docs(pii): Add comments about conditionals around sending PII data by s1gr1d · Pull Request #16143 · getsentry/sentry-javascript

s1gr1d · 2025-04-28T12:05:10Z

Based on the docs work for the issue getsentry/sentry-docs#13407, I went through the repository and looked for places where a conditional check for sendDefaultPii might be missing.

s1gr1d · 2025-04-28T14:58:24Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


I think content length is something we could send

you mean w/o sendDefaultPii === true? agreed!

s1gr1d · 2025-04-28T14:59:04Z


 const includeWithDefaultPiiApplied: RequestDataIncludeOptions = {
 ...include,
+ // todo: also exclude cookies and headers if sendDefaultPii is false


This is actually something we should do - the question is if we do this in a minor or major?

In the Http Client integration for browser, we only include the cookie data if this is explicitly enabled:
sentry-javascript/packages/browser/src/integrations/httpclient.ts
Lines 140 to 146 in 63476fa
if(_shouldSendDefaultPii()){
try{
constcookieString=xhr.getResponseHeader('Set-Cookie')||xhr.getResponseHeader('set-cookie')||undefined;
if(cookieString){
responseCookies=_parseCookieString(cookieString);
}

Agreed, we should do it but my gut feeling is to do it in a major (see review comment)

s1gr1d · 2025-04-28T15:03:38Z


 /** Get the string representation of a body. */
 export function getBodyString(body: unknown, _logger: Logger = logger): [string | undefined, NetworkMetaWarning?] {
+ // fixme: only add body string if `sendDefaultPii` is enabled?


For this, we'll just need to add maxRequestBodySize

I think this is only used in conjunction with Replay and the feature being enabled but I might be missing a case

s1gr1d · 2025-04-28T15:04:58Z

 setHttpStatus(span, response.status);
 isolationScope.setContext('response', {
- headers: response.headers.toJSON(),
+ headers: response.headers.toJSON(), // fixme: headers are passed 1:1


For all the header-related data, we need to decide on whether we want to keep sending them all, filter them by excluding e.g. authorization headers or not send them all when no PII should be sent.

Lms24

I think the data you identified should all be gated by the option (see comments). But to me it seems like we can only make this changes when we ship the next major, just so that users are more aware of the changes and they might need to set this flag.

Therefore, my overall suggestion would be to replace fixme with TODO(v10), merge this and ensure we track the change for v10.

If folks have other opinions that's fine, too. But let's make sure we avoid surprising users with data we no longer send :)

Lms24 · 2025-04-29T10:41:30Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


you mean w/o sendDefaultPii === true? agreed!

Lms24 · 2025-04-29T10:43:07Z

+ // fixme: integration can be included - but integration should not add IP address etc
 ...(options.sendDefaultPii ? [requestDataIntegration()] : []),


yeah I agree that we should handle this within the integration instead of the top-level decision here.

s1gr1d · 2025-04-28T12:05:10Z

Based on the docs work for the issue getsentry/sentry-docs#13407, I went through the repository and looked for places where a conditional check for sendDefaultPii might be missing.

s1gr1d · 2025-04-28T14:58:24Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


I think content length is something we could send

you mean w/o sendDefaultPii === true? agreed!

s1gr1d · 2025-04-28T14:59:04Z


 const includeWithDefaultPiiApplied: RequestDataIncludeOptions = {
 ...include,
+ // todo: also exclude cookies and headers if sendDefaultPii is false


This is actually something we should do - the question is if we do this in a minor or major?

In the Http Client integration for browser, we only include the cookie data if this is explicitly enabled:
sentry-javascript/packages/browser/src/integrations/httpclient.ts
Lines 140 to 146 in 63476fa
if(_shouldSendDefaultPii()){
try{
constcookieString=xhr.getResponseHeader('Set-Cookie')||xhr.getResponseHeader('set-cookie')||undefined;
if(cookieString){
responseCookies=_parseCookieString(cookieString);
}

Agreed, we should do it but my gut feeling is to do it in a major (see review comment)

s1gr1d · 2025-04-28T15:03:38Z


 /** Get the string representation of a body. */
 export function getBodyString(body: unknown, _logger: Logger = logger): [string | undefined, NetworkMetaWarning?] {
+ // fixme: only add body string if `sendDefaultPii` is enabled?


For this, we'll just need to add maxRequestBodySize

I think this is only used in conjunction with Replay and the feature being enabled but I might be missing a case

s1gr1d · 2025-04-28T15:04:58Z

 setHttpStatus(span, response.status);
 isolationScope.setContext('response', {
- headers: response.headers.toJSON(),
+ headers: response.headers.toJSON(), // fixme: headers are passed 1:1


For all the header-related data, we need to decide on whether we want to keep sending them all, filter them by excluding e.g. authorization headers or not send them all when no PII should be sent.

Lms24

I think the data you identified should all be gated by the option (see comments). But to me it seems like we can only make this changes when we ship the next major, just so that users are more aware of the changes and they might need to set this flag.

Therefore, my overall suggestion would be to replace fixme with TODO(v10), merge this and ensure we track the change for v10.

If folks have other opinions that's fine, too. But let's make sure we avoid surprising users with data we no longer send :)

Lms24 · 2025-04-29T10:41:30Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


you mean w/o sendDefaultPii === true? agreed!

Lms24 · 2025-04-29T10:43:07Z

+ // fixme: integration can be included - but integration should not add IP address etc
 ...(options.sendDefaultPii ? [requestDataIntegration()] : []),


yeah I agree that we should handle this within the integration instead of the top-level decision here.

s1gr1d · 2025-04-28T12:05:10Z

Based on the docs work for the issue getsentry/sentry-docs#13407, I went through the repository and looked for places where a conditional check for sendDefaultPii might be missing.

s1gr1d · 2025-04-28T14:58:24Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


I think content length is something we could send

you mean w/o sendDefaultPii === true? agreed!

s1gr1d · 2025-04-28T14:59:04Z


 const includeWithDefaultPiiApplied: RequestDataIncludeOptions = {
 ...include,
+ // todo: also exclude cookies and headers if sendDefaultPii is false


This is actually something we should do - the question is if we do this in a minor or major?

In the Http Client integration for browser, we only include the cookie data if this is explicitly enabled:
sentry-javascript/packages/browser/src/integrations/httpclient.ts
Lines 140 to 146 in 63476fa
if(_shouldSendDefaultPii()){
try{
constcookieString=xhr.getResponseHeader('Set-Cookie')||xhr.getResponseHeader('set-cookie')||undefined;
if(cookieString){
responseCookies=_parseCookieString(cookieString);
}

Agreed, we should do it but my gut feeling is to do it in a major (see review comment)

s1gr1d · 2025-04-28T15:03:38Z


 /** Get the string representation of a body. */
 export function getBodyString(body: unknown, _logger: Logger = logger): [string | undefined, NetworkMetaWarning?] {
+ // fixme: only add body string if `sendDefaultPii` is enabled?


For this, we'll just need to add maxRequestBodySize

I think this is only used in conjunction with Replay and the feature being enabled but I might be missing a case

s1gr1d · 2025-04-28T15:04:58Z

 setHttpStatus(span, response.status);
 isolationScope.setContext('response', {
- headers: response.headers.toJSON(),
+ headers: response.headers.toJSON(), // fixme: headers are passed 1:1


For all the header-related data, we need to decide on whether we want to keep sending them all, filter them by excluding e.g. authorization headers or not send them all when no PII should be sent.

Lms24

I think the data you identified should all be gated by the option (see comments). But to me it seems like we can only make this changes when we ship the next major, just so that users are more aware of the changes and they might need to set this flag.

Therefore, my overall suggestion would be to replace fixme with TODO(v10), merge this and ensure we track the change for v10.

If folks have other opinions that's fine, too. But let's make sure we avoid surprising users with data we no longer send :)

Lms24 · 2025-04-29T10:41:30Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


you mean w/o sendDefaultPii === true? agreed!

Lms24 · 2025-04-29T10:43:07Z

+ // fixme: integration can be included - but integration should not add IP address etc
 ...(options.sendDefaultPii ? [requestDataIntegration()] : []),


yeah I agree that we should handle this within the integration instead of the top-level decision here.

s1gr1d · 2025-04-28T12:05:10Z

Based on the docs work for the issue getsentry/sentry-docs#13407, I went through the repository and looked for places where a conditional check for sendDefaultPii might be missing.

s1gr1d · 2025-04-28T14:58:24Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


I think content length is something we could send

you mean w/o sendDefaultPii === true? agreed!

s1gr1d · 2025-04-28T14:59:04Z


 const includeWithDefaultPiiApplied: RequestDataIncludeOptions = {
 ...include,
+ // todo: also exclude cookies and headers if sendDefaultPii is false


This is actually something we should do - the question is if we do this in a minor or major?

In the Http Client integration for browser, we only include the cookie data if this is explicitly enabled:
sentry-javascript/packages/browser/src/integrations/httpclient.ts
Lines 140 to 146 in 63476fa
if(_shouldSendDefaultPii()){
try{
constcookieString=xhr.getResponseHeader('Set-Cookie')||xhr.getResponseHeader('set-cookie')||undefined;
if(cookieString){
responseCookies=_parseCookieString(cookieString);
}

Agreed, we should do it but my gut feeling is to do it in a major (see review comment)

s1gr1d · 2025-04-28T15:03:38Z


 /** Get the string representation of a body. */
 export function getBodyString(body: unknown, _logger: Logger = logger): [string | undefined, NetworkMetaWarning?] {
+ // fixme: only add body string if `sendDefaultPii` is enabled?


For this, we'll just need to add maxRequestBodySize

I think this is only used in conjunction with Replay and the feature being enabled but I might be missing a case

s1gr1d · 2025-04-28T15:04:58Z

 setHttpStatus(span, response.status);
 isolationScope.setContext('response', {
- headers: response.headers.toJSON(),
+ headers: response.headers.toJSON(), // fixme: headers are passed 1:1


For all the header-related data, we need to decide on whether we want to keep sending them all, filter them by excluding e.g. authorization headers or not send them all when no PII should be sent.

Lms24

I think the data you identified should all be gated by the option (see comments). But to me it seems like we can only make this changes when we ship the next major, just so that users are more aware of the changes and they might need to set this flag.

Therefore, my overall suggestion would be to replace fixme with TODO(v10), merge this and ensure we track the change for v10.

If folks have other opinions that's fine, too. But let's make sure we avoid surprising users with data we no longer send :)

Lms24 · 2025-04-29T10:41:30Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


you mean w/o sendDefaultPii === true? agreed!

Lms24 · 2025-04-29T10:43:07Z

+ // fixme: integration can be included - but integration should not add IP address etc
 ...(options.sendDefaultPii ? [requestDataIntegration()] : []),


yeah I agree that we should handle this within the integration instead of the top-level decision here.

s1gr1d · 2025-04-28T12:05:10Z

Based on the docs work for the issue getsentry/sentry-docs#13407, I went through the repository and looked for places where a conditional check for sendDefaultPii might be missing.

s1gr1d · 2025-04-28T14:58:24Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


I think content length is something we could send

you mean w/o sendDefaultPii === true? agreed!

s1gr1d · 2025-04-28T14:59:04Z


 const includeWithDefaultPiiApplied: RequestDataIncludeOptions = {
 ...include,
+ // todo: also exclude cookies and headers if sendDefaultPii is false


This is actually something we should do - the question is if we do this in a minor or major?

In the Http Client integration for browser, we only include the cookie data if this is explicitly enabled:
sentry-javascript/packages/browser/src/integrations/httpclient.ts
Lines 140 to 146 in 63476fa
if(_shouldSendDefaultPii()){
try{
constcookieString=xhr.getResponseHeader('Set-Cookie')||xhr.getResponseHeader('set-cookie')||undefined;
if(cookieString){
responseCookies=_parseCookieString(cookieString);
}

Agreed, we should do it but my gut feeling is to do it in a major (see review comment)

s1gr1d · 2025-04-28T15:03:38Z


 /** Get the string representation of a body. */
 export function getBodyString(body: unknown, _logger: Logger = logger): [string | undefined, NetworkMetaWarning?] {
+ // fixme: only add body string if `sendDefaultPii` is enabled?


For this, we'll just need to add maxRequestBodySize

I think this is only used in conjunction with Replay and the feature being enabled but I might be missing a case

s1gr1d · 2025-04-28T15:04:58Z

 setHttpStatus(span, response.status);
 isolationScope.setContext('response', {
- headers: response.headers.toJSON(),
+ headers: response.headers.toJSON(), // fixme: headers are passed 1:1


For all the header-related data, we need to decide on whether we want to keep sending them all, filter them by excluding e.g. authorization headers or not send them all when no PII should be sent.

Lms24

I think the data you identified should all be gated by the option (see comments). But to me it seems like we can only make this changes when we ship the next major, just so that users are more aware of the changes and they might need to set this flag.

Therefore, my overall suggestion would be to replace fixme with TODO(v10), merge this and ensure we track the change for v10.

If folks have other opinions that's fine, too. But let's make sure we avoid surprising users with data we no longer send :)

Lms24 · 2025-04-29T10:41:30Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


you mean w/o sendDefaultPii === true? agreed!

Lms24 · 2025-04-29T10:43:07Z

+ // fixme: integration can be included - but integration should not add IP address etc
 ...(options.sendDefaultPii ? [requestDataIntegration()] : []),


yeah I agree that we should handle this within the integration instead of the top-level decision here.

s1gr1d · 2025-04-28T12:05:10Z

Based on the docs work for the issue getsentry/sentry-docs#13407, I went through the repository and looked for places where a conditional check for sendDefaultPii might be missing.

s1gr1d · 2025-04-28T14:58:24Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


I think content length is something we could send

you mean w/o sendDefaultPii === true? agreed!

s1gr1d · 2025-04-28T14:59:04Z


 const includeWithDefaultPiiApplied: RequestDataIncludeOptions = {
 ...include,
+ // todo: also exclude cookies and headers if sendDefaultPii is false


This is actually something we should do - the question is if we do this in a minor or major?

In the Http Client integration for browser, we only include the cookie data if this is explicitly enabled:
sentry-javascript/packages/browser/src/integrations/httpclient.ts
Lines 140 to 146 in 63476fa
if(_shouldSendDefaultPii()){
try{
constcookieString=xhr.getResponseHeader('Set-Cookie')||xhr.getResponseHeader('set-cookie')||undefined;
if(cookieString){
responseCookies=_parseCookieString(cookieString);
}

Agreed, we should do it but my gut feeling is to do it in a major (see review comment)

s1gr1d · 2025-04-28T15:03:38Z


 /** Get the string representation of a body. */
 export function getBodyString(body: unknown, _logger: Logger = logger): [string | undefined, NetworkMetaWarning?] {
+ // fixme: only add body string if `sendDefaultPii` is enabled?


For this, we'll just need to add maxRequestBodySize

I think this is only used in conjunction with Replay and the feature being enabled but I might be missing a case

s1gr1d · 2025-04-28T15:04:58Z

 setHttpStatus(span, response.status);
 isolationScope.setContext('response', {
- headers: response.headers.toJSON(),
+ headers: response.headers.toJSON(), // fixme: headers are passed 1:1


For all the header-related data, we need to decide on whether we want to keep sending them all, filter them by excluding e.g. authorization headers or not send them all when no PII should be sent.

Lms24

I think the data you identified should all be gated by the option (see comments). But to me it seems like we can only make this changes when we ship the next major, just so that users are more aware of the changes and they might need to set this flag.

Therefore, my overall suggestion would be to replace fixme with TODO(v10), merge this and ensure we track the change for v10.

If folks have other opinions that's fine, too. But let's make sure we avoid surprising users with data we no longer send :)

Lms24 · 2025-04-29T10:41:30Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


you mean w/o sendDefaultPii === true? agreed!

Lms24 · 2025-04-29T10:43:07Z

+ // fixme: integration can be included - but integration should not add IP address etc
 ...(options.sendDefaultPii ? [requestDataIntegration()] : []),


yeah I agree that we should handle this within the integration instead of the top-level decision here.

s1gr1d · 2025-04-28T12:05:10Z

Based on the docs work for the issue getsentry/sentry-docs#13407, I went through the repository and looked for places where a conditional check for sendDefaultPii might be missing.

s1gr1d · 2025-04-28T14:58:24Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


I think content length is something we could send

you mean w/o sendDefaultPii === true? agreed!

s1gr1d · 2025-04-28T14:59:04Z


 const includeWithDefaultPiiApplied: RequestDataIncludeOptions = {
 ...include,
+ // todo: also exclude cookies and headers if sendDefaultPii is false


This is actually something we should do - the question is if we do this in a minor or major?

In the Http Client integration for browser, we only include the cookie data if this is explicitly enabled:
sentry-javascript/packages/browser/src/integrations/httpclient.ts
Lines 140 to 146 in 63476fa
if(_shouldSendDefaultPii()){
try{
constcookieString=xhr.getResponseHeader('Set-Cookie')||xhr.getResponseHeader('set-cookie')||undefined;
if(cookieString){
responseCookies=_parseCookieString(cookieString);
}

Agreed, we should do it but my gut feeling is to do it in a major (see review comment)

s1gr1d · 2025-04-28T15:03:38Z


 /** Get the string representation of a body. */
 export function getBodyString(body: unknown, _logger: Logger = logger): [string | undefined, NetworkMetaWarning?] {
+ // fixme: only add body string if `sendDefaultPii` is enabled?


For this, we'll just need to add maxRequestBodySize

I think this is only used in conjunction with Replay and the feature being enabled but I might be missing a case

s1gr1d · 2025-04-28T15:04:58Z

 setHttpStatus(span, response.status);
 isolationScope.setContext('response', {
- headers: response.headers.toJSON(),
+ headers: response.headers.toJSON(), // fixme: headers are passed 1:1


For all the header-related data, we need to decide on whether we want to keep sending them all, filter them by excluding e.g. authorization headers or not send them all when no PII should be sent.

Lms24

I think the data you identified should all be gated by the option (see comments). But to me it seems like we can only make this changes when we ship the next major, just so that users are more aware of the changes and they might need to set this flag.

Therefore, my overall suggestion would be to replace fixme with TODO(v10), merge this and ensure we track the change for v10.

If folks have other opinions that's fine, too. But let's make sure we avoid surprising users with data we no longer send :)

Lms24 · 2025-04-29T10:41:30Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


you mean w/o sendDefaultPii === true? agreed!

Lms24 · 2025-04-29T10:43:07Z

+ // fixme: integration can be included - but integration should not add IP address etc
 ...(options.sendDefaultPii ? [requestDataIntegration()] : []),


yeah I agree that we should handle this within the integration instead of the top-level decision here.

s1gr1d · 2025-04-28T12:05:10Z

Based on the docs work for the issue getsentry/sentry-docs#13407, I went through the repository and looked for places where a conditional check for sendDefaultPii might be missing.

s1gr1d · 2025-04-28T14:58:24Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


I think content length is something we could send

you mean w/o sendDefaultPii === true? agreed!

s1gr1d · 2025-04-28T14:59:04Z


 const includeWithDefaultPiiApplied: RequestDataIncludeOptions = {
 ...include,
+ // todo: also exclude cookies and headers if sendDefaultPii is false


This is actually something we should do - the question is if we do this in a minor or major?

In the Http Client integration for browser, we only include the cookie data if this is explicitly enabled:
sentry-javascript/packages/browser/src/integrations/httpclient.ts
Lines 140 to 146 in 63476fa
if(_shouldSendDefaultPii()){
try{
constcookieString=xhr.getResponseHeader('Set-Cookie')||xhr.getResponseHeader('set-cookie')||undefined;
if(cookieString){
responseCookies=_parseCookieString(cookieString);
}

Agreed, we should do it but my gut feeling is to do it in a major (see review comment)

s1gr1d · 2025-04-28T15:03:38Z


 /** Get the string representation of a body. */
 export function getBodyString(body: unknown, _logger: Logger = logger): [string | undefined, NetworkMetaWarning?] {
+ // fixme: only add body string if `sendDefaultPii` is enabled?


For this, we'll just need to add maxRequestBodySize

I think this is only used in conjunction with Replay and the feature being enabled but I might be missing a case

s1gr1d · 2025-04-28T15:04:58Z

 setHttpStatus(span, response.status);
 isolationScope.setContext('response', {
- headers: response.headers.toJSON(),
+ headers: response.headers.toJSON(), // fixme: headers are passed 1:1


For all the header-related data, we need to decide on whether we want to keep sending them all, filter them by excluding e.g. authorization headers or not send them all when no PII should be sent.

Lms24

I think the data you identified should all be gated by the option (see comments). But to me it seems like we can only make this changes when we ship the next major, just so that users are more aware of the changes and they might need to set this flag.

Therefore, my overall suggestion would be to replace fixme with TODO(v10), merge this and ensure we track the change for v10.

If folks have other opinions that's fine, too. But let's make sure we avoid surprising users with data we no longer send :)

Lms24 · 2025-04-29T10:41:30Z

 if (handlerData.response) {
 setHttpStatus(span, handlerData.response.status);

+ // fixme: only send if `sendDefaultPii`?


you mean w/o sendDefaultPii === true? agreed!

Lms24 · 2025-04-29T10:43:07Z

+ // fixme: integration can be included - but integration should not add IP address etc
 ...(options.sendDefaultPii ? [requestDataIntegration()] : []),


yeah I agree that we should handle this within the integration instead of the top-level decision here.

add todo/fixme comments
07618a8

s1gr1d commented Apr 28, 2025
View reviewed changes

Lms24 reviewed Apr 29, 2025
View reviewed changes

s1gr1d mentioned this pull request Apr 29, 2025
feat(javascript): Add "Data Collected" getsentry/sentry-docs#13527
Merged
6 tasks

s1gr1d added 3 commits April 30, 2025 12:22

add comment
8252444

add todos for v10
f2fdc65

delete unnecessary comments
b3d6025

s1gr1d marked this pull request as ready for review April 30, 2025 15:48

s1gr1d requested a review from a team as a code owner April 30, 2025 15:48

s1gr1d requested a review from Lms24 April 30, 2025 15:48

Lms24 approved these changes Apr 30, 2025
View reviewed changes

s1gr1d changed the title ~~fix(pii): Add more conditionals around sending data~~docs(pii): Add comments about conditionals around sending PII dataMay 5, 2025

s1gr1d merged commit 4d46e53 into developMay 5, 2025

s1gr1d deleted the sig/defaultPii-standardize branch May 5, 2025 08:15

add todo/fixme comments
07618a8

s1gr1d commented Apr 28, 2025
View reviewed changes

Lms24 reviewed Apr 29, 2025
View reviewed changes

s1gr1d mentioned this pull request Apr 29, 2025
feat(javascript): Add "Data Collected" getsentry/sentry-docs#13527
Merged
6 tasks

s1gr1d added 3 commits April 30, 2025 12:22

add comment
8252444

add todos for v10
f2fdc65

delete unnecessary comments
b3d6025

s1gr1d marked this pull request as ready for review April 30, 2025 15:48

s1gr1d requested a review from a team as a code owner April 30, 2025 15:48

s1gr1d requested a review from Lms24 April 30, 2025 15:48

Lms24 approved these changes Apr 30, 2025
View reviewed changes

s1gr1d changed the title ~~fix(pii): Add more conditionals around sending data~~docs(pii): Add comments about conditionals around sending PII dataMay 5, 2025

s1gr1d merged commit 4d46e53 into developMay 5, 2025

s1gr1d deleted the sig/defaultPii-standardize branch May 5, 2025 08:15

add todo/fixme comments
07618a8

s1gr1d commented Apr 28, 2025
View reviewed changes

Lms24 reviewed Apr 29, 2025
View reviewed changes

s1gr1d mentioned this pull request Apr 29, 2025
feat(javascript): Add "Data Collected" getsentry/sentry-docs#13527
Merged
6 tasks

s1gr1d added 3 commits April 30, 2025 12:22

add comment
8252444

add todos for v10
f2fdc65

delete unnecessary comments
b3d6025

s1gr1d marked this pull request as ready for review April 30, 2025 15:48

s1gr1d requested a review from a team as a code owner April 30, 2025 15:48

s1gr1d requested a review from Lms24 April 30, 2025 15:48

Lms24 approved these changes Apr 30, 2025
View reviewed changes

s1gr1d changed the title ~~fix(pii): Add more conditionals around sending data~~docs(pii): Add comments about conditionals around sending PII dataMay 5, 2025

s1gr1d merged commit 4d46e53 into developMay 5, 2025

s1gr1d deleted the sig/defaultPii-standardize branch May 5, 2025 08:15

add todo/fixme comments
07618a8

s1gr1d commented Apr 28, 2025
View reviewed changes

Lms24 reviewed Apr 29, 2025
View reviewed changes

s1gr1d mentioned this pull request Apr 29, 2025
feat(javascript): Add "Data Collected" getsentry/sentry-docs#13527
Merged
6 tasks

s1gr1d added 3 commits April 30, 2025 12:22

add comment
8252444

add todos for v10
f2fdc65

delete unnecessary comments
b3d6025

s1gr1d marked this pull request as ready for review April 30, 2025 15:48

s1gr1d requested a review from a team as a code owner April 30, 2025 15:48

s1gr1d requested a review from Lms24 April 30, 2025 15:48

Lms24 approved these changes Apr 30, 2025
View reviewed changes

s1gr1d changed the title ~~fix(pii): Add more conditionals around sending data~~docs(pii): Add comments about conditionals around sending PII dataMay 5, 2025

s1gr1d merged commit 4d46e53 into developMay 5, 2025

s1gr1d deleted the sig/defaultPii-standardize branch May 5, 2025 08:15

add todo/fixme comments
07618a8

s1gr1d commented Apr 28, 2025
View reviewed changes

Lms24 reviewed Apr 29, 2025
View reviewed changes

s1gr1d mentioned this pull request Apr 29, 2025
feat(javascript): Add "Data Collected" getsentry/sentry-docs#13527
Merged
6 tasks

s1gr1d added 3 commits April 30, 2025 12:22

add comment
8252444

add todos for v10
f2fdc65

delete unnecessary comments
b3d6025

s1gr1d marked this pull request as ready for review April 30, 2025 15:48

s1gr1d requested a review from a team as a code owner April 30, 2025 15:48

s1gr1d requested a review from Lms24 April 30, 2025 15:48

Lms24 approved these changes Apr 30, 2025
View reviewed changes

s1gr1d changed the title ~~fix(pii): Add more conditionals around sending data~~docs(pii): Add comments about conditionals around sending PII dataMay 5, 2025

s1gr1d merged commit 4d46e53 into developMay 5, 2025

s1gr1d deleted the sig/defaultPii-standardize branch May 5, 2025 08:15

add todo/fixme comments
07618a8

s1gr1d commented Apr 28, 2025
View reviewed changes

Lms24 reviewed Apr 29, 2025
View reviewed changes

s1gr1d mentioned this pull request Apr 29, 2025
feat(javascript): Add "Data Collected" getsentry/sentry-docs#13527
Merged
6 tasks

s1gr1d added 3 commits April 30, 2025 12:22

add comment
8252444

add todos for v10
f2fdc65

delete unnecessary comments
b3d6025

s1gr1d marked this pull request as ready for review April 30, 2025 15:48

s1gr1d requested a review from a team as a code owner April 30, 2025 15:48

s1gr1d requested a review from Lms24 April 30, 2025 15:48

Lms24 approved these changes Apr 30, 2025
View reviewed changes

s1gr1d changed the title ~~fix(pii): Add more conditionals around sending data~~docs(pii): Add comments about conditionals around sending PII dataMay 5, 2025

s1gr1d merged commit 4d46e53 into developMay 5, 2025

s1gr1d deleted the sig/defaultPii-standardize branch May 5, 2025 08:15

add todo/fixme comments
07618a8

s1gr1d commented Apr 28, 2025
View reviewed changes

Lms24 reviewed Apr 29, 2025
View reviewed changes

s1gr1d mentioned this pull request Apr 29, 2025
feat(javascript): Add "Data Collected" getsentry/sentry-docs#13527
Merged
6 tasks

s1gr1d added 3 commits April 30, 2025 12:22

add comment
8252444

add todos for v10
f2fdc65

delete unnecessary comments
b3d6025

s1gr1d marked this pull request as ready for review April 30, 2025 15:48

s1gr1d requested a review from a team as a code owner April 30, 2025 15:48

s1gr1d requested a review from Lms24 April 30, 2025 15:48

Lms24 approved these changes Apr 30, 2025
View reviewed changes

s1gr1d changed the title ~~fix(pii): Add more conditionals around sending data~~docs(pii): Add comments about conditionals around sending PII dataMay 5, 2025

s1gr1d merged commit 4d46e53 into developMay 5, 2025

s1gr1d deleted the sig/defaultPii-standardize branch May 5, 2025 08:15

add todo/fixme comments
07618a8

s1gr1d commented Apr 28, 2025
View reviewed changes

Lms24 reviewed Apr 29, 2025
View reviewed changes

s1gr1d mentioned this pull request Apr 29, 2025
feat(javascript): Add "Data Collected" getsentry/sentry-docs#13527
Merged
6 tasks

s1gr1d added 3 commits April 30, 2025 12:22

add comment
8252444

add todos for v10
f2fdc65

delete unnecessary comments
b3d6025

s1gr1d marked this pull request as ready for review April 30, 2025 15:48

s1gr1d requested a review from a team as a code owner April 30, 2025 15:48

s1gr1d requested a review from Lms24 April 30, 2025 15:48

Lms24 approved these changes Apr 30, 2025
View reviewed changes

s1gr1d changed the title ~~fix(pii): Add more conditionals around sending data~~docs(pii): Add comments about conditionals around sending PII dataMay 5, 2025

s1gr1d merged commit 4d46e53 into developMay 5, 2025

s1gr1d deleted the sig/defaultPii-standardize branch May 5, 2025 08:15

	if(_shouldSendDefaultPii()){
	try{
	constcookieString=xhr.getResponseHeader('Set-Cookie')\|\|xhr.getResponseHeader('set-cookie')\|\|undefined;

	if(cookieString){
	responseCookies=_parseCookieString(cookieString);
	}

		// fixme: integration can be included - but integration should not add IP address etc
		...(options.sendDefaultPii ? [requestDataIntegration()] : []),

Uh oh!

Uh oh!

Conversation

s1gr1d commented Apr 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

s1gr1d commented Apr 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lms24Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

s1gr1d commented Apr 28, 2025

Lms24Apr 29, 2025•
edited
Loading

Lms24Apr 29, 2025•
edited
Loading

Lms24Apr 29, 2025•
edited
Loading