test(node): Add utility to test esm & cjs instrumentation#16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 15 commits into from
Apr 30, 2025
Merged

test(node): Add utility to test esm & cjs instrumentation #16159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c9a0e08
test(node): Add utility to test esm & cjs instrumentation
mydea Apr 28, 2025
88eee44
add more tests
mydea Apr 29, 2025
fb38aed
WIP
mydea Apr 30, 2025
6d1a73c
update ai test
mydea Apr 30, 2025
4e41faf
update timeout
mydea Apr 30, 2025
68ac69e
increase anr timeout
mydea Apr 30, 2025
616c391
rename to failsOnEsm
mydea Apr 30, 2025
68d0733
genericPool
mydea Apr 30, 2025
d058fa8
httpIntegration
mydea Apr 30, 2025
05e2692
kafkajs
mydea Apr 30, 2025
1175539
always create files even if cjs is skipped
mydea Apr 30, 2025
fffc2c2
remove one level of nesting of describe calls
mydea Apr 30, 2025
3d9ce14
knex
mydea Apr 30, 2025
410cecf
cleanup unneeded comments/vars
mydea Apr 30, 2025
2804ee5
move cjs creation to beforeAll
mydea Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dev-packages/node-integration-tests/.eslintrc.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ module.exports = {
},
},
{
files: ['suites/**/*.ts'],
files: ['suites/**/*.ts', 'suites/**/*.mjs'],
parserOptions: {
project: ['tsconfig.test.json'],
sourceType: 'module',
ecmaVersion: 'latest',
},
rules: {
'@typescript-eslint/typedef': 'off',
Expand Down
1 change: 1 addition & 0 deletions dev-packages/node-integration-tests/.gitignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
suites/**/tmp_*
3 changes: 1 addition & 2 deletions dev-packages/node-integration-tests/suites/anr/app-path.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';
import * as path from 'path';
import * as url from 'url';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
Expand Down
3 changes: 1 addition & 2 deletions dev-packages/node-integration-tests/suites/anr/basic-multiple.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down
3 changes: 1 addition & 2 deletions dev-packages/node-integration-tests/suites/anr/basic.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down
3 changes: 1 addition & 2 deletions dev-packages/node-integration-tests/suites/anr/indefinite.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
process.exit();
}, 10000);
Expand Down
3 changes: 1 addition & 2 deletions dev-packages/node-integration-tests/suites/anr/isolated.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
process.exit();
}, 10000);
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/node-integration-tests/suites/anr/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,7 +107,7 @@ const ANR_EVENT_WITH_DEBUG_META: Event = {
},
};

describe('should report ANR when event loop blocked', { timeout: 60_000 }, () => {
describe('should report ANR when event loop blocked', { timeout: 90_000 }, () => {

@mydeamydeaApr 30, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but this flaked some times, let's see if this helps...

afterAll(() => {
cleanupChildProcesses();
});
Expand Down
28 changes: 15 additions & 13 deletions dev-packages/node-integration-tests/suites/breadcrumbs/process-thread/app.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { spawn } from 'child_process';
import { join } from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -13,16 +13,18 @@ Sentry.init({
transport: loggingTransport,
});

await new Promise(resolve => {
const child = spawn('sleep', ['a']);
child.on('error', resolve);
child.on('exit', resolve);
});
(async () => {
await new Promise(resolve => {
const child = spawn('sleep', ['a']);
child.on('error', resolve);
child.on('exit', resolve);
});

await new Promise(resolve => {
const worker = new Worker(join(__dirname, 'worker.mjs'));
worker.on('error', resolve);
worker.on('exit', resolve);
});
await new Promise(resolve => {
const worker = new Worker(join(__dirname, 'worker.mjs'));
worker.on('error', resolve);
worker.on('exit', resolve);
});

throw new Error('This is a test error');
throw new Error('This is a test error');
})();
3 changes: 1 addition & 2 deletions dev-packages/node-integration-tests/suites/child-process/fork.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
throw new Error('Exiting main process');
Expand Down
6 changes: 3 additions & 3 deletions dev-packages/node-integration-tests/suites/child-process/fork.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { fork } from 'child_process';
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

const __dirname = new URL('.', import.meta.url).pathname;

Expand All@@ -12,7 +12,7 @@ Sentry.init({
transport: loggingTransport,
});

const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
throw new Error('Exiting main process');
Expand Down
3 changes: 1 addition & 2 deletions dev-packages/node-integration-tests/suites/child-process/worker.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _worker = new Worker(path.join(__dirname, 'child.js'));
new Worker(path.join(__dirname, 'child.js'));

setTimeout(() => {
process.exit();
Expand Down
6 changes: 3 additions & 3 deletions dev-packages/node-integration-tests/suites/child-process/worker.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as path from 'path';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -12,7 +12,7 @@ Sentry.init({
transport: loggingTransport,
});

const _worker = new Worker(path.join(__dirname, 'child.mjs'));
new Worker(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
process.exit();
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/instrument.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ describe('ContextLines integration in ESM', () => {
const instrumentPath = join(__dirname, 'instrument.mjs');

await createRunner(__dirname, 'scenario with space.mjs')
.withFlags('--import', instrumentPath)
.withInstrument(instrumentPath)
.expect({
event: {
exception: {
Expand Down
10 changes: 6 additions & 4 deletions dev-packages/node-integration-tests/suites/esm/import-in-the-middle/app.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as iitm from 'import-in-the-middle';

new iitm.Hook((_, name) => {
Expand All@@ -14,6 +14,8 @@ Sentry.init({
transport: loggingTransport,
});

await import('./sub-module.mjs');
await import('http');
await import('os');
(async () => {
await import('./sub-module.mjs');
await import('http');
await import('os');
})();
2 changes: 1 addition & 1 deletion dev-packages/node-integration-tests/suites/esm/modules-integration/app.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down
6 changes: 2 additions & 4 deletions dev-packages/node-integration-tests/suites/esm/warn-esm/server.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
});

import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

const app = express();

app.get('/test/success', (req, res) => {
Expand Down
0 ...tion-tests/suites/tracing/amqplib/init.ts → ...s/suites/express/with-http/instrument.mjs
View file
Open in desktop
File renamed without changes.
28 changes: 28 additions & 0 deletions dev-packages/node-integration-tests/suites/express/with-http/scenario.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import * as Sentry from '@sentry/node';
import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';
import http from 'http';

const app = express();

app.get('/test', (_req, res) => {
http.get(`http://localhost:${app.port}/test2`, httpRes => {
httpRes.on('data', () => {
setTimeout(() => {
res.send({ response: 'response 1' });
}, 200);
});
});
});

app.get('/test2', (_req, res) => {
res.send({ response: 'response 2' });
});

app.get('/test3', (_req, res) => {
res.send({ response: 'response 3' });
});

Sentry.setupExpressErrorHandler(app);

startExpressServerAndSendPortToRunner(app);
41 changes: 41 additions & 0 deletions dev-packages/node-integration-tests/suites/express/with-http/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
import { afterAll, describe } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

describe('express with http import', () => {
afterAll(() => {
cleanupChildProcesses();
});

createEsmAndCjsTests(
__dirname,
'scenario.mjs',
'instrument.mjs',
(createRunner, test) => {
test('it works when importing the http module', async () => {
const runner = createRunner()
.expect({
transaction: {
transaction: 'GET /test2',
},
})
.expect({
transaction: {
transaction: 'GET /test',
},
})
.expect({
transaction: {
transaction: 'GET /test3',
},
})
.start();
await runner.makeRequest('get', '/test');
await runner.makeRequest('get', '/test3');
await runner.completed();
});
// TODO: This is failing on ESM because importing http is triggering the http spans twice :(
// We need to fix this!
},
{ failsOnEsm: true },
);
});
10 changes: 4 additions & 6 deletions dev-packages/node-integration-tests/suites/public-api/LocalVariables/deny-inspector.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
import { register } from 'node:module';

const hookScript = Buffer.from(`

`);

register(
new URL(`data:application/javascript,
export async function resolve(specifier, context, nextResolve) {
Expand All@@ -16,6 +12,8 @@ export async function resolve(specifier, context, nextResolve) {
import.meta.url,
);

const Sentry = await import('@sentry/node');
(async () => {
const Sentry = await import('@sentry/node');

Sentry.init({});
Sentry.init({});
})();
2 changes: 1 addition & 1 deletion ...ckages/node-integration-tests/suites/public-api/LocalVariables/local-variables-caught.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-unused-vars */
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down
58 changes: 0 additions & 58 deletions dev-packages/node-integration-tests/suites/tracing/ai/scenario.js
View file
Open in desktop

This file was deleted.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test(node): Add utility to test esm & cjs instrumentation#16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 15 commits into

from

Apr 30, 2025
 Merged


test(node): Add utility to test esm & cjs instrumentation
#16159
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


15 commits


Select commit
Hold shift + click to select a range
c9a0e08

test(node): Add utility to test esm & cjs instrumentation


mydea Apr 28, 2025
88eee44

add more tests


mydea Apr 29, 2025
fb38aed

WIP


mydea Apr 30, 2025
6d1a73c

update ai test


mydea Apr 30, 2025
4e41faf

update timeout


mydea Apr 30, 2025
68ac69e

increase anr timeout


mydea Apr 30, 2025
616c391

rename to failsOnEsm


mydea Apr 30, 2025
68d0733

genericPool


mydea Apr 30, 2025
d058fa8

httpIntegration


mydea Apr 30, 2025
05e2692

kafkajs


mydea Apr 30, 2025
1175539

always create files even if cjs is skipped


mydea Apr 30, 2025
fffc2c2

remove one level of nesting of describe calls


mydea Apr 30, 2025
3d9ce14

knex


mydea Apr 30, 2025
410cecf

cleanup unneeded comments/vars


mydea Apr 30, 2025
2804ee5

move cjs creation to beforeAll


mydea Apr 30, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 2 additions & 1 deletion
dev-packages/node-integration-tests/.eslintrc.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ module.exports = {
 },
 },
 {
 files: ['suites/**/*.ts'],
 files: ['suites/**/*.ts', 'suites/**/*.mjs'],
 parserOptions: {
 project: ['tsconfig.test.json'],
 sourceType: 'module',
 ecmaVersion: 'latest',
 },
 rules: {
 '@typescript-eslint/typedef': 'off',
Expand Down

1 change: 1 addition & 0 deletions
dev-packages/node-integration-tests/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
suites/**/tmp_*

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/app-path.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';
import * as path from 'path';
import * as url from 'url';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic-multiple.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/indefinite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/isolated.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/anr/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -107,7 +107,7 @@ const ANR_EVENT_WITH_DEBUG_META: Event = {
 },
};

describe('should report ANR when event loop blocked', { timeout: 60_000 }, () => {
describe('should report ANR when event loop blocked', { timeout: 90_000 }, () => {
@mydeamydeaApr 30, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but this flaked some times, let's see if this helps...
 afterAll(() => {
 cleanupChildProcesses();
 });
Expand Down

28 changes: 15 additions & 13 deletions
dev-packages/node-integration-tests/suites/breadcrumbs/process-thread/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { spawn } from 'child_process';
import { join } from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -13,16 +13,18 @@ Sentry.init({
 transport: loggingTransport,
});

await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
});
(async () => {
 await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
 });

await new Promise(resolve => {
 const worker = new Worker(join(__dirname, 'worker.mjs'));
 worker.on('error', resolve);
 worker.on('exit', resolve);
});
await new Promise(resolve => {
const worker = new Worker(join(__dirname, 'worker.mjs'));
worker.on('error', resolve);
worker.on('exit', resolve);
});

throw new Error('This is a test error');
 throw new Error('This is a test error');
})();

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/fork.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/fork.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { fork } from 'child_process';
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

const __dirname = new URL('.', import.meta.url).pathname;

Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/worker.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _worker = new Worker(path.join(__dirname, 'child.js'));
new Worker(path.join(__dirname, 'child.js'));

setTimeout(() => {
 process.exit();
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/worker.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as path from 'path';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _worker = new Worker(path.join(__dirname, 'child.mjs'));
new Worker(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 process.exit();
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/instrument.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ describe('ContextLines integration in ESM', () => {
 const instrumentPath = join(__dirname, 'instrument.mjs');

 await createRunner(__dirname, 'scenario with space.mjs')
 .withFlags('--import', instrumentPath)
 .withInstrument(instrumentPath)
 .expect({
 event: {
 exception: {
Expand Down

10 changes: 6 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/import-in-the-middle/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as iitm from 'import-in-the-middle';

new iitm.Hook((_, name) => {
Expand All@@ -14,6 +14,8 @@ Sentry.init({
 transport: loggingTransport,
});

await import('./sub-module.mjs');
await import('http');
await import('os');
(async () => {
 await import('./sub-module.mjs');
 await import('http');
 await import('os');
})();

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/esm/modules-integration/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

6 changes: 2 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/warn-esm/server.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 release: '1.0',
 transport: loggingTransport,
});

import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

const app = express();

app.get('/test/success', (req, res) => {
Expand Down

0
...tion-tests/suites/tracing/amqplib/init.ts → ...s/suites/express/with-http/instrument.mjs

View file


Open in desktop


File renamed without changes.


28 changes: 28 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/scenario.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import * as Sentry from '@sentry/node';
import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';
import http from 'http';

const app = express();

app.get('/test', (_req, res) => {
 http.get(`http://localhost:${app.port}/test2`, httpRes => {
 httpRes.on('data', () => {
 setTimeout(() => {
 res.send({ response: 'response 1' });
 }, 200);
 });
 });
});

app.get('/test2', (_req, res) => {
 res.send({ response: 'response 2' });
});

app.get('/test3', (_req, res) => {
 res.send({ response: 'response 3' });
});

Sentry.setupExpressErrorHandler(app);

startExpressServerAndSendPortToRunner(app);

41 changes: 41 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
import { afterAll, describe } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

describe('express with http import', () => {
 afterAll(() => {
 cleanupChildProcesses();
 });

 createEsmAndCjsTests(
 __dirname,
 'scenario.mjs',
 'instrument.mjs',
 (createRunner, test) => {
 test('it works when importing the http module', async () => {
 const runner = createRunner()
 .expect({
 transaction: {
 transaction: 'GET /test2',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test3',
 },
 })
 .start();
 await runner.makeRequest('get', '/test');
 await runner.makeRequest('get', '/test3');
 await runner.completed();
 });
 // TODO: This is failing on ESM because importing http is triggering the http spans twice :(
 // We need to fix this!
 },
 { failsOnEsm: true },
 );
});

10 changes: 4 additions & 6 deletions
dev-packages/node-integration-tests/suites/public-api/LocalVariables/deny-inspector.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
import { register } from 'node:module';

const hookScript = Buffer.from(`

 `);

register(
 new URL(`data:application/javascript,
export async function resolve(specifier, context, nextResolve) {
Expand All@@ -16,6 +12,8 @@ export async function resolve(specifier, context, nextResolve) {
 import.meta.url,
);

const Sentry = await import('@sentry/node');
(async () => {
 const Sentry = await import('@sentry/node');

Sentry.init({});
 Sentry.init({});
})();

2 changes: 1 addition & 1 deletion
...ckages/node-integration-tests/suites/public-api/LocalVariables/local-variables-caught.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-unused-vars */
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

58 changes: 0 additions & 58 deletions
dev-packages/node-integration-tests/suites/tracing/ai/scenario.js

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(node): Add utility to test esm & cjs instrumentation#16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 15 commits into

from

Apr 30, 2025
 Merged


test(node): Add utility to test esm & cjs instrumentation
#16159
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


15 commits


Select commit
Hold shift + click to select a range
c9a0e08

test(node): Add utility to test esm & cjs instrumentation


mydea Apr 28, 2025
88eee44

add more tests


mydea Apr 29, 2025
fb38aed

WIP


mydea Apr 30, 2025
6d1a73c

update ai test


mydea Apr 30, 2025
4e41faf

update timeout


mydea Apr 30, 2025
68ac69e

increase anr timeout


mydea Apr 30, 2025
616c391

rename to failsOnEsm


mydea Apr 30, 2025
68d0733

genericPool


mydea Apr 30, 2025
d058fa8

httpIntegration


mydea Apr 30, 2025
05e2692

kafkajs


mydea Apr 30, 2025
1175539

always create files even if cjs is skipped


mydea Apr 30, 2025
fffc2c2

remove one level of nesting of describe calls


mydea Apr 30, 2025
3d9ce14

knex


mydea Apr 30, 2025
410cecf

cleanup unneeded comments/vars


mydea Apr 30, 2025
2804ee5

move cjs creation to beforeAll


mydea Apr 30, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 2 additions & 1 deletion
dev-packages/node-integration-tests/.eslintrc.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ module.exports = {
 },
 },
 {
 files: ['suites/**/*.ts'],
 files: ['suites/**/*.ts', 'suites/**/*.mjs'],
 parserOptions: {
 project: ['tsconfig.test.json'],
 sourceType: 'module',
 ecmaVersion: 'latest',
 },
 rules: {
 '@typescript-eslint/typedef': 'off',
Expand Down

1 change: 1 addition & 0 deletions
dev-packages/node-integration-tests/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
suites/**/tmp_*

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/app-path.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';
import * as path from 'path';
import * as url from 'url';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic-multiple.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/indefinite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/isolated.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/anr/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -107,7 +107,7 @@ const ANR_EVENT_WITH_DEBUG_META: Event = {
 },
};

describe('should report ANR when event loop blocked', { timeout: 60_000 }, () => {
describe('should report ANR when event loop blocked', { timeout: 90_000 }, () => {
@mydeamydeaApr 30, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but this flaked some times, let's see if this helps...
 afterAll(() => {
 cleanupChildProcesses();
 });
Expand Down

28 changes: 15 additions & 13 deletions
dev-packages/node-integration-tests/suites/breadcrumbs/process-thread/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { spawn } from 'child_process';
import { join } from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -13,16 +13,18 @@ Sentry.init({
 transport: loggingTransport,
});

await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
});
(async () => {
 await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
 });

await new Promise(resolve => {
 const worker = new Worker(join(__dirname, 'worker.mjs'));
 worker.on('error', resolve);
 worker.on('exit', resolve);
});
await new Promise(resolve => {
const worker = new Worker(join(__dirname, 'worker.mjs'));
worker.on('error', resolve);
worker.on('exit', resolve);
});

throw new Error('This is a test error');
 throw new Error('This is a test error');
})();

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/fork.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/fork.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { fork } from 'child_process';
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

const __dirname = new URL('.', import.meta.url).pathname;

Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/worker.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _worker = new Worker(path.join(__dirname, 'child.js'));
new Worker(path.join(__dirname, 'child.js'));

setTimeout(() => {
 process.exit();
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/worker.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as path from 'path';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _worker = new Worker(path.join(__dirname, 'child.mjs'));
new Worker(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 process.exit();
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/instrument.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ describe('ContextLines integration in ESM', () => {
 const instrumentPath = join(__dirname, 'instrument.mjs');

 await createRunner(__dirname, 'scenario with space.mjs')
 .withFlags('--import', instrumentPath)
 .withInstrument(instrumentPath)
 .expect({
 event: {
 exception: {
Expand Down

10 changes: 6 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/import-in-the-middle/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as iitm from 'import-in-the-middle';

new iitm.Hook((_, name) => {
Expand All@@ -14,6 +14,8 @@ Sentry.init({
 transport: loggingTransport,
});

await import('./sub-module.mjs');
await import('http');
await import('os');
(async () => {
 await import('./sub-module.mjs');
 await import('http');
 await import('os');
})();

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/esm/modules-integration/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

6 changes: 2 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/warn-esm/server.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 release: '1.0',
 transport: loggingTransport,
});

import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

const app = express();

app.get('/test/success', (req, res) => {
Expand Down

0
...tion-tests/suites/tracing/amqplib/init.ts → ...s/suites/express/with-http/instrument.mjs

View file


Open in desktop


File renamed without changes.


28 changes: 28 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/scenario.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import * as Sentry from '@sentry/node';
import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';
import http from 'http';

const app = express();

app.get('/test', (_req, res) => {
 http.get(`http://localhost:${app.port}/test2`, httpRes => {
 httpRes.on('data', () => {
 setTimeout(() => {
 res.send({ response: 'response 1' });
 }, 200);
 });
 });
});

app.get('/test2', (_req, res) => {
 res.send({ response: 'response 2' });
});

app.get('/test3', (_req, res) => {
 res.send({ response: 'response 3' });
});

Sentry.setupExpressErrorHandler(app);

startExpressServerAndSendPortToRunner(app);

41 changes: 41 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
import { afterAll, describe } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

describe('express with http import', () => {
 afterAll(() => {
 cleanupChildProcesses();
 });

 createEsmAndCjsTests(
 __dirname,
 'scenario.mjs',
 'instrument.mjs',
 (createRunner, test) => {
 test('it works when importing the http module', async () => {
 const runner = createRunner()
 .expect({
 transaction: {
 transaction: 'GET /test2',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test3',
 },
 })
 .start();
 await runner.makeRequest('get', '/test');
 await runner.makeRequest('get', '/test3');
 await runner.completed();
 });
 // TODO: This is failing on ESM because importing http is triggering the http spans twice :(
 // We need to fix this!
 },
 { failsOnEsm: true },
 );
});

10 changes: 4 additions & 6 deletions
dev-packages/node-integration-tests/suites/public-api/LocalVariables/deny-inspector.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
import { register } from 'node:module';

const hookScript = Buffer.from(`

 `);

register(
 new URL(`data:application/javascript,
export async function resolve(specifier, context, nextResolve) {
Expand All@@ -16,6 +12,8 @@ export async function resolve(specifier, context, nextResolve) {
 import.meta.url,
);

const Sentry = await import('@sentry/node');
(async () => {
 const Sentry = await import('@sentry/node');

Sentry.init({});
 Sentry.init({});
})();

2 changes: 1 addition & 1 deletion
...ckages/node-integration-tests/suites/public-api/LocalVariables/local-variables-caught.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-unused-vars */
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

58 changes: 0 additions & 58 deletions
dev-packages/node-integration-tests/suites/tracing/ai/scenario.js

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(node): Add utility to test esm & cjs instrumentation#16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 15 commits into

from

Apr 30, 2025
 Merged


test(node): Add utility to test esm & cjs instrumentation
#16159
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


15 commits


Select commit
Hold shift + click to select a range
c9a0e08

test(node): Add utility to test esm & cjs instrumentation


mydea Apr 28, 2025
88eee44

add more tests


mydea Apr 29, 2025
fb38aed

WIP


mydea Apr 30, 2025
6d1a73c

update ai test


mydea Apr 30, 2025
4e41faf

update timeout


mydea Apr 30, 2025
68ac69e

increase anr timeout


mydea Apr 30, 2025
616c391

rename to failsOnEsm


mydea Apr 30, 2025
68d0733

genericPool


mydea Apr 30, 2025
d058fa8

httpIntegration


mydea Apr 30, 2025
05e2692

kafkajs


mydea Apr 30, 2025
1175539

always create files even if cjs is skipped


mydea Apr 30, 2025
fffc2c2

remove one level of nesting of describe calls


mydea Apr 30, 2025
3d9ce14

knex


mydea Apr 30, 2025
410cecf

cleanup unneeded comments/vars


mydea Apr 30, 2025
2804ee5

move cjs creation to beforeAll


mydea Apr 30, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 2 additions & 1 deletion
dev-packages/node-integration-tests/.eslintrc.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ module.exports = {
 },
 },
 {
 files: ['suites/**/*.ts'],
 files: ['suites/**/*.ts', 'suites/**/*.mjs'],
 parserOptions: {
 project: ['tsconfig.test.json'],
 sourceType: 'module',
 ecmaVersion: 'latest',
 },
 rules: {
 '@typescript-eslint/typedef': 'off',
Expand Down

1 change: 1 addition & 0 deletions
dev-packages/node-integration-tests/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
suites/**/tmp_*

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/app-path.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';
import * as path from 'path';
import * as url from 'url';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic-multiple.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/indefinite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/isolated.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/anr/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -107,7 +107,7 @@ const ANR_EVENT_WITH_DEBUG_META: Event = {
 },
};

describe('should report ANR when event loop blocked', { timeout: 60_000 }, () => {
describe('should report ANR when event loop blocked', { timeout: 90_000 }, () => {
@mydeamydeaApr 30, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but this flaked some times, let's see if this helps...
 afterAll(() => {
 cleanupChildProcesses();
 });
Expand Down

28 changes: 15 additions & 13 deletions
dev-packages/node-integration-tests/suites/breadcrumbs/process-thread/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { spawn } from 'child_process';
import { join } from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -13,16 +13,18 @@ Sentry.init({
 transport: loggingTransport,
});

await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
});
(async () => {
 await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
 });

await new Promise(resolve => {
 const worker = new Worker(join(__dirname, 'worker.mjs'));
 worker.on('error', resolve);
 worker.on('exit', resolve);
});
await new Promise(resolve => {
const worker = new Worker(join(__dirname, 'worker.mjs'));
worker.on('error', resolve);
worker.on('exit', resolve);
});

throw new Error('This is a test error');
 throw new Error('This is a test error');
})();

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/fork.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/fork.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { fork } from 'child_process';
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

const __dirname = new URL('.', import.meta.url).pathname;

Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/worker.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _worker = new Worker(path.join(__dirname, 'child.js'));
new Worker(path.join(__dirname, 'child.js'));

setTimeout(() => {
 process.exit();
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/worker.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as path from 'path';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _worker = new Worker(path.join(__dirname, 'child.mjs'));
new Worker(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 process.exit();
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/instrument.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ describe('ContextLines integration in ESM', () => {
 const instrumentPath = join(__dirname, 'instrument.mjs');

 await createRunner(__dirname, 'scenario with space.mjs')
 .withFlags('--import', instrumentPath)
 .withInstrument(instrumentPath)
 .expect({
 event: {
 exception: {
Expand Down

10 changes: 6 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/import-in-the-middle/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as iitm from 'import-in-the-middle';

new iitm.Hook((_, name) => {
Expand All@@ -14,6 +14,8 @@ Sentry.init({
 transport: loggingTransport,
});

await import('./sub-module.mjs');
await import('http');
await import('os');
(async () => {
 await import('./sub-module.mjs');
 await import('http');
 await import('os');
})();

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/esm/modules-integration/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

6 changes: 2 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/warn-esm/server.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 release: '1.0',
 transport: loggingTransport,
});

import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

const app = express();

app.get('/test/success', (req, res) => {
Expand Down

0
...tion-tests/suites/tracing/amqplib/init.ts → ...s/suites/express/with-http/instrument.mjs

View file


Open in desktop


File renamed without changes.


28 changes: 28 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/scenario.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import * as Sentry from '@sentry/node';
import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';
import http from 'http';

const app = express();

app.get('/test', (_req, res) => {
 http.get(`http://localhost:${app.port}/test2`, httpRes => {
 httpRes.on('data', () => {
 setTimeout(() => {
 res.send({ response: 'response 1' });
 }, 200);
 });
 });
});

app.get('/test2', (_req, res) => {
 res.send({ response: 'response 2' });
});

app.get('/test3', (_req, res) => {
 res.send({ response: 'response 3' });
});

Sentry.setupExpressErrorHandler(app);

startExpressServerAndSendPortToRunner(app);

41 changes: 41 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
import { afterAll, describe } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

describe('express with http import', () => {
 afterAll(() => {
 cleanupChildProcesses();
 });

 createEsmAndCjsTests(
 __dirname,
 'scenario.mjs',
 'instrument.mjs',
 (createRunner, test) => {
 test('it works when importing the http module', async () => {
 const runner = createRunner()
 .expect({
 transaction: {
 transaction: 'GET /test2',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test3',
 },
 })
 .start();
 await runner.makeRequest('get', '/test');
 await runner.makeRequest('get', '/test3');
 await runner.completed();
 });
 // TODO: This is failing on ESM because importing http is triggering the http spans twice :(
 // We need to fix this!
 },
 { failsOnEsm: true },
 );
});

10 changes: 4 additions & 6 deletions
dev-packages/node-integration-tests/suites/public-api/LocalVariables/deny-inspector.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
import { register } from 'node:module';

const hookScript = Buffer.from(`

 `);

register(
 new URL(`data:application/javascript,
export async function resolve(specifier, context, nextResolve) {
Expand All@@ -16,6 +12,8 @@ export async function resolve(specifier, context, nextResolve) {
 import.meta.url,
);

const Sentry = await import('@sentry/node');
(async () => {
 const Sentry = await import('@sentry/node');

Sentry.init({});
 Sentry.init({});
})();

2 changes: 1 addition & 1 deletion
...ckages/node-integration-tests/suites/public-api/LocalVariables/local-variables-caught.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-unused-vars */
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

58 changes: 0 additions & 58 deletions
dev-packages/node-integration-tests/suites/tracing/ai/scenario.js

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test(node): Add utility to test esm & cjs instrumentation#16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 15 commits into

from

Apr 30, 2025
 Merged


test(node): Add utility to test esm & cjs instrumentation
#16159
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


15 commits


Select commit
Hold shift + click to select a range
c9a0e08

test(node): Add utility to test esm & cjs instrumentation


mydea Apr 28, 2025
88eee44

add more tests


mydea Apr 29, 2025
fb38aed

WIP


mydea Apr 30, 2025
6d1a73c

update ai test


mydea Apr 30, 2025
4e41faf

update timeout


mydea Apr 30, 2025
68ac69e

increase anr timeout


mydea Apr 30, 2025
616c391

rename to failsOnEsm


mydea Apr 30, 2025
68d0733

genericPool


mydea Apr 30, 2025
d058fa8

httpIntegration


mydea Apr 30, 2025
05e2692

kafkajs


mydea Apr 30, 2025
1175539

always create files even if cjs is skipped


mydea Apr 30, 2025
fffc2c2

remove one level of nesting of describe calls


mydea Apr 30, 2025
3d9ce14

knex


mydea Apr 30, 2025
410cecf

cleanup unneeded comments/vars


mydea Apr 30, 2025
2804ee5

move cjs creation to beforeAll


mydea Apr 30, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 2 additions & 1 deletion
dev-packages/node-integration-tests/.eslintrc.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ module.exports = {
 },
 },
 {
 files: ['suites/**/*.ts'],
 files: ['suites/**/*.ts', 'suites/**/*.mjs'],
 parserOptions: {
 project: ['tsconfig.test.json'],
 sourceType: 'module',
 ecmaVersion: 'latest',
 },
 rules: {
 '@typescript-eslint/typedef': 'off',
Expand Down

1 change: 1 addition & 0 deletions
dev-packages/node-integration-tests/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
suites/**/tmp_*

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/app-path.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';
import * as path from 'path';
import * as url from 'url';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic-multiple.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/indefinite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/isolated.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/anr/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -107,7 +107,7 @@ const ANR_EVENT_WITH_DEBUG_META: Event = {
 },
};

describe('should report ANR when event loop blocked', { timeout: 60_000 }, () => {
describe('should report ANR when event loop blocked', { timeout: 90_000 }, () => {
@mydeamydeaApr 30, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but this flaked some times, let's see if this helps...
 afterAll(() => {
 cleanupChildProcesses();
 });
Expand Down

28 changes: 15 additions & 13 deletions
dev-packages/node-integration-tests/suites/breadcrumbs/process-thread/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { spawn } from 'child_process';
import { join } from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -13,16 +13,18 @@ Sentry.init({
 transport: loggingTransport,
});

await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
});
(async () => {
 await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
 });

await new Promise(resolve => {
 const worker = new Worker(join(__dirname, 'worker.mjs'));
 worker.on('error', resolve);
 worker.on('exit', resolve);
});
await new Promise(resolve => {
const worker = new Worker(join(__dirname, 'worker.mjs'));
worker.on('error', resolve);
worker.on('exit', resolve);
});

throw new Error('This is a test error');
 throw new Error('This is a test error');
})();

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/fork.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/fork.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { fork } from 'child_process';
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

const __dirname = new URL('.', import.meta.url).pathname;

Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/worker.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _worker = new Worker(path.join(__dirname, 'child.js'));
new Worker(path.join(__dirname, 'child.js'));

setTimeout(() => {
 process.exit();
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/worker.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as path from 'path';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _worker = new Worker(path.join(__dirname, 'child.mjs'));
new Worker(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 process.exit();
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/instrument.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ describe('ContextLines integration in ESM', () => {
 const instrumentPath = join(__dirname, 'instrument.mjs');

 await createRunner(__dirname, 'scenario with space.mjs')
 .withFlags('--import', instrumentPath)
 .withInstrument(instrumentPath)
 .expect({
 event: {
 exception: {
Expand Down

10 changes: 6 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/import-in-the-middle/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as iitm from 'import-in-the-middle';

new iitm.Hook((_, name) => {
Expand All@@ -14,6 +14,8 @@ Sentry.init({
 transport: loggingTransport,
});

await import('./sub-module.mjs');
await import('http');
await import('os');
(async () => {
 await import('./sub-module.mjs');
 await import('http');
 await import('os');
})();

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/esm/modules-integration/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

6 changes: 2 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/warn-esm/server.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 release: '1.0',
 transport: loggingTransport,
});

import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

const app = express();

app.get('/test/success', (req, res) => {
Expand Down

0
...tion-tests/suites/tracing/amqplib/init.ts → ...s/suites/express/with-http/instrument.mjs

View file


Open in desktop


File renamed without changes.


28 changes: 28 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/scenario.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import * as Sentry from '@sentry/node';
import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';
import http from 'http';

const app = express();

app.get('/test', (_req, res) => {
 http.get(`http://localhost:${app.port}/test2`, httpRes => {
 httpRes.on('data', () => {
 setTimeout(() => {
 res.send({ response: 'response 1' });
 }, 200);
 });
 });
});

app.get('/test2', (_req, res) => {
 res.send({ response: 'response 2' });
});

app.get('/test3', (_req, res) => {
 res.send({ response: 'response 3' });
});

Sentry.setupExpressErrorHandler(app);

startExpressServerAndSendPortToRunner(app);

41 changes: 41 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
import { afterAll, describe } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

describe('express with http import', () => {
 afterAll(() => {
 cleanupChildProcesses();
 });

 createEsmAndCjsTests(
 __dirname,
 'scenario.mjs',
 'instrument.mjs',
 (createRunner, test) => {
 test('it works when importing the http module', async () => {
 const runner = createRunner()
 .expect({
 transaction: {
 transaction: 'GET /test2',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test3',
 },
 })
 .start();
 await runner.makeRequest('get', '/test');
 await runner.makeRequest('get', '/test3');
 await runner.completed();
 });
 // TODO: This is failing on ESM because importing http is triggering the http spans twice :(
 // We need to fix this!
 },
 { failsOnEsm: true },
 );
});

10 changes: 4 additions & 6 deletions
dev-packages/node-integration-tests/suites/public-api/LocalVariables/deny-inspector.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
import { register } from 'node:module';

const hookScript = Buffer.from(`

 `);

register(
 new URL(`data:application/javascript,
export async function resolve(specifier, context, nextResolve) {
Expand All@@ -16,6 +12,8 @@ export async function resolve(specifier, context, nextResolve) {
 import.meta.url,
);

const Sentry = await import('@sentry/node');
(async () => {
 const Sentry = await import('@sentry/node');

Sentry.init({});
 Sentry.init({});
})();

2 changes: 1 addition & 1 deletion
...ckages/node-integration-tests/suites/public-api/LocalVariables/local-variables-caught.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-unused-vars */
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

58 changes: 0 additions & 58 deletions
dev-packages/node-integration-tests/suites/tracing/ai/scenario.js

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(node): Add utility to test esm & cjs instrumentation#16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 15 commits into

from

Apr 30, 2025
 Merged


test(node): Add utility to test esm & cjs instrumentation
#16159
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


15 commits


Select commit
Hold shift + click to select a range
c9a0e08

test(node): Add utility to test esm & cjs instrumentation


mydea Apr 28, 2025
88eee44

add more tests


mydea Apr 29, 2025
fb38aed

WIP


mydea Apr 30, 2025
6d1a73c

update ai test


mydea Apr 30, 2025
4e41faf

update timeout


mydea Apr 30, 2025
68ac69e

increase anr timeout


mydea Apr 30, 2025
616c391

rename to failsOnEsm


mydea Apr 30, 2025
68d0733

genericPool


mydea Apr 30, 2025
d058fa8

httpIntegration


mydea Apr 30, 2025
05e2692

kafkajs


mydea Apr 30, 2025
1175539

always create files even if cjs is skipped


mydea Apr 30, 2025
fffc2c2

remove one level of nesting of describe calls


mydea Apr 30, 2025
3d9ce14

knex


mydea Apr 30, 2025
410cecf

cleanup unneeded comments/vars


mydea Apr 30, 2025
2804ee5

move cjs creation to beforeAll


mydea Apr 30, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 2 additions & 1 deletion
dev-packages/node-integration-tests/.eslintrc.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ module.exports = {
 },
 },
 {
 files: ['suites/**/*.ts'],
 files: ['suites/**/*.ts', 'suites/**/*.mjs'],
 parserOptions: {
 project: ['tsconfig.test.json'],
 sourceType: 'module',
 ecmaVersion: 'latest',
 },
 rules: {
 '@typescript-eslint/typedef': 'off',
Expand Down

1 change: 1 addition & 0 deletions
dev-packages/node-integration-tests/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
suites/**/tmp_*

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/app-path.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';
import * as path from 'path';
import * as url from 'url';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic-multiple.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/indefinite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/isolated.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/anr/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -107,7 +107,7 @@ const ANR_EVENT_WITH_DEBUG_META: Event = {
 },
};

describe('should report ANR when event loop blocked', { timeout: 60_000 }, () => {
describe('should report ANR when event loop blocked', { timeout: 90_000 }, () => {
@mydeamydeaApr 30, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but this flaked some times, let's see if this helps...
 afterAll(() => {
 cleanupChildProcesses();
 });
Expand Down

28 changes: 15 additions & 13 deletions
dev-packages/node-integration-tests/suites/breadcrumbs/process-thread/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { spawn } from 'child_process';
import { join } from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -13,16 +13,18 @@ Sentry.init({
 transport: loggingTransport,
});

await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
});
(async () => {
 await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
 });

await new Promise(resolve => {
 const worker = new Worker(join(__dirname, 'worker.mjs'));
 worker.on('error', resolve);
 worker.on('exit', resolve);
});
await new Promise(resolve => {
const worker = new Worker(join(__dirname, 'worker.mjs'));
worker.on('error', resolve);
worker.on('exit', resolve);
});

throw new Error('This is a test error');
 throw new Error('This is a test error');
})();

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/fork.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/fork.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { fork } from 'child_process';
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

const __dirname = new URL('.', import.meta.url).pathname;

Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/worker.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _worker = new Worker(path.join(__dirname, 'child.js'));
new Worker(path.join(__dirname, 'child.js'));

setTimeout(() => {
 process.exit();
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/worker.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as path from 'path';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _worker = new Worker(path.join(__dirname, 'child.mjs'));
new Worker(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 process.exit();
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/instrument.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ describe('ContextLines integration in ESM', () => {
 const instrumentPath = join(__dirname, 'instrument.mjs');

 await createRunner(__dirname, 'scenario with space.mjs')
 .withFlags('--import', instrumentPath)
 .withInstrument(instrumentPath)
 .expect({
 event: {
 exception: {
Expand Down

10 changes: 6 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/import-in-the-middle/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as iitm from 'import-in-the-middle';

new iitm.Hook((_, name) => {
Expand All@@ -14,6 +14,8 @@ Sentry.init({
 transport: loggingTransport,
});

await import('./sub-module.mjs');
await import('http');
await import('os');
(async () => {
 await import('./sub-module.mjs');
 await import('http');
 await import('os');
})();

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/esm/modules-integration/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

6 changes: 2 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/warn-esm/server.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 release: '1.0',
 transport: loggingTransport,
});

import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

const app = express();

app.get('/test/success', (req, res) => {
Expand Down

0
...tion-tests/suites/tracing/amqplib/init.ts → ...s/suites/express/with-http/instrument.mjs

View file


Open in desktop


File renamed without changes.


28 changes: 28 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/scenario.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import * as Sentry from '@sentry/node';
import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';
import http from 'http';

const app = express();

app.get('/test', (_req, res) => {
 http.get(`http://localhost:${app.port}/test2`, httpRes => {
 httpRes.on('data', () => {
 setTimeout(() => {
 res.send({ response: 'response 1' });
 }, 200);
 });
 });
});

app.get('/test2', (_req, res) => {
 res.send({ response: 'response 2' });
});

app.get('/test3', (_req, res) => {
 res.send({ response: 'response 3' });
});

Sentry.setupExpressErrorHandler(app);

startExpressServerAndSendPortToRunner(app);

41 changes: 41 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
import { afterAll, describe } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

describe('express with http import', () => {
 afterAll(() => {
 cleanupChildProcesses();
 });

 createEsmAndCjsTests(
 __dirname,
 'scenario.mjs',
 'instrument.mjs',
 (createRunner, test) => {
 test('it works when importing the http module', async () => {
 const runner = createRunner()
 .expect({
 transaction: {
 transaction: 'GET /test2',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test3',
 },
 })
 .start();
 await runner.makeRequest('get', '/test');
 await runner.makeRequest('get', '/test3');
 await runner.completed();
 });
 // TODO: This is failing on ESM because importing http is triggering the http spans twice :(
 // We need to fix this!
 },
 { failsOnEsm: true },
 );
});

10 changes: 4 additions & 6 deletions
dev-packages/node-integration-tests/suites/public-api/LocalVariables/deny-inspector.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
import { register } from 'node:module';

const hookScript = Buffer.from(`

 `);

register(
 new URL(`data:application/javascript,
export async function resolve(specifier, context, nextResolve) {
Expand All@@ -16,6 +12,8 @@ export async function resolve(specifier, context, nextResolve) {
 import.meta.url,
);

const Sentry = await import('@sentry/node');
(async () => {
 const Sentry = await import('@sentry/node');

Sentry.init({});
 Sentry.init({});
})();

2 changes: 1 addition & 1 deletion
...ckages/node-integration-tests/suites/public-api/LocalVariables/local-variables-caught.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-unused-vars */
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

58 changes: 0 additions & 58 deletions
dev-packages/node-integration-tests/suites/tracing/ai/scenario.js

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(node): Add utility to test esm & cjs instrumentation#16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 15 commits into

from

Apr 30, 2025
 Merged


test(node): Add utility to test esm & cjs instrumentation
#16159
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


15 commits


Select commit
Hold shift + click to select a range
c9a0e08

test(node): Add utility to test esm & cjs instrumentation


mydea Apr 28, 2025
88eee44

add more tests


mydea Apr 29, 2025
fb38aed

WIP


mydea Apr 30, 2025
6d1a73c

update ai test


mydea Apr 30, 2025
4e41faf

update timeout


mydea Apr 30, 2025
68ac69e

increase anr timeout


mydea Apr 30, 2025
616c391

rename to failsOnEsm


mydea Apr 30, 2025
68d0733

genericPool


mydea Apr 30, 2025
d058fa8

httpIntegration


mydea Apr 30, 2025
05e2692

kafkajs


mydea Apr 30, 2025
1175539

always create files even if cjs is skipped


mydea Apr 30, 2025
fffc2c2

remove one level of nesting of describe calls


mydea Apr 30, 2025
3d9ce14

knex


mydea Apr 30, 2025
410cecf

cleanup unneeded comments/vars


mydea Apr 30, 2025
2804ee5

move cjs creation to beforeAll


mydea Apr 30, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 2 additions & 1 deletion
dev-packages/node-integration-tests/.eslintrc.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ module.exports = {
 },
 },
 {
 files: ['suites/**/*.ts'],
 files: ['suites/**/*.ts', 'suites/**/*.mjs'],
 parserOptions: {
 project: ['tsconfig.test.json'],
 sourceType: 'module',
 ecmaVersion: 'latest',
 },
 rules: {
 '@typescript-eslint/typedef': 'off',
Expand Down

1 change: 1 addition & 0 deletions
dev-packages/node-integration-tests/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
suites/**/tmp_*

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/app-path.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';
import * as path from 'path';
import * as url from 'url';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic-multiple.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/indefinite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/isolated.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/anr/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -107,7 +107,7 @@ const ANR_EVENT_WITH_DEBUG_META: Event = {
 },
};

describe('should report ANR when event loop blocked', { timeout: 60_000 }, () => {
describe('should report ANR when event loop blocked', { timeout: 90_000 }, () => {
@mydeamydeaApr 30, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but this flaked some times, let's see if this helps...
 afterAll(() => {
 cleanupChildProcesses();
 });
Expand Down

28 changes: 15 additions & 13 deletions
dev-packages/node-integration-tests/suites/breadcrumbs/process-thread/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { spawn } from 'child_process';
import { join } from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -13,16 +13,18 @@ Sentry.init({
 transport: loggingTransport,
});

await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
});
(async () => {
 await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
 });

await new Promise(resolve => {
 const worker = new Worker(join(__dirname, 'worker.mjs'));
 worker.on('error', resolve);
 worker.on('exit', resolve);
});
await new Promise(resolve => {
const worker = new Worker(join(__dirname, 'worker.mjs'));
worker.on('error', resolve);
worker.on('exit', resolve);
});

throw new Error('This is a test error');
 throw new Error('This is a test error');
})();

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/fork.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/fork.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { fork } from 'child_process';
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

const __dirname = new URL('.', import.meta.url).pathname;

Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/worker.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _worker = new Worker(path.join(__dirname, 'child.js'));
new Worker(path.join(__dirname, 'child.js'));

setTimeout(() => {
 process.exit();
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/worker.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as path from 'path';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _worker = new Worker(path.join(__dirname, 'child.mjs'));
new Worker(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 process.exit();
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/instrument.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ describe('ContextLines integration in ESM', () => {
 const instrumentPath = join(__dirname, 'instrument.mjs');

 await createRunner(__dirname, 'scenario with space.mjs')
 .withFlags('--import', instrumentPath)
 .withInstrument(instrumentPath)
 .expect({
 event: {
 exception: {
Expand Down

10 changes: 6 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/import-in-the-middle/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as iitm from 'import-in-the-middle';

new iitm.Hook((_, name) => {
Expand All@@ -14,6 +14,8 @@ Sentry.init({
 transport: loggingTransport,
});

await import('./sub-module.mjs');
await import('http');
await import('os');
(async () => {
 await import('./sub-module.mjs');
 await import('http');
 await import('os');
})();

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/esm/modules-integration/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

6 changes: 2 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/warn-esm/server.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 release: '1.0',
 transport: loggingTransport,
});

import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

const app = express();

app.get('/test/success', (req, res) => {
Expand Down

0
...tion-tests/suites/tracing/amqplib/init.ts → ...s/suites/express/with-http/instrument.mjs

View file


Open in desktop


File renamed without changes.


28 changes: 28 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/scenario.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import * as Sentry from '@sentry/node';
import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';
import http from 'http';

const app = express();

app.get('/test', (_req, res) => {
 http.get(`http://localhost:${app.port}/test2`, httpRes => {
 httpRes.on('data', () => {
 setTimeout(() => {
 res.send({ response: 'response 1' });
 }, 200);
 });
 });
});

app.get('/test2', (_req, res) => {
 res.send({ response: 'response 2' });
});

app.get('/test3', (_req, res) => {
 res.send({ response: 'response 3' });
});

Sentry.setupExpressErrorHandler(app);

startExpressServerAndSendPortToRunner(app);

41 changes: 41 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
import { afterAll, describe } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

describe('express with http import', () => {
 afterAll(() => {
 cleanupChildProcesses();
 });

 createEsmAndCjsTests(
 __dirname,
 'scenario.mjs',
 'instrument.mjs',
 (createRunner, test) => {
 test('it works when importing the http module', async () => {
 const runner = createRunner()
 .expect({
 transaction: {
 transaction: 'GET /test2',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test3',
 },
 })
 .start();
 await runner.makeRequest('get', '/test');
 await runner.makeRequest('get', '/test3');
 await runner.completed();
 });
 // TODO: This is failing on ESM because importing http is triggering the http spans twice :(
 // We need to fix this!
 },
 { failsOnEsm: true },
 );
});

10 changes: 4 additions & 6 deletions
dev-packages/node-integration-tests/suites/public-api/LocalVariables/deny-inspector.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
import { register } from 'node:module';

const hookScript = Buffer.from(`

 `);

register(
 new URL(`data:application/javascript,
export async function resolve(specifier, context, nextResolve) {
Expand All@@ -16,6 +12,8 @@ export async function resolve(specifier, context, nextResolve) {
 import.meta.url,
);

const Sentry = await import('@sentry/node');
(async () => {
 const Sentry = await import('@sentry/node');

Sentry.init({});
 Sentry.init({});
})();

2 changes: 1 addition & 1 deletion
...ckages/node-integration-tests/suites/public-api/LocalVariables/local-variables-caught.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-unused-vars */
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

58 changes: 0 additions & 58 deletions
dev-packages/node-integration-tests/suites/tracing/ai/scenario.js

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test(node): Add utility to test esm & cjs instrumentation#16159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 15 commits into

from

Apr 30, 2025
 Merged


test(node): Add utility to test esm & cjs instrumentation
#16159
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


15 commits


Select commit
Hold shift + click to select a range
c9a0e08

test(node): Add utility to test esm & cjs instrumentation


mydea Apr 28, 2025
88eee44

add more tests


mydea Apr 29, 2025
fb38aed

WIP


mydea Apr 30, 2025
6d1a73c

update ai test


mydea Apr 30, 2025
4e41faf

update timeout


mydea Apr 30, 2025
68ac69e

increase anr timeout


mydea Apr 30, 2025
616c391

rename to failsOnEsm


mydea Apr 30, 2025
68d0733

genericPool


mydea Apr 30, 2025
d058fa8

httpIntegration


mydea Apr 30, 2025
05e2692

kafkajs


mydea Apr 30, 2025
1175539

always create files even if cjs is skipped


mydea Apr 30, 2025
fffc2c2

remove one level of nesting of describe calls


mydea Apr 30, 2025
3d9ce14

knex


mydea Apr 30, 2025
410cecf

cleanup unneeded comments/vars


mydea Apr 30, 2025
2804ee5

move cjs creation to beforeAll


mydea Apr 30, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


3 changes: 2 additions & 1 deletion
dev-packages/node-integration-tests/.eslintrc.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ module.exports = {
 },
 },
 {
 files: ['suites/**/*.ts'],
 files: ['suites/**/*.ts', 'suites/**/*.mjs'],
 parserOptions: {
 project: ['tsconfig.test.json'],
 sourceType: 'module',
 ecmaVersion: 'latest',
 },
 rules: {
 '@typescript-eslint/typedef': 'off',
Expand Down

1 change: 1 addition & 0 deletions
dev-packages/node-integration-tests/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
suites/**/tmp_*

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/app-path.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';
import * as path from 'path';
import * as url from 'url';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic-multiple.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/basic.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

global._sentryDebugIds = { [new Error().stack]: 'aaaaaaaa-aaaa-4aaa-aaaa-aaaaaaaaaa' };

setTimeout(() => {
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/indefinite.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/anr/isolated.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import * as Sentry from '@sentry/node';
import * as assert from 'assert';
import * as crypto from 'crypto';

import * as Sentry from '@sentry/node';

setTimeout(() => {
 process.exit();
}, 10000);
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/anr/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -107,7 +107,7 @@ const ANR_EVENT_WITH_DEBUG_META: Event = {
 },
};

describe('should report ANR when event loop blocked', { timeout: 60_000 }, () => {
describe('should report ANR when event loop blocked', { timeout: 90_000 }, () => {
@mydeamydeaApr 30, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but this flaked some times, let's see if this helps...
 afterAll(() => {
 cleanupChildProcesses();
 });
Expand Down

28 changes: 15 additions & 13 deletions
dev-packages/node-integration-tests/suites/breadcrumbs/process-thread/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { spawn } from 'child_process';
import { join } from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -13,16 +13,18 @@ Sentry.init({
 transport: loggingTransport,
});

await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
});
(async () => {
 await new Promise(resolve => {
 const child = spawn('sleep', ['a']);
 child.on('error', resolve);
 child.on('exit', resolve);
 });

await new Promise(resolve => {
 const worker = new Worker(join(__dirname, 'worker.mjs'));
 worker.on('error', resolve);
 worker.on('exit', resolve);
});
await new Promise(resolve => {
const worker = new Worker(join(__dirname, 'worker.mjs'));
worker.on('error', resolve);
worker.on('exit', resolve);
});

throw new Error('This is a test error');
 throw new Error('This is a test error');
})();

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/fork.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/fork.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import { fork } from 'child_process';
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

const __dirname = new URL('.', import.meta.url).pathname;

Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _child = fork(path.join(__dirname, 'child.mjs'));
fork(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 throw new Error('Exiting main process');
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/node-integration-tests/suites/child-process/worker.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,7 @@ Sentry.init({
 transport: loggingTransport,
});

// eslint-disable-next-line no-unused-vars
const _worker = new Worker(path.join(__dirname, 'child.js'));
new Worker(path.join(__dirname, 'child.js'));

setTimeout(() => {
 process.exit();
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/node-integration-tests/suites/child-process/worker.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import * as path from 'path';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as path from 'path';
import { Worker } from 'worker_threads';

const __dirname = new URL('.', import.meta.url).pathname;
Expand All@@ -12,7 +12,7 @@ Sentry.init({
 transport: loggingTransport,
});

const _worker = new Worker(path.join(__dirname, 'child.mjs'));
new Worker(path.join(__dirname, 'child.mjs'));

setTimeout(() => {
 process.exit();
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/instrument.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/contextLines/filename-with-spaces/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ describe('ContextLines integration in ESM', () => {
 const instrumentPath = join(__dirname, 'instrument.mjs');

 await createRunner(__dirname, 'scenario with space.mjs')
 .withFlags('--import', instrumentPath)
 .withInstrument(instrumentPath)
 .expect({
 event: {
 exception: {
Expand Down

10 changes: 6 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/import-in-the-middle/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as iitm from 'import-in-the-middle';

new iitm.Hook((_, name) => {
Expand All@@ -14,6 +14,8 @@ Sentry.init({
 transport: loggingTransport,
});

await import('./sub-module.mjs');
await import('http');
await import('os');
(async () => {
 await import('./sub-module.mjs');
 await import('http');
 await import('os');
})();

2 changes: 1 addition & 1 deletion
dev-packages/node-integration-tests/suites/esm/modules-integration/app.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

6 changes: 2 additions & 4 deletions
dev-packages/node-integration-tests/suites/esm/warn-esm/server.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 release: '1.0',
 transport: loggingTransport,
});

import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';

const app = express();

app.get('/test/success', (req, res) => {
Expand Down

0
...tion-tests/suites/tracing/amqplib/init.ts → ...s/suites/express/with-http/instrument.mjs

View file


Open in desktop


File renamed without changes.


28 changes: 28 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/scenario.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
import * as Sentry from '@sentry/node';
import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
import express from 'express';
import http from 'http';

const app = express();

app.get('/test', (_req, res) => {
 http.get(`http://localhost:${app.port}/test2`, httpRes => {
 httpRes.on('data', () => {
 setTimeout(() => {
 res.send({ response: 'response 1' });
 }, 200);
 });
 });
});

app.get('/test2', (_req, res) => {
 res.send({ response: 'response 2' });
});

app.get('/test3', (_req, res) => {
 res.send({ response: 'response 3' });
});

Sentry.setupExpressErrorHandler(app);

startExpressServerAndSendPortToRunner(app);

41 changes: 41 additions & 0 deletions
dev-packages/node-integration-tests/suites/express/with-http/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
import { afterAll, describe } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

describe('express with http import', () => {
 afterAll(() => {
 cleanupChildProcesses();
 });

 createEsmAndCjsTests(
 __dirname,
 'scenario.mjs',
 'instrument.mjs',
 (createRunner, test) => {
 test('it works when importing the http module', async () => {
 const runner = createRunner()
 .expect({
 transaction: {
 transaction: 'GET /test2',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test',
 },
 })
 .expect({
 transaction: {
 transaction: 'GET /test3',
 },
 })
 .start();
 await runner.makeRequest('get', '/test');
 await runner.makeRequest('get', '/test3');
 await runner.completed();
 });
 // TODO: This is failing on ESM because importing http is triggering the http spans twice :(
 // We need to fix this!
 },
 { failsOnEsm: true },
 );
});

10 changes: 4 additions & 6 deletions
dev-packages/node-integration-tests/suites/public-api/LocalVariables/deny-inspector.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
import { register } from 'node:module';

const hookScript = Buffer.from(`

 `);

register(
 new URL(`data:application/javascript,
export async function resolve(specifier, context, nextResolve) {
Expand All@@ -16,6 +12,8 @@ export async function resolve(specifier, context, nextResolve) {
 import.meta.url,
);

const Sentry = await import('@sentry/node');
(async () => {
 const Sentry = await import('@sentry/node');

Sentry.init({});
 Sentry.init({});
})();

2 changes: 1 addition & 1 deletion
...ckages/node-integration-tests/suites/public-api/LocalVariables/local-variables-caught.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-unused-vars */
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
Expand Down

58 changes: 0 additions & 58 deletions
dev-packages/node-integration-tests/suites/tracing/ai/scenario.js

View file


Open in desktop


This file was deleted.

Loading