Skip to content
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ Sentry.init({
// todo: get this from env
dsn: 'https://username@domain/123',
tunnel: `http://localhost:3031/`, // proxy server
integrations: [Sentry.browserTracingIntegration()],
integrations: [Sentry.reactRouterTracingIntegration()],
tracesSampleRate: 1.0,
tracePropagationTargets: [/^\//],
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ export default [
]),
...prefix('performance', [
index('routes/performance/index.tsx'),
route('ssr', 'routes/performance/ssr.tsx'),
route('with/:param', 'routes/performance/dynamic-param.tsx'),
route('static', 'routes/performance/static.tsx'),
]),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
import { Link } from 'react-router';

export default function PerformancePage() {
return <h1>Performance Page</h1>;
return (
<div>
<h1>Performance Page</h1>
<nav>
<Link to="/performance/ssr">SSR Page</Link>
<Link to="/performance/with/sentry">With Param Page</Link>
</nav>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export default function SsrPage() {
return (
<div>
<h1>SSR Page</h1>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { APP_NAME } from '../constants';

test.describe('client - navigation performance', () => {
test('should create navigation transaction', async ({ page }) => {
const navigationPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/ssr';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'SSR Page' }).click(); // navigation

const transaction = await navigationPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'url',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/ssr',
type: 'transaction',
transaction_info: { source: 'url' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/ssr'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'With Param Page' }).click(); // navigation

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'route',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,56 @@ test.describe('client - pageload performance', () => {
});
});

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance/with/sentry`);

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

// todo: this page is currently not prerendered (see react-router.config.ts)
test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
Expand Down
147 changes: 147 additions & 0 deletions packages/react-router/src/client/hydratedRouter.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,147 @@
import { startBrowserTracingNavigationSpan } from '@sentry/browser';
import type { Span } from '@sentry/core';
import {
consoleSandbox,
getActiveSpan,
getClient,
getRootSpan,
GLOBAL_OBJ,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
spanToJSON,
} from '@sentry/core';
import type { DataRouter, RouterState } from 'react-router';
import { DEBUG_BUILD } from '../common/debug-build';

const GLOBAL_OBJ_WITH_DATA_ROUTER = GLOBAL_OBJ as typeof GLOBAL_OBJ & {
__reactRouterDataRouter?: DataRouter;
};

const MAX_RETRIES = 40; // 2 seconds at 50ms interval

/**
* Instruments the React Router Data Router for pageloads and navigation.
*
* This function waits for the router to be available after hydration, then:
* 1. Updates the pageload transaction with parameterized route info
* 2. Patches router.navigate() to create navigation transactions
* 3. Subscribes to router state changes to update navigation transactions with parameterized routes
*/
export function instrumentHydratedRouter(): void {
function trySubscribe(): boolean {
const router = GLOBAL_OBJ_WITH_DATA_ROUTER.__reactRouterDataRouter;

if (router) {
// The first time we hit the router, we try to update the pageload transaction
// todo: update pageload tx here
const pageloadSpan = getActiveRootSpan();
const pageloadName = pageloadSpan ? spanToJSON(pageloadSpan).description : undefined;
const parameterizePageloadRoute = getParameterizedRoute(router.state);
if (
pageloadName &&
normalizePathname(router.state.location.pathname) === normalizePathname(pageloadName) && // this event is for the currently active pageload
normalizePathname(parameterizePageloadRoute) !== normalizePathname(pageloadName) // route is not parameterized yet
) {
pageloadSpan?.updateName(parameterizePageloadRoute);
pageloadSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}

// Patching navigate for creating accurate navigation transactions
if (typeof router.navigate === 'function') {
const originalNav = router.navigate.bind(router);
router.navigate = function sentryPatchedNavigate(...args) {
maybeCreateNavigationTransaction(
String(args[0]) || '<unknown route>', // will be updated anyway
'url', // this also will be updated once we have the parameterized route
);
return originalNav(...args);
};
}

// Subscribe to router state changes to update navigation transactions with parameterized routes
router.subscribe(newState => {
const navigationSpan = getActiveRootSpan();
const navigationSpanName = navigationSpan ? spanToJSON(navigationSpan).description : undefined;
const parameterizedNavRoute = getParameterizedRoute(newState);

if (
navigationSpanName && // we have an active pageload tx
newState.navigation.state === 'idle' && // navigation has completed
normalizePathname(newState.location.pathname) === normalizePathname(navigationSpanName) && // this event is for the currently active navigation
normalizePathname(parameterizedNavRoute) !== normalizePathname(navigationSpanName) // route is not parameterized yet
) {
navigationSpan?.updateName(parameterizedNavRoute);
navigationSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}
});
return true;
}
return false;
}

// Wait until the router is available (since the SDK loads before hydration)
if (!trySubscribe()) {
let retryCount = 0;
// Retry until the router is available or max retries reached
Comment thread
chargome marked this conversation as resolved.
const interval = setInterval(() => {
if (trySubscribe() || retryCount >= MAX_RETRIES) {
if (retryCount >= MAX_RETRIES) {
DEBUG_BUILD &&
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn('Unable to instrument React Router: router not found after hydration.');
});
}
clearInterval(interval);
}
retryCount++;
}, 50);
}
}

function maybeCreateNavigationTransaction(name: string, source: 'url' | 'route'): Span | undefined {
const client = getClient();

if (!client) {
return undefined;
}

return startBrowserTracingNavigationSpan(client, {
name,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: source,
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.react-router',
},
});
}

function getActiveRootSpan(): Span | undefined {
const activeSpan = getActiveSpan();
if (!activeSpan) {
return undefined;
}

const rootSpan = getRootSpan(activeSpan);

const op = spanToJSON(rootSpan).op;

// Only use this root span if it is a pageload or navigation span
return op === 'navigation' || op === 'pageload' ? rootSpan : undefined;
}

function getParameterizedRoute(routerState: RouterState): string {
const lastMatch = routerState.matches[routerState.matches.length - 1];
return normalizePathname(lastMatch?.route.path ?? routerState.location.pathname);
}

function normalizePathname(pathname: string): string {
// Ensure it starts with a single slash
let normalized = pathname.startsWith('/') ? pathname : `/${pathname}`;
// Remove trailing slash unless it's the root
if (normalized.length > 1 && normalized.endsWith('/')) {
normalized = normalized.slice(0, -1);
}
return normalized;
}
1 change: 1 addition & 0 deletions packages/react-router/src/client/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
export * from '@sentry/browser';

export { init } from './sdk';
export { reactRouterTracingIntegration } from './tracingIntegration';
26 changes: 20 additions & 6 deletions packages/react-router/src/client/sdk.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,33 @@
import type { BrowserOptions } from '@sentry/browser';
import { init as browserInit } from '@sentry/browser';
import type { Client } from '@sentry/core';
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata, consoleSandbox, setTag } from '@sentry/core';

const BROWSER_TRACING_INTEGRATION_ID = 'BrowserTracing';

/**
* Initializes the client side of the React Router SDK.
*/
export function init(options: BrowserOptions): Client | undefined {
const opts = {
...options,
};
// If BrowserTracing integration was passed to options, emit a warning
if (options.integrations && Array.isArray(options.integrations)) {
const hasBrowserTracing = options.integrations.some(
integration => integration.name === BROWSER_TRACING_INTEGRATION_ID,
);

if (hasBrowserTracing) {
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn(
'browserTracingIntegration is not fully compatible with @sentry/react-router. Please use reactRouterTracingIntegration instead.',
);
});
}
}

applySdkMetadata(opts, 'react-router', ['react-router', 'browser']);
applySdkMetadata(options, 'react-router', ['react-router', 'browser']);

const client = browserInit(opts);
const client = browserInit(options);

setTag('runtime', 'browser');

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(react-router): Add client-side router instrumentation by chargome · Pull Request #16185 · getsentry/sentry-javascript · GitHub
Skip to content
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ Sentry.init({
// todo: get this from env
dsn: 'https://username@domain/123',
tunnel: `http://localhost:3031/`, // proxy server
integrations: [Sentry.browserTracingIntegration()],
integrations: [Sentry.reactRouterTracingIntegration()],
tracesSampleRate: 1.0,
tracePropagationTargets: [/^\//],
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ export default [
]),
...prefix('performance', [
index('routes/performance/index.tsx'),
route('ssr', 'routes/performance/ssr.tsx'),
route('with/:param', 'routes/performance/dynamic-param.tsx'),
route('static', 'routes/performance/static.tsx'),
]),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
import { Link } from 'react-router';

export default function PerformancePage() {
return <h1>Performance Page</h1>;
return (
<div>
<h1>Performance Page</h1>
<nav>
<Link to="/performance/ssr">SSR Page</Link>
<Link to="/performance/with/sentry">With Param Page</Link>
</nav>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export default function SsrPage() {
return (
<div>
<h1>SSR Page</h1>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { APP_NAME } from '../constants';

test.describe('client - navigation performance', () => {
test('should create navigation transaction', async ({ page }) => {
const navigationPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/ssr';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'SSR Page' }).click(); // navigation

const transaction = await navigationPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'url',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/ssr',
type: 'transaction',
transaction_info: { source: 'url' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/ssr'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'With Param Page' }).click(); // navigation

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'route',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,56 @@ test.describe('client - pageload performance', () => {
});
});

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance/with/sentry`);

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

// todo: this page is currently not prerendered (see react-router.config.ts)
test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
Expand Down
147 changes: 147 additions & 0 deletions packages/react-router/src/client/hydratedRouter.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,147 @@
import { startBrowserTracingNavigationSpan } from '@sentry/browser';
import type { Span } from '@sentry/core';
import {
consoleSandbox,
getActiveSpan,
getClient,
getRootSpan,
GLOBAL_OBJ,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
spanToJSON,
} from '@sentry/core';
import type { DataRouter, RouterState } from 'react-router';
import { DEBUG_BUILD } from '../common/debug-build';

const GLOBAL_OBJ_WITH_DATA_ROUTER = GLOBAL_OBJ as typeof GLOBAL_OBJ & {
__reactRouterDataRouter?: DataRouter;
};

const MAX_RETRIES = 40; // 2 seconds at 50ms interval

/**
* Instruments the React Router Data Router for pageloads and navigation.
*
* This function waits for the router to be available after hydration, then:
* 1. Updates the pageload transaction with parameterized route info
* 2. Patches router.navigate() to create navigation transactions
* 3. Subscribes to router state changes to update navigation transactions with parameterized routes
*/
export function instrumentHydratedRouter(): void {
function trySubscribe(): boolean {
const router = GLOBAL_OBJ_WITH_DATA_ROUTER.__reactRouterDataRouter;

if (router) {
// The first time we hit the router, we try to update the pageload transaction
// todo: update pageload tx here
const pageloadSpan = getActiveRootSpan();
const pageloadName = pageloadSpan ? spanToJSON(pageloadSpan).description : undefined;
const parameterizePageloadRoute = getParameterizedRoute(router.state);
if (
pageloadName &&
normalizePathname(router.state.location.pathname) === normalizePathname(pageloadName) && // this event is for the currently active pageload
normalizePathname(parameterizePageloadRoute) !== normalizePathname(pageloadName) // route is not parameterized yet
) {
pageloadSpan?.updateName(parameterizePageloadRoute);
pageloadSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}

// Patching navigate for creating accurate navigation transactions
if (typeof router.navigate === 'function') {
const originalNav = router.navigate.bind(router);
router.navigate = function sentryPatchedNavigate(...args) {
maybeCreateNavigationTransaction(
String(args[0]) || '<unknown route>', // will be updated anyway
'url', // this also will be updated once we have the parameterized route
);
return originalNav(...args);
};
}

// Subscribe to router state changes to update navigation transactions with parameterized routes
router.subscribe(newState => {
const navigationSpan = getActiveRootSpan();
const navigationSpanName = navigationSpan ? spanToJSON(navigationSpan).description : undefined;
const parameterizedNavRoute = getParameterizedRoute(newState);

if (
navigationSpanName && // we have an active pageload tx
newState.navigation.state === 'idle' && // navigation has completed
normalizePathname(newState.location.pathname) === normalizePathname(navigationSpanName) && // this event is for the currently active navigation
normalizePathname(parameterizedNavRoute) !== normalizePathname(navigationSpanName) // route is not parameterized yet
) {
navigationSpan?.updateName(parameterizedNavRoute);
navigationSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}
});
return true;
}
return false;
}

// Wait until the router is available (since the SDK loads before hydration)
if (!trySubscribe()) {
let retryCount = 0;
// Retry until the router is available or max retries reached
Comment thread
chargome marked this conversation as resolved.
const interval = setInterval(() => {
if (trySubscribe() || retryCount >= MAX_RETRIES) {
if (retryCount >= MAX_RETRIES) {
DEBUG_BUILD &&
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn('Unable to instrument React Router: router not found after hydration.');
});
}
clearInterval(interval);
}
retryCount++;
}, 50);
}
}

function maybeCreateNavigationTransaction(name: string, source: 'url' | 'route'): Span | undefined {
const client = getClient();

if (!client) {
return undefined;
}

return startBrowserTracingNavigationSpan(client, {
name,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: source,
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.react-router',
},
});
}

function getActiveRootSpan(): Span | undefined {
const activeSpan = getActiveSpan();
if (!activeSpan) {
return undefined;
}

const rootSpan = getRootSpan(activeSpan);

const op = spanToJSON(rootSpan).op;

// Only use this root span if it is a pageload or navigation span
return op === 'navigation' || op === 'pageload' ? rootSpan : undefined;
}

function getParameterizedRoute(routerState: RouterState): string {
const lastMatch = routerState.matches[routerState.matches.length - 1];
return normalizePathname(lastMatch?.route.path ?? routerState.location.pathname);
}

function normalizePathname(pathname: string): string {
// Ensure it starts with a single slash
let normalized = pathname.startsWith('/') ? pathname : `/${pathname}`;
// Remove trailing slash unless it's the root
if (normalized.length > 1 && normalized.endsWith('/')) {
normalized = normalized.slice(0, -1);
}
return normalized;
}
1 change: 1 addition & 0 deletions packages/react-router/src/client/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
export * from '@sentry/browser';

export { init } from './sdk';
export { reactRouterTracingIntegration } from './tracingIntegration';
26 changes: 20 additions & 6 deletions packages/react-router/src/client/sdk.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,33 @@
import type { BrowserOptions } from '@sentry/browser';
import { init as browserInit } from '@sentry/browser';
import type { Client } from '@sentry/core';
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata, consoleSandbox, setTag } from '@sentry/core';

const BROWSER_TRACING_INTEGRATION_ID = 'BrowserTracing';

/**
* Initializes the client side of the React Router SDK.
*/
export function init(options: BrowserOptions): Client | undefined {
const opts = {
...options,
};
// If BrowserTracing integration was passed to options, emit a warning
if (options.integrations && Array.isArray(options.integrations)) {
const hasBrowserTracing = options.integrations.some(
integration => integration.name === BROWSER_TRACING_INTEGRATION_ID,
);

if (hasBrowserTracing) {
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn(
'browserTracingIntegration is not fully compatible with @sentry/react-router. Please use reactRouterTracingIntegration instead.',
);
});
}
}

applySdkMetadata(opts, 'react-router', ['react-router', 'browser']);
applySdkMetadata(options, 'react-router', ['react-router', 'browser']);

const client = browserInit(opts);
const client = browserInit(options);

setTag('runtime', 'browser');

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(react-router): Add client-side router instrumentation by chargome · Pull Request #16185 · getsentry/sentry-javascript · GitHub
Skip to content
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ Sentry.init({
// todo: get this from env
dsn: 'https://username@domain/123',
tunnel: `http://localhost:3031/`, // proxy server
integrations: [Sentry.browserTracingIntegration()],
integrations: [Sentry.reactRouterTracingIntegration()],
tracesSampleRate: 1.0,
tracePropagationTargets: [/^\//],
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ export default [
]),
...prefix('performance', [
index('routes/performance/index.tsx'),
route('ssr', 'routes/performance/ssr.tsx'),
route('with/:param', 'routes/performance/dynamic-param.tsx'),
route('static', 'routes/performance/static.tsx'),
]),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
import { Link } from 'react-router';

export default function PerformancePage() {
return <h1>Performance Page</h1>;
return (
<div>
<h1>Performance Page</h1>
<nav>
<Link to="/performance/ssr">SSR Page</Link>
<Link to="/performance/with/sentry">With Param Page</Link>
</nav>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export default function SsrPage() {
return (
<div>
<h1>SSR Page</h1>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { APP_NAME } from '../constants';

test.describe('client - navigation performance', () => {
test('should create navigation transaction', async ({ page }) => {
const navigationPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/ssr';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'SSR Page' }).click(); // navigation

const transaction = await navigationPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'url',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/ssr',
type: 'transaction',
transaction_info: { source: 'url' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/ssr'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'With Param Page' }).click(); // navigation

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'route',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,56 @@ test.describe('client - pageload performance', () => {
});
});

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance/with/sentry`);

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

// todo: this page is currently not prerendered (see react-router.config.ts)
test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
Expand Down
147 changes: 147 additions & 0 deletions packages/react-router/src/client/hydratedRouter.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,147 @@
import { startBrowserTracingNavigationSpan } from '@sentry/browser';
import type { Span } from '@sentry/core';
import {
consoleSandbox,
getActiveSpan,
getClient,
getRootSpan,
GLOBAL_OBJ,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
spanToJSON,
} from '@sentry/core';
import type { DataRouter, RouterState } from 'react-router';
import { DEBUG_BUILD } from '../common/debug-build';

const GLOBAL_OBJ_WITH_DATA_ROUTER = GLOBAL_OBJ as typeof GLOBAL_OBJ & {
__reactRouterDataRouter?: DataRouter;
};

const MAX_RETRIES = 40; // 2 seconds at 50ms interval

/**
* Instruments the React Router Data Router for pageloads and navigation.
*
* This function waits for the router to be available after hydration, then:
* 1. Updates the pageload transaction with parameterized route info
* 2. Patches router.navigate() to create navigation transactions
* 3. Subscribes to router state changes to update navigation transactions with parameterized routes
*/
export function instrumentHydratedRouter(): void {
function trySubscribe(): boolean {
const router = GLOBAL_OBJ_WITH_DATA_ROUTER.__reactRouterDataRouter;

if (router) {
// The first time we hit the router, we try to update the pageload transaction
// todo: update pageload tx here
const pageloadSpan = getActiveRootSpan();
const pageloadName = pageloadSpan ? spanToJSON(pageloadSpan).description : undefined;
const parameterizePageloadRoute = getParameterizedRoute(router.state);
if (
pageloadName &&
normalizePathname(router.state.location.pathname) === normalizePathname(pageloadName) && // this event is for the currently active pageload
normalizePathname(parameterizePageloadRoute) !== normalizePathname(pageloadName) // route is not parameterized yet
) {
pageloadSpan?.updateName(parameterizePageloadRoute);
pageloadSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}

// Patching navigate for creating accurate navigation transactions
if (typeof router.navigate === 'function') {
const originalNav = router.navigate.bind(router);
router.navigate = function sentryPatchedNavigate(...args) {
maybeCreateNavigationTransaction(
String(args[0]) || '<unknown route>', // will be updated anyway
'url', // this also will be updated once we have the parameterized route
);
return originalNav(...args);
};
}

// Subscribe to router state changes to update navigation transactions with parameterized routes
router.subscribe(newState => {
const navigationSpan = getActiveRootSpan();
const navigationSpanName = navigationSpan ? spanToJSON(navigationSpan).description : undefined;
const parameterizedNavRoute = getParameterizedRoute(newState);

if (
navigationSpanName && // we have an active pageload tx
newState.navigation.state === 'idle' && // navigation has completed
normalizePathname(newState.location.pathname) === normalizePathname(navigationSpanName) && // this event is for the currently active navigation
normalizePathname(parameterizedNavRoute) !== normalizePathname(navigationSpanName) // route is not parameterized yet
) {
navigationSpan?.updateName(parameterizedNavRoute);
navigationSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}
});
return true;
}
return false;
}

// Wait until the router is available (since the SDK loads before hydration)
if (!trySubscribe()) {
let retryCount = 0;
// Retry until the router is available or max retries reached
Comment thread
chargome marked this conversation as resolved.
const interval = setInterval(() => {
if (trySubscribe() || retryCount >= MAX_RETRIES) {
if (retryCount >= MAX_RETRIES) {
DEBUG_BUILD &&
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn('Unable to instrument React Router: router not found after hydration.');
});
}
clearInterval(interval);
}
retryCount++;
}, 50);
}
}

function maybeCreateNavigationTransaction(name: string, source: 'url' | 'route'): Span | undefined {
const client = getClient();

if (!client) {
return undefined;
}

return startBrowserTracingNavigationSpan(client, {
name,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: source,
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.react-router',
},
});
}

function getActiveRootSpan(): Span | undefined {
const activeSpan = getActiveSpan();
if (!activeSpan) {
return undefined;
}

const rootSpan = getRootSpan(activeSpan);

const op = spanToJSON(rootSpan).op;

// Only use this root span if it is a pageload or navigation span
return op === 'navigation' || op === 'pageload' ? rootSpan : undefined;
}

function getParameterizedRoute(routerState: RouterState): string {
const lastMatch = routerState.matches[routerState.matches.length - 1];
return normalizePathname(lastMatch?.route.path ?? routerState.location.pathname);
}

function normalizePathname(pathname: string): string {
// Ensure it starts with a single slash
let normalized = pathname.startsWith('/') ? pathname : `/${pathname}`;
// Remove trailing slash unless it's the root
if (normalized.length > 1 && normalized.endsWith('/')) {
normalized = normalized.slice(0, -1);
}
return normalized;
}
1 change: 1 addition & 0 deletions packages/react-router/src/client/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
export * from '@sentry/browser';

export { init } from './sdk';
export { reactRouterTracingIntegration } from './tracingIntegration';
26 changes: 20 additions & 6 deletions packages/react-router/src/client/sdk.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,33 @@
import type { BrowserOptions } from '@sentry/browser';
import { init as browserInit } from '@sentry/browser';
import type { Client } from '@sentry/core';
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata, consoleSandbox, setTag } from '@sentry/core';

const BROWSER_TRACING_INTEGRATION_ID = 'BrowserTracing';

/**
* Initializes the client side of the React Router SDK.
*/
export function init(options: BrowserOptions): Client | undefined {
const opts = {
...options,
};
// If BrowserTracing integration was passed to options, emit a warning
if (options.integrations && Array.isArray(options.integrations)) {
const hasBrowserTracing = options.integrations.some(
integration => integration.name === BROWSER_TRACING_INTEGRATION_ID,
);

if (hasBrowserTracing) {
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn(
'browserTracingIntegration is not fully compatible with @sentry/react-router. Please use reactRouterTracingIntegration instead.',
);
});
}
}

applySdkMetadata(opts, 'react-router', ['react-router', 'browser']);
applySdkMetadata(options, 'react-router', ['react-router', 'browser']);

const client = browserInit(opts);
const client = browserInit(options);

setTag('runtime', 'browser');

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(react-router): Add client-side router instrumentation by chargome · Pull Request #16185 · getsentry/sentry-javascript · GitHub
Skip to content
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ Sentry.init({
// todo: get this from env
dsn: 'https://username@domain/123',
tunnel: `http://localhost:3031/`, // proxy server
integrations: [Sentry.browserTracingIntegration()],
integrations: [Sentry.reactRouterTracingIntegration()],
tracesSampleRate: 1.0,
tracePropagationTargets: [/^\//],
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ export default [
]),
...prefix('performance', [
index('routes/performance/index.tsx'),
route('ssr', 'routes/performance/ssr.tsx'),
route('with/:param', 'routes/performance/dynamic-param.tsx'),
route('static', 'routes/performance/static.tsx'),
]),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
import { Link } from 'react-router';

export default function PerformancePage() {
return <h1>Performance Page</h1>;
return (
<div>
<h1>Performance Page</h1>
<nav>
<Link to="/performance/ssr">SSR Page</Link>
<Link to="/performance/with/sentry">With Param Page</Link>
</nav>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export default function SsrPage() {
return (
<div>
<h1>SSR Page</h1>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { APP_NAME } from '../constants';

test.describe('client - navigation performance', () => {
test('should create navigation transaction', async ({ page }) => {
const navigationPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/ssr';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'SSR Page' }).click(); // navigation

const transaction = await navigationPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'url',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/ssr',
type: 'transaction',
transaction_info: { source: 'url' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/ssr'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'With Param Page' }).click(); // navigation

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'route',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,56 @@ test.describe('client - pageload performance', () => {
});
});

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance/with/sentry`);

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

// todo: this page is currently not prerendered (see react-router.config.ts)
test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
Expand Down
147 changes: 147 additions & 0 deletions packages/react-router/src/client/hydratedRouter.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,147 @@
import { startBrowserTracingNavigationSpan } from '@sentry/browser';
import type { Span } from '@sentry/core';
import {
consoleSandbox,
getActiveSpan,
getClient,
getRootSpan,
GLOBAL_OBJ,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
spanToJSON,
} from '@sentry/core';
import type { DataRouter, RouterState } from 'react-router';
import { DEBUG_BUILD } from '../common/debug-build';

const GLOBAL_OBJ_WITH_DATA_ROUTER = GLOBAL_OBJ as typeof GLOBAL_OBJ & {
__reactRouterDataRouter?: DataRouter;
};

const MAX_RETRIES = 40; // 2 seconds at 50ms interval

/**
* Instruments the React Router Data Router for pageloads and navigation.
*
* This function waits for the router to be available after hydration, then:
* 1. Updates the pageload transaction with parameterized route info
* 2. Patches router.navigate() to create navigation transactions
* 3. Subscribes to router state changes to update navigation transactions with parameterized routes
*/
export function instrumentHydratedRouter(): void {
function trySubscribe(): boolean {
const router = GLOBAL_OBJ_WITH_DATA_ROUTER.__reactRouterDataRouter;

if (router) {
// The first time we hit the router, we try to update the pageload transaction
// todo: update pageload tx here
const pageloadSpan = getActiveRootSpan();
const pageloadName = pageloadSpan ? spanToJSON(pageloadSpan).description : undefined;
const parameterizePageloadRoute = getParameterizedRoute(router.state);
if (
pageloadName &&
normalizePathname(router.state.location.pathname) === normalizePathname(pageloadName) && // this event is for the currently active pageload
normalizePathname(parameterizePageloadRoute) !== normalizePathname(pageloadName) // route is not parameterized yet
) {
pageloadSpan?.updateName(parameterizePageloadRoute);
pageloadSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}

// Patching navigate for creating accurate navigation transactions
if (typeof router.navigate === 'function') {
const originalNav = router.navigate.bind(router);
router.navigate = function sentryPatchedNavigate(...args) {
maybeCreateNavigationTransaction(
String(args[0]) || '<unknown route>', // will be updated anyway
'url', // this also will be updated once we have the parameterized route
);
return originalNav(...args);
};
}

// Subscribe to router state changes to update navigation transactions with parameterized routes
router.subscribe(newState => {
const navigationSpan = getActiveRootSpan();
const navigationSpanName = navigationSpan ? spanToJSON(navigationSpan).description : undefined;
const parameterizedNavRoute = getParameterizedRoute(newState);

if (
navigationSpanName && // we have an active pageload tx
newState.navigation.state === 'idle' && // navigation has completed
normalizePathname(newState.location.pathname) === normalizePathname(navigationSpanName) && // this event is for the currently active navigation
normalizePathname(parameterizedNavRoute) !== normalizePathname(navigationSpanName) // route is not parameterized yet
) {
navigationSpan?.updateName(parameterizedNavRoute);
navigationSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}
});
return true;
}
return false;
}

// Wait until the router is available (since the SDK loads before hydration)
if (!trySubscribe()) {
let retryCount = 0;
// Retry until the router is available or max retries reached
Comment thread
chargome marked this conversation as resolved.
const interval = setInterval(() => {
if (trySubscribe() || retryCount >= MAX_RETRIES) {
if (retryCount >= MAX_RETRIES) {
DEBUG_BUILD &&
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn('Unable to instrument React Router: router not found after hydration.');
});
}
clearInterval(interval);
}
retryCount++;
}, 50);
}
}

function maybeCreateNavigationTransaction(name: string, source: 'url' | 'route'): Span | undefined {
const client = getClient();

if (!client) {
return undefined;
}

return startBrowserTracingNavigationSpan(client, {
name,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: source,
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.react-router',
},
});
}

function getActiveRootSpan(): Span | undefined {
const activeSpan = getActiveSpan();
if (!activeSpan) {
return undefined;
}

const rootSpan = getRootSpan(activeSpan);

const op = spanToJSON(rootSpan).op;

// Only use this root span if it is a pageload or navigation span
return op === 'navigation' || op === 'pageload' ? rootSpan : undefined;
}

function getParameterizedRoute(routerState: RouterState): string {
const lastMatch = routerState.matches[routerState.matches.length - 1];
return normalizePathname(lastMatch?.route.path ?? routerState.location.pathname);
}

function normalizePathname(pathname: string): string {
// Ensure it starts with a single slash
let normalized = pathname.startsWith('/') ? pathname : `/${pathname}`;
// Remove trailing slash unless it's the root
if (normalized.length > 1 && normalized.endsWith('/')) {
normalized = normalized.slice(0, -1);
}
return normalized;
}
1 change: 1 addition & 0 deletions packages/react-router/src/client/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
export * from '@sentry/browser';

export { init } from './sdk';
export { reactRouterTracingIntegration } from './tracingIntegration';
26 changes: 20 additions & 6 deletions packages/react-router/src/client/sdk.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,33 @@
import type { BrowserOptions } from '@sentry/browser';
import { init as browserInit } from '@sentry/browser';
import type { Client } from '@sentry/core';
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata, consoleSandbox, setTag } from '@sentry/core';

const BROWSER_TRACING_INTEGRATION_ID = 'BrowserTracing';

/**
* Initializes the client side of the React Router SDK.
*/
export function init(options: BrowserOptions): Client | undefined {
const opts = {
...options,
};
// If BrowserTracing integration was passed to options, emit a warning
if (options.integrations && Array.isArray(options.integrations)) {
const hasBrowserTracing = options.integrations.some(
integration => integration.name === BROWSER_TRACING_INTEGRATION_ID,
);

if (hasBrowserTracing) {
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn(
'browserTracingIntegration is not fully compatible with @sentry/react-router. Please use reactRouterTracingIntegration instead.',
);
});
}
}

applySdkMetadata(opts, 'react-router', ['react-router', 'browser']);
applySdkMetadata(options, 'react-router', ['react-router', 'browser']);

const client = browserInit(opts);
const client = browserInit(options);

setTag('runtime', 'browser');

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(react-router): Add client-side router instrumentation by chargome · Pull Request #16185 · getsentry/sentry-javascript · GitHub
Skip to content
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ Sentry.init({
// todo: get this from env
dsn: 'https://username@domain/123',
tunnel: `http://localhost:3031/`, // proxy server
integrations: [Sentry.browserTracingIntegration()],
integrations: [Sentry.reactRouterTracingIntegration()],
tracesSampleRate: 1.0,
tracePropagationTargets: [/^\//],
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ export default [
]),
...prefix('performance', [
index('routes/performance/index.tsx'),
route('ssr', 'routes/performance/ssr.tsx'),
route('with/:param', 'routes/performance/dynamic-param.tsx'),
route('static', 'routes/performance/static.tsx'),
]),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
import { Link } from 'react-router';

export default function PerformancePage() {
return <h1>Performance Page</h1>;
return (
<div>
<h1>Performance Page</h1>
<nav>
<Link to="/performance/ssr">SSR Page</Link>
<Link to="/performance/with/sentry">With Param Page</Link>
</nav>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export default function SsrPage() {
return (
<div>
<h1>SSR Page</h1>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { APP_NAME } from '../constants';

test.describe('client - navigation performance', () => {
test('should create navigation transaction', async ({ page }) => {
const navigationPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/ssr';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'SSR Page' }).click(); // navigation

const transaction = await navigationPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'url',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/ssr',
type: 'transaction',
transaction_info: { source: 'url' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/ssr'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'With Param Page' }).click(); // navigation

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'route',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,56 @@ test.describe('client - pageload performance', () => {
});
});

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance/with/sentry`);

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

// todo: this page is currently not prerendered (see react-router.config.ts)
test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
Expand Down
147 changes: 147 additions & 0 deletions packages/react-router/src/client/hydratedRouter.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,147 @@
import { startBrowserTracingNavigationSpan } from '@sentry/browser';
import type { Span } from '@sentry/core';
import {
consoleSandbox,
getActiveSpan,
getClient,
getRootSpan,
GLOBAL_OBJ,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
spanToJSON,
} from '@sentry/core';
import type { DataRouter, RouterState } from 'react-router';
import { DEBUG_BUILD } from '../common/debug-build';

const GLOBAL_OBJ_WITH_DATA_ROUTER = GLOBAL_OBJ as typeof GLOBAL_OBJ & {
__reactRouterDataRouter?: DataRouter;
};

const MAX_RETRIES = 40; // 2 seconds at 50ms interval

/**
* Instruments the React Router Data Router for pageloads and navigation.
*
* This function waits for the router to be available after hydration, then:
* 1. Updates the pageload transaction with parameterized route info
* 2. Patches router.navigate() to create navigation transactions
* 3. Subscribes to router state changes to update navigation transactions with parameterized routes
*/
export function instrumentHydratedRouter(): void {
function trySubscribe(): boolean {
const router = GLOBAL_OBJ_WITH_DATA_ROUTER.__reactRouterDataRouter;

if (router) {
// The first time we hit the router, we try to update the pageload transaction
// todo: update pageload tx here
const pageloadSpan = getActiveRootSpan();
const pageloadName = pageloadSpan ? spanToJSON(pageloadSpan).description : undefined;
const parameterizePageloadRoute = getParameterizedRoute(router.state);
if (
pageloadName &&
normalizePathname(router.state.location.pathname) === normalizePathname(pageloadName) && // this event is for the currently active pageload
normalizePathname(parameterizePageloadRoute) !== normalizePathname(pageloadName) // route is not parameterized yet
) {
pageloadSpan?.updateName(parameterizePageloadRoute);
pageloadSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}

// Patching navigate for creating accurate navigation transactions
if (typeof router.navigate === 'function') {
const originalNav = router.navigate.bind(router);
router.navigate = function sentryPatchedNavigate(...args) {
maybeCreateNavigationTransaction(
String(args[0]) || '<unknown route>', // will be updated anyway
'url', // this also will be updated once we have the parameterized route
);
return originalNav(...args);
};
}

// Subscribe to router state changes to update navigation transactions with parameterized routes
router.subscribe(newState => {
const navigationSpan = getActiveRootSpan();
const navigationSpanName = navigationSpan ? spanToJSON(navigationSpan).description : undefined;
const parameterizedNavRoute = getParameterizedRoute(newState);

if (
navigationSpanName && // we have an active pageload tx
newState.navigation.state === 'idle' && // navigation has completed
normalizePathname(newState.location.pathname) === normalizePathname(navigationSpanName) && // this event is for the currently active navigation
normalizePathname(parameterizedNavRoute) !== normalizePathname(navigationSpanName) // route is not parameterized yet
) {
navigationSpan?.updateName(parameterizedNavRoute);
navigationSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}
});
return true;
}
return false;
}

// Wait until the router is available (since the SDK loads before hydration)
if (!trySubscribe()) {
let retryCount = 0;
// Retry until the router is available or max retries reached
Comment thread
chargome marked this conversation as resolved.
const interval = setInterval(() => {
if (trySubscribe() || retryCount >= MAX_RETRIES) {
if (retryCount >= MAX_RETRIES) {
DEBUG_BUILD &&
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn('Unable to instrument React Router: router not found after hydration.');
});
}
clearInterval(interval);
}
retryCount++;
}, 50);
}
}

function maybeCreateNavigationTransaction(name: string, source: 'url' | 'route'): Span | undefined {
const client = getClient();

if (!client) {
return undefined;
}

return startBrowserTracingNavigationSpan(client, {
name,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: source,
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.react-router',
},
});
}

function getActiveRootSpan(): Span | undefined {
const activeSpan = getActiveSpan();
if (!activeSpan) {
return undefined;
}

const rootSpan = getRootSpan(activeSpan);

const op = spanToJSON(rootSpan).op;

// Only use this root span if it is a pageload or navigation span
return op === 'navigation' || op === 'pageload' ? rootSpan : undefined;
}

function getParameterizedRoute(routerState: RouterState): string {
const lastMatch = routerState.matches[routerState.matches.length - 1];
return normalizePathname(lastMatch?.route.path ?? routerState.location.pathname);
}

function normalizePathname(pathname: string): string {
// Ensure it starts with a single slash
let normalized = pathname.startsWith('/') ? pathname : `/${pathname}`;
// Remove trailing slash unless it's the root
if (normalized.length > 1 && normalized.endsWith('/')) {
normalized = normalized.slice(0, -1);
}
return normalized;
}
1 change: 1 addition & 0 deletions packages/react-router/src/client/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
export * from '@sentry/browser';

export { init } from './sdk';
export { reactRouterTracingIntegration } from './tracingIntegration';
26 changes: 20 additions & 6 deletions packages/react-router/src/client/sdk.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,33 @@
import type { BrowserOptions } from '@sentry/browser';
import { init as browserInit } from '@sentry/browser';
import type { Client } from '@sentry/core';
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata, consoleSandbox, setTag } from '@sentry/core';

const BROWSER_TRACING_INTEGRATION_ID = 'BrowserTracing';

/**
* Initializes the client side of the React Router SDK.
*/
export function init(options: BrowserOptions): Client | undefined {
const opts = {
...options,
};
// If BrowserTracing integration was passed to options, emit a warning
if (options.integrations && Array.isArray(options.integrations)) {
const hasBrowserTracing = options.integrations.some(
integration => integration.name === BROWSER_TRACING_INTEGRATION_ID,
);

if (hasBrowserTracing) {
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn(
'browserTracingIntegration is not fully compatible with @sentry/react-router. Please use reactRouterTracingIntegration instead.',
);
});
}
}

applySdkMetadata(opts, 'react-router', ['react-router', 'browser']);
applySdkMetadata(options, 'react-router', ['react-router', 'browser']);

const client = browserInit(opts);
const client = browserInit(options);

setTag('runtime', 'browser');

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(react-router): Add client-side router instrumentation by chargome · Pull Request #16185 · getsentry/sentry-javascript · GitHub
Skip to content
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ Sentry.init({
// todo: get this from env
dsn: 'https://username@domain/123',
tunnel: `http://localhost:3031/`, // proxy server
integrations: [Sentry.browserTracingIntegration()],
integrations: [Sentry.reactRouterTracingIntegration()],
tracesSampleRate: 1.0,
tracePropagationTargets: [/^\//],
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ export default [
]),
...prefix('performance', [
index('routes/performance/index.tsx'),
route('ssr', 'routes/performance/ssr.tsx'),
route('with/:param', 'routes/performance/dynamic-param.tsx'),
route('static', 'routes/performance/static.tsx'),
]),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
import { Link } from 'react-router';

export default function PerformancePage() {
return <h1>Performance Page</h1>;
return (
<div>
<h1>Performance Page</h1>
<nav>
<Link to="/performance/ssr">SSR Page</Link>
<Link to="/performance/with/sentry">With Param Page</Link>
</nav>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export default function SsrPage() {
return (
<div>
<h1>SSR Page</h1>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { APP_NAME } from '../constants';

test.describe('client - navigation performance', () => {
test('should create navigation transaction', async ({ page }) => {
const navigationPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/ssr';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'SSR Page' }).click(); // navigation

const transaction = await navigationPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'url',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/ssr',
type: 'transaction',
transaction_info: { source: 'url' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/ssr'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'With Param Page' }).click(); // navigation

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'route',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,56 @@ test.describe('client - pageload performance', () => {
});
});

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance/with/sentry`);

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

// todo: this page is currently not prerendered (see react-router.config.ts)
test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
Expand Down
147 changes: 147 additions & 0 deletions packages/react-router/src/client/hydratedRouter.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,147 @@
import { startBrowserTracingNavigationSpan } from '@sentry/browser';
import type { Span } from '@sentry/core';
import {
consoleSandbox,
getActiveSpan,
getClient,
getRootSpan,
GLOBAL_OBJ,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
spanToJSON,
} from '@sentry/core';
import type { DataRouter, RouterState } from 'react-router';
import { DEBUG_BUILD } from '../common/debug-build';

const GLOBAL_OBJ_WITH_DATA_ROUTER = GLOBAL_OBJ as typeof GLOBAL_OBJ & {
__reactRouterDataRouter?: DataRouter;
};

const MAX_RETRIES = 40; // 2 seconds at 50ms interval

/**
* Instruments the React Router Data Router for pageloads and navigation.
*
* This function waits for the router to be available after hydration, then:
* 1. Updates the pageload transaction with parameterized route info
* 2. Patches router.navigate() to create navigation transactions
* 3. Subscribes to router state changes to update navigation transactions with parameterized routes
*/
export function instrumentHydratedRouter(): void {
function trySubscribe(): boolean {
const router = GLOBAL_OBJ_WITH_DATA_ROUTER.__reactRouterDataRouter;

if (router) {
// The first time we hit the router, we try to update the pageload transaction
// todo: update pageload tx here
const pageloadSpan = getActiveRootSpan();
const pageloadName = pageloadSpan ? spanToJSON(pageloadSpan).description : undefined;
const parameterizePageloadRoute = getParameterizedRoute(router.state);
if (
pageloadName &&
normalizePathname(router.state.location.pathname) === normalizePathname(pageloadName) && // this event is for the currently active pageload
normalizePathname(parameterizePageloadRoute) !== normalizePathname(pageloadName) // route is not parameterized yet
) {
pageloadSpan?.updateName(parameterizePageloadRoute);
pageloadSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}

// Patching navigate for creating accurate navigation transactions
if (typeof router.navigate === 'function') {
const originalNav = router.navigate.bind(router);
router.navigate = function sentryPatchedNavigate(...args) {
maybeCreateNavigationTransaction(
String(args[0]) || '<unknown route>', // will be updated anyway
'url', // this also will be updated once we have the parameterized route
);
return originalNav(...args);
};
}

// Subscribe to router state changes to update navigation transactions with parameterized routes
router.subscribe(newState => {
const navigationSpan = getActiveRootSpan();
const navigationSpanName = navigationSpan ? spanToJSON(navigationSpan).description : undefined;
const parameterizedNavRoute = getParameterizedRoute(newState);

if (
navigationSpanName && // we have an active pageload tx
newState.navigation.state === 'idle' && // navigation has completed
normalizePathname(newState.location.pathname) === normalizePathname(navigationSpanName) && // this event is for the currently active navigation
normalizePathname(parameterizedNavRoute) !== normalizePathname(navigationSpanName) // route is not parameterized yet
) {
navigationSpan?.updateName(parameterizedNavRoute);
navigationSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}
});
return true;
}
return false;
}

// Wait until the router is available (since the SDK loads before hydration)
if (!trySubscribe()) {
let retryCount = 0;
// Retry until the router is available or max retries reached
Comment thread
chargome marked this conversation as resolved.
const interval = setInterval(() => {
if (trySubscribe() || retryCount >= MAX_RETRIES) {
if (retryCount >= MAX_RETRIES) {
DEBUG_BUILD &&
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn('Unable to instrument React Router: router not found after hydration.');
});
}
clearInterval(interval);
}
retryCount++;
}, 50);
}
}

function maybeCreateNavigationTransaction(name: string, source: 'url' | 'route'): Span | undefined {
const client = getClient();

if (!client) {
return undefined;
}

return startBrowserTracingNavigationSpan(client, {
name,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: source,
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.react-router',
},
});
}

function getActiveRootSpan(): Span | undefined {
const activeSpan = getActiveSpan();
if (!activeSpan) {
return undefined;
}

const rootSpan = getRootSpan(activeSpan);

const op = spanToJSON(rootSpan).op;

// Only use this root span if it is a pageload or navigation span
return op === 'navigation' || op === 'pageload' ? rootSpan : undefined;
}

function getParameterizedRoute(routerState: RouterState): string {
const lastMatch = routerState.matches[routerState.matches.length - 1];
return normalizePathname(lastMatch?.route.path ?? routerState.location.pathname);
}

function normalizePathname(pathname: string): string {
// Ensure it starts with a single slash
let normalized = pathname.startsWith('/') ? pathname : `/${pathname}`;
// Remove trailing slash unless it's the root
if (normalized.length > 1 && normalized.endsWith('/')) {
normalized = normalized.slice(0, -1);
}
return normalized;
}
1 change: 1 addition & 0 deletions packages/react-router/src/client/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
export * from '@sentry/browser';

export { init } from './sdk';
export { reactRouterTracingIntegration } from './tracingIntegration';
26 changes: 20 additions & 6 deletions packages/react-router/src/client/sdk.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,33 @@
import type { BrowserOptions } from '@sentry/browser';
import { init as browserInit } from '@sentry/browser';
import type { Client } from '@sentry/core';
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata, consoleSandbox, setTag } from '@sentry/core';

const BROWSER_TRACING_INTEGRATION_ID = 'BrowserTracing';

/**
* Initializes the client side of the React Router SDK.
*/
export function init(options: BrowserOptions): Client | undefined {
const opts = {
...options,
};
// If BrowserTracing integration was passed to options, emit a warning
if (options.integrations && Array.isArray(options.integrations)) {
const hasBrowserTracing = options.integrations.some(
integration => integration.name === BROWSER_TRACING_INTEGRATION_ID,
);

if (hasBrowserTracing) {
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn(
'browserTracingIntegration is not fully compatible with @sentry/react-router. Please use reactRouterTracingIntegration instead.',
);
});
}
}

applySdkMetadata(opts, 'react-router', ['react-router', 'browser']);
applySdkMetadata(options, 'react-router', ['react-router', 'browser']);

const client = browserInit(opts);
const client = browserInit(options);

setTag('runtime', 'browser');

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(react-router): Add client-side router instrumentation by chargome · Pull Request #16185 · getsentry/sentry-javascript · GitHub
Skip to content
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ Sentry.init({
// todo: get this from env
dsn: 'https://username@domain/123',
tunnel: `http://localhost:3031/`, // proxy server
integrations: [Sentry.browserTracingIntegration()],
integrations: [Sentry.reactRouterTracingIntegration()],
tracesSampleRate: 1.0,
tracePropagationTargets: [/^\//],
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ export default [
]),
...prefix('performance', [
index('routes/performance/index.tsx'),
route('ssr', 'routes/performance/ssr.tsx'),
route('with/:param', 'routes/performance/dynamic-param.tsx'),
route('static', 'routes/performance/static.tsx'),
]),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
import { Link } from 'react-router';

export default function PerformancePage() {
return <h1>Performance Page</h1>;
return (
<div>
<h1>Performance Page</h1>
<nav>
<Link to="/performance/ssr">SSR Page</Link>
<Link to="/performance/with/sentry">With Param Page</Link>
</nav>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export default function SsrPage() {
return (
<div>
<h1>SSR Page</h1>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { APP_NAME } from '../constants';

test.describe('client - navigation performance', () => {
test('should create navigation transaction', async ({ page }) => {
const navigationPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/ssr';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'SSR Page' }).click(); // navigation

const transaction = await navigationPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'url',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/ssr',
type: 'transaction',
transaction_info: { source: 'url' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/ssr'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'With Param Page' }).click(); // navigation

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'route',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,56 @@ test.describe('client - pageload performance', () => {
});
});

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance/with/sentry`);

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

// todo: this page is currently not prerendered (see react-router.config.ts)
test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
Expand Down
147 changes: 147 additions & 0 deletions packages/react-router/src/client/hydratedRouter.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,147 @@
import { startBrowserTracingNavigationSpan } from '@sentry/browser';
import type { Span } from '@sentry/core';
import {
consoleSandbox,
getActiveSpan,
getClient,
getRootSpan,
GLOBAL_OBJ,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
spanToJSON,
} from '@sentry/core';
import type { DataRouter, RouterState } from 'react-router';
import { DEBUG_BUILD } from '../common/debug-build';

const GLOBAL_OBJ_WITH_DATA_ROUTER = GLOBAL_OBJ as typeof GLOBAL_OBJ & {
__reactRouterDataRouter?: DataRouter;
};

const MAX_RETRIES = 40; // 2 seconds at 50ms interval

/**
* Instruments the React Router Data Router for pageloads and navigation.
*
* This function waits for the router to be available after hydration, then:
* 1. Updates the pageload transaction with parameterized route info
* 2. Patches router.navigate() to create navigation transactions
* 3. Subscribes to router state changes to update navigation transactions with parameterized routes
*/
export function instrumentHydratedRouter(): void {
function trySubscribe(): boolean {
const router = GLOBAL_OBJ_WITH_DATA_ROUTER.__reactRouterDataRouter;

if (router) {
// The first time we hit the router, we try to update the pageload transaction
// todo: update pageload tx here
const pageloadSpan = getActiveRootSpan();
const pageloadName = pageloadSpan ? spanToJSON(pageloadSpan).description : undefined;
const parameterizePageloadRoute = getParameterizedRoute(router.state);
if (
pageloadName &&
normalizePathname(router.state.location.pathname) === normalizePathname(pageloadName) && // this event is for the currently active pageload
normalizePathname(parameterizePageloadRoute) !== normalizePathname(pageloadName) // route is not parameterized yet
) {
pageloadSpan?.updateName(parameterizePageloadRoute);
pageloadSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}

// Patching navigate for creating accurate navigation transactions
if (typeof router.navigate === 'function') {
const originalNav = router.navigate.bind(router);
router.navigate = function sentryPatchedNavigate(...args) {
maybeCreateNavigationTransaction(
String(args[0]) || '<unknown route>', // will be updated anyway
'url', // this also will be updated once we have the parameterized route
);
return originalNav(...args);
};
}

// Subscribe to router state changes to update navigation transactions with parameterized routes
router.subscribe(newState => {
const navigationSpan = getActiveRootSpan();
const navigationSpanName = navigationSpan ? spanToJSON(navigationSpan).description : undefined;
const parameterizedNavRoute = getParameterizedRoute(newState);

if (
navigationSpanName && // we have an active pageload tx
newState.navigation.state === 'idle' && // navigation has completed
normalizePathname(newState.location.pathname) === normalizePathname(navigationSpanName) && // this event is for the currently active navigation
normalizePathname(parameterizedNavRoute) !== normalizePathname(navigationSpanName) // route is not parameterized yet
) {
navigationSpan?.updateName(parameterizedNavRoute);
navigationSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}
});
return true;
}
return false;
}

// Wait until the router is available (since the SDK loads before hydration)
if (!trySubscribe()) {
let retryCount = 0;
// Retry until the router is available or max retries reached
Comment thread
chargome marked this conversation as resolved.
const interval = setInterval(() => {
if (trySubscribe() || retryCount >= MAX_RETRIES) {
if (retryCount >= MAX_RETRIES) {
DEBUG_BUILD &&
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn('Unable to instrument React Router: router not found after hydration.');
});
}
clearInterval(interval);
}
retryCount++;
}, 50);
}
}

function maybeCreateNavigationTransaction(name: string, source: 'url' | 'route'): Span | undefined {
const client = getClient();

if (!client) {
return undefined;
}

return startBrowserTracingNavigationSpan(client, {
name,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: source,
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.react-router',
},
});
}

function getActiveRootSpan(): Span | undefined {
const activeSpan = getActiveSpan();
if (!activeSpan) {
return undefined;
}

const rootSpan = getRootSpan(activeSpan);

const op = spanToJSON(rootSpan).op;

// Only use this root span if it is a pageload or navigation span
return op === 'navigation' || op === 'pageload' ? rootSpan : undefined;
}

function getParameterizedRoute(routerState: RouterState): string {
const lastMatch = routerState.matches[routerState.matches.length - 1];
return normalizePathname(lastMatch?.route.path ?? routerState.location.pathname);
}

function normalizePathname(pathname: string): string {
// Ensure it starts with a single slash
let normalized = pathname.startsWith('/') ? pathname : `/${pathname}`;
// Remove trailing slash unless it's the root
if (normalized.length > 1 && normalized.endsWith('/')) {
normalized = normalized.slice(0, -1);
}
return normalized;
}
1 change: 1 addition & 0 deletions packages/react-router/src/client/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
export * from '@sentry/browser';

export { init } from './sdk';
export { reactRouterTracingIntegration } from './tracingIntegration';
26 changes: 20 additions & 6 deletions packages/react-router/src/client/sdk.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,33 @@
import type { BrowserOptions } from '@sentry/browser';
import { init as browserInit } from '@sentry/browser';
import type { Client } from '@sentry/core';
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata, consoleSandbox, setTag } from '@sentry/core';

const BROWSER_TRACING_INTEGRATION_ID = 'BrowserTracing';

/**
* Initializes the client side of the React Router SDK.
*/
export function init(options: BrowserOptions): Client | undefined {
const opts = {
...options,
};
// If BrowserTracing integration was passed to options, emit a warning
if (options.integrations && Array.isArray(options.integrations)) {
const hasBrowserTracing = options.integrations.some(
integration => integration.name === BROWSER_TRACING_INTEGRATION_ID,
);

if (hasBrowserTracing) {
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn(
'browserTracingIntegration is not fully compatible with @sentry/react-router. Please use reactRouterTracingIntegration instead.',
);
});
}
}

applySdkMetadata(opts, 'react-router', ['react-router', 'browser']);
applySdkMetadata(options, 'react-router', ['react-router', 'browser']);

const client = browserInit(opts);
const client = browserInit(options);

setTag('runtime', 'browser');

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(react-router): Add client-side router instrumentation by chargome · Pull Request #16185 · getsentry/sentry-javascript · GitHub
Skip to content
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ Sentry.init({
// todo: get this from env
dsn: 'https://username@domain/123',
tunnel: `http://localhost:3031/`, // proxy server
integrations: [Sentry.browserTracingIntegration()],
integrations: [Sentry.reactRouterTracingIntegration()],
tracesSampleRate: 1.0,
tracePropagationTargets: [/^\//],
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ export default [
]),
...prefix('performance', [
index('routes/performance/index.tsx'),
route('ssr', 'routes/performance/ssr.tsx'),
route('with/:param', 'routes/performance/dynamic-param.tsx'),
route('static', 'routes/performance/static.tsx'),
]),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
import { Link } from 'react-router';

export default function PerformancePage() {
return <h1>Performance Page</h1>;
return (
<div>
<h1>Performance Page</h1>
<nav>
<Link to="/performance/ssr">SSR Page</Link>
<Link to="/performance/with/sentry">With Param Page</Link>
</nav>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export default function SsrPage() {
return (
<div>
<h1>SSR Page</h1>
</div>
);
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { APP_NAME } from '../constants';

test.describe('client - navigation performance', () => {
test('should create navigation transaction', async ({ page }) => {
const navigationPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/ssr';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'SSR Page' }).click(); // navigation

const transaction = await navigationPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'url',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/ssr',
type: 'transaction',
transaction_info: { source: 'url' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/ssr'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance`); // pageload
await page.waitForTimeout(1000); // give it a sec before navigation
await page.getByRole('link', { name: 'With Param Page' }).click(); // navigation

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.navigation.react-router',
'sentry.op': 'navigation',
'sentry.source': 'route',
},
op: 'navigation',
origin: 'auto.navigation.react-router',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,56 @@ test.describe('client - pageload performance', () => {
});
});

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
});

await page.goto(`/performance/with/sentry`);

const transaction = await txPromise;

expect(transaction).toMatchObject({
contexts: {
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
data: {
'sentry.origin': 'auto.pageload.browser',
'sentry.op': 'pageload',
'sentry.source': 'route',
},
op: 'pageload',
origin: 'auto.pageload.browser',
},
},
spans: expect.any(Array),
start_timestamp: expect.any(Number),
timestamp: expect.any(Number),
transaction: '/performance/with/:param',
type: 'transaction',
transaction_info: { source: 'route' },
measurements: expect.any(Object),
platform: 'javascript',
request: {
url: expect.stringContaining('/performance/with/sentry'),
headers: expect.any(Object),
},
event_id: expect.any(String),
environment: 'qa',
sdk: {
integrations: expect.arrayContaining([expect.any(String)]),
name: 'sentry.javascript.react-router',
version: expect.any(String),
packages: [
{ name: 'npm:@sentry/react-router', version: expect.any(String) },
{ name: 'npm:@sentry/browser', version: expect.any(String) },
],
},
tags: { runtime: 'browser' },
});
});

// todo: this page is currently not prerendered (see react-router.config.ts)
test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
Expand Down
147 changes: 147 additions & 0 deletions packages/react-router/src/client/hydratedRouter.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,147 @@
import { startBrowserTracingNavigationSpan } from '@sentry/browser';
import type { Span } from '@sentry/core';
import {
consoleSandbox,
getActiveSpan,
getClient,
getRootSpan,
GLOBAL_OBJ,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
spanToJSON,
} from '@sentry/core';
import type { DataRouter, RouterState } from 'react-router';
import { DEBUG_BUILD } from '../common/debug-build';

const GLOBAL_OBJ_WITH_DATA_ROUTER = GLOBAL_OBJ as typeof GLOBAL_OBJ & {
__reactRouterDataRouter?: DataRouter;
};

const MAX_RETRIES = 40; // 2 seconds at 50ms interval

/**
* Instruments the React Router Data Router for pageloads and navigation.
*
* This function waits for the router to be available after hydration, then:
* 1. Updates the pageload transaction with parameterized route info
* 2. Patches router.navigate() to create navigation transactions
* 3. Subscribes to router state changes to update navigation transactions with parameterized routes
*/
export function instrumentHydratedRouter(): void {
function trySubscribe(): boolean {
const router = GLOBAL_OBJ_WITH_DATA_ROUTER.__reactRouterDataRouter;

if (router) {
// The first time we hit the router, we try to update the pageload transaction
// todo: update pageload tx here
const pageloadSpan = getActiveRootSpan();
const pageloadName = pageloadSpan ? spanToJSON(pageloadSpan).description : undefined;
const parameterizePageloadRoute = getParameterizedRoute(router.state);
if (
pageloadName &&
normalizePathname(router.state.location.pathname) === normalizePathname(pageloadName) && // this event is for the currently active pageload
normalizePathname(parameterizePageloadRoute) !== normalizePathname(pageloadName) // route is not parameterized yet
) {
pageloadSpan?.updateName(parameterizePageloadRoute);
pageloadSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}

// Patching navigate for creating accurate navigation transactions
if (typeof router.navigate === 'function') {
const originalNav = router.navigate.bind(router);
router.navigate = function sentryPatchedNavigate(...args) {
maybeCreateNavigationTransaction(
String(args[0]) || '<unknown route>', // will be updated anyway
'url', // this also will be updated once we have the parameterized route
);
return originalNav(...args);
};
}

// Subscribe to router state changes to update navigation transactions with parameterized routes
router.subscribe(newState => {
const navigationSpan = getActiveRootSpan();
const navigationSpanName = navigationSpan ? spanToJSON(navigationSpan).description : undefined;
const parameterizedNavRoute = getParameterizedRoute(newState);

if (
navigationSpanName && // we have an active pageload tx
newState.navigation.state === 'idle' && // navigation has completed
normalizePathname(newState.location.pathname) === normalizePathname(navigationSpanName) && // this event is for the currently active navigation
normalizePathname(parameterizedNavRoute) !== normalizePathname(navigationSpanName) // route is not parameterized yet
) {
navigationSpan?.updateName(parameterizedNavRoute);
navigationSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
}
});
return true;
}
return false;
}

// Wait until the router is available (since the SDK loads before hydration)
if (!trySubscribe()) {
let retryCount = 0;
// Retry until the router is available or max retries reached
Comment thread
chargome marked this conversation as resolved.
const interval = setInterval(() => {
if (trySubscribe() || retryCount >= MAX_RETRIES) {
if (retryCount >= MAX_RETRIES) {
DEBUG_BUILD &&
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn('Unable to instrument React Router: router not found after hydration.');
});
}
clearInterval(interval);
}
retryCount++;
}, 50);
}
}

function maybeCreateNavigationTransaction(name: string, source: 'url' | 'route'): Span | undefined {
const client = getClient();

if (!client) {
return undefined;
}

return startBrowserTracingNavigationSpan(client, {
name,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: source,
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.react-router',
},
});
}

function getActiveRootSpan(): Span | undefined {
const activeSpan = getActiveSpan();
if (!activeSpan) {
return undefined;
}

const rootSpan = getRootSpan(activeSpan);

const op = spanToJSON(rootSpan).op;

// Only use this root span if it is a pageload or navigation span
return op === 'navigation' || op === 'pageload' ? rootSpan : undefined;
}

function getParameterizedRoute(routerState: RouterState): string {
const lastMatch = routerState.matches[routerState.matches.length - 1];
return normalizePathname(lastMatch?.route.path ?? routerState.location.pathname);
}

function normalizePathname(pathname: string): string {
// Ensure it starts with a single slash
let normalized = pathname.startsWith('/') ? pathname : `/${pathname}`;
// Remove trailing slash unless it's the root
if (normalized.length > 1 && normalized.endsWith('/')) {
normalized = normalized.slice(0, -1);
}
return normalized;
}
1 change: 1 addition & 0 deletions packages/react-router/src/client/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
export * from '@sentry/browser';

export { init } from './sdk';
export { reactRouterTracingIntegration } from './tracingIntegration';
26 changes: 20 additions & 6 deletions packages/react-router/src/client/sdk.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,33 @@
import type { BrowserOptions } from '@sentry/browser';
import { init as browserInit } from '@sentry/browser';
import type { Client } from '@sentry/core';
import { applySdkMetadata, setTag } from '@sentry/core';
import { applySdkMetadata, consoleSandbox, setTag } from '@sentry/core';

const BROWSER_TRACING_INTEGRATION_ID = 'BrowserTracing';

/**
* Initializes the client side of the React Router SDK.
*/
export function init(options: BrowserOptions): Client | undefined {
const opts = {
...options,
};
// If BrowserTracing integration was passed to options, emit a warning
if (options.integrations && Array.isArray(options.integrations)) {
const hasBrowserTracing = options.integrations.some(
integration => integration.name === BROWSER_TRACING_INTEGRATION_ID,
);

if (hasBrowserTracing) {
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn(
'browserTracingIntegration is not fully compatible with @sentry/react-router. Please use reactRouterTracingIntegration instead.',
);
});
}
}

applySdkMetadata(opts, 'react-router', ['react-router', 'browser']);
applySdkMetadata(options, 'react-router', ['react-router', 'browser']);

const client = browserInit(opts);
const client = browserInit(options);

setTag('runtime', 'browser');

Expand Down
Loading