ci(v7): Bump to ubuntu-24.04 - #17083

Merged
mydea merged 24 commits into
v7from
fn/v7-ubuntu-ci
Jul 24, 2025
Merged

ci(v7): Bump to ubuntu-24.04#17083
mydea merged 24 commits into
v7from
fn/v7-ubuntu-ci

Conversation

@mydea

@mydeamydea commented Jul 18, 2025•
edited
Loading

Copy link
Copy Markdown
Member

ubuntu-20.04 is no longer working, so CI is no longer working and nothing can be merged in v7 :O

Changes required to make this work:

  • Skip all playwright tests on CI :( We need to manually test changes locally instead. Playwright in this version simply does not like ubuntu-24.04
  • Skip mongoose/mongodb tests because they somehow also fail
  • Stop compiling node profiling binaries - we vendor them in instead
  • Size limit action fails because the comparison artifacts have expired 😅

@mydea
mydea requested review from Lms24 and andreiborzaJuly 18, 2025 11:20
@mydeamydea self-assigned this Jul 18, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actionsBot commented Jul 18, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)80.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)71.9 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)76.15 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)65.53 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped)35.78 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)35.67 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped)31.71 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)31.73 KB (added)
@sentry/browser - Webpack (gzipped)22.92 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)79.18 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)70.5 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)36.17 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped)25.42 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)221.94 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)109.54 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)76.26 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)39.48 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)72.4 KB (added)
@sentry/react - Webpack (gzipped)22.95 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)90.16 KB (added)
@sentry/nextjs Client - Webpack (gzipped)54.28 KB (added)
@sentry-internal/feedback - Webpack (gzipped)17.34 KB (added)

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]
cursorBot reviewed Jul 21, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Tests Fail Due to Missing Dependencies

Playwright tests are failing on Ubuntu 24.04 runners in job_nextjs_integration_test, job_browser_playwright_tests, and job_browser_loader_tests. This is because the npx playwright install --with-deps flag and the npx playwright install-deps step were removed from these jobs. Although OS dependencies are installed in job_install_deps, each GitHub Actions job runs on a fresh runner, preventing these dependencies from being available to the separate Playwright test jobs.

.github/workflows/build.yml#L614-L620

sentry-javascript/.github/workflows/build.yml

Lines 614 to 620 in 5e1e26b

key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
- name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
run: npx playwright install
env:
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
- name: Run tests

.github/workflows/build.yml#L706-L710

sentry-javascript/.github/workflows/build.yml

Lines 706 to 710 in 5e1e26b

- name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env:
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}

.github/workflows/build.yml#L759-L763

sentry-javascript/.github/workflows/build.yml

Lines 759 to 763 in 5e1e26b

- name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env:
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}

Fix in Cursor • Fix in Web

Bug: Missing Directory Causes Build Script Failure

The build:copy-bindings script attempts to copy from compiled-bindings/ to lib/. However, the node-gyp build steps (and associated CI job) that previously created and populated compiled-bindings/ have been removed. This results in the compiled-bindings/ directory not existing, causing the cp command to fail and break the build process.

packages/profiling-node/package.json#L53-L54

sentry-javascript/packages/profiling-node/package.json

Lines 53 to 54 in 5e1e26b

"build:types:watch": "tsc -p tsconfig.types.json --watch",
"build:copy-bindings": "cp -r compiled-bindings/ lib/",

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

cursor[bot]
cursorBot reviewed Jul 24, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Browser Installation Script Removed

The postinstall script, which automatically installed Playwright browsers via yarn install-browsers, was removed. This causes browser integration tests to fail due to missing browsers unless they are manually installed.

dev-packages/browser-integration-tests/package.json#L14-L16

sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 16 in 353f1ef

"fix": "eslint . --format stylish --fix",
"type-check": "tsc",
"pretest": "yarn clean && yarn type-check",

Fix in Cursor • Fix in Web

Comment thread.github/workflows/build.yml
name: Nextjs (Node ${{ matrix.node }}) Tests
needs: [job_get_metadata, job_build]
if: needs.job_get_metadata.outputs.changed_nextjs == 'true' || github.event_name != 'pull_request'
if: false

@cursorcursorBotJul 24, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Next.js Integration Tests Disabled

The job_nextjs_integration_test is completely disabled by setting its if condition to false. This likely accidental change prevents important Next.js integration tests from running, potentially masking functionality issues, especially after the upgrade to Ubuntu 24.04.

Locations (1)

Fix in Cursor • Fix in Web

cursor[bot]
cursorBot reviewed Jul 24, 2025
View reviewed changes
Comment thread.github/workflows/build.yml
Comment threadpackages/profiling-node/package.json
"test:bundle": "node test-binaries.esbuild.js",
"test": "cross-env SENTRY_PROFILER_BINARY_DIR=lib jest --config jest.config.js"
"test:watch": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --watch",
"test": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --config jest.config.js"

@cursorcursorBotJul 24, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Node Profiling Build Fails Due to Missing Bindings

The packages/profiling-node build and test scripts now rely on a compiled-bindings directory that is never created or populated. The build:copy-bindings script attempts to copy from this non-existent directory, leading to build failures. Similarly, test scripts set SENTRY_PROFILER_BINARY_DIR to this missing directory, preventing tests from running. This change removed the previous node-gyp steps responsible for generating these bindings.

Locations (1)

Fix in Cursor • Fix in Web

cursor[bot]
cursorBot reviewed Jul 24, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Postinstall Script Causes Test Failures

The postinstall script, "yarn install-browsers", was removed from dev-packages/browser-integration-tests/package.json. This script automatically installed Playwright browsers. Its removal prevents automatic browser installation during dependency setup, leading to browser integration test failures for local developers.

dev-packages/browser-integration-tests/package.json#L14-L15

sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 15 in 3e6a498

"fix": "eslint . --format stylish --fix",
"type-check": "tsc",

Fix in Cursor • Fix in Web

@mydea
mydea merged commit bc8bbb6 into v7Jul 24, 2025
80 of 82 checks passed
@mydea
mydea deleted the fn/v7-ubuntu-ci branch July 24, 2025 15:03
@mydeamydea mentioned this pull request Jul 24, 2025
Closed
@AdriVanHoudtAdriVanHoudt mentioned this pull request Aug 22, 2025
Closed
3 tasks
@mydeamydea mentioned this pull request Sep 2, 2025
Closed
@onurtemizkanonurtemizkan mentioned this pull request Sep 11, 2025
Merged
s1gr1d pushed a commit that referenced this pull request Sep 17, 2025
@onurtemizkan
ci(v8): Bump to ubuntu-24.04 (#17507)
22f3fa3
This PR unblocks backports to `v8` branch, similarly to what's done for
v7 (#17083)
Summary:
- Skip `size-check`
- Skip webkit / firefox playwright tests (so also flaky test detection)
- Upgrade playwright versions to `1.52.0`
- Skip a few browser tests that are flaky or failing on ubuntu-24.04
- Update nuxt e2e test configurations
- Use node-profiler binding binaries
- Skip nextjs canary tests
- Skip mongodb, mongoose and amqplib tests
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@andreiborzaandreiborzaandreiborza approved these changes

Assignees

@mydeamydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@Lms24@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ci(v7): Bump to ubuntu-24.04 - #17083
Merged
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Jul 24, 2025
Merged
ci(v7): Bump to ubuntu-24.04#17083
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Conversation
@mydea
@mydeamydea
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Member
ubuntu-20.04 is no longer working, so CI is no longer working and nothing can be merged in v7 :O
Changes required to make this work:
  • Skip all playwright tests on CI :( We need to manually test changes locally instead. Playwright in this version simply does not like ubuntu-24.04
  • Skip mongoose/mongodb tests because they somehow also fail
  • Stop compiling node profiling binaries - we vendor them in instead
  • Size limit action fails because the comparison artifacts have expired 😅
@mydea
mydea
requested review from
Lms24 and andreiborzaJuly 18, 2025 11:20
@mydeamydea
self-assigned this
Jul 18, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
@github-actions
github-actionsBot
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)80.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)71.9 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)76.15 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)65.53 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped)35.78 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)35.67 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped)31.71 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)31.73 KB (added)
@sentry/browser - Webpack (gzipped)22.92 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)79.18 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)70.5 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)36.17 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped)25.42 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)221.94 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)109.54 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)76.26 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)39.48 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)72.4 KB (added)
@sentry/react - Webpack (gzipped)22.95 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)90.16 KB (added)
@sentry/nextjs Client - Webpack (gzipped)54.28 KB (added)
@sentry-internal/feedback - Webpack (gzipped)17.34 KB (added)
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]
cursorBot
reviewed
Jul 21, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Tests Fail Due to Missing Dependencies
Playwright tests are failing on Ubuntu 24.04 runners in job_nextjs_integration_test, job_browser_playwright_tests, and job_browser_loader_tests. This is because the npx playwright install --with-deps flag and the npx playwright install-deps step were removed from these jobs. Although OS dependencies are installed in job_install_deps, each GitHub Actions job runs on a fresh runner, preventing these dependencies from being available to the separate Playwright test jobs.
.github/workflows/build.yml#L614-L620
sentry-javascript/.github/workflows/build.yml

Lines 614 to 620
in
5e1e26b
key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
 - name: Run tests
.github/workflows/build.yml#L706-L710
sentry-javascript/.github/workflows/build.yml

Lines 706 to 710
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
.github/workflows/build.yml#L759-L763
sentry-javascript/.github/workflows/build.yml

Lines 759 to 763
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
Fix in Cursor • Fix in Web
Bug: Missing Directory Causes Build Script Failure
The build:copy-bindings script attempts to copy from compiled-bindings/ to lib/. However, the node-gyp build steps (and associated CI job) that previously created and populated compiled-bindings/ have been removed. This results in the compiled-bindings/ directory not existing, causing the cp command to fail and break the build process.
packages/profiling-node/package.json#L53-L54
sentry-javascript/packages/profiling-node/package.json

Lines 53 to 54
in
5e1e26b
"build:types:watch": "tsc -p tsconfig.types.json --watch", 
"build:copy-bindings": "cp -r compiled-bindings/ lib/", 
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Browser Installation Script Removed
The postinstall script, which automatically installed Playwright browsers via yarn install-browsers, was removed. This causes browser integration tests to fail due to missing browsers unless they are manually installed.
dev-packages/browser-integration-tests/package.json#L14-L16
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 16
in
353f1ef
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
"pretest": "yarn clean && yarn type-check", 
Fix in Cursor • Fix in Web
Comment thread.github/workflows/build.yml
 name: Nextjs (Node ${{ matrix.node }}) Tests
 needs: [job_get_metadata, job_build]
 if: needs.job_get_metadata.outputs.changed_nextjs == 'true' || github.event_name != 'pull_request'
 if: false
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Next.js Integration Tests Disabled
The job_nextjs_integration_test is completely disabled by setting its if condition to false. This likely accidental change prevents important Next.js integration tests from running, potentially masking functionality issues, especially after the upgrade to Ubuntu 24.04.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
Comment thread.github/workflows/build.yml
Comment threadpackages/profiling-node/package.json
 "test:bundle": "node test-binaries.esbuild.js",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=lib jest --config jest.config.js"
 "test:watch": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --watch",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --config jest.config.js"
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Node Profiling Build Fails Due to Missing Bindings
The packages/profiling-node build and test scripts now rely on a compiled-bindings directory that is never created or populated. The build:copy-bindings script attempts to copy from this non-existent directory, leading to build failures. Similarly, test scripts set SENTRY_PROFILER_BINARY_DIR to this missing directory, preventing tests from running. This change removed the previous node-gyp steps responsible for generating these bindings.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Postinstall Script Causes Test Failures
The postinstall script, "yarn install-browsers", was removed from dev-packages/browser-integration-tests/package.json. This script automatically installed Playwright browsers. Its removal prevents automatic browser installation during dependency setup, leading to browser integration test failures for local developers.
dev-packages/browser-integration-tests/package.json#L14-L15
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 15
in
3e6a498
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
Fix in Cursor • Fix in Web
@mydea
mydea
merged commit bc8bbb6
into
v7Jul 24, 2025

80 of 82 checks passed

@mydea
mydea
deleted the

fn/v7-ubuntu-ci

branch
July 24, 2025 15:03
@mydeamydea
mentioned this pull request
Jul 24, 2025
 Closed

@AdriVanHoudtAdriVanHoudt
mentioned this pull request
Aug 22, 2025

Closed

3 tasks
@mydeamydea
mentioned this pull request
Sep 2, 2025
 Closed

@onurtemizkanonurtemizkan
mentioned this pull request
Sep 11, 2025
 Merged

s1gr1d pushed a commit
that referenced
this pull request
Sep 17, 2025
@onurtemizkan
ci(v8): Bump to ubuntu-24.04 (#17507)
22f3fa3
This PR unblocks backports to `v8` branch, similarly to what's done for
v7 (#17083)
Summary:
- Skip `size-check`
- Skip webkit / firefox playwright tests (so also flaky test detection)
- Upgrade playwright versions to `1.52.0`
- Skip a few browser tests that are flaky or failing on ubuntu-24.04
- Update nuxt e2e test configurations
- Use node-profiler binding binaries
- Skip nextjs canary tests
- Skip mongodb, mongoose and amqplib tests
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@andreiborzaandreiborzaandreiborza approved these changes

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@Lms24@andreiborza

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ci(v7): Bump to ubuntu-24.04 - #17083
Merged
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Jul 24, 2025
Merged
ci(v7): Bump to ubuntu-24.04#17083
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Conversation
@mydea
@mydeamydea
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Member
ubuntu-20.04 is no longer working, so CI is no longer working and nothing can be merged in v7 :O
Changes required to make this work:
  • Skip all playwright tests on CI :( We need to manually test changes locally instead. Playwright in this version simply does not like ubuntu-24.04
  • Skip mongoose/mongodb tests because they somehow also fail
  • Stop compiling node profiling binaries - we vendor them in instead
  • Size limit action fails because the comparison artifacts have expired 😅
@mydea
mydea
requested review from
Lms24 and andreiborzaJuly 18, 2025 11:20
@mydeamydea
self-assigned this
Jul 18, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
@github-actions
github-actionsBot
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)80.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)71.9 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)76.15 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)65.53 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped)35.78 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)35.67 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped)31.71 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)31.73 KB (added)
@sentry/browser - Webpack (gzipped)22.92 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)79.18 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)70.5 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)36.17 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped)25.42 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)221.94 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)109.54 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)76.26 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)39.48 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)72.4 KB (added)
@sentry/react - Webpack (gzipped)22.95 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)90.16 KB (added)
@sentry/nextjs Client - Webpack (gzipped)54.28 KB (added)
@sentry-internal/feedback - Webpack (gzipped)17.34 KB (added)
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]
cursorBot
reviewed
Jul 21, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Tests Fail Due to Missing Dependencies
Playwright tests are failing on Ubuntu 24.04 runners in job_nextjs_integration_test, job_browser_playwright_tests, and job_browser_loader_tests. This is because the npx playwright install --with-deps flag and the npx playwright install-deps step were removed from these jobs. Although OS dependencies are installed in job_install_deps, each GitHub Actions job runs on a fresh runner, preventing these dependencies from being available to the separate Playwright test jobs.
.github/workflows/build.yml#L614-L620
sentry-javascript/.github/workflows/build.yml

Lines 614 to 620
in
5e1e26b
key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
 - name: Run tests
.github/workflows/build.yml#L706-L710
sentry-javascript/.github/workflows/build.yml

Lines 706 to 710
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
.github/workflows/build.yml#L759-L763
sentry-javascript/.github/workflows/build.yml

Lines 759 to 763
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
Fix in Cursor • Fix in Web
Bug: Missing Directory Causes Build Script Failure
The build:copy-bindings script attempts to copy from compiled-bindings/ to lib/. However, the node-gyp build steps (and associated CI job) that previously created and populated compiled-bindings/ have been removed. This results in the compiled-bindings/ directory not existing, causing the cp command to fail and break the build process.
packages/profiling-node/package.json#L53-L54
sentry-javascript/packages/profiling-node/package.json

Lines 53 to 54
in
5e1e26b
"build:types:watch": "tsc -p tsconfig.types.json --watch", 
"build:copy-bindings": "cp -r compiled-bindings/ lib/", 
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Browser Installation Script Removed
The postinstall script, which automatically installed Playwright browsers via yarn install-browsers, was removed. This causes browser integration tests to fail due to missing browsers unless they are manually installed.
dev-packages/browser-integration-tests/package.json#L14-L16
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 16
in
353f1ef
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
"pretest": "yarn clean && yarn type-check", 
Fix in Cursor • Fix in Web
Comment thread.github/workflows/build.yml
 name: Nextjs (Node ${{ matrix.node }}) Tests
 needs: [job_get_metadata, job_build]
 if: needs.job_get_metadata.outputs.changed_nextjs == 'true' || github.event_name != 'pull_request'
 if: false
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Next.js Integration Tests Disabled
The job_nextjs_integration_test is completely disabled by setting its if condition to false. This likely accidental change prevents important Next.js integration tests from running, potentially masking functionality issues, especially after the upgrade to Ubuntu 24.04.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
Comment thread.github/workflows/build.yml
Comment threadpackages/profiling-node/package.json
 "test:bundle": "node test-binaries.esbuild.js",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=lib jest --config jest.config.js"
 "test:watch": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --watch",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --config jest.config.js"
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Node Profiling Build Fails Due to Missing Bindings
The packages/profiling-node build and test scripts now rely on a compiled-bindings directory that is never created or populated. The build:copy-bindings script attempts to copy from this non-existent directory, leading to build failures. Similarly, test scripts set SENTRY_PROFILER_BINARY_DIR to this missing directory, preventing tests from running. This change removed the previous node-gyp steps responsible for generating these bindings.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Postinstall Script Causes Test Failures
The postinstall script, "yarn install-browsers", was removed from dev-packages/browser-integration-tests/package.json. This script automatically installed Playwright browsers. Its removal prevents automatic browser installation during dependency setup, leading to browser integration test failures for local developers.
dev-packages/browser-integration-tests/package.json#L14-L15
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 15
in
3e6a498
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
Fix in Cursor • Fix in Web
@mydea
mydea
merged commit bc8bbb6
into
v7Jul 24, 2025

80 of 82 checks passed

@mydea
mydea
deleted the

fn/v7-ubuntu-ci

branch
July 24, 2025 15:03
@mydeamydea
mentioned this pull request
Jul 24, 2025
 Closed

@AdriVanHoudtAdriVanHoudt
mentioned this pull request
Aug 22, 2025

Closed

3 tasks
@mydeamydea
mentioned this pull request
Sep 2, 2025
 Closed

@onurtemizkanonurtemizkan
mentioned this pull request
Sep 11, 2025
 Merged

s1gr1d pushed a commit
that referenced
this pull request
Sep 17, 2025
@onurtemizkan
ci(v8): Bump to ubuntu-24.04 (#17507)
22f3fa3
This PR unblocks backports to `v8` branch, similarly to what's done for
v7 (#17083)
Summary:
- Skip `size-check`
- Skip webkit / firefox playwright tests (so also flaky test detection)
- Upgrade playwright versions to `1.52.0`
- Skip a few browser tests that are flaky or failing on ubuntu-24.04
- Update nuxt e2e test configurations
- Use node-profiler binding binaries
- Skip nextjs canary tests
- Skip mongodb, mongoose and amqplib tests
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@andreiborzaandreiborzaandreiborza approved these changes

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@Lms24@andreiborza

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ci(v7): Bump to ubuntu-24.04 - #17083
Merged
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Jul 24, 2025
Merged
ci(v7): Bump to ubuntu-24.04#17083
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Conversation
@mydea
@mydeamydea
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Member
ubuntu-20.04 is no longer working, so CI is no longer working and nothing can be merged in v7 :O
Changes required to make this work:
  • Skip all playwright tests on CI :( We need to manually test changes locally instead. Playwright in this version simply does not like ubuntu-24.04
  • Skip mongoose/mongodb tests because they somehow also fail
  • Stop compiling node profiling binaries - we vendor them in instead
  • Size limit action fails because the comparison artifacts have expired 😅
@mydea
mydea
requested review from
Lms24 and andreiborzaJuly 18, 2025 11:20
@mydeamydea
self-assigned this
Jul 18, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
@github-actions
github-actionsBot
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)80.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)71.9 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)76.15 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)65.53 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped)35.78 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)35.67 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped)31.71 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)31.73 KB (added)
@sentry/browser - Webpack (gzipped)22.92 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)79.18 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)70.5 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)36.17 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped)25.42 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)221.94 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)109.54 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)76.26 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)39.48 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)72.4 KB (added)
@sentry/react - Webpack (gzipped)22.95 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)90.16 KB (added)
@sentry/nextjs Client - Webpack (gzipped)54.28 KB (added)
@sentry-internal/feedback - Webpack (gzipped)17.34 KB (added)
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]
cursorBot
reviewed
Jul 21, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Tests Fail Due to Missing Dependencies
Playwright tests are failing on Ubuntu 24.04 runners in job_nextjs_integration_test, job_browser_playwright_tests, and job_browser_loader_tests. This is because the npx playwright install --with-deps flag and the npx playwright install-deps step were removed from these jobs. Although OS dependencies are installed in job_install_deps, each GitHub Actions job runs on a fresh runner, preventing these dependencies from being available to the separate Playwright test jobs.
.github/workflows/build.yml#L614-L620
sentry-javascript/.github/workflows/build.yml

Lines 614 to 620
in
5e1e26b
key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
 - name: Run tests
.github/workflows/build.yml#L706-L710
sentry-javascript/.github/workflows/build.yml

Lines 706 to 710
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
.github/workflows/build.yml#L759-L763
sentry-javascript/.github/workflows/build.yml

Lines 759 to 763
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
Fix in Cursor • Fix in Web
Bug: Missing Directory Causes Build Script Failure
The build:copy-bindings script attempts to copy from compiled-bindings/ to lib/. However, the node-gyp build steps (and associated CI job) that previously created and populated compiled-bindings/ have been removed. This results in the compiled-bindings/ directory not existing, causing the cp command to fail and break the build process.
packages/profiling-node/package.json#L53-L54
sentry-javascript/packages/profiling-node/package.json

Lines 53 to 54
in
5e1e26b
"build:types:watch": "tsc -p tsconfig.types.json --watch", 
"build:copy-bindings": "cp -r compiled-bindings/ lib/", 
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Browser Installation Script Removed
The postinstall script, which automatically installed Playwright browsers via yarn install-browsers, was removed. This causes browser integration tests to fail due to missing browsers unless they are manually installed.
dev-packages/browser-integration-tests/package.json#L14-L16
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 16
in
353f1ef
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
"pretest": "yarn clean && yarn type-check", 
Fix in Cursor • Fix in Web
Comment thread.github/workflows/build.yml
 name: Nextjs (Node ${{ matrix.node }}) Tests
 needs: [job_get_metadata, job_build]
 if: needs.job_get_metadata.outputs.changed_nextjs == 'true' || github.event_name != 'pull_request'
 if: false
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Next.js Integration Tests Disabled
The job_nextjs_integration_test is completely disabled by setting its if condition to false. This likely accidental change prevents important Next.js integration tests from running, potentially masking functionality issues, especially after the upgrade to Ubuntu 24.04.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
Comment thread.github/workflows/build.yml
Comment threadpackages/profiling-node/package.json
 "test:bundle": "node test-binaries.esbuild.js",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=lib jest --config jest.config.js"
 "test:watch": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --watch",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --config jest.config.js"
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Node Profiling Build Fails Due to Missing Bindings
The packages/profiling-node build and test scripts now rely on a compiled-bindings directory that is never created or populated. The build:copy-bindings script attempts to copy from this non-existent directory, leading to build failures. Similarly, test scripts set SENTRY_PROFILER_BINARY_DIR to this missing directory, preventing tests from running. This change removed the previous node-gyp steps responsible for generating these bindings.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Postinstall Script Causes Test Failures
The postinstall script, "yarn install-browsers", was removed from dev-packages/browser-integration-tests/package.json. This script automatically installed Playwright browsers. Its removal prevents automatic browser installation during dependency setup, leading to browser integration test failures for local developers.
dev-packages/browser-integration-tests/package.json#L14-L15
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 15
in
3e6a498
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
Fix in Cursor • Fix in Web
@mydea
mydea
merged commit bc8bbb6
into
v7Jul 24, 2025

80 of 82 checks passed

@mydea
mydea
deleted the

fn/v7-ubuntu-ci

branch
July 24, 2025 15:03
@mydeamydea
mentioned this pull request
Jul 24, 2025
 Closed

@AdriVanHoudtAdriVanHoudt
mentioned this pull request
Aug 22, 2025

Closed

3 tasks
@mydeamydea
mentioned this pull request
Sep 2, 2025
 Closed

@onurtemizkanonurtemizkan
mentioned this pull request
Sep 11, 2025
 Merged

s1gr1d pushed a commit
that referenced
this pull request
Sep 17, 2025
@onurtemizkan
ci(v8): Bump to ubuntu-24.04 (#17507)
22f3fa3
This PR unblocks backports to `v8` branch, similarly to what's done for
v7 (#17083)
Summary:
- Skip `size-check`
- Skip webkit / firefox playwright tests (so also flaky test detection)
- Upgrade playwright versions to `1.52.0`
- Skip a few browser tests that are flaky or failing on ubuntu-24.04
- Update nuxt e2e test configurations
- Use node-profiler binding binaries
- Skip nextjs canary tests
- Skip mongodb, mongoose and amqplib tests
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@andreiborzaandreiborzaandreiborza approved these changes

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@Lms24@andreiborza

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ci(v7): Bump to ubuntu-24.04 - #17083
Merged
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Jul 24, 2025
Merged
ci(v7): Bump to ubuntu-24.04#17083
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Conversation
@mydea
@mydeamydea
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Member
ubuntu-20.04 is no longer working, so CI is no longer working and nothing can be merged in v7 :O
Changes required to make this work:
  • Skip all playwright tests on CI :( We need to manually test changes locally instead. Playwright in this version simply does not like ubuntu-24.04
  • Skip mongoose/mongodb tests because they somehow also fail
  • Stop compiling node profiling binaries - we vendor them in instead
  • Size limit action fails because the comparison artifacts have expired 😅
@mydea
mydea
requested review from
Lms24 and andreiborzaJuly 18, 2025 11:20
@mydeamydea
self-assigned this
Jul 18, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
@github-actions
github-actionsBot
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)80.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)71.9 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)76.15 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)65.53 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped)35.78 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)35.67 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped)31.71 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)31.73 KB (added)
@sentry/browser - Webpack (gzipped)22.92 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)79.18 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)70.5 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)36.17 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped)25.42 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)221.94 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)109.54 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)76.26 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)39.48 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)72.4 KB (added)
@sentry/react - Webpack (gzipped)22.95 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)90.16 KB (added)
@sentry/nextjs Client - Webpack (gzipped)54.28 KB (added)
@sentry-internal/feedback - Webpack (gzipped)17.34 KB (added)
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]
cursorBot
reviewed
Jul 21, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Tests Fail Due to Missing Dependencies
Playwright tests are failing on Ubuntu 24.04 runners in job_nextjs_integration_test, job_browser_playwright_tests, and job_browser_loader_tests. This is because the npx playwright install --with-deps flag and the npx playwright install-deps step were removed from these jobs. Although OS dependencies are installed in job_install_deps, each GitHub Actions job runs on a fresh runner, preventing these dependencies from being available to the separate Playwright test jobs.
.github/workflows/build.yml#L614-L620
sentry-javascript/.github/workflows/build.yml

Lines 614 to 620
in
5e1e26b
key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
 - name: Run tests
.github/workflows/build.yml#L706-L710
sentry-javascript/.github/workflows/build.yml

Lines 706 to 710
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
.github/workflows/build.yml#L759-L763
sentry-javascript/.github/workflows/build.yml

Lines 759 to 763
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
Fix in Cursor • Fix in Web
Bug: Missing Directory Causes Build Script Failure
The build:copy-bindings script attempts to copy from compiled-bindings/ to lib/. However, the node-gyp build steps (and associated CI job) that previously created and populated compiled-bindings/ have been removed. This results in the compiled-bindings/ directory not existing, causing the cp command to fail and break the build process.
packages/profiling-node/package.json#L53-L54
sentry-javascript/packages/profiling-node/package.json

Lines 53 to 54
in
5e1e26b
"build:types:watch": "tsc -p tsconfig.types.json --watch", 
"build:copy-bindings": "cp -r compiled-bindings/ lib/", 
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Browser Installation Script Removed
The postinstall script, which automatically installed Playwright browsers via yarn install-browsers, was removed. This causes browser integration tests to fail due to missing browsers unless they are manually installed.
dev-packages/browser-integration-tests/package.json#L14-L16
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 16
in
353f1ef
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
"pretest": "yarn clean && yarn type-check", 
Fix in Cursor • Fix in Web
Comment thread.github/workflows/build.yml
 name: Nextjs (Node ${{ matrix.node }}) Tests
 needs: [job_get_metadata, job_build]
 if: needs.job_get_metadata.outputs.changed_nextjs == 'true' || github.event_name != 'pull_request'
 if: false
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Next.js Integration Tests Disabled
The job_nextjs_integration_test is completely disabled by setting its if condition to false. This likely accidental change prevents important Next.js integration tests from running, potentially masking functionality issues, especially after the upgrade to Ubuntu 24.04.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
Comment thread.github/workflows/build.yml
Comment threadpackages/profiling-node/package.json
 "test:bundle": "node test-binaries.esbuild.js",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=lib jest --config jest.config.js"
 "test:watch": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --watch",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --config jest.config.js"
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Node Profiling Build Fails Due to Missing Bindings
The packages/profiling-node build and test scripts now rely on a compiled-bindings directory that is never created or populated. The build:copy-bindings script attempts to copy from this non-existent directory, leading to build failures. Similarly, test scripts set SENTRY_PROFILER_BINARY_DIR to this missing directory, preventing tests from running. This change removed the previous node-gyp steps responsible for generating these bindings.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Postinstall Script Causes Test Failures
The postinstall script, "yarn install-browsers", was removed from dev-packages/browser-integration-tests/package.json. This script automatically installed Playwright browsers. Its removal prevents automatic browser installation during dependency setup, leading to browser integration test failures for local developers.
dev-packages/browser-integration-tests/package.json#L14-L15
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 15
in
3e6a498
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
Fix in Cursor • Fix in Web
@mydea
mydea
merged commit bc8bbb6
into
v7Jul 24, 2025

80 of 82 checks passed

@mydea
mydea
deleted the

fn/v7-ubuntu-ci

branch
July 24, 2025 15:03
@mydeamydea
mentioned this pull request
Jul 24, 2025
 Closed

@AdriVanHoudtAdriVanHoudt
mentioned this pull request
Aug 22, 2025

Closed

3 tasks
@mydeamydea
mentioned this pull request
Sep 2, 2025
 Closed

@onurtemizkanonurtemizkan
mentioned this pull request
Sep 11, 2025
 Merged

s1gr1d pushed a commit
that referenced
this pull request
Sep 17, 2025
@onurtemizkan
ci(v8): Bump to ubuntu-24.04 (#17507)
22f3fa3
This PR unblocks backports to `v8` branch, similarly to what's done for
v7 (#17083)
Summary:
- Skip `size-check`
- Skip webkit / firefox playwright tests (so also flaky test detection)
- Upgrade playwright versions to `1.52.0`
- Skip a few browser tests that are flaky or failing on ubuntu-24.04
- Update nuxt e2e test configurations
- Use node-profiler binding binaries
- Skip nextjs canary tests
- Skip mongodb, mongoose and amqplib tests
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@andreiborzaandreiborzaandreiborza approved these changes

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@Lms24@andreiborza

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ci(v7): Bump to ubuntu-24.04 - #17083
Merged
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Jul 24, 2025
Merged
ci(v7): Bump to ubuntu-24.04#17083
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Conversation
@mydea
@mydeamydea
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Member
ubuntu-20.04 is no longer working, so CI is no longer working and nothing can be merged in v7 :O
Changes required to make this work:
  • Skip all playwright tests on CI :( We need to manually test changes locally instead. Playwright in this version simply does not like ubuntu-24.04
  • Skip mongoose/mongodb tests because they somehow also fail
  • Stop compiling node profiling binaries - we vendor them in instead
  • Size limit action fails because the comparison artifacts have expired 😅
@mydea
mydea
requested review from
Lms24 and andreiborzaJuly 18, 2025 11:20
@mydeamydea
self-assigned this
Jul 18, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
@github-actions
github-actionsBot
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)80.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)71.9 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)76.15 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)65.53 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped)35.78 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)35.67 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped)31.71 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)31.73 KB (added)
@sentry/browser - Webpack (gzipped)22.92 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)79.18 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)70.5 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)36.17 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped)25.42 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)221.94 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)109.54 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)76.26 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)39.48 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)72.4 KB (added)
@sentry/react - Webpack (gzipped)22.95 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)90.16 KB (added)
@sentry/nextjs Client - Webpack (gzipped)54.28 KB (added)
@sentry-internal/feedback - Webpack (gzipped)17.34 KB (added)
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]
cursorBot
reviewed
Jul 21, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Tests Fail Due to Missing Dependencies
Playwright tests are failing on Ubuntu 24.04 runners in job_nextjs_integration_test, job_browser_playwright_tests, and job_browser_loader_tests. This is because the npx playwright install --with-deps flag and the npx playwright install-deps step were removed from these jobs. Although OS dependencies are installed in job_install_deps, each GitHub Actions job runs on a fresh runner, preventing these dependencies from being available to the separate Playwright test jobs.
.github/workflows/build.yml#L614-L620
sentry-javascript/.github/workflows/build.yml

Lines 614 to 620
in
5e1e26b
key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
 - name: Run tests
.github/workflows/build.yml#L706-L710
sentry-javascript/.github/workflows/build.yml

Lines 706 to 710
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
.github/workflows/build.yml#L759-L763
sentry-javascript/.github/workflows/build.yml

Lines 759 to 763
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
Fix in Cursor • Fix in Web
Bug: Missing Directory Causes Build Script Failure
The build:copy-bindings script attempts to copy from compiled-bindings/ to lib/. However, the node-gyp build steps (and associated CI job) that previously created and populated compiled-bindings/ have been removed. This results in the compiled-bindings/ directory not existing, causing the cp command to fail and break the build process.
packages/profiling-node/package.json#L53-L54
sentry-javascript/packages/profiling-node/package.json

Lines 53 to 54
in
5e1e26b
"build:types:watch": "tsc -p tsconfig.types.json --watch", 
"build:copy-bindings": "cp -r compiled-bindings/ lib/", 
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Browser Installation Script Removed
The postinstall script, which automatically installed Playwright browsers via yarn install-browsers, was removed. This causes browser integration tests to fail due to missing browsers unless they are manually installed.
dev-packages/browser-integration-tests/package.json#L14-L16
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 16
in
353f1ef
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
"pretest": "yarn clean && yarn type-check", 
Fix in Cursor • Fix in Web
Comment thread.github/workflows/build.yml
 name: Nextjs (Node ${{ matrix.node }}) Tests
 needs: [job_get_metadata, job_build]
 if: needs.job_get_metadata.outputs.changed_nextjs == 'true' || github.event_name != 'pull_request'
 if: false
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Next.js Integration Tests Disabled
The job_nextjs_integration_test is completely disabled by setting its if condition to false. This likely accidental change prevents important Next.js integration tests from running, potentially masking functionality issues, especially after the upgrade to Ubuntu 24.04.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
Comment thread.github/workflows/build.yml
Comment threadpackages/profiling-node/package.json
 "test:bundle": "node test-binaries.esbuild.js",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=lib jest --config jest.config.js"
 "test:watch": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --watch",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --config jest.config.js"
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Node Profiling Build Fails Due to Missing Bindings
The packages/profiling-node build and test scripts now rely on a compiled-bindings directory that is never created or populated. The build:copy-bindings script attempts to copy from this non-existent directory, leading to build failures. Similarly, test scripts set SENTRY_PROFILER_BINARY_DIR to this missing directory, preventing tests from running. This change removed the previous node-gyp steps responsible for generating these bindings.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Postinstall Script Causes Test Failures
The postinstall script, "yarn install-browsers", was removed from dev-packages/browser-integration-tests/package.json. This script automatically installed Playwright browsers. Its removal prevents automatic browser installation during dependency setup, leading to browser integration test failures for local developers.
dev-packages/browser-integration-tests/package.json#L14-L15
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 15
in
3e6a498
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
Fix in Cursor • Fix in Web
@mydea
mydea
merged commit bc8bbb6
into
v7Jul 24, 2025

80 of 82 checks passed

@mydea
mydea
deleted the

fn/v7-ubuntu-ci

branch
July 24, 2025 15:03
@mydeamydea
mentioned this pull request
Jul 24, 2025
 Closed

@AdriVanHoudtAdriVanHoudt
mentioned this pull request
Aug 22, 2025

Closed

3 tasks
@mydeamydea
mentioned this pull request
Sep 2, 2025
 Closed

@onurtemizkanonurtemizkan
mentioned this pull request
Sep 11, 2025
 Merged

s1gr1d pushed a commit
that referenced
this pull request
Sep 17, 2025
@onurtemizkan
ci(v8): Bump to ubuntu-24.04 (#17507)
22f3fa3
This PR unblocks backports to `v8` branch, similarly to what's done for
v7 (#17083)
Summary:
- Skip `size-check`
- Skip webkit / firefox playwright tests (so also flaky test detection)
- Upgrade playwright versions to `1.52.0`
- Skip a few browser tests that are flaky or failing on ubuntu-24.04
- Update nuxt e2e test configurations
- Use node-profiler binding binaries
- Skip nextjs canary tests
- Skip mongodb, mongoose and amqplib tests
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@andreiborzaandreiborzaandreiborza approved these changes

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@Lms24@andreiborza

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ci(v7): Bump to ubuntu-24.04 - #17083
Merged
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Jul 24, 2025
Merged
ci(v7): Bump to ubuntu-24.04#17083
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Conversation
@mydea
@mydeamydea
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Member
ubuntu-20.04 is no longer working, so CI is no longer working and nothing can be merged in v7 :O
Changes required to make this work:
  • Skip all playwright tests on CI :( We need to manually test changes locally instead. Playwright in this version simply does not like ubuntu-24.04
  • Skip mongoose/mongodb tests because they somehow also fail
  • Stop compiling node profiling binaries - we vendor them in instead
  • Size limit action fails because the comparison artifacts have expired 😅
@mydea
mydea
requested review from
Lms24 and andreiborzaJuly 18, 2025 11:20
@mydeamydea
self-assigned this
Jul 18, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
@github-actions
github-actionsBot
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)80.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)71.9 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)76.15 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)65.53 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped)35.78 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)35.67 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped)31.71 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)31.73 KB (added)
@sentry/browser - Webpack (gzipped)22.92 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)79.18 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)70.5 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)36.17 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped)25.42 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)221.94 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)109.54 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)76.26 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)39.48 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)72.4 KB (added)
@sentry/react - Webpack (gzipped)22.95 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)90.16 KB (added)
@sentry/nextjs Client - Webpack (gzipped)54.28 KB (added)
@sentry-internal/feedback - Webpack (gzipped)17.34 KB (added)
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]
cursorBot
reviewed
Jul 21, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Tests Fail Due to Missing Dependencies
Playwright tests are failing on Ubuntu 24.04 runners in job_nextjs_integration_test, job_browser_playwright_tests, and job_browser_loader_tests. This is because the npx playwright install --with-deps flag and the npx playwright install-deps step were removed from these jobs. Although OS dependencies are installed in job_install_deps, each GitHub Actions job runs on a fresh runner, preventing these dependencies from being available to the separate Playwright test jobs.
.github/workflows/build.yml#L614-L620
sentry-javascript/.github/workflows/build.yml

Lines 614 to 620
in
5e1e26b
key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
 - name: Run tests
.github/workflows/build.yml#L706-L710
sentry-javascript/.github/workflows/build.yml

Lines 706 to 710
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
.github/workflows/build.yml#L759-L763
sentry-javascript/.github/workflows/build.yml

Lines 759 to 763
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
Fix in Cursor • Fix in Web
Bug: Missing Directory Causes Build Script Failure
The build:copy-bindings script attempts to copy from compiled-bindings/ to lib/. However, the node-gyp build steps (and associated CI job) that previously created and populated compiled-bindings/ have been removed. This results in the compiled-bindings/ directory not existing, causing the cp command to fail and break the build process.
packages/profiling-node/package.json#L53-L54
sentry-javascript/packages/profiling-node/package.json

Lines 53 to 54
in
5e1e26b
"build:types:watch": "tsc -p tsconfig.types.json --watch", 
"build:copy-bindings": "cp -r compiled-bindings/ lib/", 
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Browser Installation Script Removed
The postinstall script, which automatically installed Playwright browsers via yarn install-browsers, was removed. This causes browser integration tests to fail due to missing browsers unless they are manually installed.
dev-packages/browser-integration-tests/package.json#L14-L16
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 16
in
353f1ef
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
"pretest": "yarn clean && yarn type-check", 
Fix in Cursor • Fix in Web
Comment thread.github/workflows/build.yml
 name: Nextjs (Node ${{ matrix.node }}) Tests
 needs: [job_get_metadata, job_build]
 if: needs.job_get_metadata.outputs.changed_nextjs == 'true' || github.event_name != 'pull_request'
 if: false
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Next.js Integration Tests Disabled
The job_nextjs_integration_test is completely disabled by setting its if condition to false. This likely accidental change prevents important Next.js integration tests from running, potentially masking functionality issues, especially after the upgrade to Ubuntu 24.04.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
Comment thread.github/workflows/build.yml
Comment threadpackages/profiling-node/package.json
 "test:bundle": "node test-binaries.esbuild.js",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=lib jest --config jest.config.js"
 "test:watch": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --watch",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --config jest.config.js"
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Node Profiling Build Fails Due to Missing Bindings
The packages/profiling-node build and test scripts now rely on a compiled-bindings directory that is never created or populated. The build:copy-bindings script attempts to copy from this non-existent directory, leading to build failures. Similarly, test scripts set SENTRY_PROFILER_BINARY_DIR to this missing directory, preventing tests from running. This change removed the previous node-gyp steps responsible for generating these bindings.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Postinstall Script Causes Test Failures
The postinstall script, "yarn install-browsers", was removed from dev-packages/browser-integration-tests/package.json. This script automatically installed Playwright browsers. Its removal prevents automatic browser installation during dependency setup, leading to browser integration test failures for local developers.
dev-packages/browser-integration-tests/package.json#L14-L15
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 15
in
3e6a498
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
Fix in Cursor • Fix in Web
@mydea
mydea
merged commit bc8bbb6
into
v7Jul 24, 2025

80 of 82 checks passed

@mydea
mydea
deleted the

fn/v7-ubuntu-ci

branch
July 24, 2025 15:03
@mydeamydea
mentioned this pull request
Jul 24, 2025
 Closed

@AdriVanHoudtAdriVanHoudt
mentioned this pull request
Aug 22, 2025

Closed

3 tasks
@mydeamydea
mentioned this pull request
Sep 2, 2025
 Closed

@onurtemizkanonurtemizkan
mentioned this pull request
Sep 11, 2025
 Merged

s1gr1d pushed a commit
that referenced
this pull request
Sep 17, 2025
@onurtemizkan
ci(v8): Bump to ubuntu-24.04 (#17507)
22f3fa3
This PR unblocks backports to `v8` branch, similarly to what's done for
v7 (#17083)
Summary:
- Skip `size-check`
- Skip webkit / firefox playwright tests (so also flaky test detection)
- Upgrade playwright versions to `1.52.0`
- Skip a few browser tests that are flaky or failing on ubuntu-24.04
- Update nuxt e2e test configurations
- Use node-profiler binding binaries
- Skip nextjs canary tests
- Skip mongodb, mongoose and amqplib tests
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@andreiborzaandreiborzaandreiborza approved these changes

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@Lms24@andreiborza

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ci(v7): Bump to ubuntu-24.04 - #17083
Merged
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Jul 24, 2025
Merged
ci(v7): Bump to ubuntu-24.04#17083
mydea merged 24 commits into
v7from 
fn/v7-ubuntu-ci
Conversation
@mydea
@mydeamydea
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Member
ubuntu-20.04 is no longer working, so CI is no longer working and nothing can be merged in v7 :O
Changes required to make this work:
  • Skip all playwright tests on CI :( We need to manually test changes locally instead. Playwright in this version simply does not like ubuntu-24.04
  • Skip mongoose/mongodb tests because they somehow also fail
  • Stop compiling node profiling binaries - we vendor them in instead
  • Size limit action fails because the comparison artifacts have expired 😅
@mydea
mydea
requested review from
Lms24 and andreiborzaJuly 18, 2025 11:20
@mydeamydea
self-assigned this
Jul 18, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view
@github-actions
github-actionsBot
commented
Jul 18, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)80.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)71.9 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped)76.15 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)65.53 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped)35.78 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)35.67 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped)31.71 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped)31.73 KB (added)
@sentry/browser - Webpack (gzipped)22.92 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)79.18 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)70.5 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)36.17 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped)25.42 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)221.94 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)109.54 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)76.26 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)39.48 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)72.4 KB (added)
@sentry/react - Webpack (gzipped)22.95 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)90.16 KB (added)
@sentry/nextjs Client - Webpack (gzipped)54.28 KB (added)
@sentry-internal/feedback - Webpack (gzipped)17.34 KB (added)
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view
cursor[bot]
cursorBot
reviewed
Jul 21, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Tests Fail Due to Missing Dependencies
Playwright tests are failing on Ubuntu 24.04 runners in job_nextjs_integration_test, job_browser_playwright_tests, and job_browser_loader_tests. This is because the npx playwright install --with-deps flag and the npx playwright install-deps step were removed from these jobs. Although OS dependencies are installed in job_install_deps, each GitHub Actions job runs on a fresh runner, preventing these dependencies from being available to the separate Playwright test jobs.
.github/workflows/build.yml#L614-L620
sentry-javascript/.github/workflows/build.yml

Lines 614 to 620
in
5e1e26b
key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
 - name: Run tests
.github/workflows/build.yml#L706-L710
sentry-javascript/.github/workflows/build.yml

Lines 706 to 710
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
.github/workflows/build.yml#L759-L763
sentry-javascript/.github/workflows/build.yml

Lines 759 to 763
in
5e1e26b
 - name: Install Playwright browser if not cached
if: steps.playwright-cache.outputs.cache-hit != 'true'
run: npx playwright install
env: 
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
Fix in Cursor • Fix in Web
Bug: Missing Directory Causes Build Script Failure
The build:copy-bindings script attempts to copy from compiled-bindings/ to lib/. However, the node-gyp build steps (and associated CI job) that previously created and populated compiled-bindings/ have been removed. This results in the compiled-bindings/ directory not existing, causing the cp command to fail and break the build process.
packages/profiling-node/package.json#L53-L54
sentry-javascript/packages/profiling-node/package.json

Lines 53 to 54
in
5e1e26b
"build:types:watch": "tsc -p tsconfig.types.json --watch", 
"build:copy-bindings": "cp -r compiled-bindings/ lib/", 
Fix in Cursor • Fix in Web
Was this report helpful? Give feedback by reacting with 👍 or 👎
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Playwright Browser Installation Script Removed
The postinstall script, which automatically installed Playwright browsers via yarn install-browsers, was removed. This causes browser integration tests to fail due to missing browsers unless they are manually installed.
dev-packages/browser-integration-tests/package.json#L14-L16
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 16
in
353f1ef
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
"pretest": "yarn clean && yarn type-check", 
Fix in Cursor • Fix in Web
Comment thread.github/workflows/build.yml
 name: Nextjs (Node ${{ matrix.node }}) Tests
 needs: [job_get_metadata, job_build]
 if: needs.job_get_metadata.outputs.changed_nextjs == 'true' || github.event_name != 'pull_request'
 if: false
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Next.js Integration Tests Disabled
The job_nextjs_integration_test is completely disabled by setting its if condition to false. This likely accidental change prevents important Next.js integration tests from running, potentially masking functionality issues, especially after the upgrade to Ubuntu 24.04.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
Comment thread.github/workflows/build.yml
Comment threadpackages/profiling-node/package.json
 "test:bundle": "node test-binaries.esbuild.js",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=lib jest --config jest.config.js"
 "test:watch": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --watch",
 "test": "cross-env SENTRY_PROFILER_BINARY_DIR=compiled-bindings jest --config jest.config.js"
@cursorcursorBotJul 24, 2025

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Node Profiling Build Fails Due to Missing Bindings
The packages/profiling-node build and test scripts now rely on a compiled-bindings directory that is never created or populated. The build:copy-bindings script attempts to copy from this non-existent directory, leading to build failures. Similarly, test scripts set SENTRY_PROFILER_BINARY_DIR to this missing directory, preventing tests from running. This change removed the previous node-gyp steps responsible for generating these bindings.
Locations (1)
Fix in Cursor • Fix in Web
cursor[bot]
cursorBot
reviewed
Jul 24, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Postinstall Script Causes Test Failures
The postinstall script, "yarn install-browsers", was removed from dev-packages/browser-integration-tests/package.json. This script automatically installed Playwright browsers. Its removal prevents automatic browser installation during dependency setup, leading to browser integration test failures for local developers.
dev-packages/browser-integration-tests/package.json#L14-L15
sentry-javascript/dev-packages/browser-integration-tests/package.json

Lines 14 to 15
in
3e6a498
"fix": "eslint . --format stylish --fix", 
"type-check": "tsc", 
Fix in Cursor • Fix in Web
@mydea
mydea
merged commit bc8bbb6
into
v7Jul 24, 2025

80 of 82 checks passed

@mydea
mydea
deleted the

fn/v7-ubuntu-ci

branch
July 24, 2025 15:03
@mydeamydea
mentioned this pull request
Jul 24, 2025
 Closed

@AdriVanHoudtAdriVanHoudt
mentioned this pull request
Aug 22, 2025

Closed

3 tasks
@mydeamydea
mentioned this pull request
Sep 2, 2025
 Closed

@onurtemizkanonurtemizkan
mentioned this pull request
Sep 11, 2025
 Merged

s1gr1d pushed a commit
that referenced
this pull request
Sep 17, 2025
@onurtemizkan
ci(v8): Bump to ubuntu-24.04 (#17507)
22f3fa3
This PR unblocks backports to `v8` branch, similarly to what's done for
v7 (#17083)
Summary:
- Skip `size-check`
- Skip webkit / firefox playwright tests (so also flaky test detection)
- Upgrade playwright versions to `1.52.0`
- Skip a few browser tests that are flaky or failing on ubuntu-24.04
- Update nuxt e2e test configurations
- Use node-profiler binding binaries
- Skip nextjs canary tests
- Skip mongodb, mongoose and amqplib tests
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@andreiborzaandreiborzaandreiborza approved these changes

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@Lms24@andreiborza