Uh oh!
There was an error while loading. Please reload this page.
fix(replay): Call sendBufferedReplayOrFlush when opening/sending feedback - #17236
Merged
billyvg merged 1 commit intoAug 4, 2025
Conversation
Contributor
size-limit report 📦
|
billyvg
marked this pull request as ready for review
July 30, 2025 20:25
chargome
approved these changes
Jul 31, 2025
…edback I noticed that our replays w/ feedbacks have gaps while the user is entering in their feedback. This is because we call `replay.flush` (not to be confused w/ the public replay integration integration which also has a flush) which only flushes the buffer and continues to buffer. What we want is to call `sendBufferedReplayOrFlush` which will convert the buffered replay into a session replay (after flushing) in order to continue recording.
billyvgforce-pushed
the
billy/replay-435-replays-from-feedback-have-gaps-in-the-replay-and-missing
branch
from
July 31, 2025 14:27
fa9d17b to
baaedccCompareUh oh!
There was an error while loading. Please reload this page.
billyvg
deleted the
billy/replay-435-replays-from-feedback-have-gaps-in-the-replay-and-missing
branch
August 4, 2025 12:47
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that our replays w/ feedbacks have gaps while the user is entering in their feedback. This is because we call
replay.flush(not to be confused w/ the public replay integration integration which also has a flush) which only flushes the buffer and continues to buffer. What we want is to callsendBufferedReplayOrFlushwhich will convert the buffered replay into a session replay (after flushing) in order to continue recording.