fix(react): Add support for React Router sub-routes from handle - #17277

Merged
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle
Aug 8, 2025
Merged

fix(react): Add support for React Router sub-routes from handle#17277
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Adds support for lazy loading sub-routes / components using the pattern below:

constroutes[// ...{path: 'part1',handle: {lazyChildren: ()=>import('./pages/SomeMoreNestedRoutes').then((mod)=>mod.someMoreNestedRoutes),},},]

lazyChildren is not a predefined key; it can be anything returning renderable data.

Not sure about the widespread usage of the pattern, but as it requires a recursive search inside the whole route tree, it potentially creates performance overhead.
So, added a new option [enableAsyncRouteHandlers] to the RR Tracing Integration and these checks will only run when it's set.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkan marked this pull request as draft August 1, 2025 05:23
@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 728fb60 to 244a953CompareAugust 4, 2025 08:46
@onurtemizkan
onurtemizkan marked this pull request as ready for review August 4, 2025 09:29
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from fea5834 to 06e535eCompareAugust 5, 2025 05:43
cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 81c1bc5 to e968adfCompareAugust 5, 2025 06:00
@github-actions

github-actionsBot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.11 kB--
@sentry/browser - with treeshaking flags22.68 kB--
@sentry/browser (incl. Tracing)39.83 kB--
@sentry/browser (incl. Tracing, Replay)77.92 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.77 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)82.63 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)94.73 kB--
@sentry/browser (incl. Feedback)40.77 kB--
@sentry/browser (incl. sendFeedback)28.77 kB--
@sentry/browser (incl. FeedbackAsync)33.66 kB--
@sentry/react25.83 kB--
@sentry/react (incl. Tracing)41.8 kB+0.07%+26 B 🔺
@sentry/vue28.59 kB--
@sentry/vue (incl. Tracing)41.64 kB--
@sentry/svelte24.14 kB--
CDN Bundle25.62 kB--
CDN Bundle (incl. Tracing)39.72 kB--
CDN Bundle (incl. Tracing, Replay)75.77 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)81.19 kB--
CDN Bundle - uncompressed74.89 kB--
CDN Bundle (incl. Tracing) - uncompressed117.52 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed231.78 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed244.38 kB--
@sentry/nextjs (client)43.83 kB--
@sentry/sveltekit (client)40.27 kB--
@sentry/node-core47.73 kB-0.01%-2 B 🔽
@sentry/node146.62 kB--
@sentry/node - without tracing91.83 kB-0.01%-1 B 🔽
@sentry/aws-serverless103.27 kB--

View base workflow run

@chargomechargome self-assigned this Aug 6, 2025
@AbhiPrasad
AbhiPrasad self-requested a review August 7, 2025 13:36
Comment threadpackages/react/src/reactrouterv6-compat-utils.tsx
cursor[bot]

This comment was marked as outdated.

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chargome
chargome merged commit ca4fba6 into developAug 8, 2025
186 checks passed
@chargome
chargome deleted the onur/react-router-support-async-handle branch August 8, 2025 08:54
onurtemizkan added a commit that referenced this pull request Feb 10, 2026
…es (#19086)
This PR will resolve the core reason for the series of fixes / handling
for automatic lazy-route resolution for a while.
Related: #18898,
#18881,
#18346,
#18155,
#18098,
#17962,
#17867,
#17438,
#17277
The core issue we have been trying to tackle is not having access to the
complete route hierarchy when asynchronously loaded lazy routes are
used. React Router provides a route manifest that we can use while
matching parameterized transaction names with routes in all cases except
this lazy-routes pattern.
This problem has been discussed on React Router:
- remix-run/react-router#11113
While this has been
[addressed](remix-run/react-router#11626) for
Remix / React Router (Framework Mode), it's still not available in
Library Mode. The manifest contains the lazily-loaded route, only when
it's navigated to. While waiting for navigation, our transactions can be
dropped for several reasons, such as user behaviour like switching tabs
(`document.hidden` guard), hitting timeouts like `idleTimeout`, and
potentially other reasons. This results in incomplete transaction naming
with leftover wildcards, which caused broken aggregation on the Sentry
dashboard.
The series of attempts to fix this while keeping automatic route
discovery has been prone to race conditions and required special-case
handling of each edge case scenario, also requiring a considerable
amount of internal logic, affecting our readability and performance. At
the end, all failed in giving completely robust and deterministic
results on the customers' side.
This PR proposes a new option: `lazyRouteManifest` specifically for lazy
routes. This will let us have initial information about the route
hierarchy. So we can assign correct parameterized transaction names
without needing to wait for navigated state.
It's a static array of routes in parameterized format (needs to be
maintained by the users on route hierarchy updates) like:
```ts
Sentry.reactRouterV7BrowserTracingIntegration({
// ...
enableAsyncRouteHandlers: true
lazyRouteManifest: [
'/',
'/pricing',
'/features',
'/login',
'/signup',
'/forgot-password',
'/reset-password/:token',
'/org/:orgSlug',
'/org/:orgSlug/dashboard',
'/org/:orgSlug/projects',
'/org/:orgSlug/projects/:projectId',
'/org/:orgSlug/projects/:projectId/settings',
'/org/:orgSlug/projects/:projectId/issues',
'/org/:orgSlug/projects/:projectId/issues/:issueId',
'/org/:orgSlug/team',
'/org/:orgSlug/team/:memberId',
'/org/:orgSlug/settings',
'/org/:orgSlug/billing',
'/admin',
'/admin/users',
'/admin/users/:userId',
'/admin/orgs',
'/admin/orgs/:orgId',
],
})
```
- This will only be active when `enableAsyncRouteHandlers` is set to
`true`
- To match URLs with given routes, we mimic React Router's own
implementation.
- When this is not provided or fails, it falls back to the current
behaviour
- This manifest is primarily for lazy routes, but the users can also add
their non-lazy routes here for convenience or consistency.
- Also added E2E tests that will fail when (if at some point) React
Router manifests include the lazy routes before navigation, so we'll be
aware and plan depending on that manifest instead.
- We can do a cleanup for the race-condition / edge-case handling part
of the code in a follow-up PR.
Closes#19090 (added automatically)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@onurtemizkan@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(react): Add support for React Router sub-routes from handle - #17277

Merged
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle
Aug 8, 2025
Merged

fix(react): Add support for React Router sub-routes from handle#17277
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Adds support for lazy loading sub-routes / components using the pattern below:

constroutes[// ...{path: 'part1',handle: {lazyChildren: ()=>import('./pages/SomeMoreNestedRoutes').then((mod)=>mod.someMoreNestedRoutes),},},]

lazyChildren is not a predefined key; it can be anything returning renderable data.

Not sure about the widespread usage of the pattern, but as it requires a recursive search inside the whole route tree, it potentially creates performance overhead.
So, added a new option [enableAsyncRouteHandlers] to the RR Tracing Integration and these checks will only run when it's set.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkan marked this pull request as draft August 1, 2025 05:23
@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 728fb60 to 244a953CompareAugust 4, 2025 08:46
@onurtemizkan
onurtemizkan marked this pull request as ready for review August 4, 2025 09:29
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from fea5834 to 06e535eCompareAugust 5, 2025 05:43
cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 81c1bc5 to e968adfCompareAugust 5, 2025 06:00
@github-actions

github-actionsBot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.11 kB--
@sentry/browser - with treeshaking flags22.68 kB--
@sentry/browser (incl. Tracing)39.83 kB--
@sentry/browser (incl. Tracing, Replay)77.92 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.77 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)82.63 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)94.73 kB--
@sentry/browser (incl. Feedback)40.77 kB--
@sentry/browser (incl. sendFeedback)28.77 kB--
@sentry/browser (incl. FeedbackAsync)33.66 kB--
@sentry/react25.83 kB--
@sentry/react (incl. Tracing)41.8 kB+0.07%+26 B 🔺
@sentry/vue28.59 kB--
@sentry/vue (incl. Tracing)41.64 kB--
@sentry/svelte24.14 kB--
CDN Bundle25.62 kB--
CDN Bundle (incl. Tracing)39.72 kB--
CDN Bundle (incl. Tracing, Replay)75.77 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)81.19 kB--
CDN Bundle - uncompressed74.89 kB--
CDN Bundle (incl. Tracing) - uncompressed117.52 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed231.78 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed244.38 kB--
@sentry/nextjs (client)43.83 kB--
@sentry/sveltekit (client)40.27 kB--
@sentry/node-core47.73 kB-0.01%-2 B 🔽
@sentry/node146.62 kB--
@sentry/node - without tracing91.83 kB-0.01%-1 B 🔽
@sentry/aws-serverless103.27 kB--

View base workflow run

@chargomechargome self-assigned this Aug 6, 2025
@AbhiPrasad
AbhiPrasad self-requested a review August 7, 2025 13:36
Comment threadpackages/react/src/reactrouterv6-compat-utils.tsx
cursor[bot]

This comment was marked as outdated.

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chargome
chargome merged commit ca4fba6 into developAug 8, 2025
186 checks passed
@chargome
chargome deleted the onur/react-router-support-async-handle branch August 8, 2025 08:54
onurtemizkan added a commit that referenced this pull request Feb 10, 2026
…es (#19086)
This PR will resolve the core reason for the series of fixes / handling
for automatic lazy-route resolution for a while.
Related: #18898,
#18881,
#18346,
#18155,
#18098,
#17962,
#17867,
#17438,
#17277
The core issue we have been trying to tackle is not having access to the
complete route hierarchy when asynchronously loaded lazy routes are
used. React Router provides a route manifest that we can use while
matching parameterized transaction names with routes in all cases except
this lazy-routes pattern.
This problem has been discussed on React Router:
- remix-run/react-router#11113
While this has been
[addressed](remix-run/react-router#11626) for
Remix / React Router (Framework Mode), it's still not available in
Library Mode. The manifest contains the lazily-loaded route, only when
it's navigated to. While waiting for navigation, our transactions can be
dropped for several reasons, such as user behaviour like switching tabs
(`document.hidden` guard), hitting timeouts like `idleTimeout`, and
potentially other reasons. This results in incomplete transaction naming
with leftover wildcards, which caused broken aggregation on the Sentry
dashboard.
The series of attempts to fix this while keeping automatic route
discovery has been prone to race conditions and required special-case
handling of each edge case scenario, also requiring a considerable
amount of internal logic, affecting our readability and performance. At
the end, all failed in giving completely robust and deterministic
results on the customers' side.
This PR proposes a new option: `lazyRouteManifest` specifically for lazy
routes. This will let us have initial information about the route
hierarchy. So we can assign correct parameterized transaction names
without needing to wait for navigated state.
It's a static array of routes in parameterized format (needs to be
maintained by the users on route hierarchy updates) like:
```ts
Sentry.reactRouterV7BrowserTracingIntegration({
// ...
enableAsyncRouteHandlers: true
lazyRouteManifest: [
'/',
'/pricing',
'/features',
'/login',
'/signup',
'/forgot-password',
'/reset-password/:token',
'/org/:orgSlug',
'/org/:orgSlug/dashboard',
'/org/:orgSlug/projects',
'/org/:orgSlug/projects/:projectId',
'/org/:orgSlug/projects/:projectId/settings',
'/org/:orgSlug/projects/:projectId/issues',
'/org/:orgSlug/projects/:projectId/issues/:issueId',
'/org/:orgSlug/team',
'/org/:orgSlug/team/:memberId',
'/org/:orgSlug/settings',
'/org/:orgSlug/billing',
'/admin',
'/admin/users',
'/admin/users/:userId',
'/admin/orgs',
'/admin/orgs/:orgId',
],
})
```
- This will only be active when `enableAsyncRouteHandlers` is set to
`true`
- To match URLs with given routes, we mimic React Router's own
implementation.
- When this is not provided or fails, it falls back to the current
behaviour
- This manifest is primarily for lazy routes, but the users can also add
their non-lazy routes here for convenience or consistency.
- Also added E2E tests that will fail when (if at some point) React
Router manifests include the lazy routes before navigation, so we'll be
aware and plan depending on that manifest instead.
- We can do a cleanup for the race-condition / edge-case handling part
of the code in a follow-up PR.
Closes#19090 (added automatically)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@onurtemizkan@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(react): Add support for React Router sub-routes from handle - #17277

Merged
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle
Aug 8, 2025
Merged

fix(react): Add support for React Router sub-routes from handle#17277
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Adds support for lazy loading sub-routes / components using the pattern below:

constroutes[// ...{path: 'part1',handle: {lazyChildren: ()=>import('./pages/SomeMoreNestedRoutes').then((mod)=>mod.someMoreNestedRoutes),},},]

lazyChildren is not a predefined key; it can be anything returning renderable data.

Not sure about the widespread usage of the pattern, but as it requires a recursive search inside the whole route tree, it potentially creates performance overhead.
So, added a new option [enableAsyncRouteHandlers] to the RR Tracing Integration and these checks will only run when it's set.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkan marked this pull request as draft August 1, 2025 05:23
@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 728fb60 to 244a953CompareAugust 4, 2025 08:46
@onurtemizkan
onurtemizkan marked this pull request as ready for review August 4, 2025 09:29
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from fea5834 to 06e535eCompareAugust 5, 2025 05:43
cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 81c1bc5 to e968adfCompareAugust 5, 2025 06:00
@github-actions

github-actionsBot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.11 kB--
@sentry/browser - with treeshaking flags22.68 kB--
@sentry/browser (incl. Tracing)39.83 kB--
@sentry/browser (incl. Tracing, Replay)77.92 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.77 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)82.63 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)94.73 kB--
@sentry/browser (incl. Feedback)40.77 kB--
@sentry/browser (incl. sendFeedback)28.77 kB--
@sentry/browser (incl. FeedbackAsync)33.66 kB--
@sentry/react25.83 kB--
@sentry/react (incl. Tracing)41.8 kB+0.07%+26 B 🔺
@sentry/vue28.59 kB--
@sentry/vue (incl. Tracing)41.64 kB--
@sentry/svelte24.14 kB--
CDN Bundle25.62 kB--
CDN Bundle (incl. Tracing)39.72 kB--
CDN Bundle (incl. Tracing, Replay)75.77 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)81.19 kB--
CDN Bundle - uncompressed74.89 kB--
CDN Bundle (incl. Tracing) - uncompressed117.52 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed231.78 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed244.38 kB--
@sentry/nextjs (client)43.83 kB--
@sentry/sveltekit (client)40.27 kB--
@sentry/node-core47.73 kB-0.01%-2 B 🔽
@sentry/node146.62 kB--
@sentry/node - without tracing91.83 kB-0.01%-1 B 🔽
@sentry/aws-serverless103.27 kB--

View base workflow run

@chargomechargome self-assigned this Aug 6, 2025
@AbhiPrasad
AbhiPrasad self-requested a review August 7, 2025 13:36
Comment threadpackages/react/src/reactrouterv6-compat-utils.tsx
cursor[bot]

This comment was marked as outdated.

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chargome
chargome merged commit ca4fba6 into developAug 8, 2025
186 checks passed
@chargome
chargome deleted the onur/react-router-support-async-handle branch August 8, 2025 08:54
onurtemizkan added a commit that referenced this pull request Feb 10, 2026
…es (#19086)
This PR will resolve the core reason for the series of fixes / handling
for automatic lazy-route resolution for a while.
Related: #18898,
#18881,
#18346,
#18155,
#18098,
#17962,
#17867,
#17438,
#17277
The core issue we have been trying to tackle is not having access to the
complete route hierarchy when asynchronously loaded lazy routes are
used. React Router provides a route manifest that we can use while
matching parameterized transaction names with routes in all cases except
this lazy-routes pattern.
This problem has been discussed on React Router:
- remix-run/react-router#11113
While this has been
[addressed](remix-run/react-router#11626) for
Remix / React Router (Framework Mode), it's still not available in
Library Mode. The manifest contains the lazily-loaded route, only when
it's navigated to. While waiting for navigation, our transactions can be
dropped for several reasons, such as user behaviour like switching tabs
(`document.hidden` guard), hitting timeouts like `idleTimeout`, and
potentially other reasons. This results in incomplete transaction naming
with leftover wildcards, which caused broken aggregation on the Sentry
dashboard.
The series of attempts to fix this while keeping automatic route
discovery has been prone to race conditions and required special-case
handling of each edge case scenario, also requiring a considerable
amount of internal logic, affecting our readability and performance. At
the end, all failed in giving completely robust and deterministic
results on the customers' side.
This PR proposes a new option: `lazyRouteManifest` specifically for lazy
routes. This will let us have initial information about the route
hierarchy. So we can assign correct parameterized transaction names
without needing to wait for navigated state.
It's a static array of routes in parameterized format (needs to be
maintained by the users on route hierarchy updates) like:
```ts
Sentry.reactRouterV7BrowserTracingIntegration({
// ...
enableAsyncRouteHandlers: true
lazyRouteManifest: [
'/',
'/pricing',
'/features',
'/login',
'/signup',
'/forgot-password',
'/reset-password/:token',
'/org/:orgSlug',
'/org/:orgSlug/dashboard',
'/org/:orgSlug/projects',
'/org/:orgSlug/projects/:projectId',
'/org/:orgSlug/projects/:projectId/settings',
'/org/:orgSlug/projects/:projectId/issues',
'/org/:orgSlug/projects/:projectId/issues/:issueId',
'/org/:orgSlug/team',
'/org/:orgSlug/team/:memberId',
'/org/:orgSlug/settings',
'/org/:orgSlug/billing',
'/admin',
'/admin/users',
'/admin/users/:userId',
'/admin/orgs',
'/admin/orgs/:orgId',
],
})
```
- This will only be active when `enableAsyncRouteHandlers` is set to
`true`
- To match URLs with given routes, we mimic React Router's own
implementation.
- When this is not provided or fails, it falls back to the current
behaviour
- This manifest is primarily for lazy routes, but the users can also add
their non-lazy routes here for convenience or consistency.
- Also added E2E tests that will fail when (if at some point) React
Router manifests include the lazy routes before navigation, so we'll be
aware and plan depending on that manifest instead.
- We can do a cleanup for the race-condition / edge-case handling part
of the code in a follow-up PR.
Closes#19090 (added automatically)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@onurtemizkan@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(react): Add support for React Router sub-routes from handle - #17277

Merged
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle
Aug 8, 2025
Merged

fix(react): Add support for React Router sub-routes from handle#17277
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Adds support for lazy loading sub-routes / components using the pattern below:

constroutes[// ...{path: 'part1',handle: {lazyChildren: ()=>import('./pages/SomeMoreNestedRoutes').then((mod)=>mod.someMoreNestedRoutes),},},]

lazyChildren is not a predefined key; it can be anything returning renderable data.

Not sure about the widespread usage of the pattern, but as it requires a recursive search inside the whole route tree, it potentially creates performance overhead.
So, added a new option [enableAsyncRouteHandlers] to the RR Tracing Integration and these checks will only run when it's set.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkan marked this pull request as draft August 1, 2025 05:23
@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 728fb60 to 244a953CompareAugust 4, 2025 08:46
@onurtemizkan
onurtemizkan marked this pull request as ready for review August 4, 2025 09:29
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from fea5834 to 06e535eCompareAugust 5, 2025 05:43
cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 81c1bc5 to e968adfCompareAugust 5, 2025 06:00
@github-actions

github-actionsBot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.11 kB--
@sentry/browser - with treeshaking flags22.68 kB--
@sentry/browser (incl. Tracing)39.83 kB--
@sentry/browser (incl. Tracing, Replay)77.92 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.77 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)82.63 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)94.73 kB--
@sentry/browser (incl. Feedback)40.77 kB--
@sentry/browser (incl. sendFeedback)28.77 kB--
@sentry/browser (incl. FeedbackAsync)33.66 kB--
@sentry/react25.83 kB--
@sentry/react (incl. Tracing)41.8 kB+0.07%+26 B 🔺
@sentry/vue28.59 kB--
@sentry/vue (incl. Tracing)41.64 kB--
@sentry/svelte24.14 kB--
CDN Bundle25.62 kB--
CDN Bundle (incl. Tracing)39.72 kB--
CDN Bundle (incl. Tracing, Replay)75.77 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)81.19 kB--
CDN Bundle - uncompressed74.89 kB--
CDN Bundle (incl. Tracing) - uncompressed117.52 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed231.78 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed244.38 kB--
@sentry/nextjs (client)43.83 kB--
@sentry/sveltekit (client)40.27 kB--
@sentry/node-core47.73 kB-0.01%-2 B 🔽
@sentry/node146.62 kB--
@sentry/node - without tracing91.83 kB-0.01%-1 B 🔽
@sentry/aws-serverless103.27 kB--

View base workflow run

@chargomechargome self-assigned this Aug 6, 2025
@AbhiPrasad
AbhiPrasad self-requested a review August 7, 2025 13:36
Comment threadpackages/react/src/reactrouterv6-compat-utils.tsx
cursor[bot]

This comment was marked as outdated.

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chargome
chargome merged commit ca4fba6 into developAug 8, 2025
186 checks passed
@chargome
chargome deleted the onur/react-router-support-async-handle branch August 8, 2025 08:54
onurtemizkan added a commit that referenced this pull request Feb 10, 2026
…es (#19086)
This PR will resolve the core reason for the series of fixes / handling
for automatic lazy-route resolution for a while.
Related: #18898,
#18881,
#18346,
#18155,
#18098,
#17962,
#17867,
#17438,
#17277
The core issue we have been trying to tackle is not having access to the
complete route hierarchy when asynchronously loaded lazy routes are
used. React Router provides a route manifest that we can use while
matching parameterized transaction names with routes in all cases except
this lazy-routes pattern.
This problem has been discussed on React Router:
- remix-run/react-router#11113
While this has been
[addressed](remix-run/react-router#11626) for
Remix / React Router (Framework Mode), it's still not available in
Library Mode. The manifest contains the lazily-loaded route, only when
it's navigated to. While waiting for navigation, our transactions can be
dropped for several reasons, such as user behaviour like switching tabs
(`document.hidden` guard), hitting timeouts like `idleTimeout`, and
potentially other reasons. This results in incomplete transaction naming
with leftover wildcards, which caused broken aggregation on the Sentry
dashboard.
The series of attempts to fix this while keeping automatic route
discovery has been prone to race conditions and required special-case
handling of each edge case scenario, also requiring a considerable
amount of internal logic, affecting our readability and performance. At
the end, all failed in giving completely robust and deterministic
results on the customers' side.
This PR proposes a new option: `lazyRouteManifest` specifically for lazy
routes. This will let us have initial information about the route
hierarchy. So we can assign correct parameterized transaction names
without needing to wait for navigated state.
It's a static array of routes in parameterized format (needs to be
maintained by the users on route hierarchy updates) like:
```ts
Sentry.reactRouterV7BrowserTracingIntegration({
// ...
enableAsyncRouteHandlers: true
lazyRouteManifest: [
'/',
'/pricing',
'/features',
'/login',
'/signup',
'/forgot-password',
'/reset-password/:token',
'/org/:orgSlug',
'/org/:orgSlug/dashboard',
'/org/:orgSlug/projects',
'/org/:orgSlug/projects/:projectId',
'/org/:orgSlug/projects/:projectId/settings',
'/org/:orgSlug/projects/:projectId/issues',
'/org/:orgSlug/projects/:projectId/issues/:issueId',
'/org/:orgSlug/team',
'/org/:orgSlug/team/:memberId',
'/org/:orgSlug/settings',
'/org/:orgSlug/billing',
'/admin',
'/admin/users',
'/admin/users/:userId',
'/admin/orgs',
'/admin/orgs/:orgId',
],
})
```
- This will only be active when `enableAsyncRouteHandlers` is set to
`true`
- To match URLs with given routes, we mimic React Router's own
implementation.
- When this is not provided or fails, it falls back to the current
behaviour
- This manifest is primarily for lazy routes, but the users can also add
their non-lazy routes here for convenience or consistency.
- Also added E2E tests that will fail when (if at some point) React
Router manifests include the lazy routes before navigation, so we'll be
aware and plan depending on that manifest instead.
- We can do a cleanup for the race-condition / edge-case handling part
of the code in a follow-up PR.
Closes#19090 (added automatically)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@onurtemizkan@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(react): Add support for React Router sub-routes from handle - #17277

Merged
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle
Aug 8, 2025
Merged

fix(react): Add support for React Router sub-routes from handle#17277
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Adds support for lazy loading sub-routes / components using the pattern below:

constroutes[// ...{path: 'part1',handle: {lazyChildren: ()=>import('./pages/SomeMoreNestedRoutes').then((mod)=>mod.someMoreNestedRoutes),},},]

lazyChildren is not a predefined key; it can be anything returning renderable data.

Not sure about the widespread usage of the pattern, but as it requires a recursive search inside the whole route tree, it potentially creates performance overhead.
So, added a new option [enableAsyncRouteHandlers] to the RR Tracing Integration and these checks will only run when it's set.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkan marked this pull request as draft August 1, 2025 05:23
@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 728fb60 to 244a953CompareAugust 4, 2025 08:46
@onurtemizkan
onurtemizkan marked this pull request as ready for review August 4, 2025 09:29
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from fea5834 to 06e535eCompareAugust 5, 2025 05:43
cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 81c1bc5 to e968adfCompareAugust 5, 2025 06:00
@github-actions

github-actionsBot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.11 kB--
@sentry/browser - with treeshaking flags22.68 kB--
@sentry/browser (incl. Tracing)39.83 kB--
@sentry/browser (incl. Tracing, Replay)77.92 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.77 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)82.63 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)94.73 kB--
@sentry/browser (incl. Feedback)40.77 kB--
@sentry/browser (incl. sendFeedback)28.77 kB--
@sentry/browser (incl. FeedbackAsync)33.66 kB--
@sentry/react25.83 kB--
@sentry/react (incl. Tracing)41.8 kB+0.07%+26 B 🔺
@sentry/vue28.59 kB--
@sentry/vue (incl. Tracing)41.64 kB--
@sentry/svelte24.14 kB--
CDN Bundle25.62 kB--
CDN Bundle (incl. Tracing)39.72 kB--
CDN Bundle (incl. Tracing, Replay)75.77 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)81.19 kB--
CDN Bundle - uncompressed74.89 kB--
CDN Bundle (incl. Tracing) - uncompressed117.52 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed231.78 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed244.38 kB--
@sentry/nextjs (client)43.83 kB--
@sentry/sveltekit (client)40.27 kB--
@sentry/node-core47.73 kB-0.01%-2 B 🔽
@sentry/node146.62 kB--
@sentry/node - without tracing91.83 kB-0.01%-1 B 🔽
@sentry/aws-serverless103.27 kB--

View base workflow run

@chargomechargome self-assigned this Aug 6, 2025
@AbhiPrasad
AbhiPrasad self-requested a review August 7, 2025 13:36
Comment threadpackages/react/src/reactrouterv6-compat-utils.tsx
cursor[bot]

This comment was marked as outdated.

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chargome
chargome merged commit ca4fba6 into developAug 8, 2025
186 checks passed
@chargome
chargome deleted the onur/react-router-support-async-handle branch August 8, 2025 08:54
onurtemizkan added a commit that referenced this pull request Feb 10, 2026
…es (#19086)
This PR will resolve the core reason for the series of fixes / handling
for automatic lazy-route resolution for a while.
Related: #18898,
#18881,
#18346,
#18155,
#18098,
#17962,
#17867,
#17438,
#17277
The core issue we have been trying to tackle is not having access to the
complete route hierarchy when asynchronously loaded lazy routes are
used. React Router provides a route manifest that we can use while
matching parameterized transaction names with routes in all cases except
this lazy-routes pattern.
This problem has been discussed on React Router:
- remix-run/react-router#11113
While this has been
[addressed](remix-run/react-router#11626) for
Remix / React Router (Framework Mode), it's still not available in
Library Mode. The manifest contains the lazily-loaded route, only when
it's navigated to. While waiting for navigation, our transactions can be
dropped for several reasons, such as user behaviour like switching tabs
(`document.hidden` guard), hitting timeouts like `idleTimeout`, and
potentially other reasons. This results in incomplete transaction naming
with leftover wildcards, which caused broken aggregation on the Sentry
dashboard.
The series of attempts to fix this while keeping automatic route
discovery has been prone to race conditions and required special-case
handling of each edge case scenario, also requiring a considerable
amount of internal logic, affecting our readability and performance. At
the end, all failed in giving completely robust and deterministic
results on the customers' side.
This PR proposes a new option: `lazyRouteManifest` specifically for lazy
routes. This will let us have initial information about the route
hierarchy. So we can assign correct parameterized transaction names
without needing to wait for navigated state.
It's a static array of routes in parameterized format (needs to be
maintained by the users on route hierarchy updates) like:
```ts
Sentry.reactRouterV7BrowserTracingIntegration({
// ...
enableAsyncRouteHandlers: true
lazyRouteManifest: [
'/',
'/pricing',
'/features',
'/login',
'/signup',
'/forgot-password',
'/reset-password/:token',
'/org/:orgSlug',
'/org/:orgSlug/dashboard',
'/org/:orgSlug/projects',
'/org/:orgSlug/projects/:projectId',
'/org/:orgSlug/projects/:projectId/settings',
'/org/:orgSlug/projects/:projectId/issues',
'/org/:orgSlug/projects/:projectId/issues/:issueId',
'/org/:orgSlug/team',
'/org/:orgSlug/team/:memberId',
'/org/:orgSlug/settings',
'/org/:orgSlug/billing',
'/admin',
'/admin/users',
'/admin/users/:userId',
'/admin/orgs',
'/admin/orgs/:orgId',
],
})
```
- This will only be active when `enableAsyncRouteHandlers` is set to
`true`
- To match URLs with given routes, we mimic React Router's own
implementation.
- When this is not provided or fails, it falls back to the current
behaviour
- This manifest is primarily for lazy routes, but the users can also add
their non-lazy routes here for convenience or consistency.
- Also added E2E tests that will fail when (if at some point) React
Router manifests include the lazy routes before navigation, so we'll be
aware and plan depending on that manifest instead.
- We can do a cleanup for the race-condition / edge-case handling part
of the code in a follow-up PR.
Closes#19090 (added automatically)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@onurtemizkan@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(react): Add support for React Router sub-routes from handle - #17277

Merged
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle
Aug 8, 2025
Merged

fix(react): Add support for React Router sub-routes from handle#17277
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Adds support for lazy loading sub-routes / components using the pattern below:

constroutes[// ...{path: 'part1',handle: {lazyChildren: ()=>import('./pages/SomeMoreNestedRoutes').then((mod)=>mod.someMoreNestedRoutes),},},]

lazyChildren is not a predefined key; it can be anything returning renderable data.

Not sure about the widespread usage of the pattern, but as it requires a recursive search inside the whole route tree, it potentially creates performance overhead.
So, added a new option [enableAsyncRouteHandlers] to the RR Tracing Integration and these checks will only run when it's set.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkan marked this pull request as draft August 1, 2025 05:23
@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 728fb60 to 244a953CompareAugust 4, 2025 08:46
@onurtemizkan
onurtemizkan marked this pull request as ready for review August 4, 2025 09:29
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from fea5834 to 06e535eCompareAugust 5, 2025 05:43
cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 81c1bc5 to e968adfCompareAugust 5, 2025 06:00
@github-actions

github-actionsBot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.11 kB--
@sentry/browser - with treeshaking flags22.68 kB--
@sentry/browser (incl. Tracing)39.83 kB--
@sentry/browser (incl. Tracing, Replay)77.92 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.77 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)82.63 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)94.73 kB--
@sentry/browser (incl. Feedback)40.77 kB--
@sentry/browser (incl. sendFeedback)28.77 kB--
@sentry/browser (incl. FeedbackAsync)33.66 kB--
@sentry/react25.83 kB--
@sentry/react (incl. Tracing)41.8 kB+0.07%+26 B 🔺
@sentry/vue28.59 kB--
@sentry/vue (incl. Tracing)41.64 kB--
@sentry/svelte24.14 kB--
CDN Bundle25.62 kB--
CDN Bundle (incl. Tracing)39.72 kB--
CDN Bundle (incl. Tracing, Replay)75.77 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)81.19 kB--
CDN Bundle - uncompressed74.89 kB--
CDN Bundle (incl. Tracing) - uncompressed117.52 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed231.78 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed244.38 kB--
@sentry/nextjs (client)43.83 kB--
@sentry/sveltekit (client)40.27 kB--
@sentry/node-core47.73 kB-0.01%-2 B 🔽
@sentry/node146.62 kB--
@sentry/node - without tracing91.83 kB-0.01%-1 B 🔽
@sentry/aws-serverless103.27 kB--

View base workflow run

@chargomechargome self-assigned this Aug 6, 2025
@AbhiPrasad
AbhiPrasad self-requested a review August 7, 2025 13:36
Comment threadpackages/react/src/reactrouterv6-compat-utils.tsx
cursor[bot]

This comment was marked as outdated.

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chargome
chargome merged commit ca4fba6 into developAug 8, 2025
186 checks passed
@chargome
chargome deleted the onur/react-router-support-async-handle branch August 8, 2025 08:54
onurtemizkan added a commit that referenced this pull request Feb 10, 2026
…es (#19086)
This PR will resolve the core reason for the series of fixes / handling
for automatic lazy-route resolution for a while.
Related: #18898,
#18881,
#18346,
#18155,
#18098,
#17962,
#17867,
#17438,
#17277
The core issue we have been trying to tackle is not having access to the
complete route hierarchy when asynchronously loaded lazy routes are
used. React Router provides a route manifest that we can use while
matching parameterized transaction names with routes in all cases except
this lazy-routes pattern.
This problem has been discussed on React Router:
- remix-run/react-router#11113
While this has been
[addressed](remix-run/react-router#11626) for
Remix / React Router (Framework Mode), it's still not available in
Library Mode. The manifest contains the lazily-loaded route, only when
it's navigated to. While waiting for navigation, our transactions can be
dropped for several reasons, such as user behaviour like switching tabs
(`document.hidden` guard), hitting timeouts like `idleTimeout`, and
potentially other reasons. This results in incomplete transaction naming
with leftover wildcards, which caused broken aggregation on the Sentry
dashboard.
The series of attempts to fix this while keeping automatic route
discovery has been prone to race conditions and required special-case
handling of each edge case scenario, also requiring a considerable
amount of internal logic, affecting our readability and performance. At
the end, all failed in giving completely robust and deterministic
results on the customers' side.
This PR proposes a new option: `lazyRouteManifest` specifically for lazy
routes. This will let us have initial information about the route
hierarchy. So we can assign correct parameterized transaction names
without needing to wait for navigated state.
It's a static array of routes in parameterized format (needs to be
maintained by the users on route hierarchy updates) like:
```ts
Sentry.reactRouterV7BrowserTracingIntegration({
// ...
enableAsyncRouteHandlers: true
lazyRouteManifest: [
'/',
'/pricing',
'/features',
'/login',
'/signup',
'/forgot-password',
'/reset-password/:token',
'/org/:orgSlug',
'/org/:orgSlug/dashboard',
'/org/:orgSlug/projects',
'/org/:orgSlug/projects/:projectId',
'/org/:orgSlug/projects/:projectId/settings',
'/org/:orgSlug/projects/:projectId/issues',
'/org/:orgSlug/projects/:projectId/issues/:issueId',
'/org/:orgSlug/team',
'/org/:orgSlug/team/:memberId',
'/org/:orgSlug/settings',
'/org/:orgSlug/billing',
'/admin',
'/admin/users',
'/admin/users/:userId',
'/admin/orgs',
'/admin/orgs/:orgId',
],
})
```
- This will only be active when `enableAsyncRouteHandlers` is set to
`true`
- To match URLs with given routes, we mimic React Router's own
implementation.
- When this is not provided or fails, it falls back to the current
behaviour
- This manifest is primarily for lazy routes, but the users can also add
their non-lazy routes here for convenience or consistency.
- Also added E2E tests that will fail when (if at some point) React
Router manifests include the lazy routes before navigation, so we'll be
aware and plan depending on that manifest instead.
- We can do a cleanup for the race-condition / edge-case handling part
of the code in a follow-up PR.
Closes#19090 (added automatically)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@onurtemizkan@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(react): Add support for React Router sub-routes from handle - #17277

Merged
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle
Aug 8, 2025
Merged

fix(react): Add support for React Router sub-routes from handle#17277
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Adds support for lazy loading sub-routes / components using the pattern below:

constroutes[// ...{path: 'part1',handle: {lazyChildren: ()=>import('./pages/SomeMoreNestedRoutes').then((mod)=>mod.someMoreNestedRoutes),},},]

lazyChildren is not a predefined key; it can be anything returning renderable data.

Not sure about the widespread usage of the pattern, but as it requires a recursive search inside the whole route tree, it potentially creates performance overhead.
So, added a new option [enableAsyncRouteHandlers] to the RR Tracing Integration and these checks will only run when it's set.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkan marked this pull request as draft August 1, 2025 05:23
@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 728fb60 to 244a953CompareAugust 4, 2025 08:46
@onurtemizkan
onurtemizkan marked this pull request as ready for review August 4, 2025 09:29
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from fea5834 to 06e535eCompareAugust 5, 2025 05:43
cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 81c1bc5 to e968adfCompareAugust 5, 2025 06:00
@github-actions

github-actionsBot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.11 kB--
@sentry/browser - with treeshaking flags22.68 kB--
@sentry/browser (incl. Tracing)39.83 kB--
@sentry/browser (incl. Tracing, Replay)77.92 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.77 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)82.63 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)94.73 kB--
@sentry/browser (incl. Feedback)40.77 kB--
@sentry/browser (incl. sendFeedback)28.77 kB--
@sentry/browser (incl. FeedbackAsync)33.66 kB--
@sentry/react25.83 kB--
@sentry/react (incl. Tracing)41.8 kB+0.07%+26 B 🔺
@sentry/vue28.59 kB--
@sentry/vue (incl. Tracing)41.64 kB--
@sentry/svelte24.14 kB--
CDN Bundle25.62 kB--
CDN Bundle (incl. Tracing)39.72 kB--
CDN Bundle (incl. Tracing, Replay)75.77 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)81.19 kB--
CDN Bundle - uncompressed74.89 kB--
CDN Bundle (incl. Tracing) - uncompressed117.52 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed231.78 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed244.38 kB--
@sentry/nextjs (client)43.83 kB--
@sentry/sveltekit (client)40.27 kB--
@sentry/node-core47.73 kB-0.01%-2 B 🔽
@sentry/node146.62 kB--
@sentry/node - without tracing91.83 kB-0.01%-1 B 🔽
@sentry/aws-serverless103.27 kB--

View base workflow run

@chargomechargome self-assigned this Aug 6, 2025
@AbhiPrasad
AbhiPrasad self-requested a review August 7, 2025 13:36
Comment threadpackages/react/src/reactrouterv6-compat-utils.tsx
cursor[bot]

This comment was marked as outdated.

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chargome
chargome merged commit ca4fba6 into developAug 8, 2025
186 checks passed
@chargome
chargome deleted the onur/react-router-support-async-handle branch August 8, 2025 08:54
onurtemizkan added a commit that referenced this pull request Feb 10, 2026
…es (#19086)
This PR will resolve the core reason for the series of fixes / handling
for automatic lazy-route resolution for a while.
Related: #18898,
#18881,
#18346,
#18155,
#18098,
#17962,
#17867,
#17438,
#17277
The core issue we have been trying to tackle is not having access to the
complete route hierarchy when asynchronously loaded lazy routes are
used. React Router provides a route manifest that we can use while
matching parameterized transaction names with routes in all cases except
this lazy-routes pattern.
This problem has been discussed on React Router:
- remix-run/react-router#11113
While this has been
[addressed](remix-run/react-router#11626) for
Remix / React Router (Framework Mode), it's still not available in
Library Mode. The manifest contains the lazily-loaded route, only when
it's navigated to. While waiting for navigation, our transactions can be
dropped for several reasons, such as user behaviour like switching tabs
(`document.hidden` guard), hitting timeouts like `idleTimeout`, and
potentially other reasons. This results in incomplete transaction naming
with leftover wildcards, which caused broken aggregation on the Sentry
dashboard.
The series of attempts to fix this while keeping automatic route
discovery has been prone to race conditions and required special-case
handling of each edge case scenario, also requiring a considerable
amount of internal logic, affecting our readability and performance. At
the end, all failed in giving completely robust and deterministic
results on the customers' side.
This PR proposes a new option: `lazyRouteManifest` specifically for lazy
routes. This will let us have initial information about the route
hierarchy. So we can assign correct parameterized transaction names
without needing to wait for navigated state.
It's a static array of routes in parameterized format (needs to be
maintained by the users on route hierarchy updates) like:
```ts
Sentry.reactRouterV7BrowserTracingIntegration({
// ...
enableAsyncRouteHandlers: true
lazyRouteManifest: [
'/',
'/pricing',
'/features',
'/login',
'/signup',
'/forgot-password',
'/reset-password/:token',
'/org/:orgSlug',
'/org/:orgSlug/dashboard',
'/org/:orgSlug/projects',
'/org/:orgSlug/projects/:projectId',
'/org/:orgSlug/projects/:projectId/settings',
'/org/:orgSlug/projects/:projectId/issues',
'/org/:orgSlug/projects/:projectId/issues/:issueId',
'/org/:orgSlug/team',
'/org/:orgSlug/team/:memberId',
'/org/:orgSlug/settings',
'/org/:orgSlug/billing',
'/admin',
'/admin/users',
'/admin/users/:userId',
'/admin/orgs',
'/admin/orgs/:orgId',
],
})
```
- This will only be active when `enableAsyncRouteHandlers` is set to
`true`
- To match URLs with given routes, we mimic React Router's own
implementation.
- When this is not provided or fails, it falls back to the current
behaviour
- This manifest is primarily for lazy routes, but the users can also add
their non-lazy routes here for convenience or consistency.
- Also added E2E tests that will fail when (if at some point) React
Router manifests include the lazy routes before navigation, so we'll be
aware and plan depending on that manifest instead.
- We can do a cleanup for the race-condition / edge-case handling part
of the code in a follow-up PR.
Closes#19090 (added automatically)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@onurtemizkan@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(react): Add support for React Router sub-routes from handle - #17277

Merged
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle
Aug 8, 2025
Merged

fix(react): Add support for React Router sub-routes from handle#17277
chargome merged 10 commits into
developfrom
onur/react-router-support-async-handle

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Adds support for lazy loading sub-routes / components using the pattern below:

constroutes[// ...{path: 'part1',handle: {lazyChildren: ()=>import('./pages/SomeMoreNestedRoutes').then((mod)=>mod.someMoreNestedRoutes),},},]

lazyChildren is not a predefined key; it can be anything returning renderable data.

Not sure about the widespread usage of the pattern, but as it requires a recursive search inside the whole route tree, it potentially creates performance overhead.
So, added a new option [enableAsyncRouteHandlers] to the RR Tracing Integration and these checks will only run when it's set.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkan marked this pull request as draft August 1, 2025 05:23
@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 728fb60 to 244a953CompareAugust 4, 2025 08:46
@onurtemizkan
onurtemizkan marked this pull request as ready for review August 4, 2025 09:29
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from fea5834 to 06e535eCompareAugust 5, 2025 05:43
cursor[bot]

This comment was marked as outdated.

@onurtemizkan
onurtemizkanforce-pushed the onur/react-router-support-async-handle branch from 81c1bc5 to e968adfCompareAugust 5, 2025 06:00
@github-actions

github-actionsBot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.11 kB--
@sentry/browser - with treeshaking flags22.68 kB--
@sentry/browser (incl. Tracing)39.83 kB--
@sentry/browser (incl. Tracing, Replay)77.92 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.77 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)82.63 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)94.73 kB--
@sentry/browser (incl. Feedback)40.77 kB--
@sentry/browser (incl. sendFeedback)28.77 kB--
@sentry/browser (incl. FeedbackAsync)33.66 kB--
@sentry/react25.83 kB--
@sentry/react (incl. Tracing)41.8 kB+0.07%+26 B 🔺
@sentry/vue28.59 kB--
@sentry/vue (incl. Tracing)41.64 kB--
@sentry/svelte24.14 kB--
CDN Bundle25.62 kB--
CDN Bundle (incl. Tracing)39.72 kB--
CDN Bundle (incl. Tracing, Replay)75.77 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)81.19 kB--
CDN Bundle - uncompressed74.89 kB--
CDN Bundle (incl. Tracing) - uncompressed117.52 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed231.78 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed244.38 kB--
@sentry/nextjs (client)43.83 kB--
@sentry/sveltekit (client)40.27 kB--
@sentry/node-core47.73 kB-0.01%-2 B 🔽
@sentry/node146.62 kB--
@sentry/node - without tracing91.83 kB-0.01%-1 B 🔽
@sentry/aws-serverless103.27 kB--

View base workflow run

@chargomechargome self-assigned this Aug 6, 2025
@AbhiPrasad
AbhiPrasad self-requested a review August 7, 2025 13:36
Comment threadpackages/react/src/reactrouterv6-compat-utils.tsx
cursor[bot]

This comment was marked as outdated.

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chargome
chargome merged commit ca4fba6 into developAug 8, 2025
186 checks passed
@chargome
chargome deleted the onur/react-router-support-async-handle branch August 8, 2025 08:54
onurtemizkan added a commit that referenced this pull request Feb 10, 2026
…es (#19086)
This PR will resolve the core reason for the series of fixes / handling
for automatic lazy-route resolution for a while.
Related: #18898,
#18881,
#18346,
#18155,
#18098,
#17962,
#17867,
#17438,
#17277
The core issue we have been trying to tackle is not having access to the
complete route hierarchy when asynchronously loaded lazy routes are
used. React Router provides a route manifest that we can use while
matching parameterized transaction names with routes in all cases except
this lazy-routes pattern.
This problem has been discussed on React Router:
- remix-run/react-router#11113
While this has been
[addressed](remix-run/react-router#11626) for
Remix / React Router (Framework Mode), it's still not available in
Library Mode. The manifest contains the lazily-loaded route, only when
it's navigated to. While waiting for navigation, our transactions can be
dropped for several reasons, such as user behaviour like switching tabs
(`document.hidden` guard), hitting timeouts like `idleTimeout`, and
potentially other reasons. This results in incomplete transaction naming
with leftover wildcards, which caused broken aggregation on the Sentry
dashboard.
The series of attempts to fix this while keeping automatic route
discovery has been prone to race conditions and required special-case
handling of each edge case scenario, also requiring a considerable
amount of internal logic, affecting our readability and performance. At
the end, all failed in giving completely robust and deterministic
results on the customers' side.
This PR proposes a new option: `lazyRouteManifest` specifically for lazy
routes. This will let us have initial information about the route
hierarchy. So we can assign correct parameterized transaction names
without needing to wait for navigated state.
It's a static array of routes in parameterized format (needs to be
maintained by the users on route hierarchy updates) like:
```ts
Sentry.reactRouterV7BrowserTracingIntegration({
// ...
enableAsyncRouteHandlers: true
lazyRouteManifest: [
'/',
'/pricing',
'/features',
'/login',
'/signup',
'/forgot-password',
'/reset-password/:token',
'/org/:orgSlug',
'/org/:orgSlug/dashboard',
'/org/:orgSlug/projects',
'/org/:orgSlug/projects/:projectId',
'/org/:orgSlug/projects/:projectId/settings',
'/org/:orgSlug/projects/:projectId/issues',
'/org/:orgSlug/projects/:projectId/issues/:issueId',
'/org/:orgSlug/team',
'/org/:orgSlug/team/:memberId',
'/org/:orgSlug/settings',
'/org/:orgSlug/billing',
'/admin',
'/admin/users',
'/admin/users/:userId',
'/admin/orgs',
'/admin/orgs/:orgId',
],
})
```
- This will only be active when `enableAsyncRouteHandlers` is set to
`true`
- To match URLs with given routes, we mimic React Router's own
implementation.
- When this is not provided or fails, it falls back to the current
behaviour
- This manifest is primarily for lazy routes, but the users can also add
their non-lazy routes here for convenience or consistency.
- Also added E2E tests that will fail when (if at some point) React
Router manifests include the lazy routes before navigation, so we'll be
aware and plan depending on that manifest instead.
- We can do a cleanup for the race-condition / edge-case handling part
of the code in a follow-up PR.
Closes#19090 (added automatically)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@onurtemizkan@chargome