Skip to content

feat(core): MCP Server - Capture prompt results from prompt function calls - #17284

Merged
AbhiPrasad merged 13 commits into
developfrom
bete/mcp-server-prompt-results
Aug 6, 2025
Merged

feat(core): MCP Server - Capture prompt results from prompt function calls#17284
AbhiPrasad merged 13 commits into
developfrom
bete/mcp-server-prompt-results

Conversation

@betegon

@betegonbetegon commented Aug 1, 2025•
edited
Loading

Copy link
Copy Markdown
Member

closes#17283

includes these attributes for mcp.server spans:

  • mcp.prompt.result.description
  • mcp.prompt.result.message_content
  • mcp.prompt.result.message_role
  • mcp.prompt.result.message_count

Example:
Screenshot 2025-08-01 at 12 40 46

Needed to make attributeExtraction.ts <300 lines of code (requirement) so it's now split between sessionExtraction.ts, sessionExtraction.ts and resultExtraction.ts.

So changes explained so it's easier to review:

  • The only function this PR adds is extractPromptResultAttributes inside resultExtraction.ts.
  • It adds the prompt results as PII in piiFiltering.ts. Just add them to the set.
  • adds a else if (method === 'prompts/get') to execute the extractPromptResultAttributes function.
  • adds a test that checks we're capturing the results and updates the PII test to check PII result attributes are being removed if sending PII is not enabled.

@betegonbetegon self-assigned this Aug 1, 2025
@betegon

betegon commented Aug 1, 2025

Copy link
Copy Markdown
MemberAuthor

@sentry review

seer-by-sentry[bot]
seer-by-sentryBot reviewed Aug 1, 2025
View reviewed changes
Comment threadpackages/core/src/integrations/mcp-server/attributeExtraction.ts Outdated
seer-by-sentry[bot]
seer-by-sentryBot reviewed Aug 1, 2025
View reviewed changes
Comment threadpackages/core/src/integrations/mcp-server/attributeExtraction.ts Outdated
AbhiPrasad
AbhiPrasad reviewed Aug 1, 2025
View reviewed changes
Comment threadpackages/core/src/integrations/mcp-server/sessionExtraction.ts Outdated
Comment threadpackages/core/src/integrations/mcp-server/resultExtraction.ts Outdated
Comment threadpackages/core/src/integrations/mcp-server/resultExtraction.ts Outdated
Comment threadpackages/core/src/integrations/mcp-server/resultExtraction.ts Outdated
Comment threadpackages/core/src/integrations/mcp-server/resultExtraction.ts Outdated
Comment threadpackages/core/src/integrations/mcp-server/resultExtraction.ts Outdated
@betegon
betegon marked this pull request as ready for review August 5, 2025 18:31
@betegon
betegon requested a review from AbhiPrasadAugust 5, 2025 18:31
AbhiPrasad
AbhiPrasad approved these changes Aug 5, 2025
View reviewed changes

@AbhiPrasadAbhiPrasad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

cursor[bot]

This comment was marked as outdated.

Sign in to view

@AbhiPrasad

AbhiPrasad commented Aug 6, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

feel free to merge @betegon (make sure you squash and merge). Also if we need this backported to v9 you'll need to cherry-pick the commit and open it against the v9 branch.

@AbhiPrasad
AbhiPrasad merged commit 0e05a40 into developAug 6, 2025
184 checks passed
@AbhiPrasad
AbhiPrasad deleted the bete/mcp-server-prompt-results branch August 6, 2025 15:19
@AbhiPrasad

AbhiPrasad commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

actually whatever I'll just do it 😄

@betegon

betegon commented Aug 6, 2025

Copy link
Copy Markdown
MemberAuthor

thanks @AbhiPrasad . I'm on PTO this week so it's been a bit difficult to keep up 😆

RulaKhaled pushed a commit that referenced this pull request Aug 7, 2025
@betegon@RulaKhaled
feat(core): MCP Server - Capture prompt results from prompt function …
30ef3e5
…calls (#17284)
closes#17283
includes these attributes for `mcp.server` spans:
- `mcp.prompt.result.description`
- `mcp.prompt.result.message_content`
- `mcp.prompt.result.message_role`
- `mcp.prompt.result.message_count`
Example: <img width="835" height="300" alt="Screenshot 2025-08-01 at 12 40 46"
src="https://github.com/user-attachments/assets/592d876b-807a-4f3e-a9b2-406e10f5a83d"
/>
Needed to make `attributeExtraction.ts` <300 lines of code (requirement)
so it's now split between `sessionExtraction.ts`, `sessionExtraction.ts`
and `resultExtraction.ts`.
So changes explained so it's easier to review:
- The only function this PR adds is `extractPromptResultAttributes`
inside `resultExtraction.ts`.
- It adds the prompt results as PII in `piiFiltering.ts`. Just add them
to the `set`.
- adds a `else if (method === 'prompts/get')` to execute the
`extractPromptResultAttributes` function.
- adds a test that checks we're capturing the results and updates the
PII test to check PII result attributes are being removed if sending PII
is not enabled.
betegon added a commit that referenced this pull request Aug 13, 2025
@betegon
feat(core): MCP Server - Capture prompt results from prompt function …
c959853
…calls (#17284)
closes#17283
includes these attributes for `mcp.server` spans:
- `mcp.prompt.result.description`
- `mcp.prompt.result.message_content`
- `mcp.prompt.result.message_role`
- `mcp.prompt.result.message_count`
Example:
<img width="835" height="300" alt="Screenshot 2025-08-01 at 12 40 46"
src="https://github.com/user-attachments/assets/592d876b-807a-4f3e-a9b2-406e10f5a83d"
/>
Needed to make `attributeExtraction.ts` <300 lines of code (requirement)
so it's now split between `sessionExtraction.ts`, `sessionExtraction.ts`
and `resultExtraction.ts`.
So changes explained so it's easier to review:
- The only function this PR adds is `extractPromptResultAttributes`
inside `resultExtraction.ts`.
- It adds the prompt results as PII in `piiFiltering.ts`. Just add them
to the `set`.
- adds a `else if (method === 'prompts/get')` to execute the
`extractPromptResultAttributes` function.
- adds a test that checks we're capturing the results and updates the
PII test to check PII result attributes are being removed if sending PII
is not enabled.
(cherry picked from commit 0e05a40)
@betegonbetegon mentioned this pull request Aug 13, 2025
Merged
andreiborza pushed a commit that referenced this pull request Aug 13, 2025
@betegon
fix(v9/mcp): capture prompt results and add defensive edge cases for …
183a245
…transport instrumentation (#17401)
backport of #17284 and #17291
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seer-by-sentryseer-by-sentry[bot]seer-by-sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
+1 more reviewer
@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@betegonbetegon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MCP Server - capture prompt results from prompt function calls

2 participants

@betegon@AbhiPrasad