Skip to content

ref(core): Improve event mechanism for supabase integration - #17286

Merged
Lms24 merged 3 commits into
developfrom
lms/ref-core-mechanism-supabase
Aug 8, 2025
Merged

ref(core): Improve event mechanism for supabase integration#17286
Lms24 merged 3 commits into
developfrom
lms/ref-core-mechanism-supabase

Conversation

@Lms24

@Lms24Lms24 commented Aug 1, 2025

Copy link
Copy Markdown
Member

ref: #17250
ref: #17212

@Lms24Lms24 self-assigned this Aug 1, 2025
return res;
},
(err: Error) => {
// TODO: shouldn't we capture this error?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onurtemizkan not sure if this is me missing something or if we should call captureException here. Can you take a look?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like this comes from the original implementation we ported:

https://github.com/supabase-community/sentry-integration-js/blob/9fc7be61d2890f87257c4af528271374c89c4acd/v8.js#L237-L242

I don't see a reason why we should not capture this, though.

@Lms24Lms24Aug 4, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Probably just an oversight then. I'll make a separate PR adding a captureException call here.

captureException(res.error, {
mechanism: {
handled: false,
type: 'auto.db.supabase.auth',

@Lms24Lms24Aug 1, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thesetype entries are one level more specific than the trace origin on the spans (auto.db.supabase). I think this is fine.

Comment threadpackages/core/src/integrations/supabase.ts
@Lms24Lms24 mentioned this pull request Aug 1, 2025
4 tasks
@Lms24
Lms24 merged commit ccc7d32 into developAug 8, 2025
182 checks passed
@Lms24
Lms24 deleted the lms/ref-core-mechanism-supabase branch August 8, 2025 07:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Lms24@onurtemizkan@AbhiPrasad@s1gr1d