Uh oh!
There was an error while loading. Please reload this page.
ref(feedback): Remove almost duplicate sendFeedback rejection message - #17297
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
size-limit report 📦
|
Lms24
left a comment
There was a problem hiding this comment.
Sounds fair to me to remove. Wondering if there was an intention behind the special casing for response.statusCode being 0 but given there's no user-facing difference to the callback, this might just have been an oversight.
mydea
commented
Aug 4, 2025
Yeah I had the same thought, but this should be an equivalent solution at least I suppose! |
Uh oh!
There was an error while loading. Please reload this page.
sendFeedback rejection messagesendFeedback rejection messageUh oh!
There was an error while loading. Please reload this page.
Noticed this by chance, this is a redundant message (we also use this as general fallback anyhow).
The two messages have been:
Which are virtually identical. We can safe some bytes there IMHO.