Uh oh!
There was an error while loading. Please reload this page.
feat(sveltekit): Streamline build logs - #17306
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mydea
commented
Aug 4, 2025
MemberAuthor
wait this does not work, let me draft it again... |
mydea
marked this pull request as draft
August 4, 2025 13:59
mydea
marked this pull request as ready for review
August 5, 2025 08:35
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
| const { promise: filesToDeleteAfterUpload, resolve: resolveFilesToDeleteAfterUpload } = | ||
| createFilesToDeleteAfterUploadPromise(); | ||
| let _resolveFilesToDeleteAfterUpload: |
Contributor
There was a problem hiding this comment.
I wonder if we should create a utility that does this, but then does a node version check to run Promise.withResolvers
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
mydeaforce-pushed
the
fn/sveltekit-build-logs
branch
from
August 6, 2025 11:22
3d12225 to
66636caCompareAbhiPrasad
approved these changes
Aug 6, 2025
Lms24
approved these changes
Aug 7, 2025
Lms24
left a comment
Member
There was a problem hiding this comment.
Thanks for cleaning this up and sorry for the late review! LGTM!
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This streamlines the build logs for sveltekit. For this, I aligned how we handle source maps setting with other SDKs, which is a bit different then how sveltekit did it.
debug: truesourceMaps: falseanddebug: false, more details whendebug: trueis setfilesToDeleteAfterUploadis set, based on other SDKs (?? I hope that makes sense....)