Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,6 +200,9 @@ jobs:
changed_node:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/node') }}
changed_node_overhead_action:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry-internal/node-overhead-gh-action') }}
changed_deno:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/deno') }}
Expand DownExpand Up@@ -253,6 +256,37 @@ jobs:
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_node_overhead_check:
name: Node Overhead Check
needs: [job_get_metadata, job_build]
timeout-minutes: 15
runs-on: ubuntu-24.04
if:
(needs.job_build.outputs.changed_node == 'true' && github.event_name == 'pull_request') ||
(needs.job_build.outputs.changed_node_overhead_action == 'true' && github.event_name == 'pull_request') ||
needs.job_get_metadata.outputs.is_base_branch == 'true' || needs.job_get_metadata.outputs.is_release == 'true'
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
- name: Restore caches
uses: ./.github/actions/restore-cache
with:
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
- name: Check node overhead
uses: ./dev-packages/node-overhead-gh-action
env:
DEBUG: '1'
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_lint:
name: Lint
# Even though the linter only checks source code, not built code, it needs the built code in order check that all
Expand Down
15 changes: 15 additions & 0 deletions dev-packages/node-overhead-gh-action/.eslintrc.cjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
module.exports = {
env: {
node: true,
},
extends: ['../../.eslintrc.js'],
overrides: [
{
files: ['**/*.mjs'],
parserOptions: {
project: ['tsconfig.json'],
sourceType: 'module',
},
},
],
};
3 changes: 3 additions & 0 deletions dev-packages/node-overhead-gh-action/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
# node-overhead-gh-action

Capture the overhead of Sentry in a node app.
17 changes: 17 additions & 0 deletions dev-packages/node-overhead-gh-action/action.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
name: 'node-overhead-gh-action'
description: 'Run node overhead comparison'
inputs:
github_token:
required: true
description: 'a github access token'
comparison_branch:
required: false
default: ''
description: 'If set, compare the current branch with this branch'
threshold:
required: false
default: '3'
description: 'The percentage threshold for size changes before posting a comment'
runs:
using: 'node24'
main: 'index.mjs'
25 changes: 25 additions & 0 deletions dev-packages/node-overhead-gh-action/db/init/init.sql
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
CREATE DATABASE mydb;
USE mydb

-- SQL script to create the 'users' table and insert initial data.

-- 1. Create the 'users' table
-- This table stores basic user information.
-- 'id' is the primary key and will automatically increment for each new record.
-- 'name' stores the user's name, up to 255 characters.
-- 'age' stores the user's age as an integer.

CREATE TABLE users (
id INT PRIMARY KEY AUTO_INCREMENT,
name VARCHAR(255) NOT NULL,
age INT
);

-- 2. Insert 5 rows into the 'users' table
-- Populating the table with some sample data.

INSERT INTO users (name, age) VALUES ('Alice Johnson', 28);
INSERT INTO users (name, age) VALUES ('Bob Smith', 45);
INSERT INTO users (name, age) VALUES ('Charlie Brown', 32);
INSERT INTO users (name, age) VALUES ('Diana Prince', 25);
INSERT INTO users (name, age) VALUES ('Ethan Hunt', 41);
12 changes: 12 additions & 0 deletions dev-packages/node-overhead-gh-action/docker-compose.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
services:
db:
image: mysql:8
restart: always
container_name: node-overhead-gh-action-mysql
ports:
- '3306:3306'
environment:
MYSQL_ROOT_PASSWORD: password
volumes:
# - ./db/data:/var/lib/mysql
- ./db/init:/docker-entrypoint-initdb.d/:ro
236 changes: 236 additions & 0 deletions dev-packages/node-overhead-gh-action/index.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,236 @@
import { promises as fs } from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { DefaultArtifactClient } from '@actions/artifact';
import * as core from '@actions/core';
import { exec } from '@actions/exec';
import { context, getOctokit } from '@actions/github';
import * as glob from '@actions/glob';
import * as io from '@actions/io';
import { markdownTable } from 'markdown-table';
import { getArtifactsForBranchAndWorkflow } from './lib/getArtifactsForBranchAndWorkflow.mjs';
import { getAveragedOverheadMeasurements } from './lib/getOverheadMeasurements.mjs';
import { formatResults, hasChanges } from './lib/markdown-table-formatter.mjs';

const NODE_OVERHEAD_HEADING = '## node-overhead report 🧳';
const ARTIFACT_NAME = 'node-overhead-action';
const RESULTS_FILE = 'node-overhead-results.json';

function getResultsFilePath() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
return path.resolve(__dirname, RESULTS_FILE);
}

const { getInput, setFailed } = core;

async function fetchPreviousComment(octokit, repo, pr) {
const { data: commentList } = await octokit.rest.issues.listComments({
...repo,
issue_number: pr.number,
});

return commentList.find(comment => comment.body.startsWith(NODE_OVERHEAD_HEADING));
}

async function run() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));

try {
const { payload, repo } = context;
const pr = payload.pull_request;

const comparisonBranch = getInput('comparison_branch');
const githubToken = getInput('github_token');
const threshold = getInput('threshold') || 1;

if (comparisonBranch && !pr) {
throw new Error('No PR found. Only pull_request workflows are supported.');
}

const octokit = getOctokit(githubToken);
const resultsFilePath = getResultsFilePath();

// If we have no comparison branch, we just run overhead check & store the result as artifact
if (!comparisonBranch) {
return runNodeOverheadOnComparisonBranch();
}

// Else, we run overhead check for the current branch, AND fetch it for the comparison branch
let base;
let current;
let baseIsNotLatest = false;
let baseWorkflowRun;

try {
const workflowName = `${process.env.GITHUB_WORKFLOW || ''}`;
core.startGroup(`getArtifactsForBranchAndWorkflow - workflow:"${workflowName}", branch:"${comparisonBranch}"`);
const artifacts = await getArtifactsForBranchAndWorkflow(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
branch: comparisonBranch,
workflowName,
});
core.endGroup();

if (!artifacts) {
throw new Error('No artifacts found');
}

baseWorkflowRun = artifacts.workflowRun;

await downloadOtherWorkflowArtifact(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
artifactId: artifacts.artifact.id,
downloadPath: __dirname,
});

base = JSON.parse(await fs.readFile(resultsFilePath, { encoding: 'utf8' }));

if (!artifacts.isLatest) {
baseIsNotLatest = true;
core.info('Base artifact is not the latest one. This may lead to incorrect results.');
}
} catch (error) {
core.startGroup('Warning, unable to find base results');
core.error(error);
core.endGroup();
}

core.startGroup('Getting current overhead measurements');
try {
current = await getAveragedOverheadMeasurements();
} catch (error) {
core.error('Error getting current overhead measurements');
core.endGroup();
throw error;
}
core.debug(`Current overhead measurements: ${JSON.stringify(current, null, 2)}`);
core.endGroup();

const thresholdNumber = Number(threshold);

const nodeOverheadComment = await fetchPreviousComment(octokit, repo, pr);

if (nodeOverheadComment) {
core.debug('Found existing node overhead comment, updating it instead of creating a new one...');
}

const shouldComment = isNaN(thresholdNumber) || hasChanges(base, current, thresholdNumber) || nodeOverheadComment;

if (shouldComment) {
const bodyParts = [
NODE_OVERHEAD_HEADING,
'Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.',
];

if (baseIsNotLatest) {
bodyParts.push(
'⚠️ **Warning:** Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.',
);
}
try {
bodyParts.push(markdownTable(formatResults(base, current)));
} catch (error) {
core.error('Error generating markdown table');
throw error;
}

if (baseWorkflowRun) {
bodyParts.push('');
bodyParts.push(`[View base workflow run](${baseWorkflowRun.html_url})`);
}

const body = bodyParts.join('\r\n');

try {
if (!nodeOverheadComment) {
await octokit.rest.issues.createComment({
...repo,
issue_number: pr.number,
body,
});
} else {
await octokit.rest.issues.updateComment({
...repo,
comment_id: nodeOverheadComment.id,
body,
});
}
} catch (error) {
core.error(
"Error updating comment. This can happen for PR's originating from a fork without write permissions.",
);
}
} else {
core.debug('Skipping comment because there are no changes.');
}
} catch (error) {
core.error(error);
setFailed(error.message);
}
}

async function runNodeOverheadOnComparisonBranch() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const resultsFilePath = getResultsFilePath();

const artifactClient = new DefaultArtifactClient();

const result = await getAveragedOverheadMeasurements();

try {
await fs.writeFile(resultsFilePath, JSON.stringify(result), 'utf8');
} catch (error) {
core.error('Error parsing node overhead output. The output should be a json.');
throw error;
}

const globber = await glob.create(resultsFilePath, {
followSymbolicLinks: false,
});
const files = await globber.glob();

await artifactClient.uploadArtifact(ARTIFACT_NAME, files, __dirname);
}

run();

/**
* Use GitHub API to fetch artifact download url, then
* download and extract artifact to `downloadPath`
*/
async function downloadOtherWorkflowArtifact(octokit, { owner, repo, artifactId, artifactName, downloadPath }) {
const artifact = await octokit.rest.actions.downloadArtifact({
owner,
repo,
artifact_id: artifactId,
archive_format: 'zip',
});

// Make sure output path exists
try {
await io.mkdirP(downloadPath);
} catch {
// ignore errors
}

const downloadFile = path.resolve(downloadPath, `${artifactName}.zip`);

await exec('wget', [
'-nv',
'--retry-connrefused',
'--waitretry=1',
'--read-timeout=20',
'--timeout=15',
'-t',
'0',
'-O',
downloadFile,
artifact.url,
]);

await exec('unzip', ['-q', '-d', downloadPath, downloadFile], {
silent: true,
});
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,6 +200,9 @@ jobs:
changed_node:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/node') }}
changed_node_overhead_action:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry-internal/node-overhead-gh-action') }}
changed_deno:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/deno') }}
Expand DownExpand Up@@ -253,6 +256,37 @@ jobs:
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_node_overhead_check:
name: Node Overhead Check
needs: [job_get_metadata, job_build]
timeout-minutes: 15
runs-on: ubuntu-24.04
if:
(needs.job_build.outputs.changed_node == 'true' && github.event_name == 'pull_request') ||
(needs.job_build.outputs.changed_node_overhead_action == 'true' && github.event_name == 'pull_request') ||
needs.job_get_metadata.outputs.is_base_branch == 'true' || needs.job_get_metadata.outputs.is_release == 'true'
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
- name: Restore caches
uses: ./.github/actions/restore-cache
with:
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
- name: Check node overhead
uses: ./dev-packages/node-overhead-gh-action
env:
DEBUG: '1'
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_lint:
name: Lint
# Even though the linter only checks source code, not built code, it needs the built code in order check that all
Expand Down
15 changes: 15 additions & 0 deletions dev-packages/node-overhead-gh-action/.eslintrc.cjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
module.exports = {
env: {
node: true,
},
extends: ['../../.eslintrc.js'],
overrides: [
{
files: ['**/*.mjs'],
parserOptions: {
project: ['tsconfig.json'],
sourceType: 'module',
},
},
],
};
3 changes: 3 additions & 0 deletions dev-packages/node-overhead-gh-action/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
# node-overhead-gh-action

Capture the overhead of Sentry in a node app.
17 changes: 17 additions & 0 deletions dev-packages/node-overhead-gh-action/action.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
name: 'node-overhead-gh-action'
description: 'Run node overhead comparison'
inputs:
github_token:
required: true
description: 'a github access token'
comparison_branch:
required: false
default: ''
description: 'If set, compare the current branch with this branch'
threshold:
required: false
default: '3'
description: 'The percentage threshold for size changes before posting a comment'
runs:
using: 'node24'
main: 'index.mjs'
25 changes: 25 additions & 0 deletions dev-packages/node-overhead-gh-action/db/init/init.sql
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
CREATE DATABASE mydb;
USE mydb

-- SQL script to create the 'users' table and insert initial data.

-- 1. Create the 'users' table
-- This table stores basic user information.
-- 'id' is the primary key and will automatically increment for each new record.
-- 'name' stores the user's name, up to 255 characters.
-- 'age' stores the user's age as an integer.

CREATE TABLE users (
id INT PRIMARY KEY AUTO_INCREMENT,
name VARCHAR(255) NOT NULL,
age INT
);

-- 2. Insert 5 rows into the 'users' table
-- Populating the table with some sample data.

INSERT INTO users (name, age) VALUES ('Alice Johnson', 28);
INSERT INTO users (name, age) VALUES ('Bob Smith', 45);
INSERT INTO users (name, age) VALUES ('Charlie Brown', 32);
INSERT INTO users (name, age) VALUES ('Diana Prince', 25);
INSERT INTO users (name, age) VALUES ('Ethan Hunt', 41);
12 changes: 12 additions & 0 deletions dev-packages/node-overhead-gh-action/docker-compose.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
services:
db:
image: mysql:8
restart: always
container_name: node-overhead-gh-action-mysql
ports:
- '3306:3306'
environment:
MYSQL_ROOT_PASSWORD: password
volumes:
# - ./db/data:/var/lib/mysql
- ./db/init:/docker-entrypoint-initdb.d/:ro
236 changes: 236 additions & 0 deletions dev-packages/node-overhead-gh-action/index.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,236 @@
import { promises as fs } from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { DefaultArtifactClient } from '@actions/artifact';
import * as core from '@actions/core';
import { exec } from '@actions/exec';
import { context, getOctokit } from '@actions/github';
import * as glob from '@actions/glob';
import * as io from '@actions/io';
import { markdownTable } from 'markdown-table';
import { getArtifactsForBranchAndWorkflow } from './lib/getArtifactsForBranchAndWorkflow.mjs';
import { getAveragedOverheadMeasurements } from './lib/getOverheadMeasurements.mjs';
import { formatResults, hasChanges } from './lib/markdown-table-formatter.mjs';

const NODE_OVERHEAD_HEADING = '## node-overhead report 🧳';
const ARTIFACT_NAME = 'node-overhead-action';
const RESULTS_FILE = 'node-overhead-results.json';

function getResultsFilePath() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
return path.resolve(__dirname, RESULTS_FILE);
}

const { getInput, setFailed } = core;

async function fetchPreviousComment(octokit, repo, pr) {
const { data: commentList } = await octokit.rest.issues.listComments({
...repo,
issue_number: pr.number,
});

return commentList.find(comment => comment.body.startsWith(NODE_OVERHEAD_HEADING));
}

async function run() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));

try {
const { payload, repo } = context;
const pr = payload.pull_request;

const comparisonBranch = getInput('comparison_branch');
const githubToken = getInput('github_token');
const threshold = getInput('threshold') || 1;

if (comparisonBranch && !pr) {
throw new Error('No PR found. Only pull_request workflows are supported.');
}

const octokit = getOctokit(githubToken);
const resultsFilePath = getResultsFilePath();

// If we have no comparison branch, we just run overhead check & store the result as artifact
if (!comparisonBranch) {
return runNodeOverheadOnComparisonBranch();
}

// Else, we run overhead check for the current branch, AND fetch it for the comparison branch
let base;
let current;
let baseIsNotLatest = false;
let baseWorkflowRun;

try {
const workflowName = `${process.env.GITHUB_WORKFLOW || ''}`;
core.startGroup(`getArtifactsForBranchAndWorkflow - workflow:"${workflowName}", branch:"${comparisonBranch}"`);
const artifacts = await getArtifactsForBranchAndWorkflow(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
branch: comparisonBranch,
workflowName,
});
core.endGroup();

if (!artifacts) {
throw new Error('No artifacts found');
}

baseWorkflowRun = artifacts.workflowRun;

await downloadOtherWorkflowArtifact(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
artifactId: artifacts.artifact.id,
downloadPath: __dirname,
});

base = JSON.parse(await fs.readFile(resultsFilePath, { encoding: 'utf8' }));

if (!artifacts.isLatest) {
baseIsNotLatest = true;
core.info('Base artifact is not the latest one. This may lead to incorrect results.');
}
} catch (error) {
core.startGroup('Warning, unable to find base results');
core.error(error);
core.endGroup();
}

core.startGroup('Getting current overhead measurements');
try {
current = await getAveragedOverheadMeasurements();
} catch (error) {
core.error('Error getting current overhead measurements');
core.endGroup();
throw error;
}
core.debug(`Current overhead measurements: ${JSON.stringify(current, null, 2)}`);
core.endGroup();

const thresholdNumber = Number(threshold);

const nodeOverheadComment = await fetchPreviousComment(octokit, repo, pr);

if (nodeOverheadComment) {
core.debug('Found existing node overhead comment, updating it instead of creating a new one...');
}

const shouldComment = isNaN(thresholdNumber) || hasChanges(base, current, thresholdNumber) || nodeOverheadComment;

if (shouldComment) {
const bodyParts = [
NODE_OVERHEAD_HEADING,
'Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.',
];

if (baseIsNotLatest) {
bodyParts.push(
'⚠️ **Warning:** Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.',
);
}
try {
bodyParts.push(markdownTable(formatResults(base, current)));
} catch (error) {
core.error('Error generating markdown table');
throw error;
}

if (baseWorkflowRun) {
bodyParts.push('');
bodyParts.push(`[View base workflow run](${baseWorkflowRun.html_url})`);
}

const body = bodyParts.join('\r\n');

try {
if (!nodeOverheadComment) {
await octokit.rest.issues.createComment({
...repo,
issue_number: pr.number,
body,
});
} else {
await octokit.rest.issues.updateComment({
...repo,
comment_id: nodeOverheadComment.id,
body,
});
}
} catch (error) {
core.error(
"Error updating comment. This can happen for PR's originating from a fork without write permissions.",
);
}
} else {
core.debug('Skipping comment because there are no changes.');
}
} catch (error) {
core.error(error);
setFailed(error.message);
}
}

async function runNodeOverheadOnComparisonBranch() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const resultsFilePath = getResultsFilePath();

const artifactClient = new DefaultArtifactClient();

const result = await getAveragedOverheadMeasurements();

try {
await fs.writeFile(resultsFilePath, JSON.stringify(result), 'utf8');
} catch (error) {
core.error('Error parsing node overhead output. The output should be a json.');
throw error;
}

const globber = await glob.create(resultsFilePath, {
followSymbolicLinks: false,
});
const files = await globber.glob();

await artifactClient.uploadArtifact(ARTIFACT_NAME, files, __dirname);
}

run();

/**
* Use GitHub API to fetch artifact download url, then
* download and extract artifact to `downloadPath`
*/
async function downloadOtherWorkflowArtifact(octokit, { owner, repo, artifactId, artifactName, downloadPath }) {
const artifact = await octokit.rest.actions.downloadArtifact({
owner,
repo,
artifact_id: artifactId,
archive_format: 'zip',
});

// Make sure output path exists
try {
await io.mkdirP(downloadPath);
} catch {
// ignore errors
}

const downloadFile = path.resolve(downloadPath, `${artifactName}.zip`);

await exec('wget', [
'-nv',
'--retry-connrefused',
'--waitretry=1',
'--read-timeout=20',
'--timeout=15',
'-t',
'0',
'-O',
downloadFile,
artifact.url,
]);

await exec('unzip', ['-q', '-d', downloadPath, downloadFile], {
silent: true,
});
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,6 +200,9 @@ jobs:
changed_node:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/node') }}
changed_node_overhead_action:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry-internal/node-overhead-gh-action') }}
changed_deno:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/deno') }}
Expand DownExpand Up@@ -253,6 +256,37 @@ jobs:
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_node_overhead_check:
name: Node Overhead Check
needs: [job_get_metadata, job_build]
timeout-minutes: 15
runs-on: ubuntu-24.04
if:
(needs.job_build.outputs.changed_node == 'true' && github.event_name == 'pull_request') ||
(needs.job_build.outputs.changed_node_overhead_action == 'true' && github.event_name == 'pull_request') ||
needs.job_get_metadata.outputs.is_base_branch == 'true' || needs.job_get_metadata.outputs.is_release == 'true'
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
- name: Restore caches
uses: ./.github/actions/restore-cache
with:
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
- name: Check node overhead
uses: ./dev-packages/node-overhead-gh-action
env:
DEBUG: '1'
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_lint:
name: Lint
# Even though the linter only checks source code, not built code, it needs the built code in order check that all
Expand Down
15 changes: 15 additions & 0 deletions dev-packages/node-overhead-gh-action/.eslintrc.cjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
module.exports = {
env: {
node: true,
},
extends: ['../../.eslintrc.js'],
overrides: [
{
files: ['**/*.mjs'],
parserOptions: {
project: ['tsconfig.json'],
sourceType: 'module',
},
},
],
};
3 changes: 3 additions & 0 deletions dev-packages/node-overhead-gh-action/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
# node-overhead-gh-action

Capture the overhead of Sentry in a node app.
17 changes: 17 additions & 0 deletions dev-packages/node-overhead-gh-action/action.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
name: 'node-overhead-gh-action'
description: 'Run node overhead comparison'
inputs:
github_token:
required: true
description: 'a github access token'
comparison_branch:
required: false
default: ''
description: 'If set, compare the current branch with this branch'
threshold:
required: false
default: '3'
description: 'The percentage threshold for size changes before posting a comment'
runs:
using: 'node24'
main: 'index.mjs'
25 changes: 25 additions & 0 deletions dev-packages/node-overhead-gh-action/db/init/init.sql
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
CREATE DATABASE mydb;
USE mydb

-- SQL script to create the 'users' table and insert initial data.

-- 1. Create the 'users' table
-- This table stores basic user information.
-- 'id' is the primary key and will automatically increment for each new record.
-- 'name' stores the user's name, up to 255 characters.
-- 'age' stores the user's age as an integer.

CREATE TABLE users (
id INT PRIMARY KEY AUTO_INCREMENT,
name VARCHAR(255) NOT NULL,
age INT
);

-- 2. Insert 5 rows into the 'users' table
-- Populating the table with some sample data.

INSERT INTO users (name, age) VALUES ('Alice Johnson', 28);
INSERT INTO users (name, age) VALUES ('Bob Smith', 45);
INSERT INTO users (name, age) VALUES ('Charlie Brown', 32);
INSERT INTO users (name, age) VALUES ('Diana Prince', 25);
INSERT INTO users (name, age) VALUES ('Ethan Hunt', 41);
12 changes: 12 additions & 0 deletions dev-packages/node-overhead-gh-action/docker-compose.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
services:
db:
image: mysql:8
restart: always
container_name: node-overhead-gh-action-mysql
ports:
- '3306:3306'
environment:
MYSQL_ROOT_PASSWORD: password
volumes:
# - ./db/data:/var/lib/mysql
- ./db/init:/docker-entrypoint-initdb.d/:ro
236 changes: 236 additions & 0 deletions dev-packages/node-overhead-gh-action/index.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,236 @@
import { promises as fs } from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { DefaultArtifactClient } from '@actions/artifact';
import * as core from '@actions/core';
import { exec } from '@actions/exec';
import { context, getOctokit } from '@actions/github';
import * as glob from '@actions/glob';
import * as io from '@actions/io';
import { markdownTable } from 'markdown-table';
import { getArtifactsForBranchAndWorkflow } from './lib/getArtifactsForBranchAndWorkflow.mjs';
import { getAveragedOverheadMeasurements } from './lib/getOverheadMeasurements.mjs';
import { formatResults, hasChanges } from './lib/markdown-table-formatter.mjs';

const NODE_OVERHEAD_HEADING = '## node-overhead report 🧳';
const ARTIFACT_NAME = 'node-overhead-action';
const RESULTS_FILE = 'node-overhead-results.json';

function getResultsFilePath() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
return path.resolve(__dirname, RESULTS_FILE);
}

const { getInput, setFailed } = core;

async function fetchPreviousComment(octokit, repo, pr) {
const { data: commentList } = await octokit.rest.issues.listComments({
...repo,
issue_number: pr.number,
});

return commentList.find(comment => comment.body.startsWith(NODE_OVERHEAD_HEADING));
}

async function run() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));

try {
const { payload, repo } = context;
const pr = payload.pull_request;

const comparisonBranch = getInput('comparison_branch');
const githubToken = getInput('github_token');
const threshold = getInput('threshold') || 1;

if (comparisonBranch && !pr) {
throw new Error('No PR found. Only pull_request workflows are supported.');
}

const octokit = getOctokit(githubToken);
const resultsFilePath = getResultsFilePath();

// If we have no comparison branch, we just run overhead check & store the result as artifact
if (!comparisonBranch) {
return runNodeOverheadOnComparisonBranch();
}

// Else, we run overhead check for the current branch, AND fetch it for the comparison branch
let base;
let current;
let baseIsNotLatest = false;
let baseWorkflowRun;

try {
const workflowName = `${process.env.GITHUB_WORKFLOW || ''}`;
core.startGroup(`getArtifactsForBranchAndWorkflow - workflow:"${workflowName}", branch:"${comparisonBranch}"`);
const artifacts = await getArtifactsForBranchAndWorkflow(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
branch: comparisonBranch,
workflowName,
});
core.endGroup();

if (!artifacts) {
throw new Error('No artifacts found');
}

baseWorkflowRun = artifacts.workflowRun;

await downloadOtherWorkflowArtifact(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
artifactId: artifacts.artifact.id,
downloadPath: __dirname,
});

base = JSON.parse(await fs.readFile(resultsFilePath, { encoding: 'utf8' }));

if (!artifacts.isLatest) {
baseIsNotLatest = true;
core.info('Base artifact is not the latest one. This may lead to incorrect results.');
}
} catch (error) {
core.startGroup('Warning, unable to find base results');
core.error(error);
core.endGroup();
}

core.startGroup('Getting current overhead measurements');
try {
current = await getAveragedOverheadMeasurements();
} catch (error) {
core.error('Error getting current overhead measurements');
core.endGroup();
throw error;
}
core.debug(`Current overhead measurements: ${JSON.stringify(current, null, 2)}`);
core.endGroup();

const thresholdNumber = Number(threshold);

const nodeOverheadComment = await fetchPreviousComment(octokit, repo, pr);

if (nodeOverheadComment) {
core.debug('Found existing node overhead comment, updating it instead of creating a new one...');
}

const shouldComment = isNaN(thresholdNumber) || hasChanges(base, current, thresholdNumber) || nodeOverheadComment;

if (shouldComment) {
const bodyParts = [
NODE_OVERHEAD_HEADING,
'Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.',
];

if (baseIsNotLatest) {
bodyParts.push(
'⚠️ **Warning:** Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.',
);
}
try {
bodyParts.push(markdownTable(formatResults(base, current)));
} catch (error) {
core.error('Error generating markdown table');
throw error;
}

if (baseWorkflowRun) {
bodyParts.push('');
bodyParts.push(`[View base workflow run](${baseWorkflowRun.html_url})`);
}

const body = bodyParts.join('\r\n');

try {
if (!nodeOverheadComment) {
await octokit.rest.issues.createComment({
...repo,
issue_number: pr.number,
body,
});
} else {
await octokit.rest.issues.updateComment({
...repo,
comment_id: nodeOverheadComment.id,
body,
});
}
} catch (error) {
core.error(
"Error updating comment. This can happen for PR's originating from a fork without write permissions.",
);
}
} else {
core.debug('Skipping comment because there are no changes.');
}
} catch (error) {
core.error(error);
setFailed(error.message);
}
}

async function runNodeOverheadOnComparisonBranch() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const resultsFilePath = getResultsFilePath();

const artifactClient = new DefaultArtifactClient();

const result = await getAveragedOverheadMeasurements();

try {
await fs.writeFile(resultsFilePath, JSON.stringify(result), 'utf8');
} catch (error) {
core.error('Error parsing node overhead output. The output should be a json.');
throw error;
}

const globber = await glob.create(resultsFilePath, {
followSymbolicLinks: false,
});
const files = await globber.glob();

await artifactClient.uploadArtifact(ARTIFACT_NAME, files, __dirname);
}

run();

/**
* Use GitHub API to fetch artifact download url, then
* download and extract artifact to `downloadPath`
*/
async function downloadOtherWorkflowArtifact(octokit, { owner, repo, artifactId, artifactName, downloadPath }) {
const artifact = await octokit.rest.actions.downloadArtifact({
owner,
repo,
artifact_id: artifactId,
archive_format: 'zip',
});

// Make sure output path exists
try {
await io.mkdirP(downloadPath);
} catch {
// ignore errors
}

const downloadFile = path.resolve(downloadPath, `${artifactName}.zip`);

await exec('wget', [
'-nv',
'--retry-connrefused',
'--waitretry=1',
'--read-timeout=20',
'--timeout=15',
'-t',
'0',
'-O',
downloadFile,
artifact.url,
]);

await exec('unzip', ['-q', '-d', downloadPath, downloadFile], {
silent: true,
});
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,6 +200,9 @@ jobs:
changed_node:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/node') }}
changed_node_overhead_action:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry-internal/node-overhead-gh-action') }}
changed_deno:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/deno') }}
Expand DownExpand Up@@ -253,6 +256,37 @@ jobs:
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_node_overhead_check:
name: Node Overhead Check
needs: [job_get_metadata, job_build]
timeout-minutes: 15
runs-on: ubuntu-24.04
if:
(needs.job_build.outputs.changed_node == 'true' && github.event_name == 'pull_request') ||
(needs.job_build.outputs.changed_node_overhead_action == 'true' && github.event_name == 'pull_request') ||
needs.job_get_metadata.outputs.is_base_branch == 'true' || needs.job_get_metadata.outputs.is_release == 'true'
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
- name: Restore caches
uses: ./.github/actions/restore-cache
with:
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
- name: Check node overhead
uses: ./dev-packages/node-overhead-gh-action
env:
DEBUG: '1'
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_lint:
name: Lint
# Even though the linter only checks source code, not built code, it needs the built code in order check that all
Expand Down
15 changes: 15 additions & 0 deletions dev-packages/node-overhead-gh-action/.eslintrc.cjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
module.exports = {
env: {
node: true,
},
extends: ['../../.eslintrc.js'],
overrides: [
{
files: ['**/*.mjs'],
parserOptions: {
project: ['tsconfig.json'],
sourceType: 'module',
},
},
],
};
3 changes: 3 additions & 0 deletions dev-packages/node-overhead-gh-action/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
# node-overhead-gh-action

Capture the overhead of Sentry in a node app.
17 changes: 17 additions & 0 deletions dev-packages/node-overhead-gh-action/action.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
name: 'node-overhead-gh-action'
description: 'Run node overhead comparison'
inputs:
github_token:
required: true
description: 'a github access token'
comparison_branch:
required: false
default: ''
description: 'If set, compare the current branch with this branch'
threshold:
required: false
default: '3'
description: 'The percentage threshold for size changes before posting a comment'
runs:
using: 'node24'
main: 'index.mjs'
25 changes: 25 additions & 0 deletions dev-packages/node-overhead-gh-action/db/init/init.sql
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
CREATE DATABASE mydb;
USE mydb

-- SQL script to create the 'users' table and insert initial data.

-- 1. Create the 'users' table
-- This table stores basic user information.
-- 'id' is the primary key and will automatically increment for each new record.
-- 'name' stores the user's name, up to 255 characters.
-- 'age' stores the user's age as an integer.

CREATE TABLE users (
id INT PRIMARY KEY AUTO_INCREMENT,
name VARCHAR(255) NOT NULL,
age INT
);

-- 2. Insert 5 rows into the 'users' table
-- Populating the table with some sample data.

INSERT INTO users (name, age) VALUES ('Alice Johnson', 28);
INSERT INTO users (name, age) VALUES ('Bob Smith', 45);
INSERT INTO users (name, age) VALUES ('Charlie Brown', 32);
INSERT INTO users (name, age) VALUES ('Diana Prince', 25);
INSERT INTO users (name, age) VALUES ('Ethan Hunt', 41);
12 changes: 12 additions & 0 deletions dev-packages/node-overhead-gh-action/docker-compose.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
services:
db:
image: mysql:8
restart: always
container_name: node-overhead-gh-action-mysql
ports:
- '3306:3306'
environment:
MYSQL_ROOT_PASSWORD: password
volumes:
# - ./db/data:/var/lib/mysql
- ./db/init:/docker-entrypoint-initdb.d/:ro
236 changes: 236 additions & 0 deletions dev-packages/node-overhead-gh-action/index.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,236 @@
import { promises as fs } from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { DefaultArtifactClient } from '@actions/artifact';
import * as core from '@actions/core';
import { exec } from '@actions/exec';
import { context, getOctokit } from '@actions/github';
import * as glob from '@actions/glob';
import * as io from '@actions/io';
import { markdownTable } from 'markdown-table';
import { getArtifactsForBranchAndWorkflow } from './lib/getArtifactsForBranchAndWorkflow.mjs';
import { getAveragedOverheadMeasurements } from './lib/getOverheadMeasurements.mjs';
import { formatResults, hasChanges } from './lib/markdown-table-formatter.mjs';

const NODE_OVERHEAD_HEADING = '## node-overhead report 🧳';
const ARTIFACT_NAME = 'node-overhead-action';
const RESULTS_FILE = 'node-overhead-results.json';

function getResultsFilePath() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
return path.resolve(__dirname, RESULTS_FILE);
}

const { getInput, setFailed } = core;

async function fetchPreviousComment(octokit, repo, pr) {
const { data: commentList } = await octokit.rest.issues.listComments({
...repo,
issue_number: pr.number,
});

return commentList.find(comment => comment.body.startsWith(NODE_OVERHEAD_HEADING));
}

async function run() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));

try {
const { payload, repo } = context;
const pr = payload.pull_request;

const comparisonBranch = getInput('comparison_branch');
const githubToken = getInput('github_token');
const threshold = getInput('threshold') || 1;

if (comparisonBranch && !pr) {
throw new Error('No PR found. Only pull_request workflows are supported.');
}

const octokit = getOctokit(githubToken);
const resultsFilePath = getResultsFilePath();

// If we have no comparison branch, we just run overhead check & store the result as artifact
if (!comparisonBranch) {
return runNodeOverheadOnComparisonBranch();
}

// Else, we run overhead check for the current branch, AND fetch it for the comparison branch
let base;
let current;
let baseIsNotLatest = false;
let baseWorkflowRun;

try {
const workflowName = `${process.env.GITHUB_WORKFLOW || ''}`;
core.startGroup(`getArtifactsForBranchAndWorkflow - workflow:"${workflowName}", branch:"${comparisonBranch}"`);
const artifacts = await getArtifactsForBranchAndWorkflow(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
branch: comparisonBranch,
workflowName,
});
core.endGroup();

if (!artifacts) {
throw new Error('No artifacts found');
}

baseWorkflowRun = artifacts.workflowRun;

await downloadOtherWorkflowArtifact(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
artifactId: artifacts.artifact.id,
downloadPath: __dirname,
});

base = JSON.parse(await fs.readFile(resultsFilePath, { encoding: 'utf8' }));

if (!artifacts.isLatest) {
baseIsNotLatest = true;
core.info('Base artifact is not the latest one. This may lead to incorrect results.');
}
} catch (error) {
core.startGroup('Warning, unable to find base results');
core.error(error);
core.endGroup();
}

core.startGroup('Getting current overhead measurements');
try {
current = await getAveragedOverheadMeasurements();
} catch (error) {
core.error('Error getting current overhead measurements');
core.endGroup();
throw error;
}
core.debug(`Current overhead measurements: ${JSON.stringify(current, null, 2)}`);
core.endGroup();

const thresholdNumber = Number(threshold);

const nodeOverheadComment = await fetchPreviousComment(octokit, repo, pr);

if (nodeOverheadComment) {
core.debug('Found existing node overhead comment, updating it instead of creating a new one...');
}

const shouldComment = isNaN(thresholdNumber) || hasChanges(base, current, thresholdNumber) || nodeOverheadComment;

if (shouldComment) {
const bodyParts = [
NODE_OVERHEAD_HEADING,
'Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.',
];

if (baseIsNotLatest) {
bodyParts.push(
'⚠️ **Warning:** Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.',
);
}
try {
bodyParts.push(markdownTable(formatResults(base, current)));
} catch (error) {
core.error('Error generating markdown table');
throw error;
}

if (baseWorkflowRun) {
bodyParts.push('');
bodyParts.push(`[View base workflow run](${baseWorkflowRun.html_url})`);
}

const body = bodyParts.join('\r\n');

try {
if (!nodeOverheadComment) {
await octokit.rest.issues.createComment({
...repo,
issue_number: pr.number,
body,
});
} else {
await octokit.rest.issues.updateComment({
...repo,
comment_id: nodeOverheadComment.id,
body,
});
}
} catch (error) {
core.error(
"Error updating comment. This can happen for PR's originating from a fork without write permissions.",
);
}
} else {
core.debug('Skipping comment because there are no changes.');
}
} catch (error) {
core.error(error);
setFailed(error.message);
}
}

async function runNodeOverheadOnComparisonBranch() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const resultsFilePath = getResultsFilePath();

const artifactClient = new DefaultArtifactClient();

const result = await getAveragedOverheadMeasurements();

try {
await fs.writeFile(resultsFilePath, JSON.stringify(result), 'utf8');
} catch (error) {
core.error('Error parsing node overhead output. The output should be a json.');
throw error;
}

const globber = await glob.create(resultsFilePath, {
followSymbolicLinks: false,
});
const files = await globber.glob();

await artifactClient.uploadArtifact(ARTIFACT_NAME, files, __dirname);
}

run();

/**
* Use GitHub API to fetch artifact download url, then
* download and extract artifact to `downloadPath`
*/
async function downloadOtherWorkflowArtifact(octokit, { owner, repo, artifactId, artifactName, downloadPath }) {
const artifact = await octokit.rest.actions.downloadArtifact({
owner,
repo,
artifact_id: artifactId,
archive_format: 'zip',
});

// Make sure output path exists
try {
await io.mkdirP(downloadPath);
} catch {
// ignore errors
}

const downloadFile = path.resolve(downloadPath, `${artifactName}.zip`);

await exec('wget', [
'-nv',
'--retry-connrefused',
'--waitretry=1',
'--read-timeout=20',
'--timeout=15',
'-t',
'0',
'-O',
downloadFile,
artifact.url,
]);

await exec('unzip', ['-q', '-d', downloadPath, downloadFile], {
silent: true,
});
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,6 +200,9 @@ jobs:
changed_node:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/node') }}
changed_node_overhead_action:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry-internal/node-overhead-gh-action') }}
changed_deno:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/deno') }}
Expand DownExpand Up@@ -253,6 +256,37 @@ jobs:
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_node_overhead_check:
name: Node Overhead Check
needs: [job_get_metadata, job_build]
timeout-minutes: 15
runs-on: ubuntu-24.04
if:
(needs.job_build.outputs.changed_node == 'true' && github.event_name == 'pull_request') ||
(needs.job_build.outputs.changed_node_overhead_action == 'true' && github.event_name == 'pull_request') ||
needs.job_get_metadata.outputs.is_base_branch == 'true' || needs.job_get_metadata.outputs.is_release == 'true'
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
- name: Restore caches
uses: ./.github/actions/restore-cache
with:
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
- name: Check node overhead
uses: ./dev-packages/node-overhead-gh-action
env:
DEBUG: '1'
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_lint:
name: Lint
# Even though the linter only checks source code, not built code, it needs the built code in order check that all
Expand Down
15 changes: 15 additions & 0 deletions dev-packages/node-overhead-gh-action/.eslintrc.cjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
module.exports = {
env: {
node: true,
},
extends: ['../../.eslintrc.js'],
overrides: [
{
files: ['**/*.mjs'],
parserOptions: {
project: ['tsconfig.json'],
sourceType: 'module',
},
},
],
};
3 changes: 3 additions & 0 deletions dev-packages/node-overhead-gh-action/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
# node-overhead-gh-action

Capture the overhead of Sentry in a node app.
17 changes: 17 additions & 0 deletions dev-packages/node-overhead-gh-action/action.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
name: 'node-overhead-gh-action'
description: 'Run node overhead comparison'
inputs:
github_token:
required: true
description: 'a github access token'
comparison_branch:
required: false
default: ''
description: 'If set, compare the current branch with this branch'
threshold:
required: false
default: '3'
description: 'The percentage threshold for size changes before posting a comment'
runs:
using: 'node24'
main: 'index.mjs'
25 changes: 25 additions & 0 deletions dev-packages/node-overhead-gh-action/db/init/init.sql
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
CREATE DATABASE mydb;
USE mydb

-- SQL script to create the 'users' table and insert initial data.

-- 1. Create the 'users' table
-- This table stores basic user information.
-- 'id' is the primary key and will automatically increment for each new record.
-- 'name' stores the user's name, up to 255 characters.
-- 'age' stores the user's age as an integer.

CREATE TABLE users (
id INT PRIMARY KEY AUTO_INCREMENT,
name VARCHAR(255) NOT NULL,
age INT
);

-- 2. Insert 5 rows into the 'users' table
-- Populating the table with some sample data.

INSERT INTO users (name, age) VALUES ('Alice Johnson', 28);
INSERT INTO users (name, age) VALUES ('Bob Smith', 45);
INSERT INTO users (name, age) VALUES ('Charlie Brown', 32);
INSERT INTO users (name, age) VALUES ('Diana Prince', 25);
INSERT INTO users (name, age) VALUES ('Ethan Hunt', 41);
12 changes: 12 additions & 0 deletions dev-packages/node-overhead-gh-action/docker-compose.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
services:
db:
image: mysql:8
restart: always
container_name: node-overhead-gh-action-mysql
ports:
- '3306:3306'
environment:
MYSQL_ROOT_PASSWORD: password
volumes:
# - ./db/data:/var/lib/mysql
- ./db/init:/docker-entrypoint-initdb.d/:ro
236 changes: 236 additions & 0 deletions dev-packages/node-overhead-gh-action/index.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,236 @@
import { promises as fs } from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { DefaultArtifactClient } from '@actions/artifact';
import * as core from '@actions/core';
import { exec } from '@actions/exec';
import { context, getOctokit } from '@actions/github';
import * as glob from '@actions/glob';
import * as io from '@actions/io';
import { markdownTable } from 'markdown-table';
import { getArtifactsForBranchAndWorkflow } from './lib/getArtifactsForBranchAndWorkflow.mjs';
import { getAveragedOverheadMeasurements } from './lib/getOverheadMeasurements.mjs';
import { formatResults, hasChanges } from './lib/markdown-table-formatter.mjs';

const NODE_OVERHEAD_HEADING = '## node-overhead report 🧳';
const ARTIFACT_NAME = 'node-overhead-action';
const RESULTS_FILE = 'node-overhead-results.json';

function getResultsFilePath() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
return path.resolve(__dirname, RESULTS_FILE);
}

const { getInput, setFailed } = core;

async function fetchPreviousComment(octokit, repo, pr) {
const { data: commentList } = await octokit.rest.issues.listComments({
...repo,
issue_number: pr.number,
});

return commentList.find(comment => comment.body.startsWith(NODE_OVERHEAD_HEADING));
}

async function run() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));

try {
const { payload, repo } = context;
const pr = payload.pull_request;

const comparisonBranch = getInput('comparison_branch');
const githubToken = getInput('github_token');
const threshold = getInput('threshold') || 1;

if (comparisonBranch && !pr) {
throw new Error('No PR found. Only pull_request workflows are supported.');
}

const octokit = getOctokit(githubToken);
const resultsFilePath = getResultsFilePath();

// If we have no comparison branch, we just run overhead check & store the result as artifact
if (!comparisonBranch) {
return runNodeOverheadOnComparisonBranch();
}

// Else, we run overhead check for the current branch, AND fetch it for the comparison branch
let base;
let current;
let baseIsNotLatest = false;
let baseWorkflowRun;

try {
const workflowName = `${process.env.GITHUB_WORKFLOW || ''}`;
core.startGroup(`getArtifactsForBranchAndWorkflow - workflow:"${workflowName}", branch:"${comparisonBranch}"`);
const artifacts = await getArtifactsForBranchAndWorkflow(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
branch: comparisonBranch,
workflowName,
});
core.endGroup();

if (!artifacts) {
throw new Error('No artifacts found');
}

baseWorkflowRun = artifacts.workflowRun;

await downloadOtherWorkflowArtifact(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
artifactId: artifacts.artifact.id,
downloadPath: __dirname,
});

base = JSON.parse(await fs.readFile(resultsFilePath, { encoding: 'utf8' }));

if (!artifacts.isLatest) {
baseIsNotLatest = true;
core.info('Base artifact is not the latest one. This may lead to incorrect results.');
}
} catch (error) {
core.startGroup('Warning, unable to find base results');
core.error(error);
core.endGroup();
}

core.startGroup('Getting current overhead measurements');
try {
current = await getAveragedOverheadMeasurements();
} catch (error) {
core.error('Error getting current overhead measurements');
core.endGroup();
throw error;
}
core.debug(`Current overhead measurements: ${JSON.stringify(current, null, 2)}`);
core.endGroup();

const thresholdNumber = Number(threshold);

const nodeOverheadComment = await fetchPreviousComment(octokit, repo, pr);

if (nodeOverheadComment) {
core.debug('Found existing node overhead comment, updating it instead of creating a new one...');
}

const shouldComment = isNaN(thresholdNumber) || hasChanges(base, current, thresholdNumber) || nodeOverheadComment;

if (shouldComment) {
const bodyParts = [
NODE_OVERHEAD_HEADING,
'Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.',
];

if (baseIsNotLatest) {
bodyParts.push(
'⚠️ **Warning:** Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.',
);
}
try {
bodyParts.push(markdownTable(formatResults(base, current)));
} catch (error) {
core.error('Error generating markdown table');
throw error;
}

if (baseWorkflowRun) {
bodyParts.push('');
bodyParts.push(`[View base workflow run](${baseWorkflowRun.html_url})`);
}

const body = bodyParts.join('\r\n');

try {
if (!nodeOverheadComment) {
await octokit.rest.issues.createComment({
...repo,
issue_number: pr.number,
body,
});
} else {
await octokit.rest.issues.updateComment({
...repo,
comment_id: nodeOverheadComment.id,
body,
});
}
} catch (error) {
core.error(
"Error updating comment. This can happen for PR's originating from a fork without write permissions.",
);
}
} else {
core.debug('Skipping comment because there are no changes.');
}
} catch (error) {
core.error(error);
setFailed(error.message);
}
}

async function runNodeOverheadOnComparisonBranch() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const resultsFilePath = getResultsFilePath();

const artifactClient = new DefaultArtifactClient();

const result = await getAveragedOverheadMeasurements();

try {
await fs.writeFile(resultsFilePath, JSON.stringify(result), 'utf8');
} catch (error) {
core.error('Error parsing node overhead output. The output should be a json.');
throw error;
}

const globber = await glob.create(resultsFilePath, {
followSymbolicLinks: false,
});
const files = await globber.glob();

await artifactClient.uploadArtifact(ARTIFACT_NAME, files, __dirname);
}

run();

/**
* Use GitHub API to fetch artifact download url, then
* download and extract artifact to `downloadPath`
*/
async function downloadOtherWorkflowArtifact(octokit, { owner, repo, artifactId, artifactName, downloadPath }) {
const artifact = await octokit.rest.actions.downloadArtifact({
owner,
repo,
artifact_id: artifactId,
archive_format: 'zip',
});

// Make sure output path exists
try {
await io.mkdirP(downloadPath);
} catch {
// ignore errors
}

const downloadFile = path.resolve(downloadPath, `${artifactName}.zip`);

await exec('wget', [
'-nv',
'--retry-connrefused',
'--waitretry=1',
'--read-timeout=20',
'--timeout=15',
'-t',
'0',
'-O',
downloadFile,
artifact.url,
]);

await exec('unzip', ['-q', '-d', downloadPath, downloadFile], {
silent: true,
});
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,6 +200,9 @@ jobs:
changed_node:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/node') }}
changed_node_overhead_action:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry-internal/node-overhead-gh-action') }}
changed_deno:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/deno') }}
Expand DownExpand Up@@ -253,6 +256,37 @@ jobs:
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_node_overhead_check:
name: Node Overhead Check
needs: [job_get_metadata, job_build]
timeout-minutes: 15
runs-on: ubuntu-24.04
if:
(needs.job_build.outputs.changed_node == 'true' && github.event_name == 'pull_request') ||
(needs.job_build.outputs.changed_node_overhead_action == 'true' && github.event_name == 'pull_request') ||
needs.job_get_metadata.outputs.is_base_branch == 'true' || needs.job_get_metadata.outputs.is_release == 'true'
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
- name: Restore caches
uses: ./.github/actions/restore-cache
with:
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
- name: Check node overhead
uses: ./dev-packages/node-overhead-gh-action
env:
DEBUG: '1'
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_lint:
name: Lint
# Even though the linter only checks source code, not built code, it needs the built code in order check that all
Expand Down
15 changes: 15 additions & 0 deletions dev-packages/node-overhead-gh-action/.eslintrc.cjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
module.exports = {
env: {
node: true,
},
extends: ['../../.eslintrc.js'],
overrides: [
{
files: ['**/*.mjs'],
parserOptions: {
project: ['tsconfig.json'],
sourceType: 'module',
},
},
],
};
3 changes: 3 additions & 0 deletions dev-packages/node-overhead-gh-action/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
# node-overhead-gh-action

Capture the overhead of Sentry in a node app.
17 changes: 17 additions & 0 deletions dev-packages/node-overhead-gh-action/action.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
name: 'node-overhead-gh-action'
description: 'Run node overhead comparison'
inputs:
github_token:
required: true
description: 'a github access token'
comparison_branch:
required: false
default: ''
description: 'If set, compare the current branch with this branch'
threshold:
required: false
default: '3'
description: 'The percentage threshold for size changes before posting a comment'
runs:
using: 'node24'
main: 'index.mjs'
25 changes: 25 additions & 0 deletions dev-packages/node-overhead-gh-action/db/init/init.sql
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
CREATE DATABASE mydb;
USE mydb

-- SQL script to create the 'users' table and insert initial data.

-- 1. Create the 'users' table
-- This table stores basic user information.
-- 'id' is the primary key and will automatically increment for each new record.
-- 'name' stores the user's name, up to 255 characters.
-- 'age' stores the user's age as an integer.

CREATE TABLE users (
id INT PRIMARY KEY AUTO_INCREMENT,
name VARCHAR(255) NOT NULL,
age INT
);

-- 2. Insert 5 rows into the 'users' table
-- Populating the table with some sample data.

INSERT INTO users (name, age) VALUES ('Alice Johnson', 28);
INSERT INTO users (name, age) VALUES ('Bob Smith', 45);
INSERT INTO users (name, age) VALUES ('Charlie Brown', 32);
INSERT INTO users (name, age) VALUES ('Diana Prince', 25);
INSERT INTO users (name, age) VALUES ('Ethan Hunt', 41);
12 changes: 12 additions & 0 deletions dev-packages/node-overhead-gh-action/docker-compose.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
services:
db:
image: mysql:8
restart: always
container_name: node-overhead-gh-action-mysql
ports:
- '3306:3306'
environment:
MYSQL_ROOT_PASSWORD: password
volumes:
# - ./db/data:/var/lib/mysql
- ./db/init:/docker-entrypoint-initdb.d/:ro
236 changes: 236 additions & 0 deletions dev-packages/node-overhead-gh-action/index.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,236 @@
import { promises as fs } from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { DefaultArtifactClient } from '@actions/artifact';
import * as core from '@actions/core';
import { exec } from '@actions/exec';
import { context, getOctokit } from '@actions/github';
import * as glob from '@actions/glob';
import * as io from '@actions/io';
import { markdownTable } from 'markdown-table';
import { getArtifactsForBranchAndWorkflow } from './lib/getArtifactsForBranchAndWorkflow.mjs';
import { getAveragedOverheadMeasurements } from './lib/getOverheadMeasurements.mjs';
import { formatResults, hasChanges } from './lib/markdown-table-formatter.mjs';

const NODE_OVERHEAD_HEADING = '## node-overhead report 🧳';
const ARTIFACT_NAME = 'node-overhead-action';
const RESULTS_FILE = 'node-overhead-results.json';

function getResultsFilePath() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
return path.resolve(__dirname, RESULTS_FILE);
}

const { getInput, setFailed } = core;

async function fetchPreviousComment(octokit, repo, pr) {
const { data: commentList } = await octokit.rest.issues.listComments({
...repo,
issue_number: pr.number,
});

return commentList.find(comment => comment.body.startsWith(NODE_OVERHEAD_HEADING));
}

async function run() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));

try {
const { payload, repo } = context;
const pr = payload.pull_request;

const comparisonBranch = getInput('comparison_branch');
const githubToken = getInput('github_token');
const threshold = getInput('threshold') || 1;

if (comparisonBranch && !pr) {
throw new Error('No PR found. Only pull_request workflows are supported.');
}

const octokit = getOctokit(githubToken);
const resultsFilePath = getResultsFilePath();

// If we have no comparison branch, we just run overhead check & store the result as artifact
if (!comparisonBranch) {
return runNodeOverheadOnComparisonBranch();
}

// Else, we run overhead check for the current branch, AND fetch it for the comparison branch
let base;
let current;
let baseIsNotLatest = false;
let baseWorkflowRun;

try {
const workflowName = `${process.env.GITHUB_WORKFLOW || ''}`;
core.startGroup(`getArtifactsForBranchAndWorkflow - workflow:"${workflowName}", branch:"${comparisonBranch}"`);
const artifacts = await getArtifactsForBranchAndWorkflow(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
branch: comparisonBranch,
workflowName,
});
core.endGroup();

if (!artifacts) {
throw new Error('No artifacts found');
}

baseWorkflowRun = artifacts.workflowRun;

await downloadOtherWorkflowArtifact(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
artifactId: artifacts.artifact.id,
downloadPath: __dirname,
});

base = JSON.parse(await fs.readFile(resultsFilePath, { encoding: 'utf8' }));

if (!artifacts.isLatest) {
baseIsNotLatest = true;
core.info('Base artifact is not the latest one. This may lead to incorrect results.');
}
} catch (error) {
core.startGroup('Warning, unable to find base results');
core.error(error);
core.endGroup();
}

core.startGroup('Getting current overhead measurements');
try {
current = await getAveragedOverheadMeasurements();
} catch (error) {
core.error('Error getting current overhead measurements');
core.endGroup();
throw error;
}
core.debug(`Current overhead measurements: ${JSON.stringify(current, null, 2)}`);
core.endGroup();

const thresholdNumber = Number(threshold);

const nodeOverheadComment = await fetchPreviousComment(octokit, repo, pr);

if (nodeOverheadComment) {
core.debug('Found existing node overhead comment, updating it instead of creating a new one...');
}

const shouldComment = isNaN(thresholdNumber) || hasChanges(base, current, thresholdNumber) || nodeOverheadComment;

if (shouldComment) {
const bodyParts = [
NODE_OVERHEAD_HEADING,
'Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.',
];

if (baseIsNotLatest) {
bodyParts.push(
'⚠️ **Warning:** Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.',
);
}
try {
bodyParts.push(markdownTable(formatResults(base, current)));
} catch (error) {
core.error('Error generating markdown table');
throw error;
}

if (baseWorkflowRun) {
bodyParts.push('');
bodyParts.push(`[View base workflow run](${baseWorkflowRun.html_url})`);
}

const body = bodyParts.join('\r\n');

try {
if (!nodeOverheadComment) {
await octokit.rest.issues.createComment({
...repo,
issue_number: pr.number,
body,
});
} else {
await octokit.rest.issues.updateComment({
...repo,
comment_id: nodeOverheadComment.id,
body,
});
}
} catch (error) {
core.error(
"Error updating comment. This can happen for PR's originating from a fork without write permissions.",
);
}
} else {
core.debug('Skipping comment because there are no changes.');
}
} catch (error) {
core.error(error);
setFailed(error.message);
}
}

async function runNodeOverheadOnComparisonBranch() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const resultsFilePath = getResultsFilePath();

const artifactClient = new DefaultArtifactClient();

const result = await getAveragedOverheadMeasurements();

try {
await fs.writeFile(resultsFilePath, JSON.stringify(result), 'utf8');
} catch (error) {
core.error('Error parsing node overhead output. The output should be a json.');
throw error;
}

const globber = await glob.create(resultsFilePath, {
followSymbolicLinks: false,
});
const files = await globber.glob();

await artifactClient.uploadArtifact(ARTIFACT_NAME, files, __dirname);
}

run();

/**
* Use GitHub API to fetch artifact download url, then
* download and extract artifact to `downloadPath`
*/
async function downloadOtherWorkflowArtifact(octokit, { owner, repo, artifactId, artifactName, downloadPath }) {
const artifact = await octokit.rest.actions.downloadArtifact({
owner,
repo,
artifact_id: artifactId,
archive_format: 'zip',
});

// Make sure output path exists
try {
await io.mkdirP(downloadPath);
} catch {
// ignore errors
}

const downloadFile = path.resolve(downloadPath, `${artifactName}.zip`);

await exec('wget', [
'-nv',
'--retry-connrefused',
'--waitretry=1',
'--read-timeout=20',
'--timeout=15',
'-t',
'0',
'-O',
downloadFile,
artifact.url,
]);

await exec('unzip', ['-q', '-d', downloadPath, downloadFile], {
silent: true,
});
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,6 +200,9 @@ jobs:
changed_node:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/node') }}
changed_node_overhead_action:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry-internal/node-overhead-gh-action') }}
changed_deno:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/deno') }}
Expand DownExpand Up@@ -253,6 +256,37 @@ jobs:
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_node_overhead_check:
name: Node Overhead Check
needs: [job_get_metadata, job_build]
timeout-minutes: 15
runs-on: ubuntu-24.04
if:
(needs.job_build.outputs.changed_node == 'true' && github.event_name == 'pull_request') ||
(needs.job_build.outputs.changed_node_overhead_action == 'true' && github.event_name == 'pull_request') ||
needs.job_get_metadata.outputs.is_base_branch == 'true' || needs.job_get_metadata.outputs.is_release == 'true'
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
- name: Restore caches
uses: ./.github/actions/restore-cache
with:
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
- name: Check node overhead
uses: ./dev-packages/node-overhead-gh-action
env:
DEBUG: '1'
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_lint:
name: Lint
# Even though the linter only checks source code, not built code, it needs the built code in order check that all
Expand Down
15 changes: 15 additions & 0 deletions dev-packages/node-overhead-gh-action/.eslintrc.cjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
module.exports = {
env: {
node: true,
},
extends: ['../../.eslintrc.js'],
overrides: [
{
files: ['**/*.mjs'],
parserOptions: {
project: ['tsconfig.json'],
sourceType: 'module',
},
},
],
};
3 changes: 3 additions & 0 deletions dev-packages/node-overhead-gh-action/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
# node-overhead-gh-action

Capture the overhead of Sentry in a node app.
17 changes: 17 additions & 0 deletions dev-packages/node-overhead-gh-action/action.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
name: 'node-overhead-gh-action'
description: 'Run node overhead comparison'
inputs:
github_token:
required: true
description: 'a github access token'
comparison_branch:
required: false
default: ''
description: 'If set, compare the current branch with this branch'
threshold:
required: false
default: '3'
description: 'The percentage threshold for size changes before posting a comment'
runs:
using: 'node24'
main: 'index.mjs'
25 changes: 25 additions & 0 deletions dev-packages/node-overhead-gh-action/db/init/init.sql
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
CREATE DATABASE mydb;
USE mydb

-- SQL script to create the 'users' table and insert initial data.

-- 1. Create the 'users' table
-- This table stores basic user information.
-- 'id' is the primary key and will automatically increment for each new record.
-- 'name' stores the user's name, up to 255 characters.
-- 'age' stores the user's age as an integer.

CREATE TABLE users (
id INT PRIMARY KEY AUTO_INCREMENT,
name VARCHAR(255) NOT NULL,
age INT
);

-- 2. Insert 5 rows into the 'users' table
-- Populating the table with some sample data.

INSERT INTO users (name, age) VALUES ('Alice Johnson', 28);
INSERT INTO users (name, age) VALUES ('Bob Smith', 45);
INSERT INTO users (name, age) VALUES ('Charlie Brown', 32);
INSERT INTO users (name, age) VALUES ('Diana Prince', 25);
INSERT INTO users (name, age) VALUES ('Ethan Hunt', 41);
12 changes: 12 additions & 0 deletions dev-packages/node-overhead-gh-action/docker-compose.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
services:
db:
image: mysql:8
restart: always
container_name: node-overhead-gh-action-mysql
ports:
- '3306:3306'
environment:
MYSQL_ROOT_PASSWORD: password
volumes:
# - ./db/data:/var/lib/mysql
- ./db/init:/docker-entrypoint-initdb.d/:ro
236 changes: 236 additions & 0 deletions dev-packages/node-overhead-gh-action/index.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,236 @@
import { promises as fs } from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { DefaultArtifactClient } from '@actions/artifact';
import * as core from '@actions/core';
import { exec } from '@actions/exec';
import { context, getOctokit } from '@actions/github';
import * as glob from '@actions/glob';
import * as io from '@actions/io';
import { markdownTable } from 'markdown-table';
import { getArtifactsForBranchAndWorkflow } from './lib/getArtifactsForBranchAndWorkflow.mjs';
import { getAveragedOverheadMeasurements } from './lib/getOverheadMeasurements.mjs';
import { formatResults, hasChanges } from './lib/markdown-table-formatter.mjs';

const NODE_OVERHEAD_HEADING = '## node-overhead report 🧳';
const ARTIFACT_NAME = 'node-overhead-action';
const RESULTS_FILE = 'node-overhead-results.json';

function getResultsFilePath() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
return path.resolve(__dirname, RESULTS_FILE);
}

const { getInput, setFailed } = core;

async function fetchPreviousComment(octokit, repo, pr) {
const { data: commentList } = await octokit.rest.issues.listComments({
...repo,
issue_number: pr.number,
});

return commentList.find(comment => comment.body.startsWith(NODE_OVERHEAD_HEADING));
}

async function run() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));

try {
const { payload, repo } = context;
const pr = payload.pull_request;

const comparisonBranch = getInput('comparison_branch');
const githubToken = getInput('github_token');
const threshold = getInput('threshold') || 1;

if (comparisonBranch && !pr) {
throw new Error('No PR found. Only pull_request workflows are supported.');
}

const octokit = getOctokit(githubToken);
const resultsFilePath = getResultsFilePath();

// If we have no comparison branch, we just run overhead check & store the result as artifact
if (!comparisonBranch) {
return runNodeOverheadOnComparisonBranch();
}

// Else, we run overhead check for the current branch, AND fetch it for the comparison branch
let base;
let current;
let baseIsNotLatest = false;
let baseWorkflowRun;

try {
const workflowName = `${process.env.GITHUB_WORKFLOW || ''}`;
core.startGroup(`getArtifactsForBranchAndWorkflow - workflow:"${workflowName}", branch:"${comparisonBranch}"`);
const artifacts = await getArtifactsForBranchAndWorkflow(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
branch: comparisonBranch,
workflowName,
});
core.endGroup();

if (!artifacts) {
throw new Error('No artifacts found');
}

baseWorkflowRun = artifacts.workflowRun;

await downloadOtherWorkflowArtifact(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
artifactId: artifacts.artifact.id,
downloadPath: __dirname,
});

base = JSON.parse(await fs.readFile(resultsFilePath, { encoding: 'utf8' }));

if (!artifacts.isLatest) {
baseIsNotLatest = true;
core.info('Base artifact is not the latest one. This may lead to incorrect results.');
}
} catch (error) {
core.startGroup('Warning, unable to find base results');
core.error(error);
core.endGroup();
}

core.startGroup('Getting current overhead measurements');
try {
current = await getAveragedOverheadMeasurements();
} catch (error) {
core.error('Error getting current overhead measurements');
core.endGroup();
throw error;
}
core.debug(`Current overhead measurements: ${JSON.stringify(current, null, 2)}`);
core.endGroup();

const thresholdNumber = Number(threshold);

const nodeOverheadComment = await fetchPreviousComment(octokit, repo, pr);

if (nodeOverheadComment) {
core.debug('Found existing node overhead comment, updating it instead of creating a new one...');
}

const shouldComment = isNaN(thresholdNumber) || hasChanges(base, current, thresholdNumber) || nodeOverheadComment;

if (shouldComment) {
const bodyParts = [
NODE_OVERHEAD_HEADING,
'Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.',
];

if (baseIsNotLatest) {
bodyParts.push(
'⚠️ **Warning:** Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.',
);
}
try {
bodyParts.push(markdownTable(formatResults(base, current)));
} catch (error) {
core.error('Error generating markdown table');
throw error;
}

if (baseWorkflowRun) {
bodyParts.push('');
bodyParts.push(`[View base workflow run](${baseWorkflowRun.html_url})`);
}

const body = bodyParts.join('\r\n');

try {
if (!nodeOverheadComment) {
await octokit.rest.issues.createComment({
...repo,
issue_number: pr.number,
body,
});
} else {
await octokit.rest.issues.updateComment({
...repo,
comment_id: nodeOverheadComment.id,
body,
});
}
} catch (error) {
core.error(
"Error updating comment. This can happen for PR's originating from a fork without write permissions.",
);
}
} else {
core.debug('Skipping comment because there are no changes.');
}
} catch (error) {
core.error(error);
setFailed(error.message);
}
}

async function runNodeOverheadOnComparisonBranch() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const resultsFilePath = getResultsFilePath();

const artifactClient = new DefaultArtifactClient();

const result = await getAveragedOverheadMeasurements();

try {
await fs.writeFile(resultsFilePath, JSON.stringify(result), 'utf8');
} catch (error) {
core.error('Error parsing node overhead output. The output should be a json.');
throw error;
}

const globber = await glob.create(resultsFilePath, {
followSymbolicLinks: false,
});
const files = await globber.glob();

await artifactClient.uploadArtifact(ARTIFACT_NAME, files, __dirname);
}

run();

/**
* Use GitHub API to fetch artifact download url, then
* download and extract artifact to `downloadPath`
*/
async function downloadOtherWorkflowArtifact(octokit, { owner, repo, artifactId, artifactName, downloadPath }) {
const artifact = await octokit.rest.actions.downloadArtifact({
owner,
repo,
artifact_id: artifactId,
archive_format: 'zip',
});

// Make sure output path exists
try {
await io.mkdirP(downloadPath);
} catch {
// ignore errors
}

const downloadFile = path.resolve(downloadPath, `${artifactName}.zip`);

await exec('wget', [
'-nv',
'--retry-connrefused',
'--waitretry=1',
'--read-timeout=20',
'--timeout=15',
'-t',
'0',
'-O',
downloadFile,
artifact.url,
]);

await exec('unzip', ['-q', '-d', downloadPath, downloadFile], {
silent: true,
});
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,6 +200,9 @@ jobs:
changed_node:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/node') }}
changed_node_overhead_action:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry-internal/node-overhead-gh-action') }}
changed_deno:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry/deno') }}
Expand DownExpand Up@@ -253,6 +256,37 @@ jobs:
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_node_overhead_check:
name: Node Overhead Check
needs: [job_get_metadata, job_build]
timeout-minutes: 15
runs-on: ubuntu-24.04
if:
(needs.job_build.outputs.changed_node == 'true' && github.event_name == 'pull_request') ||
(needs.job_build.outputs.changed_node_overhead_action == 'true' && github.event_name == 'pull_request') ||
needs.job_get_metadata.outputs.is_base_branch == 'true' || needs.job_get_metadata.outputs.is_release == 'true'
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
- name: Restore caches
uses: ./.github/actions/restore-cache
with:
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
- name: Check node overhead
uses: ./dev-packages/node-overhead-gh-action
env:
DEBUG: '1'
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Only run comparison against develop if this is a PR
comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) || ''}}

job_lint:
name: Lint
# Even though the linter only checks source code, not built code, it needs the built code in order check that all
Expand Down
15 changes: 15 additions & 0 deletions dev-packages/node-overhead-gh-action/.eslintrc.cjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
module.exports = {
env: {
node: true,
},
extends: ['../../.eslintrc.js'],
overrides: [
{
files: ['**/*.mjs'],
parserOptions: {
project: ['tsconfig.json'],
sourceType: 'module',
},
},
],
};
3 changes: 3 additions & 0 deletions dev-packages/node-overhead-gh-action/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
# node-overhead-gh-action

Capture the overhead of Sentry in a node app.
17 changes: 17 additions & 0 deletions dev-packages/node-overhead-gh-action/action.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
name: 'node-overhead-gh-action'
description: 'Run node overhead comparison'
inputs:
github_token:
required: true
description: 'a github access token'
comparison_branch:
required: false
default: ''
description: 'If set, compare the current branch with this branch'
threshold:
required: false
default: '3'
description: 'The percentage threshold for size changes before posting a comment'
runs:
using: 'node24'
main: 'index.mjs'
25 changes: 25 additions & 0 deletions dev-packages/node-overhead-gh-action/db/init/init.sql
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
CREATE DATABASE mydb;
USE mydb

-- SQL script to create the 'users' table and insert initial data.

-- 1. Create the 'users' table
-- This table stores basic user information.
-- 'id' is the primary key and will automatically increment for each new record.
-- 'name' stores the user's name, up to 255 characters.
-- 'age' stores the user's age as an integer.

CREATE TABLE users (
id INT PRIMARY KEY AUTO_INCREMENT,
name VARCHAR(255) NOT NULL,
age INT
);

-- 2. Insert 5 rows into the 'users' table
-- Populating the table with some sample data.

INSERT INTO users (name, age) VALUES ('Alice Johnson', 28);
INSERT INTO users (name, age) VALUES ('Bob Smith', 45);
INSERT INTO users (name, age) VALUES ('Charlie Brown', 32);
INSERT INTO users (name, age) VALUES ('Diana Prince', 25);
INSERT INTO users (name, age) VALUES ('Ethan Hunt', 41);
12 changes: 12 additions & 0 deletions dev-packages/node-overhead-gh-action/docker-compose.yml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
services:
db:
image: mysql:8
restart: always
container_name: node-overhead-gh-action-mysql
ports:
- '3306:3306'
environment:
MYSQL_ROOT_PASSWORD: password
volumes:
# - ./db/data:/var/lib/mysql
- ./db/init:/docker-entrypoint-initdb.d/:ro
236 changes: 236 additions & 0 deletions dev-packages/node-overhead-gh-action/index.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,236 @@
import { promises as fs } from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { DefaultArtifactClient } from '@actions/artifact';
import * as core from '@actions/core';
import { exec } from '@actions/exec';
import { context, getOctokit } from '@actions/github';
import * as glob from '@actions/glob';
import * as io from '@actions/io';
import { markdownTable } from 'markdown-table';
import { getArtifactsForBranchAndWorkflow } from './lib/getArtifactsForBranchAndWorkflow.mjs';
import { getAveragedOverheadMeasurements } from './lib/getOverheadMeasurements.mjs';
import { formatResults, hasChanges } from './lib/markdown-table-formatter.mjs';

const NODE_OVERHEAD_HEADING = '## node-overhead report 🧳';
const ARTIFACT_NAME = 'node-overhead-action';
const RESULTS_FILE = 'node-overhead-results.json';

function getResultsFilePath() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
return path.resolve(__dirname, RESULTS_FILE);
}

const { getInput, setFailed } = core;

async function fetchPreviousComment(octokit, repo, pr) {
const { data: commentList } = await octokit.rest.issues.listComments({
...repo,
issue_number: pr.number,
});

return commentList.find(comment => comment.body.startsWith(NODE_OVERHEAD_HEADING));
}

async function run() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));

try {
const { payload, repo } = context;
const pr = payload.pull_request;

const comparisonBranch = getInput('comparison_branch');
const githubToken = getInput('github_token');
const threshold = getInput('threshold') || 1;

if (comparisonBranch && !pr) {
throw new Error('No PR found. Only pull_request workflows are supported.');
}

const octokit = getOctokit(githubToken);
const resultsFilePath = getResultsFilePath();

// If we have no comparison branch, we just run overhead check & store the result as artifact
if (!comparisonBranch) {
return runNodeOverheadOnComparisonBranch();
}

// Else, we run overhead check for the current branch, AND fetch it for the comparison branch
let base;
let current;
let baseIsNotLatest = false;
let baseWorkflowRun;

try {
const workflowName = `${process.env.GITHUB_WORKFLOW || ''}`;
core.startGroup(`getArtifactsForBranchAndWorkflow - workflow:"${workflowName}", branch:"${comparisonBranch}"`);
const artifacts = await getArtifactsForBranchAndWorkflow(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
branch: comparisonBranch,
workflowName,
});
core.endGroup();

if (!artifacts) {
throw new Error('No artifacts found');
}

baseWorkflowRun = artifacts.workflowRun;

await downloadOtherWorkflowArtifact(octokit, {
...repo,
artifactName: ARTIFACT_NAME,
artifactId: artifacts.artifact.id,
downloadPath: __dirname,
});

base = JSON.parse(await fs.readFile(resultsFilePath, { encoding: 'utf8' }));

if (!artifacts.isLatest) {
baseIsNotLatest = true;
core.info('Base artifact is not the latest one. This may lead to incorrect results.');
}
} catch (error) {
core.startGroup('Warning, unable to find base results');
core.error(error);
core.endGroup();
}

core.startGroup('Getting current overhead measurements');
try {
current = await getAveragedOverheadMeasurements();
} catch (error) {
core.error('Error getting current overhead measurements');
core.endGroup();
throw error;
}
core.debug(`Current overhead measurements: ${JSON.stringify(current, null, 2)}`);
core.endGroup();

const thresholdNumber = Number(threshold);

const nodeOverheadComment = await fetchPreviousComment(octokit, repo, pr);

if (nodeOverheadComment) {
core.debug('Found existing node overhead comment, updating it instead of creating a new one...');
}

const shouldComment = isNaN(thresholdNumber) || hasChanges(base, current, thresholdNumber) || nodeOverheadComment;

if (shouldComment) {
const bodyParts = [
NODE_OVERHEAD_HEADING,
'Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.',
];

if (baseIsNotLatest) {
bodyParts.push(
'⚠️ **Warning:** Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.',
);
}
try {
bodyParts.push(markdownTable(formatResults(base, current)));
} catch (error) {
core.error('Error generating markdown table');
throw error;
}

if (baseWorkflowRun) {
bodyParts.push('');
bodyParts.push(`[View base workflow run](${baseWorkflowRun.html_url})`);
}

const body = bodyParts.join('\r\n');

try {
if (!nodeOverheadComment) {
await octokit.rest.issues.createComment({
...repo,
issue_number: pr.number,
body,
});
} else {
await octokit.rest.issues.updateComment({
...repo,
comment_id: nodeOverheadComment.id,
body,
});
}
} catch (error) {
core.error(
"Error updating comment. This can happen for PR's originating from a fork without write permissions.",
);
}
} else {
core.debug('Skipping comment because there are no changes.');
}
} catch (error) {
core.error(error);
setFailed(error.message);
}
}

async function runNodeOverheadOnComparisonBranch() {
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const resultsFilePath = getResultsFilePath();

const artifactClient = new DefaultArtifactClient();

const result = await getAveragedOverheadMeasurements();

try {
await fs.writeFile(resultsFilePath, JSON.stringify(result), 'utf8');
} catch (error) {
core.error('Error parsing node overhead output. The output should be a json.');
throw error;
}

const globber = await glob.create(resultsFilePath, {
followSymbolicLinks: false,
});
const files = await globber.glob();

await artifactClient.uploadArtifact(ARTIFACT_NAME, files, __dirname);
}

run();

/**
* Use GitHub API to fetch artifact download url, then
* download and extract artifact to `downloadPath`
*/
async function downloadOtherWorkflowArtifact(octokit, { owner, repo, artifactId, artifactName, downloadPath }) {
const artifact = await octokit.rest.actions.downloadArtifact({
owner,
repo,
artifact_id: artifactId,
archive_format: 'zip',
});

// Make sure output path exists
try {
await io.mkdirP(downloadPath);
} catch {
// ignore errors
}

const downloadFile = path.resolve(downloadPath, `${artifactName}.zip`);

await exec('wget', [
'-nv',
'--retry-connrefused',
'--waitretry=1',
'--read-timeout=20',
'--timeout=15',
'-t',
'0',
'-O',
downloadFile,
artifact.url,
]);

await exec('unzip', ['-q', '-d', downloadPath, downloadFile], {
silent: true,
});
}
Loading
Loading