fix(v8/react): Add support for React Router sub-routes from handle (#17277)#17433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
onurtemizkan wants to merge 3 commits into from
Closed

fix(v8/react): Add support for React Router sub-routes from handle (#17277) #17433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91044d1
fix(react): Add support for React Router sub-routes from `handle` (#1…
onurtemizkan Aug 8, 2025
156600c
Lint
onurtemizkan Aug 20, 2025
0e2892b
Apply multiple navigations fix
onurtemizkan Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.gitignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*

/test-results/
/playwright-report/
/playwright/.cache/

!*.d.ts
2 changes: 2 additions & 0 deletions dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.npmrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
@sentry:registry=http://127.0.0.1:4873
@sentry-internal:registry=http://127.0.0.1:4873
53 changes: 53 additions & 0 deletions dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
{
"name": "react-router-7-lazy-routes",
"version": "0.1.0",
"private": true,
"dependencies": {
"@sentry/react": "latest || *",
"@types/react": "18.0.0",
"@types/react-dom": "18.0.0",
"express": "4.20.0",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-router-dom": "7.6.0",
"react-scripts": "5.0.1",
"typescript": "~5.0.0"
},
"scripts": {
"build": "react-scripts build",
"start": "serve -s build",
"test": "playwright test",
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
"test:assert": "pnpm test"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
]
},
"browserslist": {
"production": [
">0.2%",
"not dead",
"not op_mini all"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
},
"devDependencies": {
"@playwright/test": "~1.53.2",
"@sentry-internal/test-utils": "link:../../../test-utils",
"serve": "14.0.1",
"npm-run-all2": "^6.2.0"
},
"volta": {
"extends": "../../package.json"
}
}
7 changes: 7 additions & 0 deletions dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/playwright.config.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
import { getPlaywrightConfig } from '@sentry-internal/test-utils';

const config = getPlaywrightConfig({
startCommand: `pnpm start`,
});

export default config;
24 changes: 24 additions & 0 deletions dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/public/index.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />
<meta name="description" content="Web site created using create-react-app" />
<title>React App</title>
</head>
<body>
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
<!--
This HTML file is a template.
If you open it directly in the browser, you will see an empty page.

You can add webfonts, meta tags, or analytics to this file.
The build step will place the bundled scripts into the <body> tag.

To begin the development, run `npm start` or `yarn start`.
To create a production bundle, use `npm run build` or `yarn build`.
-->
</body>
</html>
5 changes: 5 additions & 0 deletions dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/globals.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
interface Window {
recordedTransactions?: string[];
capturedExceptionId?: string;
sentryReplayId?: string;
}
79 changes: 79 additions & 0 deletions dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import * as Sentry from '@sentry/react';
import React from 'react';
import ReactDOM from 'react-dom/client';
import {
Navigate,
PatchRoutesOnNavigationFunction,
RouterProvider,
createBrowserRouter,
createRoutesFromChildren,
matchRoutes,
useLocation,
useNavigationType,
} from 'react-router-dom';
import Index from './pages/Index';

Sentry.init({
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.REACT_APP_E2E_TEST_DSN,
integrations: [
Sentry.reactRouterV7BrowserTracingIntegration({
useEffect: React.useEffect,
useLocation,
useNavigationType,
createRoutesFromChildren,
matchRoutes,
trackFetchStreamPerformance: true,
enableAsyncRouteHandlers: true,
}),
],
// We recommend adjusting this value in production, or using tracesSampler
// for finer control
tracesSampleRate: 1.0,
release: 'e2e-test',

tunnel: 'http://localhost:3031',
});

const sentryCreateBrowserRouter = Sentry.wrapCreateBrowserRouterV7(createBrowserRouter);

const router = sentryCreateBrowserRouter(
[
{
path: '/',
element: <Index />,
},
{
path: '/lazy',
handle: {
lazyChildren: () => import('./pages/InnerLazyRoutes').then(module => module.someMoreNestedRoutes),
},
},
{
path: '/another-lazy',
handle: {
lazyChildren: () => import('./pages/AnotherLazyRoutes').then(module => module.anotherNestedRoutes),
},
},
{
path: '/static',
element: <>Hello World</>,
},
{
path: '*',
element: <Navigate to="/" replace />,
},
],
{
async patchRoutesOnNavigation({ matches, patch }: Parameters<PatchRoutesOnNavigationFunction>[0]) {
const leafRoute = matches[matches.length - 1]?.route;
if (leafRoute?.id && leafRoute?.handle?.lazyChildren) {
const children = await leafRoute.handle.lazyChildren();
patch(leafRoute.id, children);
}
},
},
);

const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);
root.render(<RouterProvider router={router} />);
42 changes: 42 additions & 0 deletions ...es/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/AnotherLazyRoutes.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { Link } from 'react-router-dom';

export const anotherNestedRoutes = [
{
path: 'sub',
children: [
{
index: true,
element: (
<div id="another-lazy-route">
Another Lazy Route
<Link to="/lazy/inner/999/888/777" id="navigate-to-inner">
Navigate to Inner Lazy Route
</Link>
</div>
),
},
{
path: ':id',
children: [
{
index: true,
element: <div id="another-lazy-route-with-id">Another Lazy Route with ID</div>,
},
{
path: ':subId',
element: (
<div id="another-lazy-route-deep">
Another Deep Lazy Route
<Link to="/lazy/inner/111/222/333" id="navigate-to-inner-from-deep">
Navigate to Inner from Deep
</Link>
</div>
),
},
],
},
],
},
];

export default null as unknown as void;
21 changes: 21 additions & 0 deletions dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/Index.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
import { Link } from 'react-router-dom';

const Index = () => {
return (
<>
<Link to="/lazy/inner/123/456/789" id="navigation">
navigate
</Link>
<br />
<Link to="/another-lazy/sub" id="navigation-to-another">
Navigate to Another Lazy Route
</Link>
<br />
<Link to="/another-lazy/sub/555/666" id="navigation-to-another-deep">
Navigate to Another Deep Lazy Route
</Link>
</>
);
};

export default Index;
43 changes: 43 additions & 0 deletions ...ages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/InnerLazyRoutes.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
import { Link } from 'react-router-dom';

export const someMoreNestedRoutes = [
{
path: 'inner',
children: [
{
index: true,
element: <>Level 1</>,
},
{
path: ':id',
children: [
{
index: true,
element: <>Level 1 ID</>,
},
{
path: ':anotherId',
children: [
{
index: true,
element: <>Level 1 ID Another ID</>,
},
{
path: ':someAnotherId',
element: (
<div id="innermost-lazy-route">
Rendered
<br />
<Link to="/another-lazy/sub/888/999" id="navigate-to-another-from-inner">
Navigate to Another Lazy Route
</Link>
</div>
),
},
],
},
],
},
],
},
];
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/react-app-env.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
/// <reference types="react-scripts" />
6 changes: 6 additions & 0 deletions dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/start-event-proxy.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
port: 3031,
proxyServerName: 'react-router-7-lazy-routes',
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(v8/react): Add support for React Router sub-routes from handle (#17277)#17433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


fix(v8/react): Add support for React Router sub-routes from handle (#17277)
#17433
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
91044d1

fix(react): Add support for React Router sub-routes from `handle` (#1…


onurtemizkan Aug 8, 2025
156600c

Lint


onurtemizkan Aug 20, 2025
0e2892b

Apply multiple navigations fix


onurtemizkan Sep 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


29 changes: 29 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*

/test-results/
/playwright-report/
/playwright/.cache/

!*.d.ts

2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.npmrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
@sentry:registry=http://127.0.0.1:4873
@sentry-internal:registry=http://127.0.0.1:4873

53 changes: 53 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
{
 "name": "react-router-7-lazy-routes",
 "version": "0.1.0",
 "private": true,
 "dependencies": {
 "@sentry/react": "latest || *",
 "@types/react": "18.0.0",
 "@types/react-dom": "18.0.0",
 "express": "4.20.0",
 "react": "18.2.0",
 "react-dom": "18.2.0",
 "react-router-dom": "7.6.0",
 "react-scripts": "5.0.1",
 "typescript": "~5.0.0"
 },
 "scripts": {
 "build": "react-scripts build",
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
 "extends": [
 "react-app",
 "react-app/jest"
 ]
 },
 "browserslist": {
 "production": [
 ">0.2%",
 "not dead",
 "not op_mini all"
 ],
 "development": [
 "last 1 chrome version",
 "last 1 firefox version",
 "last 1 safari version"
 ]
 },
 "devDependencies": {
 "@playwright/test": "~1.53.2",
 "@sentry-internal/test-utils": "link:../../../test-utils",
 "serve": "14.0.1",
 "npm-run-all2": "^6.2.0"
 },
 "volta": {
 "extends": "../../package.json"
 }
}

7 changes: 7 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/playwright.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
import { getPlaywrightConfig } from '@sentry-internal/test-utils';

const config = getPlaywrightConfig({
 startCommand: `pnpm start`,
});

export default config;

24 changes: 24 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/public/index.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
<!DOCTYPE html>
<html lang="en">
 <head>
 <meta charset="utf-8" />
 <meta name="viewport" content="width=device-width, initial-scale=1" />
 <meta name="theme-color" content="#000000" />
 <meta name="description" content="Web site created using create-react-app" />
 <title>React App</title>
 </head>
 <body>
 <noscript>You need to enable JavaScript to run this app.</noscript>
 <div id="root"></div>
 <!--
 This HTML file is a template.
 If you open it directly in the browser, you will see an empty page.

 You can add webfonts, meta tags, or analytics to this file.
 The build step will place the bundled scripts into the <body> tag.

 To begin the development, run `npm start` or `yarn start`.
 To create a production bundle, use `npm run build` or `yarn build`.
 -->
 </body>
</html>

5 changes: 5 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/globals.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
interface Window {
 recordedTransactions?: string[];
 capturedExceptionId?: string;
 sentryReplayId?: string;
}

79 changes: 79 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import * as Sentry from '@sentry/react';
import React from 'react';
import ReactDOM from 'react-dom/client';
import {
 Navigate,
 PatchRoutesOnNavigationFunction,
 RouterProvider,
 createBrowserRouter,
 createRoutesFromChildren,
 matchRoutes,
 useLocation,
 useNavigationType,
} from 'react-router-dom';
import Index from './pages/Index';

Sentry.init({
 environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
 Sentry.reactRouterV7BrowserTracingIntegration({
 useEffect: React.useEffect,
 useLocation,
 useNavigationType,
 createRoutesFromChildren,
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 }),
 ],
 // We recommend adjusting this value in production, or using tracesSampler
 // for finer control
 tracesSampleRate: 1.0,
 release: 'e2e-test',

 tunnel: 'http://localhost:3031',
});

const sentryCreateBrowserRouter = Sentry.wrapCreateBrowserRouterV7(createBrowserRouter);

const router = sentryCreateBrowserRouter(
 [
 {
 path: '/',
 element: <Index />,
 },
 {
 path: '/lazy',
 handle: {
 lazyChildren: () => import('./pages/InnerLazyRoutes').then(module => module.someMoreNestedRoutes),
 },
 },
 {
 path: '/another-lazy',
 handle: {
 lazyChildren: () => import('./pages/AnotherLazyRoutes').then(module => module.anotherNestedRoutes),
 },
 },
 {
 path: '/static',
 element: <>Hello World</>,
 },
 {
 path: '*',
 element: <Navigate to="/" replace />,
 },
 ],
 {
 async patchRoutesOnNavigation({ matches, patch }: Parameters<PatchRoutesOnNavigationFunction>[0]) {
 const leafRoute = matches[matches.length - 1]?.route;
 if (leafRoute?.id && leafRoute?.handle?.lazyChildren) {
 const children = await leafRoute.handle.lazyChildren();
 patch(leafRoute.id, children);
 }
 },
 },
);

const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);
root.render(<RouterProvider router={router} />);

42 changes: 42 additions & 0 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/AnotherLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { Link } from 'react-router-dom';

export const anotherNestedRoutes = [
 {
 path: 'sub',
 children: [
 {
 index: true,
 element: (
 <div id="another-lazy-route">
 Another Lazy Route
 <Link to="/lazy/inner/999/888/777" id="navigate-to-inner">
 Navigate to Inner Lazy Route
 </Link>
 </div>
 ),
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <div id="another-lazy-route-with-id">Another Lazy Route with ID</div>,
 },
 {
 path: ':subId',
 element: (
 <div id="another-lazy-route-deep">
 Another Deep Lazy Route
 <Link to="/lazy/inner/111/222/333" id="navigate-to-inner-from-deep">
 Navigate to Inner from Deep
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
];

export default null as unknown as void;

21 changes: 21 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/Index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
import { Link } from 'react-router-dom';

const Index = () => {
 return (
 <>
 <Link to="/lazy/inner/123/456/789" id="navigation">
 navigate
 </Link>
 <br />
 <Link to="/another-lazy/sub" id="navigation-to-another">
 Navigate to Another Lazy Route
 </Link>
 <br />
 <Link to="/another-lazy/sub/555/666" id="navigation-to-another-deep">
 Navigate to Another Deep Lazy Route
 </Link>
 </>
 );
};

export default Index;

43 changes: 43 additions & 0 deletions
...ages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/InnerLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
import { Link } from 'react-router-dom';

export const someMoreNestedRoutes = [
 {
 path: 'inner',
 children: [
 {
 index: true,
 element: <>Level 1</>,
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <>Level 1 ID</>,
 },
 {
 path: ':anotherId',
 children: [
 {
 index: true,
 element: <>Level 1 ID Another ID</>,
 },
 {
 path: ':someAnotherId',
 element: (
 <div id="innermost-lazy-route">
 Rendered
 <br />
 <Link to="/another-lazy/sub/888/999" id="navigate-to-another-from-inner">
 Navigate to Another Lazy Route
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
 ],
 },
];

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/react-app-env.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
/// <reference types="react-scripts" />

6 changes: 6 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/start-event-proxy.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
 port: 3031,
 proxyServerName: 'react-router-7-lazy-routes',
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(v8/react): Add support for React Router sub-routes from handle (#17277)#17433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


fix(v8/react): Add support for React Router sub-routes from handle (#17277)
#17433
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
91044d1

fix(react): Add support for React Router sub-routes from `handle` (#1…


onurtemizkan Aug 8, 2025
156600c

Lint


onurtemizkan Aug 20, 2025
0e2892b

Apply multiple navigations fix


onurtemizkan Sep 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


29 changes: 29 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*

/test-results/
/playwright-report/
/playwright/.cache/

!*.d.ts

2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.npmrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
@sentry:registry=http://127.0.0.1:4873
@sentry-internal:registry=http://127.0.0.1:4873

53 changes: 53 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
{
 "name": "react-router-7-lazy-routes",
 "version": "0.1.0",
 "private": true,
 "dependencies": {
 "@sentry/react": "latest || *",
 "@types/react": "18.0.0",
 "@types/react-dom": "18.0.0",
 "express": "4.20.0",
 "react": "18.2.0",
 "react-dom": "18.2.0",
 "react-router-dom": "7.6.0",
 "react-scripts": "5.0.1",
 "typescript": "~5.0.0"
 },
 "scripts": {
 "build": "react-scripts build",
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
 "extends": [
 "react-app",
 "react-app/jest"
 ]
 },
 "browserslist": {
 "production": [
 ">0.2%",
 "not dead",
 "not op_mini all"
 ],
 "development": [
 "last 1 chrome version",
 "last 1 firefox version",
 "last 1 safari version"
 ]
 },
 "devDependencies": {
 "@playwright/test": "~1.53.2",
 "@sentry-internal/test-utils": "link:../../../test-utils",
 "serve": "14.0.1",
 "npm-run-all2": "^6.2.0"
 },
 "volta": {
 "extends": "../../package.json"
 }
}

7 changes: 7 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/playwright.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
import { getPlaywrightConfig } from '@sentry-internal/test-utils';

const config = getPlaywrightConfig({
 startCommand: `pnpm start`,
});

export default config;

24 changes: 24 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/public/index.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
<!DOCTYPE html>
<html lang="en">
 <head>
 <meta charset="utf-8" />
 <meta name="viewport" content="width=device-width, initial-scale=1" />
 <meta name="theme-color" content="#000000" />
 <meta name="description" content="Web site created using create-react-app" />
 <title>React App</title>
 </head>
 <body>
 <noscript>You need to enable JavaScript to run this app.</noscript>
 <div id="root"></div>
 <!--
 This HTML file is a template.
 If you open it directly in the browser, you will see an empty page.

 You can add webfonts, meta tags, or analytics to this file.
 The build step will place the bundled scripts into the <body> tag.

 To begin the development, run `npm start` or `yarn start`.
 To create a production bundle, use `npm run build` or `yarn build`.
 -->
 </body>
</html>

5 changes: 5 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/globals.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
interface Window {
 recordedTransactions?: string[];
 capturedExceptionId?: string;
 sentryReplayId?: string;
}

79 changes: 79 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import * as Sentry from '@sentry/react';
import React from 'react';
import ReactDOM from 'react-dom/client';
import {
 Navigate,
 PatchRoutesOnNavigationFunction,
 RouterProvider,
 createBrowserRouter,
 createRoutesFromChildren,
 matchRoutes,
 useLocation,
 useNavigationType,
} from 'react-router-dom';
import Index from './pages/Index';

Sentry.init({
 environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
 Sentry.reactRouterV7BrowserTracingIntegration({
 useEffect: React.useEffect,
 useLocation,
 useNavigationType,
 createRoutesFromChildren,
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 }),
 ],
 // We recommend adjusting this value in production, or using tracesSampler
 // for finer control
 tracesSampleRate: 1.0,
 release: 'e2e-test',

 tunnel: 'http://localhost:3031',
});

const sentryCreateBrowserRouter = Sentry.wrapCreateBrowserRouterV7(createBrowserRouter);

const router = sentryCreateBrowserRouter(
 [
 {
 path: '/',
 element: <Index />,
 },
 {
 path: '/lazy',
 handle: {
 lazyChildren: () => import('./pages/InnerLazyRoutes').then(module => module.someMoreNestedRoutes),
 },
 },
 {
 path: '/another-lazy',
 handle: {
 lazyChildren: () => import('./pages/AnotherLazyRoutes').then(module => module.anotherNestedRoutes),
 },
 },
 {
 path: '/static',
 element: <>Hello World</>,
 },
 {
 path: '*',
 element: <Navigate to="/" replace />,
 },
 ],
 {
 async patchRoutesOnNavigation({ matches, patch }: Parameters<PatchRoutesOnNavigationFunction>[0]) {
 const leafRoute = matches[matches.length - 1]?.route;
 if (leafRoute?.id && leafRoute?.handle?.lazyChildren) {
 const children = await leafRoute.handle.lazyChildren();
 patch(leafRoute.id, children);
 }
 },
 },
);

const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);
root.render(<RouterProvider router={router} />);

42 changes: 42 additions & 0 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/AnotherLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { Link } from 'react-router-dom';

export const anotherNestedRoutes = [
 {
 path: 'sub',
 children: [
 {
 index: true,
 element: (
 <div id="another-lazy-route">
 Another Lazy Route
 <Link to="/lazy/inner/999/888/777" id="navigate-to-inner">
 Navigate to Inner Lazy Route
 </Link>
 </div>
 ),
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <div id="another-lazy-route-with-id">Another Lazy Route with ID</div>,
 },
 {
 path: ':subId',
 element: (
 <div id="another-lazy-route-deep">
 Another Deep Lazy Route
 <Link to="/lazy/inner/111/222/333" id="navigate-to-inner-from-deep">
 Navigate to Inner from Deep
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
];

export default null as unknown as void;

21 changes: 21 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/Index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
import { Link } from 'react-router-dom';

const Index = () => {
 return (
 <>
 <Link to="/lazy/inner/123/456/789" id="navigation">
 navigate
 </Link>
 <br />
 <Link to="/another-lazy/sub" id="navigation-to-another">
 Navigate to Another Lazy Route
 </Link>
 <br />
 <Link to="/another-lazy/sub/555/666" id="navigation-to-another-deep">
 Navigate to Another Deep Lazy Route
 </Link>
 </>
 );
};

export default Index;

43 changes: 43 additions & 0 deletions
...ages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/InnerLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
import { Link } from 'react-router-dom';

export const someMoreNestedRoutes = [
 {
 path: 'inner',
 children: [
 {
 index: true,
 element: <>Level 1</>,
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <>Level 1 ID</>,
 },
 {
 path: ':anotherId',
 children: [
 {
 index: true,
 element: <>Level 1 ID Another ID</>,
 },
 {
 path: ':someAnotherId',
 element: (
 <div id="innermost-lazy-route">
 Rendered
 <br />
 <Link to="/another-lazy/sub/888/999" id="navigate-to-another-from-inner">
 Navigate to Another Lazy Route
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
 ],
 },
];

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/react-app-env.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
/// <reference types="react-scripts" />

6 changes: 6 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/start-event-proxy.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
 port: 3031,
 proxyServerName: 'react-router-7-lazy-routes',
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(v8/react): Add support for React Router sub-routes from handle (#17277)#17433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


fix(v8/react): Add support for React Router sub-routes from handle (#17277)
#17433
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
91044d1

fix(react): Add support for React Router sub-routes from `handle` (#1…


onurtemizkan Aug 8, 2025
156600c

Lint


onurtemizkan Aug 20, 2025
0e2892b

Apply multiple navigations fix


onurtemizkan Sep 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


29 changes: 29 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*

/test-results/
/playwright-report/
/playwright/.cache/

!*.d.ts

2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.npmrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
@sentry:registry=http://127.0.0.1:4873
@sentry-internal:registry=http://127.0.0.1:4873

53 changes: 53 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
{
 "name": "react-router-7-lazy-routes",
 "version": "0.1.0",
 "private": true,
 "dependencies": {
 "@sentry/react": "latest || *",
 "@types/react": "18.0.0",
 "@types/react-dom": "18.0.0",
 "express": "4.20.0",
 "react": "18.2.0",
 "react-dom": "18.2.0",
 "react-router-dom": "7.6.0",
 "react-scripts": "5.0.1",
 "typescript": "~5.0.0"
 },
 "scripts": {
 "build": "react-scripts build",
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
 "extends": [
 "react-app",
 "react-app/jest"
 ]
 },
 "browserslist": {
 "production": [
 ">0.2%",
 "not dead",
 "not op_mini all"
 ],
 "development": [
 "last 1 chrome version",
 "last 1 firefox version",
 "last 1 safari version"
 ]
 },
 "devDependencies": {
 "@playwright/test": "~1.53.2",
 "@sentry-internal/test-utils": "link:../../../test-utils",
 "serve": "14.0.1",
 "npm-run-all2": "^6.2.0"
 },
 "volta": {
 "extends": "../../package.json"
 }
}

7 changes: 7 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/playwright.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
import { getPlaywrightConfig } from '@sentry-internal/test-utils';

const config = getPlaywrightConfig({
 startCommand: `pnpm start`,
});

export default config;

24 changes: 24 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/public/index.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
<!DOCTYPE html>
<html lang="en">
 <head>
 <meta charset="utf-8" />
 <meta name="viewport" content="width=device-width, initial-scale=1" />
 <meta name="theme-color" content="#000000" />
 <meta name="description" content="Web site created using create-react-app" />
 <title>React App</title>
 </head>
 <body>
 <noscript>You need to enable JavaScript to run this app.</noscript>
 <div id="root"></div>
 <!--
 This HTML file is a template.
 If you open it directly in the browser, you will see an empty page.

 You can add webfonts, meta tags, or analytics to this file.
 The build step will place the bundled scripts into the <body> tag.

 To begin the development, run `npm start` or `yarn start`.
 To create a production bundle, use `npm run build` or `yarn build`.
 -->
 </body>
</html>

5 changes: 5 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/globals.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
interface Window {
 recordedTransactions?: string[];
 capturedExceptionId?: string;
 sentryReplayId?: string;
}

79 changes: 79 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import * as Sentry from '@sentry/react';
import React from 'react';
import ReactDOM from 'react-dom/client';
import {
 Navigate,
 PatchRoutesOnNavigationFunction,
 RouterProvider,
 createBrowserRouter,
 createRoutesFromChildren,
 matchRoutes,
 useLocation,
 useNavigationType,
} from 'react-router-dom';
import Index from './pages/Index';

Sentry.init({
 environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
 Sentry.reactRouterV7BrowserTracingIntegration({
 useEffect: React.useEffect,
 useLocation,
 useNavigationType,
 createRoutesFromChildren,
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 }),
 ],
 // We recommend adjusting this value in production, or using tracesSampler
 // for finer control
 tracesSampleRate: 1.0,
 release: 'e2e-test',

 tunnel: 'http://localhost:3031',
});

const sentryCreateBrowserRouter = Sentry.wrapCreateBrowserRouterV7(createBrowserRouter);

const router = sentryCreateBrowserRouter(
 [
 {
 path: '/',
 element: <Index />,
 },
 {
 path: '/lazy',
 handle: {
 lazyChildren: () => import('./pages/InnerLazyRoutes').then(module => module.someMoreNestedRoutes),
 },
 },
 {
 path: '/another-lazy',
 handle: {
 lazyChildren: () => import('./pages/AnotherLazyRoutes').then(module => module.anotherNestedRoutes),
 },
 },
 {
 path: '/static',
 element: <>Hello World</>,
 },
 {
 path: '*',
 element: <Navigate to="/" replace />,
 },
 ],
 {
 async patchRoutesOnNavigation({ matches, patch }: Parameters<PatchRoutesOnNavigationFunction>[0]) {
 const leafRoute = matches[matches.length - 1]?.route;
 if (leafRoute?.id && leafRoute?.handle?.lazyChildren) {
 const children = await leafRoute.handle.lazyChildren();
 patch(leafRoute.id, children);
 }
 },
 },
);

const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);
root.render(<RouterProvider router={router} />);

42 changes: 42 additions & 0 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/AnotherLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { Link } from 'react-router-dom';

export const anotherNestedRoutes = [
 {
 path: 'sub',
 children: [
 {
 index: true,
 element: (
 <div id="another-lazy-route">
 Another Lazy Route
 <Link to="/lazy/inner/999/888/777" id="navigate-to-inner">
 Navigate to Inner Lazy Route
 </Link>
 </div>
 ),
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <div id="another-lazy-route-with-id">Another Lazy Route with ID</div>,
 },
 {
 path: ':subId',
 element: (
 <div id="another-lazy-route-deep">
 Another Deep Lazy Route
 <Link to="/lazy/inner/111/222/333" id="navigate-to-inner-from-deep">
 Navigate to Inner from Deep
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
];

export default null as unknown as void;

21 changes: 21 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/Index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
import { Link } from 'react-router-dom';

const Index = () => {
 return (
 <>
 <Link to="/lazy/inner/123/456/789" id="navigation">
 navigate
 </Link>
 <br />
 <Link to="/another-lazy/sub" id="navigation-to-another">
 Navigate to Another Lazy Route
 </Link>
 <br />
 <Link to="/another-lazy/sub/555/666" id="navigation-to-another-deep">
 Navigate to Another Deep Lazy Route
 </Link>
 </>
 );
};

export default Index;

43 changes: 43 additions & 0 deletions
...ages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/InnerLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
import { Link } from 'react-router-dom';

export const someMoreNestedRoutes = [
 {
 path: 'inner',
 children: [
 {
 index: true,
 element: <>Level 1</>,
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <>Level 1 ID</>,
 },
 {
 path: ':anotherId',
 children: [
 {
 index: true,
 element: <>Level 1 ID Another ID</>,
 },
 {
 path: ':someAnotherId',
 element: (
 <div id="innermost-lazy-route">
 Rendered
 <br />
 <Link to="/another-lazy/sub/888/999" id="navigate-to-another-from-inner">
 Navigate to Another Lazy Route
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
 ],
 },
];

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/react-app-env.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
/// <reference types="react-scripts" />

6 changes: 6 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/start-event-proxy.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
 port: 3031,
 proxyServerName: 'react-router-7-lazy-routes',
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(v8/react): Add support for React Router sub-routes from handle (#17277)#17433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


fix(v8/react): Add support for React Router sub-routes from handle (#17277)
#17433
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
91044d1

fix(react): Add support for React Router sub-routes from `handle` (#1…


onurtemizkan Aug 8, 2025
156600c

Lint


onurtemizkan Aug 20, 2025
0e2892b

Apply multiple navigations fix


onurtemizkan Sep 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


29 changes: 29 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*

/test-results/
/playwright-report/
/playwright/.cache/

!*.d.ts

2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.npmrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
@sentry:registry=http://127.0.0.1:4873
@sentry-internal:registry=http://127.0.0.1:4873

53 changes: 53 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
{
 "name": "react-router-7-lazy-routes",
 "version": "0.1.0",
 "private": true,
 "dependencies": {
 "@sentry/react": "latest || *",
 "@types/react": "18.0.0",
 "@types/react-dom": "18.0.0",
 "express": "4.20.0",
 "react": "18.2.0",
 "react-dom": "18.2.0",
 "react-router-dom": "7.6.0",
 "react-scripts": "5.0.1",
 "typescript": "~5.0.0"
 },
 "scripts": {
 "build": "react-scripts build",
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
 "extends": [
 "react-app",
 "react-app/jest"
 ]
 },
 "browserslist": {
 "production": [
 ">0.2%",
 "not dead",
 "not op_mini all"
 ],
 "development": [
 "last 1 chrome version",
 "last 1 firefox version",
 "last 1 safari version"
 ]
 },
 "devDependencies": {
 "@playwright/test": "~1.53.2",
 "@sentry-internal/test-utils": "link:../../../test-utils",
 "serve": "14.0.1",
 "npm-run-all2": "^6.2.0"
 },
 "volta": {
 "extends": "../../package.json"
 }
}

7 changes: 7 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/playwright.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
import { getPlaywrightConfig } from '@sentry-internal/test-utils';

const config = getPlaywrightConfig({
 startCommand: `pnpm start`,
});

export default config;

24 changes: 24 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/public/index.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
<!DOCTYPE html>
<html lang="en">
 <head>
 <meta charset="utf-8" />
 <meta name="viewport" content="width=device-width, initial-scale=1" />
 <meta name="theme-color" content="#000000" />
 <meta name="description" content="Web site created using create-react-app" />
 <title>React App</title>
 </head>
 <body>
 <noscript>You need to enable JavaScript to run this app.</noscript>
 <div id="root"></div>
 <!--
 This HTML file is a template.
 If you open it directly in the browser, you will see an empty page.

 You can add webfonts, meta tags, or analytics to this file.
 The build step will place the bundled scripts into the <body> tag.

 To begin the development, run `npm start` or `yarn start`.
 To create a production bundle, use `npm run build` or `yarn build`.
 -->
 </body>
</html>

5 changes: 5 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/globals.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
interface Window {
 recordedTransactions?: string[];
 capturedExceptionId?: string;
 sentryReplayId?: string;
}

79 changes: 79 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import * as Sentry from '@sentry/react';
import React from 'react';
import ReactDOM from 'react-dom/client';
import {
 Navigate,
 PatchRoutesOnNavigationFunction,
 RouterProvider,
 createBrowserRouter,
 createRoutesFromChildren,
 matchRoutes,
 useLocation,
 useNavigationType,
} from 'react-router-dom';
import Index from './pages/Index';

Sentry.init({
 environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
 Sentry.reactRouterV7BrowserTracingIntegration({
 useEffect: React.useEffect,
 useLocation,
 useNavigationType,
 createRoutesFromChildren,
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 }),
 ],
 // We recommend adjusting this value in production, or using tracesSampler
 // for finer control
 tracesSampleRate: 1.0,
 release: 'e2e-test',

 tunnel: 'http://localhost:3031',
});

const sentryCreateBrowserRouter = Sentry.wrapCreateBrowserRouterV7(createBrowserRouter);

const router = sentryCreateBrowserRouter(
 [
 {
 path: '/',
 element: <Index />,
 },
 {
 path: '/lazy',
 handle: {
 lazyChildren: () => import('./pages/InnerLazyRoutes').then(module => module.someMoreNestedRoutes),
 },
 },
 {
 path: '/another-lazy',
 handle: {
 lazyChildren: () => import('./pages/AnotherLazyRoutes').then(module => module.anotherNestedRoutes),
 },
 },
 {
 path: '/static',
 element: <>Hello World</>,
 },
 {
 path: '*',
 element: <Navigate to="/" replace />,
 },
 ],
 {
 async patchRoutesOnNavigation({ matches, patch }: Parameters<PatchRoutesOnNavigationFunction>[0]) {
 const leafRoute = matches[matches.length - 1]?.route;
 if (leafRoute?.id && leafRoute?.handle?.lazyChildren) {
 const children = await leafRoute.handle.lazyChildren();
 patch(leafRoute.id, children);
 }
 },
 },
);

const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);
root.render(<RouterProvider router={router} />);

42 changes: 42 additions & 0 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/AnotherLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { Link } from 'react-router-dom';

export const anotherNestedRoutes = [
 {
 path: 'sub',
 children: [
 {
 index: true,
 element: (
 <div id="another-lazy-route">
 Another Lazy Route
 <Link to="/lazy/inner/999/888/777" id="navigate-to-inner">
 Navigate to Inner Lazy Route
 </Link>
 </div>
 ),
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <div id="another-lazy-route-with-id">Another Lazy Route with ID</div>,
 },
 {
 path: ':subId',
 element: (
 <div id="another-lazy-route-deep">
 Another Deep Lazy Route
 <Link to="/lazy/inner/111/222/333" id="navigate-to-inner-from-deep">
 Navigate to Inner from Deep
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
];

export default null as unknown as void;

21 changes: 21 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/Index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
import { Link } from 'react-router-dom';

const Index = () => {
 return (
 <>
 <Link to="/lazy/inner/123/456/789" id="navigation">
 navigate
 </Link>
 <br />
 <Link to="/another-lazy/sub" id="navigation-to-another">
 Navigate to Another Lazy Route
 </Link>
 <br />
 <Link to="/another-lazy/sub/555/666" id="navigation-to-another-deep">
 Navigate to Another Deep Lazy Route
 </Link>
 </>
 );
};

export default Index;

43 changes: 43 additions & 0 deletions
...ages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/InnerLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
import { Link } from 'react-router-dom';

export const someMoreNestedRoutes = [
 {
 path: 'inner',
 children: [
 {
 index: true,
 element: <>Level 1</>,
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <>Level 1 ID</>,
 },
 {
 path: ':anotherId',
 children: [
 {
 index: true,
 element: <>Level 1 ID Another ID</>,
 },
 {
 path: ':someAnotherId',
 element: (
 <div id="innermost-lazy-route">
 Rendered
 <br />
 <Link to="/another-lazy/sub/888/999" id="navigate-to-another-from-inner">
 Navigate to Another Lazy Route
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
 ],
 },
];

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/react-app-env.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
/// <reference types="react-scripts" />

6 changes: 6 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/start-event-proxy.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
 port: 3031,
 proxyServerName: 'react-router-7-lazy-routes',
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(v8/react): Add support for React Router sub-routes from handle (#17277)#17433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


fix(v8/react): Add support for React Router sub-routes from handle (#17277)
#17433
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
91044d1

fix(react): Add support for React Router sub-routes from `handle` (#1…


onurtemizkan Aug 8, 2025
156600c

Lint


onurtemizkan Aug 20, 2025
0e2892b

Apply multiple navigations fix


onurtemizkan Sep 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


29 changes: 29 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*

/test-results/
/playwright-report/
/playwright/.cache/

!*.d.ts

2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.npmrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
@sentry:registry=http://127.0.0.1:4873
@sentry-internal:registry=http://127.0.0.1:4873

53 changes: 53 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
{
 "name": "react-router-7-lazy-routes",
 "version": "0.1.0",
 "private": true,
 "dependencies": {
 "@sentry/react": "latest || *",
 "@types/react": "18.0.0",
 "@types/react-dom": "18.0.0",
 "express": "4.20.0",
 "react": "18.2.0",
 "react-dom": "18.2.0",
 "react-router-dom": "7.6.0",
 "react-scripts": "5.0.1",
 "typescript": "~5.0.0"
 },
 "scripts": {
 "build": "react-scripts build",
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
 "extends": [
 "react-app",
 "react-app/jest"
 ]
 },
 "browserslist": {
 "production": [
 ">0.2%",
 "not dead",
 "not op_mini all"
 ],
 "development": [
 "last 1 chrome version",
 "last 1 firefox version",
 "last 1 safari version"
 ]
 },
 "devDependencies": {
 "@playwright/test": "~1.53.2",
 "@sentry-internal/test-utils": "link:../../../test-utils",
 "serve": "14.0.1",
 "npm-run-all2": "^6.2.0"
 },
 "volta": {
 "extends": "../../package.json"
 }
}

7 changes: 7 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/playwright.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
import { getPlaywrightConfig } from '@sentry-internal/test-utils';

const config = getPlaywrightConfig({
 startCommand: `pnpm start`,
});

export default config;

24 changes: 24 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/public/index.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
<!DOCTYPE html>
<html lang="en">
 <head>
 <meta charset="utf-8" />
 <meta name="viewport" content="width=device-width, initial-scale=1" />
 <meta name="theme-color" content="#000000" />
 <meta name="description" content="Web site created using create-react-app" />
 <title>React App</title>
 </head>
 <body>
 <noscript>You need to enable JavaScript to run this app.</noscript>
 <div id="root"></div>
 <!--
 This HTML file is a template.
 If you open it directly in the browser, you will see an empty page.

 You can add webfonts, meta tags, or analytics to this file.
 The build step will place the bundled scripts into the <body> tag.

 To begin the development, run `npm start` or `yarn start`.
 To create a production bundle, use `npm run build` or `yarn build`.
 -->
 </body>
</html>

5 changes: 5 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/globals.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
interface Window {
 recordedTransactions?: string[];
 capturedExceptionId?: string;
 sentryReplayId?: string;
}

79 changes: 79 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import * as Sentry from '@sentry/react';
import React from 'react';
import ReactDOM from 'react-dom/client';
import {
 Navigate,
 PatchRoutesOnNavigationFunction,
 RouterProvider,
 createBrowserRouter,
 createRoutesFromChildren,
 matchRoutes,
 useLocation,
 useNavigationType,
} from 'react-router-dom';
import Index from './pages/Index';

Sentry.init({
 environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
 Sentry.reactRouterV7BrowserTracingIntegration({
 useEffect: React.useEffect,
 useLocation,
 useNavigationType,
 createRoutesFromChildren,
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 }),
 ],
 // We recommend adjusting this value in production, or using tracesSampler
 // for finer control
 tracesSampleRate: 1.0,
 release: 'e2e-test',

 tunnel: 'http://localhost:3031',
});

const sentryCreateBrowserRouter = Sentry.wrapCreateBrowserRouterV7(createBrowserRouter);

const router = sentryCreateBrowserRouter(
 [
 {
 path: '/',
 element: <Index />,
 },
 {
 path: '/lazy',
 handle: {
 lazyChildren: () => import('./pages/InnerLazyRoutes').then(module => module.someMoreNestedRoutes),
 },
 },
 {
 path: '/another-lazy',
 handle: {
 lazyChildren: () => import('./pages/AnotherLazyRoutes').then(module => module.anotherNestedRoutes),
 },
 },
 {
 path: '/static',
 element: <>Hello World</>,
 },
 {
 path: '*',
 element: <Navigate to="/" replace />,
 },
 ],
 {
 async patchRoutesOnNavigation({ matches, patch }: Parameters<PatchRoutesOnNavigationFunction>[0]) {
 const leafRoute = matches[matches.length - 1]?.route;
 if (leafRoute?.id && leafRoute?.handle?.lazyChildren) {
 const children = await leafRoute.handle.lazyChildren();
 patch(leafRoute.id, children);
 }
 },
 },
);

const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);
root.render(<RouterProvider router={router} />);

42 changes: 42 additions & 0 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/AnotherLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { Link } from 'react-router-dom';

export const anotherNestedRoutes = [
 {
 path: 'sub',
 children: [
 {
 index: true,
 element: (
 <div id="another-lazy-route">
 Another Lazy Route
 <Link to="/lazy/inner/999/888/777" id="navigate-to-inner">
 Navigate to Inner Lazy Route
 </Link>
 </div>
 ),
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <div id="another-lazy-route-with-id">Another Lazy Route with ID</div>,
 },
 {
 path: ':subId',
 element: (
 <div id="another-lazy-route-deep">
 Another Deep Lazy Route
 <Link to="/lazy/inner/111/222/333" id="navigate-to-inner-from-deep">
 Navigate to Inner from Deep
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
];

export default null as unknown as void;

21 changes: 21 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/Index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
import { Link } from 'react-router-dom';

const Index = () => {
 return (
 <>
 <Link to="/lazy/inner/123/456/789" id="navigation">
 navigate
 </Link>
 <br />
 <Link to="/another-lazy/sub" id="navigation-to-another">
 Navigate to Another Lazy Route
 </Link>
 <br />
 <Link to="/another-lazy/sub/555/666" id="navigation-to-another-deep">
 Navigate to Another Deep Lazy Route
 </Link>
 </>
 );
};

export default Index;

43 changes: 43 additions & 0 deletions
...ages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/InnerLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
import { Link } from 'react-router-dom';

export const someMoreNestedRoutes = [
 {
 path: 'inner',
 children: [
 {
 index: true,
 element: <>Level 1</>,
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <>Level 1 ID</>,
 },
 {
 path: ':anotherId',
 children: [
 {
 index: true,
 element: <>Level 1 ID Another ID</>,
 },
 {
 path: ':someAnotherId',
 element: (
 <div id="innermost-lazy-route">
 Rendered
 <br />
 <Link to="/another-lazy/sub/888/999" id="navigate-to-another-from-inner">
 Navigate to Another Lazy Route
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
 ],
 },
];

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/react-app-env.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
/// <reference types="react-scripts" />

6 changes: 6 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/start-event-proxy.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
 port: 3031,
 proxyServerName: 'react-router-7-lazy-routes',
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(v8/react): Add support for React Router sub-routes from handle (#17277)#17433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


fix(v8/react): Add support for React Router sub-routes from handle (#17277)
#17433
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
91044d1

fix(react): Add support for React Router sub-routes from `handle` (#1…


onurtemizkan Aug 8, 2025
156600c

Lint


onurtemizkan Aug 20, 2025
0e2892b

Apply multiple navigations fix


onurtemizkan Sep 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


29 changes: 29 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*

/test-results/
/playwright-report/
/playwright/.cache/

!*.d.ts

2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.npmrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
@sentry:registry=http://127.0.0.1:4873
@sentry-internal:registry=http://127.0.0.1:4873

53 changes: 53 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
{
 "name": "react-router-7-lazy-routes",
 "version": "0.1.0",
 "private": true,
 "dependencies": {
 "@sentry/react": "latest || *",
 "@types/react": "18.0.0",
 "@types/react-dom": "18.0.0",
 "express": "4.20.0",
 "react": "18.2.0",
 "react-dom": "18.2.0",
 "react-router-dom": "7.6.0",
 "react-scripts": "5.0.1",
 "typescript": "~5.0.0"
 },
 "scripts": {
 "build": "react-scripts build",
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
 "extends": [
 "react-app",
 "react-app/jest"
 ]
 },
 "browserslist": {
 "production": [
 ">0.2%",
 "not dead",
 "not op_mini all"
 ],
 "development": [
 "last 1 chrome version",
 "last 1 firefox version",
 "last 1 safari version"
 ]
 },
 "devDependencies": {
 "@playwright/test": "~1.53.2",
 "@sentry-internal/test-utils": "link:../../../test-utils",
 "serve": "14.0.1",
 "npm-run-all2": "^6.2.0"
 },
 "volta": {
 "extends": "../../package.json"
 }
}

7 changes: 7 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/playwright.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
import { getPlaywrightConfig } from '@sentry-internal/test-utils';

const config = getPlaywrightConfig({
 startCommand: `pnpm start`,
});

export default config;

24 changes: 24 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/public/index.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
<!DOCTYPE html>
<html lang="en">
 <head>
 <meta charset="utf-8" />
 <meta name="viewport" content="width=device-width, initial-scale=1" />
 <meta name="theme-color" content="#000000" />
 <meta name="description" content="Web site created using create-react-app" />
 <title>React App</title>
 </head>
 <body>
 <noscript>You need to enable JavaScript to run this app.</noscript>
 <div id="root"></div>
 <!--
 This HTML file is a template.
 If you open it directly in the browser, you will see an empty page.

 You can add webfonts, meta tags, or analytics to this file.
 The build step will place the bundled scripts into the <body> tag.

 To begin the development, run `npm start` or `yarn start`.
 To create a production bundle, use `npm run build` or `yarn build`.
 -->
 </body>
</html>

5 changes: 5 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/globals.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
interface Window {
 recordedTransactions?: string[];
 capturedExceptionId?: string;
 sentryReplayId?: string;
}

79 changes: 79 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import * as Sentry from '@sentry/react';
import React from 'react';
import ReactDOM from 'react-dom/client';
import {
 Navigate,
 PatchRoutesOnNavigationFunction,
 RouterProvider,
 createBrowserRouter,
 createRoutesFromChildren,
 matchRoutes,
 useLocation,
 useNavigationType,
} from 'react-router-dom';
import Index from './pages/Index';

Sentry.init({
 environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
 Sentry.reactRouterV7BrowserTracingIntegration({
 useEffect: React.useEffect,
 useLocation,
 useNavigationType,
 createRoutesFromChildren,
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 }),
 ],
 // We recommend adjusting this value in production, or using tracesSampler
 // for finer control
 tracesSampleRate: 1.0,
 release: 'e2e-test',

 tunnel: 'http://localhost:3031',
});

const sentryCreateBrowserRouter = Sentry.wrapCreateBrowserRouterV7(createBrowserRouter);

const router = sentryCreateBrowserRouter(
 [
 {
 path: '/',
 element: <Index />,
 },
 {
 path: '/lazy',
 handle: {
 lazyChildren: () => import('./pages/InnerLazyRoutes').then(module => module.someMoreNestedRoutes),
 },
 },
 {
 path: '/another-lazy',
 handle: {
 lazyChildren: () => import('./pages/AnotherLazyRoutes').then(module => module.anotherNestedRoutes),
 },
 },
 {
 path: '/static',
 element: <>Hello World</>,
 },
 {
 path: '*',
 element: <Navigate to="/" replace />,
 },
 ],
 {
 async patchRoutesOnNavigation({ matches, patch }: Parameters<PatchRoutesOnNavigationFunction>[0]) {
 const leafRoute = matches[matches.length - 1]?.route;
 if (leafRoute?.id && leafRoute?.handle?.lazyChildren) {
 const children = await leafRoute.handle.lazyChildren();
 patch(leafRoute.id, children);
 }
 },
 },
);

const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);
root.render(<RouterProvider router={router} />);

42 changes: 42 additions & 0 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/AnotherLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { Link } from 'react-router-dom';

export const anotherNestedRoutes = [
 {
 path: 'sub',
 children: [
 {
 index: true,
 element: (
 <div id="another-lazy-route">
 Another Lazy Route
 <Link to="/lazy/inner/999/888/777" id="navigate-to-inner">
 Navigate to Inner Lazy Route
 </Link>
 </div>
 ),
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <div id="another-lazy-route-with-id">Another Lazy Route with ID</div>,
 },
 {
 path: ':subId',
 element: (
 <div id="another-lazy-route-deep">
 Another Deep Lazy Route
 <Link to="/lazy/inner/111/222/333" id="navigate-to-inner-from-deep">
 Navigate to Inner from Deep
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
];

export default null as unknown as void;

21 changes: 21 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/Index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
import { Link } from 'react-router-dom';

const Index = () => {
 return (
 <>
 <Link to="/lazy/inner/123/456/789" id="navigation">
 navigate
 </Link>
 <br />
 <Link to="/another-lazy/sub" id="navigation-to-another">
 Navigate to Another Lazy Route
 </Link>
 <br />
 <Link to="/another-lazy/sub/555/666" id="navigation-to-another-deep">
 Navigate to Another Deep Lazy Route
 </Link>
 </>
 );
};

export default Index;

43 changes: 43 additions & 0 deletions
...ages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/InnerLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
import { Link } from 'react-router-dom';

export const someMoreNestedRoutes = [
 {
 path: 'inner',
 children: [
 {
 index: true,
 element: <>Level 1</>,
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <>Level 1 ID</>,
 },
 {
 path: ':anotherId',
 children: [
 {
 index: true,
 element: <>Level 1 ID Another ID</>,
 },
 {
 path: ':someAnotherId',
 element: (
 <div id="innermost-lazy-route">
 Rendered
 <br />
 <Link to="/another-lazy/sub/888/999" id="navigate-to-another-from-inner">
 Navigate to Another Lazy Route
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
 ],
 },
];

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/react-app-env.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
/// <reference types="react-scripts" />

6 changes: 6 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/start-event-proxy.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
 port: 3031,
 proxyServerName: 'react-router-7-lazy-routes',
});
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(v8/react): Add support for React Router sub-routes from handle (#17277)#17433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


fix(v8/react): Add support for React Router sub-routes from handle (#17277)
#17433
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
91044d1

fix(react): Add support for React Router sub-routes from `handle` (#1…


onurtemizkan Aug 8, 2025
156600c

Lint


onurtemizkan Aug 20, 2025
0e2892b

Apply multiple navigations fix


onurtemizkan Sep 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


29 changes: 29 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*

/test-results/
/playwright-report/
/playwright/.cache/

!*.d.ts

2 changes: 2 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/.npmrc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
@sentry:registry=http://127.0.0.1:4873
@sentry-internal:registry=http://127.0.0.1:4873

53 changes: 53 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
{
 "name": "react-router-7-lazy-routes",
 "version": "0.1.0",
 "private": true,
 "dependencies": {
 "@sentry/react": "latest || *",
 "@types/react": "18.0.0",
 "@types/react-dom": "18.0.0",
 "express": "4.20.0",
 "react": "18.2.0",
 "react-dom": "18.2.0",
 "react-router-dom": "7.6.0",
 "react-scripts": "5.0.1",
 "typescript": "~5.0.0"
 },
 "scripts": {
 "build": "react-scripts build",
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
 "extends": [
 "react-app",
 "react-app/jest"
 ]
 },
 "browserslist": {
 "production": [
 ">0.2%",
 "not dead",
 "not op_mini all"
 ],
 "development": [
 "last 1 chrome version",
 "last 1 firefox version",
 "last 1 safari version"
 ]
 },
 "devDependencies": {
 "@playwright/test": "~1.53.2",
 "@sentry-internal/test-utils": "link:../../../test-utils",
 "serve": "14.0.1",
 "npm-run-all2": "^6.2.0"
 },
 "volta": {
 "extends": "../../package.json"
 }
}

7 changes: 7 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/playwright.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
import { getPlaywrightConfig } from '@sentry-internal/test-utils';

const config = getPlaywrightConfig({
 startCommand: `pnpm start`,
});

export default config;

24 changes: 24 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/public/index.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
<!DOCTYPE html>
<html lang="en">
 <head>
 <meta charset="utf-8" />
 <meta name="viewport" content="width=device-width, initial-scale=1" />
 <meta name="theme-color" content="#000000" />
 <meta name="description" content="Web site created using create-react-app" />
 <title>React App</title>
 </head>
 <body>
 <noscript>You need to enable JavaScript to run this app.</noscript>
 <div id="root"></div>
 <!--
 This HTML file is a template.
 If you open it directly in the browser, you will see an empty page.

 You can add webfonts, meta tags, or analytics to this file.
 The build step will place the bundled scripts into the <body> tag.

 To begin the development, run `npm start` or `yarn start`.
 To create a production bundle, use `npm run build` or `yarn build`.
 -->
 </body>
</html>

5 changes: 5 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/globals.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
interface Window {
 recordedTransactions?: string[];
 capturedExceptionId?: string;
 sentryReplayId?: string;
}

79 changes: 79 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
import * as Sentry from '@sentry/react';
import React from 'react';
import ReactDOM from 'react-dom/client';
import {
 Navigate,
 PatchRoutesOnNavigationFunction,
 RouterProvider,
 createBrowserRouter,
 createRoutesFromChildren,
 matchRoutes,
 useLocation,
 useNavigationType,
} from 'react-router-dom';
import Index from './pages/Index';

Sentry.init({
 environment: 'qa', // dynamic sampling bias to keep transactions
 dsn: process.env.REACT_APP_E2E_TEST_DSN,
 integrations: [
 Sentry.reactRouterV7BrowserTracingIntegration({
 useEffect: React.useEffect,
 useLocation,
 useNavigationType,
 createRoutesFromChildren,
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 }),
 ],
 // We recommend adjusting this value in production, or using tracesSampler
 // for finer control
 tracesSampleRate: 1.0,
 release: 'e2e-test',

 tunnel: 'http://localhost:3031',
});

const sentryCreateBrowserRouter = Sentry.wrapCreateBrowserRouterV7(createBrowserRouter);

const router = sentryCreateBrowserRouter(
 [
 {
 path: '/',
 element: <Index />,
 },
 {
 path: '/lazy',
 handle: {
 lazyChildren: () => import('./pages/InnerLazyRoutes').then(module => module.someMoreNestedRoutes),
 },
 },
 {
 path: '/another-lazy',
 handle: {
 lazyChildren: () => import('./pages/AnotherLazyRoutes').then(module => module.anotherNestedRoutes),
 },
 },
 {
 path: '/static',
 element: <>Hello World</>,
 },
 {
 path: '*',
 element: <Navigate to="/" replace />,
 },
 ],
 {
 async patchRoutesOnNavigation({ matches, patch }: Parameters<PatchRoutesOnNavigationFunction>[0]) {
 const leafRoute = matches[matches.length - 1]?.route;
 if (leafRoute?.id && leafRoute?.handle?.lazyChildren) {
 const children = await leafRoute.handle.lazyChildren();
 patch(leafRoute.id, children);
 }
 },
 },
);

const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);
root.render(<RouterProvider router={router} />);

42 changes: 42 additions & 0 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/AnotherLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { Link } from 'react-router-dom';

export const anotherNestedRoutes = [
 {
 path: 'sub',
 children: [
 {
 index: true,
 element: (
 <div id="another-lazy-route">
 Another Lazy Route
 <Link to="/lazy/inner/999/888/777" id="navigate-to-inner">
 Navigate to Inner Lazy Route
 </Link>
 </div>
 ),
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <div id="another-lazy-route-with-id">Another Lazy Route with ID</div>,
 },
 {
 path: ':subId',
 element: (
 <div id="another-lazy-route-deep">
 Another Deep Lazy Route
 <Link to="/lazy/inner/111/222/333" id="navigate-to-inner-from-deep">
 Navigate to Inner from Deep
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
];

export default null as unknown as void;

21 changes: 21 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/Index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
import { Link } from 'react-router-dom';

const Index = () => {
 return (
 <>
 <Link to="/lazy/inner/123/456/789" id="navigation">
 navigate
 </Link>
 <br />
 <Link to="/another-lazy/sub" id="navigation-to-another">
 Navigate to Another Lazy Route
 </Link>
 <br />
 <Link to="/another-lazy/sub/555/666" id="navigation-to-another-deep">
 Navigate to Another Deep Lazy Route
 </Link>
 </>
 );
};

export default Index;

43 changes: 43 additions & 0 deletions
...ages/e2e-tests/test-applications/react-router-7-lazy-routes/src/pages/InnerLazyRoutes.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
import { Link } from 'react-router-dom';

export const someMoreNestedRoutes = [
 {
 path: 'inner',
 children: [
 {
 index: true,
 element: <>Level 1</>,
 },
 {
 path: ':id',
 children: [
 {
 index: true,
 element: <>Level 1 ID</>,
 },
 {
 path: ':anotherId',
 children: [
 {
 index: true,
 element: <>Level 1 ID Another ID</>,
 },
 {
 path: ':someAnotherId',
 element: (
 <div id="innermost-lazy-route">
 Rendered
 <br />
 <Link to="/another-lazy/sub/888/999" id="navigate-to-another-from-inner">
 Navigate to Another Lazy Route
 </Link>
 </div>
 ),
 },
 ],
 },
 ],
 },
 ],
 },
];

1 change: 1 addition & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/react-app-env.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
/// <reference types="react-scripts" />

6 changes: 6 additions & 0 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/start-event-proxy.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
 port: 3031,
 proxyServerName: 'react-router-7-lazy-routes',
});
Loading
Loading