Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'waits for Sentry.reportPageLoaded() to be called when `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'reportPageLoaded',
});

// We wait for 2.5 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2);
expect(spanDurationSeconds).toBeLessThan(3);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, finalTimeout: 3000 })],
tracesSampleRate: 1,
debug: true,
});

// not calling Sentry.reportPageLoaded() on purpose!
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'final timeout cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'finalTimeout',
});

// We wait for 3 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2.5);
expect(spanDurationSeconds).toBeLessThan(3.5);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, instrumentNavigation: false })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.startBrowserTracingNavigationSpan(Sentry.getClient(), { name: 'custom_navigation' });
}, 1000);

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'starting a navigation span cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'cancelled',
});

// ending span after 1s but adding a margin of 0.5s to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeLessThan(1.5);
},
);
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.feedback.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { getFeedback, sendFeedback } from '@sentry-internal/feedback';

export { feedbackAsyncIntegration as feedbackAsyncIntegration, feedbackAsyncIntegration as feedbackIntegration };
Expand Down
3 changes: 3 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,9 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { feedbackIntegrationShim as feedbackAsyncIntegration, feedbackIntegrationShim as feedbackIntegration };

export { replayIntegration, getReplay } from '@sentry-internal/replay';
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export {
feedbackIntegrationShim as feedbackAsyncIntegration,
feedbackIntegrationShim as feedbackIntegration,
Expand Down
1 change: 1 addition & 0 deletions packages/browser/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';
export { reportPageLoaded } from './tracing/reportPageLoaded';
export type { RequestInstrumentationOptions } from './tracing/request';
export {
registerSpanErrorInstrumentation,
Expand Down
50 changes: 45 additions & 5 deletions packages/browser/src/tracing/browserTracingIntegration.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -250,6 +250,23 @@ export interface BrowserTracingOptions {
*/
consistentTraceSampling: boolean;

/**
* If set to `true`, the pageload span will not end itself automatically, unless it
* runs until the {@link BrowserTracingOptions.finalTimeout} (30 seconds by default) is reached.
*
* Set this option to `true`, if you want full control over the pageload span duration.
* You can use `Sentry.reportPageLoaded()` to manually end the pageload span whenever convenient.
* Be aware that you have to ensure that this is always called, regardless of the chosen route
* or path in the application.
*
* @default `false`. By default, the pageload span will end itself automatically, based on
* the {@link BrowserTracingOptions.finalTimeout}, {@link BrowserTracingOptions.idleTimeout}
* and {@link BrowserTracingOptions.childSpanTimeout}. This is more convenient to use but means
* that the pageload duration can be arbitrary and might not be fully representative of a perceived
* page load time.
*/
enableReportPageLoaded: boolean;

/**
* _experiments allows the user to send options to define how this integration works.
*
Expand DownExpand Up@@ -297,6 +314,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
detectRedirects: true,
linkPreviousTrace: 'in-memory',
consistentTraceSampling: false,
enableReportPageLoaded: false,
_experiments: {},
...defaultRequestInstrumentationOptions,
};
Expand All@@ -310,7 +328,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
*
* We explicitly export the proper type here, as this has to be extended in some cases.
*/
export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptions> = {}) => {
export const browserTracingIntegration = ((options: Partial<BrowserTracingOptions> = {}) => {
const latestRoute: RouteInfo = {
name: undefined,
source: undefined,
Expand DownExpand Up@@ -345,18 +363,21 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
detectRedirects,
linkPreviousTrace,
consistentTraceSampling,
enableReportPageLoaded,
onRequestSpanStart,
} = {
...DEFAULT_BROWSER_TRACING_OPTIONS,
..._options,
...options,
};

let _collectWebVitals: undefined | (() => void);
let lastInteractionTimestamp: number | undefined;

let _pageloadSpan: Span | undefined;

/** Create routing idle transaction. */
function _createRouteSpan(client: Client, startSpanOptions: StartSpanOptions, makeActive = true): void {
const isPageloadTransaction = startSpanOptions.op === 'pageload';
const isPageloadSpan = startSpanOptions.op === 'pageload';

const initialSpanName = startSpanOptions.name;
const finalStartSpanOptions: StartSpanOptions = beforeStartSpan
Expand DownExpand Up@@ -390,7 +411,7 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
finalTimeout,
childSpanTimeout,
// should wait for finish signal if it's a pageload transaction
disableAutoFinish: isPageloadTransaction,
disableAutoFinish: isPageloadSpan,
beforeSpanEnd: span => {
// This will generally always be defined here, because it is set in `setup()` of the integration
// but technically, it is optional, so we guard here to be extra safe
Expand All@@ -415,9 +436,19 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
sampled: spanIsSampled(idleSpan),
dsc: getDynamicSamplingContextFromSpan(span),
});

if (isPageloadSpan) {
// clean up the stored pageload span on the intergration.
_pageloadSpan = undefined;
}
},
trimIdleSpanEndTimestamp: !enableReportPageLoaded,
});

if (isPageloadSpan && enableReportPageLoaded) {
_pageloadSpan = idleSpan;
}

setActiveIdleSpan(client, idleSpan);

function emitFinish(): void {
Expand All@@ -426,7 +457,8 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
}
}

if (isPageloadTransaction && optionalWindowDocument) {
// Enable auto finish of the pageload span if users are not explicitly ending it
if (isPageloadSpan && !enableReportPageLoaded && optionalWindowDocument) {
optionalWindowDocument.addEventListener('readystatechange', () => {
emitFinish();
});
Expand DownExpand Up@@ -573,7 +605,15 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
...startSpanOptions,
});
});

client.on('endPageloadSpan', () => {
if (enableReportPageLoaded && _pageloadSpan) {
_pageloadSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON, 'reportPageLoaded');
_pageloadSpan.end();
}
});
},

afterAllSetup(client) {
let startingUrl: string | undefined = getLocationHref();

Expand Down
14 changes: 14 additions & 0 deletions packages/browser/src/tracing/reportPageLoaded.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
import type { Client } from '@sentry/core';
import { getClient } from '@sentry/core';

/**
* Manually report the end of the page load, resulting in the SDK ending the pageload span.
* This only works if {@link BrowserTracingOptions.enableReportPageLoaded} is set to `true`.
* Otherwise, the pageload span will end itself based on the {@link BrowserTracingOptions.finalTimeout},
* {@link BrowserTracingOptions.idleTimeout} and {@link BrowserTracingOptions.childSpanTimeout}.
*
* @param client - The client to use. If not provided, the global client will be used.
*/
export function reportPageLoaded(client: Client | undefined = getClient()): void {
client?.emit('endPageloadSpan');
}
24 changes: 24 additions & 0 deletions packages/browser/test/tracing/reportPageLoaded.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { describe, expect, it, vi } from 'vitest';
import { BrowserClient, setCurrentClient } from '../../src';
import { reportPageLoaded } from '../../src/tracing/reportPageLoaded';
import { getDefaultBrowserClientOptions } from '../helper/browser-client-options';

describe('reportPageLoaded', () => {
it('emits the endPageloadSpan event on the global client if no client is passed', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
setCurrentClient(client);

const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded();

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});

it('emits the endPageloadSpan event on the passed client', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded(client);

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});
});
11 changes: 11 additions & 0 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -606,6 +606,12 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
) => void,
): () => void;

/**
* A hook for the browser tracing integrations to trigger the end of a page load span.
* @returns {() => void} A function that, when executed, removes the registered callback.
*/
public on(hook: 'endPageloadSpan', callback: () => void): () => void;

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to go with the client hooks approach instead of exposing a method on browserTracingIntegration because in contrast to all other integrations, we don't hide the specific implementation of browserTracingIntegration behind defineIntegration. So adding a method would indeed be public API (we also can't introduce defineIntegration now as that would be a breaking change).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is a nice enough API for this anyhow, I like it!


/**
* A hook for the browser tracing integrations to trigger after the pageload span was started.
* @returns {() => void} A function that, when executed, removes the registered callback.
Expand DownExpand Up@@ -800,6 +806,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
traceOptions?: { sentryTrace?: string | undefined; baggage?: string | undefined },
): void;

/**
* Emit a hook event for browser tracing integrations to trigger the end of a page load span.
*/
public emit(hook: 'endPageloadSpan'): void;

/**
* Emit a hook event for browser tracing integrations to trigger aafter the pageload span was started.
*/
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'waits for Sentry.reportPageLoaded() to be called when `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'reportPageLoaded',
});

// We wait for 2.5 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2);
expect(spanDurationSeconds).toBeLessThan(3);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, finalTimeout: 3000 })],
tracesSampleRate: 1,
debug: true,
});

// not calling Sentry.reportPageLoaded() on purpose!
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'final timeout cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'finalTimeout',
});

// We wait for 3 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2.5);
expect(spanDurationSeconds).toBeLessThan(3.5);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, instrumentNavigation: false })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.startBrowserTracingNavigationSpan(Sentry.getClient(), { name: 'custom_navigation' });
}, 1000);

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'starting a navigation span cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'cancelled',
});

// ending span after 1s but adding a margin of 0.5s to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeLessThan(1.5);
},
);
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.feedback.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { getFeedback, sendFeedback } from '@sentry-internal/feedback';

export { feedbackAsyncIntegration as feedbackAsyncIntegration, feedbackAsyncIntegration as feedbackIntegration };
Expand Down
3 changes: 3 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,9 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { feedbackIntegrationShim as feedbackAsyncIntegration, feedbackIntegrationShim as feedbackIntegration };

export { replayIntegration, getReplay } from '@sentry-internal/replay';
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export {
feedbackIntegrationShim as feedbackAsyncIntegration,
feedbackIntegrationShim as feedbackIntegration,
Expand Down
1 change: 1 addition & 0 deletions packages/browser/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';
export { reportPageLoaded } from './tracing/reportPageLoaded';
export type { RequestInstrumentationOptions } from './tracing/request';
export {
registerSpanErrorInstrumentation,
Expand Down
50 changes: 45 additions & 5 deletions packages/browser/src/tracing/browserTracingIntegration.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -250,6 +250,23 @@ export interface BrowserTracingOptions {
*/
consistentTraceSampling: boolean;

/**
* If set to `true`, the pageload span will not end itself automatically, unless it
* runs until the {@link BrowserTracingOptions.finalTimeout} (30 seconds by default) is reached.
*
* Set this option to `true`, if you want full control over the pageload span duration.
* You can use `Sentry.reportPageLoaded()` to manually end the pageload span whenever convenient.
* Be aware that you have to ensure that this is always called, regardless of the chosen route
* or path in the application.
*
* @default `false`. By default, the pageload span will end itself automatically, based on
* the {@link BrowserTracingOptions.finalTimeout}, {@link BrowserTracingOptions.idleTimeout}
* and {@link BrowserTracingOptions.childSpanTimeout}. This is more convenient to use but means
* that the pageload duration can be arbitrary and might not be fully representative of a perceived
* page load time.
*/
enableReportPageLoaded: boolean;

/**
* _experiments allows the user to send options to define how this integration works.
*
Expand DownExpand Up@@ -297,6 +314,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
detectRedirects: true,
linkPreviousTrace: 'in-memory',
consistentTraceSampling: false,
enableReportPageLoaded: false,
_experiments: {},
...defaultRequestInstrumentationOptions,
};
Expand All@@ -310,7 +328,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
*
* We explicitly export the proper type here, as this has to be extended in some cases.
*/
export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptions> = {}) => {
export const browserTracingIntegration = ((options: Partial<BrowserTracingOptions> = {}) => {
const latestRoute: RouteInfo = {
name: undefined,
source: undefined,
Expand DownExpand Up@@ -345,18 +363,21 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
detectRedirects,
linkPreviousTrace,
consistentTraceSampling,
enableReportPageLoaded,
onRequestSpanStart,
} = {
...DEFAULT_BROWSER_TRACING_OPTIONS,
..._options,
...options,
};

let _collectWebVitals: undefined | (() => void);
let lastInteractionTimestamp: number | undefined;

let _pageloadSpan: Span | undefined;

/** Create routing idle transaction. */
function _createRouteSpan(client: Client, startSpanOptions: StartSpanOptions, makeActive = true): void {
const isPageloadTransaction = startSpanOptions.op === 'pageload';
const isPageloadSpan = startSpanOptions.op === 'pageload';

const initialSpanName = startSpanOptions.name;
const finalStartSpanOptions: StartSpanOptions = beforeStartSpan
Expand DownExpand Up@@ -390,7 +411,7 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
finalTimeout,
childSpanTimeout,
// should wait for finish signal if it's a pageload transaction
disableAutoFinish: isPageloadTransaction,
disableAutoFinish: isPageloadSpan,
beforeSpanEnd: span => {
// This will generally always be defined here, because it is set in `setup()` of the integration
// but technically, it is optional, so we guard here to be extra safe
Expand All@@ -415,9 +436,19 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
sampled: spanIsSampled(idleSpan),
dsc: getDynamicSamplingContextFromSpan(span),
});

if (isPageloadSpan) {
// clean up the stored pageload span on the intergration.
_pageloadSpan = undefined;
}
},
trimIdleSpanEndTimestamp: !enableReportPageLoaded,
});

if (isPageloadSpan && enableReportPageLoaded) {
_pageloadSpan = idleSpan;
}

setActiveIdleSpan(client, idleSpan);

function emitFinish(): void {
Expand All@@ -426,7 +457,8 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
}
}

if (isPageloadTransaction && optionalWindowDocument) {
// Enable auto finish of the pageload span if users are not explicitly ending it
if (isPageloadSpan && !enableReportPageLoaded && optionalWindowDocument) {
optionalWindowDocument.addEventListener('readystatechange', () => {
emitFinish();
});
Expand DownExpand Up@@ -573,7 +605,15 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
...startSpanOptions,
});
});

client.on('endPageloadSpan', () => {
if (enableReportPageLoaded && _pageloadSpan) {
_pageloadSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON, 'reportPageLoaded');
_pageloadSpan.end();
}
});
},

afterAllSetup(client) {
let startingUrl: string | undefined = getLocationHref();

Expand Down
14 changes: 14 additions & 0 deletions packages/browser/src/tracing/reportPageLoaded.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
import type { Client } from '@sentry/core';
import { getClient } from '@sentry/core';

/**
* Manually report the end of the page load, resulting in the SDK ending the pageload span.
* This only works if {@link BrowserTracingOptions.enableReportPageLoaded} is set to `true`.
* Otherwise, the pageload span will end itself based on the {@link BrowserTracingOptions.finalTimeout},
* {@link BrowserTracingOptions.idleTimeout} and {@link BrowserTracingOptions.childSpanTimeout}.
*
* @param client - The client to use. If not provided, the global client will be used.
*/
export function reportPageLoaded(client: Client | undefined = getClient()): void {
client?.emit('endPageloadSpan');
}
24 changes: 24 additions & 0 deletions packages/browser/test/tracing/reportPageLoaded.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { describe, expect, it, vi } from 'vitest';
import { BrowserClient, setCurrentClient } from '../../src';
import { reportPageLoaded } from '../../src/tracing/reportPageLoaded';
import { getDefaultBrowserClientOptions } from '../helper/browser-client-options';

describe('reportPageLoaded', () => {
it('emits the endPageloadSpan event on the global client if no client is passed', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
setCurrentClient(client);

const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded();

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});

it('emits the endPageloadSpan event on the passed client', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded(client);

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});
});
11 changes: 11 additions & 0 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -606,6 +606,12 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
) => void,
): () => void;

/**
* A hook for the browser tracing integrations to trigger the end of a page load span.
* @returns {() => void} A function that, when executed, removes the registered callback.
*/
public on(hook: 'endPageloadSpan', callback: () => void): () => void;

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to go with the client hooks approach instead of exposing a method on browserTracingIntegration because in contrast to all other integrations, we don't hide the specific implementation of browserTracingIntegration behind defineIntegration. So adding a method would indeed be public API (we also can't introduce defineIntegration now as that would be a breaking change).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is a nice enough API for this anyhow, I like it!


/**
* A hook for the browser tracing integrations to trigger after the pageload span was started.
* @returns {() => void} A function that, when executed, removes the registered callback.
Expand DownExpand Up@@ -800,6 +806,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
traceOptions?: { sentryTrace?: string | undefined; baggage?: string | undefined },
): void;

/**
* Emit a hook event for browser tracing integrations to trigger the end of a page load span.
*/
public emit(hook: 'endPageloadSpan'): void;

/**
* Emit a hook event for browser tracing integrations to trigger aafter the pageload span was started.
*/
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'waits for Sentry.reportPageLoaded() to be called when `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'reportPageLoaded',
});

// We wait for 2.5 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2);
expect(spanDurationSeconds).toBeLessThan(3);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, finalTimeout: 3000 })],
tracesSampleRate: 1,
debug: true,
});

// not calling Sentry.reportPageLoaded() on purpose!
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'final timeout cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'finalTimeout',
});

// We wait for 3 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2.5);
expect(spanDurationSeconds).toBeLessThan(3.5);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, instrumentNavigation: false })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.startBrowserTracingNavigationSpan(Sentry.getClient(), { name: 'custom_navigation' });
}, 1000);

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'starting a navigation span cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'cancelled',
});

// ending span after 1s but adding a margin of 0.5s to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeLessThan(1.5);
},
);
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.feedback.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { getFeedback, sendFeedback } from '@sentry-internal/feedback';

export { feedbackAsyncIntegration as feedbackAsyncIntegration, feedbackAsyncIntegration as feedbackIntegration };
Expand Down
3 changes: 3 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,9 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { feedbackIntegrationShim as feedbackAsyncIntegration, feedbackIntegrationShim as feedbackIntegration };

export { replayIntegration, getReplay } from '@sentry-internal/replay';
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export {
feedbackIntegrationShim as feedbackAsyncIntegration,
feedbackIntegrationShim as feedbackIntegration,
Expand Down
1 change: 1 addition & 0 deletions packages/browser/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';
export { reportPageLoaded } from './tracing/reportPageLoaded';
export type { RequestInstrumentationOptions } from './tracing/request';
export {
registerSpanErrorInstrumentation,
Expand Down
50 changes: 45 additions & 5 deletions packages/browser/src/tracing/browserTracingIntegration.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -250,6 +250,23 @@ export interface BrowserTracingOptions {
*/
consistentTraceSampling: boolean;

/**
* If set to `true`, the pageload span will not end itself automatically, unless it
* runs until the {@link BrowserTracingOptions.finalTimeout} (30 seconds by default) is reached.
*
* Set this option to `true`, if you want full control over the pageload span duration.
* You can use `Sentry.reportPageLoaded()` to manually end the pageload span whenever convenient.
* Be aware that you have to ensure that this is always called, regardless of the chosen route
* or path in the application.
*
* @default `false`. By default, the pageload span will end itself automatically, based on
* the {@link BrowserTracingOptions.finalTimeout}, {@link BrowserTracingOptions.idleTimeout}
* and {@link BrowserTracingOptions.childSpanTimeout}. This is more convenient to use but means
* that the pageload duration can be arbitrary and might not be fully representative of a perceived
* page load time.
*/
enableReportPageLoaded: boolean;

/**
* _experiments allows the user to send options to define how this integration works.
*
Expand DownExpand Up@@ -297,6 +314,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
detectRedirects: true,
linkPreviousTrace: 'in-memory',
consistentTraceSampling: false,
enableReportPageLoaded: false,
_experiments: {},
...defaultRequestInstrumentationOptions,
};
Expand All@@ -310,7 +328,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
*
* We explicitly export the proper type here, as this has to be extended in some cases.
*/
export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptions> = {}) => {
export const browserTracingIntegration = ((options: Partial<BrowserTracingOptions> = {}) => {
const latestRoute: RouteInfo = {
name: undefined,
source: undefined,
Expand DownExpand Up@@ -345,18 +363,21 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
detectRedirects,
linkPreviousTrace,
consistentTraceSampling,
enableReportPageLoaded,
onRequestSpanStart,
} = {
...DEFAULT_BROWSER_TRACING_OPTIONS,
..._options,
...options,
};

let _collectWebVitals: undefined | (() => void);
let lastInteractionTimestamp: number | undefined;

let _pageloadSpan: Span | undefined;

/** Create routing idle transaction. */
function _createRouteSpan(client: Client, startSpanOptions: StartSpanOptions, makeActive = true): void {
const isPageloadTransaction = startSpanOptions.op === 'pageload';
const isPageloadSpan = startSpanOptions.op === 'pageload';

const initialSpanName = startSpanOptions.name;
const finalStartSpanOptions: StartSpanOptions = beforeStartSpan
Expand DownExpand Up@@ -390,7 +411,7 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
finalTimeout,
childSpanTimeout,
// should wait for finish signal if it's a pageload transaction
disableAutoFinish: isPageloadTransaction,
disableAutoFinish: isPageloadSpan,
beforeSpanEnd: span => {
// This will generally always be defined here, because it is set in `setup()` of the integration
// but technically, it is optional, so we guard here to be extra safe
Expand All@@ -415,9 +436,19 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
sampled: spanIsSampled(idleSpan),
dsc: getDynamicSamplingContextFromSpan(span),
});

if (isPageloadSpan) {
// clean up the stored pageload span on the intergration.
_pageloadSpan = undefined;
}
},
trimIdleSpanEndTimestamp: !enableReportPageLoaded,
});

if (isPageloadSpan && enableReportPageLoaded) {
_pageloadSpan = idleSpan;
}

setActiveIdleSpan(client, idleSpan);

function emitFinish(): void {
Expand All@@ -426,7 +457,8 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
}
}

if (isPageloadTransaction && optionalWindowDocument) {
// Enable auto finish of the pageload span if users are not explicitly ending it
if (isPageloadSpan && !enableReportPageLoaded && optionalWindowDocument) {
optionalWindowDocument.addEventListener('readystatechange', () => {
emitFinish();
});
Expand DownExpand Up@@ -573,7 +605,15 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
...startSpanOptions,
});
});

client.on('endPageloadSpan', () => {
if (enableReportPageLoaded && _pageloadSpan) {
_pageloadSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON, 'reportPageLoaded');
_pageloadSpan.end();
}
});
},

afterAllSetup(client) {
let startingUrl: string | undefined = getLocationHref();

Expand Down
14 changes: 14 additions & 0 deletions packages/browser/src/tracing/reportPageLoaded.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
import type { Client } from '@sentry/core';
import { getClient } from '@sentry/core';

/**
* Manually report the end of the page load, resulting in the SDK ending the pageload span.
* This only works if {@link BrowserTracingOptions.enableReportPageLoaded} is set to `true`.
* Otherwise, the pageload span will end itself based on the {@link BrowserTracingOptions.finalTimeout},
* {@link BrowserTracingOptions.idleTimeout} and {@link BrowserTracingOptions.childSpanTimeout}.
*
* @param client - The client to use. If not provided, the global client will be used.
*/
export function reportPageLoaded(client: Client | undefined = getClient()): void {
client?.emit('endPageloadSpan');
}
24 changes: 24 additions & 0 deletions packages/browser/test/tracing/reportPageLoaded.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { describe, expect, it, vi } from 'vitest';
import { BrowserClient, setCurrentClient } from '../../src';
import { reportPageLoaded } from '../../src/tracing/reportPageLoaded';
import { getDefaultBrowserClientOptions } from '../helper/browser-client-options';

describe('reportPageLoaded', () => {
it('emits the endPageloadSpan event on the global client if no client is passed', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
setCurrentClient(client);

const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded();

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});

it('emits the endPageloadSpan event on the passed client', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded(client);

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});
});
11 changes: 11 additions & 0 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -606,6 +606,12 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
) => void,
): () => void;

/**
* A hook for the browser tracing integrations to trigger the end of a page load span.
* @returns {() => void} A function that, when executed, removes the registered callback.
*/
public on(hook: 'endPageloadSpan', callback: () => void): () => void;

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to go with the client hooks approach instead of exposing a method on browserTracingIntegration because in contrast to all other integrations, we don't hide the specific implementation of browserTracingIntegration behind defineIntegration. So adding a method would indeed be public API (we also can't introduce defineIntegration now as that would be a breaking change).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is a nice enough API for this anyhow, I like it!


/**
* A hook for the browser tracing integrations to trigger after the pageload span was started.
* @returns {() => void} A function that, when executed, removes the registered callback.
Expand DownExpand Up@@ -800,6 +806,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
traceOptions?: { sentryTrace?: string | undefined; baggage?: string | undefined },
): void;

/**
* Emit a hook event for browser tracing integrations to trigger the end of a page load span.
*/
public emit(hook: 'endPageloadSpan'): void;

/**
* Emit a hook event for browser tracing integrations to trigger aafter the pageload span was started.
*/
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'waits for Sentry.reportPageLoaded() to be called when `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'reportPageLoaded',
});

// We wait for 2.5 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2);
expect(spanDurationSeconds).toBeLessThan(3);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, finalTimeout: 3000 })],
tracesSampleRate: 1,
debug: true,
});

// not calling Sentry.reportPageLoaded() on purpose!
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'final timeout cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'finalTimeout',
});

// We wait for 3 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2.5);
expect(spanDurationSeconds).toBeLessThan(3.5);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, instrumentNavigation: false })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.startBrowserTracingNavigationSpan(Sentry.getClient(), { name: 'custom_navigation' });
}, 1000);

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'starting a navigation span cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'cancelled',
});

// ending span after 1s but adding a margin of 0.5s to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeLessThan(1.5);
},
);
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.feedback.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { getFeedback, sendFeedback } from '@sentry-internal/feedback';

export { feedbackAsyncIntegration as feedbackAsyncIntegration, feedbackAsyncIntegration as feedbackIntegration };
Expand Down
3 changes: 3 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,9 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { feedbackIntegrationShim as feedbackAsyncIntegration, feedbackIntegrationShim as feedbackIntegration };

export { replayIntegration, getReplay } from '@sentry-internal/replay';
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export {
feedbackIntegrationShim as feedbackAsyncIntegration,
feedbackIntegrationShim as feedbackIntegration,
Expand Down
1 change: 1 addition & 0 deletions packages/browser/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';
export { reportPageLoaded } from './tracing/reportPageLoaded';
export type { RequestInstrumentationOptions } from './tracing/request';
export {
registerSpanErrorInstrumentation,
Expand Down
50 changes: 45 additions & 5 deletions packages/browser/src/tracing/browserTracingIntegration.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -250,6 +250,23 @@ export interface BrowserTracingOptions {
*/
consistentTraceSampling: boolean;

/**
* If set to `true`, the pageload span will not end itself automatically, unless it
* runs until the {@link BrowserTracingOptions.finalTimeout} (30 seconds by default) is reached.
*
* Set this option to `true`, if you want full control over the pageload span duration.
* You can use `Sentry.reportPageLoaded()` to manually end the pageload span whenever convenient.
* Be aware that you have to ensure that this is always called, regardless of the chosen route
* or path in the application.
*
* @default `false`. By default, the pageload span will end itself automatically, based on
* the {@link BrowserTracingOptions.finalTimeout}, {@link BrowserTracingOptions.idleTimeout}
* and {@link BrowserTracingOptions.childSpanTimeout}. This is more convenient to use but means
* that the pageload duration can be arbitrary and might not be fully representative of a perceived
* page load time.
*/
enableReportPageLoaded: boolean;

/**
* _experiments allows the user to send options to define how this integration works.
*
Expand DownExpand Up@@ -297,6 +314,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
detectRedirects: true,
linkPreviousTrace: 'in-memory',
consistentTraceSampling: false,
enableReportPageLoaded: false,
_experiments: {},
...defaultRequestInstrumentationOptions,
};
Expand All@@ -310,7 +328,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
*
* We explicitly export the proper type here, as this has to be extended in some cases.
*/
export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptions> = {}) => {
export const browserTracingIntegration = ((options: Partial<BrowserTracingOptions> = {}) => {
const latestRoute: RouteInfo = {
name: undefined,
source: undefined,
Expand DownExpand Up@@ -345,18 +363,21 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
detectRedirects,
linkPreviousTrace,
consistentTraceSampling,
enableReportPageLoaded,
onRequestSpanStart,
} = {
...DEFAULT_BROWSER_TRACING_OPTIONS,
..._options,
...options,
};

let _collectWebVitals: undefined | (() => void);
let lastInteractionTimestamp: number | undefined;

let _pageloadSpan: Span | undefined;

/** Create routing idle transaction. */
function _createRouteSpan(client: Client, startSpanOptions: StartSpanOptions, makeActive = true): void {
const isPageloadTransaction = startSpanOptions.op === 'pageload';
const isPageloadSpan = startSpanOptions.op === 'pageload';

const initialSpanName = startSpanOptions.name;
const finalStartSpanOptions: StartSpanOptions = beforeStartSpan
Expand DownExpand Up@@ -390,7 +411,7 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
finalTimeout,
childSpanTimeout,
// should wait for finish signal if it's a pageload transaction
disableAutoFinish: isPageloadTransaction,
disableAutoFinish: isPageloadSpan,
beforeSpanEnd: span => {
// This will generally always be defined here, because it is set in `setup()` of the integration
// but technically, it is optional, so we guard here to be extra safe
Expand All@@ -415,9 +436,19 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
sampled: spanIsSampled(idleSpan),
dsc: getDynamicSamplingContextFromSpan(span),
});

if (isPageloadSpan) {
// clean up the stored pageload span on the intergration.
_pageloadSpan = undefined;
}
},
trimIdleSpanEndTimestamp: !enableReportPageLoaded,
});

if (isPageloadSpan && enableReportPageLoaded) {
_pageloadSpan = idleSpan;
}

setActiveIdleSpan(client, idleSpan);

function emitFinish(): void {
Expand All@@ -426,7 +457,8 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
}
}

if (isPageloadTransaction && optionalWindowDocument) {
// Enable auto finish of the pageload span if users are not explicitly ending it
if (isPageloadSpan && !enableReportPageLoaded && optionalWindowDocument) {
optionalWindowDocument.addEventListener('readystatechange', () => {
emitFinish();
});
Expand DownExpand Up@@ -573,7 +605,15 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
...startSpanOptions,
});
});

client.on('endPageloadSpan', () => {
if (enableReportPageLoaded && _pageloadSpan) {
_pageloadSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON, 'reportPageLoaded');
_pageloadSpan.end();
}
});
},

afterAllSetup(client) {
let startingUrl: string | undefined = getLocationHref();

Expand Down
14 changes: 14 additions & 0 deletions packages/browser/src/tracing/reportPageLoaded.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
import type { Client } from '@sentry/core';
import { getClient } from '@sentry/core';

/**
* Manually report the end of the page load, resulting in the SDK ending the pageload span.
* This only works if {@link BrowserTracingOptions.enableReportPageLoaded} is set to `true`.
* Otherwise, the pageload span will end itself based on the {@link BrowserTracingOptions.finalTimeout},
* {@link BrowserTracingOptions.idleTimeout} and {@link BrowserTracingOptions.childSpanTimeout}.
*
* @param client - The client to use. If not provided, the global client will be used.
*/
export function reportPageLoaded(client: Client | undefined = getClient()): void {
client?.emit('endPageloadSpan');
}
24 changes: 24 additions & 0 deletions packages/browser/test/tracing/reportPageLoaded.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { describe, expect, it, vi } from 'vitest';
import { BrowserClient, setCurrentClient } from '../../src';
import { reportPageLoaded } from '../../src/tracing/reportPageLoaded';
import { getDefaultBrowserClientOptions } from '../helper/browser-client-options';

describe('reportPageLoaded', () => {
it('emits the endPageloadSpan event on the global client if no client is passed', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
setCurrentClient(client);

const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded();

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});

it('emits the endPageloadSpan event on the passed client', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded(client);

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});
});
11 changes: 11 additions & 0 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -606,6 +606,12 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
) => void,
): () => void;

/**
* A hook for the browser tracing integrations to trigger the end of a page load span.
* @returns {() => void} A function that, when executed, removes the registered callback.
*/
public on(hook: 'endPageloadSpan', callback: () => void): () => void;

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to go with the client hooks approach instead of exposing a method on browserTracingIntegration because in contrast to all other integrations, we don't hide the specific implementation of browserTracingIntegration behind defineIntegration. So adding a method would indeed be public API (we also can't introduce defineIntegration now as that would be a breaking change).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is a nice enough API for this anyhow, I like it!


/**
* A hook for the browser tracing integrations to trigger after the pageload span was started.
* @returns {() => void} A function that, when executed, removes the registered callback.
Expand DownExpand Up@@ -800,6 +806,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
traceOptions?: { sentryTrace?: string | undefined; baggage?: string | undefined },
): void;

/**
* Emit a hook event for browser tracing integrations to trigger the end of a page load span.
*/
public emit(hook: 'endPageloadSpan'): void;

/**
* Emit a hook event for browser tracing integrations to trigger aafter the pageload span was started.
*/
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'waits for Sentry.reportPageLoaded() to be called when `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'reportPageLoaded',
});

// We wait for 2.5 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2);
expect(spanDurationSeconds).toBeLessThan(3);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, finalTimeout: 3000 })],
tracesSampleRate: 1,
debug: true,
});

// not calling Sentry.reportPageLoaded() on purpose!
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'final timeout cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'finalTimeout',
});

// We wait for 3 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2.5);
expect(spanDurationSeconds).toBeLessThan(3.5);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, instrumentNavigation: false })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.startBrowserTracingNavigationSpan(Sentry.getClient(), { name: 'custom_navigation' });
}, 1000);

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'starting a navigation span cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'cancelled',
});

// ending span after 1s but adding a margin of 0.5s to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeLessThan(1.5);
},
);
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.feedback.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { getFeedback, sendFeedback } from '@sentry-internal/feedback';

export { feedbackAsyncIntegration as feedbackAsyncIntegration, feedbackAsyncIntegration as feedbackIntegration };
Expand Down
3 changes: 3 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,9 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { feedbackIntegrationShim as feedbackAsyncIntegration, feedbackIntegrationShim as feedbackIntegration };

export { replayIntegration, getReplay } from '@sentry-internal/replay';
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export {
feedbackIntegrationShim as feedbackAsyncIntegration,
feedbackIntegrationShim as feedbackIntegration,
Expand Down
1 change: 1 addition & 0 deletions packages/browser/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';
export { reportPageLoaded } from './tracing/reportPageLoaded';
export type { RequestInstrumentationOptions } from './tracing/request';
export {
registerSpanErrorInstrumentation,
Expand Down
50 changes: 45 additions & 5 deletions packages/browser/src/tracing/browserTracingIntegration.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -250,6 +250,23 @@ export interface BrowserTracingOptions {
*/
consistentTraceSampling: boolean;

/**
* If set to `true`, the pageload span will not end itself automatically, unless it
* runs until the {@link BrowserTracingOptions.finalTimeout} (30 seconds by default) is reached.
*
* Set this option to `true`, if you want full control over the pageload span duration.
* You can use `Sentry.reportPageLoaded()` to manually end the pageload span whenever convenient.
* Be aware that you have to ensure that this is always called, regardless of the chosen route
* or path in the application.
*
* @default `false`. By default, the pageload span will end itself automatically, based on
* the {@link BrowserTracingOptions.finalTimeout}, {@link BrowserTracingOptions.idleTimeout}
* and {@link BrowserTracingOptions.childSpanTimeout}. This is more convenient to use but means
* that the pageload duration can be arbitrary and might not be fully representative of a perceived
* page load time.
*/
enableReportPageLoaded: boolean;

/**
* _experiments allows the user to send options to define how this integration works.
*
Expand DownExpand Up@@ -297,6 +314,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
detectRedirects: true,
linkPreviousTrace: 'in-memory',
consistentTraceSampling: false,
enableReportPageLoaded: false,
_experiments: {},
...defaultRequestInstrumentationOptions,
};
Expand All@@ -310,7 +328,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
*
* We explicitly export the proper type here, as this has to be extended in some cases.
*/
export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptions> = {}) => {
export const browserTracingIntegration = ((options: Partial<BrowserTracingOptions> = {}) => {
const latestRoute: RouteInfo = {
name: undefined,
source: undefined,
Expand DownExpand Up@@ -345,18 +363,21 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
detectRedirects,
linkPreviousTrace,
consistentTraceSampling,
enableReportPageLoaded,
onRequestSpanStart,
} = {
...DEFAULT_BROWSER_TRACING_OPTIONS,
..._options,
...options,
};

let _collectWebVitals: undefined | (() => void);
let lastInteractionTimestamp: number | undefined;

let _pageloadSpan: Span | undefined;

/** Create routing idle transaction. */
function _createRouteSpan(client: Client, startSpanOptions: StartSpanOptions, makeActive = true): void {
const isPageloadTransaction = startSpanOptions.op === 'pageload';
const isPageloadSpan = startSpanOptions.op === 'pageload';

const initialSpanName = startSpanOptions.name;
const finalStartSpanOptions: StartSpanOptions = beforeStartSpan
Expand DownExpand Up@@ -390,7 +411,7 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
finalTimeout,
childSpanTimeout,
// should wait for finish signal if it's a pageload transaction
disableAutoFinish: isPageloadTransaction,
disableAutoFinish: isPageloadSpan,
beforeSpanEnd: span => {
// This will generally always be defined here, because it is set in `setup()` of the integration
// but technically, it is optional, so we guard here to be extra safe
Expand All@@ -415,9 +436,19 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
sampled: spanIsSampled(idleSpan),
dsc: getDynamicSamplingContextFromSpan(span),
});

if (isPageloadSpan) {
// clean up the stored pageload span on the intergration.
_pageloadSpan = undefined;
}
},
trimIdleSpanEndTimestamp: !enableReportPageLoaded,
});

if (isPageloadSpan && enableReportPageLoaded) {
_pageloadSpan = idleSpan;
}

setActiveIdleSpan(client, idleSpan);

function emitFinish(): void {
Expand All@@ -426,7 +457,8 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
}
}

if (isPageloadTransaction && optionalWindowDocument) {
// Enable auto finish of the pageload span if users are not explicitly ending it
if (isPageloadSpan && !enableReportPageLoaded && optionalWindowDocument) {
optionalWindowDocument.addEventListener('readystatechange', () => {
emitFinish();
});
Expand DownExpand Up@@ -573,7 +605,15 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
...startSpanOptions,
});
});

client.on('endPageloadSpan', () => {
if (enableReportPageLoaded && _pageloadSpan) {
_pageloadSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON, 'reportPageLoaded');
_pageloadSpan.end();
}
});
},

afterAllSetup(client) {
let startingUrl: string | undefined = getLocationHref();

Expand Down
14 changes: 14 additions & 0 deletions packages/browser/src/tracing/reportPageLoaded.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
import type { Client } from '@sentry/core';
import { getClient } from '@sentry/core';

/**
* Manually report the end of the page load, resulting in the SDK ending the pageload span.
* This only works if {@link BrowserTracingOptions.enableReportPageLoaded} is set to `true`.
* Otherwise, the pageload span will end itself based on the {@link BrowserTracingOptions.finalTimeout},
* {@link BrowserTracingOptions.idleTimeout} and {@link BrowserTracingOptions.childSpanTimeout}.
*
* @param client - The client to use. If not provided, the global client will be used.
*/
export function reportPageLoaded(client: Client | undefined = getClient()): void {
client?.emit('endPageloadSpan');
}
24 changes: 24 additions & 0 deletions packages/browser/test/tracing/reportPageLoaded.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { describe, expect, it, vi } from 'vitest';
import { BrowserClient, setCurrentClient } from '../../src';
import { reportPageLoaded } from '../../src/tracing/reportPageLoaded';
import { getDefaultBrowserClientOptions } from '../helper/browser-client-options';

describe('reportPageLoaded', () => {
it('emits the endPageloadSpan event on the global client if no client is passed', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
setCurrentClient(client);

const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded();

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});

it('emits the endPageloadSpan event on the passed client', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded(client);

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});
});
11 changes: 11 additions & 0 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -606,6 +606,12 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
) => void,
): () => void;

/**
* A hook for the browser tracing integrations to trigger the end of a page load span.
* @returns {() => void} A function that, when executed, removes the registered callback.
*/
public on(hook: 'endPageloadSpan', callback: () => void): () => void;

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to go with the client hooks approach instead of exposing a method on browserTracingIntegration because in contrast to all other integrations, we don't hide the specific implementation of browserTracingIntegration behind defineIntegration. So adding a method would indeed be public API (we also can't introduce defineIntegration now as that would be a breaking change).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is a nice enough API for this anyhow, I like it!


/**
* A hook for the browser tracing integrations to trigger after the pageload span was started.
* @returns {() => void} A function that, when executed, removes the registered callback.
Expand DownExpand Up@@ -800,6 +806,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
traceOptions?: { sentryTrace?: string | undefined; baggage?: string | undefined },
): void;

/**
* Emit a hook event for browser tracing integrations to trigger the end of a page load span.
*/
public emit(hook: 'endPageloadSpan'): void;

/**
* Emit a hook event for browser tracing integrations to trigger aafter the pageload span was started.
*/
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'waits for Sentry.reportPageLoaded() to be called when `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'reportPageLoaded',
});

// We wait for 2.5 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2);
expect(spanDurationSeconds).toBeLessThan(3);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, finalTimeout: 3000 })],
tracesSampleRate: 1,
debug: true,
});

// not calling Sentry.reportPageLoaded() on purpose!
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'final timeout cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'finalTimeout',
});

// We wait for 3 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2.5);
expect(spanDurationSeconds).toBeLessThan(3.5);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, instrumentNavigation: false })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.startBrowserTracingNavigationSpan(Sentry.getClient(), { name: 'custom_navigation' });
}, 1000);

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'starting a navigation span cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'cancelled',
});

// ending span after 1s but adding a margin of 0.5s to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeLessThan(1.5);
},
);
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.feedback.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { getFeedback, sendFeedback } from '@sentry-internal/feedback';

export { feedbackAsyncIntegration as feedbackAsyncIntegration, feedbackAsyncIntegration as feedbackIntegration };
Expand Down
3 changes: 3 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,9 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { feedbackIntegrationShim as feedbackAsyncIntegration, feedbackIntegrationShim as feedbackIntegration };

export { replayIntegration, getReplay } from '@sentry-internal/replay';
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export {
feedbackIntegrationShim as feedbackAsyncIntegration,
feedbackIntegrationShim as feedbackIntegration,
Expand Down
1 change: 1 addition & 0 deletions packages/browser/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';
export { reportPageLoaded } from './tracing/reportPageLoaded';
export type { RequestInstrumentationOptions } from './tracing/request';
export {
registerSpanErrorInstrumentation,
Expand Down
50 changes: 45 additions & 5 deletions packages/browser/src/tracing/browserTracingIntegration.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -250,6 +250,23 @@ export interface BrowserTracingOptions {
*/
consistentTraceSampling: boolean;

/**
* If set to `true`, the pageload span will not end itself automatically, unless it
* runs until the {@link BrowserTracingOptions.finalTimeout} (30 seconds by default) is reached.
*
* Set this option to `true`, if you want full control over the pageload span duration.
* You can use `Sentry.reportPageLoaded()` to manually end the pageload span whenever convenient.
* Be aware that you have to ensure that this is always called, regardless of the chosen route
* or path in the application.
*
* @default `false`. By default, the pageload span will end itself automatically, based on
* the {@link BrowserTracingOptions.finalTimeout}, {@link BrowserTracingOptions.idleTimeout}
* and {@link BrowserTracingOptions.childSpanTimeout}. This is more convenient to use but means
* that the pageload duration can be arbitrary and might not be fully representative of a perceived
* page load time.
*/
enableReportPageLoaded: boolean;

/**
* _experiments allows the user to send options to define how this integration works.
*
Expand DownExpand Up@@ -297,6 +314,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
detectRedirects: true,
linkPreviousTrace: 'in-memory',
consistentTraceSampling: false,
enableReportPageLoaded: false,
_experiments: {},
...defaultRequestInstrumentationOptions,
};
Expand All@@ -310,7 +328,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
*
* We explicitly export the proper type here, as this has to be extended in some cases.
*/
export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptions> = {}) => {
export const browserTracingIntegration = ((options: Partial<BrowserTracingOptions> = {}) => {
const latestRoute: RouteInfo = {
name: undefined,
source: undefined,
Expand DownExpand Up@@ -345,18 +363,21 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
detectRedirects,
linkPreviousTrace,
consistentTraceSampling,
enableReportPageLoaded,
onRequestSpanStart,
} = {
...DEFAULT_BROWSER_TRACING_OPTIONS,
..._options,
...options,
};

let _collectWebVitals: undefined | (() => void);
let lastInteractionTimestamp: number | undefined;

let _pageloadSpan: Span | undefined;

/** Create routing idle transaction. */
function _createRouteSpan(client: Client, startSpanOptions: StartSpanOptions, makeActive = true): void {
const isPageloadTransaction = startSpanOptions.op === 'pageload';
const isPageloadSpan = startSpanOptions.op === 'pageload';

const initialSpanName = startSpanOptions.name;
const finalStartSpanOptions: StartSpanOptions = beforeStartSpan
Expand DownExpand Up@@ -390,7 +411,7 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
finalTimeout,
childSpanTimeout,
// should wait for finish signal if it's a pageload transaction
disableAutoFinish: isPageloadTransaction,
disableAutoFinish: isPageloadSpan,
beforeSpanEnd: span => {
// This will generally always be defined here, because it is set in `setup()` of the integration
// but technically, it is optional, so we guard here to be extra safe
Expand All@@ -415,9 +436,19 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
sampled: spanIsSampled(idleSpan),
dsc: getDynamicSamplingContextFromSpan(span),
});

if (isPageloadSpan) {
// clean up the stored pageload span on the intergration.
_pageloadSpan = undefined;
}
},
trimIdleSpanEndTimestamp: !enableReportPageLoaded,
});

if (isPageloadSpan && enableReportPageLoaded) {
_pageloadSpan = idleSpan;
}

setActiveIdleSpan(client, idleSpan);

function emitFinish(): void {
Expand All@@ -426,7 +457,8 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
}
}

if (isPageloadTransaction && optionalWindowDocument) {
// Enable auto finish of the pageload span if users are not explicitly ending it
if (isPageloadSpan && !enableReportPageLoaded && optionalWindowDocument) {
optionalWindowDocument.addEventListener('readystatechange', () => {
emitFinish();
});
Expand DownExpand Up@@ -573,7 +605,15 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
...startSpanOptions,
});
});

client.on('endPageloadSpan', () => {
if (enableReportPageLoaded && _pageloadSpan) {
_pageloadSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON, 'reportPageLoaded');
_pageloadSpan.end();
}
});
},

afterAllSetup(client) {
let startingUrl: string | undefined = getLocationHref();

Expand Down
14 changes: 14 additions & 0 deletions packages/browser/src/tracing/reportPageLoaded.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
import type { Client } from '@sentry/core';
import { getClient } from '@sentry/core';

/**
* Manually report the end of the page load, resulting in the SDK ending the pageload span.
* This only works if {@link BrowserTracingOptions.enableReportPageLoaded} is set to `true`.
* Otherwise, the pageload span will end itself based on the {@link BrowserTracingOptions.finalTimeout},
* {@link BrowserTracingOptions.idleTimeout} and {@link BrowserTracingOptions.childSpanTimeout}.
*
* @param client - The client to use. If not provided, the global client will be used.
*/
export function reportPageLoaded(client: Client | undefined = getClient()): void {
client?.emit('endPageloadSpan');
}
24 changes: 24 additions & 0 deletions packages/browser/test/tracing/reportPageLoaded.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { describe, expect, it, vi } from 'vitest';
import { BrowserClient, setCurrentClient } from '../../src';
import { reportPageLoaded } from '../../src/tracing/reportPageLoaded';
import { getDefaultBrowserClientOptions } from '../helper/browser-client-options';

describe('reportPageLoaded', () => {
it('emits the endPageloadSpan event on the global client if no client is passed', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
setCurrentClient(client);

const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded();

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});

it('emits the endPageloadSpan event on the passed client', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded(client);

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});
});
11 changes: 11 additions & 0 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -606,6 +606,12 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
) => void,
): () => void;

/**
* A hook for the browser tracing integrations to trigger the end of a page load span.
* @returns {() => void} A function that, when executed, removes the registered callback.
*/
public on(hook: 'endPageloadSpan', callback: () => void): () => void;

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to go with the client hooks approach instead of exposing a method on browserTracingIntegration because in contrast to all other integrations, we don't hide the specific implementation of browserTracingIntegration behind defineIntegration. So adding a method would indeed be public API (we also can't introduce defineIntegration now as that would be a breaking change).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is a nice enough API for this anyhow, I like it!


/**
* A hook for the browser tracing integrations to trigger after the pageload span was started.
* @returns {() => void} A function that, when executed, removes the registered callback.
Expand DownExpand Up@@ -800,6 +806,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
traceOptions?: { sentryTrace?: string | undefined; baggage?: string | undefined },
): void;

/**
* Emit a hook event for browser tracing integrations to trigger the end of a page load span.
*/
public emit(hook: 'endPageloadSpan'): void;

/**
* Emit a hook event for browser tracing integrations to trigger aafter the pageload span was started.
*/
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'waits for Sentry.reportPageLoaded() to be called when `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'reportPageLoaded',
});

// We wait for 2.5 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2);
expect(spanDurationSeconds).toBeLessThan(3);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, finalTimeout: 3000 })],
tracesSampleRate: 1,
debug: true,
});

// not calling Sentry.reportPageLoaded() on purpose!
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'final timeout cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'finalTimeout',
});

// We wait for 3 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2.5);
expect(spanDurationSeconds).toBeLessThan(3.5);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, instrumentNavigation: false })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.startBrowserTracingNavigationSpan(Sentry.getClient(), { name: 'custom_navigation' });
}, 1000);

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'starting a navigation span cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'cancelled',
});

// ending span after 1s but adding a margin of 0.5s to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeLessThan(1.5);
},
);
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.feedback.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { getFeedback, sendFeedback } from '@sentry-internal/feedback';

export { feedbackAsyncIntegration as feedbackAsyncIntegration, feedbackAsyncIntegration as feedbackIntegration };
Expand Down
3 changes: 3 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,9 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { feedbackIntegrationShim as feedbackAsyncIntegration, feedbackIntegrationShim as feedbackIntegration };

export { replayIntegration, getReplay } from '@sentry-internal/replay';
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export {
feedbackIntegrationShim as feedbackAsyncIntegration,
feedbackIntegrationShim as feedbackIntegration,
Expand Down
1 change: 1 addition & 0 deletions packages/browser/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';
export { reportPageLoaded } from './tracing/reportPageLoaded';
export type { RequestInstrumentationOptions } from './tracing/request';
export {
registerSpanErrorInstrumentation,
Expand Down
50 changes: 45 additions & 5 deletions packages/browser/src/tracing/browserTracingIntegration.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -250,6 +250,23 @@ export interface BrowserTracingOptions {
*/
consistentTraceSampling: boolean;

/**
* If set to `true`, the pageload span will not end itself automatically, unless it
* runs until the {@link BrowserTracingOptions.finalTimeout} (30 seconds by default) is reached.
*
* Set this option to `true`, if you want full control over the pageload span duration.
* You can use `Sentry.reportPageLoaded()` to manually end the pageload span whenever convenient.
* Be aware that you have to ensure that this is always called, regardless of the chosen route
* or path in the application.
*
* @default `false`. By default, the pageload span will end itself automatically, based on
* the {@link BrowserTracingOptions.finalTimeout}, {@link BrowserTracingOptions.idleTimeout}
* and {@link BrowserTracingOptions.childSpanTimeout}. This is more convenient to use but means
* that the pageload duration can be arbitrary and might not be fully representative of a perceived
* page load time.
*/
enableReportPageLoaded: boolean;

/**
* _experiments allows the user to send options to define how this integration works.
*
Expand DownExpand Up@@ -297,6 +314,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
detectRedirects: true,
linkPreviousTrace: 'in-memory',
consistentTraceSampling: false,
enableReportPageLoaded: false,
_experiments: {},
...defaultRequestInstrumentationOptions,
};
Expand All@@ -310,7 +328,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
*
* We explicitly export the proper type here, as this has to be extended in some cases.
*/
export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptions> = {}) => {
export const browserTracingIntegration = ((options: Partial<BrowserTracingOptions> = {}) => {
const latestRoute: RouteInfo = {
name: undefined,
source: undefined,
Expand DownExpand Up@@ -345,18 +363,21 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
detectRedirects,
linkPreviousTrace,
consistentTraceSampling,
enableReportPageLoaded,
onRequestSpanStart,
} = {
...DEFAULT_BROWSER_TRACING_OPTIONS,
..._options,
...options,
};

let _collectWebVitals: undefined | (() => void);
let lastInteractionTimestamp: number | undefined;

let _pageloadSpan: Span | undefined;

/** Create routing idle transaction. */
function _createRouteSpan(client: Client, startSpanOptions: StartSpanOptions, makeActive = true): void {
const isPageloadTransaction = startSpanOptions.op === 'pageload';
const isPageloadSpan = startSpanOptions.op === 'pageload';

const initialSpanName = startSpanOptions.name;
const finalStartSpanOptions: StartSpanOptions = beforeStartSpan
Expand DownExpand Up@@ -390,7 +411,7 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
finalTimeout,
childSpanTimeout,
// should wait for finish signal if it's a pageload transaction
disableAutoFinish: isPageloadTransaction,
disableAutoFinish: isPageloadSpan,
beforeSpanEnd: span => {
// This will generally always be defined here, because it is set in `setup()` of the integration
// but technically, it is optional, so we guard here to be extra safe
Expand All@@ -415,9 +436,19 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
sampled: spanIsSampled(idleSpan),
dsc: getDynamicSamplingContextFromSpan(span),
});

if (isPageloadSpan) {
// clean up the stored pageload span on the intergration.
_pageloadSpan = undefined;
}
},
trimIdleSpanEndTimestamp: !enableReportPageLoaded,
});

if (isPageloadSpan && enableReportPageLoaded) {
_pageloadSpan = idleSpan;
}

setActiveIdleSpan(client, idleSpan);

function emitFinish(): void {
Expand All@@ -426,7 +457,8 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
}
}

if (isPageloadTransaction && optionalWindowDocument) {
// Enable auto finish of the pageload span if users are not explicitly ending it
if (isPageloadSpan && !enableReportPageLoaded && optionalWindowDocument) {
optionalWindowDocument.addEventListener('readystatechange', () => {
emitFinish();
});
Expand DownExpand Up@@ -573,7 +605,15 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
...startSpanOptions,
});
});

client.on('endPageloadSpan', () => {
if (enableReportPageLoaded && _pageloadSpan) {
_pageloadSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON, 'reportPageLoaded');
_pageloadSpan.end();
}
});
},

afterAllSetup(client) {
let startingUrl: string | undefined = getLocationHref();

Expand Down
14 changes: 14 additions & 0 deletions packages/browser/src/tracing/reportPageLoaded.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
import type { Client } from '@sentry/core';
import { getClient } from '@sentry/core';

/**
* Manually report the end of the page load, resulting in the SDK ending the pageload span.
* This only works if {@link BrowserTracingOptions.enableReportPageLoaded} is set to `true`.
* Otherwise, the pageload span will end itself based on the {@link BrowserTracingOptions.finalTimeout},
* {@link BrowserTracingOptions.idleTimeout} and {@link BrowserTracingOptions.childSpanTimeout}.
*
* @param client - The client to use. If not provided, the global client will be used.
*/
export function reportPageLoaded(client: Client | undefined = getClient()): void {
client?.emit('endPageloadSpan');
}
24 changes: 24 additions & 0 deletions packages/browser/test/tracing/reportPageLoaded.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { describe, expect, it, vi } from 'vitest';
import { BrowserClient, setCurrentClient } from '../../src';
import { reportPageLoaded } from '../../src/tracing/reportPageLoaded';
import { getDefaultBrowserClientOptions } from '../helper/browser-client-options';

describe('reportPageLoaded', () => {
it('emits the endPageloadSpan event on the global client if no client is passed', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
setCurrentClient(client);

const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded();

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});

it('emits the endPageloadSpan event on the passed client', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded(client);

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});
});
11 changes: 11 additions & 0 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -606,6 +606,12 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
) => void,
): () => void;

/**
* A hook for the browser tracing integrations to trigger the end of a page load span.
* @returns {() => void} A function that, when executed, removes the registered callback.
*/
public on(hook: 'endPageloadSpan', callback: () => void): () => void;

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to go with the client hooks approach instead of exposing a method on browserTracingIntegration because in contrast to all other integrations, we don't hide the specific implementation of browserTracingIntegration behind defineIntegration. So adding a method would indeed be public API (we also can't introduce defineIntegration now as that would be a breaking change).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is a nice enough API for this anyhow, I like it!


/**
* A hook for the browser tracing integrations to trigger after the pageload span was started.
* @returns {() => void} A function that, when executed, removes the registered callback.
Expand DownExpand Up@@ -800,6 +806,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
traceOptions?: { sentryTrace?: string | undefined; baggage?: string | undefined },
): void;

/**
* Emit a hook event for browser tracing integrations to trigger the end of a page load span.
*/
public emit(hook: 'endPageloadSpan'): void;

/**
* Emit a hook event for browser tracing integrations to trigger aafter the pageload span was started.
*/
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'waits for Sentry.reportPageLoaded() to be called when `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'reportPageLoaded',
});

// We wait for 2.5 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2);
expect(spanDurationSeconds).toBeLessThan(3);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, finalTimeout: 3000 })],
tracesSampleRate: 1,
debug: true,
});

// not calling Sentry.reportPageLoaded() on purpose!
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'final timeout cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'finalTimeout',
});

// We wait for 3 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeGreaterThan(2.5);
expect(spanDurationSeconds).toBeLessThan(3.5);
},
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;
window._testBaseTimestamp = performance.timeOrigin / 1000;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.browserTracingIntegration({ enableReportPageLoaded: true, instrumentNavigation: false })],
tracesSampleRate: 1,
debug: true,
});

setTimeout(() => {
Sentry.startBrowserTracingNavigationSpan(Sentry.getClient(), { name: 'custom_navigation' });
}, 1000);

setTimeout(() => {
Sentry.reportPageLoaded();
}, 2500);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
import { expect } from '@playwright/test';
import {
SEMANTIC_ATTRIBUTE_SENTRY_OP,
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
} from '@sentry/browser';
import { sentryTest } from '../../../../../utils/fixtures';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';

sentryTest(
'starting a navigation span cancels the pageload span even if `enableReportPageLoaded` is true',
async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const pageloadEventPromise = waitForTransactionRequest(page, event => event.contexts?.trace?.op === 'pageload');

const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);

const eventData = envelopeRequestParser(await pageloadEventPromise);

const traceContextData = eventData.contexts?.trace?.data;
const spanDurationSeconds = eventData.timestamp! - eventData.start_timestamp!;

expect(traceContextData).toMatchObject({
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.browser',
[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1,
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload',
['sentry.idle_span_finish_reason']: 'cancelled',
});

// ending span after 1s but adding a margin of 0.5s to account for timing weirdness in CI to avoid flakes
expect(spanDurationSeconds).toBeLessThan(1.5);
},
);
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.feedback.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { getFeedback, sendFeedback } from '@sentry-internal/feedback';

export { feedbackAsyncIntegration as feedbackAsyncIntegration, feedbackAsyncIntegration as feedbackIntegration };
Expand Down
3 changes: 3 additions & 0 deletions packages/browser/src/index.bundle.tracing.replay.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,9 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export { feedbackIntegrationShim as feedbackAsyncIntegration, feedbackIntegrationShim as feedbackIntegration };

export { replayIntegration, getReplay } from '@sentry-internal/replay';
2 changes: 2 additions & 0 deletions packages/browser/src/index.bundle.tracing.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,8 @@ export {
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';

export { reportPageLoaded } from './tracing/reportPageLoaded';

export {
feedbackIntegrationShim as feedbackAsyncIntegration,
feedbackIntegrationShim as feedbackIntegration,
Expand Down
1 change: 1 addition & 0 deletions packages/browser/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,6 +42,7 @@ export {
startBrowserTracingNavigationSpan,
startBrowserTracingPageLoadSpan,
} from './tracing/browserTracingIntegration';
export { reportPageLoaded } from './tracing/reportPageLoaded';
export type { RequestInstrumentationOptions } from './tracing/request';
export {
registerSpanErrorInstrumentation,
Expand Down
50 changes: 45 additions & 5 deletions packages/browser/src/tracing/browserTracingIntegration.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -250,6 +250,23 @@ export interface BrowserTracingOptions {
*/
consistentTraceSampling: boolean;

/**
* If set to `true`, the pageload span will not end itself automatically, unless it
* runs until the {@link BrowserTracingOptions.finalTimeout} (30 seconds by default) is reached.
*
* Set this option to `true`, if you want full control over the pageload span duration.
* You can use `Sentry.reportPageLoaded()` to manually end the pageload span whenever convenient.
* Be aware that you have to ensure that this is always called, regardless of the chosen route
* or path in the application.
*
* @default `false`. By default, the pageload span will end itself automatically, based on
* the {@link BrowserTracingOptions.finalTimeout}, {@link BrowserTracingOptions.idleTimeout}
* and {@link BrowserTracingOptions.childSpanTimeout}. This is more convenient to use but means
* that the pageload duration can be arbitrary and might not be fully representative of a perceived
* page load time.
*/
enableReportPageLoaded: boolean;

/**
* _experiments allows the user to send options to define how this integration works.
*
Expand DownExpand Up@@ -297,6 +314,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
detectRedirects: true,
linkPreviousTrace: 'in-memory',
consistentTraceSampling: false,
enableReportPageLoaded: false,
_experiments: {},
...defaultRequestInstrumentationOptions,
};
Expand All@@ -310,7 +328,7 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = {
*
* We explicitly export the proper type here, as this has to be extended in some cases.
*/
export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptions> = {}) => {
export const browserTracingIntegration = ((options: Partial<BrowserTracingOptions> = {}) => {
const latestRoute: RouteInfo = {
name: undefined,
source: undefined,
Expand DownExpand Up@@ -345,18 +363,21 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
detectRedirects,
linkPreviousTrace,
consistentTraceSampling,
enableReportPageLoaded,
onRequestSpanStart,
} = {
...DEFAULT_BROWSER_TRACING_OPTIONS,
..._options,
...options,
};

let _collectWebVitals: undefined | (() => void);
let lastInteractionTimestamp: number | undefined;

let _pageloadSpan: Span | undefined;

/** Create routing idle transaction. */
function _createRouteSpan(client: Client, startSpanOptions: StartSpanOptions, makeActive = true): void {
const isPageloadTransaction = startSpanOptions.op === 'pageload';
const isPageloadSpan = startSpanOptions.op === 'pageload';

const initialSpanName = startSpanOptions.name;
const finalStartSpanOptions: StartSpanOptions = beforeStartSpan
Expand DownExpand Up@@ -390,7 +411,7 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
finalTimeout,
childSpanTimeout,
// should wait for finish signal if it's a pageload transaction
disableAutoFinish: isPageloadTransaction,
disableAutoFinish: isPageloadSpan,
beforeSpanEnd: span => {
// This will generally always be defined here, because it is set in `setup()` of the integration
// but technically, it is optional, so we guard here to be extra safe
Expand All@@ -415,9 +436,19 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
sampled: spanIsSampled(idleSpan),
dsc: getDynamicSamplingContextFromSpan(span),
});

if (isPageloadSpan) {
// clean up the stored pageload span on the intergration.
_pageloadSpan = undefined;
}
},
trimIdleSpanEndTimestamp: !enableReportPageLoaded,
});

if (isPageloadSpan && enableReportPageLoaded) {
_pageloadSpan = idleSpan;
}

setActiveIdleSpan(client, idleSpan);

function emitFinish(): void {
Expand All@@ -426,7 +457,8 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
}
}

if (isPageloadTransaction && optionalWindowDocument) {
// Enable auto finish of the pageload span if users are not explicitly ending it
if (isPageloadSpan && !enableReportPageLoaded && optionalWindowDocument) {
optionalWindowDocument.addEventListener('readystatechange', () => {
emitFinish();
});
Expand DownExpand Up@@ -573,7 +605,15 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio
...startSpanOptions,
});
});

client.on('endPageloadSpan', () => {
if (enableReportPageLoaded && _pageloadSpan) {
_pageloadSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON, 'reportPageLoaded');
_pageloadSpan.end();
}
});
},

afterAllSetup(client) {
let startingUrl: string | undefined = getLocationHref();

Expand Down
14 changes: 14 additions & 0 deletions packages/browser/src/tracing/reportPageLoaded.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
import type { Client } from '@sentry/core';
import { getClient } from '@sentry/core';

/**
* Manually report the end of the page load, resulting in the SDK ending the pageload span.
* This only works if {@link BrowserTracingOptions.enableReportPageLoaded} is set to `true`.
* Otherwise, the pageload span will end itself based on the {@link BrowserTracingOptions.finalTimeout},
* {@link BrowserTracingOptions.idleTimeout} and {@link BrowserTracingOptions.childSpanTimeout}.
*
* @param client - The client to use. If not provided, the global client will be used.
*/
export function reportPageLoaded(client: Client | undefined = getClient()): void {
client?.emit('endPageloadSpan');
}
24 changes: 24 additions & 0 deletions packages/browser/test/tracing/reportPageLoaded.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import { describe, expect, it, vi } from 'vitest';
import { BrowserClient, setCurrentClient } from '../../src';
import { reportPageLoaded } from '../../src/tracing/reportPageLoaded';
import { getDefaultBrowserClientOptions } from '../helper/browser-client-options';

describe('reportPageLoaded', () => {
it('emits the endPageloadSpan event on the global client if no client is passed', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
setCurrentClient(client);

const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded();

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});

it('emits the endPageloadSpan event on the passed client', () => {
const client = new BrowserClient(getDefaultBrowserClientOptions({}));
const emitSpy = vi.spyOn(client, 'emit');
reportPageLoaded(client);

expect(emitSpy).toHaveBeenCalledWith('endPageloadSpan');
});
});
11 changes: 11 additions & 0 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -606,6 +606,12 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
) => void,
): () => void;

/**
* A hook for the browser tracing integrations to trigger the end of a page load span.
* @returns {() => void} A function that, when executed, removes the registered callback.
*/
public on(hook: 'endPageloadSpan', callback: () => void): () => void;

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to go with the client hooks approach instead of exposing a method on browserTracingIntegration because in contrast to all other integrations, we don't hide the specific implementation of browserTracingIntegration behind defineIntegration. So adding a method would indeed be public API (we also can't introduce defineIntegration now as that would be a breaking change).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this is a nice enough API for this anyhow, I like it!


/**
* A hook for the browser tracing integrations to trigger after the pageload span was started.
* @returns {() => void} A function that, when executed, removes the registered callback.
Expand DownExpand Up@@ -800,6 +806,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
traceOptions?: { sentryTrace?: string | undefined; baggage?: string | undefined },
): void;

/**
* Emit a hook event for browser tracing integrations to trigger the end of a page load span.
*/
public emit(hook: 'endPageloadSpan'): void;

/**
* Emit a hook event for browser tracing integrations to trigger aafter the pageload span was started.
*/
Expand Down
Loading