87 changes: 67 additions & 20 deletions packages/cloudflare/src/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,13 +8,14 @@ import {
parseStringToURLObject,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
setHttpStatus,
startSpan,
startSpanManual,
winterCGHeadersToDict,
withIsolationScope,
} from '@sentry/core';
import type { CloudflareOptions } from './client';
import { addCloudResourceContext, addCultureContext, addRequest } from './scope-utils';
import { init } from './sdk';
import { classifyResponseStreaming } from './utils/streaming';

interface RequestHandlerWrapperOptions {
options: CloudflareOptions;
Expand DownExpand Up@@ -97,30 +98,76 @@ export function wrapRequestHandler(
// Note: This span will not have a duration unless I/O happens in the handler. This is
// because of how the cloudflare workers runtime works.
// See: https://developers.cloudflare.com/workers/runtime-apis/performance/
return startSpan(
{
name,
attributes,
},
async span => {

// Use startSpanManual to control when span ends (needed for streaming responses)
return startSpanManual({ name, attributes }, async span => {
let res: Response;

try {
res = await handler();
setHttpStatus(span, res.status);

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
} catch (e) {
span.end();
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
waitUntil?.(flush(2000));
throw e;
}

// Classify response to detect actual streaming
const classification = classifyResponseStreaming(res);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: what happens if we mis-classify a non-streaming response as a stream response? Would we break anything with creating the stream readers?

I guess the other way around isn't "dangerous", given we'd just end the span too early, correct?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so for false positives (non-streaming → classified as streaming) functionality wise it won't break anything, the only downside is slightly more overhead (creating an unnecessary stream monitor), and for false negatives yes you're correct, it would end span too early, but that's our best guess for now


if (classification.isStreaming && res.body) {
// Streaming response detected - monitor consumption to keep span alive
try {
const res = await handler();
setHttpStatus(span, res.status);
const [clientStream, monitorStream] = res.body.tee();

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
return res;
// Monitor stream consumption and end span when complete
const streamMonitor = (async () => {
const reader = monitorStream.getReader();

try {
let done = false;
while (!done) {
const result = await reader.read();
done = result.done;
}
} catch {
// Stream error or cancellation - will end span in finally
} finally {
reader.releaseLock();
span.end();
waitUntil?.(flush(2000));
}
})();

// Keep worker alive until stream monitoring completes (otherwise span won't end)
waitUntil?.(streamMonitor);

// Return response with client stream
return new Response(clientStream, {
status: res.status,
statusText: res.statusText,
headers: res.headers,
});
} catch (e) {
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
throw e;
} finally {
// tee() failed (e.g stream already locked) - fall back to non-streaming handling
span.end();
waitUntil?.(flush(2000));
return res;
}
},
);
}

// Non-streaming response - end span immediately and return original
span.end();
waitUntil?.(flush(2000));
return res;
});
},
);
});
Expand Down
41 changes: 41 additions & 0 deletions packages/cloudflare/src/utils/streaming.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
export type StreamingGuess = {
isStreaming: boolean;
};

/**
* Classifies a Response as streaming or non-streaming.
*
* Heuristics:
* - No body → not streaming
* - Known streaming Content-Types → streaming (SSE, NDJSON, JSON streaming)
* - text/plain without Content-Length → streaming (some AI APIs)
* - Otherwise → not streaming (conservative default, including HTML/SSR)
*
* We avoid probing the stream to prevent blocking on transform streams (like injectTraceMetaTags)
* or SSR streams that may not have data ready immediately.
*/
export function classifyResponseStreaming(res: Response): StreamingGuess {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l/nit: Is there a reason why we return the response as well? I don't see any changes being made to it, so could a caller just directly reuse res instead of using the returned response?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I was mutating the res in a previous commit, these are just leftovers 😅

if (!res.body) {
return { isStreaming: false };
}

const contentType = res.headers.get('content-type') ?? '';
const contentLength = res.headers.get('content-length');

// Streaming: Known streaming content types
// - text/event-stream: Server-Sent Events (Vercel AI SDK, real-time APIs)
// - application/x-ndjson, application/ndjson: Newline-delimited JSON
// - application/stream+json: JSON streaming
// - text/plain (without Content-Length): Some AI APIs use this for streaming text
if (
/^text\/event-stream\b/i.test(contentType) ||
/^application\/(x-)?ndjson\b/i.test(contentType) ||
/^application\/stream\+json\b/i.test(contentType) ||
(/^text\/plain\b/i.test(contentType) && !contentLength)
) {
return { isStreaming: true };
}

// Default: treat as non-streaming
return { isStreaming: false };
}
34 changes: 29 additions & 5 deletions packages/cloudflare/test/durableobject.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,11 +116,18 @@ describe('instrumentDurableObjectWithSentry', () => {
});

it('flush performs after all waitUntil promises are finished', async () => {
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flush.mock.calls.length;

const waitUntil = vi.fn();
const testClass = vi.fn(context => ({
fetch: () => {
Expand All@@ -133,12 +140,29 @@ describe('instrumentDurableObjectWithSentry', () => {
waitUntil,
} as unknown as ExecutionContext;
const dObject: any = Reflect.construct(instrumented, [context, {} as any]);
expect(() => dObject.fetch(new Request('https://example.com'))).not.toThrow();
expect(flush).not.toBeCalled();
expect(waitUntil).toHaveBeenCalledOnce();

// Call fetch (don't await yet)
const responsePromise = dObject.fetch(new Request('https://example.com'));

// Advance past classification timeout and get response
vi.advanceTimersByTime(30);
const response = await responsePromise;

// Consume response (triggers span end for buffered responses)
await response.text();

// The flush should now be queued in waitUntil
expect(waitUntil).toHaveBeenCalled();

// Advance to trigger the setTimeout in the handler's waitUntil
vi.advanceTimersToNextTimer();
await Promise.all(waitUntil.mock.calls.map(([p]) => p));
expect(flush).toBeCalled();

const after = flush.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('instrumentPrototypeMethods option', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/cloudflare/test/handler.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,11 @@ describe('withSentry', () => {
createMockExecutionContext(),
);

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result?.status).toBe(response.status);
if (result) {
expect(await result.text()).toBe('test');
}
});

test('merges options from env and callback', async () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/cloudflare/test/pages-plugin.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,8 @@ describe('sentryPagesPlugin', () => {
pluginArgs: MOCK_OPTIONS,
});

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});
});
50 changes: 44 additions & 6 deletions packages/cloudflare/test/request.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,9 @@ describe('withSentry', () => {
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => response,
);
expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content matches
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});

test('flushes the event after the handler is done using the cloudflare context.waitUntil', async () => {
Expand All@@ -48,6 +50,25 @@ describe('withSentry', () => {
expect(waitUntilSpy).toHaveBeenLastCalledWith(expect.any(Promise));
});

test('handles streaming responses correctly', async () => {
const stream = new ReadableStream({
start(controller) {
controller.enqueue(new TextEncoder().encode('chunk1'));
controller.enqueue(new TextEncoder().encode('chunk2'));
controller.close();
},
});
const streamingResponse = new Response(stream);

const result = await wrapRequestHandler(
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => streamingResponse,
);

const text = await result.text();
expect(text).toBe('chunk1chunk2');
});

test("doesn't error if context is undefined", () => {
expect(() =>
wrapRequestHandler(
Expand All@@ -69,11 +90,18 @@ describe('withSentry', () => {
});

test('flush must be called when all waitUntil are done', async () => {
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flushSpy = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flushSpy.mock.calls.length;

const waits: Promise<unknown>[] = [];
const waitUntil = vi.fn(promise => waits.push(promise));

Expand All@@ -83,13 +111,20 @@ describe('withSentry', () => {

await wrapRequestHandler({ options: MOCK_OPTIONS, request: new Request('https://example.com'), context }, () => {
addDelayedWaitUntil(context);
return new Response('test');
const response = new Response('test');
// Add Content-Length to skip probing
response.headers.set('content-length', '4');
return response;
});
expect(flush).not.toBeCalled();
expect(waitUntil).toBeCalled();
vi.advanceTimersToNextTimerAsync().then(() => vi.runAllTimers());
vi.advanceTimersToNextTimer().runAllTimers();
await Promise.all(waits);
expect(flush).toHaveBeenCalledOnce();

const after = flushSpy.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('scope instrumentation', () => {
Expand DownExpand Up@@ -303,6 +338,9 @@ describe('withSentry', () => {
},
);

// Wait for async span end and transaction capture
await new Promise(resolve => setTimeout(resolve, 50));

expect(sentryEvent.transaction).toEqual('GET /');
expect(sentryEvent.spans).toHaveLength(0);
expect(sentryEvent.contexts?.trace).toEqual({
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
87 changes: 67 additions & 20 deletions packages/cloudflare/src/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,13 +8,14 @@ import {
parseStringToURLObject,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
setHttpStatus,
startSpan,
startSpanManual,
winterCGHeadersToDict,
withIsolationScope,
} from '@sentry/core';
import type { CloudflareOptions } from './client';
import { addCloudResourceContext, addCultureContext, addRequest } from './scope-utils';
import { init } from './sdk';
import { classifyResponseStreaming } from './utils/streaming';

interface RequestHandlerWrapperOptions {
options: CloudflareOptions;
Expand DownExpand Up@@ -97,30 +98,76 @@ export function wrapRequestHandler(
// Note: This span will not have a duration unless I/O happens in the handler. This is
// because of how the cloudflare workers runtime works.
// See: https://developers.cloudflare.com/workers/runtime-apis/performance/
return startSpan(
{
name,
attributes,
},
async span => {

// Use startSpanManual to control when span ends (needed for streaming responses)
return startSpanManual({ name, attributes }, async span => {
let res: Response;

try {
res = await handler();
setHttpStatus(span, res.status);

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
} catch (e) {
span.end();
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
waitUntil?.(flush(2000));
throw e;
}

// Classify response to detect actual streaming
const classification = classifyResponseStreaming(res);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: what happens if we mis-classify a non-streaming response as a stream response? Would we break anything with creating the stream readers?

I guess the other way around isn't "dangerous", given we'd just end the span too early, correct?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so for false positives (non-streaming → classified as streaming) functionality wise it won't break anything, the only downside is slightly more overhead (creating an unnecessary stream monitor), and for false negatives yes you're correct, it would end span too early, but that's our best guess for now


if (classification.isStreaming && res.body) {
// Streaming response detected - monitor consumption to keep span alive
try {
const res = await handler();
setHttpStatus(span, res.status);
const [clientStream, monitorStream] = res.body.tee();

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
return res;
// Monitor stream consumption and end span when complete
const streamMonitor = (async () => {
const reader = monitorStream.getReader();

try {
let done = false;
while (!done) {
const result = await reader.read();
done = result.done;
}
} catch {
// Stream error or cancellation - will end span in finally
} finally {
reader.releaseLock();
span.end();
waitUntil?.(flush(2000));
}
})();

// Keep worker alive until stream monitoring completes (otherwise span won't end)
waitUntil?.(streamMonitor);

// Return response with client stream
return new Response(clientStream, {
status: res.status,
statusText: res.statusText,
headers: res.headers,
});
} catch (e) {
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
throw e;
} finally {
// tee() failed (e.g stream already locked) - fall back to non-streaming handling
span.end();
waitUntil?.(flush(2000));
return res;
}
},
);
}

// Non-streaming response - end span immediately and return original
span.end();
waitUntil?.(flush(2000));
return res;
});
},
);
});
Expand Down
41 changes: 41 additions & 0 deletions packages/cloudflare/src/utils/streaming.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
export type StreamingGuess = {
isStreaming: boolean;
};

/**
* Classifies a Response as streaming or non-streaming.
*
* Heuristics:
* - No body → not streaming
* - Known streaming Content-Types → streaming (SSE, NDJSON, JSON streaming)
* - text/plain without Content-Length → streaming (some AI APIs)
* - Otherwise → not streaming (conservative default, including HTML/SSR)
*
* We avoid probing the stream to prevent blocking on transform streams (like injectTraceMetaTags)
* or SSR streams that may not have data ready immediately.
*/
export function classifyResponseStreaming(res: Response): StreamingGuess {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l/nit: Is there a reason why we return the response as well? I don't see any changes being made to it, so could a caller just directly reuse res instead of using the returned response?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I was mutating the res in a previous commit, these are just leftovers 😅

if (!res.body) {
return { isStreaming: false };
}

const contentType = res.headers.get('content-type') ?? '';
const contentLength = res.headers.get('content-length');

// Streaming: Known streaming content types
// - text/event-stream: Server-Sent Events (Vercel AI SDK, real-time APIs)
// - application/x-ndjson, application/ndjson: Newline-delimited JSON
// - application/stream+json: JSON streaming
// - text/plain (without Content-Length): Some AI APIs use this for streaming text
if (
/^text\/event-stream\b/i.test(contentType) ||
/^application\/(x-)?ndjson\b/i.test(contentType) ||
/^application\/stream\+json\b/i.test(contentType) ||
(/^text\/plain\b/i.test(contentType) && !contentLength)
) {
return { isStreaming: true };
}

// Default: treat as non-streaming
return { isStreaming: false };
}
34 changes: 29 additions & 5 deletions packages/cloudflare/test/durableobject.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,11 +116,18 @@ describe('instrumentDurableObjectWithSentry', () => {
});

it('flush performs after all waitUntil promises are finished', async () => {
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flush.mock.calls.length;

const waitUntil = vi.fn();
const testClass = vi.fn(context => ({
fetch: () => {
Expand All@@ -133,12 +140,29 @@ describe('instrumentDurableObjectWithSentry', () => {
waitUntil,
} as unknown as ExecutionContext;
const dObject: any = Reflect.construct(instrumented, [context, {} as any]);
expect(() => dObject.fetch(new Request('https://example.com'))).not.toThrow();
expect(flush).not.toBeCalled();
expect(waitUntil).toHaveBeenCalledOnce();

// Call fetch (don't await yet)
const responsePromise = dObject.fetch(new Request('https://example.com'));

// Advance past classification timeout and get response
vi.advanceTimersByTime(30);
const response = await responsePromise;

// Consume response (triggers span end for buffered responses)
await response.text();

// The flush should now be queued in waitUntil
expect(waitUntil).toHaveBeenCalled();

// Advance to trigger the setTimeout in the handler's waitUntil
vi.advanceTimersToNextTimer();
await Promise.all(waitUntil.mock.calls.map(([p]) => p));
expect(flush).toBeCalled();

const after = flush.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('instrumentPrototypeMethods option', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/cloudflare/test/handler.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,11 @@ describe('withSentry', () => {
createMockExecutionContext(),
);

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result?.status).toBe(response.status);
if (result) {
expect(await result.text()).toBe('test');
}
});

test('merges options from env and callback', async () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/cloudflare/test/pages-plugin.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,8 @@ describe('sentryPagesPlugin', () => {
pluginArgs: MOCK_OPTIONS,
});

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});
});
50 changes: 44 additions & 6 deletions packages/cloudflare/test/request.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,9 @@ describe('withSentry', () => {
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => response,
);
expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content matches
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});

test('flushes the event after the handler is done using the cloudflare context.waitUntil', async () => {
Expand All@@ -48,6 +50,25 @@ describe('withSentry', () => {
expect(waitUntilSpy).toHaveBeenLastCalledWith(expect.any(Promise));
});

test('handles streaming responses correctly', async () => {
const stream = new ReadableStream({
start(controller) {
controller.enqueue(new TextEncoder().encode('chunk1'));
controller.enqueue(new TextEncoder().encode('chunk2'));
controller.close();
},
});
const streamingResponse = new Response(stream);

const result = await wrapRequestHandler(
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => streamingResponse,
);

const text = await result.text();
expect(text).toBe('chunk1chunk2');
});

test("doesn't error if context is undefined", () => {
expect(() =>
wrapRequestHandler(
Expand All@@ -69,11 +90,18 @@ describe('withSentry', () => {
});

test('flush must be called when all waitUntil are done', async () => {
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flushSpy = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flushSpy.mock.calls.length;

const waits: Promise<unknown>[] = [];
const waitUntil = vi.fn(promise => waits.push(promise));

Expand All@@ -83,13 +111,20 @@ describe('withSentry', () => {

await wrapRequestHandler({ options: MOCK_OPTIONS, request: new Request('https://example.com'), context }, () => {
addDelayedWaitUntil(context);
return new Response('test');
const response = new Response('test');
// Add Content-Length to skip probing
response.headers.set('content-length', '4');
return response;
});
expect(flush).not.toBeCalled();
expect(waitUntil).toBeCalled();
vi.advanceTimersToNextTimerAsync().then(() => vi.runAllTimers());
vi.advanceTimersToNextTimer().runAllTimers();
await Promise.all(waits);
expect(flush).toHaveBeenCalledOnce();

const after = flushSpy.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('scope instrumentation', () => {
Expand DownExpand Up@@ -303,6 +338,9 @@ describe('withSentry', () => {
},
);

// Wait for async span end and transaction capture
await new Promise(resolve => setTimeout(resolve, 50));

expect(sentryEvent.transaction).toEqual('GET /');
expect(sentryEvent.spans).toHaveLength(0);
expect(sentryEvent.contexts?.trace).toEqual({
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
87 changes: 67 additions & 20 deletions packages/cloudflare/src/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,13 +8,14 @@ import {
parseStringToURLObject,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
setHttpStatus,
startSpan,
startSpanManual,
winterCGHeadersToDict,
withIsolationScope,
} from '@sentry/core';
import type { CloudflareOptions } from './client';
import { addCloudResourceContext, addCultureContext, addRequest } from './scope-utils';
import { init } from './sdk';
import { classifyResponseStreaming } from './utils/streaming';

interface RequestHandlerWrapperOptions {
options: CloudflareOptions;
Expand DownExpand Up@@ -97,30 +98,76 @@ export function wrapRequestHandler(
// Note: This span will not have a duration unless I/O happens in the handler. This is
// because of how the cloudflare workers runtime works.
// See: https://developers.cloudflare.com/workers/runtime-apis/performance/
return startSpan(
{
name,
attributes,
},
async span => {

// Use startSpanManual to control when span ends (needed for streaming responses)
return startSpanManual({ name, attributes }, async span => {
let res: Response;

try {
res = await handler();
setHttpStatus(span, res.status);

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
} catch (e) {
span.end();
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
waitUntil?.(flush(2000));
throw e;
}

// Classify response to detect actual streaming
const classification = classifyResponseStreaming(res);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: what happens if we mis-classify a non-streaming response as a stream response? Would we break anything with creating the stream readers?

I guess the other way around isn't "dangerous", given we'd just end the span too early, correct?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so for false positives (non-streaming → classified as streaming) functionality wise it won't break anything, the only downside is slightly more overhead (creating an unnecessary stream monitor), and for false negatives yes you're correct, it would end span too early, but that's our best guess for now


if (classification.isStreaming && res.body) {
// Streaming response detected - monitor consumption to keep span alive
try {
const res = await handler();
setHttpStatus(span, res.status);
const [clientStream, monitorStream] = res.body.tee();

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
return res;
// Monitor stream consumption and end span when complete
const streamMonitor = (async () => {
const reader = monitorStream.getReader();

try {
let done = false;
while (!done) {
const result = await reader.read();
done = result.done;
}
} catch {
// Stream error or cancellation - will end span in finally
} finally {
reader.releaseLock();
span.end();
waitUntil?.(flush(2000));
}
})();

// Keep worker alive until stream monitoring completes (otherwise span won't end)
waitUntil?.(streamMonitor);

// Return response with client stream
return new Response(clientStream, {
status: res.status,
statusText: res.statusText,
headers: res.headers,
});
} catch (e) {
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
throw e;
} finally {
// tee() failed (e.g stream already locked) - fall back to non-streaming handling
span.end();
waitUntil?.(flush(2000));
return res;
}
},
);
}

// Non-streaming response - end span immediately and return original
span.end();
waitUntil?.(flush(2000));
return res;
});
},
);
});
Expand Down
41 changes: 41 additions & 0 deletions packages/cloudflare/src/utils/streaming.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
export type StreamingGuess = {
isStreaming: boolean;
};

/**
* Classifies a Response as streaming or non-streaming.
*
* Heuristics:
* - No body → not streaming
* - Known streaming Content-Types → streaming (SSE, NDJSON, JSON streaming)
* - text/plain without Content-Length → streaming (some AI APIs)
* - Otherwise → not streaming (conservative default, including HTML/SSR)
*
* We avoid probing the stream to prevent blocking on transform streams (like injectTraceMetaTags)
* or SSR streams that may not have data ready immediately.
*/
export function classifyResponseStreaming(res: Response): StreamingGuess {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l/nit: Is there a reason why we return the response as well? I don't see any changes being made to it, so could a caller just directly reuse res instead of using the returned response?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I was mutating the res in a previous commit, these are just leftovers 😅

if (!res.body) {
return { isStreaming: false };
}

const contentType = res.headers.get('content-type') ?? '';
const contentLength = res.headers.get('content-length');

// Streaming: Known streaming content types
// - text/event-stream: Server-Sent Events (Vercel AI SDK, real-time APIs)
// - application/x-ndjson, application/ndjson: Newline-delimited JSON
// - application/stream+json: JSON streaming
// - text/plain (without Content-Length): Some AI APIs use this for streaming text
if (
/^text\/event-stream\b/i.test(contentType) ||
/^application\/(x-)?ndjson\b/i.test(contentType) ||
/^application\/stream\+json\b/i.test(contentType) ||
(/^text\/plain\b/i.test(contentType) && !contentLength)
) {
return { isStreaming: true };
}

// Default: treat as non-streaming
return { isStreaming: false };
}
34 changes: 29 additions & 5 deletions packages/cloudflare/test/durableobject.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,11 +116,18 @@ describe('instrumentDurableObjectWithSentry', () => {
});

it('flush performs after all waitUntil promises are finished', async () => {
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flush.mock.calls.length;

const waitUntil = vi.fn();
const testClass = vi.fn(context => ({
fetch: () => {
Expand All@@ -133,12 +140,29 @@ describe('instrumentDurableObjectWithSentry', () => {
waitUntil,
} as unknown as ExecutionContext;
const dObject: any = Reflect.construct(instrumented, [context, {} as any]);
expect(() => dObject.fetch(new Request('https://example.com'))).not.toThrow();
expect(flush).not.toBeCalled();
expect(waitUntil).toHaveBeenCalledOnce();

// Call fetch (don't await yet)
const responsePromise = dObject.fetch(new Request('https://example.com'));

// Advance past classification timeout and get response
vi.advanceTimersByTime(30);
const response = await responsePromise;

// Consume response (triggers span end for buffered responses)
await response.text();

// The flush should now be queued in waitUntil
expect(waitUntil).toHaveBeenCalled();

// Advance to trigger the setTimeout in the handler's waitUntil
vi.advanceTimersToNextTimer();
await Promise.all(waitUntil.mock.calls.map(([p]) => p));
expect(flush).toBeCalled();

const after = flush.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('instrumentPrototypeMethods option', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/cloudflare/test/handler.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,11 @@ describe('withSentry', () => {
createMockExecutionContext(),
);

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result?.status).toBe(response.status);
if (result) {
expect(await result.text()).toBe('test');
}
});

test('merges options from env and callback', async () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/cloudflare/test/pages-plugin.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,8 @@ describe('sentryPagesPlugin', () => {
pluginArgs: MOCK_OPTIONS,
});

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});
});
50 changes: 44 additions & 6 deletions packages/cloudflare/test/request.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,9 @@ describe('withSentry', () => {
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => response,
);
expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content matches
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});

test('flushes the event after the handler is done using the cloudflare context.waitUntil', async () => {
Expand All@@ -48,6 +50,25 @@ describe('withSentry', () => {
expect(waitUntilSpy).toHaveBeenLastCalledWith(expect.any(Promise));
});

test('handles streaming responses correctly', async () => {
const stream = new ReadableStream({
start(controller) {
controller.enqueue(new TextEncoder().encode('chunk1'));
controller.enqueue(new TextEncoder().encode('chunk2'));
controller.close();
},
});
const streamingResponse = new Response(stream);

const result = await wrapRequestHandler(
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => streamingResponse,
);

const text = await result.text();
expect(text).toBe('chunk1chunk2');
});

test("doesn't error if context is undefined", () => {
expect(() =>
wrapRequestHandler(
Expand All@@ -69,11 +90,18 @@ describe('withSentry', () => {
});

test('flush must be called when all waitUntil are done', async () => {
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flushSpy = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flushSpy.mock.calls.length;

const waits: Promise<unknown>[] = [];
const waitUntil = vi.fn(promise => waits.push(promise));

Expand All@@ -83,13 +111,20 @@ describe('withSentry', () => {

await wrapRequestHandler({ options: MOCK_OPTIONS, request: new Request('https://example.com'), context }, () => {
addDelayedWaitUntil(context);
return new Response('test');
const response = new Response('test');
// Add Content-Length to skip probing
response.headers.set('content-length', '4');
return response;
});
expect(flush).not.toBeCalled();
expect(waitUntil).toBeCalled();
vi.advanceTimersToNextTimerAsync().then(() => vi.runAllTimers());
vi.advanceTimersToNextTimer().runAllTimers();
await Promise.all(waits);
expect(flush).toHaveBeenCalledOnce();

const after = flushSpy.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('scope instrumentation', () => {
Expand DownExpand Up@@ -303,6 +338,9 @@ describe('withSentry', () => {
},
);

// Wait for async span end and transaction capture
await new Promise(resolve => setTimeout(resolve, 50));

expect(sentryEvent.transaction).toEqual('GET /');
expect(sentryEvent.spans).toHaveLength(0);
expect(sentryEvent.contexts?.trace).toEqual({
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
87 changes: 67 additions & 20 deletions packages/cloudflare/src/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,13 +8,14 @@ import {
parseStringToURLObject,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
setHttpStatus,
startSpan,
startSpanManual,
winterCGHeadersToDict,
withIsolationScope,
} from '@sentry/core';
import type { CloudflareOptions } from './client';
import { addCloudResourceContext, addCultureContext, addRequest } from './scope-utils';
import { init } from './sdk';
import { classifyResponseStreaming } from './utils/streaming';

interface RequestHandlerWrapperOptions {
options: CloudflareOptions;
Expand DownExpand Up@@ -97,30 +98,76 @@ export function wrapRequestHandler(
// Note: This span will not have a duration unless I/O happens in the handler. This is
// because of how the cloudflare workers runtime works.
// See: https://developers.cloudflare.com/workers/runtime-apis/performance/
return startSpan(
{
name,
attributes,
},
async span => {

// Use startSpanManual to control when span ends (needed for streaming responses)
return startSpanManual({ name, attributes }, async span => {
let res: Response;

try {
res = await handler();
setHttpStatus(span, res.status);

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
} catch (e) {
span.end();
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
waitUntil?.(flush(2000));
throw e;
}

// Classify response to detect actual streaming
const classification = classifyResponseStreaming(res);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: what happens if we mis-classify a non-streaming response as a stream response? Would we break anything with creating the stream readers?

I guess the other way around isn't "dangerous", given we'd just end the span too early, correct?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so for false positives (non-streaming → classified as streaming) functionality wise it won't break anything, the only downside is slightly more overhead (creating an unnecessary stream monitor), and for false negatives yes you're correct, it would end span too early, but that's our best guess for now


if (classification.isStreaming && res.body) {
// Streaming response detected - monitor consumption to keep span alive
try {
const res = await handler();
setHttpStatus(span, res.status);
const [clientStream, monitorStream] = res.body.tee();

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
return res;
// Monitor stream consumption and end span when complete
const streamMonitor = (async () => {
const reader = monitorStream.getReader();

try {
let done = false;
while (!done) {
const result = await reader.read();
done = result.done;
}
} catch {
// Stream error or cancellation - will end span in finally
} finally {
reader.releaseLock();
span.end();
waitUntil?.(flush(2000));
}
})();

// Keep worker alive until stream monitoring completes (otherwise span won't end)
waitUntil?.(streamMonitor);

// Return response with client stream
return new Response(clientStream, {
status: res.status,
statusText: res.statusText,
headers: res.headers,
});
} catch (e) {
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
throw e;
} finally {
// tee() failed (e.g stream already locked) - fall back to non-streaming handling
span.end();
waitUntil?.(flush(2000));
return res;
}
},
);
}

// Non-streaming response - end span immediately and return original
span.end();
waitUntil?.(flush(2000));
return res;
});
},
);
});
Expand Down
41 changes: 41 additions & 0 deletions packages/cloudflare/src/utils/streaming.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
export type StreamingGuess = {
isStreaming: boolean;
};

/**
* Classifies a Response as streaming or non-streaming.
*
* Heuristics:
* - No body → not streaming
* - Known streaming Content-Types → streaming (SSE, NDJSON, JSON streaming)
* - text/plain without Content-Length → streaming (some AI APIs)
* - Otherwise → not streaming (conservative default, including HTML/SSR)
*
* We avoid probing the stream to prevent blocking on transform streams (like injectTraceMetaTags)
* or SSR streams that may not have data ready immediately.
*/
export function classifyResponseStreaming(res: Response): StreamingGuess {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l/nit: Is there a reason why we return the response as well? I don't see any changes being made to it, so could a caller just directly reuse res instead of using the returned response?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I was mutating the res in a previous commit, these are just leftovers 😅

if (!res.body) {
return { isStreaming: false };
}

const contentType = res.headers.get('content-type') ?? '';
const contentLength = res.headers.get('content-length');

// Streaming: Known streaming content types
// - text/event-stream: Server-Sent Events (Vercel AI SDK, real-time APIs)
// - application/x-ndjson, application/ndjson: Newline-delimited JSON
// - application/stream+json: JSON streaming
// - text/plain (without Content-Length): Some AI APIs use this for streaming text
if (
/^text\/event-stream\b/i.test(contentType) ||
/^application\/(x-)?ndjson\b/i.test(contentType) ||
/^application\/stream\+json\b/i.test(contentType) ||
(/^text\/plain\b/i.test(contentType) && !contentLength)
) {
return { isStreaming: true };
}

// Default: treat as non-streaming
return { isStreaming: false };
}
34 changes: 29 additions & 5 deletions packages/cloudflare/test/durableobject.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,11 +116,18 @@ describe('instrumentDurableObjectWithSentry', () => {
});

it('flush performs after all waitUntil promises are finished', async () => {
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flush.mock.calls.length;

const waitUntil = vi.fn();
const testClass = vi.fn(context => ({
fetch: () => {
Expand All@@ -133,12 +140,29 @@ describe('instrumentDurableObjectWithSentry', () => {
waitUntil,
} as unknown as ExecutionContext;
const dObject: any = Reflect.construct(instrumented, [context, {} as any]);
expect(() => dObject.fetch(new Request('https://example.com'))).not.toThrow();
expect(flush).not.toBeCalled();
expect(waitUntil).toHaveBeenCalledOnce();

// Call fetch (don't await yet)
const responsePromise = dObject.fetch(new Request('https://example.com'));

// Advance past classification timeout and get response
vi.advanceTimersByTime(30);
const response = await responsePromise;

// Consume response (triggers span end for buffered responses)
await response.text();

// The flush should now be queued in waitUntil
expect(waitUntil).toHaveBeenCalled();

// Advance to trigger the setTimeout in the handler's waitUntil
vi.advanceTimersToNextTimer();
await Promise.all(waitUntil.mock.calls.map(([p]) => p));
expect(flush).toBeCalled();

const after = flush.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('instrumentPrototypeMethods option', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/cloudflare/test/handler.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,11 @@ describe('withSentry', () => {
createMockExecutionContext(),
);

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result?.status).toBe(response.status);
if (result) {
expect(await result.text()).toBe('test');
}
});

test('merges options from env and callback', async () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/cloudflare/test/pages-plugin.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,8 @@ describe('sentryPagesPlugin', () => {
pluginArgs: MOCK_OPTIONS,
});

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});
});
50 changes: 44 additions & 6 deletions packages/cloudflare/test/request.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,9 @@ describe('withSentry', () => {
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => response,
);
expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content matches
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});

test('flushes the event after the handler is done using the cloudflare context.waitUntil', async () => {
Expand All@@ -48,6 +50,25 @@ describe('withSentry', () => {
expect(waitUntilSpy).toHaveBeenLastCalledWith(expect.any(Promise));
});

test('handles streaming responses correctly', async () => {
const stream = new ReadableStream({
start(controller) {
controller.enqueue(new TextEncoder().encode('chunk1'));
controller.enqueue(new TextEncoder().encode('chunk2'));
controller.close();
},
});
const streamingResponse = new Response(stream);

const result = await wrapRequestHandler(
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => streamingResponse,
);

const text = await result.text();
expect(text).toBe('chunk1chunk2');
});

test("doesn't error if context is undefined", () => {
expect(() =>
wrapRequestHandler(
Expand All@@ -69,11 +90,18 @@ describe('withSentry', () => {
});

test('flush must be called when all waitUntil are done', async () => {
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flushSpy = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flushSpy.mock.calls.length;

const waits: Promise<unknown>[] = [];
const waitUntil = vi.fn(promise => waits.push(promise));

Expand All@@ -83,13 +111,20 @@ describe('withSentry', () => {

await wrapRequestHandler({ options: MOCK_OPTIONS, request: new Request('https://example.com'), context }, () => {
addDelayedWaitUntil(context);
return new Response('test');
const response = new Response('test');
// Add Content-Length to skip probing
response.headers.set('content-length', '4');
return response;
});
expect(flush).not.toBeCalled();
expect(waitUntil).toBeCalled();
vi.advanceTimersToNextTimerAsync().then(() => vi.runAllTimers());
vi.advanceTimersToNextTimer().runAllTimers();
await Promise.all(waits);
expect(flush).toHaveBeenCalledOnce();

const after = flushSpy.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('scope instrumentation', () => {
Expand DownExpand Up@@ -303,6 +338,9 @@ describe('withSentry', () => {
},
);

// Wait for async span end and transaction capture
await new Promise(resolve => setTimeout(resolve, 50));

expect(sentryEvent.transaction).toEqual('GET /');
expect(sentryEvent.spans).toHaveLength(0);
expect(sentryEvent.contexts?.trace).toEqual({
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
87 changes: 67 additions & 20 deletions packages/cloudflare/src/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,13 +8,14 @@ import {
parseStringToURLObject,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
setHttpStatus,
startSpan,
startSpanManual,
winterCGHeadersToDict,
withIsolationScope,
} from '@sentry/core';
import type { CloudflareOptions } from './client';
import { addCloudResourceContext, addCultureContext, addRequest } from './scope-utils';
import { init } from './sdk';
import { classifyResponseStreaming } from './utils/streaming';

interface RequestHandlerWrapperOptions {
options: CloudflareOptions;
Expand DownExpand Up@@ -97,30 +98,76 @@ export function wrapRequestHandler(
// Note: This span will not have a duration unless I/O happens in the handler. This is
// because of how the cloudflare workers runtime works.
// See: https://developers.cloudflare.com/workers/runtime-apis/performance/
return startSpan(
{
name,
attributes,
},
async span => {

// Use startSpanManual to control when span ends (needed for streaming responses)
return startSpanManual({ name, attributes }, async span => {
let res: Response;

try {
res = await handler();
setHttpStatus(span, res.status);

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
} catch (e) {
span.end();
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
waitUntil?.(flush(2000));
throw e;
}

// Classify response to detect actual streaming
const classification = classifyResponseStreaming(res);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: what happens if we mis-classify a non-streaming response as a stream response? Would we break anything with creating the stream readers?

I guess the other way around isn't "dangerous", given we'd just end the span too early, correct?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so for false positives (non-streaming → classified as streaming) functionality wise it won't break anything, the only downside is slightly more overhead (creating an unnecessary stream monitor), and for false negatives yes you're correct, it would end span too early, but that's our best guess for now


if (classification.isStreaming && res.body) {
// Streaming response detected - monitor consumption to keep span alive
try {
const res = await handler();
setHttpStatus(span, res.status);
const [clientStream, monitorStream] = res.body.tee();

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
return res;
// Monitor stream consumption and end span when complete
const streamMonitor = (async () => {
const reader = monitorStream.getReader();

try {
let done = false;
while (!done) {
const result = await reader.read();
done = result.done;
}
} catch {
// Stream error or cancellation - will end span in finally
} finally {
reader.releaseLock();
span.end();
waitUntil?.(flush(2000));
}
})();

// Keep worker alive until stream monitoring completes (otherwise span won't end)
waitUntil?.(streamMonitor);

// Return response with client stream
return new Response(clientStream, {
status: res.status,
statusText: res.statusText,
headers: res.headers,
});
} catch (e) {
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
throw e;
} finally {
// tee() failed (e.g stream already locked) - fall back to non-streaming handling
span.end();
waitUntil?.(flush(2000));
return res;
}
},
);
}

// Non-streaming response - end span immediately and return original
span.end();
waitUntil?.(flush(2000));
return res;
});
},
);
});
Expand Down
41 changes: 41 additions & 0 deletions packages/cloudflare/src/utils/streaming.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
export type StreamingGuess = {
isStreaming: boolean;
};

/**
* Classifies a Response as streaming or non-streaming.
*
* Heuristics:
* - No body → not streaming
* - Known streaming Content-Types → streaming (SSE, NDJSON, JSON streaming)
* - text/plain without Content-Length → streaming (some AI APIs)
* - Otherwise → not streaming (conservative default, including HTML/SSR)
*
* We avoid probing the stream to prevent blocking on transform streams (like injectTraceMetaTags)
* or SSR streams that may not have data ready immediately.
*/
export function classifyResponseStreaming(res: Response): StreamingGuess {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l/nit: Is there a reason why we return the response as well? I don't see any changes being made to it, so could a caller just directly reuse res instead of using the returned response?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I was mutating the res in a previous commit, these are just leftovers 😅

if (!res.body) {
return { isStreaming: false };
}

const contentType = res.headers.get('content-type') ?? '';
const contentLength = res.headers.get('content-length');

// Streaming: Known streaming content types
// - text/event-stream: Server-Sent Events (Vercel AI SDK, real-time APIs)
// - application/x-ndjson, application/ndjson: Newline-delimited JSON
// - application/stream+json: JSON streaming
// - text/plain (without Content-Length): Some AI APIs use this for streaming text
if (
/^text\/event-stream\b/i.test(contentType) ||
/^application\/(x-)?ndjson\b/i.test(contentType) ||
/^application\/stream\+json\b/i.test(contentType) ||
(/^text\/plain\b/i.test(contentType) && !contentLength)
) {
return { isStreaming: true };
}

// Default: treat as non-streaming
return { isStreaming: false };
}
34 changes: 29 additions & 5 deletions packages/cloudflare/test/durableobject.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,11 +116,18 @@ describe('instrumentDurableObjectWithSentry', () => {
});

it('flush performs after all waitUntil promises are finished', async () => {
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flush.mock.calls.length;

const waitUntil = vi.fn();
const testClass = vi.fn(context => ({
fetch: () => {
Expand All@@ -133,12 +140,29 @@ describe('instrumentDurableObjectWithSentry', () => {
waitUntil,
} as unknown as ExecutionContext;
const dObject: any = Reflect.construct(instrumented, [context, {} as any]);
expect(() => dObject.fetch(new Request('https://example.com'))).not.toThrow();
expect(flush).not.toBeCalled();
expect(waitUntil).toHaveBeenCalledOnce();

// Call fetch (don't await yet)
const responsePromise = dObject.fetch(new Request('https://example.com'));

// Advance past classification timeout and get response
vi.advanceTimersByTime(30);
const response = await responsePromise;

// Consume response (triggers span end for buffered responses)
await response.text();

// The flush should now be queued in waitUntil
expect(waitUntil).toHaveBeenCalled();

// Advance to trigger the setTimeout in the handler's waitUntil
vi.advanceTimersToNextTimer();
await Promise.all(waitUntil.mock.calls.map(([p]) => p));
expect(flush).toBeCalled();

const after = flush.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('instrumentPrototypeMethods option', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/cloudflare/test/handler.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,11 @@ describe('withSentry', () => {
createMockExecutionContext(),
);

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result?.status).toBe(response.status);
if (result) {
expect(await result.text()).toBe('test');
}
});

test('merges options from env and callback', async () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/cloudflare/test/pages-plugin.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,8 @@ describe('sentryPagesPlugin', () => {
pluginArgs: MOCK_OPTIONS,
});

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});
});
50 changes: 44 additions & 6 deletions packages/cloudflare/test/request.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,9 @@ describe('withSentry', () => {
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => response,
);
expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content matches
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});

test('flushes the event after the handler is done using the cloudflare context.waitUntil', async () => {
Expand All@@ -48,6 +50,25 @@ describe('withSentry', () => {
expect(waitUntilSpy).toHaveBeenLastCalledWith(expect.any(Promise));
});

test('handles streaming responses correctly', async () => {
const stream = new ReadableStream({
start(controller) {
controller.enqueue(new TextEncoder().encode('chunk1'));
controller.enqueue(new TextEncoder().encode('chunk2'));
controller.close();
},
});
const streamingResponse = new Response(stream);

const result = await wrapRequestHandler(
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => streamingResponse,
);

const text = await result.text();
expect(text).toBe('chunk1chunk2');
});

test("doesn't error if context is undefined", () => {
expect(() =>
wrapRequestHandler(
Expand All@@ -69,11 +90,18 @@ describe('withSentry', () => {
});

test('flush must be called when all waitUntil are done', async () => {
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flushSpy = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flushSpy.mock.calls.length;

const waits: Promise<unknown>[] = [];
const waitUntil = vi.fn(promise => waits.push(promise));

Expand All@@ -83,13 +111,20 @@ describe('withSentry', () => {

await wrapRequestHandler({ options: MOCK_OPTIONS, request: new Request('https://example.com'), context }, () => {
addDelayedWaitUntil(context);
return new Response('test');
const response = new Response('test');
// Add Content-Length to skip probing
response.headers.set('content-length', '4');
return response;
});
expect(flush).not.toBeCalled();
expect(waitUntil).toBeCalled();
vi.advanceTimersToNextTimerAsync().then(() => vi.runAllTimers());
vi.advanceTimersToNextTimer().runAllTimers();
await Promise.all(waits);
expect(flush).toHaveBeenCalledOnce();

const after = flushSpy.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('scope instrumentation', () => {
Expand DownExpand Up@@ -303,6 +338,9 @@ describe('withSentry', () => {
},
);

// Wait for async span end and transaction capture
await new Promise(resolve => setTimeout(resolve, 50));

expect(sentryEvent.transaction).toEqual('GET /');
expect(sentryEvent.spans).toHaveLength(0);
expect(sentryEvent.contexts?.trace).toEqual({
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
87 changes: 67 additions & 20 deletions packages/cloudflare/src/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,13 +8,14 @@ import {
parseStringToURLObject,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
setHttpStatus,
startSpan,
startSpanManual,
winterCGHeadersToDict,
withIsolationScope,
} from '@sentry/core';
import type { CloudflareOptions } from './client';
import { addCloudResourceContext, addCultureContext, addRequest } from './scope-utils';
import { init } from './sdk';
import { classifyResponseStreaming } from './utils/streaming';

interface RequestHandlerWrapperOptions {
options: CloudflareOptions;
Expand DownExpand Up@@ -97,30 +98,76 @@ export function wrapRequestHandler(
// Note: This span will not have a duration unless I/O happens in the handler. This is
// because of how the cloudflare workers runtime works.
// See: https://developers.cloudflare.com/workers/runtime-apis/performance/
return startSpan(
{
name,
attributes,
},
async span => {

// Use startSpanManual to control when span ends (needed for streaming responses)
return startSpanManual({ name, attributes }, async span => {
let res: Response;

try {
res = await handler();
setHttpStatus(span, res.status);

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
} catch (e) {
span.end();
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
waitUntil?.(flush(2000));
throw e;
}

// Classify response to detect actual streaming
const classification = classifyResponseStreaming(res);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: what happens if we mis-classify a non-streaming response as a stream response? Would we break anything with creating the stream readers?

I guess the other way around isn't "dangerous", given we'd just end the span too early, correct?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so for false positives (non-streaming → classified as streaming) functionality wise it won't break anything, the only downside is slightly more overhead (creating an unnecessary stream monitor), and for false negatives yes you're correct, it would end span too early, but that's our best guess for now


if (classification.isStreaming && res.body) {
// Streaming response detected - monitor consumption to keep span alive
try {
const res = await handler();
setHttpStatus(span, res.status);
const [clientStream, monitorStream] = res.body.tee();

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
return res;
// Monitor stream consumption and end span when complete
const streamMonitor = (async () => {
const reader = monitorStream.getReader();

try {
let done = false;
while (!done) {
const result = await reader.read();
done = result.done;
}
} catch {
// Stream error or cancellation - will end span in finally
} finally {
reader.releaseLock();
span.end();
waitUntil?.(flush(2000));
}
})();

// Keep worker alive until stream monitoring completes (otherwise span won't end)
waitUntil?.(streamMonitor);

// Return response with client stream
return new Response(clientStream, {
status: res.status,
statusText: res.statusText,
headers: res.headers,
});
} catch (e) {
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
throw e;
} finally {
// tee() failed (e.g stream already locked) - fall back to non-streaming handling
span.end();
waitUntil?.(flush(2000));
return res;
}
},
);
}

// Non-streaming response - end span immediately and return original
span.end();
waitUntil?.(flush(2000));
return res;
});
},
);
});
Expand Down
41 changes: 41 additions & 0 deletions packages/cloudflare/src/utils/streaming.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
export type StreamingGuess = {
isStreaming: boolean;
};

/**
* Classifies a Response as streaming or non-streaming.
*
* Heuristics:
* - No body → not streaming
* - Known streaming Content-Types → streaming (SSE, NDJSON, JSON streaming)
* - text/plain without Content-Length → streaming (some AI APIs)
* - Otherwise → not streaming (conservative default, including HTML/SSR)
*
* We avoid probing the stream to prevent blocking on transform streams (like injectTraceMetaTags)
* or SSR streams that may not have data ready immediately.
*/
export function classifyResponseStreaming(res: Response): StreamingGuess {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l/nit: Is there a reason why we return the response as well? I don't see any changes being made to it, so could a caller just directly reuse res instead of using the returned response?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I was mutating the res in a previous commit, these are just leftovers 😅

if (!res.body) {
return { isStreaming: false };
}

const contentType = res.headers.get('content-type') ?? '';
const contentLength = res.headers.get('content-length');

// Streaming: Known streaming content types
// - text/event-stream: Server-Sent Events (Vercel AI SDK, real-time APIs)
// - application/x-ndjson, application/ndjson: Newline-delimited JSON
// - application/stream+json: JSON streaming
// - text/plain (without Content-Length): Some AI APIs use this for streaming text
if (
/^text\/event-stream\b/i.test(contentType) ||
/^application\/(x-)?ndjson\b/i.test(contentType) ||
/^application\/stream\+json\b/i.test(contentType) ||
(/^text\/plain\b/i.test(contentType) && !contentLength)
) {
return { isStreaming: true };
}

// Default: treat as non-streaming
return { isStreaming: false };
}
34 changes: 29 additions & 5 deletions packages/cloudflare/test/durableobject.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,11 +116,18 @@ describe('instrumentDurableObjectWithSentry', () => {
});

it('flush performs after all waitUntil promises are finished', async () => {
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flush.mock.calls.length;

const waitUntil = vi.fn();
const testClass = vi.fn(context => ({
fetch: () => {
Expand All@@ -133,12 +140,29 @@ describe('instrumentDurableObjectWithSentry', () => {
waitUntil,
} as unknown as ExecutionContext;
const dObject: any = Reflect.construct(instrumented, [context, {} as any]);
expect(() => dObject.fetch(new Request('https://example.com'))).not.toThrow();
expect(flush).not.toBeCalled();
expect(waitUntil).toHaveBeenCalledOnce();

// Call fetch (don't await yet)
const responsePromise = dObject.fetch(new Request('https://example.com'));

// Advance past classification timeout and get response
vi.advanceTimersByTime(30);
const response = await responsePromise;

// Consume response (triggers span end for buffered responses)
await response.text();

// The flush should now be queued in waitUntil
expect(waitUntil).toHaveBeenCalled();

// Advance to trigger the setTimeout in the handler's waitUntil
vi.advanceTimersToNextTimer();
await Promise.all(waitUntil.mock.calls.map(([p]) => p));
expect(flush).toBeCalled();

const after = flush.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('instrumentPrototypeMethods option', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/cloudflare/test/handler.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,11 @@ describe('withSentry', () => {
createMockExecutionContext(),
);

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result?.status).toBe(response.status);
if (result) {
expect(await result.text()).toBe('test');
}
});

test('merges options from env and callback', async () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/cloudflare/test/pages-plugin.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,8 @@ describe('sentryPagesPlugin', () => {
pluginArgs: MOCK_OPTIONS,
});

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});
});
50 changes: 44 additions & 6 deletions packages/cloudflare/test/request.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,9 @@ describe('withSentry', () => {
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => response,
);
expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content matches
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});

test('flushes the event after the handler is done using the cloudflare context.waitUntil', async () => {
Expand All@@ -48,6 +50,25 @@ describe('withSentry', () => {
expect(waitUntilSpy).toHaveBeenLastCalledWith(expect.any(Promise));
});

test('handles streaming responses correctly', async () => {
const stream = new ReadableStream({
start(controller) {
controller.enqueue(new TextEncoder().encode('chunk1'));
controller.enqueue(new TextEncoder().encode('chunk2'));
controller.close();
},
});
const streamingResponse = new Response(stream);

const result = await wrapRequestHandler(
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => streamingResponse,
);

const text = await result.text();
expect(text).toBe('chunk1chunk2');
});

test("doesn't error if context is undefined", () => {
expect(() =>
wrapRequestHandler(
Expand All@@ -69,11 +90,18 @@ describe('withSentry', () => {
});

test('flush must be called when all waitUntil are done', async () => {
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flushSpy = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flushSpy.mock.calls.length;

const waits: Promise<unknown>[] = [];
const waitUntil = vi.fn(promise => waits.push(promise));

Expand All@@ -83,13 +111,20 @@ describe('withSentry', () => {

await wrapRequestHandler({ options: MOCK_OPTIONS, request: new Request('https://example.com'), context }, () => {
addDelayedWaitUntil(context);
return new Response('test');
const response = new Response('test');
// Add Content-Length to skip probing
response.headers.set('content-length', '4');
return response;
});
expect(flush).not.toBeCalled();
expect(waitUntil).toBeCalled();
vi.advanceTimersToNextTimerAsync().then(() => vi.runAllTimers());
vi.advanceTimersToNextTimer().runAllTimers();
await Promise.all(waits);
expect(flush).toHaveBeenCalledOnce();

const after = flushSpy.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('scope instrumentation', () => {
Expand DownExpand Up@@ -303,6 +338,9 @@ describe('withSentry', () => {
},
);

// Wait for async span end and transaction capture
await new Promise(resolve => setTimeout(resolve, 50));

expect(sentryEvent.transaction).toEqual('GET /');
expect(sentryEvent.spans).toHaveLength(0);
expect(sentryEvent.contexts?.trace).toEqual({
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
87 changes: 67 additions & 20 deletions packages/cloudflare/src/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,13 +8,14 @@ import {
parseStringToURLObject,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
setHttpStatus,
startSpan,
startSpanManual,
winterCGHeadersToDict,
withIsolationScope,
} from '@sentry/core';
import type { CloudflareOptions } from './client';
import { addCloudResourceContext, addCultureContext, addRequest } from './scope-utils';
import { init } from './sdk';
import { classifyResponseStreaming } from './utils/streaming';

interface RequestHandlerWrapperOptions {
options: CloudflareOptions;
Expand DownExpand Up@@ -97,30 +98,76 @@ export function wrapRequestHandler(
// Note: This span will not have a duration unless I/O happens in the handler. This is
// because of how the cloudflare workers runtime works.
// See: https://developers.cloudflare.com/workers/runtime-apis/performance/
return startSpan(
{
name,
attributes,
},
async span => {

// Use startSpanManual to control when span ends (needed for streaming responses)
return startSpanManual({ name, attributes }, async span => {
let res: Response;

try {
res = await handler();
setHttpStatus(span, res.status);

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
} catch (e) {
span.end();
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
waitUntil?.(flush(2000));
throw e;
}

// Classify response to detect actual streaming
const classification = classifyResponseStreaming(res);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: what happens if we mis-classify a non-streaming response as a stream response? Would we break anything with creating the stream readers?

I guess the other way around isn't "dangerous", given we'd just end the span too early, correct?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so for false positives (non-streaming → classified as streaming) functionality wise it won't break anything, the only downside is slightly more overhead (creating an unnecessary stream monitor), and for false negatives yes you're correct, it would end span too early, but that's our best guess for now


if (classification.isStreaming && res.body) {
// Streaming response detected - monitor consumption to keep span alive
try {
const res = await handler();
setHttpStatus(span, res.status);
const [clientStream, monitorStream] = res.body.tee();

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
return res;
// Monitor stream consumption and end span when complete
const streamMonitor = (async () => {
const reader = monitorStream.getReader();

try {
let done = false;
while (!done) {
const result = await reader.read();
done = result.done;
}
} catch {
// Stream error or cancellation - will end span in finally
} finally {
reader.releaseLock();
span.end();
waitUntil?.(flush(2000));
}
})();

// Keep worker alive until stream monitoring completes (otherwise span won't end)
waitUntil?.(streamMonitor);

// Return response with client stream
return new Response(clientStream, {
status: res.status,
statusText: res.statusText,
headers: res.headers,
});
} catch (e) {
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
throw e;
} finally {
// tee() failed (e.g stream already locked) - fall back to non-streaming handling
span.end();
waitUntil?.(flush(2000));
return res;
}
},
);
}

// Non-streaming response - end span immediately and return original
span.end();
waitUntil?.(flush(2000));
return res;
});
},
);
});
Expand Down
41 changes: 41 additions & 0 deletions packages/cloudflare/src/utils/streaming.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
export type StreamingGuess = {
isStreaming: boolean;
};

/**
* Classifies a Response as streaming or non-streaming.
*
* Heuristics:
* - No body → not streaming
* - Known streaming Content-Types → streaming (SSE, NDJSON, JSON streaming)
* - text/plain without Content-Length → streaming (some AI APIs)
* - Otherwise → not streaming (conservative default, including HTML/SSR)
*
* We avoid probing the stream to prevent blocking on transform streams (like injectTraceMetaTags)
* or SSR streams that may not have data ready immediately.
*/
export function classifyResponseStreaming(res: Response): StreamingGuess {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l/nit: Is there a reason why we return the response as well? I don't see any changes being made to it, so could a caller just directly reuse res instead of using the returned response?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I was mutating the res in a previous commit, these are just leftovers 😅

if (!res.body) {
return { isStreaming: false };
}

const contentType = res.headers.get('content-type') ?? '';
const contentLength = res.headers.get('content-length');

// Streaming: Known streaming content types
// - text/event-stream: Server-Sent Events (Vercel AI SDK, real-time APIs)
// - application/x-ndjson, application/ndjson: Newline-delimited JSON
// - application/stream+json: JSON streaming
// - text/plain (without Content-Length): Some AI APIs use this for streaming text
if (
/^text\/event-stream\b/i.test(contentType) ||
/^application\/(x-)?ndjson\b/i.test(contentType) ||
/^application\/stream\+json\b/i.test(contentType) ||
(/^text\/plain\b/i.test(contentType) && !contentLength)
) {
return { isStreaming: true };
}

// Default: treat as non-streaming
return { isStreaming: false };
}
34 changes: 29 additions & 5 deletions packages/cloudflare/test/durableobject.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,11 +116,18 @@ describe('instrumentDurableObjectWithSentry', () => {
});

it('flush performs after all waitUntil promises are finished', async () => {
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flush.mock.calls.length;

const waitUntil = vi.fn();
const testClass = vi.fn(context => ({
fetch: () => {
Expand All@@ -133,12 +140,29 @@ describe('instrumentDurableObjectWithSentry', () => {
waitUntil,
} as unknown as ExecutionContext;
const dObject: any = Reflect.construct(instrumented, [context, {} as any]);
expect(() => dObject.fetch(new Request('https://example.com'))).not.toThrow();
expect(flush).not.toBeCalled();
expect(waitUntil).toHaveBeenCalledOnce();

// Call fetch (don't await yet)
const responsePromise = dObject.fetch(new Request('https://example.com'));

// Advance past classification timeout and get response
vi.advanceTimersByTime(30);
const response = await responsePromise;

// Consume response (triggers span end for buffered responses)
await response.text();

// The flush should now be queued in waitUntil
expect(waitUntil).toHaveBeenCalled();

// Advance to trigger the setTimeout in the handler's waitUntil
vi.advanceTimersToNextTimer();
await Promise.all(waitUntil.mock.calls.map(([p]) => p));
expect(flush).toBeCalled();

const after = flush.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('instrumentPrototypeMethods option', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/cloudflare/test/handler.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,11 @@ describe('withSentry', () => {
createMockExecutionContext(),
);

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result?.status).toBe(response.status);
if (result) {
expect(await result.text()).toBe('test');
}
});

test('merges options from env and callback', async () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/cloudflare/test/pages-plugin.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,8 @@ describe('sentryPagesPlugin', () => {
pluginArgs: MOCK_OPTIONS,
});

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});
});
50 changes: 44 additions & 6 deletions packages/cloudflare/test/request.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,9 @@ describe('withSentry', () => {
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => response,
);
expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content matches
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});

test('flushes the event after the handler is done using the cloudflare context.waitUntil', async () => {
Expand All@@ -48,6 +50,25 @@ describe('withSentry', () => {
expect(waitUntilSpy).toHaveBeenLastCalledWith(expect.any(Promise));
});

test('handles streaming responses correctly', async () => {
const stream = new ReadableStream({
start(controller) {
controller.enqueue(new TextEncoder().encode('chunk1'));
controller.enqueue(new TextEncoder().encode('chunk2'));
controller.close();
},
});
const streamingResponse = new Response(stream);

const result = await wrapRequestHandler(
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => streamingResponse,
);

const text = await result.text();
expect(text).toBe('chunk1chunk2');
});

test("doesn't error if context is undefined", () => {
expect(() =>
wrapRequestHandler(
Expand All@@ -69,11 +90,18 @@ describe('withSentry', () => {
});

test('flush must be called when all waitUntil are done', async () => {
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flushSpy = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flushSpy.mock.calls.length;

const waits: Promise<unknown>[] = [];
const waitUntil = vi.fn(promise => waits.push(promise));

Expand All@@ -83,13 +111,20 @@ describe('withSentry', () => {

await wrapRequestHandler({ options: MOCK_OPTIONS, request: new Request('https://example.com'), context }, () => {
addDelayedWaitUntil(context);
return new Response('test');
const response = new Response('test');
// Add Content-Length to skip probing
response.headers.set('content-length', '4');
return response;
});
expect(flush).not.toBeCalled();
expect(waitUntil).toBeCalled();
vi.advanceTimersToNextTimerAsync().then(() => vi.runAllTimers());
vi.advanceTimersToNextTimer().runAllTimers();
await Promise.all(waits);
expect(flush).toHaveBeenCalledOnce();

const after = flushSpy.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('scope instrumentation', () => {
Expand DownExpand Up@@ -303,6 +338,9 @@ describe('withSentry', () => {
},
);

// Wait for async span end and transaction capture
await new Promise(resolve => setTimeout(resolve, 50));

expect(sentryEvent.transaction).toEqual('GET /');
expect(sentryEvent.spans).toHaveLength(0);
expect(sentryEvent.contexts?.trace).toEqual({
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
87 changes: 67 additions & 20 deletions packages/cloudflare/src/request.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,13 +8,14 @@ import {
parseStringToURLObject,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
setHttpStatus,
startSpan,
startSpanManual,
winterCGHeadersToDict,
withIsolationScope,
} from '@sentry/core';
import type { CloudflareOptions } from './client';
import { addCloudResourceContext, addCultureContext, addRequest } from './scope-utils';
import { init } from './sdk';
import { classifyResponseStreaming } from './utils/streaming';

interface RequestHandlerWrapperOptions {
options: CloudflareOptions;
Expand DownExpand Up@@ -97,30 +98,76 @@ export function wrapRequestHandler(
// Note: This span will not have a duration unless I/O happens in the handler. This is
// because of how the cloudflare workers runtime works.
// See: https://developers.cloudflare.com/workers/runtime-apis/performance/
return startSpan(
{
name,
attributes,
},
async span => {

// Use startSpanManual to control when span ends (needed for streaming responses)
return startSpanManual({ name, attributes }, async span => {
let res: Response;

try {
res = await handler();
setHttpStatus(span, res.status);

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
} catch (e) {
span.end();
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
waitUntil?.(flush(2000));
throw e;
}

// Classify response to detect actual streaming
const classification = classifyResponseStreaming(res);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: what happens if we mis-classify a non-streaming response as a stream response? Would we break anything with creating the stream readers?

I guess the other way around isn't "dangerous", given we'd just end the span too early, correct?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so for false positives (non-streaming → classified as streaming) functionality wise it won't break anything, the only downside is slightly more overhead (creating an unnecessary stream monitor), and for false negatives yes you're correct, it would end span too early, but that's our best guess for now


if (classification.isStreaming && res.body) {
// Streaming response detected - monitor consumption to keep span alive
try {
const res = await handler();
setHttpStatus(span, res.status);
const [clientStream, monitorStream] = res.body.tee();

// After the handler runs, the span name might have been updated by nested instrumentation
// (e.g., Remix parameterizing routes). The span should already have the correct name
// from that instrumentation, so we don't need to do anything here.
return res;
// Monitor stream consumption and end span when complete
const streamMonitor = (async () => {
const reader = monitorStream.getReader();

try {
let done = false;
while (!done) {
const result = await reader.read();
done = result.done;
}
} catch {
// Stream error or cancellation - will end span in finally
} finally {
reader.releaseLock();
span.end();
waitUntil?.(flush(2000));
}
})();

// Keep worker alive until stream monitoring completes (otherwise span won't end)
waitUntil?.(streamMonitor);

// Return response with client stream
return new Response(clientStream, {
status: res.status,
statusText: res.statusText,
headers: res.headers,
});
} catch (e) {
if (captureErrors) {
captureException(e, { mechanism: { handled: false, type: 'auto.http.cloudflare' } });
}
throw e;
} finally {
// tee() failed (e.g stream already locked) - fall back to non-streaming handling
span.end();
waitUntil?.(flush(2000));
return res;
}
},
);
}

// Non-streaming response - end span immediately and return original
span.end();
waitUntil?.(flush(2000));
return res;
});
},
);
});
Expand Down
41 changes: 41 additions & 0 deletions packages/cloudflare/src/utils/streaming.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
export type StreamingGuess = {
isStreaming: boolean;
};

/**
* Classifies a Response as streaming or non-streaming.
*
* Heuristics:
* - No body → not streaming
* - Known streaming Content-Types → streaming (SSE, NDJSON, JSON streaming)
* - text/plain without Content-Length → streaming (some AI APIs)
* - Otherwise → not streaming (conservative default, including HTML/SSR)
*
* We avoid probing the stream to prevent blocking on transform streams (like injectTraceMetaTags)
* or SSR streams that may not have data ready immediately.
*/
export function classifyResponseStreaming(res: Response): StreamingGuess {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l/nit: Is there a reason why we return the response as well? I don't see any changes being made to it, so could a caller just directly reuse res instead of using the returned response?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I was mutating the res in a previous commit, these are just leftovers 😅

if (!res.body) {
return { isStreaming: false };
}

const contentType = res.headers.get('content-type') ?? '';
const contentLength = res.headers.get('content-length');

// Streaming: Known streaming content types
// - text/event-stream: Server-Sent Events (Vercel AI SDK, real-time APIs)
// - application/x-ndjson, application/ndjson: Newline-delimited JSON
// - application/stream+json: JSON streaming
// - text/plain (without Content-Length): Some AI APIs use this for streaming text
if (
/^text\/event-stream\b/i.test(contentType) ||
/^application\/(x-)?ndjson\b/i.test(contentType) ||
/^application\/stream\+json\b/i.test(contentType) ||
(/^text\/plain\b/i.test(contentType) && !contentLength)
) {
return { isStreaming: true };
}

// Default: treat as non-streaming
return { isStreaming: false };
}
34 changes: 29 additions & 5 deletions packages/cloudflare/test/durableobject.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,11 +116,18 @@ describe('instrumentDurableObjectWithSentry', () => {
});

it('flush performs after all waitUntil promises are finished', async () => {
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flush.mock.calls.length;

const waitUntil = vi.fn();
const testClass = vi.fn(context => ({
fetch: () => {
Expand All@@ -133,12 +140,29 @@ describe('instrumentDurableObjectWithSentry', () => {
waitUntil,
} as unknown as ExecutionContext;
const dObject: any = Reflect.construct(instrumented, [context, {} as any]);
expect(() => dObject.fetch(new Request('https://example.com'))).not.toThrow();
expect(flush).not.toBeCalled();
expect(waitUntil).toHaveBeenCalledOnce();

// Call fetch (don't await yet)
const responsePromise = dObject.fetch(new Request('https://example.com'));

// Advance past classification timeout and get response
vi.advanceTimersByTime(30);
const response = await responsePromise;

// Consume response (triggers span end for buffered responses)
await response.text();

// The flush should now be queued in waitUntil
expect(waitUntil).toHaveBeenCalled();

// Advance to trigger the setTimeout in the handler's waitUntil
vi.advanceTimersToNextTimer();
await Promise.all(waitUntil.mock.calls.map(([p]) => p));
expect(flush).toBeCalled();

const after = flush.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('instrumentPrototypeMethods option', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/cloudflare/test/handler.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,11 @@ describe('withSentry', () => {
createMockExecutionContext(),
);

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result?.status).toBe(response.status);
if (result) {
expect(await result.text()).toBe('test');
}
});

test('merges options from env and callback', async () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/cloudflare/test/pages-plugin.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,8 @@ describe('sentryPagesPlugin', () => {
pluginArgs: MOCK_OPTIONS,
});

expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});
});
50 changes: 44 additions & 6 deletions packages/cloudflare/test/request.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,9 @@ describe('withSentry', () => {
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => response,
);
expect(result).toBe(response);
// Response may be wrapped for streaming detection, verify content matches
expect(result.status).toBe(response.status);
expect(await result.text()).toBe('test');
});

test('flushes the event after the handler is done using the cloudflare context.waitUntil', async () => {
Expand All@@ -48,6 +50,25 @@ describe('withSentry', () => {
expect(waitUntilSpy).toHaveBeenLastCalledWith(expect.any(Promise));
});

test('handles streaming responses correctly', async () => {
const stream = new ReadableStream({
start(controller) {
controller.enqueue(new TextEncoder().encode('chunk1'));
controller.enqueue(new TextEncoder().encode('chunk2'));
controller.close();
},
});
const streamingResponse = new Response(stream);

const result = await wrapRequestHandler(
{ options: MOCK_OPTIONS, request: new Request('https://example.com'), context: createMockExecutionContext() },
() => streamingResponse,
);

const text = await result.text();
expect(text).toBe('chunk1chunk2');
});

test("doesn't error if context is undefined", () => {
expect(() =>
wrapRequestHandler(
Expand All@@ -69,11 +90,18 @@ describe('withSentry', () => {
});

test('flush must be called when all waitUntil are done', async () => {
const flush = vi.spyOn(SentryCore.Client.prototype, 'flush');
// Spy on Client.prototype.flush and mock it to resolve immediately to avoid timeout issues with fake timers
const flushSpy = vi.spyOn(SentryCore.Client.prototype, 'flush').mockResolvedValue(true);
vi.useFakeTimers();
onTestFinished(() => {
vi.useRealTimers();
});

// Measure delta instead of absolute call count to avoid interference from parallel tests.
// Since we spy on the prototype, other tests running in parallel may also call flush.
// By measuring before/after, we only verify that THIS test triggered exactly one flush call.
const before = flushSpy.mock.calls.length;

const waits: Promise<unknown>[] = [];
const waitUntil = vi.fn(promise => waits.push(promise));

Expand All@@ -83,13 +111,20 @@ describe('withSentry', () => {

await wrapRequestHandler({ options: MOCK_OPTIONS, request: new Request('https://example.com'), context }, () => {
addDelayedWaitUntil(context);
return new Response('test');
const response = new Response('test');
// Add Content-Length to skip probing
response.headers.set('content-length', '4');
return response;
});
expect(flush).not.toBeCalled();
expect(waitUntil).toBeCalled();
vi.advanceTimersToNextTimerAsync().then(() => vi.runAllTimers());
vi.advanceTimersToNextTimer().runAllTimers();
await Promise.all(waits);
expect(flush).toHaveBeenCalledOnce();

const after = flushSpy.mock.calls.length;
const delta = after - before;

// Verify that exactly one flush call was made during this test
expect(delta).toBe(1);
});

describe('scope instrumentation', () => {
Expand DownExpand Up@@ -303,6 +338,9 @@ describe('withSentry', () => {
},
);

// Wait for async span end and transaction capture
await new Promise(resolve => setTimeout(resolve, 50));

expect(sentryEvent.transaction).toEqual('GET /');
expect(sentryEvent.spans).toHaveLength(0);
expect(sentryEvent.contexts?.trace).toEqual({
Expand Down