fix(nextjs): Stop accessing sync props in template by chargome · Pull Request #18113 · getsentry/sentry-javascript

chargome · 2025-11-06T18:10:48Z

We need to stop accessing params within our wrapper templates as this can break statically rendered pages and cause cache busts in dynamic pages.

Opened #18115 to investigate other ways of handling the functionality we're removing here.

closes#18097
closes#17431

Note: There's some unused code in the utils that I did not delete as we might be able to reuse this in #18115

URLs were missing from server-side transaction events (server components, generation functions) in Next.js. This was previously removed in #18113 because we tried to synchronously access `params` and `searchParams`, which cause builds to crash. This PR approach adds the URL at runtime using a `preprocessEvent` hook as suggested. **Implementation** 1. Reads `http.target` (actual request path) and `next.route` (parameterized route) from the transaction's trace data 2. Extracts headers from the captured isolation scope's SDK processing metadata 3. Builds the full URL using the existing `getSanitizedRequestUrl()` utility 4. Adds it to `normalizedRequest.url` so the `requestDataIntegration` includes it in the event This works uniformly for both Webpack and Turbopack across all of our supported Next.js versions (13~16), I added missing tests for this case in the versions that did not have it. Fixes#18115

chargome · 2025-11-06T18:10:48Z

We need to stop accessing params within our wrapper templates as this can break statically rendered pages and cause cache busts in dynamic pages.

Opened #18115 to investigate other ways of handling the functionality we're removing here.

closes#18097
closes#17431

Note: There's some unused code in the utils that I did not delete as we might be able to reuse this in #18115

URLs were missing from server-side transaction events (server components, generation functions) in Next.js. This was previously removed in #18113 because we tried to synchronously access `params` and `searchParams`, which cause builds to crash. This PR approach adds the URL at runtime using a `preprocessEvent` hook as suggested. **Implementation** 1. Reads `http.target` (actual request path) and `next.route` (parameterized route) from the transaction's trace data 2. Extracts headers from the captured isolation scope's SDK processing metadata 3. Builds the full URL using the existing `getSanitizedRequestUrl()` utility 4. Adds it to `normalizedRequest.url` so the `requestDataIntegration` includes it in the event This works uniformly for both Webpack and Turbopack across all of our supported Next.js versions (13~16), I added missing tests for this case in the versions that did not have it. Fixes#18115

chargome · 2025-11-06T18:10:48Z

We need to stop accessing params within our wrapper templates as this can break statically rendered pages and cause cache busts in dynamic pages.

Opened #18115 to investigate other ways of handling the functionality we're removing here.

closes#18097
closes#17431

Note: There's some unused code in the utils that I did not delete as we might be able to reuse this in #18115

URLs were missing from server-side transaction events (server components, generation functions) in Next.js. This was previously removed in #18113 because we tried to synchronously access `params` and `searchParams`, which cause builds to crash. This PR approach adds the URL at runtime using a `preprocessEvent` hook as suggested. **Implementation** 1. Reads `http.target` (actual request path) and `next.route` (parameterized route) from the transaction's trace data 2. Extracts headers from the captured isolation scope's SDK processing metadata 3. Builds the full URL using the existing `getSanitizedRequestUrl()` utility 4. Adds it to `normalizedRequest.url` so the `requestDataIntegration` includes it in the event This works uniformly for both Webpack and Turbopack across all of our supported Next.js versions (13~16), I added missing tests for this case in the versions that did not have it. Fixes#18115

chargome · 2025-11-06T18:10:48Z

We need to stop accessing params within our wrapper templates as this can break statically rendered pages and cause cache busts in dynamic pages.

Opened #18115 to investigate other ways of handling the functionality we're removing here.

closes#18097
closes#17431

Note: There's some unused code in the utils that I did not delete as we might be able to reuse this in #18115

URLs were missing from server-side transaction events (server components, generation functions) in Next.js. This was previously removed in #18113 because we tried to synchronously access `params` and `searchParams`, which cause builds to crash. This PR approach adds the URL at runtime using a `preprocessEvent` hook as suggested. **Implementation** 1. Reads `http.target` (actual request path) and `next.route` (parameterized route) from the transaction's trace data 2. Extracts headers from the captured isolation scope's SDK processing metadata 3. Builds the full URL using the existing `getSanitizedRequestUrl()` utility 4. Adds it to `normalizedRequest.url` so the `requestDataIntegration` includes it in the event This works uniformly for both Webpack and Turbopack across all of our supported Next.js versions (13~16), I added missing tests for this case in the versions that did not have it. Fixes#18115

chargome · 2025-11-06T18:10:48Z

We need to stop accessing params within our wrapper templates as this can break statically rendered pages and cause cache busts in dynamic pages.

Opened #18115 to investigate other ways of handling the functionality we're removing here.

closes#18097
closes#17431

Note: There's some unused code in the utils that I did not delete as we might be able to reuse this in #18115

URLs were missing from server-side transaction events (server components, generation functions) in Next.js. This was previously removed in #18113 because we tried to synchronously access `params` and `searchParams`, which cause builds to crash. This PR approach adds the URL at runtime using a `preprocessEvent` hook as suggested. **Implementation** 1. Reads `http.target` (actual request path) and `next.route` (parameterized route) from the transaction's trace data 2. Extracts headers from the captured isolation scope's SDK processing metadata 3. Builds the full URL using the existing `getSanitizedRequestUrl()` utility 4. Adds it to `normalizedRequest.url` so the `requestDataIntegration` includes it in the event This works uniformly for both Webpack and Turbopack across all of our supported Next.js versions (13~16), I added missing tests for this case in the versions that did not have it. Fixes#18115

chargome · 2025-11-06T18:10:48Z

We need to stop accessing params within our wrapper templates as this can break statically rendered pages and cause cache busts in dynamic pages.

Opened #18115 to investigate other ways of handling the functionality we're removing here.

closes#18097
closes#17431

Note: There's some unused code in the utils that I did not delete as we might be able to reuse this in #18115

URLs were missing from server-side transaction events (server components, generation functions) in Next.js. This was previously removed in #18113 because we tried to synchronously access `params` and `searchParams`, which cause builds to crash. This PR approach adds the URL at runtime using a `preprocessEvent` hook as suggested. **Implementation** 1. Reads `http.target` (actual request path) and `next.route` (parameterized route) from the transaction's trace data 2. Extracts headers from the captured isolation scope's SDK processing metadata 3. Builds the full URL using the existing `getSanitizedRequestUrl()` utility 4. Adds it to `normalizedRequest.url` so the `requestDataIntegration` includes it in the event This works uniformly for both Webpack and Turbopack across all of our supported Next.js versions (13~16), I added missing tests for this case in the versions that did not have it. Fixes#18115

chargome · 2025-11-06T18:10:48Z

We need to stop accessing params within our wrapper templates as this can break statically rendered pages and cause cache busts in dynamic pages.

Opened #18115 to investigate other ways of handling the functionality we're removing here.

closes#18097
closes#17431

Note: There's some unused code in the utils that I did not delete as we might be able to reuse this in #18115

URLs were missing from server-side transaction events (server components, generation functions) in Next.js. This was previously removed in #18113 because we tried to synchronously access `params` and `searchParams`, which cause builds to crash. This PR approach adds the URL at runtime using a `preprocessEvent` hook as suggested. **Implementation** 1. Reads `http.target` (actual request path) and `next.route` (parameterized route) from the transaction's trace data 2. Extracts headers from the captured isolation scope's SDK processing metadata 3. Builds the full URL using the existing `getSanitizedRequestUrl()` utility 4. Adds it to `normalizedRequest.url` so the `requestDataIntegration` includes it in the event This works uniformly for both Webpack and Turbopack across all of our supported Next.js versions (13~16), I added missing tests for this case in the versions that did not have it. Fixes#18115

chargome · 2025-11-06T18:10:48Z

We need to stop accessing params within our wrapper templates as this can break statically rendered pages and cause cache busts in dynamic pages.

Opened #18115 to investigate other ways of handling the functionality we're removing here.

closes#18097
closes#17431

Note: There's some unused code in the utils that I did not delete as we might be able to reuse this in #18115

URLs were missing from server-side transaction events (server components, generation functions) in Next.js. This was previously removed in #18113 because we tried to synchronously access `params` and `searchParams`, which cause builds to crash. This PR approach adds the URL at runtime using a `preprocessEvent` hook as suggested. **Implementation** 1. Reads `http.target` (actual request path) and `next.route` (parameterized route) from the transaction's trace data 2. Extracts headers from the captured isolation scope's SDK processing metadata 3. Builds the full URL using the existing `getSanitizedRequestUrl()` utility 4. Adds it to `normalizedRequest.url` so the `requestDataIntegration` includes it in the event This works uniformly for both Webpack and Turbopack across all of our supported Next.js versions (13~16), I added missing tests for this case in the versions that did not have it. Fixes#18115

stop accessing sync props in template
2967c5c

chargome self-assigned this Nov 6, 2025

rm url test
badf905

chargome mentioned this pull request Nov 6, 2025
Find uniform way to add the url to the transaction event in Next.js #18115
Closed

chargome marked this pull request as ready for review November 6, 2025 19:15

chargome requested review from RulaKhaled, andreiborza and logaretm November 6, 2025 19:18

logaretm approved these changes Nov 6, 2025
View reviewed changes

chargome merged commit 27af12e into developNov 7, 2025
114 of 117 checks passed

chargome deleted the cg-next-fix-static-template branch November 7, 2025 09:14

This was referenced Nov 10, 2025
Server cache not refreshing when sendDefaultPii: true since @sentry/nextjs@9.43 (DYNAMIC_SERVER_USAGE error) #17431
Closed
Nextjs: sendDefaultPii on sentry.server.config.ts breaks ISR pages #18097
Closed

logaretm mentioned this pull request Nov 17, 2025
feat(nextjs): Add URL to server-side transaction events #18230
Merged