fix(browser): Add ok status to succesful idleSpans - #18139

Merged
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status
Nov 12, 2025
Merged

fix(browser): Add ok status to succesful idleSpans#18139
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This came up while working on improvements for React Router wildcard routes. Looks like the successful browser idleSpans are reported with unknown status at the moment.

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.59 kB--
@sentry/browser - with treeshaking flags23.09 kB--
@sentry/browser (incl. Tracing)41.25 kB+0.06%+22 B 🔺
@sentry/browser (incl. Tracing, Profiling)45.52 kB+0.05%+20 B 🔺
@sentry/browser (incl. Tracing, Replay)79.72 kB+0.03%+18 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.39 kB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)84.39 kB+0.01%+1 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)96.58 kB+0.03%+21 B 🔺
@sentry/browser (incl. Feedback)41.27 kB--
@sentry/browser (incl. sendFeedback)29.26 kB--
@sentry/browser (incl. FeedbackAsync)34.19 kB--
@sentry/react26.28 kB--
@sentry/react (incl. Tracing)43.21 kB+0.06%+22 B 🔺
@sentry/vue29.07 kB--
@sentry/vue (incl. Tracing)43.02 kB+0.05%+20 B 🔺
@sentry/svelte24.6 kB--
CDN Bundle26.89 kB--
CDN Bundle (incl. Tracing)41.8 kB+0.05%+19 B 🔺
CDN Bundle (incl. Tracing, Replay)78.32 kB+0.03%+18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)83.79 kB+0.03%+20 B 🔺
CDN Bundle - uncompressed78.84 kB--
CDN Bundle (incl. Tracing) - uncompressed124 kB+0.05%+57 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed240.03 kB+0.03%+57 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed252.79 kB+0.03%+57 B 🔺
@sentry/nextjs (client)45.33 kB+0.04%+17 B 🔺
@sentry/sveltekit (client)41.63 kB+0.05%+20 B 🔺
@sentry/node-core50.76 kB--
@sentry/node157.84 kB+0.01%+1 B 🔺
@sentry/node - without tracing92.64 kB--
@sentry/aws-serverless106.4 kB-0.01%-3 B 🔽

View base workflow run

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,832-8,762+1%
GET With Sentry1,35115%1,394-3%
GET With Sentry (error only)6,11469%6,136-0%
POST Baseline1,200-1,200-
POST With Sentry50642%542-7%
POST With Sentry (error only)1,04687%1,062-2%
MYSQL Baseline3,288-3,361-2%
MYSQL With Sentry48015%476+1%
MYSQL With Sentry (error only)2,75884%2,740+1%

View base workflow run

@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from d157380 to 08763ccCompareNovember 10, 2025 21:07
@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from 6b535aa to 307b0a2CompareNovember 11, 2025 10:00
@onurtemizkan
onurtemizkan marked this pull request as ready for review November 11, 2025 10:16
cursor[bot]
cursorBot reviewed Nov 11, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Timeout Assignment Breaks Cancellation

In _restartChildSpanTimeout, the timeout ID is assigned to _idleTimeoutID instead of _childSpanTimeoutID. This causes the child span timeout to overwrite the idle timeout variable, preventing _cancelIdleTimeout from properly canceling the idle timeout and potentially causing incorrect timeout behavior when both timeouts are active.

packages/core/src/tracing/idleSpan.ts#L242-L250

sentry-javascript/packages/core/src/tracing/idleSpan.ts

Lines 242 to 250 in 307b0a2

function_restartChildSpanTimeout(endTimestamp?: number): void{
_cancelChildSpanTimeout();
_idleTimeoutID=setTimeout(()=>{
if(!_finished&&_autoFinishAllowed){
_finishReason=FINISH_REASON_HEARTBEAT_FAILED;
span.end(endTimestamp);
}
},childSpanTimeout);
}

Fix in CursorFix in Web

@s1gr1d
s1gr1d requested a review from Lms24November 12, 2025 11:47
Lms24
Lms24 reviewed Nov 12, 2025
View reviewed changes

@Lms24Lms24 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this makes sense because we're working towards spans only having 'ok'. and 'error' statuses (so, RIP 'unknown') (loosely tracked via #17836 for the moment).

@s1gr1d
s1gr1d merged commit 0cb306e into developNov 12, 2025
195 checks passed
@s1gr1d
s1gr1d deleted the onur/idle-span-success-status branch November 12, 2025 12:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargome

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onurtemizkan@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(browser): Add ok status to succesful idleSpans - #18139

Merged
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status
Nov 12, 2025
Merged

fix(browser): Add ok status to succesful idleSpans#18139
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This came up while working on improvements for React Router wildcard routes. Looks like the successful browser idleSpans are reported with unknown status at the moment.

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.59 kB--
@sentry/browser - with treeshaking flags23.09 kB--
@sentry/browser (incl. Tracing)41.25 kB+0.06%+22 B 🔺
@sentry/browser (incl. Tracing, Profiling)45.52 kB+0.05%+20 B 🔺
@sentry/browser (incl. Tracing, Replay)79.72 kB+0.03%+18 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.39 kB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)84.39 kB+0.01%+1 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)96.58 kB+0.03%+21 B 🔺
@sentry/browser (incl. Feedback)41.27 kB--
@sentry/browser (incl. sendFeedback)29.26 kB--
@sentry/browser (incl. FeedbackAsync)34.19 kB--
@sentry/react26.28 kB--
@sentry/react (incl. Tracing)43.21 kB+0.06%+22 B 🔺
@sentry/vue29.07 kB--
@sentry/vue (incl. Tracing)43.02 kB+0.05%+20 B 🔺
@sentry/svelte24.6 kB--
CDN Bundle26.89 kB--
CDN Bundle (incl. Tracing)41.8 kB+0.05%+19 B 🔺
CDN Bundle (incl. Tracing, Replay)78.32 kB+0.03%+18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)83.79 kB+0.03%+20 B 🔺
CDN Bundle - uncompressed78.84 kB--
CDN Bundle (incl. Tracing) - uncompressed124 kB+0.05%+57 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed240.03 kB+0.03%+57 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed252.79 kB+0.03%+57 B 🔺
@sentry/nextjs (client)45.33 kB+0.04%+17 B 🔺
@sentry/sveltekit (client)41.63 kB+0.05%+20 B 🔺
@sentry/node-core50.76 kB--
@sentry/node157.84 kB+0.01%+1 B 🔺
@sentry/node - without tracing92.64 kB--
@sentry/aws-serverless106.4 kB-0.01%-3 B 🔽

View base workflow run

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,832-8,762+1%
GET With Sentry1,35115%1,394-3%
GET With Sentry (error only)6,11469%6,136-0%
POST Baseline1,200-1,200-
POST With Sentry50642%542-7%
POST With Sentry (error only)1,04687%1,062-2%
MYSQL Baseline3,288-3,361-2%
MYSQL With Sentry48015%476+1%
MYSQL With Sentry (error only)2,75884%2,740+1%

View base workflow run

@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from d157380 to 08763ccCompareNovember 10, 2025 21:07
@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from 6b535aa to 307b0a2CompareNovember 11, 2025 10:00
@onurtemizkan
onurtemizkan marked this pull request as ready for review November 11, 2025 10:16
cursor[bot]
cursorBot reviewed Nov 11, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Timeout Assignment Breaks Cancellation

In _restartChildSpanTimeout, the timeout ID is assigned to _idleTimeoutID instead of _childSpanTimeoutID. This causes the child span timeout to overwrite the idle timeout variable, preventing _cancelIdleTimeout from properly canceling the idle timeout and potentially causing incorrect timeout behavior when both timeouts are active.

packages/core/src/tracing/idleSpan.ts#L242-L250

sentry-javascript/packages/core/src/tracing/idleSpan.ts

Lines 242 to 250 in 307b0a2

function_restartChildSpanTimeout(endTimestamp?: number): void{
_cancelChildSpanTimeout();
_idleTimeoutID=setTimeout(()=>{
if(!_finished&&_autoFinishAllowed){
_finishReason=FINISH_REASON_HEARTBEAT_FAILED;
span.end(endTimestamp);
}
},childSpanTimeout);
}

Fix in CursorFix in Web

@s1gr1d
s1gr1d requested a review from Lms24November 12, 2025 11:47
Lms24
Lms24 reviewed Nov 12, 2025
View reviewed changes

@Lms24Lms24 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this makes sense because we're working towards spans only having 'ok'. and 'error' statuses (so, RIP 'unknown') (loosely tracked via #17836 for the moment).

@s1gr1d
s1gr1d merged commit 0cb306e into developNov 12, 2025
195 checks passed
@s1gr1d
s1gr1d deleted the onur/idle-span-success-status branch November 12, 2025 12:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargome

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onurtemizkan@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(browser): Add ok status to succesful idleSpans - #18139

Merged
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status
Nov 12, 2025
Merged

fix(browser): Add ok status to succesful idleSpans#18139
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This came up while working on improvements for React Router wildcard routes. Looks like the successful browser idleSpans are reported with unknown status at the moment.

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.59 kB--
@sentry/browser - with treeshaking flags23.09 kB--
@sentry/browser (incl. Tracing)41.25 kB+0.06%+22 B 🔺
@sentry/browser (incl. Tracing, Profiling)45.52 kB+0.05%+20 B 🔺
@sentry/browser (incl. Tracing, Replay)79.72 kB+0.03%+18 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.39 kB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)84.39 kB+0.01%+1 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)96.58 kB+0.03%+21 B 🔺
@sentry/browser (incl. Feedback)41.27 kB--
@sentry/browser (incl. sendFeedback)29.26 kB--
@sentry/browser (incl. FeedbackAsync)34.19 kB--
@sentry/react26.28 kB--
@sentry/react (incl. Tracing)43.21 kB+0.06%+22 B 🔺
@sentry/vue29.07 kB--
@sentry/vue (incl. Tracing)43.02 kB+0.05%+20 B 🔺
@sentry/svelte24.6 kB--
CDN Bundle26.89 kB--
CDN Bundle (incl. Tracing)41.8 kB+0.05%+19 B 🔺
CDN Bundle (incl. Tracing, Replay)78.32 kB+0.03%+18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)83.79 kB+0.03%+20 B 🔺
CDN Bundle - uncompressed78.84 kB--
CDN Bundle (incl. Tracing) - uncompressed124 kB+0.05%+57 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed240.03 kB+0.03%+57 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed252.79 kB+0.03%+57 B 🔺
@sentry/nextjs (client)45.33 kB+0.04%+17 B 🔺
@sentry/sveltekit (client)41.63 kB+0.05%+20 B 🔺
@sentry/node-core50.76 kB--
@sentry/node157.84 kB+0.01%+1 B 🔺
@sentry/node - without tracing92.64 kB--
@sentry/aws-serverless106.4 kB-0.01%-3 B 🔽

View base workflow run

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,832-8,762+1%
GET With Sentry1,35115%1,394-3%
GET With Sentry (error only)6,11469%6,136-0%
POST Baseline1,200-1,200-
POST With Sentry50642%542-7%
POST With Sentry (error only)1,04687%1,062-2%
MYSQL Baseline3,288-3,361-2%
MYSQL With Sentry48015%476+1%
MYSQL With Sentry (error only)2,75884%2,740+1%

View base workflow run

@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from d157380 to 08763ccCompareNovember 10, 2025 21:07
@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from 6b535aa to 307b0a2CompareNovember 11, 2025 10:00
@onurtemizkan
onurtemizkan marked this pull request as ready for review November 11, 2025 10:16
cursor[bot]
cursorBot reviewed Nov 11, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Timeout Assignment Breaks Cancellation

In _restartChildSpanTimeout, the timeout ID is assigned to _idleTimeoutID instead of _childSpanTimeoutID. This causes the child span timeout to overwrite the idle timeout variable, preventing _cancelIdleTimeout from properly canceling the idle timeout and potentially causing incorrect timeout behavior when both timeouts are active.

packages/core/src/tracing/idleSpan.ts#L242-L250

sentry-javascript/packages/core/src/tracing/idleSpan.ts

Lines 242 to 250 in 307b0a2

function_restartChildSpanTimeout(endTimestamp?: number): void{
_cancelChildSpanTimeout();
_idleTimeoutID=setTimeout(()=>{
if(!_finished&&_autoFinishAllowed){
_finishReason=FINISH_REASON_HEARTBEAT_FAILED;
span.end(endTimestamp);
}
},childSpanTimeout);
}

Fix in CursorFix in Web

@s1gr1d
s1gr1d requested a review from Lms24November 12, 2025 11:47
Lms24
Lms24 reviewed Nov 12, 2025
View reviewed changes

@Lms24Lms24 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this makes sense because we're working towards spans only having 'ok'. and 'error' statuses (so, RIP 'unknown') (loosely tracked via #17836 for the moment).

@s1gr1d
s1gr1d merged commit 0cb306e into developNov 12, 2025
195 checks passed
@s1gr1d
s1gr1d deleted the onur/idle-span-success-status branch November 12, 2025 12:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargome

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onurtemizkan@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(browser): Add ok status to succesful idleSpans - #18139

Merged
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status
Nov 12, 2025
Merged

fix(browser): Add ok status to succesful idleSpans#18139
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This came up while working on improvements for React Router wildcard routes. Looks like the successful browser idleSpans are reported with unknown status at the moment.

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.59 kB--
@sentry/browser - with treeshaking flags23.09 kB--
@sentry/browser (incl. Tracing)41.25 kB+0.06%+22 B 🔺
@sentry/browser (incl. Tracing, Profiling)45.52 kB+0.05%+20 B 🔺
@sentry/browser (incl. Tracing, Replay)79.72 kB+0.03%+18 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.39 kB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)84.39 kB+0.01%+1 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)96.58 kB+0.03%+21 B 🔺
@sentry/browser (incl. Feedback)41.27 kB--
@sentry/browser (incl. sendFeedback)29.26 kB--
@sentry/browser (incl. FeedbackAsync)34.19 kB--
@sentry/react26.28 kB--
@sentry/react (incl. Tracing)43.21 kB+0.06%+22 B 🔺
@sentry/vue29.07 kB--
@sentry/vue (incl. Tracing)43.02 kB+0.05%+20 B 🔺
@sentry/svelte24.6 kB--
CDN Bundle26.89 kB--
CDN Bundle (incl. Tracing)41.8 kB+0.05%+19 B 🔺
CDN Bundle (incl. Tracing, Replay)78.32 kB+0.03%+18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)83.79 kB+0.03%+20 B 🔺
CDN Bundle - uncompressed78.84 kB--
CDN Bundle (incl. Tracing) - uncompressed124 kB+0.05%+57 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed240.03 kB+0.03%+57 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed252.79 kB+0.03%+57 B 🔺
@sentry/nextjs (client)45.33 kB+0.04%+17 B 🔺
@sentry/sveltekit (client)41.63 kB+0.05%+20 B 🔺
@sentry/node-core50.76 kB--
@sentry/node157.84 kB+0.01%+1 B 🔺
@sentry/node - without tracing92.64 kB--
@sentry/aws-serverless106.4 kB-0.01%-3 B 🔽

View base workflow run

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,832-8,762+1%
GET With Sentry1,35115%1,394-3%
GET With Sentry (error only)6,11469%6,136-0%
POST Baseline1,200-1,200-
POST With Sentry50642%542-7%
POST With Sentry (error only)1,04687%1,062-2%
MYSQL Baseline3,288-3,361-2%
MYSQL With Sentry48015%476+1%
MYSQL With Sentry (error only)2,75884%2,740+1%

View base workflow run

@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from d157380 to 08763ccCompareNovember 10, 2025 21:07
@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from 6b535aa to 307b0a2CompareNovember 11, 2025 10:00
@onurtemizkan
onurtemizkan marked this pull request as ready for review November 11, 2025 10:16
cursor[bot]
cursorBot reviewed Nov 11, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Timeout Assignment Breaks Cancellation

In _restartChildSpanTimeout, the timeout ID is assigned to _idleTimeoutID instead of _childSpanTimeoutID. This causes the child span timeout to overwrite the idle timeout variable, preventing _cancelIdleTimeout from properly canceling the idle timeout and potentially causing incorrect timeout behavior when both timeouts are active.

packages/core/src/tracing/idleSpan.ts#L242-L250

sentry-javascript/packages/core/src/tracing/idleSpan.ts

Lines 242 to 250 in 307b0a2

function_restartChildSpanTimeout(endTimestamp?: number): void{
_cancelChildSpanTimeout();
_idleTimeoutID=setTimeout(()=>{
if(!_finished&&_autoFinishAllowed){
_finishReason=FINISH_REASON_HEARTBEAT_FAILED;
span.end(endTimestamp);
}
},childSpanTimeout);
}

Fix in CursorFix in Web

@s1gr1d
s1gr1d requested a review from Lms24November 12, 2025 11:47
Lms24
Lms24 reviewed Nov 12, 2025
View reviewed changes

@Lms24Lms24 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this makes sense because we're working towards spans only having 'ok'. and 'error' statuses (so, RIP 'unknown') (loosely tracked via #17836 for the moment).

@s1gr1d
s1gr1d merged commit 0cb306e into developNov 12, 2025
195 checks passed
@s1gr1d
s1gr1d deleted the onur/idle-span-success-status branch November 12, 2025 12:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargome

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onurtemizkan@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(browser): Add ok status to succesful idleSpans - #18139

Merged
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status
Nov 12, 2025
Merged

fix(browser): Add ok status to succesful idleSpans#18139
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This came up while working on improvements for React Router wildcard routes. Looks like the successful browser idleSpans are reported with unknown status at the moment.

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.59 kB--
@sentry/browser - with treeshaking flags23.09 kB--
@sentry/browser (incl. Tracing)41.25 kB+0.06%+22 B 🔺
@sentry/browser (incl. Tracing, Profiling)45.52 kB+0.05%+20 B 🔺
@sentry/browser (incl. Tracing, Replay)79.72 kB+0.03%+18 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.39 kB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)84.39 kB+0.01%+1 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)96.58 kB+0.03%+21 B 🔺
@sentry/browser (incl. Feedback)41.27 kB--
@sentry/browser (incl. sendFeedback)29.26 kB--
@sentry/browser (incl. FeedbackAsync)34.19 kB--
@sentry/react26.28 kB--
@sentry/react (incl. Tracing)43.21 kB+0.06%+22 B 🔺
@sentry/vue29.07 kB--
@sentry/vue (incl. Tracing)43.02 kB+0.05%+20 B 🔺
@sentry/svelte24.6 kB--
CDN Bundle26.89 kB--
CDN Bundle (incl. Tracing)41.8 kB+0.05%+19 B 🔺
CDN Bundle (incl. Tracing, Replay)78.32 kB+0.03%+18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)83.79 kB+0.03%+20 B 🔺
CDN Bundle - uncompressed78.84 kB--
CDN Bundle (incl. Tracing) - uncompressed124 kB+0.05%+57 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed240.03 kB+0.03%+57 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed252.79 kB+0.03%+57 B 🔺
@sentry/nextjs (client)45.33 kB+0.04%+17 B 🔺
@sentry/sveltekit (client)41.63 kB+0.05%+20 B 🔺
@sentry/node-core50.76 kB--
@sentry/node157.84 kB+0.01%+1 B 🔺
@sentry/node - without tracing92.64 kB--
@sentry/aws-serverless106.4 kB-0.01%-3 B 🔽

View base workflow run

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,832-8,762+1%
GET With Sentry1,35115%1,394-3%
GET With Sentry (error only)6,11469%6,136-0%
POST Baseline1,200-1,200-
POST With Sentry50642%542-7%
POST With Sentry (error only)1,04687%1,062-2%
MYSQL Baseline3,288-3,361-2%
MYSQL With Sentry48015%476+1%
MYSQL With Sentry (error only)2,75884%2,740+1%

View base workflow run

@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from d157380 to 08763ccCompareNovember 10, 2025 21:07
@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from 6b535aa to 307b0a2CompareNovember 11, 2025 10:00
@onurtemizkan
onurtemizkan marked this pull request as ready for review November 11, 2025 10:16
cursor[bot]
cursorBot reviewed Nov 11, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Timeout Assignment Breaks Cancellation

In _restartChildSpanTimeout, the timeout ID is assigned to _idleTimeoutID instead of _childSpanTimeoutID. This causes the child span timeout to overwrite the idle timeout variable, preventing _cancelIdleTimeout from properly canceling the idle timeout and potentially causing incorrect timeout behavior when both timeouts are active.

packages/core/src/tracing/idleSpan.ts#L242-L250

sentry-javascript/packages/core/src/tracing/idleSpan.ts

Lines 242 to 250 in 307b0a2

function_restartChildSpanTimeout(endTimestamp?: number): void{
_cancelChildSpanTimeout();
_idleTimeoutID=setTimeout(()=>{
if(!_finished&&_autoFinishAllowed){
_finishReason=FINISH_REASON_HEARTBEAT_FAILED;
span.end(endTimestamp);
}
},childSpanTimeout);
}

Fix in CursorFix in Web

@s1gr1d
s1gr1d requested a review from Lms24November 12, 2025 11:47
Lms24
Lms24 reviewed Nov 12, 2025
View reviewed changes

@Lms24Lms24 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this makes sense because we're working towards spans only having 'ok'. and 'error' statuses (so, RIP 'unknown') (loosely tracked via #17836 for the moment).

@s1gr1d
s1gr1d merged commit 0cb306e into developNov 12, 2025
195 checks passed
@s1gr1d
s1gr1d deleted the onur/idle-span-success-status branch November 12, 2025 12:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargome

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onurtemizkan@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(browser): Add ok status to succesful idleSpans - #18139

Merged
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status
Nov 12, 2025
Merged

fix(browser): Add ok status to succesful idleSpans#18139
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This came up while working on improvements for React Router wildcard routes. Looks like the successful browser idleSpans are reported with unknown status at the moment.

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.59 kB--
@sentry/browser - with treeshaking flags23.09 kB--
@sentry/browser (incl. Tracing)41.25 kB+0.06%+22 B 🔺
@sentry/browser (incl. Tracing, Profiling)45.52 kB+0.05%+20 B 🔺
@sentry/browser (incl. Tracing, Replay)79.72 kB+0.03%+18 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.39 kB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)84.39 kB+0.01%+1 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)96.58 kB+0.03%+21 B 🔺
@sentry/browser (incl. Feedback)41.27 kB--
@sentry/browser (incl. sendFeedback)29.26 kB--
@sentry/browser (incl. FeedbackAsync)34.19 kB--
@sentry/react26.28 kB--
@sentry/react (incl. Tracing)43.21 kB+0.06%+22 B 🔺
@sentry/vue29.07 kB--
@sentry/vue (incl. Tracing)43.02 kB+0.05%+20 B 🔺
@sentry/svelte24.6 kB--
CDN Bundle26.89 kB--
CDN Bundle (incl. Tracing)41.8 kB+0.05%+19 B 🔺
CDN Bundle (incl. Tracing, Replay)78.32 kB+0.03%+18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)83.79 kB+0.03%+20 B 🔺
CDN Bundle - uncompressed78.84 kB--
CDN Bundle (incl. Tracing) - uncompressed124 kB+0.05%+57 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed240.03 kB+0.03%+57 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed252.79 kB+0.03%+57 B 🔺
@sentry/nextjs (client)45.33 kB+0.04%+17 B 🔺
@sentry/sveltekit (client)41.63 kB+0.05%+20 B 🔺
@sentry/node-core50.76 kB--
@sentry/node157.84 kB+0.01%+1 B 🔺
@sentry/node - without tracing92.64 kB--
@sentry/aws-serverless106.4 kB-0.01%-3 B 🔽

View base workflow run

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,832-8,762+1%
GET With Sentry1,35115%1,394-3%
GET With Sentry (error only)6,11469%6,136-0%
POST Baseline1,200-1,200-
POST With Sentry50642%542-7%
POST With Sentry (error only)1,04687%1,062-2%
MYSQL Baseline3,288-3,361-2%
MYSQL With Sentry48015%476+1%
MYSQL With Sentry (error only)2,75884%2,740+1%

View base workflow run

@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from d157380 to 08763ccCompareNovember 10, 2025 21:07
@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from 6b535aa to 307b0a2CompareNovember 11, 2025 10:00
@onurtemizkan
onurtemizkan marked this pull request as ready for review November 11, 2025 10:16
cursor[bot]
cursorBot reviewed Nov 11, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Timeout Assignment Breaks Cancellation

In _restartChildSpanTimeout, the timeout ID is assigned to _idleTimeoutID instead of _childSpanTimeoutID. This causes the child span timeout to overwrite the idle timeout variable, preventing _cancelIdleTimeout from properly canceling the idle timeout and potentially causing incorrect timeout behavior when both timeouts are active.

packages/core/src/tracing/idleSpan.ts#L242-L250

sentry-javascript/packages/core/src/tracing/idleSpan.ts

Lines 242 to 250 in 307b0a2

function_restartChildSpanTimeout(endTimestamp?: number): void{
_cancelChildSpanTimeout();
_idleTimeoutID=setTimeout(()=>{
if(!_finished&&_autoFinishAllowed){
_finishReason=FINISH_REASON_HEARTBEAT_FAILED;
span.end(endTimestamp);
}
},childSpanTimeout);
}

Fix in CursorFix in Web

@s1gr1d
s1gr1d requested a review from Lms24November 12, 2025 11:47
Lms24
Lms24 reviewed Nov 12, 2025
View reviewed changes

@Lms24Lms24 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this makes sense because we're working towards spans only having 'ok'. and 'error' statuses (so, RIP 'unknown') (loosely tracked via #17836 for the moment).

@s1gr1d
s1gr1d merged commit 0cb306e into developNov 12, 2025
195 checks passed
@s1gr1d
s1gr1d deleted the onur/idle-span-success-status branch November 12, 2025 12:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargome

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onurtemizkan@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(browser): Add ok status to succesful idleSpans - #18139

Merged
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status
Nov 12, 2025
Merged

fix(browser): Add ok status to succesful idleSpans#18139
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This came up while working on improvements for React Router wildcard routes. Looks like the successful browser idleSpans are reported with unknown status at the moment.

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.59 kB--
@sentry/browser - with treeshaking flags23.09 kB--
@sentry/browser (incl. Tracing)41.25 kB+0.06%+22 B 🔺
@sentry/browser (incl. Tracing, Profiling)45.52 kB+0.05%+20 B 🔺
@sentry/browser (incl. Tracing, Replay)79.72 kB+0.03%+18 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.39 kB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)84.39 kB+0.01%+1 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)96.58 kB+0.03%+21 B 🔺
@sentry/browser (incl. Feedback)41.27 kB--
@sentry/browser (incl. sendFeedback)29.26 kB--
@sentry/browser (incl. FeedbackAsync)34.19 kB--
@sentry/react26.28 kB--
@sentry/react (incl. Tracing)43.21 kB+0.06%+22 B 🔺
@sentry/vue29.07 kB--
@sentry/vue (incl. Tracing)43.02 kB+0.05%+20 B 🔺
@sentry/svelte24.6 kB--
CDN Bundle26.89 kB--
CDN Bundle (incl. Tracing)41.8 kB+0.05%+19 B 🔺
CDN Bundle (incl. Tracing, Replay)78.32 kB+0.03%+18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)83.79 kB+0.03%+20 B 🔺
CDN Bundle - uncompressed78.84 kB--
CDN Bundle (incl. Tracing) - uncompressed124 kB+0.05%+57 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed240.03 kB+0.03%+57 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed252.79 kB+0.03%+57 B 🔺
@sentry/nextjs (client)45.33 kB+0.04%+17 B 🔺
@sentry/sveltekit (client)41.63 kB+0.05%+20 B 🔺
@sentry/node-core50.76 kB--
@sentry/node157.84 kB+0.01%+1 B 🔺
@sentry/node - without tracing92.64 kB--
@sentry/aws-serverless106.4 kB-0.01%-3 B 🔽

View base workflow run

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,832-8,762+1%
GET With Sentry1,35115%1,394-3%
GET With Sentry (error only)6,11469%6,136-0%
POST Baseline1,200-1,200-
POST With Sentry50642%542-7%
POST With Sentry (error only)1,04687%1,062-2%
MYSQL Baseline3,288-3,361-2%
MYSQL With Sentry48015%476+1%
MYSQL With Sentry (error only)2,75884%2,740+1%

View base workflow run

@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from d157380 to 08763ccCompareNovember 10, 2025 21:07
@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from 6b535aa to 307b0a2CompareNovember 11, 2025 10:00
@onurtemizkan
onurtemizkan marked this pull request as ready for review November 11, 2025 10:16
cursor[bot]
cursorBot reviewed Nov 11, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Timeout Assignment Breaks Cancellation

In _restartChildSpanTimeout, the timeout ID is assigned to _idleTimeoutID instead of _childSpanTimeoutID. This causes the child span timeout to overwrite the idle timeout variable, preventing _cancelIdleTimeout from properly canceling the idle timeout and potentially causing incorrect timeout behavior when both timeouts are active.

packages/core/src/tracing/idleSpan.ts#L242-L250

sentry-javascript/packages/core/src/tracing/idleSpan.ts

Lines 242 to 250 in 307b0a2

function_restartChildSpanTimeout(endTimestamp?: number): void{
_cancelChildSpanTimeout();
_idleTimeoutID=setTimeout(()=>{
if(!_finished&&_autoFinishAllowed){
_finishReason=FINISH_REASON_HEARTBEAT_FAILED;
span.end(endTimestamp);
}
},childSpanTimeout);
}

Fix in CursorFix in Web

@s1gr1d
s1gr1d requested a review from Lms24November 12, 2025 11:47
Lms24
Lms24 reviewed Nov 12, 2025
View reviewed changes

@Lms24Lms24 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this makes sense because we're working towards spans only having 'ok'. and 'error' statuses (so, RIP 'unknown') (loosely tracked via #17836 for the moment).

@s1gr1d
s1gr1d merged commit 0cb306e into developNov 12, 2025
195 checks passed
@s1gr1d
s1gr1d deleted the onur/idle-span-success-status branch November 12, 2025 12:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargome

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onurtemizkan@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(browser): Add ok status to succesful idleSpans - #18139

Merged
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status
Nov 12, 2025
Merged

fix(browser): Add ok status to succesful idleSpans#18139
s1gr1d merged 4 commits into
developfrom
onur/idle-span-success-status

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This came up while working on improvements for React Router wildcard routes. Looks like the successful browser idleSpans are reported with unknown status at the moment.

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.59 kB--
@sentry/browser - with treeshaking flags23.09 kB--
@sentry/browser (incl. Tracing)41.25 kB+0.06%+22 B 🔺
@sentry/browser (incl. Tracing, Profiling)45.52 kB+0.05%+20 B 🔺
@sentry/browser (incl. Tracing, Replay)79.72 kB+0.03%+18 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.39 kB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)84.39 kB+0.01%+1 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)96.58 kB+0.03%+21 B 🔺
@sentry/browser (incl. Feedback)41.27 kB--
@sentry/browser (incl. sendFeedback)29.26 kB--
@sentry/browser (incl. FeedbackAsync)34.19 kB--
@sentry/react26.28 kB--
@sentry/react (incl. Tracing)43.21 kB+0.06%+22 B 🔺
@sentry/vue29.07 kB--
@sentry/vue (incl. Tracing)43.02 kB+0.05%+20 B 🔺
@sentry/svelte24.6 kB--
CDN Bundle26.89 kB--
CDN Bundle (incl. Tracing)41.8 kB+0.05%+19 B 🔺
CDN Bundle (incl. Tracing, Replay)78.32 kB+0.03%+18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)83.79 kB+0.03%+20 B 🔺
CDN Bundle - uncompressed78.84 kB--
CDN Bundle (incl. Tracing) - uncompressed124 kB+0.05%+57 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed240.03 kB+0.03%+57 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed252.79 kB+0.03%+57 B 🔺
@sentry/nextjs (client)45.33 kB+0.04%+17 B 🔺
@sentry/sveltekit (client)41.63 kB+0.05%+20 B 🔺
@sentry/node-core50.76 kB--
@sentry/node157.84 kB+0.01%+1 B 🔺
@sentry/node - without tracing92.64 kB--
@sentry/aws-serverless106.4 kB-0.01%-3 B 🔽

View base workflow run

@github-actions

github-actionsBot commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,832-8,762+1%
GET With Sentry1,35115%1,394-3%
GET With Sentry (error only)6,11469%6,136-0%
POST Baseline1,200-1,200-
POST With Sentry50642%542-7%
POST With Sentry (error only)1,04687%1,062-2%
MYSQL Baseline3,288-3,361-2%
MYSQL With Sentry48015%476+1%
MYSQL With Sentry (error only)2,75884%2,740+1%

View base workflow run

@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from d157380 to 08763ccCompareNovember 10, 2025 21:07
@onurtemizkan
onurtemizkanforce-pushed the onur/idle-span-success-status branch from 6b535aa to 307b0a2CompareNovember 11, 2025 10:00
@onurtemizkan
onurtemizkan marked this pull request as ready for review November 11, 2025 10:16
cursor[bot]
cursorBot reviewed Nov 11, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Timeout Assignment Breaks Cancellation

In _restartChildSpanTimeout, the timeout ID is assigned to _idleTimeoutID instead of _childSpanTimeoutID. This causes the child span timeout to overwrite the idle timeout variable, preventing _cancelIdleTimeout from properly canceling the idle timeout and potentially causing incorrect timeout behavior when both timeouts are active.

packages/core/src/tracing/idleSpan.ts#L242-L250

sentry-javascript/packages/core/src/tracing/idleSpan.ts

Lines 242 to 250 in 307b0a2

function_restartChildSpanTimeout(endTimestamp?: number): void{
_cancelChildSpanTimeout();
_idleTimeoutID=setTimeout(()=>{
if(!_finished&&_autoFinishAllowed){
_finishReason=FINISH_REASON_HEARTBEAT_FAILED;
span.end(endTimestamp);
}
},childSpanTimeout);
}

Fix in CursorFix in Web

@s1gr1d
s1gr1d requested a review from Lms24November 12, 2025 11:47
Lms24
Lms24 reviewed Nov 12, 2025
View reviewed changes

@Lms24Lms24 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this makes sense because we're working towards spans only having 'ok'. and 'error' statuses (so, RIP 'unknown') (loosely tracked via #17836 for the moment).

@s1gr1d
s1gr1d merged commit 0cb306e into developNov 12, 2025
195 checks passed
@s1gr1d
s1gr1d deleted the onur/idle-span-success-status branch November 12, 2025 12:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@Lms24Lms24Lms24 approved these changes
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargome

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onurtemizkan@Lms24@s1gr1d