Uh oh!
There was an error while loading. Please reload this page.
fix(core): Fix logs and metrics flush timeout starvation with continuous logging - #18211
Merged
Conversation
The flush timeout was being reset on every incoming log, preventing flushes when logs arrived continuously. Now, the timer starts on the first log won't get reset, ensuring logs flush within the configured interval. Fixes#18204, getsentry/sentry-react-native#5378
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
| flushTimeout = setTimeout(() => { | ||
| flushFn(client); | ||
| // Note: isTimerActive is reset by the flushHook handler above, not here, | ||
| // to avoid race conditions when new items arrive during the flush. |
There was a problem hiding this comment.
Bug: Stuck Timer Halts Automatic Flushing
The isTimerActive flag can get stuck as true when the timer fires but the buffer is empty. This happens because isTimerActive is only reset in the flushHook handler (line 121), but _INTERNAL_flushLogsBuffer returns early without emitting this hook when the buffer is empty. Once stuck, no new timers can start since !isTimerActive evaluates to false, preventing automatic flushing of subsequent logs/metrics until the weight threshold is exceeded.
MemberAuthor
There was a problem hiding this comment.
For isTimerActive to be set to true, an item must have come in via afterCaptureHook which in turn starts the timeout. Once the buffer flushes isTimerActive will be set back to false via flushHook.
I don't think this scenario can happen.
andreiborza added a commit
that referenced
this pull request
Nov 14, 2025
The flush timeout was being reset on every incoming log, preventing flushes when logs arrived continuously. Now, the timer starts on the first log won't get reset, ensuring logs flush within the configured interval. Backport of: #18211
isaacs
approved these changes
Nov 14, 2025
isaacs
left a comment
Member
There was a problem hiding this comment.
LGTM, this does do what it says :)
Uh oh!
There was an error while loading. Please reload this page.
andreiborza added a commit
that referenced
this pull request
Nov 17, 2025
The flush timeout was being reset on every incoming log, preventing flushes when logs arrived continuously. Now, the timer starts on the first log won't get reset, ensuring logs flush within the configured interval. Backport of: #18211
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flush timeout was being reset on every incoming log, preventing flushes when logs arrived continuously. Now, the timer starts on the first log and won't get reset, ensuring logs flush within the configured interval.
Fixes#18204, getsentry/sentry-react-native#5378
v9 backport: #18214