Uh oh!
There was an error while loading. Please reload this page.
feat(deps): Bump OpenTelemetry instrumentations - #18239
Merged
Merged
Conversation
andreiborzaforce-pushed
the
bump-otel-2025-11-18
branch
from
November 18, 2025 10:37
44bdc0e to
65edd0cCompareContributor
size-limit report 📦
|
andreiborzaforce-pushed
the
bump-otel-2025-11-18
branch
from
November 18, 2025 17:23
c1de527 to
9980e4dComparetimfish
reviewed
Nov 18, 2025
timfish
left a comment
Collaborator
There was a problem hiding this comment.
The latest @opentelemetry/instrumentation now uses import-in-the-middle v2 and require-in-the-middle v8.
These need updating wherever we have them as dependencies and then I guess the bundle impact might be reduced to zero!
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This was referenced Nov 19, 2025
This was referenced Nov 19, 2025
andreiborza added a commit
that referenced
this pull request
Nov 19, 2025
Bumping OpenTelemetry instrumentations is an important but tedious task, all instrumentations have to be bumped in lockstep across the codebase. That includes easy to miss dev-packages and third party instrumentations like prisma's. This command should make it easier to do that. Example of a PR that was kicked off with this command: #18239
andreiborzaforce-pushed
the
bump-otel-2025-11-18
branch
4 times, most recently
from
November 19, 2025 13:48
1a1d8fc to
e435f4eCompareandreiborza
marked this pull request as ready for review
November 19, 2025 14:01
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
andreiborzaforce-pushed
the
bump-otel-2025-11-18
branch
3 times, most recently
from
November 19, 2025 17:26
fb89424 to
265a630CompareJPeer264
approved these changes
Nov 20, 2025
| // Inline EventEmitter interface to avoid Node.js module dependency | ||
| // This prevents Node.js type leaks in edge runtime environments | ||
| interface EventEmitter { |
Member
There was a problem hiding this comment.
l: is this intended to be in this PR?
MemberAuthor
There was a problem hiding this comment.
I vendored these in because the build was failing. This being the edge-runtime I guess it kind of makes sense not to import anything from node modules. I don't know why this wasn't an issue before.
OTOH types don't make it into run time so.... kind of weird all in all.
| // Inline AsyncLocalStorage interface to avoid Node.js module dependency | ||
| // This prevents Node.js type leaks in edge runtime environments | ||
| interface AsyncLocalStorage<T> { |
Member
There was a problem hiding this comment.
l: is this intended to be in this PR?
andreiborzaforce-pushed
the
bump-otel-2025-11-18
branch
from
November 21, 2025 00:44
057017e to
edc5083Compare- Bump @opentelemetry/instrumentation from 0.204.0 to 0.208.0 - Bump @opentelemetry/instrumentation-amqplib from 0.51.0 to 0.55.0 - Bump @opentelemetry/instrumentation-aws-sdk from 0.59.0 to 0.64.0 - Bump @opentelemetry/instrumentation-connect from 0.48.0 to 0.52.0 - Bump @opentelemetry/instrumentation-dataloader from 0.22.0 to 0.26.0 - Bump @opentelemetry/instrumentation-express from 0.53.0 to 0.57.0 - Bump @opentelemetry/instrumentation-fs from 0.24.0 to 0.28.0 - Bump @opentelemetry/instrumentation-generic-pool from 0.48.0 to 0.52.0 - Bump @opentelemetry/instrumentation-graphql from 0.52.0 to 0.56.0 - Bump @opentelemetry/instrumentation-hapi from 0.51.0 to 0.55.0 - Bump @opentelemetry/instrumentation-http from 0.204.0 to 0.208.0 - Bump @opentelemetry/instrumentation-ioredis from 0.52.0 to 0.56.0 - Bump @opentelemetry/instrumentation-kafkajs from 0.14.0 to 0.18.0 - Bump @opentelemetry/instrumentation-knex from 0.49.0 to 0.53.0 - Bump @opentelemetry/instrumentation-koa from 0.52.0 to 0.57.0 - Bump @opentelemetry/instrumentation-lru-memoizer from 0.49.0 to 0.53.0 - Bump @opentelemetry/instrumentation-mongodb from 0.57.0 to 0.61.0 - Bump @opentelemetry/instrumentation-mongoose from 0.51.0 to 0.55.0 - Bump @opentelemetry/instrumentation-mysql from 0.50.0 to 0.54.0 - Bump @opentelemetry/instrumentation-mysql2 from 0.51.0 to 0.55.0 - Bump @opentelemetry/instrumentation-nestjs-core from 0.50.0 to 0.55.0 - Bump @opentelemetry/instrumentation-pg from 0.57.0 to 0.61.0 - Bump @opentelemetry/instrumentation-redis from 0.53.0 to 0.57.0 - Bump @opentelemetry/instrumentation-tedious from 0.23.0 to 0.27.0 - Bump @opentelemetry/instrumentation-undici from 0.15.0 to 0.19.0 - Bump @prisma/instrumentation from 6.15.0 to 6.19.0
- Bump @opentelemetry/context-async-hooks from ^2.1.0 to ^2.2.0 - Bump @opentelemetry/core from ^2.1.0 to ^2.2.0 - Bump @opentelemetry/resources from ^2.1.0 to ^2.2.0 - Bump @opentelemetry/sdk-trace-base from ^2.1.0 to ^2.2.0 - Bump @opentelemetry/sdk-trace-node from ^2.1.0 to ^2.2.0 Added ^2.2.0 as peer dependency option for core OpenTelemetry packages in @sentry/node-core and @sentry/opentelemetry to support the latest OpenTelemetry SDK while maintaining backward compatibility with v1.30.1 and v2.1.0.
andreiborzaforce-pushed
the
bump-otel-2025-11-18
branch
from
November 21, 2025 21:24
edc5083 to
d4f247fCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps OpenTelemetry instrumentations and SDK packages to their latest versions.
Dependency Updates:
Closes: #18178