Uh oh!
There was an error while loading. Please reload this page.
feat(v11): Drop TypeScript 3.8 support - #18604
Merged
Merged
Conversation
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
logaretmforce-pushed
the
awad/js-1293-drop-typescript-38-support
branch
2 times, most recently
from
December 23, 2025 13:02
424934f to
dea5658Comparelogaretmforce-pushed
the
awad/js-1293-drop-typescript-38-support
branch
2 times, most recently
from
December 24, 2025 12:50
bf9dfc3 to
f8824a4CompareContributor
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
logaretmforce-pushed
the
awad/js-1293-drop-typescript-38-support
branch
from
July 10, 2026 18:37
0ccb9a1 to
fb2b2d8Comparelogaretmforce-pushed
the
awad/js-1293-drop-typescript-38-support
branch
2 times, most recently
from
July 10, 2026 18:56
410a72f to
bc07973Comparelogaretmforce-pushed
the
awad/js-1293-drop-typescript-38-support
branch
from
July 10, 2026 19:01
bc07973 to
21ebf07CompareContributor
size-limit report 📦
|
logaretmforce-pushed
the
awad/js-1293-drop-typescript-38-support
branch
2 times, most recently
from
July 11, 2026 02:45
e2e63ad to
b4b2d6cComparelogaretmforce-pushed
the
awad/js-1293-drop-typescript-38-support
branch
from
July 13, 2026 14:31
b4b2d6c to
0b68598Comparelogaretmforce-pushed
the
awad/js-1293-drop-typescript-38-support
branch
from
July 13, 2026 15:16
0b68598 to
e97c2adComparelogaretm
marked this pull request as ready for review
July 21, 2026 13:52
logaretm
requested review from
JPeer264, Lms24, chargome, isaacs, msonnb and nicohrubec
and removed request for
a teamJuly 21, 2026 13:52
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e97c2ad. Configure here.
| }, | ||
| "volta": { | ||
| "extends": "../../package.json" | ||
| }, |
There was a problem hiding this comment.
Esbuild override removed accidentally
Medium Severity
Cleaning up the TS 3.8 sentryTest variants also dropped the unrelated pnpm.overrides pin for esbuild at 0.24.0. That pin is a bundler constraint, not TypeScript downlevel support, and similar apps such as astro-5 still keep it. Losing it can make these Vite E2E installs resolve a different esbuild and break test:build.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e97c2ad. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
logaretmforce-pushed
the
awad/js-1293-drop-typescript-38-support
branch
2 times, most recently
from
July 21, 2026 14:12
7e8b35b to
254056dComparenicohrubec
approved these changes
Jul 21, 2026
logaretmforce-pushed
the
awad/js-1293-drop-typescript-38-support
branch
2 times, most recently
from
July 21, 2026 16:46
53fe796 to
0ee945dCompareMinimum supported TypeScript is now 5.0, so remove the downlevel-dts type path and the TS 3.8 test surface: - drop each package's typesVersions "<5.0" mapping and the build:types:downlevel step (build:types is just tsc now) - remove downlevel-dts and the ts3.8 shim scripts/type-shims - bump the node integration-test TS matrix to 5.0 (use-ts-5_0) - drop the TS 3.8 e2e variants and the generic-ts3.8 app - use the built-in Awaited type instead of the vendored shim
logaretmforce-pushed
the
awad/js-1293-drop-typescript-38-support
branch
from
July 21, 2026 17:46
0ee945d to
30858f5CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes support for generating and publishing TypeScript 3.8 downleveled type definitions across all packages.
The changes simplify the build process by eliminating scripts, dependencies, and configuration related to downleveling types, and update test and project configuration accordingly.
closes#18477
TODO:
package.json