Uh oh!
There was an error while loading. Please reload this page.
feat(node): Add Prisma v7 support - #18908
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| await client.$disconnect(); | ||
| }, 500); | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Wrong API used: span auto-ends before setTimeout fires
Low Severity
The v7 scenario uses Sentry.startSpan() with an async callback that includes a setTimeout calling span.end(). However, startSpan automatically ends the span when the async callback returns (after the database operations complete), which happens before the setTimeout fires. This means span.end() is called on an already-ended span. The v5 test correctly uses Sentry.startSpanManual() for this same pattern, which does not auto-end the span. While the test likely still passes because all database operations complete before the callback returns, this is inconsistent with the existing v5 test pattern and could cause confusion.
There was a problem hiding this comment.
This is consistent with our v6 tests.
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Upgrades `@prisma/instrumentation` from `6.19.0` to `7.2.0`. The instrumentation should be backwards compatible with v5 and v6 (we have integration tests for v5 and v6). I also added integration tests for v7. Closes: #18876
ae86d14 to
9d229adCompare| } | ||
| generator client { | ||
| provider = "prisma-client-js" |
There was a problem hiding this comment.
Should we maybe use "prisma-client" here? According to their blog post, this is now possible and rust-free: https://www.prisma.io/blog/announcing-prisma-orm-7-0-0
And their migration guide: https://www.prisma.io/docs/orm/more/upgrade-guides/upgrading-versions/upgrading-to-prisma-7#prisma-schema-changes
| workingDirectory: [cwd], | ||
| readyMatches: ['port 5432'], | ||
| setupCommand: `yarn prisma generate --schema ${cwd}/prisma/schema.prisma && yarn prisma migrate dev -n sentry-test --schema ${cwd}/prisma/schema.prisma`, | ||
| setupCommand: `prisma generate --schema ${cwd}/prisma/schema.prisma && tsc -p ${cwd}/prisma/tsconfig.json && prisma migrate dev -n sentry-test --schema ${cwd}/prisma/schema.prisma`, |
There was a problem hiding this comment.
This previously used the workspace prisma, which was v6. I changed the runner to modify PATH so that the closest node_modules bin path is preferred so that runners that specify additional dependencies have those take precedence.
38320d4 to
b7b71a7CompareUh oh!
There was an error while loading. Please reload this page.
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Adds docs for getsentry/sentry-javascript#18908 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
Upgrades
@prisma/instrumentationfrom6.19.0to7.2.0. The instrumentation should be backwards compatible with v5 and v6 (we have integration tests for v5 and v6). I also added integration tests for v7.Closes: #18876