feat(core): Add scope-level conversation ID API to support linking AI conversations - #18909

Merged
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api
Jan 23, 2026
Merged

feat(core): Add scope-level conversation ID API to support linking AI conversations#18909
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api

Conversation

@RulaKhaled

@RulaKhaledRulaKhaled commented Jan 20, 2026

Copy link
Copy Markdown
Collaborator

Introduces a new Sentry.setConversationId() API to track multi turn AI conversations across API calls.

We want to leverage each AI frameworks built-in functionalities wherever possible. OpenAIs conversation_id, sessions, etc to create the gen_ai.conversation.id attribute.
However if the framework does not provide such a mechanism (such as Google GenAI or Anthropic) we shall provide a common function: Sentry.setConversationId(...) or sentry_sdk.set_conversation_id(), which adds the conversation ID to the Scope in a similar way as Sentry.setUser() and sentry_sdk.set_user() do. When provided in such a way it will override any automatically detected value.

Why not just add this as an attribute?
it should only appear as a span attribute, not propagate to logs and metrics. This keeps AI conversation context isolated to spans where it's semantically relevant.

@linear

linearBot commented Jan 20, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.32 kB+0.46%+115 B 🔺
@sentry/browser - with treeshaking flags23.83 kB+0.51%+120 B 🔺
@sentry/browser (incl. Tracing)42.14 kB+0.27%+112 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.78 kB+0.26%+119 B 🔺
@sentry/browser (incl. Tracing, Replay)80.75 kB+0.15%+115 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.4 kB+0.15%+101 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.47 kB+0.15%+120 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.65 kB+0.12%+108 B 🔺
@sentry/browser (incl. Feedback)42.04 kB+0.28%+117 B 🔺
@sentry/browser (incl. sendFeedback)30.01 kB+0.41%+120 B 🔺
@sentry/browser (incl. FeedbackAsync)35.01 kB+0.35%+120 B 🔺
@sentry/browser (incl. Metrics)26.43 kB+0.47%+122 B 🔺
@sentry/browser (incl. Logs)26.57 kB+0.41%+108 B 🔺
@sentry/browser (incl. Metrics & Logs)27.24 kB+0.47%+125 B 🔺
@sentry/react27.05 kB+0.45%+120 B 🔺
@sentry/react (incl. Tracing)44.37 kB+0.25%+110 B 🔺
@sentry/vue29.76 kB+0.41%+119 B 🔺
@sentry/vue (incl. Tracing)43.93 kB+0.26%+112 B 🔺
@sentry/svelte25.33 kB+0.45%+113 B 🔺
CDN Bundle27.89 kB+0.41%+113 B 🔺
CDN Bundle (incl. Tracing)42.93 kB+0.25%+103 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.75 kB+0.25%+105 B 🔺
CDN Bundle (incl. Tracing, Replay)79.68 kB+0.17%+130 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.11 kB+0.15%+119 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.03 kB+0.15%+121 B 🔺
CDN Bundle - uncompressed81.6 kB+0.42%+335 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.14 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed129.97 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.74 kB+0.14%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.54 kB+0.13%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.35 kB+0.13%+329 B 🔺
@sentry/nextjs (client)46.73 kB+0.23%+107 B 🔺
@sentry/sveltekit (client)42.51 kB+0.28%+115 B 🔺
@sentry/node-core52.01 kB+0.21%+108 B 🔺
@sentry/node165.56 kB+0.06%+87 B 🔺
@sentry/node - without tracing93.76 kB+0.11%+103 B 🔺
@sentry/aws-serverless109.28 kB+0.11%+116 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,045-9,038+0%
GET With Sentry1,68719%1,667+1%
GET With Sentry (error only)6,03367%6,029+0%
POST Baseline1,200-1,193+1%
POST With Sentry58849%586+0%
POST With Sentry (error only)1,06489%1,038+3%
MYSQL Baseline3,283-3,377-3%
MYSQL With Sentry44113%497-11%
MYSQL With Sentry (error only)2,65081%2,733-3%

View base workflow run

@RulaKhaledRulaKhaled changed the title wip(ai): Support scope-level conversation ID for AI tracingfeat(core): Add scope-level conversation ID API to support linking AI conversationsJan 21, 2026
@RulaKhaled
RulaKhaled requested a review from Lms24January 21, 2026 15:18
Comment threadpackages/core/src/tracing/sentrySpan.ts
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/scope.ts Outdated
Comment threadpackages/core/src/scope.ts
@RulaKhaled
RulaKhaled marked this pull request as ready for review January 22, 2026 13:21
Comment threadpackages/astro/src/index.server.ts

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! LGTM now!

In the future, we also might want to export conversationIdIntegration from SDKs but as long as there's nothing to configure, I think it's fine to leave it unexported. Happy to leave that up to you :)

cursor[bot]

This comment was marked as outdated.

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


if (conversationId) {
span.setAttribute(GEN_AI_CONVERSATION_ID_ATTRIBUTE, conversationId);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration uses spanStart instead of agreed spanEnd hook

High Severity

The integration uses client.on('spanStart', ...) but the PR discussion explicitly agreed on client.on('spanEnd', ...). With spanStart, the scope's conversation ID is set first, then auto-detected values from OpenAI/LangGraph integrations override it during span execution. The PR description states scope-level values should "override any automatically detected value" which requires spanEnd so the scope value is applied last and takes precedence.

Fix in CursorFix in Web

@RulaKhaled
RulaKhaled merged commit c5e3249 into developJan 23, 2026
212 checks passed
@RulaKhaled
RulaKhaled deleted the rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api branch January 23, 2026 15:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@RulaKhaled@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(core): Add scope-level conversation ID API to support linking AI conversations - #18909

Merged
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api
Jan 23, 2026
Merged

feat(core): Add scope-level conversation ID API to support linking AI conversations#18909
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api

Conversation

@RulaKhaled

@RulaKhaledRulaKhaled commented Jan 20, 2026

Copy link
Copy Markdown
Collaborator

Introduces a new Sentry.setConversationId() API to track multi turn AI conversations across API calls.

We want to leverage each AI frameworks built-in functionalities wherever possible. OpenAIs conversation_id, sessions, etc to create the gen_ai.conversation.id attribute.
However if the framework does not provide such a mechanism (such as Google GenAI or Anthropic) we shall provide a common function: Sentry.setConversationId(...) or sentry_sdk.set_conversation_id(), which adds the conversation ID to the Scope in a similar way as Sentry.setUser() and sentry_sdk.set_user() do. When provided in such a way it will override any automatically detected value.

Why not just add this as an attribute?
it should only appear as a span attribute, not propagate to logs and metrics. This keeps AI conversation context isolated to spans where it's semantically relevant.

@linear

linearBot commented Jan 20, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.32 kB+0.46%+115 B 🔺
@sentry/browser - with treeshaking flags23.83 kB+0.51%+120 B 🔺
@sentry/browser (incl. Tracing)42.14 kB+0.27%+112 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.78 kB+0.26%+119 B 🔺
@sentry/browser (incl. Tracing, Replay)80.75 kB+0.15%+115 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.4 kB+0.15%+101 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.47 kB+0.15%+120 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.65 kB+0.12%+108 B 🔺
@sentry/browser (incl. Feedback)42.04 kB+0.28%+117 B 🔺
@sentry/browser (incl. sendFeedback)30.01 kB+0.41%+120 B 🔺
@sentry/browser (incl. FeedbackAsync)35.01 kB+0.35%+120 B 🔺
@sentry/browser (incl. Metrics)26.43 kB+0.47%+122 B 🔺
@sentry/browser (incl. Logs)26.57 kB+0.41%+108 B 🔺
@sentry/browser (incl. Metrics & Logs)27.24 kB+0.47%+125 B 🔺
@sentry/react27.05 kB+0.45%+120 B 🔺
@sentry/react (incl. Tracing)44.37 kB+0.25%+110 B 🔺
@sentry/vue29.76 kB+0.41%+119 B 🔺
@sentry/vue (incl. Tracing)43.93 kB+0.26%+112 B 🔺
@sentry/svelte25.33 kB+0.45%+113 B 🔺
CDN Bundle27.89 kB+0.41%+113 B 🔺
CDN Bundle (incl. Tracing)42.93 kB+0.25%+103 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.75 kB+0.25%+105 B 🔺
CDN Bundle (incl. Tracing, Replay)79.68 kB+0.17%+130 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.11 kB+0.15%+119 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.03 kB+0.15%+121 B 🔺
CDN Bundle - uncompressed81.6 kB+0.42%+335 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.14 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed129.97 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.74 kB+0.14%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.54 kB+0.13%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.35 kB+0.13%+329 B 🔺
@sentry/nextjs (client)46.73 kB+0.23%+107 B 🔺
@sentry/sveltekit (client)42.51 kB+0.28%+115 B 🔺
@sentry/node-core52.01 kB+0.21%+108 B 🔺
@sentry/node165.56 kB+0.06%+87 B 🔺
@sentry/node - without tracing93.76 kB+0.11%+103 B 🔺
@sentry/aws-serverless109.28 kB+0.11%+116 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,045-9,038+0%
GET With Sentry1,68719%1,667+1%
GET With Sentry (error only)6,03367%6,029+0%
POST Baseline1,200-1,193+1%
POST With Sentry58849%586+0%
POST With Sentry (error only)1,06489%1,038+3%
MYSQL Baseline3,283-3,377-3%
MYSQL With Sentry44113%497-11%
MYSQL With Sentry (error only)2,65081%2,733-3%

View base workflow run

@RulaKhaledRulaKhaled changed the title wip(ai): Support scope-level conversation ID for AI tracingfeat(core): Add scope-level conversation ID API to support linking AI conversationsJan 21, 2026
@RulaKhaled
RulaKhaled requested a review from Lms24January 21, 2026 15:18
Comment threadpackages/core/src/tracing/sentrySpan.ts
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/scope.ts Outdated
Comment threadpackages/core/src/scope.ts
@RulaKhaled
RulaKhaled marked this pull request as ready for review January 22, 2026 13:21
Comment threadpackages/astro/src/index.server.ts

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! LGTM now!

In the future, we also might want to export conversationIdIntegration from SDKs but as long as there's nothing to configure, I think it's fine to leave it unexported. Happy to leave that up to you :)

cursor[bot]

This comment was marked as outdated.

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


if (conversationId) {
span.setAttribute(GEN_AI_CONVERSATION_ID_ATTRIBUTE, conversationId);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration uses spanStart instead of agreed spanEnd hook

High Severity

The integration uses client.on('spanStart', ...) but the PR discussion explicitly agreed on client.on('spanEnd', ...). With spanStart, the scope's conversation ID is set first, then auto-detected values from OpenAI/LangGraph integrations override it during span execution. The PR description states scope-level values should "override any automatically detected value" which requires spanEnd so the scope value is applied last and takes precedence.

Fix in CursorFix in Web

@RulaKhaled
RulaKhaled merged commit c5e3249 into developJan 23, 2026
212 checks passed
@RulaKhaled
RulaKhaled deleted the rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api branch January 23, 2026 15:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@RulaKhaled@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(core): Add scope-level conversation ID API to support linking AI conversations - #18909

Merged
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api
Jan 23, 2026
Merged

feat(core): Add scope-level conversation ID API to support linking AI conversations#18909
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api

Conversation

@RulaKhaled

@RulaKhaledRulaKhaled commented Jan 20, 2026

Copy link
Copy Markdown
Collaborator

Introduces a new Sentry.setConversationId() API to track multi turn AI conversations across API calls.

We want to leverage each AI frameworks built-in functionalities wherever possible. OpenAIs conversation_id, sessions, etc to create the gen_ai.conversation.id attribute.
However if the framework does not provide such a mechanism (such as Google GenAI or Anthropic) we shall provide a common function: Sentry.setConversationId(...) or sentry_sdk.set_conversation_id(), which adds the conversation ID to the Scope in a similar way as Sentry.setUser() and sentry_sdk.set_user() do. When provided in such a way it will override any automatically detected value.

Why not just add this as an attribute?
it should only appear as a span attribute, not propagate to logs and metrics. This keeps AI conversation context isolated to spans where it's semantically relevant.

@linear

linearBot commented Jan 20, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.32 kB+0.46%+115 B 🔺
@sentry/browser - with treeshaking flags23.83 kB+0.51%+120 B 🔺
@sentry/browser (incl. Tracing)42.14 kB+0.27%+112 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.78 kB+0.26%+119 B 🔺
@sentry/browser (incl. Tracing, Replay)80.75 kB+0.15%+115 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.4 kB+0.15%+101 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.47 kB+0.15%+120 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.65 kB+0.12%+108 B 🔺
@sentry/browser (incl. Feedback)42.04 kB+0.28%+117 B 🔺
@sentry/browser (incl. sendFeedback)30.01 kB+0.41%+120 B 🔺
@sentry/browser (incl. FeedbackAsync)35.01 kB+0.35%+120 B 🔺
@sentry/browser (incl. Metrics)26.43 kB+0.47%+122 B 🔺
@sentry/browser (incl. Logs)26.57 kB+0.41%+108 B 🔺
@sentry/browser (incl. Metrics & Logs)27.24 kB+0.47%+125 B 🔺
@sentry/react27.05 kB+0.45%+120 B 🔺
@sentry/react (incl. Tracing)44.37 kB+0.25%+110 B 🔺
@sentry/vue29.76 kB+0.41%+119 B 🔺
@sentry/vue (incl. Tracing)43.93 kB+0.26%+112 B 🔺
@sentry/svelte25.33 kB+0.45%+113 B 🔺
CDN Bundle27.89 kB+0.41%+113 B 🔺
CDN Bundle (incl. Tracing)42.93 kB+0.25%+103 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.75 kB+0.25%+105 B 🔺
CDN Bundle (incl. Tracing, Replay)79.68 kB+0.17%+130 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.11 kB+0.15%+119 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.03 kB+0.15%+121 B 🔺
CDN Bundle - uncompressed81.6 kB+0.42%+335 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.14 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed129.97 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.74 kB+0.14%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.54 kB+0.13%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.35 kB+0.13%+329 B 🔺
@sentry/nextjs (client)46.73 kB+0.23%+107 B 🔺
@sentry/sveltekit (client)42.51 kB+0.28%+115 B 🔺
@sentry/node-core52.01 kB+0.21%+108 B 🔺
@sentry/node165.56 kB+0.06%+87 B 🔺
@sentry/node - without tracing93.76 kB+0.11%+103 B 🔺
@sentry/aws-serverless109.28 kB+0.11%+116 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,045-9,038+0%
GET With Sentry1,68719%1,667+1%
GET With Sentry (error only)6,03367%6,029+0%
POST Baseline1,200-1,193+1%
POST With Sentry58849%586+0%
POST With Sentry (error only)1,06489%1,038+3%
MYSQL Baseline3,283-3,377-3%
MYSQL With Sentry44113%497-11%
MYSQL With Sentry (error only)2,65081%2,733-3%

View base workflow run

@RulaKhaledRulaKhaled changed the title wip(ai): Support scope-level conversation ID for AI tracingfeat(core): Add scope-level conversation ID API to support linking AI conversationsJan 21, 2026
@RulaKhaled
RulaKhaled requested a review from Lms24January 21, 2026 15:18
Comment threadpackages/core/src/tracing/sentrySpan.ts
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/scope.ts Outdated
Comment threadpackages/core/src/scope.ts
@RulaKhaled
RulaKhaled marked this pull request as ready for review January 22, 2026 13:21
Comment threadpackages/astro/src/index.server.ts

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! LGTM now!

In the future, we also might want to export conversationIdIntegration from SDKs but as long as there's nothing to configure, I think it's fine to leave it unexported. Happy to leave that up to you :)

cursor[bot]

This comment was marked as outdated.

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


if (conversationId) {
span.setAttribute(GEN_AI_CONVERSATION_ID_ATTRIBUTE, conversationId);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration uses spanStart instead of agreed spanEnd hook

High Severity

The integration uses client.on('spanStart', ...) but the PR discussion explicitly agreed on client.on('spanEnd', ...). With spanStart, the scope's conversation ID is set first, then auto-detected values from OpenAI/LangGraph integrations override it during span execution. The PR description states scope-level values should "override any automatically detected value" which requires spanEnd so the scope value is applied last and takes precedence.

Fix in CursorFix in Web

@RulaKhaled
RulaKhaled merged commit c5e3249 into developJan 23, 2026
212 checks passed
@RulaKhaled
RulaKhaled deleted the rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api branch January 23, 2026 15:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@RulaKhaled@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(core): Add scope-level conversation ID API to support linking AI conversations - #18909

Merged
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api
Jan 23, 2026
Merged

feat(core): Add scope-level conversation ID API to support linking AI conversations#18909
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api

Conversation

@RulaKhaled

@RulaKhaledRulaKhaled commented Jan 20, 2026

Copy link
Copy Markdown
Collaborator

Introduces a new Sentry.setConversationId() API to track multi turn AI conversations across API calls.

We want to leverage each AI frameworks built-in functionalities wherever possible. OpenAIs conversation_id, sessions, etc to create the gen_ai.conversation.id attribute.
However if the framework does not provide such a mechanism (such as Google GenAI or Anthropic) we shall provide a common function: Sentry.setConversationId(...) or sentry_sdk.set_conversation_id(), which adds the conversation ID to the Scope in a similar way as Sentry.setUser() and sentry_sdk.set_user() do. When provided in such a way it will override any automatically detected value.

Why not just add this as an attribute?
it should only appear as a span attribute, not propagate to logs and metrics. This keeps AI conversation context isolated to spans where it's semantically relevant.

@linear

linearBot commented Jan 20, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.32 kB+0.46%+115 B 🔺
@sentry/browser - with treeshaking flags23.83 kB+0.51%+120 B 🔺
@sentry/browser (incl. Tracing)42.14 kB+0.27%+112 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.78 kB+0.26%+119 B 🔺
@sentry/browser (incl. Tracing, Replay)80.75 kB+0.15%+115 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.4 kB+0.15%+101 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.47 kB+0.15%+120 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.65 kB+0.12%+108 B 🔺
@sentry/browser (incl. Feedback)42.04 kB+0.28%+117 B 🔺
@sentry/browser (incl. sendFeedback)30.01 kB+0.41%+120 B 🔺
@sentry/browser (incl. FeedbackAsync)35.01 kB+0.35%+120 B 🔺
@sentry/browser (incl. Metrics)26.43 kB+0.47%+122 B 🔺
@sentry/browser (incl. Logs)26.57 kB+0.41%+108 B 🔺
@sentry/browser (incl. Metrics & Logs)27.24 kB+0.47%+125 B 🔺
@sentry/react27.05 kB+0.45%+120 B 🔺
@sentry/react (incl. Tracing)44.37 kB+0.25%+110 B 🔺
@sentry/vue29.76 kB+0.41%+119 B 🔺
@sentry/vue (incl. Tracing)43.93 kB+0.26%+112 B 🔺
@sentry/svelte25.33 kB+0.45%+113 B 🔺
CDN Bundle27.89 kB+0.41%+113 B 🔺
CDN Bundle (incl. Tracing)42.93 kB+0.25%+103 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.75 kB+0.25%+105 B 🔺
CDN Bundle (incl. Tracing, Replay)79.68 kB+0.17%+130 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.11 kB+0.15%+119 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.03 kB+0.15%+121 B 🔺
CDN Bundle - uncompressed81.6 kB+0.42%+335 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.14 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed129.97 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.74 kB+0.14%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.54 kB+0.13%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.35 kB+0.13%+329 B 🔺
@sentry/nextjs (client)46.73 kB+0.23%+107 B 🔺
@sentry/sveltekit (client)42.51 kB+0.28%+115 B 🔺
@sentry/node-core52.01 kB+0.21%+108 B 🔺
@sentry/node165.56 kB+0.06%+87 B 🔺
@sentry/node - without tracing93.76 kB+0.11%+103 B 🔺
@sentry/aws-serverless109.28 kB+0.11%+116 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,045-9,038+0%
GET With Sentry1,68719%1,667+1%
GET With Sentry (error only)6,03367%6,029+0%
POST Baseline1,200-1,193+1%
POST With Sentry58849%586+0%
POST With Sentry (error only)1,06489%1,038+3%
MYSQL Baseline3,283-3,377-3%
MYSQL With Sentry44113%497-11%
MYSQL With Sentry (error only)2,65081%2,733-3%

View base workflow run

@RulaKhaledRulaKhaled changed the title wip(ai): Support scope-level conversation ID for AI tracingfeat(core): Add scope-level conversation ID API to support linking AI conversationsJan 21, 2026
@RulaKhaled
RulaKhaled requested a review from Lms24January 21, 2026 15:18
Comment threadpackages/core/src/tracing/sentrySpan.ts
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/scope.ts Outdated
Comment threadpackages/core/src/scope.ts
@RulaKhaled
RulaKhaled marked this pull request as ready for review January 22, 2026 13:21
Comment threadpackages/astro/src/index.server.ts

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! LGTM now!

In the future, we also might want to export conversationIdIntegration from SDKs but as long as there's nothing to configure, I think it's fine to leave it unexported. Happy to leave that up to you :)

cursor[bot]

This comment was marked as outdated.

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


if (conversationId) {
span.setAttribute(GEN_AI_CONVERSATION_ID_ATTRIBUTE, conversationId);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration uses spanStart instead of agreed spanEnd hook

High Severity

The integration uses client.on('spanStart', ...) but the PR discussion explicitly agreed on client.on('spanEnd', ...). With spanStart, the scope's conversation ID is set first, then auto-detected values from OpenAI/LangGraph integrations override it during span execution. The PR description states scope-level values should "override any automatically detected value" which requires spanEnd so the scope value is applied last and takes precedence.

Fix in CursorFix in Web

@RulaKhaled
RulaKhaled merged commit c5e3249 into developJan 23, 2026
212 checks passed
@RulaKhaled
RulaKhaled deleted the rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api branch January 23, 2026 15:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@RulaKhaled@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(core): Add scope-level conversation ID API to support linking AI conversations - #18909

Merged
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api
Jan 23, 2026
Merged

feat(core): Add scope-level conversation ID API to support linking AI conversations#18909
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api

Conversation

@RulaKhaled

@RulaKhaledRulaKhaled commented Jan 20, 2026

Copy link
Copy Markdown
Collaborator

Introduces a new Sentry.setConversationId() API to track multi turn AI conversations across API calls.

We want to leverage each AI frameworks built-in functionalities wherever possible. OpenAIs conversation_id, sessions, etc to create the gen_ai.conversation.id attribute.
However if the framework does not provide such a mechanism (such as Google GenAI or Anthropic) we shall provide a common function: Sentry.setConversationId(...) or sentry_sdk.set_conversation_id(), which adds the conversation ID to the Scope in a similar way as Sentry.setUser() and sentry_sdk.set_user() do. When provided in such a way it will override any automatically detected value.

Why not just add this as an attribute?
it should only appear as a span attribute, not propagate to logs and metrics. This keeps AI conversation context isolated to spans where it's semantically relevant.

@linear

linearBot commented Jan 20, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.32 kB+0.46%+115 B 🔺
@sentry/browser - with treeshaking flags23.83 kB+0.51%+120 B 🔺
@sentry/browser (incl. Tracing)42.14 kB+0.27%+112 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.78 kB+0.26%+119 B 🔺
@sentry/browser (incl. Tracing, Replay)80.75 kB+0.15%+115 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.4 kB+0.15%+101 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.47 kB+0.15%+120 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.65 kB+0.12%+108 B 🔺
@sentry/browser (incl. Feedback)42.04 kB+0.28%+117 B 🔺
@sentry/browser (incl. sendFeedback)30.01 kB+0.41%+120 B 🔺
@sentry/browser (incl. FeedbackAsync)35.01 kB+0.35%+120 B 🔺
@sentry/browser (incl. Metrics)26.43 kB+0.47%+122 B 🔺
@sentry/browser (incl. Logs)26.57 kB+0.41%+108 B 🔺
@sentry/browser (incl. Metrics & Logs)27.24 kB+0.47%+125 B 🔺
@sentry/react27.05 kB+0.45%+120 B 🔺
@sentry/react (incl. Tracing)44.37 kB+0.25%+110 B 🔺
@sentry/vue29.76 kB+0.41%+119 B 🔺
@sentry/vue (incl. Tracing)43.93 kB+0.26%+112 B 🔺
@sentry/svelte25.33 kB+0.45%+113 B 🔺
CDN Bundle27.89 kB+0.41%+113 B 🔺
CDN Bundle (incl. Tracing)42.93 kB+0.25%+103 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.75 kB+0.25%+105 B 🔺
CDN Bundle (incl. Tracing, Replay)79.68 kB+0.17%+130 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.11 kB+0.15%+119 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.03 kB+0.15%+121 B 🔺
CDN Bundle - uncompressed81.6 kB+0.42%+335 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.14 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed129.97 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.74 kB+0.14%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.54 kB+0.13%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.35 kB+0.13%+329 B 🔺
@sentry/nextjs (client)46.73 kB+0.23%+107 B 🔺
@sentry/sveltekit (client)42.51 kB+0.28%+115 B 🔺
@sentry/node-core52.01 kB+0.21%+108 B 🔺
@sentry/node165.56 kB+0.06%+87 B 🔺
@sentry/node - without tracing93.76 kB+0.11%+103 B 🔺
@sentry/aws-serverless109.28 kB+0.11%+116 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,045-9,038+0%
GET With Sentry1,68719%1,667+1%
GET With Sentry (error only)6,03367%6,029+0%
POST Baseline1,200-1,193+1%
POST With Sentry58849%586+0%
POST With Sentry (error only)1,06489%1,038+3%
MYSQL Baseline3,283-3,377-3%
MYSQL With Sentry44113%497-11%
MYSQL With Sentry (error only)2,65081%2,733-3%

View base workflow run

@RulaKhaledRulaKhaled changed the title wip(ai): Support scope-level conversation ID for AI tracingfeat(core): Add scope-level conversation ID API to support linking AI conversationsJan 21, 2026
@RulaKhaled
RulaKhaled requested a review from Lms24January 21, 2026 15:18
Comment threadpackages/core/src/tracing/sentrySpan.ts
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/scope.ts Outdated
Comment threadpackages/core/src/scope.ts
@RulaKhaled
RulaKhaled marked this pull request as ready for review January 22, 2026 13:21
Comment threadpackages/astro/src/index.server.ts

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! LGTM now!

In the future, we also might want to export conversationIdIntegration from SDKs but as long as there's nothing to configure, I think it's fine to leave it unexported. Happy to leave that up to you :)

cursor[bot]

This comment was marked as outdated.

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


if (conversationId) {
span.setAttribute(GEN_AI_CONVERSATION_ID_ATTRIBUTE, conversationId);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration uses spanStart instead of agreed spanEnd hook

High Severity

The integration uses client.on('spanStart', ...) but the PR discussion explicitly agreed on client.on('spanEnd', ...). With spanStart, the scope's conversation ID is set first, then auto-detected values from OpenAI/LangGraph integrations override it during span execution. The PR description states scope-level values should "override any automatically detected value" which requires spanEnd so the scope value is applied last and takes precedence.

Fix in CursorFix in Web

@RulaKhaled
RulaKhaled merged commit c5e3249 into developJan 23, 2026
212 checks passed
@RulaKhaled
RulaKhaled deleted the rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api branch January 23, 2026 15:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@RulaKhaled@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(core): Add scope-level conversation ID API to support linking AI conversations - #18909

Merged
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api
Jan 23, 2026
Merged

feat(core): Add scope-level conversation ID API to support linking AI conversations#18909
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api

Conversation

@RulaKhaled

@RulaKhaledRulaKhaled commented Jan 20, 2026

Copy link
Copy Markdown
Collaborator

Introduces a new Sentry.setConversationId() API to track multi turn AI conversations across API calls.

We want to leverage each AI frameworks built-in functionalities wherever possible. OpenAIs conversation_id, sessions, etc to create the gen_ai.conversation.id attribute.
However if the framework does not provide such a mechanism (such as Google GenAI or Anthropic) we shall provide a common function: Sentry.setConversationId(...) or sentry_sdk.set_conversation_id(), which adds the conversation ID to the Scope in a similar way as Sentry.setUser() and sentry_sdk.set_user() do. When provided in such a way it will override any automatically detected value.

Why not just add this as an attribute?
it should only appear as a span attribute, not propagate to logs and metrics. This keeps AI conversation context isolated to spans where it's semantically relevant.

@linear

linearBot commented Jan 20, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.32 kB+0.46%+115 B 🔺
@sentry/browser - with treeshaking flags23.83 kB+0.51%+120 B 🔺
@sentry/browser (incl. Tracing)42.14 kB+0.27%+112 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.78 kB+0.26%+119 B 🔺
@sentry/browser (incl. Tracing, Replay)80.75 kB+0.15%+115 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.4 kB+0.15%+101 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.47 kB+0.15%+120 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.65 kB+0.12%+108 B 🔺
@sentry/browser (incl. Feedback)42.04 kB+0.28%+117 B 🔺
@sentry/browser (incl. sendFeedback)30.01 kB+0.41%+120 B 🔺
@sentry/browser (incl. FeedbackAsync)35.01 kB+0.35%+120 B 🔺
@sentry/browser (incl. Metrics)26.43 kB+0.47%+122 B 🔺
@sentry/browser (incl. Logs)26.57 kB+0.41%+108 B 🔺
@sentry/browser (incl. Metrics & Logs)27.24 kB+0.47%+125 B 🔺
@sentry/react27.05 kB+0.45%+120 B 🔺
@sentry/react (incl. Tracing)44.37 kB+0.25%+110 B 🔺
@sentry/vue29.76 kB+0.41%+119 B 🔺
@sentry/vue (incl. Tracing)43.93 kB+0.26%+112 B 🔺
@sentry/svelte25.33 kB+0.45%+113 B 🔺
CDN Bundle27.89 kB+0.41%+113 B 🔺
CDN Bundle (incl. Tracing)42.93 kB+0.25%+103 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.75 kB+0.25%+105 B 🔺
CDN Bundle (incl. Tracing, Replay)79.68 kB+0.17%+130 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.11 kB+0.15%+119 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.03 kB+0.15%+121 B 🔺
CDN Bundle - uncompressed81.6 kB+0.42%+335 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.14 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed129.97 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.74 kB+0.14%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.54 kB+0.13%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.35 kB+0.13%+329 B 🔺
@sentry/nextjs (client)46.73 kB+0.23%+107 B 🔺
@sentry/sveltekit (client)42.51 kB+0.28%+115 B 🔺
@sentry/node-core52.01 kB+0.21%+108 B 🔺
@sentry/node165.56 kB+0.06%+87 B 🔺
@sentry/node - without tracing93.76 kB+0.11%+103 B 🔺
@sentry/aws-serverless109.28 kB+0.11%+116 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,045-9,038+0%
GET With Sentry1,68719%1,667+1%
GET With Sentry (error only)6,03367%6,029+0%
POST Baseline1,200-1,193+1%
POST With Sentry58849%586+0%
POST With Sentry (error only)1,06489%1,038+3%
MYSQL Baseline3,283-3,377-3%
MYSQL With Sentry44113%497-11%
MYSQL With Sentry (error only)2,65081%2,733-3%

View base workflow run

@RulaKhaledRulaKhaled changed the title wip(ai): Support scope-level conversation ID for AI tracingfeat(core): Add scope-level conversation ID API to support linking AI conversationsJan 21, 2026
@RulaKhaled
RulaKhaled requested a review from Lms24January 21, 2026 15:18
Comment threadpackages/core/src/tracing/sentrySpan.ts
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/scope.ts Outdated
Comment threadpackages/core/src/scope.ts
@RulaKhaled
RulaKhaled marked this pull request as ready for review January 22, 2026 13:21
Comment threadpackages/astro/src/index.server.ts

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! LGTM now!

In the future, we also might want to export conversationIdIntegration from SDKs but as long as there's nothing to configure, I think it's fine to leave it unexported. Happy to leave that up to you :)

cursor[bot]

This comment was marked as outdated.

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


if (conversationId) {
span.setAttribute(GEN_AI_CONVERSATION_ID_ATTRIBUTE, conversationId);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration uses spanStart instead of agreed spanEnd hook

High Severity

The integration uses client.on('spanStart', ...) but the PR discussion explicitly agreed on client.on('spanEnd', ...). With spanStart, the scope's conversation ID is set first, then auto-detected values from OpenAI/LangGraph integrations override it during span execution. The PR description states scope-level values should "override any automatically detected value" which requires spanEnd so the scope value is applied last and takes precedence.

Fix in CursorFix in Web

@RulaKhaled
RulaKhaled merged commit c5e3249 into developJan 23, 2026
212 checks passed
@RulaKhaled
RulaKhaled deleted the rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api branch January 23, 2026 15:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@RulaKhaled@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(core): Add scope-level conversation ID API to support linking AI conversations - #18909

Merged
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api
Jan 23, 2026
Merged

feat(core): Add scope-level conversation ID API to support linking AI conversations#18909
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api

Conversation

@RulaKhaled

@RulaKhaledRulaKhaled commented Jan 20, 2026

Copy link
Copy Markdown
Collaborator

Introduces a new Sentry.setConversationId() API to track multi turn AI conversations across API calls.

We want to leverage each AI frameworks built-in functionalities wherever possible. OpenAIs conversation_id, sessions, etc to create the gen_ai.conversation.id attribute.
However if the framework does not provide such a mechanism (such as Google GenAI or Anthropic) we shall provide a common function: Sentry.setConversationId(...) or sentry_sdk.set_conversation_id(), which adds the conversation ID to the Scope in a similar way as Sentry.setUser() and sentry_sdk.set_user() do. When provided in such a way it will override any automatically detected value.

Why not just add this as an attribute?
it should only appear as a span attribute, not propagate to logs and metrics. This keeps AI conversation context isolated to spans where it's semantically relevant.

@linear

linearBot commented Jan 20, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.32 kB+0.46%+115 B 🔺
@sentry/browser - with treeshaking flags23.83 kB+0.51%+120 B 🔺
@sentry/browser (incl. Tracing)42.14 kB+0.27%+112 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.78 kB+0.26%+119 B 🔺
@sentry/browser (incl. Tracing, Replay)80.75 kB+0.15%+115 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.4 kB+0.15%+101 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.47 kB+0.15%+120 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.65 kB+0.12%+108 B 🔺
@sentry/browser (incl. Feedback)42.04 kB+0.28%+117 B 🔺
@sentry/browser (incl. sendFeedback)30.01 kB+0.41%+120 B 🔺
@sentry/browser (incl. FeedbackAsync)35.01 kB+0.35%+120 B 🔺
@sentry/browser (incl. Metrics)26.43 kB+0.47%+122 B 🔺
@sentry/browser (incl. Logs)26.57 kB+0.41%+108 B 🔺
@sentry/browser (incl. Metrics & Logs)27.24 kB+0.47%+125 B 🔺
@sentry/react27.05 kB+0.45%+120 B 🔺
@sentry/react (incl. Tracing)44.37 kB+0.25%+110 B 🔺
@sentry/vue29.76 kB+0.41%+119 B 🔺
@sentry/vue (incl. Tracing)43.93 kB+0.26%+112 B 🔺
@sentry/svelte25.33 kB+0.45%+113 B 🔺
CDN Bundle27.89 kB+0.41%+113 B 🔺
CDN Bundle (incl. Tracing)42.93 kB+0.25%+103 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.75 kB+0.25%+105 B 🔺
CDN Bundle (incl. Tracing, Replay)79.68 kB+0.17%+130 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.11 kB+0.15%+119 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.03 kB+0.15%+121 B 🔺
CDN Bundle - uncompressed81.6 kB+0.42%+335 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.14 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed129.97 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.74 kB+0.14%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.54 kB+0.13%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.35 kB+0.13%+329 B 🔺
@sentry/nextjs (client)46.73 kB+0.23%+107 B 🔺
@sentry/sveltekit (client)42.51 kB+0.28%+115 B 🔺
@sentry/node-core52.01 kB+0.21%+108 B 🔺
@sentry/node165.56 kB+0.06%+87 B 🔺
@sentry/node - without tracing93.76 kB+0.11%+103 B 🔺
@sentry/aws-serverless109.28 kB+0.11%+116 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,045-9,038+0%
GET With Sentry1,68719%1,667+1%
GET With Sentry (error only)6,03367%6,029+0%
POST Baseline1,200-1,193+1%
POST With Sentry58849%586+0%
POST With Sentry (error only)1,06489%1,038+3%
MYSQL Baseline3,283-3,377-3%
MYSQL With Sentry44113%497-11%
MYSQL With Sentry (error only)2,65081%2,733-3%

View base workflow run

@RulaKhaledRulaKhaled changed the title wip(ai): Support scope-level conversation ID for AI tracingfeat(core): Add scope-level conversation ID API to support linking AI conversationsJan 21, 2026
@RulaKhaled
RulaKhaled requested a review from Lms24January 21, 2026 15:18
Comment threadpackages/core/src/tracing/sentrySpan.ts
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/scope.ts Outdated
Comment threadpackages/core/src/scope.ts
@RulaKhaled
RulaKhaled marked this pull request as ready for review January 22, 2026 13:21
Comment threadpackages/astro/src/index.server.ts

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! LGTM now!

In the future, we also might want to export conversationIdIntegration from SDKs but as long as there's nothing to configure, I think it's fine to leave it unexported. Happy to leave that up to you :)

cursor[bot]

This comment was marked as outdated.

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


if (conversationId) {
span.setAttribute(GEN_AI_CONVERSATION_ID_ATTRIBUTE, conversationId);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration uses spanStart instead of agreed spanEnd hook

High Severity

The integration uses client.on('spanStart', ...) but the PR discussion explicitly agreed on client.on('spanEnd', ...). With spanStart, the scope's conversation ID is set first, then auto-detected values from OpenAI/LangGraph integrations override it during span execution. The PR description states scope-level values should "override any automatically detected value" which requires spanEnd so the scope value is applied last and takes precedence.

Fix in CursorFix in Web

@RulaKhaled
RulaKhaled merged commit c5e3249 into developJan 23, 2026
212 checks passed
@RulaKhaled
RulaKhaled deleted the rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api branch January 23, 2026 15:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@RulaKhaled@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(core): Add scope-level conversation ID API to support linking AI conversations - #18909

Merged
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api
Jan 23, 2026
Merged

feat(core): Add scope-level conversation ID API to support linking AI conversations#18909
RulaKhaled merged 9 commits into
developfrom
rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api

Conversation

@RulaKhaled

@RulaKhaledRulaKhaled commented Jan 20, 2026

Copy link
Copy Markdown
Collaborator

Introduces a new Sentry.setConversationId() API to track multi turn AI conversations across API calls.

We want to leverage each AI frameworks built-in functionalities wherever possible. OpenAIs conversation_id, sessions, etc to create the gen_ai.conversation.id attribute.
However if the framework does not provide such a mechanism (such as Google GenAI or Anthropic) we shall provide a common function: Sentry.setConversationId(...) or sentry_sdk.set_conversation_id(), which adds the conversation ID to the Scope in a similar way as Sentry.setUser() and sentry_sdk.set_user() do. When provided in such a way it will override any automatically detected value.

Why not just add this as an attribute?
it should only appear as a span attribute, not propagate to logs and metrics. This keeps AI conversation context isolated to spans where it's semantically relevant.

@linear

linearBot commented Jan 20, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.32 kB+0.46%+115 B 🔺
@sentry/browser - with treeshaking flags23.83 kB+0.51%+120 B 🔺
@sentry/browser (incl. Tracing)42.14 kB+0.27%+112 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.78 kB+0.26%+119 B 🔺
@sentry/browser (incl. Tracing, Replay)80.75 kB+0.15%+115 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.4 kB+0.15%+101 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.47 kB+0.15%+120 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.65 kB+0.12%+108 B 🔺
@sentry/browser (incl. Feedback)42.04 kB+0.28%+117 B 🔺
@sentry/browser (incl. sendFeedback)30.01 kB+0.41%+120 B 🔺
@sentry/browser (incl. FeedbackAsync)35.01 kB+0.35%+120 B 🔺
@sentry/browser (incl. Metrics)26.43 kB+0.47%+122 B 🔺
@sentry/browser (incl. Logs)26.57 kB+0.41%+108 B 🔺
@sentry/browser (incl. Metrics & Logs)27.24 kB+0.47%+125 B 🔺
@sentry/react27.05 kB+0.45%+120 B 🔺
@sentry/react (incl. Tracing)44.37 kB+0.25%+110 B 🔺
@sentry/vue29.76 kB+0.41%+119 B 🔺
@sentry/vue (incl. Tracing)43.93 kB+0.26%+112 B 🔺
@sentry/svelte25.33 kB+0.45%+113 B 🔺
CDN Bundle27.89 kB+0.41%+113 B 🔺
CDN Bundle (incl. Tracing)42.93 kB+0.25%+103 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.75 kB+0.25%+105 B 🔺
CDN Bundle (incl. Tracing, Replay)79.68 kB+0.17%+130 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.11 kB+0.15%+119 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.03 kB+0.15%+121 B 🔺
CDN Bundle - uncompressed81.6 kB+0.42%+335 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.14 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed129.97 kB+0.26%+329 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.74 kB+0.14%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.54 kB+0.13%+329 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.35 kB+0.13%+329 B 🔺
@sentry/nextjs (client)46.73 kB+0.23%+107 B 🔺
@sentry/sveltekit (client)42.51 kB+0.28%+115 B 🔺
@sentry/node-core52.01 kB+0.21%+108 B 🔺
@sentry/node165.56 kB+0.06%+87 B 🔺
@sentry/node - without tracing93.76 kB+0.11%+103 B 🔺
@sentry/aws-serverless109.28 kB+0.11%+116 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,045-9,038+0%
GET With Sentry1,68719%1,667+1%
GET With Sentry (error only)6,03367%6,029+0%
POST Baseline1,200-1,193+1%
POST With Sentry58849%586+0%
POST With Sentry (error only)1,06489%1,038+3%
MYSQL Baseline3,283-3,377-3%
MYSQL With Sentry44113%497-11%
MYSQL With Sentry (error only)2,65081%2,733-3%

View base workflow run

@RulaKhaledRulaKhaled changed the title wip(ai): Support scope-level conversation ID for AI tracingfeat(core): Add scope-level conversation ID API to support linking AI conversationsJan 21, 2026
@RulaKhaled
RulaKhaled requested a review from Lms24January 21, 2026 15:18
Comment threadpackages/core/src/tracing/sentrySpan.ts
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
Comment threadpackages/core/src/scope.ts Outdated
Comment threadpackages/core/src/scope.ts
@RulaKhaled
RulaKhaled marked this pull request as ready for review January 22, 2026 13:21
Comment threadpackages/astro/src/index.server.ts

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! LGTM now!

In the future, we also might want to export conversationIdIntegration from SDKs but as long as there's nothing to configure, I think it's fine to leave it unexported. Happy to leave that up to you :)

cursor[bot]

This comment was marked as outdated.

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


if (conversationId) {
span.setAttribute(GEN_AI_CONVERSATION_ID_ATTRIBUTE, conversationId);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration uses spanStart instead of agreed spanEnd hook

High Severity

The integration uses client.on('spanStart', ...) but the PR discussion explicitly agreed on client.on('spanEnd', ...). With spanStart, the scope's conversation ID is set first, then auto-detected values from OpenAI/LangGraph integrations override it during span execution. The PR description states scope-level values should "override any automatically detected value" which requires spanEnd so the scope value is applied last and takes precedence.

Fix in CursorFix in Web

@RulaKhaled
RulaKhaled merged commit c5e3249 into developJan 23, 2026
212 checks passed
@RulaKhaled
RulaKhaled deleted the rolaabuhasna/js-1515-implement-a-new-sentrysetconversationid-api branch January 23, 2026 15:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@RulaKhaled@Lms24