Uh oh!
There was an error while loading. Please reload this page.
fix(core): Report well known values in gen_ai.operation.name attribute - #18925
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Uh oh!
There was an error while loading. Please reload this page.
4bc1034 to
ea1883cCompare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…lues-in-gen_aioperationname-attribute
| { | ||
| name: `${operationName} ${modelName}`, | ||
| op: 'gen_ai.pipeline', | ||
| op: 'gen_ai.invoke_agent', |
There was a problem hiding this comment.
m: isn't this for single llm calls? in that case wouldn't chat be more suitable?
There was a problem hiding this comment.
because langchain also has a separate create_agent API: https://docs.langchain.com/oss/python/langchain/agents#static-model
so to me it would seem that we should use chat for individual invokations and invoke_agent if the agent is invoked
There was a problem hiding this comment.
Makes sense, i kept going back and forth on this one. having a separate create_agent API settles it
Uh oh!
There was an error while loading. Please reload this page.
| } | ||
| // Return the original value for unknown operations | ||
| return operationName; | ||
| } |
There was a problem hiding this comment.
l: I think it would be better to use sets in this method and then just do a lookup in the condition e.g. INVOKE_AGENT_OPS that contains the operations we want to map to invoke_agent
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…lues-in-gen_aioperationname-attribute
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AI integrations should follow OTel spec and report the gen_ai.operation.name with the values listed in sentry conventions if applies getsentry/sentry-conventions#225, this PR renames gen_ai.operation so that if one of values applies, then that value MUST be used.
Closes https://linear.app/getsentry/issue/JS-1527/report-well-known-values-in-gen-aioperationname-attribute