feat(nextjs): Update default ignore list for sourcemaps#18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 4 commits into from
Jan 23, 2026
Merged

feat(nextjs): Update default ignore list for sourcemaps #18938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
916b2ad
update default ignore
chargome Jan 22, 2026
d4efe82
Merge branch 'develop' into cg/JS-1501/nextjs-add-option-to-suppress-…
chargome Jan 22, 2026
9cdbabe
rm logs
chargome Jan 22, 2026
a332750
hold my horses
chargome Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions packages/nextjs/src/config/getBuildPluginOptions.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,13 @@ const FILE_PATTERNS = {
FRAMEWORK_CHUNKS_DOT: 'static/chunks/framework.*',
POLYFILLS_CHUNKS: 'static/chunks/polyfills-*',
WEBPACK_CHUNKS: 'static/chunks/webpack-*',
PAGE_CLIENT_REFERENCE_MANIFEST: '**/page_client-reference-manifest.js',
SERVER_REFERENCE_MANIFEST: '**/server-reference-manifest.js',
NEXT_FONT_MANIFEST: '**/next-font-manifest.js',
MIDDLEWARE_BUILD_MANIFEST: '**/middleware-build-manifest.js',
INTERCEPTION_ROUTE_REWRITE_MANIFEST: '**/interception-route-rewrite-manifest.js',
ROUTE_CLIENT_REFERENCE_MANIFEST: '**/route_client-reference-manifest.js',
MIDDLEWARE_REACT_LOADABLE_MANIFEST: '**/middleware-react-loadable-manifest.js',
} as const;

// Source map file extensions to delete
Expand DownExpand Up@@ -142,6 +149,16 @@ function createSourcemapUploadIgnorePattern(
path.posix.join(normalizedDistPath, FILE_PATTERNS.FRAMEWORK_CHUNKS_DOT),
path.posix.join(normalizedDistPath, FILE_PATTERNS.POLYFILLS_CHUNKS),
path.posix.join(normalizedDistPath, FILE_PATTERNS.WEBPACK_CHUNKS),
// Next.js internal manifest files that don't have source maps
// These files are auto-generated by Next.js and do not contain user code.
// Ignoring them prevents "Could not determine source map reference" warnings.
FILE_PATTERNS.PAGE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.SERVER_REFERENCE_MANIFEST,
FILE_PATTERNS.NEXT_FONT_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_BUILD_MANIFEST,
FILE_PATTERNS.INTERCEPTION_ROUTE_REWRITE_MANIFEST,
FILE_PATTERNS.ROUTE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_REACT_LOADABLE_MANIFEST,
);

return ignore;
Expand DownExpand Up@@ -216,6 +233,20 @@ function createReleaseConfig(
};
}

/**
* Merges default ignore patterns with user-provided ignore patterns.
* User patterns are appended to the defaults to ensure internal Next.js
* files are always ignored while allowing users to add additional patterns.
*/
function mergeIgnorePatterns(defaultPatterns: string[], userPatterns: string | string[] | undefined): string[] {
if (!userPatterns) {
return defaultPatterns;
}

const userPatternsArray = Array.isArray(userPatterns) ? userPatterns : [userPatterns];
return [...defaultPatterns, ...userPatternsArray];
}

/**
* Get Sentry Build Plugin options for both webpack and turbopack builds.
* These options can be used in two ways:
Expand All@@ -239,7 +270,6 @@ export function getBuildPluginOptions({
// glob characters. This clashes with Windows path separators.
// See: https://www.npmjs.com/package/glob
const normalizedDistDirAbsPath = normalizePathForGlob(distDirAbsPath);

const loggerPrefix = LOGGER_PREFIXES[buildTool];
const widenClientFileUpload = sentryBuildOptions.widenClientFileUpload ?? false;
const deleteSourcemapsAfterUpload = sentryBuildOptions.sourcemaps?.deleteSourcemapsAfterUpload ?? false;
Expand All@@ -252,6 +282,8 @@ export function getBuildPluginOptions({

const sourcemapUploadIgnore = createSourcemapUploadIgnorePattern(normalizedDistDirAbsPath, widenClientFileUpload);

const finalIgnorePatterns = mergeIgnorePatterns(sourcemapUploadIgnore, sentryBuildOptions.sourcemaps?.ignore);

const filesToDeleteAfterUpload = createFilesToDeleteAfterUploadPattern(
normalizedDistDirAbsPath,
buildTool,
Expand DownExpand Up@@ -281,7 +313,7 @@ export function getBuildPluginOptions({
disable: skipSourcemapsUpload ? true : (sentryBuildOptions.sourcemaps?.disable ?? false),
rewriteSources: rewriteWebpackSources,
assets: sentryBuildOptions.sourcemaps?.assets ?? sourcemapUploadAssets,
ignore: sentryBuildOptions.sourcemaps?.ignore ?? sourcemapUploadIgnore,
ignore: finalIgnorePatterns,
filesToDeleteAfterUpload,
...sentryBuildOptions.webpack?.unstable_sentryWebpackPluginOptions?.sourcemaps,
Comment thread
sentry[bot] marked this conversation as resolved.
},
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/config/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -261,7 +261,8 @@ export type SentryBuildOptions = {
/**
* A glob or an array of globs that specifies which build artifacts should not be uploaded to Sentry.
*
* Default: `[]`
* The SDK automatically ignores Next.js internal files that don't have source maps (such as manifest files)
* to prevent "Could not determine source map" warnings. Your custom patterns are merged with these defaults.
*
* The globbing patterns follow the implementation of the `glob` package. (https://www.npmjs.com/package/glob)
*
Expand Down
111 changes: 109 additions & 2 deletions packages/nextjs/test/config/getBuildPluginOptions.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand DownExpand Up@@ -121,6 +128,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -142,6 +156,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
});

Expand All@@ -161,6 +182,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -181,6 +209,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -205,6 +240,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand All@@ -228,6 +270,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand DownExpand Up@@ -444,7 +493,7 @@ describe('getBuildPluginOptions', () => {
expect(result.sourcemaps?.assets).toEqual(customAssets);
});

it('uses custom sourcemap ignore patterns when provided', () => {
it('merges custom sourcemap ignore patterns with defaults', () => {
const customIgnore = ['**/vendor/**', '**/node_modules/**'];
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
Expand All@@ -461,7 +510,58 @@ describe('getBuildPluginOptions', () => {
buildTool: 'webpack-client',
});

expect(result.sourcemaps?.ignore).toEqual(customIgnore);
// Custom patterns should be appended to defaults, not replace them
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
'**/node_modules/**',
]);
});

it('handles single string custom sourcemap ignore pattern', () => {
const customIgnore = '**/vendor/**';
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
project: 'test-project',
sourcemaps: {
ignore: customIgnore,
},
};

const result = getBuildPluginOptions({
sentryBuildOptions,
releaseName: mockReleaseName,
distDirAbsPath: mockDistDirAbsPath,
buildTool: 'webpack-client',
});

// Single string pattern should be appended to defaults
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
]);

@cursorcursorBotJan 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing integration or E2E test for feature PR

Low Severity · Bugbot Rules

This feat PR changes the sourcemap ignore pattern behavior (merging user patterns with defaults instead of replacing) but only includes unit tests. Per the review rules: "When reviewing a feat PR, check if the PR includes at least one integration or E2E test. If neither of the two are present, add a comment, recommending to add one." An integration test verifying the actual sourcemap upload/ignore behavior with the new merged patterns would help ensure the feature works correctly in real build scenarios.

Fix in CursorFix in Web

});

it('disables sourcemaps when disable flag is set', () => {
Expand DownExpand Up@@ -769,6 +869,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(nextjs): Update default ignore list for sourcemaps#18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 4 commits into from
Jan 23, 2026
Merged

feat(nextjs): Update default ignore list for sourcemaps #18938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
916b2ad
update default ignore
chargome Jan 22, 2026
d4efe82
Merge branch 'develop' into cg/JS-1501/nextjs-add-option-to-suppress-…
chargome Jan 22, 2026
9cdbabe
rm logs
chargome Jan 22, 2026
a332750
hold my horses
chargome Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions packages/nextjs/src/config/getBuildPluginOptions.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,13 @@ const FILE_PATTERNS = {
FRAMEWORK_CHUNKS_DOT: 'static/chunks/framework.*',
POLYFILLS_CHUNKS: 'static/chunks/polyfills-*',
WEBPACK_CHUNKS: 'static/chunks/webpack-*',
PAGE_CLIENT_REFERENCE_MANIFEST: '**/page_client-reference-manifest.js',
SERVER_REFERENCE_MANIFEST: '**/server-reference-manifest.js',
NEXT_FONT_MANIFEST: '**/next-font-manifest.js',
MIDDLEWARE_BUILD_MANIFEST: '**/middleware-build-manifest.js',
INTERCEPTION_ROUTE_REWRITE_MANIFEST: '**/interception-route-rewrite-manifest.js',
ROUTE_CLIENT_REFERENCE_MANIFEST: '**/route_client-reference-manifest.js',
MIDDLEWARE_REACT_LOADABLE_MANIFEST: '**/middleware-react-loadable-manifest.js',
} as const;

// Source map file extensions to delete
Expand DownExpand Up@@ -142,6 +149,16 @@ function createSourcemapUploadIgnorePattern(
path.posix.join(normalizedDistPath, FILE_PATTERNS.FRAMEWORK_CHUNKS_DOT),
path.posix.join(normalizedDistPath, FILE_PATTERNS.POLYFILLS_CHUNKS),
path.posix.join(normalizedDistPath, FILE_PATTERNS.WEBPACK_CHUNKS),
// Next.js internal manifest files that don't have source maps
// These files are auto-generated by Next.js and do not contain user code.
// Ignoring them prevents "Could not determine source map reference" warnings.
FILE_PATTERNS.PAGE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.SERVER_REFERENCE_MANIFEST,
FILE_PATTERNS.NEXT_FONT_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_BUILD_MANIFEST,
FILE_PATTERNS.INTERCEPTION_ROUTE_REWRITE_MANIFEST,
FILE_PATTERNS.ROUTE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_REACT_LOADABLE_MANIFEST,
);

return ignore;
Expand DownExpand Up@@ -216,6 +233,20 @@ function createReleaseConfig(
};
}

/**
* Merges default ignore patterns with user-provided ignore patterns.
* User patterns are appended to the defaults to ensure internal Next.js
* files are always ignored while allowing users to add additional patterns.
*/
function mergeIgnorePatterns(defaultPatterns: string[], userPatterns: string | string[] | undefined): string[] {
if (!userPatterns) {
return defaultPatterns;
}

const userPatternsArray = Array.isArray(userPatterns) ? userPatterns : [userPatterns];
return [...defaultPatterns, ...userPatternsArray];
}

/**
* Get Sentry Build Plugin options for both webpack and turbopack builds.
* These options can be used in two ways:
Expand All@@ -239,7 +270,6 @@ export function getBuildPluginOptions({
// glob characters. This clashes with Windows path separators.
// See: https://www.npmjs.com/package/glob
const normalizedDistDirAbsPath = normalizePathForGlob(distDirAbsPath);

const loggerPrefix = LOGGER_PREFIXES[buildTool];
const widenClientFileUpload = sentryBuildOptions.widenClientFileUpload ?? false;
const deleteSourcemapsAfterUpload = sentryBuildOptions.sourcemaps?.deleteSourcemapsAfterUpload ?? false;
Expand All@@ -252,6 +282,8 @@ export function getBuildPluginOptions({

const sourcemapUploadIgnore = createSourcemapUploadIgnorePattern(normalizedDistDirAbsPath, widenClientFileUpload);

const finalIgnorePatterns = mergeIgnorePatterns(sourcemapUploadIgnore, sentryBuildOptions.sourcemaps?.ignore);

const filesToDeleteAfterUpload = createFilesToDeleteAfterUploadPattern(
normalizedDistDirAbsPath,
buildTool,
Expand DownExpand Up@@ -281,7 +313,7 @@ export function getBuildPluginOptions({
disable: skipSourcemapsUpload ? true : (sentryBuildOptions.sourcemaps?.disable ?? false),
rewriteSources: rewriteWebpackSources,
assets: sentryBuildOptions.sourcemaps?.assets ?? sourcemapUploadAssets,
ignore: sentryBuildOptions.sourcemaps?.ignore ?? sourcemapUploadIgnore,
ignore: finalIgnorePatterns,
filesToDeleteAfterUpload,
...sentryBuildOptions.webpack?.unstable_sentryWebpackPluginOptions?.sourcemaps,
Comment thread
sentry[bot] marked this conversation as resolved.
},
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/config/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -261,7 +261,8 @@ export type SentryBuildOptions = {
/**
* A glob or an array of globs that specifies which build artifacts should not be uploaded to Sentry.
*
* Default: `[]`
* The SDK automatically ignores Next.js internal files that don't have source maps (such as manifest files)
* to prevent "Could not determine source map" warnings. Your custom patterns are merged with these defaults.
*
* The globbing patterns follow the implementation of the `glob` package. (https://www.npmjs.com/package/glob)
*
Expand Down
111 changes: 109 additions & 2 deletions packages/nextjs/test/config/getBuildPluginOptions.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand DownExpand Up@@ -121,6 +128,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -142,6 +156,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
});

Expand All@@ -161,6 +182,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -181,6 +209,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -205,6 +240,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand All@@ -228,6 +270,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand DownExpand Up@@ -444,7 +493,7 @@ describe('getBuildPluginOptions', () => {
expect(result.sourcemaps?.assets).toEqual(customAssets);
});

it('uses custom sourcemap ignore patterns when provided', () => {
it('merges custom sourcemap ignore patterns with defaults', () => {
const customIgnore = ['**/vendor/**', '**/node_modules/**'];
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
Expand All@@ -461,7 +510,58 @@ describe('getBuildPluginOptions', () => {
buildTool: 'webpack-client',
});

expect(result.sourcemaps?.ignore).toEqual(customIgnore);
// Custom patterns should be appended to defaults, not replace them
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
'**/node_modules/**',
]);
});

it('handles single string custom sourcemap ignore pattern', () => {
const customIgnore = '**/vendor/**';
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
project: 'test-project',
sourcemaps: {
ignore: customIgnore,
},
};

const result = getBuildPluginOptions({
sentryBuildOptions,
releaseName: mockReleaseName,
distDirAbsPath: mockDistDirAbsPath,
buildTool: 'webpack-client',
});

// Single string pattern should be appended to defaults
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
]);

@cursorcursorBotJan 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing integration or E2E test for feature PR

Low Severity · Bugbot Rules

This feat PR changes the sourcemap ignore pattern behavior (merging user patterns with defaults instead of replacing) but only includes unit tests. Per the review rules: "When reviewing a feat PR, check if the PR includes at least one integration or E2E test. If neither of the two are present, add a comment, recommending to add one." An integration test verifying the actual sourcemap upload/ignore behavior with the new merged patterns would help ensure the feature works correctly in real build scenarios.

Fix in CursorFix in Web

});

it('disables sourcemaps when disable flag is set', () => {
Expand DownExpand Up@@ -769,6 +869,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(nextjs): Update default ignore list for sourcemaps#18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 4 commits into from
Jan 23, 2026
Merged

feat(nextjs): Update default ignore list for sourcemaps #18938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
916b2ad
update default ignore
chargome Jan 22, 2026
d4efe82
Merge branch 'develop' into cg/JS-1501/nextjs-add-option-to-suppress-…
chargome Jan 22, 2026
9cdbabe
rm logs
chargome Jan 22, 2026
a332750
hold my horses
chargome Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions packages/nextjs/src/config/getBuildPluginOptions.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,13 @@ const FILE_PATTERNS = {
FRAMEWORK_CHUNKS_DOT: 'static/chunks/framework.*',
POLYFILLS_CHUNKS: 'static/chunks/polyfills-*',
WEBPACK_CHUNKS: 'static/chunks/webpack-*',
PAGE_CLIENT_REFERENCE_MANIFEST: '**/page_client-reference-manifest.js',
SERVER_REFERENCE_MANIFEST: '**/server-reference-manifest.js',
NEXT_FONT_MANIFEST: '**/next-font-manifest.js',
MIDDLEWARE_BUILD_MANIFEST: '**/middleware-build-manifest.js',
INTERCEPTION_ROUTE_REWRITE_MANIFEST: '**/interception-route-rewrite-manifest.js',
ROUTE_CLIENT_REFERENCE_MANIFEST: '**/route_client-reference-manifest.js',
MIDDLEWARE_REACT_LOADABLE_MANIFEST: '**/middleware-react-loadable-manifest.js',
} as const;

// Source map file extensions to delete
Expand DownExpand Up@@ -142,6 +149,16 @@ function createSourcemapUploadIgnorePattern(
path.posix.join(normalizedDistPath, FILE_PATTERNS.FRAMEWORK_CHUNKS_DOT),
path.posix.join(normalizedDistPath, FILE_PATTERNS.POLYFILLS_CHUNKS),
path.posix.join(normalizedDistPath, FILE_PATTERNS.WEBPACK_CHUNKS),
// Next.js internal manifest files that don't have source maps
// These files are auto-generated by Next.js and do not contain user code.
// Ignoring them prevents "Could not determine source map reference" warnings.
FILE_PATTERNS.PAGE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.SERVER_REFERENCE_MANIFEST,
FILE_PATTERNS.NEXT_FONT_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_BUILD_MANIFEST,
FILE_PATTERNS.INTERCEPTION_ROUTE_REWRITE_MANIFEST,
FILE_PATTERNS.ROUTE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_REACT_LOADABLE_MANIFEST,
);

return ignore;
Expand DownExpand Up@@ -216,6 +233,20 @@ function createReleaseConfig(
};
}

/**
* Merges default ignore patterns with user-provided ignore patterns.
* User patterns are appended to the defaults to ensure internal Next.js
* files are always ignored while allowing users to add additional patterns.
*/
function mergeIgnorePatterns(defaultPatterns: string[], userPatterns: string | string[] | undefined): string[] {
if (!userPatterns) {
return defaultPatterns;
}

const userPatternsArray = Array.isArray(userPatterns) ? userPatterns : [userPatterns];
return [...defaultPatterns, ...userPatternsArray];
}

/**
* Get Sentry Build Plugin options for both webpack and turbopack builds.
* These options can be used in two ways:
Expand All@@ -239,7 +270,6 @@ export function getBuildPluginOptions({
// glob characters. This clashes with Windows path separators.
// See: https://www.npmjs.com/package/glob
const normalizedDistDirAbsPath = normalizePathForGlob(distDirAbsPath);

const loggerPrefix = LOGGER_PREFIXES[buildTool];
const widenClientFileUpload = sentryBuildOptions.widenClientFileUpload ?? false;
const deleteSourcemapsAfterUpload = sentryBuildOptions.sourcemaps?.deleteSourcemapsAfterUpload ?? false;
Expand All@@ -252,6 +282,8 @@ export function getBuildPluginOptions({

const sourcemapUploadIgnore = createSourcemapUploadIgnorePattern(normalizedDistDirAbsPath, widenClientFileUpload);

const finalIgnorePatterns = mergeIgnorePatterns(sourcemapUploadIgnore, sentryBuildOptions.sourcemaps?.ignore);

const filesToDeleteAfterUpload = createFilesToDeleteAfterUploadPattern(
normalizedDistDirAbsPath,
buildTool,
Expand DownExpand Up@@ -281,7 +313,7 @@ export function getBuildPluginOptions({
disable: skipSourcemapsUpload ? true : (sentryBuildOptions.sourcemaps?.disable ?? false),
rewriteSources: rewriteWebpackSources,
assets: sentryBuildOptions.sourcemaps?.assets ?? sourcemapUploadAssets,
ignore: sentryBuildOptions.sourcemaps?.ignore ?? sourcemapUploadIgnore,
ignore: finalIgnorePatterns,
filesToDeleteAfterUpload,
...sentryBuildOptions.webpack?.unstable_sentryWebpackPluginOptions?.sourcemaps,
Comment thread
sentry[bot] marked this conversation as resolved.
},
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/config/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -261,7 +261,8 @@ export type SentryBuildOptions = {
/**
* A glob or an array of globs that specifies which build artifacts should not be uploaded to Sentry.
*
* Default: `[]`
* The SDK automatically ignores Next.js internal files that don't have source maps (such as manifest files)
* to prevent "Could not determine source map" warnings. Your custom patterns are merged with these defaults.
*
* The globbing patterns follow the implementation of the `glob` package. (https://www.npmjs.com/package/glob)
*
Expand Down
111 changes: 109 additions & 2 deletions packages/nextjs/test/config/getBuildPluginOptions.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand DownExpand Up@@ -121,6 +128,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -142,6 +156,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
});

Expand All@@ -161,6 +182,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -181,6 +209,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -205,6 +240,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand All@@ -228,6 +270,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand DownExpand Up@@ -444,7 +493,7 @@ describe('getBuildPluginOptions', () => {
expect(result.sourcemaps?.assets).toEqual(customAssets);
});

it('uses custom sourcemap ignore patterns when provided', () => {
it('merges custom sourcemap ignore patterns with defaults', () => {
const customIgnore = ['**/vendor/**', '**/node_modules/**'];
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
Expand All@@ -461,7 +510,58 @@ describe('getBuildPluginOptions', () => {
buildTool: 'webpack-client',
});

expect(result.sourcemaps?.ignore).toEqual(customIgnore);
// Custom patterns should be appended to defaults, not replace them
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
'**/node_modules/**',
]);
});

it('handles single string custom sourcemap ignore pattern', () => {
const customIgnore = '**/vendor/**';
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
project: 'test-project',
sourcemaps: {
ignore: customIgnore,
},
};

const result = getBuildPluginOptions({
sentryBuildOptions,
releaseName: mockReleaseName,
distDirAbsPath: mockDistDirAbsPath,
buildTool: 'webpack-client',
});

// Single string pattern should be appended to defaults
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
]);

@cursorcursorBotJan 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing integration or E2E test for feature PR

Low Severity · Bugbot Rules

This feat PR changes the sourcemap ignore pattern behavior (merging user patterns with defaults instead of replacing) but only includes unit tests. Per the review rules: "When reviewing a feat PR, check if the PR includes at least one integration or E2E test. If neither of the two are present, add a comment, recommending to add one." An integration test verifying the actual sourcemap upload/ignore behavior with the new merged patterns would help ensure the feature works correctly in real build scenarios.

Fix in CursorFix in Web

});

it('disables sourcemaps when disable flag is set', () => {
Expand DownExpand Up@@ -769,6 +869,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(nextjs): Update default ignore list for sourcemaps#18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 4 commits into from
Jan 23, 2026
Merged

feat(nextjs): Update default ignore list for sourcemaps #18938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
916b2ad
update default ignore
chargome Jan 22, 2026
d4efe82
Merge branch 'develop' into cg/JS-1501/nextjs-add-option-to-suppress-…
chargome Jan 22, 2026
9cdbabe
rm logs
chargome Jan 22, 2026
a332750
hold my horses
chargome Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions packages/nextjs/src/config/getBuildPluginOptions.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,13 @@ const FILE_PATTERNS = {
FRAMEWORK_CHUNKS_DOT: 'static/chunks/framework.*',
POLYFILLS_CHUNKS: 'static/chunks/polyfills-*',
WEBPACK_CHUNKS: 'static/chunks/webpack-*',
PAGE_CLIENT_REFERENCE_MANIFEST: '**/page_client-reference-manifest.js',
SERVER_REFERENCE_MANIFEST: '**/server-reference-manifest.js',
NEXT_FONT_MANIFEST: '**/next-font-manifest.js',
MIDDLEWARE_BUILD_MANIFEST: '**/middleware-build-manifest.js',
INTERCEPTION_ROUTE_REWRITE_MANIFEST: '**/interception-route-rewrite-manifest.js',
ROUTE_CLIENT_REFERENCE_MANIFEST: '**/route_client-reference-manifest.js',
MIDDLEWARE_REACT_LOADABLE_MANIFEST: '**/middleware-react-loadable-manifest.js',
} as const;

// Source map file extensions to delete
Expand DownExpand Up@@ -142,6 +149,16 @@ function createSourcemapUploadIgnorePattern(
path.posix.join(normalizedDistPath, FILE_PATTERNS.FRAMEWORK_CHUNKS_DOT),
path.posix.join(normalizedDistPath, FILE_PATTERNS.POLYFILLS_CHUNKS),
path.posix.join(normalizedDistPath, FILE_PATTERNS.WEBPACK_CHUNKS),
// Next.js internal manifest files that don't have source maps
// These files are auto-generated by Next.js and do not contain user code.
// Ignoring them prevents "Could not determine source map reference" warnings.
FILE_PATTERNS.PAGE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.SERVER_REFERENCE_MANIFEST,
FILE_PATTERNS.NEXT_FONT_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_BUILD_MANIFEST,
FILE_PATTERNS.INTERCEPTION_ROUTE_REWRITE_MANIFEST,
FILE_PATTERNS.ROUTE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_REACT_LOADABLE_MANIFEST,
);

return ignore;
Expand DownExpand Up@@ -216,6 +233,20 @@ function createReleaseConfig(
};
}

/**
* Merges default ignore patterns with user-provided ignore patterns.
* User patterns are appended to the defaults to ensure internal Next.js
* files are always ignored while allowing users to add additional patterns.
*/
function mergeIgnorePatterns(defaultPatterns: string[], userPatterns: string | string[] | undefined): string[] {
if (!userPatterns) {
return defaultPatterns;
}

const userPatternsArray = Array.isArray(userPatterns) ? userPatterns : [userPatterns];
return [...defaultPatterns, ...userPatternsArray];
}

/**
* Get Sentry Build Plugin options for both webpack and turbopack builds.
* These options can be used in two ways:
Expand All@@ -239,7 +270,6 @@ export function getBuildPluginOptions({
// glob characters. This clashes with Windows path separators.
// See: https://www.npmjs.com/package/glob
const normalizedDistDirAbsPath = normalizePathForGlob(distDirAbsPath);

const loggerPrefix = LOGGER_PREFIXES[buildTool];
const widenClientFileUpload = sentryBuildOptions.widenClientFileUpload ?? false;
const deleteSourcemapsAfterUpload = sentryBuildOptions.sourcemaps?.deleteSourcemapsAfterUpload ?? false;
Expand All@@ -252,6 +282,8 @@ export function getBuildPluginOptions({

const sourcemapUploadIgnore = createSourcemapUploadIgnorePattern(normalizedDistDirAbsPath, widenClientFileUpload);

const finalIgnorePatterns = mergeIgnorePatterns(sourcemapUploadIgnore, sentryBuildOptions.sourcemaps?.ignore);

const filesToDeleteAfterUpload = createFilesToDeleteAfterUploadPattern(
normalizedDistDirAbsPath,
buildTool,
Expand DownExpand Up@@ -281,7 +313,7 @@ export function getBuildPluginOptions({
disable: skipSourcemapsUpload ? true : (sentryBuildOptions.sourcemaps?.disable ?? false),
rewriteSources: rewriteWebpackSources,
assets: sentryBuildOptions.sourcemaps?.assets ?? sourcemapUploadAssets,
ignore: sentryBuildOptions.sourcemaps?.ignore ?? sourcemapUploadIgnore,
ignore: finalIgnorePatterns,
filesToDeleteAfterUpload,
...sentryBuildOptions.webpack?.unstable_sentryWebpackPluginOptions?.sourcemaps,
Comment thread
sentry[bot] marked this conversation as resolved.
},
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/config/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -261,7 +261,8 @@ export type SentryBuildOptions = {
/**
* A glob or an array of globs that specifies which build artifacts should not be uploaded to Sentry.
*
* Default: `[]`
* The SDK automatically ignores Next.js internal files that don't have source maps (such as manifest files)
* to prevent "Could not determine source map" warnings. Your custom patterns are merged with these defaults.
*
* The globbing patterns follow the implementation of the `glob` package. (https://www.npmjs.com/package/glob)
*
Expand Down
111 changes: 109 additions & 2 deletions packages/nextjs/test/config/getBuildPluginOptions.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand DownExpand Up@@ -121,6 +128,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -142,6 +156,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
});

Expand All@@ -161,6 +182,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -181,6 +209,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -205,6 +240,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand All@@ -228,6 +270,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand DownExpand Up@@ -444,7 +493,7 @@ describe('getBuildPluginOptions', () => {
expect(result.sourcemaps?.assets).toEqual(customAssets);
});

it('uses custom sourcemap ignore patterns when provided', () => {
it('merges custom sourcemap ignore patterns with defaults', () => {
const customIgnore = ['**/vendor/**', '**/node_modules/**'];
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
Expand All@@ -461,7 +510,58 @@ describe('getBuildPluginOptions', () => {
buildTool: 'webpack-client',
});

expect(result.sourcemaps?.ignore).toEqual(customIgnore);
// Custom patterns should be appended to defaults, not replace them
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
'**/node_modules/**',
]);
});

it('handles single string custom sourcemap ignore pattern', () => {
const customIgnore = '**/vendor/**';
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
project: 'test-project',
sourcemaps: {
ignore: customIgnore,
},
};

const result = getBuildPluginOptions({
sentryBuildOptions,
releaseName: mockReleaseName,
distDirAbsPath: mockDistDirAbsPath,
buildTool: 'webpack-client',
});

// Single string pattern should be appended to defaults
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
]);

@cursorcursorBotJan 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing integration or E2E test for feature PR

Low Severity · Bugbot Rules

This feat PR changes the sourcemap ignore pattern behavior (merging user patterns with defaults instead of replacing) but only includes unit tests. Per the review rules: "When reviewing a feat PR, check if the PR includes at least one integration or E2E test. If neither of the two are present, add a comment, recommending to add one." An integration test verifying the actual sourcemap upload/ignore behavior with the new merged patterns would help ensure the feature works correctly in real build scenarios.

Fix in CursorFix in Web

});

it('disables sourcemaps when disable flag is set', () => {
Expand DownExpand Up@@ -769,6 +869,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(nextjs): Update default ignore list for sourcemaps#18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 4 commits into from
Jan 23, 2026
Merged

feat(nextjs): Update default ignore list for sourcemaps #18938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
916b2ad
update default ignore
chargome Jan 22, 2026
d4efe82
Merge branch 'develop' into cg/JS-1501/nextjs-add-option-to-suppress-…
chargome Jan 22, 2026
9cdbabe
rm logs
chargome Jan 22, 2026
a332750
hold my horses
chargome Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions packages/nextjs/src/config/getBuildPluginOptions.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,13 @@ const FILE_PATTERNS = {
FRAMEWORK_CHUNKS_DOT: 'static/chunks/framework.*',
POLYFILLS_CHUNKS: 'static/chunks/polyfills-*',
WEBPACK_CHUNKS: 'static/chunks/webpack-*',
PAGE_CLIENT_REFERENCE_MANIFEST: '**/page_client-reference-manifest.js',
SERVER_REFERENCE_MANIFEST: '**/server-reference-manifest.js',
NEXT_FONT_MANIFEST: '**/next-font-manifest.js',
MIDDLEWARE_BUILD_MANIFEST: '**/middleware-build-manifest.js',
INTERCEPTION_ROUTE_REWRITE_MANIFEST: '**/interception-route-rewrite-manifest.js',
ROUTE_CLIENT_REFERENCE_MANIFEST: '**/route_client-reference-manifest.js',
MIDDLEWARE_REACT_LOADABLE_MANIFEST: '**/middleware-react-loadable-manifest.js',
} as const;

// Source map file extensions to delete
Expand DownExpand Up@@ -142,6 +149,16 @@ function createSourcemapUploadIgnorePattern(
path.posix.join(normalizedDistPath, FILE_PATTERNS.FRAMEWORK_CHUNKS_DOT),
path.posix.join(normalizedDistPath, FILE_PATTERNS.POLYFILLS_CHUNKS),
path.posix.join(normalizedDistPath, FILE_PATTERNS.WEBPACK_CHUNKS),
// Next.js internal manifest files that don't have source maps
// These files are auto-generated by Next.js and do not contain user code.
// Ignoring them prevents "Could not determine source map reference" warnings.
FILE_PATTERNS.PAGE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.SERVER_REFERENCE_MANIFEST,
FILE_PATTERNS.NEXT_FONT_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_BUILD_MANIFEST,
FILE_PATTERNS.INTERCEPTION_ROUTE_REWRITE_MANIFEST,
FILE_PATTERNS.ROUTE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_REACT_LOADABLE_MANIFEST,
);

return ignore;
Expand DownExpand Up@@ -216,6 +233,20 @@ function createReleaseConfig(
};
}

/**
* Merges default ignore patterns with user-provided ignore patterns.
* User patterns are appended to the defaults to ensure internal Next.js
* files are always ignored while allowing users to add additional patterns.
*/
function mergeIgnorePatterns(defaultPatterns: string[], userPatterns: string | string[] | undefined): string[] {
if (!userPatterns) {
return defaultPatterns;
}

const userPatternsArray = Array.isArray(userPatterns) ? userPatterns : [userPatterns];
return [...defaultPatterns, ...userPatternsArray];
}

/**
* Get Sentry Build Plugin options for both webpack and turbopack builds.
* These options can be used in two ways:
Expand All@@ -239,7 +270,6 @@ export function getBuildPluginOptions({
// glob characters. This clashes with Windows path separators.
// See: https://www.npmjs.com/package/glob
const normalizedDistDirAbsPath = normalizePathForGlob(distDirAbsPath);

const loggerPrefix = LOGGER_PREFIXES[buildTool];
const widenClientFileUpload = sentryBuildOptions.widenClientFileUpload ?? false;
const deleteSourcemapsAfterUpload = sentryBuildOptions.sourcemaps?.deleteSourcemapsAfterUpload ?? false;
Expand All@@ -252,6 +282,8 @@ export function getBuildPluginOptions({

const sourcemapUploadIgnore = createSourcemapUploadIgnorePattern(normalizedDistDirAbsPath, widenClientFileUpload);

const finalIgnorePatterns = mergeIgnorePatterns(sourcemapUploadIgnore, sentryBuildOptions.sourcemaps?.ignore);

const filesToDeleteAfterUpload = createFilesToDeleteAfterUploadPattern(
normalizedDistDirAbsPath,
buildTool,
Expand DownExpand Up@@ -281,7 +313,7 @@ export function getBuildPluginOptions({
disable: skipSourcemapsUpload ? true : (sentryBuildOptions.sourcemaps?.disable ?? false),
rewriteSources: rewriteWebpackSources,
assets: sentryBuildOptions.sourcemaps?.assets ?? sourcemapUploadAssets,
ignore: sentryBuildOptions.sourcemaps?.ignore ?? sourcemapUploadIgnore,
ignore: finalIgnorePatterns,
filesToDeleteAfterUpload,
...sentryBuildOptions.webpack?.unstable_sentryWebpackPluginOptions?.sourcemaps,
Comment thread
sentry[bot] marked this conversation as resolved.
},
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/config/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -261,7 +261,8 @@ export type SentryBuildOptions = {
/**
* A glob or an array of globs that specifies which build artifacts should not be uploaded to Sentry.
*
* Default: `[]`
* The SDK automatically ignores Next.js internal files that don't have source maps (such as manifest files)
* to prevent "Could not determine source map" warnings. Your custom patterns are merged with these defaults.
*
* The globbing patterns follow the implementation of the `glob` package. (https://www.npmjs.com/package/glob)
*
Expand Down
111 changes: 109 additions & 2 deletions packages/nextjs/test/config/getBuildPluginOptions.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand DownExpand Up@@ -121,6 +128,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -142,6 +156,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
});

Expand All@@ -161,6 +182,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -181,6 +209,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -205,6 +240,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand All@@ -228,6 +270,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand DownExpand Up@@ -444,7 +493,7 @@ describe('getBuildPluginOptions', () => {
expect(result.sourcemaps?.assets).toEqual(customAssets);
});

it('uses custom sourcemap ignore patterns when provided', () => {
it('merges custom sourcemap ignore patterns with defaults', () => {
const customIgnore = ['**/vendor/**', '**/node_modules/**'];
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
Expand All@@ -461,7 +510,58 @@ describe('getBuildPluginOptions', () => {
buildTool: 'webpack-client',
});

expect(result.sourcemaps?.ignore).toEqual(customIgnore);
// Custom patterns should be appended to defaults, not replace them
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
'**/node_modules/**',
]);
});

it('handles single string custom sourcemap ignore pattern', () => {
const customIgnore = '**/vendor/**';
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
project: 'test-project',
sourcemaps: {
ignore: customIgnore,
},
};

const result = getBuildPluginOptions({
sentryBuildOptions,
releaseName: mockReleaseName,
distDirAbsPath: mockDistDirAbsPath,
buildTool: 'webpack-client',
});

// Single string pattern should be appended to defaults
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
]);

@cursorcursorBotJan 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing integration or E2E test for feature PR

Low Severity · Bugbot Rules

This feat PR changes the sourcemap ignore pattern behavior (merging user patterns with defaults instead of replacing) but only includes unit tests. Per the review rules: "When reviewing a feat PR, check if the PR includes at least one integration or E2E test. If neither of the two are present, add a comment, recommending to add one." An integration test verifying the actual sourcemap upload/ignore behavior with the new merged patterns would help ensure the feature works correctly in real build scenarios.

Fix in CursorFix in Web

});

it('disables sourcemaps when disable flag is set', () => {
Expand DownExpand Up@@ -769,6 +869,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(nextjs): Update default ignore list for sourcemaps#18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 4 commits into from
Jan 23, 2026
Merged

feat(nextjs): Update default ignore list for sourcemaps #18938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
916b2ad
update default ignore
chargome Jan 22, 2026
d4efe82
Merge branch 'develop' into cg/JS-1501/nextjs-add-option-to-suppress-…
chargome Jan 22, 2026
9cdbabe
rm logs
chargome Jan 22, 2026
a332750
hold my horses
chargome Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions packages/nextjs/src/config/getBuildPluginOptions.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,13 @@ const FILE_PATTERNS = {
FRAMEWORK_CHUNKS_DOT: 'static/chunks/framework.*',
POLYFILLS_CHUNKS: 'static/chunks/polyfills-*',
WEBPACK_CHUNKS: 'static/chunks/webpack-*',
PAGE_CLIENT_REFERENCE_MANIFEST: '**/page_client-reference-manifest.js',
SERVER_REFERENCE_MANIFEST: '**/server-reference-manifest.js',
NEXT_FONT_MANIFEST: '**/next-font-manifest.js',
MIDDLEWARE_BUILD_MANIFEST: '**/middleware-build-manifest.js',
INTERCEPTION_ROUTE_REWRITE_MANIFEST: '**/interception-route-rewrite-manifest.js',
ROUTE_CLIENT_REFERENCE_MANIFEST: '**/route_client-reference-manifest.js',
MIDDLEWARE_REACT_LOADABLE_MANIFEST: '**/middleware-react-loadable-manifest.js',
} as const;

// Source map file extensions to delete
Expand DownExpand Up@@ -142,6 +149,16 @@ function createSourcemapUploadIgnorePattern(
path.posix.join(normalizedDistPath, FILE_PATTERNS.FRAMEWORK_CHUNKS_DOT),
path.posix.join(normalizedDistPath, FILE_PATTERNS.POLYFILLS_CHUNKS),
path.posix.join(normalizedDistPath, FILE_PATTERNS.WEBPACK_CHUNKS),
// Next.js internal manifest files that don't have source maps
// These files are auto-generated by Next.js and do not contain user code.
// Ignoring them prevents "Could not determine source map reference" warnings.
FILE_PATTERNS.PAGE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.SERVER_REFERENCE_MANIFEST,
FILE_PATTERNS.NEXT_FONT_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_BUILD_MANIFEST,
FILE_PATTERNS.INTERCEPTION_ROUTE_REWRITE_MANIFEST,
FILE_PATTERNS.ROUTE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_REACT_LOADABLE_MANIFEST,
);

return ignore;
Expand DownExpand Up@@ -216,6 +233,20 @@ function createReleaseConfig(
};
}

/**
* Merges default ignore patterns with user-provided ignore patterns.
* User patterns are appended to the defaults to ensure internal Next.js
* files are always ignored while allowing users to add additional patterns.
*/
function mergeIgnorePatterns(defaultPatterns: string[], userPatterns: string | string[] | undefined): string[] {
if (!userPatterns) {
return defaultPatterns;
}

const userPatternsArray = Array.isArray(userPatterns) ? userPatterns : [userPatterns];
return [...defaultPatterns, ...userPatternsArray];
}

/**
* Get Sentry Build Plugin options for both webpack and turbopack builds.
* These options can be used in two ways:
Expand All@@ -239,7 +270,6 @@ export function getBuildPluginOptions({
// glob characters. This clashes with Windows path separators.
// See: https://www.npmjs.com/package/glob
const normalizedDistDirAbsPath = normalizePathForGlob(distDirAbsPath);

const loggerPrefix = LOGGER_PREFIXES[buildTool];
const widenClientFileUpload = sentryBuildOptions.widenClientFileUpload ?? false;
const deleteSourcemapsAfterUpload = sentryBuildOptions.sourcemaps?.deleteSourcemapsAfterUpload ?? false;
Expand All@@ -252,6 +282,8 @@ export function getBuildPluginOptions({

const sourcemapUploadIgnore = createSourcemapUploadIgnorePattern(normalizedDistDirAbsPath, widenClientFileUpload);

const finalIgnorePatterns = mergeIgnorePatterns(sourcemapUploadIgnore, sentryBuildOptions.sourcemaps?.ignore);

const filesToDeleteAfterUpload = createFilesToDeleteAfterUploadPattern(
normalizedDistDirAbsPath,
buildTool,
Expand DownExpand Up@@ -281,7 +313,7 @@ export function getBuildPluginOptions({
disable: skipSourcemapsUpload ? true : (sentryBuildOptions.sourcemaps?.disable ?? false),
rewriteSources: rewriteWebpackSources,
assets: sentryBuildOptions.sourcemaps?.assets ?? sourcemapUploadAssets,
ignore: sentryBuildOptions.sourcemaps?.ignore ?? sourcemapUploadIgnore,
ignore: finalIgnorePatterns,
filesToDeleteAfterUpload,
...sentryBuildOptions.webpack?.unstable_sentryWebpackPluginOptions?.sourcemaps,
Comment thread
sentry[bot] marked this conversation as resolved.
},
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/config/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -261,7 +261,8 @@ export type SentryBuildOptions = {
/**
* A glob or an array of globs that specifies which build artifacts should not be uploaded to Sentry.
*
* Default: `[]`
* The SDK automatically ignores Next.js internal files that don't have source maps (such as manifest files)
* to prevent "Could not determine source map" warnings. Your custom patterns are merged with these defaults.
*
* The globbing patterns follow the implementation of the `glob` package. (https://www.npmjs.com/package/glob)
*
Expand Down
111 changes: 109 additions & 2 deletions packages/nextjs/test/config/getBuildPluginOptions.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand DownExpand Up@@ -121,6 +128,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -142,6 +156,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
});

Expand All@@ -161,6 +182,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -181,6 +209,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -205,6 +240,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand All@@ -228,6 +270,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand DownExpand Up@@ -444,7 +493,7 @@ describe('getBuildPluginOptions', () => {
expect(result.sourcemaps?.assets).toEqual(customAssets);
});

it('uses custom sourcemap ignore patterns when provided', () => {
it('merges custom sourcemap ignore patterns with defaults', () => {
const customIgnore = ['**/vendor/**', '**/node_modules/**'];
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
Expand All@@ -461,7 +510,58 @@ describe('getBuildPluginOptions', () => {
buildTool: 'webpack-client',
});

expect(result.sourcemaps?.ignore).toEqual(customIgnore);
// Custom patterns should be appended to defaults, not replace them
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
'**/node_modules/**',
]);
});

it('handles single string custom sourcemap ignore pattern', () => {
const customIgnore = '**/vendor/**';
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
project: 'test-project',
sourcemaps: {
ignore: customIgnore,
},
};

const result = getBuildPluginOptions({
sentryBuildOptions,
releaseName: mockReleaseName,
distDirAbsPath: mockDistDirAbsPath,
buildTool: 'webpack-client',
});

// Single string pattern should be appended to defaults
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
]);

@cursorcursorBotJan 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing integration or E2E test for feature PR

Low Severity · Bugbot Rules

This feat PR changes the sourcemap ignore pattern behavior (merging user patterns with defaults instead of replacing) but only includes unit tests. Per the review rules: "When reviewing a feat PR, check if the PR includes at least one integration or E2E test. If neither of the two are present, add a comment, recommending to add one." An integration test verifying the actual sourcemap upload/ignore behavior with the new merged patterns would help ensure the feature works correctly in real build scenarios.

Fix in CursorFix in Web

});

it('disables sourcemaps when disable flag is set', () => {
Expand DownExpand Up@@ -769,6 +869,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(nextjs): Update default ignore list for sourcemaps#18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 4 commits into from
Jan 23, 2026
Merged

feat(nextjs): Update default ignore list for sourcemaps #18938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
916b2ad
update default ignore
chargome Jan 22, 2026
d4efe82
Merge branch 'develop' into cg/JS-1501/nextjs-add-option-to-suppress-…
chargome Jan 22, 2026
9cdbabe
rm logs
chargome Jan 22, 2026
a332750
hold my horses
chargome Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions packages/nextjs/src/config/getBuildPluginOptions.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,13 @@ const FILE_PATTERNS = {
FRAMEWORK_CHUNKS_DOT: 'static/chunks/framework.*',
POLYFILLS_CHUNKS: 'static/chunks/polyfills-*',
WEBPACK_CHUNKS: 'static/chunks/webpack-*',
PAGE_CLIENT_REFERENCE_MANIFEST: '**/page_client-reference-manifest.js',
SERVER_REFERENCE_MANIFEST: '**/server-reference-manifest.js',
NEXT_FONT_MANIFEST: '**/next-font-manifest.js',
MIDDLEWARE_BUILD_MANIFEST: '**/middleware-build-manifest.js',
INTERCEPTION_ROUTE_REWRITE_MANIFEST: '**/interception-route-rewrite-manifest.js',
ROUTE_CLIENT_REFERENCE_MANIFEST: '**/route_client-reference-manifest.js',
MIDDLEWARE_REACT_LOADABLE_MANIFEST: '**/middleware-react-loadable-manifest.js',
} as const;

// Source map file extensions to delete
Expand DownExpand Up@@ -142,6 +149,16 @@ function createSourcemapUploadIgnorePattern(
path.posix.join(normalizedDistPath, FILE_PATTERNS.FRAMEWORK_CHUNKS_DOT),
path.posix.join(normalizedDistPath, FILE_PATTERNS.POLYFILLS_CHUNKS),
path.posix.join(normalizedDistPath, FILE_PATTERNS.WEBPACK_CHUNKS),
// Next.js internal manifest files that don't have source maps
// These files are auto-generated by Next.js and do not contain user code.
// Ignoring them prevents "Could not determine source map reference" warnings.
FILE_PATTERNS.PAGE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.SERVER_REFERENCE_MANIFEST,
FILE_PATTERNS.NEXT_FONT_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_BUILD_MANIFEST,
FILE_PATTERNS.INTERCEPTION_ROUTE_REWRITE_MANIFEST,
FILE_PATTERNS.ROUTE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_REACT_LOADABLE_MANIFEST,
);

return ignore;
Expand DownExpand Up@@ -216,6 +233,20 @@ function createReleaseConfig(
};
}

/**
* Merges default ignore patterns with user-provided ignore patterns.
* User patterns are appended to the defaults to ensure internal Next.js
* files are always ignored while allowing users to add additional patterns.
*/
function mergeIgnorePatterns(defaultPatterns: string[], userPatterns: string | string[] | undefined): string[] {
if (!userPatterns) {
return defaultPatterns;
}

const userPatternsArray = Array.isArray(userPatterns) ? userPatterns : [userPatterns];
return [...defaultPatterns, ...userPatternsArray];
}

/**
* Get Sentry Build Plugin options for both webpack and turbopack builds.
* These options can be used in two ways:
Expand All@@ -239,7 +270,6 @@ export function getBuildPluginOptions({
// glob characters. This clashes with Windows path separators.
// See: https://www.npmjs.com/package/glob
const normalizedDistDirAbsPath = normalizePathForGlob(distDirAbsPath);

const loggerPrefix = LOGGER_PREFIXES[buildTool];
const widenClientFileUpload = sentryBuildOptions.widenClientFileUpload ?? false;
const deleteSourcemapsAfterUpload = sentryBuildOptions.sourcemaps?.deleteSourcemapsAfterUpload ?? false;
Expand All@@ -252,6 +282,8 @@ export function getBuildPluginOptions({

const sourcemapUploadIgnore = createSourcemapUploadIgnorePattern(normalizedDistDirAbsPath, widenClientFileUpload);

const finalIgnorePatterns = mergeIgnorePatterns(sourcemapUploadIgnore, sentryBuildOptions.sourcemaps?.ignore);

const filesToDeleteAfterUpload = createFilesToDeleteAfterUploadPattern(
normalizedDistDirAbsPath,
buildTool,
Expand DownExpand Up@@ -281,7 +313,7 @@ export function getBuildPluginOptions({
disable: skipSourcemapsUpload ? true : (sentryBuildOptions.sourcemaps?.disable ?? false),
rewriteSources: rewriteWebpackSources,
assets: sentryBuildOptions.sourcemaps?.assets ?? sourcemapUploadAssets,
ignore: sentryBuildOptions.sourcemaps?.ignore ?? sourcemapUploadIgnore,
ignore: finalIgnorePatterns,
filesToDeleteAfterUpload,
...sentryBuildOptions.webpack?.unstable_sentryWebpackPluginOptions?.sourcemaps,
Comment thread
sentry[bot] marked this conversation as resolved.
},
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/config/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -261,7 +261,8 @@ export type SentryBuildOptions = {
/**
* A glob or an array of globs that specifies which build artifacts should not be uploaded to Sentry.
*
* Default: `[]`
* The SDK automatically ignores Next.js internal files that don't have source maps (such as manifest files)
* to prevent "Could not determine source map" warnings. Your custom patterns are merged with these defaults.
*
* The globbing patterns follow the implementation of the `glob` package. (https://www.npmjs.com/package/glob)
*
Expand Down
111 changes: 109 additions & 2 deletions packages/nextjs/test/config/getBuildPluginOptions.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand DownExpand Up@@ -121,6 +128,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -142,6 +156,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
});

Expand All@@ -161,6 +182,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -181,6 +209,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -205,6 +240,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand All@@ -228,6 +270,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand DownExpand Up@@ -444,7 +493,7 @@ describe('getBuildPluginOptions', () => {
expect(result.sourcemaps?.assets).toEqual(customAssets);
});

it('uses custom sourcemap ignore patterns when provided', () => {
it('merges custom sourcemap ignore patterns with defaults', () => {
const customIgnore = ['**/vendor/**', '**/node_modules/**'];
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
Expand All@@ -461,7 +510,58 @@ describe('getBuildPluginOptions', () => {
buildTool: 'webpack-client',
});

expect(result.sourcemaps?.ignore).toEqual(customIgnore);
// Custom patterns should be appended to defaults, not replace them
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
'**/node_modules/**',
]);
});

it('handles single string custom sourcemap ignore pattern', () => {
const customIgnore = '**/vendor/**';
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
project: 'test-project',
sourcemaps: {
ignore: customIgnore,
},
};

const result = getBuildPluginOptions({
sentryBuildOptions,
releaseName: mockReleaseName,
distDirAbsPath: mockDistDirAbsPath,
buildTool: 'webpack-client',
});

// Single string pattern should be appended to defaults
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
]);

@cursorcursorBotJan 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing integration or E2E test for feature PR

Low Severity · Bugbot Rules

This feat PR changes the sourcemap ignore pattern behavior (merging user patterns with defaults instead of replacing) but only includes unit tests. Per the review rules: "When reviewing a feat PR, check if the PR includes at least one integration or E2E test. If neither of the two are present, add a comment, recommending to add one." An integration test verifying the actual sourcemap upload/ignore behavior with the new merged patterns would help ensure the feature works correctly in real build scenarios.

Fix in CursorFix in Web

});

it('disables sourcemaps when disable flag is set', () => {
Expand DownExpand Up@@ -769,6 +869,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(nextjs): Update default ignore list for sourcemaps#18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 4 commits into from
Jan 23, 2026
Merged

feat(nextjs): Update default ignore list for sourcemaps #18938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
916b2ad
update default ignore
chargome Jan 22, 2026
d4efe82
Merge branch 'develop' into cg/JS-1501/nextjs-add-option-to-suppress-…
chargome Jan 22, 2026
9cdbabe
rm logs
chargome Jan 22, 2026
a332750
hold my horses
chargome Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions packages/nextjs/src/config/getBuildPluginOptions.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,13 @@ const FILE_PATTERNS = {
FRAMEWORK_CHUNKS_DOT: 'static/chunks/framework.*',
POLYFILLS_CHUNKS: 'static/chunks/polyfills-*',
WEBPACK_CHUNKS: 'static/chunks/webpack-*',
PAGE_CLIENT_REFERENCE_MANIFEST: '**/page_client-reference-manifest.js',
SERVER_REFERENCE_MANIFEST: '**/server-reference-manifest.js',
NEXT_FONT_MANIFEST: '**/next-font-manifest.js',
MIDDLEWARE_BUILD_MANIFEST: '**/middleware-build-manifest.js',
INTERCEPTION_ROUTE_REWRITE_MANIFEST: '**/interception-route-rewrite-manifest.js',
ROUTE_CLIENT_REFERENCE_MANIFEST: '**/route_client-reference-manifest.js',
MIDDLEWARE_REACT_LOADABLE_MANIFEST: '**/middleware-react-loadable-manifest.js',
} as const;

// Source map file extensions to delete
Expand DownExpand Up@@ -142,6 +149,16 @@ function createSourcemapUploadIgnorePattern(
path.posix.join(normalizedDistPath, FILE_PATTERNS.FRAMEWORK_CHUNKS_DOT),
path.posix.join(normalizedDistPath, FILE_PATTERNS.POLYFILLS_CHUNKS),
path.posix.join(normalizedDistPath, FILE_PATTERNS.WEBPACK_CHUNKS),
// Next.js internal manifest files that don't have source maps
// These files are auto-generated by Next.js and do not contain user code.
// Ignoring them prevents "Could not determine source map reference" warnings.
FILE_PATTERNS.PAGE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.SERVER_REFERENCE_MANIFEST,
FILE_PATTERNS.NEXT_FONT_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_BUILD_MANIFEST,
FILE_PATTERNS.INTERCEPTION_ROUTE_REWRITE_MANIFEST,
FILE_PATTERNS.ROUTE_CLIENT_REFERENCE_MANIFEST,
FILE_PATTERNS.MIDDLEWARE_REACT_LOADABLE_MANIFEST,
);

return ignore;
Expand DownExpand Up@@ -216,6 +233,20 @@ function createReleaseConfig(
};
}

/**
* Merges default ignore patterns with user-provided ignore patterns.
* User patterns are appended to the defaults to ensure internal Next.js
* files are always ignored while allowing users to add additional patterns.
*/
function mergeIgnorePatterns(defaultPatterns: string[], userPatterns: string | string[] | undefined): string[] {
if (!userPatterns) {
return defaultPatterns;
}

const userPatternsArray = Array.isArray(userPatterns) ? userPatterns : [userPatterns];
return [...defaultPatterns, ...userPatternsArray];
}

/**
* Get Sentry Build Plugin options for both webpack and turbopack builds.
* These options can be used in two ways:
Expand All@@ -239,7 +270,6 @@ export function getBuildPluginOptions({
// glob characters. This clashes with Windows path separators.
// See: https://www.npmjs.com/package/glob
const normalizedDistDirAbsPath = normalizePathForGlob(distDirAbsPath);

const loggerPrefix = LOGGER_PREFIXES[buildTool];
const widenClientFileUpload = sentryBuildOptions.widenClientFileUpload ?? false;
const deleteSourcemapsAfterUpload = sentryBuildOptions.sourcemaps?.deleteSourcemapsAfterUpload ?? false;
Expand All@@ -252,6 +282,8 @@ export function getBuildPluginOptions({

const sourcemapUploadIgnore = createSourcemapUploadIgnorePattern(normalizedDistDirAbsPath, widenClientFileUpload);

const finalIgnorePatterns = mergeIgnorePatterns(sourcemapUploadIgnore, sentryBuildOptions.sourcemaps?.ignore);

const filesToDeleteAfterUpload = createFilesToDeleteAfterUploadPattern(
normalizedDistDirAbsPath,
buildTool,
Expand DownExpand Up@@ -281,7 +313,7 @@ export function getBuildPluginOptions({
disable: skipSourcemapsUpload ? true : (sentryBuildOptions.sourcemaps?.disable ?? false),
rewriteSources: rewriteWebpackSources,
assets: sentryBuildOptions.sourcemaps?.assets ?? sourcemapUploadAssets,
ignore: sentryBuildOptions.sourcemaps?.ignore ?? sourcemapUploadIgnore,
ignore: finalIgnorePatterns,
filesToDeleteAfterUpload,
...sentryBuildOptions.webpack?.unstable_sentryWebpackPluginOptions?.sourcemaps,
Comment thread
sentry[bot] marked this conversation as resolved.
},
Expand Down
3 changes: 2 additions & 1 deletion packages/nextjs/src/config/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -261,7 +261,8 @@ export type SentryBuildOptions = {
/**
* A glob or an array of globs that specifies which build artifacts should not be uploaded to Sentry.
*
* Default: `[]`
* The SDK automatically ignores Next.js internal files that don't have source maps (such as manifest files)
* to prevent "Could not determine source map" warnings. Your custom patterns are merged with these defaults.
*
* The globbing patterns follow the implementation of the `glob` package. (https://www.npmjs.com/package/glob)
*
Expand Down
111 changes: 109 additions & 2 deletions packages/nextjs/test/config/getBuildPluginOptions.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand DownExpand Up@@ -121,6 +128,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -142,6 +156,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
});

Expand All@@ -161,6 +182,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -181,6 +209,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeDefined();
});
Expand All@@ -205,6 +240,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand All@@ -228,6 +270,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
]);
expect(result.reactComponentAnnotation).toBeUndefined();
});
Expand DownExpand Up@@ -444,7 +493,7 @@ describe('getBuildPluginOptions', () => {
expect(result.sourcemaps?.assets).toEqual(customAssets);
});

it('uses custom sourcemap ignore patterns when provided', () => {
it('merges custom sourcemap ignore patterns with defaults', () => {
const customIgnore = ['**/vendor/**', '**/node_modules/**'];
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
Expand All@@ -461,7 +510,58 @@ describe('getBuildPluginOptions', () => {
buildTool: 'webpack-client',
});

expect(result.sourcemaps?.ignore).toEqual(customIgnore);
// Custom patterns should be appended to defaults, not replace them
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
'**/node_modules/**',
]);
});

it('handles single string custom sourcemap ignore pattern', () => {
const customIgnore = '**/vendor/**';
const sentryBuildOptions: SentryBuildOptions = {
org: 'test-org',
project: 'test-project',
sourcemaps: {
ignore: customIgnore,
},
};

const result = getBuildPluginOptions({
sentryBuildOptions,
releaseName: mockReleaseName,
distDirAbsPath: mockDistDirAbsPath,
buildTool: 'webpack-client',
});

// Single string pattern should be appended to defaults
expect(result.sourcemaps?.ignore).toEqual([
'/path/to/.next/static/chunks/main-*',
'/path/to/.next/static/chunks/framework-*',
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
'**/vendor/**',
]);

@cursorcursorBotJan 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing integration or E2E test for feature PR

Low Severity · Bugbot Rules

This feat PR changes the sourcemap ignore pattern behavior (merging user patterns with defaults instead of replacing) but only includes unit tests. Per the review rules: "When reviewing a feat PR, check if the PR includes at least one integration or E2E test. If neither of the two are present, add a comment, recommending to add one." An integration test verifying the actual sourcemap upload/ignore behavior with the new merged patterns would help ensure the feature works correctly in real build scenarios.

Fix in CursorFix in Web

});

it('disables sourcemaps when disable flag is set', () => {
Expand DownExpand Up@@ -769,6 +869,13 @@ describe('getBuildPluginOptions', () => {
'/path/to/.next/static/chunks/framework.*',
'/path/to/.next/static/chunks/polyfills-*',
'/path/to/.next/static/chunks/webpack-*',
'**/page_client-reference-manifest.js',
'**/server-reference-manifest.js',
'**/next-font-manifest.js',
'**/middleware-build-manifest.js',
'**/interception-route-rewrite-manifest.js',
'**/route_client-reference-manifest.js',
'**/middleware-react-loadable-manifest.js',
],
filesToDeleteAfterUpload: undefined,
rewriteSources: expect.any(Function),
Expand Down
Loading