feat(browser): Add logs.metrics bundle#19020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 3 commits into from
Jan 28, 2026
Merged

feat(browser): Add logs.metrics bundle #19020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e6c678
add logs.metrics bundle
chargome Jan 28, 2026
ce88920
bump size limit
chargome Jan 28, 2026
1af3be2
skip tracing test
chargome Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -568,6 +568,7 @@ jobs:
- bundle_min
- bundle_replay
- bundle_tracing
- bundle_logs_metrics
- bundle_tracing_logs_metrics
- bundle_tracing_replay
- bundle_tracing_replay_feedback
Expand Down
13 changes: 13 additions & 0 deletions .size-limit.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -186,6 +186,12 @@ module.exports = [
gzip: true,
limit: '43 KB',
},
{
name: 'CDN Bundle (incl. Logs, Metrics)',
path: createCDNPath('bundle.logs.metrics.min.js'),
gzip: true,
limit: '29 KB',
},
{
name: 'CDN Bundle (incl. Tracing, Logs, Metrics)',
path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand DownExpand Up@@ -225,6 +231,13 @@ module.exports = [
brotli: false,
limit: '128 KB',
},
{
name: 'CDN Bundle (incl. Logs, Metrics) - uncompressed',
path: createCDNPath('bundle.logs.metrics.min.js'),
gzip: false,
brotli: false,
limit: '86 KB',
},
{
name: 'CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed',
path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand Down
3 changes: 3 additions & 0 deletions dev-packages/browser-integration-tests/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,9 @@
"test:bundle:replay:min": "PW_BUNDLE=bundle_replay_min yarn test",
"test:bundle:tracing": "PW_BUNDLE=bundle_tracing yarn test",
"test:bundle:tracing:min": "PW_BUNDLE=bundle_tracing_min yarn test",
"test:bundle:logs_metrics": "PW_BUNDLE=bundle_logs_metrics yarn test",
"test:bundle:logs_metrics:min": "PW_BUNDLE=bundle_logs_metrics_min yarn test",
"test:bundle:logs_metrics:debug_min": "PW_BUNDLE=bundle_logs_metrics_debug_min yarn test",
"test:bundle:tracing_logs_metrics": "PW_BUNDLE=bundle_tracing_logs_metrics yarn test",
"test:bundle:tracing_logs_metrics:min": "PW_BUNDLE=bundle_tracing_logs_metrics_min yarn test",
"test:bundle:tracing_logs_metrics:debug_min": "PW_BUNDLE=bundle_tracing_logs_metrics_debug_min yarn test",
Expand Down
6 changes: 4 additions & 2 deletions dev-packages/browser-integration-tests/suites/public-api/metrics/simple/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,11 +5,13 @@ import {
getFirstSentryEnvelopeRequest,
properFullEnvelopeRequestParser,
shouldSkipMetricsTest,
shouldSkipTracingTest,
} from '../../../../utils/helpers';

sentryTest('should capture all metric types', async ({ getLocalTestUrl, page }) => {
// Only run this for npm package exports and CDN bundles with metrics
if (shouldSkipMetricsTest()) {
// Only run this for npm package exports and CDN bundles with metrics and tracing
// (the test uses Sentry.startSpan which requires tracing)
if (shouldSkipMetricsTest() || shouldSkipTracingTest()) {
sentryTest.skip();
}

Expand Down
3 changes: 3 additions & 0 deletions dev-packages/browser-integration-tests/utils/generatePlugin.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,9 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
bundle_replay_min: 'build/bundles/bundle.replay.min.js',
bundle_tracing: 'build/bundles/bundle.tracing.js',
bundle_tracing_min: 'build/bundles/bundle.tracing.min.js',
bundle_logs_metrics: 'build/bundles/bundle.logs.metrics.js',
bundle_logs_metrics_min: 'build/bundles/bundle.logs.metrics.min.js',
bundle_logs_metrics_debug_min: 'build/bundles/bundle.logs.metrics.debug.min.js',
bundle_tracing_logs_metrics: 'build/bundles/bundle.tracing.logs.metrics.js',
bundle_tracing_logs_metrics_min: 'build/bundles/bundle.tracing.logs.metrics.min.js',
bundle_tracing_logs_metrics_debug_min: 'build/bundles/bundle.tracing.logs.metrics.debug.min.js',
Expand Down
8 changes: 8 additions & 0 deletions packages/browser/rollup.bundle.config.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,6 +104,13 @@ const tracingReplayFeedbackBaseBundleConfig = makeBaseBundleConfig({
outputFileBase: () => 'bundles/bundle.tracing.replay.feedback',
});

const logsMetricsBaseBundleConfig = makeBaseBundleConfig({
bundleType: 'standalone',
entrypoints: ['src/index.bundle.logs.metrics.ts'],
licenseTitle: '@sentry/browser (Logs and Metrics)',
outputFileBase: () => 'bundles/bundle.logs.metrics',
});

const tracingLogsMetricsBaseBundleConfig = makeBaseBundleConfig({
bundleType: 'standalone',
entrypoints: ['src/index.bundle.tracing.logs.metrics.ts'],
Expand All@@ -126,6 +133,7 @@ builds.push(
...makeBundleConfigVariants(tracingReplayBaseBundleConfig),
...makeBundleConfigVariants(replayFeedbackBaseBundleConfig),
...makeBundleConfigVariants(tracingReplayFeedbackBaseBundleConfig),
...makeBundleConfigVariants(logsMetricsBaseBundleConfig),
...makeBundleConfigVariants(tracingLogsMetricsBaseBundleConfig),
...makeBundleConfigVariants(tracingReplayFeedbackLogsMetricsBaseBundleConfig),
);
Expand Down
17 changes: 17 additions & 0 deletions packages/browser/src/index.bundle.logs.metrics.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
import {
browserTracingIntegrationShim,
feedbackIntegrationShim,
replayIntegrationShim,
} from '@sentry-internal/integration-shims';

export * from './index.bundle.base';

// TODO(v11): Export metrics here once we remove it from the base bundle.
export { logger, consoleLoggingIntegration } from '@sentry/core';

export {
browserTracingIntegrationShim as browserTracingIntegration,
feedbackIntegrationShim as feedbackAsyncIntegration,
feedbackIntegrationShim as feedbackIntegration,
replayIntegrationShim as replayIntegration,
};
10 changes: 10 additions & 0 deletions packages/browser/test/index.bundle.logs.metrics.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { logger as coreLogger, metrics as coreMetrics } from '@sentry/core';
import { describe, expect, it } from 'vitest';
import * as LogsMetricsBundle from '../src/index.bundle.logs.metrics';

describe('index.bundle.logs.metrics', () => {
it('has correct exports', () => {
expect(LogsMetricsBundle.logger).toBe(coreLogger);
expect(LogsMetricsBundle.metrics).toBe(coreMetrics);
});
});

@cursorcursorBotJan 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test is incomplete compared to existing patterns

Low Severity · Bugbot Rules

The unit test only verifies logger and metrics exports, but all other bundle tests (e.g., index.bundle.test.ts, index.bundle.tracing.test.ts, index.bundle.tracing.logs.metrics.test.ts) also verify that integration shims are correctly exported. This test is missing assertions for browserTracingIntegration, feedbackIntegration, feedbackAsyncIntegration, replayIntegration (all should be shims), and consoleLoggingIntegration (should be the real implementation). This violates the review rule to "check that tests actually test the newly added behaviour" - incomplete coverage could miss regressions where shims are accidentally replaced with real implementations.

Fix in CursorFix in Web

@chargomechargomeJan 28, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is simply not true.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(browser): Add logs.metrics bundle#19020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

chargome
merged 3 commits into

from

Jan 28, 2026
 Merged


feat(browser): Add logs.metrics bundle
#19020
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
2e6c678

add logs.metrics bundle


chargome Jan 28, 2026
ce88920

bump size limit


chargome Jan 28, 2026
1af3be2

skip tracing test


chargome Jan 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -568,6 +568,7 @@ jobs:
 - bundle_min
 - bundle_replay
 - bundle_tracing
 - bundle_logs_metrics
 - bundle_tracing_logs_metrics
 - bundle_tracing_replay
 - bundle_tracing_replay_feedback
Expand Down

13 changes: 13 additions & 0 deletions
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -186,6 +186,12 @@ module.exports = [
 gzip: true,
 limit: '43 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics)',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: true,
 limit: '29 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics)',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand DownExpand Up@@ -225,6 +231,13 @@ module.exports = [
 brotli: false,
 limit: '128 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: false,
 brotli: false,
 limit: '86 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,9 @@
 "test:bundle:replay:min": "PW_BUNDLE=bundle_replay_min yarn test",
 "test:bundle:tracing": "PW_BUNDLE=bundle_tracing yarn test",
 "test:bundle:tracing:min": "PW_BUNDLE=bundle_tracing_min yarn test",
 "test:bundle:logs_metrics": "PW_BUNDLE=bundle_logs_metrics yarn test",
 "test:bundle:logs_metrics:min": "PW_BUNDLE=bundle_logs_metrics_min yarn test",
 "test:bundle:logs_metrics:debug_min": "PW_BUNDLE=bundle_logs_metrics_debug_min yarn test",
 "test:bundle:tracing_logs_metrics": "PW_BUNDLE=bundle_tracing_logs_metrics yarn test",
 "test:bundle:tracing_logs_metrics:min": "PW_BUNDLE=bundle_tracing_logs_metrics_min yarn test",
 "test:bundle:tracing_logs_metrics:debug_min": "PW_BUNDLE=bundle_tracing_logs_metrics_debug_min yarn test",
Expand Down

6 changes: 4 additions & 2 deletions
dev-packages/browser-integration-tests/suites/public-api/metrics/simple/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,11 +5,13 @@ import {
 getFirstSentryEnvelopeRequest,
 properFullEnvelopeRequestParser,
 shouldSkipMetricsTest,
 shouldSkipTracingTest,
} from '../../../../utils/helpers';

sentryTest('should capture all metric types', async ({ getLocalTestUrl, page }) => {
 // Only run this for npm package exports and CDN bundles with metrics
 if (shouldSkipMetricsTest()) {
 // Only run this for npm package exports and CDN bundles with metrics and tracing
 // (the test uses Sentry.startSpan which requires tracing)
 if (shouldSkipMetricsTest() || shouldSkipTracingTest()) {
 sentryTest.skip();
 }

Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/utils/generatePlugin.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,9 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
 bundle_replay_min: 'build/bundles/bundle.replay.min.js',
 bundle_tracing: 'build/bundles/bundle.tracing.js',
 bundle_tracing_min: 'build/bundles/bundle.tracing.min.js',
 bundle_logs_metrics: 'build/bundles/bundle.logs.metrics.js',
 bundle_logs_metrics_min: 'build/bundles/bundle.logs.metrics.min.js',
 bundle_logs_metrics_debug_min: 'build/bundles/bundle.logs.metrics.debug.min.js',
 bundle_tracing_logs_metrics: 'build/bundles/bundle.tracing.logs.metrics.js',
 bundle_tracing_logs_metrics_min: 'build/bundles/bundle.tracing.logs.metrics.min.js',
 bundle_tracing_logs_metrics_debug_min: 'build/bundles/bundle.tracing.logs.metrics.debug.min.js',
Expand Down

8 changes: 8 additions & 0 deletions
packages/browser/rollup.bundle.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,6 +104,13 @@ const tracingReplayFeedbackBaseBundleConfig = makeBaseBundleConfig({
 outputFileBase: () => 'bundles/bundle.tracing.replay.feedback',
});

const logsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.logs.metrics.ts'],
 licenseTitle: '@sentry/browser (Logs and Metrics)',
 outputFileBase: () => 'bundles/bundle.logs.metrics',
});

const tracingLogsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.tracing.logs.metrics.ts'],
Expand All@@ -126,6 +133,7 @@ builds.push(
 ...makeBundleConfigVariants(tracingReplayBaseBundleConfig),
 ...makeBundleConfigVariants(replayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(logsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingLogsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackLogsMetricsBaseBundleConfig),
);
Expand Down

17 changes: 17 additions & 0 deletions
packages/browser/src/index.bundle.logs.metrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
import {
 browserTracingIntegrationShim,
 feedbackIntegrationShim,
 replayIntegrationShim,
} from '@sentry-internal/integration-shims';

export * from './index.bundle.base';

// TODO(v11): Export metrics here once we remove it from the base bundle.
export { logger, consoleLoggingIntegration } from '@sentry/core';

export {
 browserTracingIntegrationShim as browserTracingIntegration,
 feedbackIntegrationShim as feedbackAsyncIntegration,
 feedbackIntegrationShim as feedbackIntegration,
 replayIntegrationShim as replayIntegration,
};

10 changes: 10 additions & 0 deletions
packages/browser/test/index.bundle.logs.metrics.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { logger as coreLogger, metrics as coreMetrics } from '@sentry/core';
import { describe, expect, it } from 'vitest';
import * as LogsMetricsBundle from '../src/index.bundle.logs.metrics';

describe('index.bundle.logs.metrics', () => {
 it('has correct exports', () => {
 expect(LogsMetricsBundle.logger).toBe(coreLogger);
 expect(LogsMetricsBundle.metrics).toBe(coreMetrics);
 });
});
@cursorcursorBotJan 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test is incomplete compared to existing patterns
Low Severity · Bugbot Rules
The unit test only verifies logger and metrics exports, but all other bundle tests (e.g., index.bundle.test.ts, index.bundle.tracing.test.ts, index.bundle.tracing.logs.metrics.test.ts) also verify that integration shims are correctly exported. This test is missing assertions for browserTracingIntegration, feedbackIntegration, feedbackAsyncIntegration, replayIntegration (all should be shims), and consoleLoggingIntegration (should be the real implementation). This violates the review rule to "check that tests actually test the newly added behaviour" - incomplete coverage could miss regressions where shims are accidentally replaced with real implementations.
Fix in CursorFix in Web
@chargomechargomeJan 28, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is simply not true.
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(browser): Add logs.metrics bundle#19020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

chargome
merged 3 commits into

from

Jan 28, 2026
 Merged


feat(browser): Add logs.metrics bundle
#19020
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
2e6c678

add logs.metrics bundle


chargome Jan 28, 2026
ce88920

bump size limit


chargome Jan 28, 2026
1af3be2

skip tracing test


chargome Jan 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -568,6 +568,7 @@ jobs:
 - bundle_min
 - bundle_replay
 - bundle_tracing
 - bundle_logs_metrics
 - bundle_tracing_logs_metrics
 - bundle_tracing_replay
 - bundle_tracing_replay_feedback
Expand Down

13 changes: 13 additions & 0 deletions
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -186,6 +186,12 @@ module.exports = [
 gzip: true,
 limit: '43 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics)',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: true,
 limit: '29 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics)',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand DownExpand Up@@ -225,6 +231,13 @@ module.exports = [
 brotli: false,
 limit: '128 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: false,
 brotli: false,
 limit: '86 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,9 @@
 "test:bundle:replay:min": "PW_BUNDLE=bundle_replay_min yarn test",
 "test:bundle:tracing": "PW_BUNDLE=bundle_tracing yarn test",
 "test:bundle:tracing:min": "PW_BUNDLE=bundle_tracing_min yarn test",
 "test:bundle:logs_metrics": "PW_BUNDLE=bundle_logs_metrics yarn test",
 "test:bundle:logs_metrics:min": "PW_BUNDLE=bundle_logs_metrics_min yarn test",
 "test:bundle:logs_metrics:debug_min": "PW_BUNDLE=bundle_logs_metrics_debug_min yarn test",
 "test:bundle:tracing_logs_metrics": "PW_BUNDLE=bundle_tracing_logs_metrics yarn test",
 "test:bundle:tracing_logs_metrics:min": "PW_BUNDLE=bundle_tracing_logs_metrics_min yarn test",
 "test:bundle:tracing_logs_metrics:debug_min": "PW_BUNDLE=bundle_tracing_logs_metrics_debug_min yarn test",
Expand Down

6 changes: 4 additions & 2 deletions
dev-packages/browser-integration-tests/suites/public-api/metrics/simple/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,11 +5,13 @@ import {
 getFirstSentryEnvelopeRequest,
 properFullEnvelopeRequestParser,
 shouldSkipMetricsTest,
 shouldSkipTracingTest,
} from '../../../../utils/helpers';

sentryTest('should capture all metric types', async ({ getLocalTestUrl, page }) => {
 // Only run this for npm package exports and CDN bundles with metrics
 if (shouldSkipMetricsTest()) {
 // Only run this for npm package exports and CDN bundles with metrics and tracing
 // (the test uses Sentry.startSpan which requires tracing)
 if (shouldSkipMetricsTest() || shouldSkipTracingTest()) {
 sentryTest.skip();
 }

Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/utils/generatePlugin.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,9 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
 bundle_replay_min: 'build/bundles/bundle.replay.min.js',
 bundle_tracing: 'build/bundles/bundle.tracing.js',
 bundle_tracing_min: 'build/bundles/bundle.tracing.min.js',
 bundle_logs_metrics: 'build/bundles/bundle.logs.metrics.js',
 bundle_logs_metrics_min: 'build/bundles/bundle.logs.metrics.min.js',
 bundle_logs_metrics_debug_min: 'build/bundles/bundle.logs.metrics.debug.min.js',
 bundle_tracing_logs_metrics: 'build/bundles/bundle.tracing.logs.metrics.js',
 bundle_tracing_logs_metrics_min: 'build/bundles/bundle.tracing.logs.metrics.min.js',
 bundle_tracing_logs_metrics_debug_min: 'build/bundles/bundle.tracing.logs.metrics.debug.min.js',
Expand Down

8 changes: 8 additions & 0 deletions
packages/browser/rollup.bundle.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,6 +104,13 @@ const tracingReplayFeedbackBaseBundleConfig = makeBaseBundleConfig({
 outputFileBase: () => 'bundles/bundle.tracing.replay.feedback',
});

const logsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.logs.metrics.ts'],
 licenseTitle: '@sentry/browser (Logs and Metrics)',
 outputFileBase: () => 'bundles/bundle.logs.metrics',
});

const tracingLogsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.tracing.logs.metrics.ts'],
Expand All@@ -126,6 +133,7 @@ builds.push(
 ...makeBundleConfigVariants(tracingReplayBaseBundleConfig),
 ...makeBundleConfigVariants(replayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(logsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingLogsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackLogsMetricsBaseBundleConfig),
);
Expand Down

17 changes: 17 additions & 0 deletions
packages/browser/src/index.bundle.logs.metrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
import {
 browserTracingIntegrationShim,
 feedbackIntegrationShim,
 replayIntegrationShim,
} from '@sentry-internal/integration-shims';

export * from './index.bundle.base';

// TODO(v11): Export metrics here once we remove it from the base bundle.
export { logger, consoleLoggingIntegration } from '@sentry/core';

export {
 browserTracingIntegrationShim as browserTracingIntegration,
 feedbackIntegrationShim as feedbackAsyncIntegration,
 feedbackIntegrationShim as feedbackIntegration,
 replayIntegrationShim as replayIntegration,
};

10 changes: 10 additions & 0 deletions
packages/browser/test/index.bundle.logs.metrics.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { logger as coreLogger, metrics as coreMetrics } from '@sentry/core';
import { describe, expect, it } from 'vitest';
import * as LogsMetricsBundle from '../src/index.bundle.logs.metrics';

describe('index.bundle.logs.metrics', () => {
 it('has correct exports', () => {
 expect(LogsMetricsBundle.logger).toBe(coreLogger);
 expect(LogsMetricsBundle.metrics).toBe(coreMetrics);
 });
});
@cursorcursorBotJan 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test is incomplete compared to existing patterns
Low Severity · Bugbot Rules
The unit test only verifies logger and metrics exports, but all other bundle tests (e.g., index.bundle.test.ts, index.bundle.tracing.test.ts, index.bundle.tracing.logs.metrics.test.ts) also verify that integration shims are correctly exported. This test is missing assertions for browserTracingIntegration, feedbackIntegration, feedbackAsyncIntegration, replayIntegration (all should be shims), and consoleLoggingIntegration (should be the real implementation). This violates the review rule to "check that tests actually test the newly added behaviour" - incomplete coverage could miss regressions where shims are accidentally replaced with real implementations.
Fix in CursorFix in Web
@chargomechargomeJan 28, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is simply not true.
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(browser): Add logs.metrics bundle#19020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

chargome
merged 3 commits into

from

Jan 28, 2026
 Merged


feat(browser): Add logs.metrics bundle
#19020
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
2e6c678

add logs.metrics bundle


chargome Jan 28, 2026
ce88920

bump size limit


chargome Jan 28, 2026
1af3be2

skip tracing test


chargome Jan 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -568,6 +568,7 @@ jobs:
 - bundle_min
 - bundle_replay
 - bundle_tracing
 - bundle_logs_metrics
 - bundle_tracing_logs_metrics
 - bundle_tracing_replay
 - bundle_tracing_replay_feedback
Expand Down

13 changes: 13 additions & 0 deletions
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -186,6 +186,12 @@ module.exports = [
 gzip: true,
 limit: '43 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics)',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: true,
 limit: '29 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics)',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand DownExpand Up@@ -225,6 +231,13 @@ module.exports = [
 brotli: false,
 limit: '128 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: false,
 brotli: false,
 limit: '86 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,9 @@
 "test:bundle:replay:min": "PW_BUNDLE=bundle_replay_min yarn test",
 "test:bundle:tracing": "PW_BUNDLE=bundle_tracing yarn test",
 "test:bundle:tracing:min": "PW_BUNDLE=bundle_tracing_min yarn test",
 "test:bundle:logs_metrics": "PW_BUNDLE=bundle_logs_metrics yarn test",
 "test:bundle:logs_metrics:min": "PW_BUNDLE=bundle_logs_metrics_min yarn test",
 "test:bundle:logs_metrics:debug_min": "PW_BUNDLE=bundle_logs_metrics_debug_min yarn test",
 "test:bundle:tracing_logs_metrics": "PW_BUNDLE=bundle_tracing_logs_metrics yarn test",
 "test:bundle:tracing_logs_metrics:min": "PW_BUNDLE=bundle_tracing_logs_metrics_min yarn test",
 "test:bundle:tracing_logs_metrics:debug_min": "PW_BUNDLE=bundle_tracing_logs_metrics_debug_min yarn test",
Expand Down

6 changes: 4 additions & 2 deletions
dev-packages/browser-integration-tests/suites/public-api/metrics/simple/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,11 +5,13 @@ import {
 getFirstSentryEnvelopeRequest,
 properFullEnvelopeRequestParser,
 shouldSkipMetricsTest,
 shouldSkipTracingTest,
} from '../../../../utils/helpers';

sentryTest('should capture all metric types', async ({ getLocalTestUrl, page }) => {
 // Only run this for npm package exports and CDN bundles with metrics
 if (shouldSkipMetricsTest()) {
 // Only run this for npm package exports and CDN bundles with metrics and tracing
 // (the test uses Sentry.startSpan which requires tracing)
 if (shouldSkipMetricsTest() || shouldSkipTracingTest()) {
 sentryTest.skip();
 }

Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/utils/generatePlugin.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,9 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
 bundle_replay_min: 'build/bundles/bundle.replay.min.js',
 bundle_tracing: 'build/bundles/bundle.tracing.js',
 bundle_tracing_min: 'build/bundles/bundle.tracing.min.js',
 bundle_logs_metrics: 'build/bundles/bundle.logs.metrics.js',
 bundle_logs_metrics_min: 'build/bundles/bundle.logs.metrics.min.js',
 bundle_logs_metrics_debug_min: 'build/bundles/bundle.logs.metrics.debug.min.js',
 bundle_tracing_logs_metrics: 'build/bundles/bundle.tracing.logs.metrics.js',
 bundle_tracing_logs_metrics_min: 'build/bundles/bundle.tracing.logs.metrics.min.js',
 bundle_tracing_logs_metrics_debug_min: 'build/bundles/bundle.tracing.logs.metrics.debug.min.js',
Expand Down

8 changes: 8 additions & 0 deletions
packages/browser/rollup.bundle.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,6 +104,13 @@ const tracingReplayFeedbackBaseBundleConfig = makeBaseBundleConfig({
 outputFileBase: () => 'bundles/bundle.tracing.replay.feedback',
});

const logsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.logs.metrics.ts'],
 licenseTitle: '@sentry/browser (Logs and Metrics)',
 outputFileBase: () => 'bundles/bundle.logs.metrics',
});

const tracingLogsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.tracing.logs.metrics.ts'],
Expand All@@ -126,6 +133,7 @@ builds.push(
 ...makeBundleConfigVariants(tracingReplayBaseBundleConfig),
 ...makeBundleConfigVariants(replayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(logsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingLogsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackLogsMetricsBaseBundleConfig),
);
Expand Down

17 changes: 17 additions & 0 deletions
packages/browser/src/index.bundle.logs.metrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
import {
 browserTracingIntegrationShim,
 feedbackIntegrationShim,
 replayIntegrationShim,
} from '@sentry-internal/integration-shims';

export * from './index.bundle.base';

// TODO(v11): Export metrics here once we remove it from the base bundle.
export { logger, consoleLoggingIntegration } from '@sentry/core';

export {
 browserTracingIntegrationShim as browserTracingIntegration,
 feedbackIntegrationShim as feedbackAsyncIntegration,
 feedbackIntegrationShim as feedbackIntegration,
 replayIntegrationShim as replayIntegration,
};

10 changes: 10 additions & 0 deletions
packages/browser/test/index.bundle.logs.metrics.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { logger as coreLogger, metrics as coreMetrics } from '@sentry/core';
import { describe, expect, it } from 'vitest';
import * as LogsMetricsBundle from '../src/index.bundle.logs.metrics';

describe('index.bundle.logs.metrics', () => {
 it('has correct exports', () => {
 expect(LogsMetricsBundle.logger).toBe(coreLogger);
 expect(LogsMetricsBundle.metrics).toBe(coreMetrics);
 });
});
@cursorcursorBotJan 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test is incomplete compared to existing patterns
Low Severity · Bugbot Rules
The unit test only verifies logger and metrics exports, but all other bundle tests (e.g., index.bundle.test.ts, index.bundle.tracing.test.ts, index.bundle.tracing.logs.metrics.test.ts) also verify that integration shims are correctly exported. This test is missing assertions for browserTracingIntegration, feedbackIntegration, feedbackAsyncIntegration, replayIntegration (all should be shims), and consoleLoggingIntegration (should be the real implementation). This violates the review rule to "check that tests actually test the newly added behaviour" - incomplete coverage could miss regressions where shims are accidentally replaced with real implementations.
Fix in CursorFix in Web
@chargomechargomeJan 28, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is simply not true.
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(browser): Add logs.metrics bundle#19020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

chargome
merged 3 commits into

from

Jan 28, 2026
 Merged


feat(browser): Add logs.metrics bundle
#19020
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
2e6c678

add logs.metrics bundle


chargome Jan 28, 2026
ce88920

bump size limit


chargome Jan 28, 2026
1af3be2

skip tracing test


chargome Jan 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -568,6 +568,7 @@ jobs:
 - bundle_min
 - bundle_replay
 - bundle_tracing
 - bundle_logs_metrics
 - bundle_tracing_logs_metrics
 - bundle_tracing_replay
 - bundle_tracing_replay_feedback
Expand Down

13 changes: 13 additions & 0 deletions
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -186,6 +186,12 @@ module.exports = [
 gzip: true,
 limit: '43 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics)',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: true,
 limit: '29 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics)',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand DownExpand Up@@ -225,6 +231,13 @@ module.exports = [
 brotli: false,
 limit: '128 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: false,
 brotli: false,
 limit: '86 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,9 @@
 "test:bundle:replay:min": "PW_BUNDLE=bundle_replay_min yarn test",
 "test:bundle:tracing": "PW_BUNDLE=bundle_tracing yarn test",
 "test:bundle:tracing:min": "PW_BUNDLE=bundle_tracing_min yarn test",
 "test:bundle:logs_metrics": "PW_BUNDLE=bundle_logs_metrics yarn test",
 "test:bundle:logs_metrics:min": "PW_BUNDLE=bundle_logs_metrics_min yarn test",
 "test:bundle:logs_metrics:debug_min": "PW_BUNDLE=bundle_logs_metrics_debug_min yarn test",
 "test:bundle:tracing_logs_metrics": "PW_BUNDLE=bundle_tracing_logs_metrics yarn test",
 "test:bundle:tracing_logs_metrics:min": "PW_BUNDLE=bundle_tracing_logs_metrics_min yarn test",
 "test:bundle:tracing_logs_metrics:debug_min": "PW_BUNDLE=bundle_tracing_logs_metrics_debug_min yarn test",
Expand Down

6 changes: 4 additions & 2 deletions
dev-packages/browser-integration-tests/suites/public-api/metrics/simple/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,11 +5,13 @@ import {
 getFirstSentryEnvelopeRequest,
 properFullEnvelopeRequestParser,
 shouldSkipMetricsTest,
 shouldSkipTracingTest,
} from '../../../../utils/helpers';

sentryTest('should capture all metric types', async ({ getLocalTestUrl, page }) => {
 // Only run this for npm package exports and CDN bundles with metrics
 if (shouldSkipMetricsTest()) {
 // Only run this for npm package exports and CDN bundles with metrics and tracing
 // (the test uses Sentry.startSpan which requires tracing)
 if (shouldSkipMetricsTest() || shouldSkipTracingTest()) {
 sentryTest.skip();
 }

Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/utils/generatePlugin.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,9 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
 bundle_replay_min: 'build/bundles/bundle.replay.min.js',
 bundle_tracing: 'build/bundles/bundle.tracing.js',
 bundle_tracing_min: 'build/bundles/bundle.tracing.min.js',
 bundle_logs_metrics: 'build/bundles/bundle.logs.metrics.js',
 bundle_logs_metrics_min: 'build/bundles/bundle.logs.metrics.min.js',
 bundle_logs_metrics_debug_min: 'build/bundles/bundle.logs.metrics.debug.min.js',
 bundle_tracing_logs_metrics: 'build/bundles/bundle.tracing.logs.metrics.js',
 bundle_tracing_logs_metrics_min: 'build/bundles/bundle.tracing.logs.metrics.min.js',
 bundle_tracing_logs_metrics_debug_min: 'build/bundles/bundle.tracing.logs.metrics.debug.min.js',
Expand Down

8 changes: 8 additions & 0 deletions
packages/browser/rollup.bundle.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,6 +104,13 @@ const tracingReplayFeedbackBaseBundleConfig = makeBaseBundleConfig({
 outputFileBase: () => 'bundles/bundle.tracing.replay.feedback',
});

const logsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.logs.metrics.ts'],
 licenseTitle: '@sentry/browser (Logs and Metrics)',
 outputFileBase: () => 'bundles/bundle.logs.metrics',
});

const tracingLogsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.tracing.logs.metrics.ts'],
Expand All@@ -126,6 +133,7 @@ builds.push(
 ...makeBundleConfigVariants(tracingReplayBaseBundleConfig),
 ...makeBundleConfigVariants(replayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(logsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingLogsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackLogsMetricsBaseBundleConfig),
);
Expand Down

17 changes: 17 additions & 0 deletions
packages/browser/src/index.bundle.logs.metrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
import {
 browserTracingIntegrationShim,
 feedbackIntegrationShim,
 replayIntegrationShim,
} from '@sentry-internal/integration-shims';

export * from './index.bundle.base';

// TODO(v11): Export metrics here once we remove it from the base bundle.
export { logger, consoleLoggingIntegration } from '@sentry/core';

export {
 browserTracingIntegrationShim as browserTracingIntegration,
 feedbackIntegrationShim as feedbackAsyncIntegration,
 feedbackIntegrationShim as feedbackIntegration,
 replayIntegrationShim as replayIntegration,
};

10 changes: 10 additions & 0 deletions
packages/browser/test/index.bundle.logs.metrics.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { logger as coreLogger, metrics as coreMetrics } from '@sentry/core';
import { describe, expect, it } from 'vitest';
import * as LogsMetricsBundle from '../src/index.bundle.logs.metrics';

describe('index.bundle.logs.metrics', () => {
 it('has correct exports', () => {
 expect(LogsMetricsBundle.logger).toBe(coreLogger);
 expect(LogsMetricsBundle.metrics).toBe(coreMetrics);
 });
});
@cursorcursorBotJan 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test is incomplete compared to existing patterns
Low Severity · Bugbot Rules
The unit test only verifies logger and metrics exports, but all other bundle tests (e.g., index.bundle.test.ts, index.bundle.tracing.test.ts, index.bundle.tracing.logs.metrics.test.ts) also verify that integration shims are correctly exported. This test is missing assertions for browserTracingIntegration, feedbackIntegration, feedbackAsyncIntegration, replayIntegration (all should be shims), and consoleLoggingIntegration (should be the real implementation). This violates the review rule to "check that tests actually test the newly added behaviour" - incomplete coverage could miss regressions where shims are accidentally replaced with real implementations.
Fix in CursorFix in Web
@chargomechargomeJan 28, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is simply not true.
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(browser): Add logs.metrics bundle#19020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

chargome
merged 3 commits into

from

Jan 28, 2026
 Merged


feat(browser): Add logs.metrics bundle
#19020
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
2e6c678

add logs.metrics bundle


chargome Jan 28, 2026
ce88920

bump size limit


chargome Jan 28, 2026
1af3be2

skip tracing test


chargome Jan 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -568,6 +568,7 @@ jobs:
 - bundle_min
 - bundle_replay
 - bundle_tracing
 - bundle_logs_metrics
 - bundle_tracing_logs_metrics
 - bundle_tracing_replay
 - bundle_tracing_replay_feedback
Expand Down

13 changes: 13 additions & 0 deletions
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -186,6 +186,12 @@ module.exports = [
 gzip: true,
 limit: '43 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics)',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: true,
 limit: '29 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics)',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand DownExpand Up@@ -225,6 +231,13 @@ module.exports = [
 brotli: false,
 limit: '128 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: false,
 brotli: false,
 limit: '86 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,9 @@
 "test:bundle:replay:min": "PW_BUNDLE=bundle_replay_min yarn test",
 "test:bundle:tracing": "PW_BUNDLE=bundle_tracing yarn test",
 "test:bundle:tracing:min": "PW_BUNDLE=bundle_tracing_min yarn test",
 "test:bundle:logs_metrics": "PW_BUNDLE=bundle_logs_metrics yarn test",
 "test:bundle:logs_metrics:min": "PW_BUNDLE=bundle_logs_metrics_min yarn test",
 "test:bundle:logs_metrics:debug_min": "PW_BUNDLE=bundle_logs_metrics_debug_min yarn test",
 "test:bundle:tracing_logs_metrics": "PW_BUNDLE=bundle_tracing_logs_metrics yarn test",
 "test:bundle:tracing_logs_metrics:min": "PW_BUNDLE=bundle_tracing_logs_metrics_min yarn test",
 "test:bundle:tracing_logs_metrics:debug_min": "PW_BUNDLE=bundle_tracing_logs_metrics_debug_min yarn test",
Expand Down

6 changes: 4 additions & 2 deletions
dev-packages/browser-integration-tests/suites/public-api/metrics/simple/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,11 +5,13 @@ import {
 getFirstSentryEnvelopeRequest,
 properFullEnvelopeRequestParser,
 shouldSkipMetricsTest,
 shouldSkipTracingTest,
} from '../../../../utils/helpers';

sentryTest('should capture all metric types', async ({ getLocalTestUrl, page }) => {
 // Only run this for npm package exports and CDN bundles with metrics
 if (shouldSkipMetricsTest()) {
 // Only run this for npm package exports and CDN bundles with metrics and tracing
 // (the test uses Sentry.startSpan which requires tracing)
 if (shouldSkipMetricsTest() || shouldSkipTracingTest()) {
 sentryTest.skip();
 }

Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/utils/generatePlugin.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,9 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
 bundle_replay_min: 'build/bundles/bundle.replay.min.js',
 bundle_tracing: 'build/bundles/bundle.tracing.js',
 bundle_tracing_min: 'build/bundles/bundle.tracing.min.js',
 bundle_logs_metrics: 'build/bundles/bundle.logs.metrics.js',
 bundle_logs_metrics_min: 'build/bundles/bundle.logs.metrics.min.js',
 bundle_logs_metrics_debug_min: 'build/bundles/bundle.logs.metrics.debug.min.js',
 bundle_tracing_logs_metrics: 'build/bundles/bundle.tracing.logs.metrics.js',
 bundle_tracing_logs_metrics_min: 'build/bundles/bundle.tracing.logs.metrics.min.js',
 bundle_tracing_logs_metrics_debug_min: 'build/bundles/bundle.tracing.logs.metrics.debug.min.js',
Expand Down

8 changes: 8 additions & 0 deletions
packages/browser/rollup.bundle.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,6 +104,13 @@ const tracingReplayFeedbackBaseBundleConfig = makeBaseBundleConfig({
 outputFileBase: () => 'bundles/bundle.tracing.replay.feedback',
});

const logsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.logs.metrics.ts'],
 licenseTitle: '@sentry/browser (Logs and Metrics)',
 outputFileBase: () => 'bundles/bundle.logs.metrics',
});

const tracingLogsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.tracing.logs.metrics.ts'],
Expand All@@ -126,6 +133,7 @@ builds.push(
 ...makeBundleConfigVariants(tracingReplayBaseBundleConfig),
 ...makeBundleConfigVariants(replayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(logsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingLogsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackLogsMetricsBaseBundleConfig),
);
Expand Down

17 changes: 17 additions & 0 deletions
packages/browser/src/index.bundle.logs.metrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
import {
 browserTracingIntegrationShim,
 feedbackIntegrationShim,
 replayIntegrationShim,
} from '@sentry-internal/integration-shims';

export * from './index.bundle.base';

// TODO(v11): Export metrics here once we remove it from the base bundle.
export { logger, consoleLoggingIntegration } from '@sentry/core';

export {
 browserTracingIntegrationShim as browserTracingIntegration,
 feedbackIntegrationShim as feedbackAsyncIntegration,
 feedbackIntegrationShim as feedbackIntegration,
 replayIntegrationShim as replayIntegration,
};

10 changes: 10 additions & 0 deletions
packages/browser/test/index.bundle.logs.metrics.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { logger as coreLogger, metrics as coreMetrics } from '@sentry/core';
import { describe, expect, it } from 'vitest';
import * as LogsMetricsBundle from '../src/index.bundle.logs.metrics';

describe('index.bundle.logs.metrics', () => {
 it('has correct exports', () => {
 expect(LogsMetricsBundle.logger).toBe(coreLogger);
 expect(LogsMetricsBundle.metrics).toBe(coreMetrics);
 });
});
@cursorcursorBotJan 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test is incomplete compared to existing patterns
Low Severity · Bugbot Rules
The unit test only verifies logger and metrics exports, but all other bundle tests (e.g., index.bundle.test.ts, index.bundle.tracing.test.ts, index.bundle.tracing.logs.metrics.test.ts) also verify that integration shims are correctly exported. This test is missing assertions for browserTracingIntegration, feedbackIntegration, feedbackAsyncIntegration, replayIntegration (all should be shims), and consoleLoggingIntegration (should be the real implementation). This violates the review rule to "check that tests actually test the newly added behaviour" - incomplete coverage could miss regressions where shims are accidentally replaced with real implementations.
Fix in CursorFix in Web
@chargomechargomeJan 28, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is simply not true.
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(browser): Add logs.metrics bundle#19020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

chargome
merged 3 commits into

from

Jan 28, 2026
 Merged


feat(browser): Add logs.metrics bundle
#19020
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
2e6c678

add logs.metrics bundle


chargome Jan 28, 2026
ce88920

bump size limit


chargome Jan 28, 2026
1af3be2

skip tracing test


chargome Jan 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -568,6 +568,7 @@ jobs:
 - bundle_min
 - bundle_replay
 - bundle_tracing
 - bundle_logs_metrics
 - bundle_tracing_logs_metrics
 - bundle_tracing_replay
 - bundle_tracing_replay_feedback
Expand Down

13 changes: 13 additions & 0 deletions
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -186,6 +186,12 @@ module.exports = [
 gzip: true,
 limit: '43 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics)',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: true,
 limit: '29 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics)',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand DownExpand Up@@ -225,6 +231,13 @@ module.exports = [
 brotli: false,
 limit: '128 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: false,
 brotli: false,
 limit: '86 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,9 @@
 "test:bundle:replay:min": "PW_BUNDLE=bundle_replay_min yarn test",
 "test:bundle:tracing": "PW_BUNDLE=bundle_tracing yarn test",
 "test:bundle:tracing:min": "PW_BUNDLE=bundle_tracing_min yarn test",
 "test:bundle:logs_metrics": "PW_BUNDLE=bundle_logs_metrics yarn test",
 "test:bundle:logs_metrics:min": "PW_BUNDLE=bundle_logs_metrics_min yarn test",
 "test:bundle:logs_metrics:debug_min": "PW_BUNDLE=bundle_logs_metrics_debug_min yarn test",
 "test:bundle:tracing_logs_metrics": "PW_BUNDLE=bundle_tracing_logs_metrics yarn test",
 "test:bundle:tracing_logs_metrics:min": "PW_BUNDLE=bundle_tracing_logs_metrics_min yarn test",
 "test:bundle:tracing_logs_metrics:debug_min": "PW_BUNDLE=bundle_tracing_logs_metrics_debug_min yarn test",
Expand Down

6 changes: 4 additions & 2 deletions
dev-packages/browser-integration-tests/suites/public-api/metrics/simple/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,11 +5,13 @@ import {
 getFirstSentryEnvelopeRequest,
 properFullEnvelopeRequestParser,
 shouldSkipMetricsTest,
 shouldSkipTracingTest,
} from '../../../../utils/helpers';

sentryTest('should capture all metric types', async ({ getLocalTestUrl, page }) => {
 // Only run this for npm package exports and CDN bundles with metrics
 if (shouldSkipMetricsTest()) {
 // Only run this for npm package exports and CDN bundles with metrics and tracing
 // (the test uses Sentry.startSpan which requires tracing)
 if (shouldSkipMetricsTest() || shouldSkipTracingTest()) {
 sentryTest.skip();
 }

Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/utils/generatePlugin.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,9 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
 bundle_replay_min: 'build/bundles/bundle.replay.min.js',
 bundle_tracing: 'build/bundles/bundle.tracing.js',
 bundle_tracing_min: 'build/bundles/bundle.tracing.min.js',
 bundle_logs_metrics: 'build/bundles/bundle.logs.metrics.js',
 bundle_logs_metrics_min: 'build/bundles/bundle.logs.metrics.min.js',
 bundle_logs_metrics_debug_min: 'build/bundles/bundle.logs.metrics.debug.min.js',
 bundle_tracing_logs_metrics: 'build/bundles/bundle.tracing.logs.metrics.js',
 bundle_tracing_logs_metrics_min: 'build/bundles/bundle.tracing.logs.metrics.min.js',
 bundle_tracing_logs_metrics_debug_min: 'build/bundles/bundle.tracing.logs.metrics.debug.min.js',
Expand Down

8 changes: 8 additions & 0 deletions
packages/browser/rollup.bundle.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,6 +104,13 @@ const tracingReplayFeedbackBaseBundleConfig = makeBaseBundleConfig({
 outputFileBase: () => 'bundles/bundle.tracing.replay.feedback',
});

const logsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.logs.metrics.ts'],
 licenseTitle: '@sentry/browser (Logs and Metrics)',
 outputFileBase: () => 'bundles/bundle.logs.metrics',
});

const tracingLogsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.tracing.logs.metrics.ts'],
Expand All@@ -126,6 +133,7 @@ builds.push(
 ...makeBundleConfigVariants(tracingReplayBaseBundleConfig),
 ...makeBundleConfigVariants(replayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(logsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingLogsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackLogsMetricsBaseBundleConfig),
);
Expand Down

17 changes: 17 additions & 0 deletions
packages/browser/src/index.bundle.logs.metrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
import {
 browserTracingIntegrationShim,
 feedbackIntegrationShim,
 replayIntegrationShim,
} from '@sentry-internal/integration-shims';

export * from './index.bundle.base';

// TODO(v11): Export metrics here once we remove it from the base bundle.
export { logger, consoleLoggingIntegration } from '@sentry/core';

export {
 browserTracingIntegrationShim as browserTracingIntegration,
 feedbackIntegrationShim as feedbackAsyncIntegration,
 feedbackIntegrationShim as feedbackIntegration,
 replayIntegrationShim as replayIntegration,
};

10 changes: 10 additions & 0 deletions
packages/browser/test/index.bundle.logs.metrics.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { logger as coreLogger, metrics as coreMetrics } from '@sentry/core';
import { describe, expect, it } from 'vitest';
import * as LogsMetricsBundle from '../src/index.bundle.logs.metrics';

describe('index.bundle.logs.metrics', () => {
 it('has correct exports', () => {
 expect(LogsMetricsBundle.logger).toBe(coreLogger);
 expect(LogsMetricsBundle.metrics).toBe(coreMetrics);
 });
});
@cursorcursorBotJan 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test is incomplete compared to existing patterns
Low Severity · Bugbot Rules
The unit test only verifies logger and metrics exports, but all other bundle tests (e.g., index.bundle.test.ts, index.bundle.tracing.test.ts, index.bundle.tracing.logs.metrics.test.ts) also verify that integration shims are correctly exported. This test is missing assertions for browserTracingIntegration, feedbackIntegration, feedbackAsyncIntegration, replayIntegration (all should be shims), and consoleLoggingIntegration (should be the real implementation). This violates the review rule to "check that tests actually test the newly added behaviour" - incomplete coverage could miss regressions where shims are accidentally replaced with real implementations.
Fix in CursorFix in Web
@chargomechargomeJan 28, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is simply not true.
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(browser): Add logs.metrics bundle#19020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

chargome
merged 3 commits into

from

Jan 28, 2026
 Merged


feat(browser): Add logs.metrics bundle
#19020
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
2e6c678

add logs.metrics bundle


chargome Jan 28, 2026
ce88920

bump size limit


chargome Jan 28, 2026
1af3be2

skip tracing test


chargome Jan 28, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -568,6 +568,7 @@ jobs:
 - bundle_min
 - bundle_replay
 - bundle_tracing
 - bundle_logs_metrics
 - bundle_tracing_logs_metrics
 - bundle_tracing_replay
 - bundle_tracing_replay_feedback
Expand Down

13 changes: 13 additions & 0 deletions
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -186,6 +186,12 @@ module.exports = [
 gzip: true,
 limit: '43 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics)',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: true,
 limit: '29 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics)',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand DownExpand Up@@ -225,6 +231,13 @@ module.exports = [
 brotli: false,
 limit: '128 KB',
 },
 {
 name: 'CDN Bundle (incl. Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.logs.metrics.min.js'),
 gzip: false,
 brotli: false,
 limit: '86 KB',
 },
 {
 name: 'CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed',
 path: createCDNPath('bundle.tracing.logs.metrics.min.js'),
Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,9 @@
 "test:bundle:replay:min": "PW_BUNDLE=bundle_replay_min yarn test",
 "test:bundle:tracing": "PW_BUNDLE=bundle_tracing yarn test",
 "test:bundle:tracing:min": "PW_BUNDLE=bundle_tracing_min yarn test",
 "test:bundle:logs_metrics": "PW_BUNDLE=bundle_logs_metrics yarn test",
 "test:bundle:logs_metrics:min": "PW_BUNDLE=bundle_logs_metrics_min yarn test",
 "test:bundle:logs_metrics:debug_min": "PW_BUNDLE=bundle_logs_metrics_debug_min yarn test",
 "test:bundle:tracing_logs_metrics": "PW_BUNDLE=bundle_tracing_logs_metrics yarn test",
 "test:bundle:tracing_logs_metrics:min": "PW_BUNDLE=bundle_tracing_logs_metrics_min yarn test",
 "test:bundle:tracing_logs_metrics:debug_min": "PW_BUNDLE=bundle_tracing_logs_metrics_debug_min yarn test",
Expand Down

6 changes: 4 additions & 2 deletions
dev-packages/browser-integration-tests/suites/public-api/metrics/simple/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,11 +5,13 @@ import {
 getFirstSentryEnvelopeRequest,
 properFullEnvelopeRequestParser,
 shouldSkipMetricsTest,
 shouldSkipTracingTest,
} from '../../../../utils/helpers';

sentryTest('should capture all metric types', async ({ getLocalTestUrl, page }) => {
 // Only run this for npm package exports and CDN bundles with metrics
 if (shouldSkipMetricsTest()) {
 // Only run this for npm package exports and CDN bundles with metrics and tracing
 // (the test uses Sentry.startSpan which requires tracing)
 if (shouldSkipMetricsTest() || shouldSkipTracingTest()) {
 sentryTest.skip();
 }

Expand Down

3 changes: 3 additions & 0 deletions
dev-packages/browser-integration-tests/utils/generatePlugin.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -56,6 +56,9 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
 bundle_replay_min: 'build/bundles/bundle.replay.min.js',
 bundle_tracing: 'build/bundles/bundle.tracing.js',
 bundle_tracing_min: 'build/bundles/bundle.tracing.min.js',
 bundle_logs_metrics: 'build/bundles/bundle.logs.metrics.js',
 bundle_logs_metrics_min: 'build/bundles/bundle.logs.metrics.min.js',
 bundle_logs_metrics_debug_min: 'build/bundles/bundle.logs.metrics.debug.min.js',
 bundle_tracing_logs_metrics: 'build/bundles/bundle.tracing.logs.metrics.js',
 bundle_tracing_logs_metrics_min: 'build/bundles/bundle.tracing.logs.metrics.min.js',
 bundle_tracing_logs_metrics_debug_min: 'build/bundles/bundle.tracing.logs.metrics.debug.min.js',
Expand Down

8 changes: 8 additions & 0 deletions
packages/browser/rollup.bundle.config.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,6 +104,13 @@ const tracingReplayFeedbackBaseBundleConfig = makeBaseBundleConfig({
 outputFileBase: () => 'bundles/bundle.tracing.replay.feedback',
});

const logsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.logs.metrics.ts'],
 licenseTitle: '@sentry/browser (Logs and Metrics)',
 outputFileBase: () => 'bundles/bundle.logs.metrics',
});

const tracingLogsMetricsBaseBundleConfig = makeBaseBundleConfig({
 bundleType: 'standalone',
 entrypoints: ['src/index.bundle.tracing.logs.metrics.ts'],
Expand All@@ -126,6 +133,7 @@ builds.push(
 ...makeBundleConfigVariants(tracingReplayBaseBundleConfig),
 ...makeBundleConfigVariants(replayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackBaseBundleConfig),
 ...makeBundleConfigVariants(logsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingLogsMetricsBaseBundleConfig),
 ...makeBundleConfigVariants(tracingReplayFeedbackLogsMetricsBaseBundleConfig),
);
Expand Down

17 changes: 17 additions & 0 deletions
packages/browser/src/index.bundle.logs.metrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
import {
 browserTracingIntegrationShim,
 feedbackIntegrationShim,
 replayIntegrationShim,
} from '@sentry-internal/integration-shims';

export * from './index.bundle.base';

// TODO(v11): Export metrics here once we remove it from the base bundle.
export { logger, consoleLoggingIntegration } from '@sentry/core';

export {
 browserTracingIntegrationShim as browserTracingIntegration,
 feedbackIntegrationShim as feedbackAsyncIntegration,
 feedbackIntegrationShim as feedbackIntegration,
 replayIntegrationShim as replayIntegration,
};

10 changes: 10 additions & 0 deletions
packages/browser/test/index.bundle.logs.metrics.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { logger as coreLogger, metrics as coreMetrics } from '@sentry/core';
import { describe, expect, it } from 'vitest';
import * as LogsMetricsBundle from '../src/index.bundle.logs.metrics';

describe('index.bundle.logs.metrics', () => {
 it('has correct exports', () => {
 expect(LogsMetricsBundle.logger).toBe(coreLogger);
 expect(LogsMetricsBundle.metrics).toBe(coreMetrics);
 });
});
@cursorcursorBotJan 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test is incomplete compared to existing patterns
Low Severity · Bugbot Rules
The unit test only verifies logger and metrics exports, but all other bundle tests (e.g., index.bundle.test.ts, index.bundle.tracing.test.ts, index.bundle.tracing.logs.metrics.test.ts) also verify that integration shims are correctly exported. This test is missing assertions for browserTracingIntegration, feedbackIntegration, feedbackAsyncIntegration, replayIntegration (all should be shims), and consoleLoggingIntegration (should be the real implementation). This violates the review rule to "check that tests actually test the newly added behaviour" - incomplete coverage could miss regressions where shims are accidentally replaced with real implementations.
Fix in CursorFix in Web
@chargomechargomeJan 28, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is simply not true.
Loading