fix(core): Ensure partially set SDK metadata options are preserved - #19102

Merged
Lms24 merged 6 commits into
developfrom
lms/fix-core-applySdkMetadata-partial-merge
Jan 30, 2026
Merged

fix(core): Ensure partially set SDK metadata options are preserved#19102
Lms24 merged 6 commits into
developfrom
lms/fix-core-applySdkMetadata-partial-merge

Conversation

@Lms24

@Lms24Lms24 commented Jan 30, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Previously, our applySdkMetadata helper in core would only apply default SDK metadata (name, packages, version) if no sdk data at all was set. This caused incomplete SDK metadata when manually overriding sdk.settings (see #19072).

This PR now ensures that only if the name is already set, we don't apply our default options. This should be fine-grained enough to still have correct SDK metadata inheritance. I also added a bunch of tests, since applySdkMetadata had no unit tests.

To be clear, I don't think we should promote controlling IP inference via SDK metadata. However, for now, it's the only way to control IP inference in a fine-grained manner, as opposed to setting sendDefaultPii. The long-term solution is a more fine grained Pii SDK option as we're already planning to do. I think that the metadata application now is more correct though, since this also allows other SDKs to override such settings should they need to.

closes#19072

@Lms24
Lms24 marked this pull request as ready for review January 30, 2026 09:51
@github-actions

github-actionsBot commented Jan 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

Generated by Codecov Action

@Lms24
Lms24 requested review from logaretm and s1gr1dJanuary 30, 2026 09:52
@github-actions

github-actionsBot commented Jan 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser25.41 kB+0.06%+13 B 🔺
@sentry/browser - with treeshaking flags23.87 kB+0.07%+15 B 🔺
@sentry/browser (incl. Tracing)42.22 kB+0.02%+8 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.86 kB+0.03%+10 B 🔺
@sentry/browser (incl. Tracing, Replay)80.84 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.45 kB+0.02%+13 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.55 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.74 kB+0.02%+12 B 🔺
@sentry/browser (incl. Feedback)42.13 kB+0.03%+11 B 🔺
@sentry/browser (incl. sendFeedback)30.09 kB+0.03%+7 B 🔺
@sentry/browser (incl. FeedbackAsync)35.09 kB+0.04%+12 B 🔺
@sentry/browser (incl. Metrics)26.51 kB+0.05%+12 B 🔺
@sentry/browser (incl. Logs)26.67 kB+0.04%+10 B 🔺
@sentry/browser (incl. Metrics & Logs)27.33 kB+0.05%+12 B 🔺
@sentry/react27.14 kB+0.05%+11 B 🔺
@sentry/react (incl. Tracing)44.46 kB+0.03%+9 B 🔺
@sentry/vue29.84 kB+0.05%+13 B 🔺
@sentry/vue (incl. Tracing)44.02 kB+0.03%+13 B 🔺
@sentry/svelte25.43 kB+0.06%+13 B 🔺
CDN Bundle27.95 kB+0.03%+8 B 🔺
CDN Bundle (incl. Tracing)42.99 kB+0.04%+13 B 🔺
CDN Bundle (incl. Logs, Metrics)28.79 kB+0.04%+10 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.81 kB+0.03%+12 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.74 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay)79.72 kB+0.02%+11 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.59 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.16 kB+0.01%+5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.09 kB+0.01%+4 B 🔺
CDN Bundle - uncompressed81.75 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.29 kB+0.02%+23 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.59 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.13 kB+0.02%+23 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.97 kB+0.02%+23 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.9 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.72 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.69 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.5 kB+0.01%+23 B 🔺
@sentry/nextjs (client)46.8 kB+0.02%+6 B 🔺
@sentry/sveltekit (client)42.59 kB+0.03%+11 B 🔺
@sentry/node-core52.15 kB+0.01%+5 B 🔺
@sentry/node166.16 kB+0.01%+6 B 🔺
@sentry/node - without tracing93.92 kB+0.02%+11 B 🔺
@sentry/aws-serverless109.44 kB+0.02%+11 B 🔺

View base workflow run

@Lms24Lms24 mentioned this pull request Jan 30, 2026
Closed
@github-actions

github-actionsBot commented Jan 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,302-8,842+5%
GET With Sentry1,71918%1,673+3%
GET With Sentry (error only)6,20567%5,638+10%
POST Baseline1,210-1,077+12%
POST With Sentry58949%527+12%
POST With Sentry (error only)1,07088%1,016+5%
MYSQL Baseline3,373-3,199+5%
MYSQL With Sentry45614%394+16%
MYSQL With Sentry (error only)2,76382%2,617+6%

View base workflow run

logaretm
logaretm reviewed Jan 30, 2026
View reviewed changes
Comment threadpackages/core/src/utils/sdkMetadata.ts Outdated
};
}

if (!metadata.sdk) {

@logaretmlogaretmJan 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something but isn't this doing the same check as line 20? if so metadata.sdk will always be set before it hits this line here, no?

https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/utils/sdkMetadata.ts#L20-L29

@Lms24Lms24Jan 30, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not sure why but I had a massive brain outage on this one: I added my new logic underneath the old one and forgot to delete the old one afterwards. 🤦

Found a way to make this all a bit more concise. Might even save us some bytes. 🤞 Thanks for calling this out!

@Lms24Lms24 self-assigned this Jan 30, 2026
logaretm
logaretm approved these changes Jan 30, 2026
View reviewed changes

@logaretmlogaretm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fridays be like that, nice one!

@Lms24
Lms24 enabled auto-merge (squash) January 30, 2026 17:54
@Lms24
Lms24 merged commit c104764 into developJan 30, 2026
421 of 424 checks passed
@Lms24
Lms24 deleted the lms/fix-core-applySdkMetadata-partial-merge branch January 30, 2026 18:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@logaretmlogaretmlogaretm approved these changes
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@Lms24Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow enabling infer_ip without enabling all default PII

2 participants

@Lms24@logaretm
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(core): Ensure partially set SDK metadata options are preserved - #19102
Merged
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Jan 30, 2026
Merged
fix(core): Ensure partially set SDK metadata options are preserved#19102
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Conversation
@Lms24
@Lms24Lms24
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Previously, our applySdkMetadata helper in core would only apply default SDK metadata (name, packages, version) if no sdk data at all was set. This caused incomplete SDK metadata when manually overriding sdk.settings (see #19072).
This PR now ensures that only if the name is already set, we don't apply our default options. This should be fine-grained enough to still have correct SDK metadata inheritance. I also added a bunch of tests, since applySdkMetadata had no unit tests.
To be clear, I don't think we should promote controlling IP inference via SDK metadata. However, for now, it's the only way to control IP inference in a fine-grained manner, as opposed to setting sendDefaultPii. The long-term solution is a more fine grained Pii SDK option as we're already planning to do. I think that the metadata application now is more correct though, since this also allows other SDKs to override such settings should they need to.
closes#19072
@Lms24
Lms24
marked this pull request as ready for review
January 30, 2026 09:51
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Codecov Results 📊
Generated by Codecov Action
@Lms24
Lms24
requested review from
logaretm and s1gr1dJanuary 30, 2026 09:52
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser25.41 kB+0.06%+13 B 🔺
@sentry/browser - with treeshaking flags23.87 kB+0.07%+15 B 🔺
@sentry/browser (incl. Tracing)42.22 kB+0.02%+8 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.86 kB+0.03%+10 B 🔺
@sentry/browser (incl. Tracing, Replay)80.84 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.45 kB+0.02%+13 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.55 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.74 kB+0.02%+12 B 🔺
@sentry/browser (incl. Feedback)42.13 kB+0.03%+11 B 🔺
@sentry/browser (incl. sendFeedback)30.09 kB+0.03%+7 B 🔺
@sentry/browser (incl. FeedbackAsync)35.09 kB+0.04%+12 B 🔺
@sentry/browser (incl. Metrics)26.51 kB+0.05%+12 B 🔺
@sentry/browser (incl. Logs)26.67 kB+0.04%+10 B 🔺
@sentry/browser (incl. Metrics & Logs)27.33 kB+0.05%+12 B 🔺
@sentry/react27.14 kB+0.05%+11 B 🔺
@sentry/react (incl. Tracing)44.46 kB+0.03%+9 B 🔺
@sentry/vue29.84 kB+0.05%+13 B 🔺
@sentry/vue (incl. Tracing)44.02 kB+0.03%+13 B 🔺
@sentry/svelte25.43 kB+0.06%+13 B 🔺
CDN Bundle27.95 kB+0.03%+8 B 🔺
CDN Bundle (incl. Tracing)42.99 kB+0.04%+13 B 🔺
CDN Bundle (incl. Logs, Metrics)28.79 kB+0.04%+10 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.81 kB+0.03%+12 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.74 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay)79.72 kB+0.02%+11 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.59 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.16 kB+0.01%+5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.09 kB+0.01%+4 B 🔺
CDN Bundle - uncompressed81.75 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.29 kB+0.02%+23 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.59 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.13 kB+0.02%+23 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.97 kB+0.02%+23 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.9 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.72 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.69 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.5 kB+0.01%+23 B 🔺
@sentry/nextjs (client)46.8 kB+0.02%+6 B 🔺
@sentry/sveltekit (client)42.59 kB+0.03%+11 B 🔺
@sentry/node-core52.15 kB+0.01%+5 B 🔺
@sentry/node166.16 kB+0.01%+6 B 🔺
@sentry/node - without tracing93.92 kB+0.02%+11 B 🔺
@sentry/aws-serverless109.44 kB+0.02%+11 B 🔺
View base workflow run
@Lms24Lms24
mentioned this pull request
Jan 30, 2026

Closed

@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,302-8,842+5%
GET With Sentry1,71918%1,673+3%
GET With Sentry (error only)6,20567%5,638+10%
POST Baseline1,210-1,077+12%
POST With Sentry58949%527+12%
POST With Sentry (error only)1,07088%1,016+5%
MYSQL Baseline3,373-3,199+5%
MYSQL With Sentry45614%394+16%
MYSQL With Sentry (error only)2,76382%2,617+6%
View base workflow run
logaretm
logaretm
reviewed
Jan 30, 2026
View reviewed changes
Comment threadpackages/core/src/utils/sdkMetadata.ts
Outdated

 };
 }

 if (!metadata.sdk) {
@logaretmlogaretmJan 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something but isn't this doing the same check as line 20? if so metadata.sdk will always be set before it hits this line here, no?
https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/utils/sdkMetadata.ts#L20-L29
@Lms24Lms24Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not sure why but I had a massive brain outage on this one: I added my new logic underneath the old one and forgot to delete the old one afterwards. 🤦
Found a way to make this all a bit more concise. Might even save us some bytes. 🤞 Thanks for calling this out!
@Lms24Lms24
self-assigned this
Jan 30, 2026
logaretm
logaretm
approved these changes
Jan 30, 2026
View reviewed changes
@logaretmlogaretm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fridays be like that, nice one!
@Lms24
Lms24
enabled auto-merge (squash)
January 30, 2026 17:54
@Lms24
Lms24
merged commit c104764
into
developJan 30, 2026

421 of 424 checks passed

@Lms24
Lms24
deleted the

lms/fix-core-applySdkMetadata-partial-merge

branch
January 30, 2026 18:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@logaretmlogaretmlogaretm approved these changes
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@Lms24Lms24

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow enabling infer_ip without enabling all default PII


2 participants

@Lms24@logaretm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Ensure partially set SDK metadata options are preserved - #19102
Merged
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Jan 30, 2026
Merged
fix(core): Ensure partially set SDK metadata options are preserved#19102
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Conversation
@Lms24
@Lms24Lms24
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Previously, our applySdkMetadata helper in core would only apply default SDK metadata (name, packages, version) if no sdk data at all was set. This caused incomplete SDK metadata when manually overriding sdk.settings (see #19072).
This PR now ensures that only if the name is already set, we don't apply our default options. This should be fine-grained enough to still have correct SDK metadata inheritance. I also added a bunch of tests, since applySdkMetadata had no unit tests.
To be clear, I don't think we should promote controlling IP inference via SDK metadata. However, for now, it's the only way to control IP inference in a fine-grained manner, as opposed to setting sendDefaultPii. The long-term solution is a more fine grained Pii SDK option as we're already planning to do. I think that the metadata application now is more correct though, since this also allows other SDKs to override such settings should they need to.
closes#19072
@Lms24
Lms24
marked this pull request as ready for review
January 30, 2026 09:51
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Codecov Results 📊
Generated by Codecov Action
@Lms24
Lms24
requested review from
logaretm and s1gr1dJanuary 30, 2026 09:52
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser25.41 kB+0.06%+13 B 🔺
@sentry/browser - with treeshaking flags23.87 kB+0.07%+15 B 🔺
@sentry/browser (incl. Tracing)42.22 kB+0.02%+8 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.86 kB+0.03%+10 B 🔺
@sentry/browser (incl. Tracing, Replay)80.84 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.45 kB+0.02%+13 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.55 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.74 kB+0.02%+12 B 🔺
@sentry/browser (incl. Feedback)42.13 kB+0.03%+11 B 🔺
@sentry/browser (incl. sendFeedback)30.09 kB+0.03%+7 B 🔺
@sentry/browser (incl. FeedbackAsync)35.09 kB+0.04%+12 B 🔺
@sentry/browser (incl. Metrics)26.51 kB+0.05%+12 B 🔺
@sentry/browser (incl. Logs)26.67 kB+0.04%+10 B 🔺
@sentry/browser (incl. Metrics & Logs)27.33 kB+0.05%+12 B 🔺
@sentry/react27.14 kB+0.05%+11 B 🔺
@sentry/react (incl. Tracing)44.46 kB+0.03%+9 B 🔺
@sentry/vue29.84 kB+0.05%+13 B 🔺
@sentry/vue (incl. Tracing)44.02 kB+0.03%+13 B 🔺
@sentry/svelte25.43 kB+0.06%+13 B 🔺
CDN Bundle27.95 kB+0.03%+8 B 🔺
CDN Bundle (incl. Tracing)42.99 kB+0.04%+13 B 🔺
CDN Bundle (incl. Logs, Metrics)28.79 kB+0.04%+10 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.81 kB+0.03%+12 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.74 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay)79.72 kB+0.02%+11 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.59 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.16 kB+0.01%+5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.09 kB+0.01%+4 B 🔺
CDN Bundle - uncompressed81.75 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.29 kB+0.02%+23 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.59 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.13 kB+0.02%+23 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.97 kB+0.02%+23 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.9 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.72 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.69 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.5 kB+0.01%+23 B 🔺
@sentry/nextjs (client)46.8 kB+0.02%+6 B 🔺
@sentry/sveltekit (client)42.59 kB+0.03%+11 B 🔺
@sentry/node-core52.15 kB+0.01%+5 B 🔺
@sentry/node166.16 kB+0.01%+6 B 🔺
@sentry/node - without tracing93.92 kB+0.02%+11 B 🔺
@sentry/aws-serverless109.44 kB+0.02%+11 B 🔺
View base workflow run
@Lms24Lms24
mentioned this pull request
Jan 30, 2026

Closed

@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,302-8,842+5%
GET With Sentry1,71918%1,673+3%
GET With Sentry (error only)6,20567%5,638+10%
POST Baseline1,210-1,077+12%
POST With Sentry58949%527+12%
POST With Sentry (error only)1,07088%1,016+5%
MYSQL Baseline3,373-3,199+5%
MYSQL With Sentry45614%394+16%
MYSQL With Sentry (error only)2,76382%2,617+6%
View base workflow run
logaretm
logaretm
reviewed
Jan 30, 2026
View reviewed changes
Comment threadpackages/core/src/utils/sdkMetadata.ts
Outdated

 };
 }

 if (!metadata.sdk) {
@logaretmlogaretmJan 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something but isn't this doing the same check as line 20? if so metadata.sdk will always be set before it hits this line here, no?
https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/utils/sdkMetadata.ts#L20-L29
@Lms24Lms24Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not sure why but I had a massive brain outage on this one: I added my new logic underneath the old one and forgot to delete the old one afterwards. 🤦
Found a way to make this all a bit more concise. Might even save us some bytes. 🤞 Thanks for calling this out!
@Lms24Lms24
self-assigned this
Jan 30, 2026
logaretm
logaretm
approved these changes
Jan 30, 2026
View reviewed changes
@logaretmlogaretm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fridays be like that, nice one!
@Lms24
Lms24
enabled auto-merge (squash)
January 30, 2026 17:54
@Lms24
Lms24
merged commit c104764
into
developJan 30, 2026

421 of 424 checks passed

@Lms24
Lms24
deleted the

lms/fix-core-applySdkMetadata-partial-merge

branch
January 30, 2026 18:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@logaretmlogaretmlogaretm approved these changes
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@Lms24Lms24

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow enabling infer_ip without enabling all default PII


2 participants

@Lms24@logaretm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Ensure partially set SDK metadata options are preserved - #19102
Merged
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Jan 30, 2026
Merged
fix(core): Ensure partially set SDK metadata options are preserved#19102
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Conversation
@Lms24
@Lms24Lms24
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Previously, our applySdkMetadata helper in core would only apply default SDK metadata (name, packages, version) if no sdk data at all was set. This caused incomplete SDK metadata when manually overriding sdk.settings (see #19072).
This PR now ensures that only if the name is already set, we don't apply our default options. This should be fine-grained enough to still have correct SDK metadata inheritance. I also added a bunch of tests, since applySdkMetadata had no unit tests.
To be clear, I don't think we should promote controlling IP inference via SDK metadata. However, for now, it's the only way to control IP inference in a fine-grained manner, as opposed to setting sendDefaultPii. The long-term solution is a more fine grained Pii SDK option as we're already planning to do. I think that the metadata application now is more correct though, since this also allows other SDKs to override such settings should they need to.
closes#19072
@Lms24
Lms24
marked this pull request as ready for review
January 30, 2026 09:51
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Codecov Results 📊
Generated by Codecov Action
@Lms24
Lms24
requested review from
logaretm and s1gr1dJanuary 30, 2026 09:52
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser25.41 kB+0.06%+13 B 🔺
@sentry/browser - with treeshaking flags23.87 kB+0.07%+15 B 🔺
@sentry/browser (incl. Tracing)42.22 kB+0.02%+8 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.86 kB+0.03%+10 B 🔺
@sentry/browser (incl. Tracing, Replay)80.84 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.45 kB+0.02%+13 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.55 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.74 kB+0.02%+12 B 🔺
@sentry/browser (incl. Feedback)42.13 kB+0.03%+11 B 🔺
@sentry/browser (incl. sendFeedback)30.09 kB+0.03%+7 B 🔺
@sentry/browser (incl. FeedbackAsync)35.09 kB+0.04%+12 B 🔺
@sentry/browser (incl. Metrics)26.51 kB+0.05%+12 B 🔺
@sentry/browser (incl. Logs)26.67 kB+0.04%+10 B 🔺
@sentry/browser (incl. Metrics & Logs)27.33 kB+0.05%+12 B 🔺
@sentry/react27.14 kB+0.05%+11 B 🔺
@sentry/react (incl. Tracing)44.46 kB+0.03%+9 B 🔺
@sentry/vue29.84 kB+0.05%+13 B 🔺
@sentry/vue (incl. Tracing)44.02 kB+0.03%+13 B 🔺
@sentry/svelte25.43 kB+0.06%+13 B 🔺
CDN Bundle27.95 kB+0.03%+8 B 🔺
CDN Bundle (incl. Tracing)42.99 kB+0.04%+13 B 🔺
CDN Bundle (incl. Logs, Metrics)28.79 kB+0.04%+10 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.81 kB+0.03%+12 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.74 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay)79.72 kB+0.02%+11 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.59 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.16 kB+0.01%+5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.09 kB+0.01%+4 B 🔺
CDN Bundle - uncompressed81.75 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.29 kB+0.02%+23 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.59 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.13 kB+0.02%+23 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.97 kB+0.02%+23 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.9 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.72 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.69 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.5 kB+0.01%+23 B 🔺
@sentry/nextjs (client)46.8 kB+0.02%+6 B 🔺
@sentry/sveltekit (client)42.59 kB+0.03%+11 B 🔺
@sentry/node-core52.15 kB+0.01%+5 B 🔺
@sentry/node166.16 kB+0.01%+6 B 🔺
@sentry/node - without tracing93.92 kB+0.02%+11 B 🔺
@sentry/aws-serverless109.44 kB+0.02%+11 B 🔺
View base workflow run
@Lms24Lms24
mentioned this pull request
Jan 30, 2026

Closed

@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,302-8,842+5%
GET With Sentry1,71918%1,673+3%
GET With Sentry (error only)6,20567%5,638+10%
POST Baseline1,210-1,077+12%
POST With Sentry58949%527+12%
POST With Sentry (error only)1,07088%1,016+5%
MYSQL Baseline3,373-3,199+5%
MYSQL With Sentry45614%394+16%
MYSQL With Sentry (error only)2,76382%2,617+6%
View base workflow run
logaretm
logaretm
reviewed
Jan 30, 2026
View reviewed changes
Comment threadpackages/core/src/utils/sdkMetadata.ts
Outdated

 };
 }

 if (!metadata.sdk) {
@logaretmlogaretmJan 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something but isn't this doing the same check as line 20? if so metadata.sdk will always be set before it hits this line here, no?
https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/utils/sdkMetadata.ts#L20-L29
@Lms24Lms24Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not sure why but I had a massive brain outage on this one: I added my new logic underneath the old one and forgot to delete the old one afterwards. 🤦
Found a way to make this all a bit more concise. Might even save us some bytes. 🤞 Thanks for calling this out!
@Lms24Lms24
self-assigned this
Jan 30, 2026
logaretm
logaretm
approved these changes
Jan 30, 2026
View reviewed changes
@logaretmlogaretm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fridays be like that, nice one!
@Lms24
Lms24
enabled auto-merge (squash)
January 30, 2026 17:54
@Lms24
Lms24
merged commit c104764
into
developJan 30, 2026

421 of 424 checks passed

@Lms24
Lms24
deleted the

lms/fix-core-applySdkMetadata-partial-merge

branch
January 30, 2026 18:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@logaretmlogaretmlogaretm approved these changes
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@Lms24Lms24

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow enabling infer_ip without enabling all default PII


2 participants

@Lms24@logaretm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(core): Ensure partially set SDK metadata options are preserved - #19102
Merged
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Jan 30, 2026
Merged
fix(core): Ensure partially set SDK metadata options are preserved#19102
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Conversation
@Lms24
@Lms24Lms24
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Previously, our applySdkMetadata helper in core would only apply default SDK metadata (name, packages, version) if no sdk data at all was set. This caused incomplete SDK metadata when manually overriding sdk.settings (see #19072).
This PR now ensures that only if the name is already set, we don't apply our default options. This should be fine-grained enough to still have correct SDK metadata inheritance. I also added a bunch of tests, since applySdkMetadata had no unit tests.
To be clear, I don't think we should promote controlling IP inference via SDK metadata. However, for now, it's the only way to control IP inference in a fine-grained manner, as opposed to setting sendDefaultPii. The long-term solution is a more fine grained Pii SDK option as we're already planning to do. I think that the metadata application now is more correct though, since this also allows other SDKs to override such settings should they need to.
closes#19072
@Lms24
Lms24
marked this pull request as ready for review
January 30, 2026 09:51
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Codecov Results 📊
Generated by Codecov Action
@Lms24
Lms24
requested review from
logaretm and s1gr1dJanuary 30, 2026 09:52
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser25.41 kB+0.06%+13 B 🔺
@sentry/browser - with treeshaking flags23.87 kB+0.07%+15 B 🔺
@sentry/browser (incl. Tracing)42.22 kB+0.02%+8 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.86 kB+0.03%+10 B 🔺
@sentry/browser (incl. Tracing, Replay)80.84 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.45 kB+0.02%+13 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.55 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.74 kB+0.02%+12 B 🔺
@sentry/browser (incl. Feedback)42.13 kB+0.03%+11 B 🔺
@sentry/browser (incl. sendFeedback)30.09 kB+0.03%+7 B 🔺
@sentry/browser (incl. FeedbackAsync)35.09 kB+0.04%+12 B 🔺
@sentry/browser (incl. Metrics)26.51 kB+0.05%+12 B 🔺
@sentry/browser (incl. Logs)26.67 kB+0.04%+10 B 🔺
@sentry/browser (incl. Metrics & Logs)27.33 kB+0.05%+12 B 🔺
@sentry/react27.14 kB+0.05%+11 B 🔺
@sentry/react (incl. Tracing)44.46 kB+0.03%+9 B 🔺
@sentry/vue29.84 kB+0.05%+13 B 🔺
@sentry/vue (incl. Tracing)44.02 kB+0.03%+13 B 🔺
@sentry/svelte25.43 kB+0.06%+13 B 🔺
CDN Bundle27.95 kB+0.03%+8 B 🔺
CDN Bundle (incl. Tracing)42.99 kB+0.04%+13 B 🔺
CDN Bundle (incl. Logs, Metrics)28.79 kB+0.04%+10 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.81 kB+0.03%+12 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.74 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay)79.72 kB+0.02%+11 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.59 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.16 kB+0.01%+5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.09 kB+0.01%+4 B 🔺
CDN Bundle - uncompressed81.75 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.29 kB+0.02%+23 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.59 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.13 kB+0.02%+23 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.97 kB+0.02%+23 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.9 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.72 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.69 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.5 kB+0.01%+23 B 🔺
@sentry/nextjs (client)46.8 kB+0.02%+6 B 🔺
@sentry/sveltekit (client)42.59 kB+0.03%+11 B 🔺
@sentry/node-core52.15 kB+0.01%+5 B 🔺
@sentry/node166.16 kB+0.01%+6 B 🔺
@sentry/node - without tracing93.92 kB+0.02%+11 B 🔺
@sentry/aws-serverless109.44 kB+0.02%+11 B 🔺
View base workflow run
@Lms24Lms24
mentioned this pull request
Jan 30, 2026

Closed

@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,302-8,842+5%
GET With Sentry1,71918%1,673+3%
GET With Sentry (error only)6,20567%5,638+10%
POST Baseline1,210-1,077+12%
POST With Sentry58949%527+12%
POST With Sentry (error only)1,07088%1,016+5%
MYSQL Baseline3,373-3,199+5%
MYSQL With Sentry45614%394+16%
MYSQL With Sentry (error only)2,76382%2,617+6%
View base workflow run
logaretm
logaretm
reviewed
Jan 30, 2026
View reviewed changes
Comment threadpackages/core/src/utils/sdkMetadata.ts
Outdated

 };
 }

 if (!metadata.sdk) {
@logaretmlogaretmJan 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something but isn't this doing the same check as line 20? if so metadata.sdk will always be set before it hits this line here, no?
https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/utils/sdkMetadata.ts#L20-L29
@Lms24Lms24Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not sure why but I had a massive brain outage on this one: I added my new logic underneath the old one and forgot to delete the old one afterwards. 🤦
Found a way to make this all a bit more concise. Might even save us some bytes. 🤞 Thanks for calling this out!
@Lms24Lms24
self-assigned this
Jan 30, 2026
logaretm
logaretm
approved these changes
Jan 30, 2026
View reviewed changes
@logaretmlogaretm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fridays be like that, nice one!
@Lms24
Lms24
enabled auto-merge (squash)
January 30, 2026 17:54
@Lms24
Lms24
merged commit c104764
into
developJan 30, 2026

421 of 424 checks passed

@Lms24
Lms24
deleted the

lms/fix-core-applySdkMetadata-partial-merge

branch
January 30, 2026 18:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@logaretmlogaretmlogaretm approved these changes
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@Lms24Lms24

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow enabling infer_ip without enabling all default PII


2 participants

@Lms24@logaretm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Ensure partially set SDK metadata options are preserved - #19102
Merged
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Jan 30, 2026
Merged
fix(core): Ensure partially set SDK metadata options are preserved#19102
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Conversation
@Lms24
@Lms24Lms24
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Previously, our applySdkMetadata helper in core would only apply default SDK metadata (name, packages, version) if no sdk data at all was set. This caused incomplete SDK metadata when manually overriding sdk.settings (see #19072).
This PR now ensures that only if the name is already set, we don't apply our default options. This should be fine-grained enough to still have correct SDK metadata inheritance. I also added a bunch of tests, since applySdkMetadata had no unit tests.
To be clear, I don't think we should promote controlling IP inference via SDK metadata. However, for now, it's the only way to control IP inference in a fine-grained manner, as opposed to setting sendDefaultPii. The long-term solution is a more fine grained Pii SDK option as we're already planning to do. I think that the metadata application now is more correct though, since this also allows other SDKs to override such settings should they need to.
closes#19072
@Lms24
Lms24
marked this pull request as ready for review
January 30, 2026 09:51
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Codecov Results 📊
Generated by Codecov Action
@Lms24
Lms24
requested review from
logaretm and s1gr1dJanuary 30, 2026 09:52
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser25.41 kB+0.06%+13 B 🔺
@sentry/browser - with treeshaking flags23.87 kB+0.07%+15 B 🔺
@sentry/browser (incl. Tracing)42.22 kB+0.02%+8 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.86 kB+0.03%+10 B 🔺
@sentry/browser (incl. Tracing, Replay)80.84 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.45 kB+0.02%+13 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.55 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.74 kB+0.02%+12 B 🔺
@sentry/browser (incl. Feedback)42.13 kB+0.03%+11 B 🔺
@sentry/browser (incl. sendFeedback)30.09 kB+0.03%+7 B 🔺
@sentry/browser (incl. FeedbackAsync)35.09 kB+0.04%+12 B 🔺
@sentry/browser (incl. Metrics)26.51 kB+0.05%+12 B 🔺
@sentry/browser (incl. Logs)26.67 kB+0.04%+10 B 🔺
@sentry/browser (incl. Metrics & Logs)27.33 kB+0.05%+12 B 🔺
@sentry/react27.14 kB+0.05%+11 B 🔺
@sentry/react (incl. Tracing)44.46 kB+0.03%+9 B 🔺
@sentry/vue29.84 kB+0.05%+13 B 🔺
@sentry/vue (incl. Tracing)44.02 kB+0.03%+13 B 🔺
@sentry/svelte25.43 kB+0.06%+13 B 🔺
CDN Bundle27.95 kB+0.03%+8 B 🔺
CDN Bundle (incl. Tracing)42.99 kB+0.04%+13 B 🔺
CDN Bundle (incl. Logs, Metrics)28.79 kB+0.04%+10 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.81 kB+0.03%+12 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.74 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay)79.72 kB+0.02%+11 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.59 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.16 kB+0.01%+5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.09 kB+0.01%+4 B 🔺
CDN Bundle - uncompressed81.75 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.29 kB+0.02%+23 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.59 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.13 kB+0.02%+23 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.97 kB+0.02%+23 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.9 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.72 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.69 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.5 kB+0.01%+23 B 🔺
@sentry/nextjs (client)46.8 kB+0.02%+6 B 🔺
@sentry/sveltekit (client)42.59 kB+0.03%+11 B 🔺
@sentry/node-core52.15 kB+0.01%+5 B 🔺
@sentry/node166.16 kB+0.01%+6 B 🔺
@sentry/node - without tracing93.92 kB+0.02%+11 B 🔺
@sentry/aws-serverless109.44 kB+0.02%+11 B 🔺
View base workflow run
@Lms24Lms24
mentioned this pull request
Jan 30, 2026

Closed

@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,302-8,842+5%
GET With Sentry1,71918%1,673+3%
GET With Sentry (error only)6,20567%5,638+10%
POST Baseline1,210-1,077+12%
POST With Sentry58949%527+12%
POST With Sentry (error only)1,07088%1,016+5%
MYSQL Baseline3,373-3,199+5%
MYSQL With Sentry45614%394+16%
MYSQL With Sentry (error only)2,76382%2,617+6%
View base workflow run
logaretm
logaretm
reviewed
Jan 30, 2026
View reviewed changes
Comment threadpackages/core/src/utils/sdkMetadata.ts
Outdated

 };
 }

 if (!metadata.sdk) {
@logaretmlogaretmJan 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something but isn't this doing the same check as line 20? if so metadata.sdk will always be set before it hits this line here, no?
https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/utils/sdkMetadata.ts#L20-L29
@Lms24Lms24Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not sure why but I had a massive brain outage on this one: I added my new logic underneath the old one and forgot to delete the old one afterwards. 🤦
Found a way to make this all a bit more concise. Might even save us some bytes. 🤞 Thanks for calling this out!
@Lms24Lms24
self-assigned this
Jan 30, 2026
logaretm
logaretm
approved these changes
Jan 30, 2026
View reviewed changes
@logaretmlogaretm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fridays be like that, nice one!
@Lms24
Lms24
enabled auto-merge (squash)
January 30, 2026 17:54
@Lms24
Lms24
merged commit c104764
into
developJan 30, 2026

421 of 424 checks passed

@Lms24
Lms24
deleted the

lms/fix-core-applySdkMetadata-partial-merge

branch
January 30, 2026 18:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@logaretmlogaretmlogaretm approved these changes
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@Lms24Lms24

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow enabling infer_ip without enabling all default PII


2 participants

@Lms24@logaretm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Ensure partially set SDK metadata options are preserved - #19102
Merged
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Jan 30, 2026
Merged
fix(core): Ensure partially set SDK metadata options are preserved#19102
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Conversation
@Lms24
@Lms24Lms24
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Previously, our applySdkMetadata helper in core would only apply default SDK metadata (name, packages, version) if no sdk data at all was set. This caused incomplete SDK metadata when manually overriding sdk.settings (see #19072).
This PR now ensures that only if the name is already set, we don't apply our default options. This should be fine-grained enough to still have correct SDK metadata inheritance. I also added a bunch of tests, since applySdkMetadata had no unit tests.
To be clear, I don't think we should promote controlling IP inference via SDK metadata. However, for now, it's the only way to control IP inference in a fine-grained manner, as opposed to setting sendDefaultPii. The long-term solution is a more fine grained Pii SDK option as we're already planning to do. I think that the metadata application now is more correct though, since this also allows other SDKs to override such settings should they need to.
closes#19072
@Lms24
Lms24
marked this pull request as ready for review
January 30, 2026 09:51
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Codecov Results 📊
Generated by Codecov Action
@Lms24
Lms24
requested review from
logaretm and s1gr1dJanuary 30, 2026 09:52
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser25.41 kB+0.06%+13 B 🔺
@sentry/browser - with treeshaking flags23.87 kB+0.07%+15 B 🔺
@sentry/browser (incl. Tracing)42.22 kB+0.02%+8 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.86 kB+0.03%+10 B 🔺
@sentry/browser (incl. Tracing, Replay)80.84 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.45 kB+0.02%+13 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.55 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.74 kB+0.02%+12 B 🔺
@sentry/browser (incl. Feedback)42.13 kB+0.03%+11 B 🔺
@sentry/browser (incl. sendFeedback)30.09 kB+0.03%+7 B 🔺
@sentry/browser (incl. FeedbackAsync)35.09 kB+0.04%+12 B 🔺
@sentry/browser (incl. Metrics)26.51 kB+0.05%+12 B 🔺
@sentry/browser (incl. Logs)26.67 kB+0.04%+10 B 🔺
@sentry/browser (incl. Metrics & Logs)27.33 kB+0.05%+12 B 🔺
@sentry/react27.14 kB+0.05%+11 B 🔺
@sentry/react (incl. Tracing)44.46 kB+0.03%+9 B 🔺
@sentry/vue29.84 kB+0.05%+13 B 🔺
@sentry/vue (incl. Tracing)44.02 kB+0.03%+13 B 🔺
@sentry/svelte25.43 kB+0.06%+13 B 🔺
CDN Bundle27.95 kB+0.03%+8 B 🔺
CDN Bundle (incl. Tracing)42.99 kB+0.04%+13 B 🔺
CDN Bundle (incl. Logs, Metrics)28.79 kB+0.04%+10 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.81 kB+0.03%+12 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.74 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay)79.72 kB+0.02%+11 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.59 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.16 kB+0.01%+5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.09 kB+0.01%+4 B 🔺
CDN Bundle - uncompressed81.75 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.29 kB+0.02%+23 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.59 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.13 kB+0.02%+23 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.97 kB+0.02%+23 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.9 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.72 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.69 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.5 kB+0.01%+23 B 🔺
@sentry/nextjs (client)46.8 kB+0.02%+6 B 🔺
@sentry/sveltekit (client)42.59 kB+0.03%+11 B 🔺
@sentry/node-core52.15 kB+0.01%+5 B 🔺
@sentry/node166.16 kB+0.01%+6 B 🔺
@sentry/node - without tracing93.92 kB+0.02%+11 B 🔺
@sentry/aws-serverless109.44 kB+0.02%+11 B 🔺
View base workflow run
@Lms24Lms24
mentioned this pull request
Jan 30, 2026

Closed

@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,302-8,842+5%
GET With Sentry1,71918%1,673+3%
GET With Sentry (error only)6,20567%5,638+10%
POST Baseline1,210-1,077+12%
POST With Sentry58949%527+12%
POST With Sentry (error only)1,07088%1,016+5%
MYSQL Baseline3,373-3,199+5%
MYSQL With Sentry45614%394+16%
MYSQL With Sentry (error only)2,76382%2,617+6%
View base workflow run
logaretm
logaretm
reviewed
Jan 30, 2026
View reviewed changes
Comment threadpackages/core/src/utils/sdkMetadata.ts
Outdated

 };
 }

 if (!metadata.sdk) {
@logaretmlogaretmJan 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something but isn't this doing the same check as line 20? if so metadata.sdk will always be set before it hits this line here, no?
https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/utils/sdkMetadata.ts#L20-L29
@Lms24Lms24Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not sure why but I had a massive brain outage on this one: I added my new logic underneath the old one and forgot to delete the old one afterwards. 🤦
Found a way to make this all a bit more concise. Might even save us some bytes. 🤞 Thanks for calling this out!
@Lms24Lms24
self-assigned this
Jan 30, 2026
logaretm
logaretm
approved these changes
Jan 30, 2026
View reviewed changes
@logaretmlogaretm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fridays be like that, nice one!
@Lms24
Lms24
enabled auto-merge (squash)
January 30, 2026 17:54
@Lms24
Lms24
merged commit c104764
into
developJan 30, 2026

421 of 424 checks passed

@Lms24
Lms24
deleted the

lms/fix-core-applySdkMetadata-partial-merge

branch
January 30, 2026 18:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@logaretmlogaretmlogaretm approved these changes
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@Lms24Lms24

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow enabling infer_ip without enabling all default PII


2 participants

@Lms24@logaretm

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(core): Ensure partially set SDK metadata options are preserved - #19102
Merged
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Jan 30, 2026
Merged
fix(core): Ensure partially set SDK metadata options are preserved#19102
Lms24 merged 6 commits into
developfrom 
lms/fix-core-applySdkMetadata-partial-merge
Conversation
@Lms24
@Lms24Lms24
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Previously, our applySdkMetadata helper in core would only apply default SDK metadata (name, packages, version) if no sdk data at all was set. This caused incomplete SDK metadata when manually overriding sdk.settings (see #19072).
This PR now ensures that only if the name is already set, we don't apply our default options. This should be fine-grained enough to still have correct SDK metadata inheritance. I also added a bunch of tests, since applySdkMetadata had no unit tests.
To be clear, I don't think we should promote controlling IP inference via SDK metadata. However, for now, it's the only way to control IP inference in a fine-grained manner, as opposed to setting sendDefaultPii. The long-term solution is a more fine grained Pii SDK option as we're already planning to do. I think that the metadata application now is more correct though, since this also allows other SDKs to override such settings should they need to.
closes#19072
@Lms24
Lms24
marked this pull request as ready for review
January 30, 2026 09:51
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Codecov Results 📊
Generated by Codecov Action
@Lms24
Lms24
requested review from
logaretm and s1gr1dJanuary 30, 2026 09:52
@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser25.41 kB+0.06%+13 B 🔺
@sentry/browser - with treeshaking flags23.87 kB+0.07%+15 B 🔺
@sentry/browser (incl. Tracing)42.22 kB+0.02%+8 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.86 kB+0.03%+10 B 🔺
@sentry/browser (incl. Tracing, Replay)80.84 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.45 kB+0.02%+13 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.55 kB+0.02%+11 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.74 kB+0.02%+12 B 🔺
@sentry/browser (incl. Feedback)42.13 kB+0.03%+11 B 🔺
@sentry/browser (incl. sendFeedback)30.09 kB+0.03%+7 B 🔺
@sentry/browser (incl. FeedbackAsync)35.09 kB+0.04%+12 B 🔺
@sentry/browser (incl. Metrics)26.51 kB+0.05%+12 B 🔺
@sentry/browser (incl. Logs)26.67 kB+0.04%+10 B 🔺
@sentry/browser (incl. Metrics & Logs)27.33 kB+0.05%+12 B 🔺
@sentry/react27.14 kB+0.05%+11 B 🔺
@sentry/react (incl. Tracing)44.46 kB+0.03%+9 B 🔺
@sentry/vue29.84 kB+0.05%+13 B 🔺
@sentry/vue (incl. Tracing)44.02 kB+0.03%+13 B 🔺
@sentry/svelte25.43 kB+0.06%+13 B 🔺
CDN Bundle27.95 kB+0.03%+8 B 🔺
CDN Bundle (incl. Tracing)42.99 kB+0.04%+13 B 🔺
CDN Bundle (incl. Logs, Metrics)28.79 kB+0.04%+10 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.81 kB+0.03%+12 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.74 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay)79.72 kB+0.02%+11 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.59 kB+0.02%+12 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.16 kB+0.01%+5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.09 kB+0.01%+4 B 🔺
CDN Bundle - uncompressed81.75 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.29 kB+0.02%+23 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.59 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.13 kB+0.02%+23 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.97 kB+0.02%+23 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.9 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.72 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.69 kB+0.01%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.5 kB+0.01%+23 B 🔺
@sentry/nextjs (client)46.8 kB+0.02%+6 B 🔺
@sentry/sveltekit (client)42.59 kB+0.03%+11 B 🔺
@sentry/node-core52.15 kB+0.01%+5 B 🔺
@sentry/node166.16 kB+0.01%+6 B 🔺
@sentry/node - without tracing93.92 kB+0.02%+11 B 🔺
@sentry/aws-serverless109.44 kB+0.02%+11 B 🔺
View base workflow run
@Lms24Lms24
mentioned this pull request
Jan 30, 2026

Closed

@github-actions
github-actionsBot
commented
Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,302-8,842+5%
GET With Sentry1,71918%1,673+3%
GET With Sentry (error only)6,20567%5,638+10%
POST Baseline1,210-1,077+12%
POST With Sentry58949%527+12%
POST With Sentry (error only)1,07088%1,016+5%
MYSQL Baseline3,373-3,199+5%
MYSQL With Sentry45614%394+16%
MYSQL With Sentry (error only)2,76382%2,617+6%
View base workflow run
logaretm
logaretm
reviewed
Jan 30, 2026
View reviewed changes
Comment threadpackages/core/src/utils/sdkMetadata.ts
Outdated

 };
 }

 if (!metadata.sdk) {
@logaretmlogaretmJan 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something but isn't this doing the same check as line 20? if so metadata.sdk will always be set before it hits this line here, no?
https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/utils/sdkMetadata.ts#L20-L29
@Lms24Lms24Jan 30, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not sure why but I had a massive brain outage on this one: I added my new logic underneath the old one and forgot to delete the old one afterwards. 🤦
Found a way to make this all a bit more concise. Might even save us some bytes. 🤞 Thanks for calling this out!
@Lms24Lms24
self-assigned this
Jan 30, 2026
logaretm
logaretm
approved these changes
Jan 30, 2026
View reviewed changes
@logaretmlogaretm
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fridays be like that, nice one!
@Lms24
Lms24
enabled auto-merge (squash)
January 30, 2026 17:54
@Lms24
Lms24
merged commit c104764
into
developJan 30, 2026

421 of 424 checks passed

@Lms24
Lms24
deleted the

lms/fix-core-applySdkMetadata-partial-merge

branch
January 30, 2026 18:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@logaretmlogaretmlogaretm approved these changes
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@Lms24Lms24

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Allow enabling infer_ip without enabling all default PII


2 participants

@Lms24@logaretm