Uh oh!
There was an error while loading. Please reload this page.
feat(nitro): Instrument HTTP Server - #19225
Merged
logaretm merged 32 commits intoApr 17, 2026
Merged
Conversation
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
Codecov Results 📊✅ 25 passed | ⏭️ 5 skipped | Total: 30 | Pass Rate: 83.33% | Execution Time: 13.58s All tests are passing successfully. Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
logaretmforce-pushed
the
awad/js-1128-nitro-use-tracing-channels-for-srvx-and-h3
branch
2 times, most recently
from
February 9, 2026 20:05
23a8b35 to
07ad5a1Comparelogaretmforce-pushed
the
awad/create-nitro-sdk-metadata
branch
from
February 10, 2026 19:31
81b555e to
161862dComparelogaretmforce-pushed
the
awad/js-1128-nitro-use-tracing-channels-for-srvx-and-h3
branch
2 times, most recently
from
February 10, 2026 20:23
c3fef9e to
6799854CompareUh oh!
There was an error while loading. Please reload this page.
logaretmforce-pushed
the
awad/create-nitro-sdk-metadata
branch
from
February 23, 2026 14:46
a95e594 to
88d95dfComparelogaretmforce-pushed
the
awad/js-1128-nitro-use-tracing-channels-for-srvx-and-h3
branch
from
February 23, 2026 14:50
1923dda to
be2f037Comparelogaretmforce-pushed
the
awad/create-nitro-sdk-metadata
branch
from
February 23, 2026 14:51
1317257 to
2a86160Comparelogaretmforce-pushed
the
awad/js-1128-nitro-use-tracing-channels-for-srvx-and-h3
branch
2 times, most recently
from
February 23, 2026 16:17
3b30e36 to
36c96b6CompareContributor
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
logaretmforce-pushed
the
awad/create-nitro-sdk-metadata
branch
from
April 15, 2026 13:10
99ea611 to
9ded4c9Comparelogaretmforce-pushed
the
awad/js-1128-nitro-use-tracing-channels-for-srvx-and-h3
branch
3 times, most recently
from
April 15, 2026 14:55
342ea3b to
8d44437Comparelogaretm
marked this pull request as ready for review
April 15, 2026 17:16
… hooks Replace otel-tracing-channel with @sentry/opentelemetry's vendored tracingChannel. Fix data.span -> data._sentrySpan references so tracing channel spans are actually ended. Export TracingChannelContextWithSpan type for consumers. Add e2e span nesting tests to verify context propagation through the full srvx -> h3 -> user code span tree. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
logaretmforce-pushed
the
awad/js-1128-nitro-use-tracing-channels-for-srvx-and-h3
branch
from
April 16, 2026 17:09
0173b17 to
6b8d4d7Compares1gr1d
approved these changes
Apr 17, 2026
| await request.get('/api/non-existent-route'); | ||
| expect(errorReceived).toBe(false); |
Member
There was a problem hiding this comment.
What we do in other e2e-tests for such tests is to have a separate flush endpoint that is called after the error endpoint to ensure that all events have been sent (e.g. nestjs, cloudflare), so I think it would be good to switch to that pattern here too
MemberAuthor
There was a problem hiding this comment.
Makes sense, I will merge this into the base branch but will make sure to do that! thanks!
logaretm
merged commit Apr 17, 2026
4cd6415
into
awad/create-nitro-sdk-metadata
472 of 474 checks passed
Uh oh!
There was an error while loading. Please reload this page.
logaretm
deleted the
awad/js-1128-nitro-use-tracing-channels-for-srvx-and-h3
branch
April 17, 2026 15:09
logaretm added a commit
that referenced
this pull request
Apr 17, 2026
Implements HTTP server instrumentation for both `h3` and `srvx` by listening to their tracing channel events. - `h3` TC PR: h3js/h3#1251 - `srvx` TC PR: h3js/srvx#141Closes#18123 --- **This PR is part of a stack:** - #20358 - #19224 - #19225 👈 - #19304 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
logaretm added a commit
that referenced
this pull request
Apr 18, 2026
Implements HTTP server instrumentation for both `h3` and `srvx` by listening to their tracing channel events. - `h3` TC PR: h3js/h3#1251 - `srvx` TC PR: h3js/srvx#141Closes#18123 --- **This PR is part of a stack:** - #20358 - #19224 - #19225 👈 - #19304 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
logaretm added a commit
that referenced
this pull request
Apr 22, 2026
Adds automatic sourcemap handling to the Nitro SDK, using `@sentry/bundler-plugin-core` for builder-agnostic post-build upload. Nitro uses rollup or rolldown, so it made sense to make it as agnostic as possible. Closes#17992 --- **This PR is part of a stack:** - #20358 - #19224 - #19225 - #19304 👈 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
logaretm added a commit
that referenced
this pull request
Apr 22, 2026
Implements HTTP server instrumentation for both `h3` and `srvx` by listening to their tracing channel events. - `h3` TC PR: h3js/h3#1251 - `srvx` TC PR: h3js/srvx#141Closes#18123 --- **This PR is part of a stack:** - #20358 - #19224 - #19225 👈 - #19304 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
logaretm added a commit
that referenced
this pull request
Apr 22, 2026
Adds automatic sourcemap handling to the Nitro SDK, using `@sentry/bundler-plugin-core` for builder-agnostic post-build upload. Nitro uses rollup or rolldown, so it made sense to make it as agnostic as possible. Closes#17992 --- **This PR is part of a stack:** - #20358 - #19224 - #19225 - #19304 👈 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
logaretm added a commit
that referenced
this pull request
Apr 23, 2026
Implements HTTP server instrumentation for both `h3` and `srvx` by listening to their tracing channel events. - `h3` TC PR: h3js/h3#1251 - `srvx` TC PR: h3js/srvx#141Closes#18123 --- **This PR is part of a stack:** - #20358 - #19224 - #19225 👈 - #19304 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
logaretm added a commit
that referenced
this pull request
Apr 23, 2026
Adds automatic sourcemap handling to the Nitro SDK, using `@sentry/bundler-plugin-core` for builder-agnostic post-build upload. Nitro uses rollup or rolldown, so it made sense to make it as agnostic as possible. Closes#17992 --- **This PR is part of a stack:** - #20358 - #19224 - #19225 - #19304 👈 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
logaretm added a commit
that referenced
this pull request
Apr 23, 2026
This PR just isolates the mundane changes needed for a new SDK to keep the next stacked PRs clean, it adds the Nitro SDK to the monorepo. This PR is a base of a stack, the stacked PRs will be merged into it. I thought this will be easier to review. --- **This PR is part of a stack:** - #20358 - #19224 👈 - #19225 - #19304 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements HTTP server instrumentation for both
h3andsrvxby listening to their tracing channel events.h3TC PR: feat: experimental tracing support h3js/h3#1251srvxTC PR: feat: experimental tracing channel support h3js/srvx#141Closes#18123
This PR is part of a stack: