feat(deno): instrument Deno.serve with async context support - #19230

Merged
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno
Feb 13, 2026
Merged

feat(deno): instrument Deno.serve with async context support#19230
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno

Conversation

@isaacs

@isaacsisaacs commented Feb 8, 2026

Copy link
Copy Markdown
Member
  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes#15455
Closes#12450

@linear

linearBot commented Feb 8, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 14 uncovered lines.

Files with missing lines (2)
FilePatch %Lines
mute.js79.10%⚠️ 14 Missing and 7 partials
etoa.js100.00%⚠️ 1 partials

Generated by Codecov Action

@github-actions

github-actionsBot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,873-9,512-7%
GET With Sentry1,65219%1,616+2%
GET With Sentry (error only)6,04868%6,033+0%
POST Baseline1,194-1,197-0%
POST With Sentry57348%590-3%
POST With Sentry (error only)1,05488%1,051+0%
MYSQL Baseline3,254-3,335-2%
MYSQL With Sentry47815%464+3%
MYSQL With Sentry (error only)2,66982%2,689-1%

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from c0fdc88 to f1044c4CompareFebruary 10, 2026 23:15
@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.21 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.04 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB+0.01%+1 B 🔺
@sentry/node166.51 kB+0.01%+2 B 🔺
@sentry/node - without tracing93.95 kB--
@sentry/aws-serverless109.45 kB+0.01%+1 B 🔺

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from f1044c4 to 8f21020CompareFebruary 10, 2026 23:30
@isaacs

Copy link
Copy Markdown
MemberAuthor

@brc-dd Hey! I'm picking this up, attempting to do more or less what you did in #12450, but with async local storage support to keep the contexts straight.

Want to take a look and see if this patch works for you?

@isaacs
isaacs marked this pull request as ready for review February 11, 2026 00:02
@isaacs
isaacs requested a review from timfishFebruary 11, 2026 00:02
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 8f21020 to 775c258CompareFebruary 11, 2026 00:05
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 775c258 to e610fa1CompareFebruary 11, 2026 01:06
Comment threadpackages/deno/src/wrap-deno-request-handler.ts Outdated
Comment threadpackages/deno/src/wrap-deno-request-handler.ts
@brc-ddbrc-dd mentioned this pull request Feb 11, 2026
2 tasks
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@brc-dd

brc-dd commented Feb 11, 2026

Copy link
Copy Markdown

Want to take a look and see if this patch works for you?

Mostly looks good to me. I'll give it a try locally with some actual project.

Update: seems to be working. Isolation seems to be working too.

image

@timfishtimfish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment threadpackages/deno/src/utils/streaming.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 5e0298e to 516d0c0CompareFebruary 12, 2026 00:20
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 516d0c0 to 58d6f32CompareFebruary 12, 2026 00:21
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 58d6f32 to d78c354CompareFebruary 13, 2026 04:56
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from d78c354 to e54b5beCompareFebruary 13, 2026 04:58
@isaacs
isaacs merged commit 6573b00 into developFeb 13, 2026
36 checks passed
@isaacs
isaacs deleted the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 13, 2026 05:14
@isaacs
isaacs restored the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 23, 2026 23:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AsyncLocalStorage in Deno Support Deno.serve instrumentation

3 participants

@isaacs@brc-dd@timfish
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(deno): instrument Deno.serve with async context support - #19230

Merged
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno
Feb 13, 2026
Merged

feat(deno): instrument Deno.serve with async context support#19230
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno

Conversation

@isaacs

@isaacsisaacs commented Feb 8, 2026

Copy link
Copy Markdown
Member
  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes#15455
Closes#12450

@linear

linearBot commented Feb 8, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 14 uncovered lines.

Files with missing lines (2)
FilePatch %Lines
mute.js79.10%⚠️ 14 Missing and 7 partials
etoa.js100.00%⚠️ 1 partials

Generated by Codecov Action

@github-actions

github-actionsBot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,873-9,512-7%
GET With Sentry1,65219%1,616+2%
GET With Sentry (error only)6,04868%6,033+0%
POST Baseline1,194-1,197-0%
POST With Sentry57348%590-3%
POST With Sentry (error only)1,05488%1,051+0%
MYSQL Baseline3,254-3,335-2%
MYSQL With Sentry47815%464+3%
MYSQL With Sentry (error only)2,66982%2,689-1%

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from c0fdc88 to f1044c4CompareFebruary 10, 2026 23:15
@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.21 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.04 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB+0.01%+1 B 🔺
@sentry/node166.51 kB+0.01%+2 B 🔺
@sentry/node - without tracing93.95 kB--
@sentry/aws-serverless109.45 kB+0.01%+1 B 🔺

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from f1044c4 to 8f21020CompareFebruary 10, 2026 23:30
@isaacs

Copy link
Copy Markdown
MemberAuthor

@brc-dd Hey! I'm picking this up, attempting to do more or less what you did in #12450, but with async local storage support to keep the contexts straight.

Want to take a look and see if this patch works for you?

@isaacs
isaacs marked this pull request as ready for review February 11, 2026 00:02
@isaacs
isaacs requested a review from timfishFebruary 11, 2026 00:02
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 8f21020 to 775c258CompareFebruary 11, 2026 00:05
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 775c258 to e610fa1CompareFebruary 11, 2026 01:06
Comment threadpackages/deno/src/wrap-deno-request-handler.ts Outdated
Comment threadpackages/deno/src/wrap-deno-request-handler.ts
@brc-ddbrc-dd mentioned this pull request Feb 11, 2026
2 tasks
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@brc-dd

brc-dd commented Feb 11, 2026

Copy link
Copy Markdown

Want to take a look and see if this patch works for you?

Mostly looks good to me. I'll give it a try locally with some actual project.

Update: seems to be working. Isolation seems to be working too.

image

@timfishtimfish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment threadpackages/deno/src/utils/streaming.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 5e0298e to 516d0c0CompareFebruary 12, 2026 00:20
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 516d0c0 to 58d6f32CompareFebruary 12, 2026 00:21
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 58d6f32 to d78c354CompareFebruary 13, 2026 04:56
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from d78c354 to e54b5beCompareFebruary 13, 2026 04:58
@isaacs
isaacs merged commit 6573b00 into developFeb 13, 2026
36 checks passed
@isaacs
isaacs deleted the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 13, 2026 05:14
@isaacs
isaacs restored the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 23, 2026 23:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AsyncLocalStorage in Deno Support Deno.serve instrumentation

3 participants

@isaacs@brc-dd@timfish
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(deno): instrument Deno.serve with async context support - #19230

Merged
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno
Feb 13, 2026
Merged

feat(deno): instrument Deno.serve with async context support#19230
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno

Conversation

@isaacs

@isaacsisaacs commented Feb 8, 2026

Copy link
Copy Markdown
Member
  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes#15455
Closes#12450

@linear

linearBot commented Feb 8, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 14 uncovered lines.

Files with missing lines (2)
FilePatch %Lines
mute.js79.10%⚠️ 14 Missing and 7 partials
etoa.js100.00%⚠️ 1 partials

Generated by Codecov Action

@github-actions

github-actionsBot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,873-9,512-7%
GET With Sentry1,65219%1,616+2%
GET With Sentry (error only)6,04868%6,033+0%
POST Baseline1,194-1,197-0%
POST With Sentry57348%590-3%
POST With Sentry (error only)1,05488%1,051+0%
MYSQL Baseline3,254-3,335-2%
MYSQL With Sentry47815%464+3%
MYSQL With Sentry (error only)2,66982%2,689-1%

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from c0fdc88 to f1044c4CompareFebruary 10, 2026 23:15
@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.21 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.04 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB+0.01%+1 B 🔺
@sentry/node166.51 kB+0.01%+2 B 🔺
@sentry/node - without tracing93.95 kB--
@sentry/aws-serverless109.45 kB+0.01%+1 B 🔺

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from f1044c4 to 8f21020CompareFebruary 10, 2026 23:30
@isaacs

Copy link
Copy Markdown
MemberAuthor

@brc-dd Hey! I'm picking this up, attempting to do more or less what you did in #12450, but with async local storage support to keep the contexts straight.

Want to take a look and see if this patch works for you?

@isaacs
isaacs marked this pull request as ready for review February 11, 2026 00:02
@isaacs
isaacs requested a review from timfishFebruary 11, 2026 00:02
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 8f21020 to 775c258CompareFebruary 11, 2026 00:05
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 775c258 to e610fa1CompareFebruary 11, 2026 01:06
Comment threadpackages/deno/src/wrap-deno-request-handler.ts Outdated
Comment threadpackages/deno/src/wrap-deno-request-handler.ts
@brc-ddbrc-dd mentioned this pull request Feb 11, 2026
2 tasks
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@brc-dd

brc-dd commented Feb 11, 2026

Copy link
Copy Markdown

Want to take a look and see if this patch works for you?

Mostly looks good to me. I'll give it a try locally with some actual project.

Update: seems to be working. Isolation seems to be working too.

image

@timfishtimfish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment threadpackages/deno/src/utils/streaming.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 5e0298e to 516d0c0CompareFebruary 12, 2026 00:20
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 516d0c0 to 58d6f32CompareFebruary 12, 2026 00:21
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 58d6f32 to d78c354CompareFebruary 13, 2026 04:56
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from d78c354 to e54b5beCompareFebruary 13, 2026 04:58
@isaacs
isaacs merged commit 6573b00 into developFeb 13, 2026
36 checks passed
@isaacs
isaacs deleted the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 13, 2026 05:14
@isaacs
isaacs restored the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 23, 2026 23:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AsyncLocalStorage in Deno Support Deno.serve instrumentation

3 participants

@isaacs@brc-dd@timfish
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(deno): instrument Deno.serve with async context support - #19230

Merged
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno
Feb 13, 2026
Merged

feat(deno): instrument Deno.serve with async context support#19230
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno

Conversation

@isaacs

@isaacsisaacs commented Feb 8, 2026

Copy link
Copy Markdown
Member
  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes#15455
Closes#12450

@linear

linearBot commented Feb 8, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 14 uncovered lines.

Files with missing lines (2)
FilePatch %Lines
mute.js79.10%⚠️ 14 Missing and 7 partials
etoa.js100.00%⚠️ 1 partials

Generated by Codecov Action

@github-actions

github-actionsBot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,873-9,512-7%
GET With Sentry1,65219%1,616+2%
GET With Sentry (error only)6,04868%6,033+0%
POST Baseline1,194-1,197-0%
POST With Sentry57348%590-3%
POST With Sentry (error only)1,05488%1,051+0%
MYSQL Baseline3,254-3,335-2%
MYSQL With Sentry47815%464+3%
MYSQL With Sentry (error only)2,66982%2,689-1%

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from c0fdc88 to f1044c4CompareFebruary 10, 2026 23:15
@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.21 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.04 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB+0.01%+1 B 🔺
@sentry/node166.51 kB+0.01%+2 B 🔺
@sentry/node - without tracing93.95 kB--
@sentry/aws-serverless109.45 kB+0.01%+1 B 🔺

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from f1044c4 to 8f21020CompareFebruary 10, 2026 23:30
@isaacs

Copy link
Copy Markdown
MemberAuthor

@brc-dd Hey! I'm picking this up, attempting to do more or less what you did in #12450, but with async local storage support to keep the contexts straight.

Want to take a look and see if this patch works for you?

@isaacs
isaacs marked this pull request as ready for review February 11, 2026 00:02
@isaacs
isaacs requested a review from timfishFebruary 11, 2026 00:02
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 8f21020 to 775c258CompareFebruary 11, 2026 00:05
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 775c258 to e610fa1CompareFebruary 11, 2026 01:06
Comment threadpackages/deno/src/wrap-deno-request-handler.ts Outdated
Comment threadpackages/deno/src/wrap-deno-request-handler.ts
@brc-ddbrc-dd mentioned this pull request Feb 11, 2026
2 tasks
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@brc-dd

brc-dd commented Feb 11, 2026

Copy link
Copy Markdown

Want to take a look and see if this patch works for you?

Mostly looks good to me. I'll give it a try locally with some actual project.

Update: seems to be working. Isolation seems to be working too.

image

@timfishtimfish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment threadpackages/deno/src/utils/streaming.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 5e0298e to 516d0c0CompareFebruary 12, 2026 00:20
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 516d0c0 to 58d6f32CompareFebruary 12, 2026 00:21
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 58d6f32 to d78c354CompareFebruary 13, 2026 04:56
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from d78c354 to e54b5beCompareFebruary 13, 2026 04:58
@isaacs
isaacs merged commit 6573b00 into developFeb 13, 2026
36 checks passed
@isaacs
isaacs deleted the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 13, 2026 05:14
@isaacs
isaacs restored the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 23, 2026 23:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AsyncLocalStorage in Deno Support Deno.serve instrumentation

3 participants

@isaacs@brc-dd@timfish
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(deno): instrument Deno.serve with async context support - #19230

Merged
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno
Feb 13, 2026
Merged

feat(deno): instrument Deno.serve with async context support#19230
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno

Conversation

@isaacs

@isaacsisaacs commented Feb 8, 2026

Copy link
Copy Markdown
Member
  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes#15455
Closes#12450

@linear

linearBot commented Feb 8, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 14 uncovered lines.

Files with missing lines (2)
FilePatch %Lines
mute.js79.10%⚠️ 14 Missing and 7 partials
etoa.js100.00%⚠️ 1 partials

Generated by Codecov Action

@github-actions

github-actionsBot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,873-9,512-7%
GET With Sentry1,65219%1,616+2%
GET With Sentry (error only)6,04868%6,033+0%
POST Baseline1,194-1,197-0%
POST With Sentry57348%590-3%
POST With Sentry (error only)1,05488%1,051+0%
MYSQL Baseline3,254-3,335-2%
MYSQL With Sentry47815%464+3%
MYSQL With Sentry (error only)2,66982%2,689-1%

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from c0fdc88 to f1044c4CompareFebruary 10, 2026 23:15
@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.21 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.04 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB+0.01%+1 B 🔺
@sentry/node166.51 kB+0.01%+2 B 🔺
@sentry/node - without tracing93.95 kB--
@sentry/aws-serverless109.45 kB+0.01%+1 B 🔺

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from f1044c4 to 8f21020CompareFebruary 10, 2026 23:30
@isaacs

Copy link
Copy Markdown
MemberAuthor

@brc-dd Hey! I'm picking this up, attempting to do more or less what you did in #12450, but with async local storage support to keep the contexts straight.

Want to take a look and see if this patch works for you?

@isaacs
isaacs marked this pull request as ready for review February 11, 2026 00:02
@isaacs
isaacs requested a review from timfishFebruary 11, 2026 00:02
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 8f21020 to 775c258CompareFebruary 11, 2026 00:05
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 775c258 to e610fa1CompareFebruary 11, 2026 01:06
Comment threadpackages/deno/src/wrap-deno-request-handler.ts Outdated
Comment threadpackages/deno/src/wrap-deno-request-handler.ts
@brc-ddbrc-dd mentioned this pull request Feb 11, 2026
2 tasks
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@brc-dd

brc-dd commented Feb 11, 2026

Copy link
Copy Markdown

Want to take a look and see if this patch works for you?

Mostly looks good to me. I'll give it a try locally with some actual project.

Update: seems to be working. Isolation seems to be working too.

image

@timfishtimfish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment threadpackages/deno/src/utils/streaming.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 5e0298e to 516d0c0CompareFebruary 12, 2026 00:20
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 516d0c0 to 58d6f32CompareFebruary 12, 2026 00:21
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 58d6f32 to d78c354CompareFebruary 13, 2026 04:56
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from d78c354 to e54b5beCompareFebruary 13, 2026 04:58
@isaacs
isaacs merged commit 6573b00 into developFeb 13, 2026
36 checks passed
@isaacs
isaacs deleted the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 13, 2026 05:14
@isaacs
isaacs restored the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 23, 2026 23:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AsyncLocalStorage in Deno Support Deno.serve instrumentation

3 participants

@isaacs@brc-dd@timfish
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(deno): instrument Deno.serve with async context support - #19230

Merged
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno
Feb 13, 2026
Merged

feat(deno): instrument Deno.serve with async context support#19230
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno

Conversation

@isaacs

@isaacsisaacs commented Feb 8, 2026

Copy link
Copy Markdown
Member
  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes#15455
Closes#12450

@linear

linearBot commented Feb 8, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 14 uncovered lines.

Files with missing lines (2)
FilePatch %Lines
mute.js79.10%⚠️ 14 Missing and 7 partials
etoa.js100.00%⚠️ 1 partials

Generated by Codecov Action

@github-actions

github-actionsBot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,873-9,512-7%
GET With Sentry1,65219%1,616+2%
GET With Sentry (error only)6,04868%6,033+0%
POST Baseline1,194-1,197-0%
POST With Sentry57348%590-3%
POST With Sentry (error only)1,05488%1,051+0%
MYSQL Baseline3,254-3,335-2%
MYSQL With Sentry47815%464+3%
MYSQL With Sentry (error only)2,66982%2,689-1%

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from c0fdc88 to f1044c4CompareFebruary 10, 2026 23:15
@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.21 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.04 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB+0.01%+1 B 🔺
@sentry/node166.51 kB+0.01%+2 B 🔺
@sentry/node - without tracing93.95 kB--
@sentry/aws-serverless109.45 kB+0.01%+1 B 🔺

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from f1044c4 to 8f21020CompareFebruary 10, 2026 23:30
@isaacs

Copy link
Copy Markdown
MemberAuthor

@brc-dd Hey! I'm picking this up, attempting to do more or less what you did in #12450, but with async local storage support to keep the contexts straight.

Want to take a look and see if this patch works for you?

@isaacs
isaacs marked this pull request as ready for review February 11, 2026 00:02
@isaacs
isaacs requested a review from timfishFebruary 11, 2026 00:02
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 8f21020 to 775c258CompareFebruary 11, 2026 00:05
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 775c258 to e610fa1CompareFebruary 11, 2026 01:06
Comment threadpackages/deno/src/wrap-deno-request-handler.ts Outdated
Comment threadpackages/deno/src/wrap-deno-request-handler.ts
@brc-ddbrc-dd mentioned this pull request Feb 11, 2026
2 tasks
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@brc-dd

brc-dd commented Feb 11, 2026

Copy link
Copy Markdown

Want to take a look and see if this patch works for you?

Mostly looks good to me. I'll give it a try locally with some actual project.

Update: seems to be working. Isolation seems to be working too.

image

@timfishtimfish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment threadpackages/deno/src/utils/streaming.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 5e0298e to 516d0c0CompareFebruary 12, 2026 00:20
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 516d0c0 to 58d6f32CompareFebruary 12, 2026 00:21
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 58d6f32 to d78c354CompareFebruary 13, 2026 04:56
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from d78c354 to e54b5beCompareFebruary 13, 2026 04:58
@isaacs
isaacs merged commit 6573b00 into developFeb 13, 2026
36 checks passed
@isaacs
isaacs deleted the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 13, 2026 05:14
@isaacs
isaacs restored the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 23, 2026 23:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AsyncLocalStorage in Deno Support Deno.serve instrumentation

3 participants

@isaacs@brc-dd@timfish
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(deno): instrument Deno.serve with async context support - #19230

Merged
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno
Feb 13, 2026
Merged

feat(deno): instrument Deno.serve with async context support#19230
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno

Conversation

@isaacs

@isaacsisaacs commented Feb 8, 2026

Copy link
Copy Markdown
Member
  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes#15455
Closes#12450

@linear

linearBot commented Feb 8, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 14 uncovered lines.

Files with missing lines (2)
FilePatch %Lines
mute.js79.10%⚠️ 14 Missing and 7 partials
etoa.js100.00%⚠️ 1 partials

Generated by Codecov Action

@github-actions

github-actionsBot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,873-9,512-7%
GET With Sentry1,65219%1,616+2%
GET With Sentry (error only)6,04868%6,033+0%
POST Baseline1,194-1,197-0%
POST With Sentry57348%590-3%
POST With Sentry (error only)1,05488%1,051+0%
MYSQL Baseline3,254-3,335-2%
MYSQL With Sentry47815%464+3%
MYSQL With Sentry (error only)2,66982%2,689-1%

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from c0fdc88 to f1044c4CompareFebruary 10, 2026 23:15
@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.21 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.04 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB+0.01%+1 B 🔺
@sentry/node166.51 kB+0.01%+2 B 🔺
@sentry/node - without tracing93.95 kB--
@sentry/aws-serverless109.45 kB+0.01%+1 B 🔺

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from f1044c4 to 8f21020CompareFebruary 10, 2026 23:30
@isaacs

Copy link
Copy Markdown
MemberAuthor

@brc-dd Hey! I'm picking this up, attempting to do more or less what you did in #12450, but with async local storage support to keep the contexts straight.

Want to take a look and see if this patch works for you?

@isaacs
isaacs marked this pull request as ready for review February 11, 2026 00:02
@isaacs
isaacs requested a review from timfishFebruary 11, 2026 00:02
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 8f21020 to 775c258CompareFebruary 11, 2026 00:05
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 775c258 to e610fa1CompareFebruary 11, 2026 01:06
Comment threadpackages/deno/src/wrap-deno-request-handler.ts Outdated
Comment threadpackages/deno/src/wrap-deno-request-handler.ts
@brc-ddbrc-dd mentioned this pull request Feb 11, 2026
2 tasks
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@brc-dd

brc-dd commented Feb 11, 2026

Copy link
Copy Markdown

Want to take a look and see if this patch works for you?

Mostly looks good to me. I'll give it a try locally with some actual project.

Update: seems to be working. Isolation seems to be working too.

image

@timfishtimfish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment threadpackages/deno/src/utils/streaming.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 5e0298e to 516d0c0CompareFebruary 12, 2026 00:20
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 516d0c0 to 58d6f32CompareFebruary 12, 2026 00:21
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 58d6f32 to d78c354CompareFebruary 13, 2026 04:56
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from d78c354 to e54b5beCompareFebruary 13, 2026 04:58
@isaacs
isaacs merged commit 6573b00 into developFeb 13, 2026
36 checks passed
@isaacs
isaacs deleted the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 13, 2026 05:14
@isaacs
isaacs restored the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 23, 2026 23:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AsyncLocalStorage in Deno Support Deno.serve instrumentation

3 participants

@isaacs@brc-dd@timfish
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(deno): instrument Deno.serve with async context support - #19230

Merged
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno
Feb 13, 2026
Merged

feat(deno): instrument Deno.serve with async context support#19230
isaacs merged 1 commit into
developfrom
isaacschlueter/js-305-support-asynclocalstorage-in-deno

Conversation

@isaacs

@isaacsisaacs commented Feb 8, 2026

Copy link
Copy Markdown
Member
  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes#15455
Closes#12450

@linear

linearBot commented Feb 8, 2026

Copy link
Copy Markdown

@github-actions

github-actionsBot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 14 uncovered lines.

Files with missing lines (2)
FilePatch %Lines
mute.js79.10%⚠️ 14 Missing and 7 partials
etoa.js100.00%⚠️ 1 partials

Generated by Codecov Action

@github-actions

github-actionsBot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,873-9,512-7%
GET With Sentry1,65219%1,616+2%
GET With Sentry (error only)6,04868%6,033+0%
POST Baseline1,194-1,197-0%
POST With Sentry57348%590-3%
POST With Sentry (error only)1,05488%1,051+0%
MYSQL Baseline3,254-3,335-2%
MYSQL With Sentry47815%464+3%
MYSQL With Sentry (error only)2,66982%2,689-1%

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from c0fdc88 to f1044c4CompareFebruary 10, 2026 23:15
@github-actions

github-actionsBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.21 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.04 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB+0.01%+1 B 🔺
@sentry/node166.51 kB+0.01%+2 B 🔺
@sentry/node - without tracing93.95 kB--
@sentry/aws-serverless109.45 kB+0.01%+1 B 🔺

View base workflow run

@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from f1044c4 to 8f21020CompareFebruary 10, 2026 23:30
@isaacs

Copy link
Copy Markdown
MemberAuthor

@brc-dd Hey! I'm picking this up, attempting to do more or less what you did in #12450, but with async local storage support to keep the contexts straight.

Want to take a look and see if this patch works for you?

@isaacs
isaacs marked this pull request as ready for review February 11, 2026 00:02
@isaacs
isaacs requested a review from timfishFebruary 11, 2026 00:02
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 8f21020 to 775c258CompareFebruary 11, 2026 00:05
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/utils/streaming.ts Outdated
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 775c258 to e610fa1CompareFebruary 11, 2026 01:06
Comment threadpackages/deno/src/wrap-deno-request-handler.ts Outdated
Comment threadpackages/deno/src/wrap-deno-request-handler.ts
@brc-ddbrc-dd mentioned this pull request Feb 11, 2026
2 tasks
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts Outdated
@brc-dd

brc-dd commented Feb 11, 2026

Copy link
Copy Markdown

Want to take a look and see if this patch works for you?

Mostly looks good to me. I'll give it a try locally with some actual project.

Update: seems to be working. Isolation seems to be working too.

image

@timfishtimfish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment threadpackages/deno/src/utils/streaming.ts
Comment threadpackages/deno/src/integrations/deno-serve.ts
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 5e0298e to 516d0c0CompareFebruary 12, 2026 00:20
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 516d0c0 to 58d6f32CompareFebruary 12, 2026 00:21
Comment threadpackages/deno/src/utils/streaming.ts
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from 58d6f32 to d78c354CompareFebruary 13, 2026 04:56
@isaacs
isaacsforce-pushed the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch from d78c354 to e54b5beCompareFebruary 13, 2026 04:58
@isaacs
isaacs merged commit 6573b00 into developFeb 13, 2026
36 checks passed
@isaacs
isaacs deleted the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 13, 2026 05:14
@isaacs
isaacs restored the isaacschlueter/js-305-support-asynclocalstorage-in-deno branch February 23, 2026 23:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AsyncLocalStorage in Deno Support Deno.serve instrumentation

3 participants

@isaacs@brc-dd@timfish