Uh oh!
There was an error while loading. Please reload this page.
ref(core): Move shouldPropagateTraceForUrl from opentelemetry to core - #19254
Merged
Conversation
This function is needed by light mode integrations that don't use OpenTelemetry. Move it to @sentry/core and re-export from @sentry/opentelemetry for backwards compatibility.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| const cachedDecision = decisionMap?.get(url); | ||
| if (cachedDecision !== undefined) { | ||
| !cachedDecision && debug.log(NOT_PROPAGATED_MESSAGE, url); |
There was a problem hiding this comment.
Missing DEBUG_BUILD guard drops tree-shaking for debug logs
Medium Severity
The original code guarded debug.log calls with DEBUG_BUILD &&, enabling bundlers to tree-shake the entire expression (including NOT_PROPAGATED_MESSAGE) in production builds. The moved version drops the DEBUG_BUILD && prefix. While debug.log internally checks DEBUG_BUILD, the external guard is what allows dead-code elimination of the string constant and function call. Every other debug.log call in packages/core/src consistently uses the DEBUG_BUILD && pattern.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Restore the DEBUG_BUILD && prefix that was present in the original opentelemetry version, enabling bundlers to tree-shake the debug log calls and string constant in production builds.
andreiborzaforce-pushed
the
ab/move-shouldPropagateTraceForUrl-to-core
branch
from
February 10, 2026 15:50
a76acf3 to
970a075CompareContributor
Codecov Results 📊Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
chargome
approved these changes
Feb 10, 2026
JPeer264
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is needed in an upcoming pr by node-core/light, and since node-core/light does not depend on OpenTelemetry we need to move this to core and re-export it in
@sentry/opentelemetryfor backwards compatibility.Closes#19255 (added automatically)