Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(nextjs): Set parameterized transaction name for non-transaction events#19316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9 ...e2e-tests/test-applications/nextjs-16/app/route-handler/[xoxo]/capture-exception/route.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import * as Sentry from '@sentry/nextjs'; | ||
| import { NextResponse } from 'next/server'; | ||
| export const dynamic = 'force-dynamic'; | ||
| export async function GET() { | ||
| Sentry.captureException(new Error('route-handler-capture-exception')); | ||
| return NextResponse.json({ message: 'Exception captured' }); | ||
| } |
9 changes: 9 additions & 0 deletions
9 ...s/e2e-tests/test-applications/nextjs-16/app/route-handler/[xoxo]/capture-message/route.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import * as Sentry from '@sentry/nextjs'; | ||
| import { NextResponse } from 'next/server'; | ||
| export const dynamic = 'force-dynamic'; | ||
| export async function GET() { | ||
| Sentry.captureMessage('route-handler-message'); | ||
| return NextResponse.json({ message: 'Message captured' }); | ||
| } |
5 changes: 5 additions & 0 deletions
5 dev-packages/e2e-tests/test-applications/nextjs-16/app/route-handler/[xoxo]/error/route.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| export const dynamic = 'force-dynamic'; | ||
| export async function GET() { | ||
| throw new Error('route-handler-error'); | ||
| } |
111 changes: 110 additions & 1 deletion
111 dev-packages/e2e-tests/test-applications/nextjs-16/tests/route-handler.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -46,6 +46,14 @@ export function handleOnSpanStart(span: Span): void { | ||
| // Preserving the original attribute despite internally not depending on it | ||
| rootSpan.setAttribute(ATTR_NEXT_ROUTE, route); | ||
| // Update the isolation scope's transaction name so that non-transaction events | ||
| // (e.g. captureMessage, captureException) also get the parameterized route. | ||
| // eslint-disable-next-line deprecation/deprecation | ||
| const method = rootSpanAttributes?.[ATTR_HTTP_REQUEST_METHOD] || rootSpanAttributes?.[SEMATTRS_HTTP_METHOD]; | ||
| if (typeof method === 'string') { | ||
| getIsolationScope().setTransactionName(`${method} ${route}`); | ||
| } | ||
sentry[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| // Check if this is a Vercel cron request and start a check-in | ||
| maybeStartCronCheckIn(rootSpan, route); | ||
| } | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test uses conditional instead of separate test cases
Low Severity
The test at line 69 uses
if (process.env.TEST_ENV === 'development')to conditionally run assertions fornextjscontext andmechanism. Per the project review rules, conditionals within a single test case are discouraged — the recommendation is to split the test into separate test cases for each environment path. This ensures both paths are always visible in test results and avoids silently skipping assertions.Triggered by project rule: PR Review Guidelines for Cursor Bot