Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,20 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

- **feat(tanstackstart-react): Add global sentry exception middlewares ([#19330](https://github.com/getsentry/sentry-javascript/pull/19330))**

The `sentryGlobalRequestMiddleware` and `sentryGlobalFunctionMiddleware` global middlewares capture unhandled exceptions thrown in TanStack Start API routes and server functions. Add them as the first entries in the `requestMiddleware` and `functionMiddleware` arrays of `createStart()`:

```ts
import { createStart } from '@tanstack/react-start/server';
import { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from '@sentry/tanstackstart-react/server';

export default createStart({
requestMiddleware: [sentryGlobalRequestMiddleware, myRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, myFunctionMiddleware],
});
```

### Important Changes

- fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 ([#18631](https://github.com/getsentry/sentry-javascript/pull/18631))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
import * as Sentry from '@sentry/tanstackstart-react';
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/api/error')({
server: {
handlers: {
GET: async () => {
try {
throw new Error('Sentry API Route Test Error');
} catch (error) {
Sentry.captureException(error);
throw error;
}
throw new Error('Sentry API Route Test Error');
},
},
},
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import { createFileRoute } from '@tanstack/react-router';
import { flush } from '@sentry/tanstackstart-react';

export const Route = createFileRoute('/api/flush')({
server: {
handlers: {
GET: async () => {
await flush();
return new Response('ok');
},
},
},
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/ssr-error')({
loader: () => {
throw new Error('Sentry SSR Test Error');
},
component: () => <div>SSR Error Page</div>,
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { sentryGlobalFunctionMiddleware, sentryGlobalRequestMiddleware } from '@sentry/tanstackstart-react';
import { createStart } from '@tanstack/react-start';
// NOTE: These are NOT wrapped - auto-instrumentation via the Vite plugin will wrap them
import { globalRequestMiddleware, globalFunctionMiddleware } from './middleware';
import { globalFunctionMiddleware, globalRequestMiddleware } from './middleware';

export const startInstance = createStart(() => {
return {
requestMiddleware: [globalRequestMiddleware],
functionMiddleware: [globalFunctionMiddleware],
requestMiddleware: [sentryGlobalRequestMiddleware, globalRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, globalFunctionMiddleware],
};
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';

test('Sends client-side error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
Expand DownExpand Up@@ -51,17 +51,18 @@ test('Sends server-side function error to Sentry with auto-instrumentation', asy
type: 'Error',
value: 'Sentry Server Function Test Error',
mechanism: {
type: 'auto.middleware.tanstackstart.server_function',
handled: false,
},
},
],
},
});

expect(errorEvent.transaction).toBe('/');
expect(errorEvent.transaction).toEqual(expect.stringContaining('GET /_serverFn/'));
});

test('Sends API route error to Sentry if manually instrumented', async ({ page }) => {
test('Sends API route error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Sentry API Route Test Error';
});
Expand All@@ -81,7 +82,8 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }
type: 'Error',
value: 'Sentry API Route Test Error',
mechanism: {
handled: true,
type: 'auto.middleware.tanstackstart.request',
handled: false,
},
},
],
Expand All@@ -90,3 +92,28 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }

expect(errorEvent.transaction).toBe('GET /api/error');
});

// the sentry global middleware does not capture errors from SSR loader errors since they are serialized before they reach the middleware layer
// this test verifies that the error is in fact not sent to Sentry
test('Does not send SSR loader error to Sentry', async ({ baseURL, page }) => {
Comment thread
nicohrubec marked this conversation as resolved.
let errorEventOccurred = false;

waitForError('tanstackstart-react', event => {
if (!event.type && event.exception?.values?.[0]?.value === 'Sentry SSR Test Error') {
errorEventOccurred = true;
}
return event?.transaction === 'GET /ssr-error';
});

const transactionEventPromise = waitForTransaction('tanstackstart-react', transactionEvent => {
return transactionEvent?.transaction === 'GET /ssr-error';
});

await page.goto('/ssr-error');

await transactionEventPromise;

await (await fetch(`${baseURL}/api/flush`)).text();

expect(errorEventOccurred).toBe(false);
});
12 changes: 12 additions & 0 deletions packages/tanstackstart-react/src/client/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,3 +14,15 @@ export { init } from './sdk';
export function wrapMiddlewaresWithSentry<T extends TanStackMiddlewareBase>(middlewares: Record<string, T>): T[] {
return Object.values(middlewares);
}

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };
5 changes: 4 additions & 1 deletion packages/tanstackstart-react/src/common/types.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
export type TanStackMiddlewareBase = {
options?: { server?: (...args: unknown[]) => unknown };
// eslint-disable-next-line @typescript-eslint/no-explicit-any
'~types': any;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
options: { server?: (...args: any[]) => any };

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript kept complaining in my sample app that the types of the new sentry middlewares clash with what is expected from tanstack (it was still running fine thought), had to change it to this to fix that

Comment thread
nicohrubec marked this conversation as resolved.
};

export type MiddlewareWrapperOptions = {
Expand Down
3 changes: 3 additions & 0 deletions packages/tanstackstart-react/src/index.types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,3 +37,6 @@ export declare const statsigIntegration: typeof clientSdk.statsigIntegration;
export declare const unleashIntegration: typeof clientSdk.unleashIntegration;

export declare const wrapMiddlewaresWithSentry: typeof serverSdk.wrapMiddlewaresWithSentry;

export declare const sentryGlobalRequestMiddleware: typeof serverSdk.sentryGlobalRequestMiddleware;
export declare const sentryGlobalFunctionMiddleware: typeof serverSdk.sentryGlobalFunctionMiddleware;
46 changes: 46 additions & 0 deletions packages/tanstackstart-react/src/server/globalMiddleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
import { addNonEnumerableProperty, captureException } from '@sentry/core';
import type { TanStackMiddlewareBase } from '../common/types';
import { SENTRY_INTERNAL } from './middleware';

function createSentryMiddlewareHandler(mechanismType: string) {
return async function sentryMiddlewareHandler({ next }: { next: () => Promise<unknown> }): Promise<unknown> {
try {
return await next();
} catch (e) {
captureException(e, {
mechanism: { type: mechanismType, handled: false },
});
throw e;
}
};
}
Comment thread
cursor[bot] marked this conversation as resolved.

/**
* Global request middleware that captures errors from API route requests.
* Should be added as the first entry in the `requestMiddleware` array of `createStart()`.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.request') as (...args: any[]) => any,
},
};

/**
* Global function middleware that captures errors from server function invocations.
* Should be added as the first entry in the `functionMiddleware` array of `createStart()`.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.server_function') as (...args: any[]) => any,
},
};

// Mark as internal so the Vite auto-instrumentation plugin skips these middleware
addNonEnumerableProperty(sentryGlobalRequestMiddleware, SENTRY_INTERNAL, true);
addNonEnumerableProperty(sentryGlobalFunctionMiddleware, SENTRY_INTERNAL, true);
1 change: 1 addition & 0 deletions packages/tanstackstart-react/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ export * from '@sentry/node';
export { init } from './sdk';
export { wrapFetchWithSentry } from './wrapFetchWithSentry';
export { wrapMiddlewaresWithSentry } from './middleware';
export { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from './globalMiddleware';

/**
* A passthrough error boundary for the server that doesn't depend on any react. Error boundaries don't catch SSR errors
Expand Down
8 changes: 6 additions & 2 deletions packages/tanstackstart-react/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type { MiddlewareWrapperOptions, TanStackMiddlewareBase } from '../common
import { getMiddlewareSpanOptions } from './utils';

const SENTRY_WRAPPED = '__SENTRY_WRAPPED__';
export const SENTRY_INTERNAL = '__SENTRY_INTERNAL__';

/**
* Creates a proxy for the next function that ends the current span and restores the parent span.
Expand DownExpand Up@@ -39,8 +40,11 @@ function wrapMiddlewareWithSentry<T extends TanStackMiddlewareBase>(
middleware: T,
options: MiddlewareWrapperOptions,
): T {
if ((middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED]) {
// already instrumented
if (
(middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED] ||
(middleware as TanStackMiddlewareBase & { [SENTRY_INTERNAL]?: boolean })[SENTRY_INTERNAL]
) {
// already instrumented or internal Sentry middleware
return middleware;
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
import { afterEach, describe, expect, it, vi } from 'vitest';

const captureExceptionSpy = vi.fn();

vi.mock('@sentry/core', async importOriginal => {
const original = await importOriginal();
return {
...original,
captureException: (...args: unknown[]) => captureExceptionSpy(...args),
};
});

// Import after mocks are set up
const { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } =
await import('../../src/server/globalMiddleware');

describe('sentryGlobalRequestMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalRequestMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.request', handled: false },
});
});

it('does not capture error when next() succeeds', async () => {
const next = vi.fn().mockResolvedValue('success');

const serverFn = sentryGlobalRequestMiddleware.options.server!;
const result = await serverFn({ next });

expect(result).toBe('success');
expect(captureExceptionSpy).not.toHaveBeenCalled();
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalRequestMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});

describe('sentryGlobalFunctionMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalFunctionMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.server_function', handled: false },
});
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalFunctionMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,20 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

- **feat(tanstackstart-react): Add global sentry exception middlewares ([#19330](https://github.com/getsentry/sentry-javascript/pull/19330))**

The `sentryGlobalRequestMiddleware` and `sentryGlobalFunctionMiddleware` global middlewares capture unhandled exceptions thrown in TanStack Start API routes and server functions. Add them as the first entries in the `requestMiddleware` and `functionMiddleware` arrays of `createStart()`:

```ts
import { createStart } from '@tanstack/react-start/server';
import { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from '@sentry/tanstackstart-react/server';

export default createStart({
requestMiddleware: [sentryGlobalRequestMiddleware, myRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, myFunctionMiddleware],
});
```

### Important Changes

- fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 ([#18631](https://github.com/getsentry/sentry-javascript/pull/18631))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
import * as Sentry from '@sentry/tanstackstart-react';
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/api/error')({
server: {
handlers: {
GET: async () => {
try {
throw new Error('Sentry API Route Test Error');
} catch (error) {
Sentry.captureException(error);
throw error;
}
throw new Error('Sentry API Route Test Error');
},
},
},
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import { createFileRoute } from '@tanstack/react-router';
import { flush } from '@sentry/tanstackstart-react';

export const Route = createFileRoute('/api/flush')({
server: {
handlers: {
GET: async () => {
await flush();
return new Response('ok');
},
},
},
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/ssr-error')({
loader: () => {
throw new Error('Sentry SSR Test Error');
},
component: () => <div>SSR Error Page</div>,
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { sentryGlobalFunctionMiddleware, sentryGlobalRequestMiddleware } from '@sentry/tanstackstart-react';
import { createStart } from '@tanstack/react-start';
// NOTE: These are NOT wrapped - auto-instrumentation via the Vite plugin will wrap them
import { globalRequestMiddleware, globalFunctionMiddleware } from './middleware';
import { globalFunctionMiddleware, globalRequestMiddleware } from './middleware';

export const startInstance = createStart(() => {
return {
requestMiddleware: [globalRequestMiddleware],
functionMiddleware: [globalFunctionMiddleware],
requestMiddleware: [sentryGlobalRequestMiddleware, globalRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, globalFunctionMiddleware],
};
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';

test('Sends client-side error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
Expand DownExpand Up@@ -51,17 +51,18 @@ test('Sends server-side function error to Sentry with auto-instrumentation', asy
type: 'Error',
value: 'Sentry Server Function Test Error',
mechanism: {
type: 'auto.middleware.tanstackstart.server_function',
handled: false,
},
},
],
},
});

expect(errorEvent.transaction).toBe('/');
expect(errorEvent.transaction).toEqual(expect.stringContaining('GET /_serverFn/'));
});

test('Sends API route error to Sentry if manually instrumented', async ({ page }) => {
test('Sends API route error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Sentry API Route Test Error';
});
Expand All@@ -81,7 +82,8 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }
type: 'Error',
value: 'Sentry API Route Test Error',
mechanism: {
handled: true,
type: 'auto.middleware.tanstackstart.request',
handled: false,
},
},
],
Expand All@@ -90,3 +92,28 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }

expect(errorEvent.transaction).toBe('GET /api/error');
});

// the sentry global middleware does not capture errors from SSR loader errors since they are serialized before they reach the middleware layer
// this test verifies that the error is in fact not sent to Sentry
test('Does not send SSR loader error to Sentry', async ({ baseURL, page }) => {
Comment thread
nicohrubec marked this conversation as resolved.
let errorEventOccurred = false;

waitForError('tanstackstart-react', event => {
if (!event.type && event.exception?.values?.[0]?.value === 'Sentry SSR Test Error') {
errorEventOccurred = true;
}
return event?.transaction === 'GET /ssr-error';
});

const transactionEventPromise = waitForTransaction('tanstackstart-react', transactionEvent => {
return transactionEvent?.transaction === 'GET /ssr-error';
});

await page.goto('/ssr-error');

await transactionEventPromise;

await (await fetch(`${baseURL}/api/flush`)).text();

expect(errorEventOccurred).toBe(false);
});
12 changes: 12 additions & 0 deletions packages/tanstackstart-react/src/client/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,3 +14,15 @@ export { init } from './sdk';
export function wrapMiddlewaresWithSentry<T extends TanStackMiddlewareBase>(middlewares: Record<string, T>): T[] {
return Object.values(middlewares);
}

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };
5 changes: 4 additions & 1 deletion packages/tanstackstart-react/src/common/types.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
export type TanStackMiddlewareBase = {
options?: { server?: (...args: unknown[]) => unknown };
// eslint-disable-next-line @typescript-eslint/no-explicit-any
'~types': any;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
options: { server?: (...args: any[]) => any };

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript kept complaining in my sample app that the types of the new sentry middlewares clash with what is expected from tanstack (it was still running fine thought), had to change it to this to fix that

Comment thread
nicohrubec marked this conversation as resolved.
};

export type MiddlewareWrapperOptions = {
Expand Down
3 changes: 3 additions & 0 deletions packages/tanstackstart-react/src/index.types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,3 +37,6 @@ export declare const statsigIntegration: typeof clientSdk.statsigIntegration;
export declare const unleashIntegration: typeof clientSdk.unleashIntegration;

export declare const wrapMiddlewaresWithSentry: typeof serverSdk.wrapMiddlewaresWithSentry;

export declare const sentryGlobalRequestMiddleware: typeof serverSdk.sentryGlobalRequestMiddleware;
export declare const sentryGlobalFunctionMiddleware: typeof serverSdk.sentryGlobalFunctionMiddleware;
46 changes: 46 additions & 0 deletions packages/tanstackstart-react/src/server/globalMiddleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
import { addNonEnumerableProperty, captureException } from '@sentry/core';
import type { TanStackMiddlewareBase } from '../common/types';
import { SENTRY_INTERNAL } from './middleware';

function createSentryMiddlewareHandler(mechanismType: string) {
return async function sentryMiddlewareHandler({ next }: { next: () => Promise<unknown> }): Promise<unknown> {
try {
return await next();
} catch (e) {
captureException(e, {
mechanism: { type: mechanismType, handled: false },
});
throw e;
}
};
}
Comment thread
cursor[bot] marked this conversation as resolved.

/**
* Global request middleware that captures errors from API route requests.
* Should be added as the first entry in the `requestMiddleware` array of `createStart()`.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.request') as (...args: any[]) => any,
},
};

/**
* Global function middleware that captures errors from server function invocations.
* Should be added as the first entry in the `functionMiddleware` array of `createStart()`.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.server_function') as (...args: any[]) => any,
},
};

// Mark as internal so the Vite auto-instrumentation plugin skips these middleware
addNonEnumerableProperty(sentryGlobalRequestMiddleware, SENTRY_INTERNAL, true);
addNonEnumerableProperty(sentryGlobalFunctionMiddleware, SENTRY_INTERNAL, true);
1 change: 1 addition & 0 deletions packages/tanstackstart-react/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ export * from '@sentry/node';
export { init } from './sdk';
export { wrapFetchWithSentry } from './wrapFetchWithSentry';
export { wrapMiddlewaresWithSentry } from './middleware';
export { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from './globalMiddleware';

/**
* A passthrough error boundary for the server that doesn't depend on any react. Error boundaries don't catch SSR errors
Expand Down
8 changes: 6 additions & 2 deletions packages/tanstackstart-react/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type { MiddlewareWrapperOptions, TanStackMiddlewareBase } from '../common
import { getMiddlewareSpanOptions } from './utils';

const SENTRY_WRAPPED = '__SENTRY_WRAPPED__';
export const SENTRY_INTERNAL = '__SENTRY_INTERNAL__';

/**
* Creates a proxy for the next function that ends the current span and restores the parent span.
Expand DownExpand Up@@ -39,8 +40,11 @@ function wrapMiddlewareWithSentry<T extends TanStackMiddlewareBase>(
middleware: T,
options: MiddlewareWrapperOptions,
): T {
if ((middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED]) {
// already instrumented
if (
(middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED] ||
(middleware as TanStackMiddlewareBase & { [SENTRY_INTERNAL]?: boolean })[SENTRY_INTERNAL]
) {
// already instrumented or internal Sentry middleware
return middleware;
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
import { afterEach, describe, expect, it, vi } from 'vitest';

const captureExceptionSpy = vi.fn();

vi.mock('@sentry/core', async importOriginal => {
const original = await importOriginal();
return {
...original,
captureException: (...args: unknown[]) => captureExceptionSpy(...args),
};
});

// Import after mocks are set up
const { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } =
await import('../../src/server/globalMiddleware');

describe('sentryGlobalRequestMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalRequestMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.request', handled: false },
});
});

it('does not capture error when next() succeeds', async () => {
const next = vi.fn().mockResolvedValue('success');

const serverFn = sentryGlobalRequestMiddleware.options.server!;
const result = await serverFn({ next });

expect(result).toBe('success');
expect(captureExceptionSpy).not.toHaveBeenCalled();
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalRequestMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});

describe('sentryGlobalFunctionMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalFunctionMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.server_function', handled: false },
});
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalFunctionMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,20 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

- **feat(tanstackstart-react): Add global sentry exception middlewares ([#19330](https://github.com/getsentry/sentry-javascript/pull/19330))**

The `sentryGlobalRequestMiddleware` and `sentryGlobalFunctionMiddleware` global middlewares capture unhandled exceptions thrown in TanStack Start API routes and server functions. Add them as the first entries in the `requestMiddleware` and `functionMiddleware` arrays of `createStart()`:

```ts
import { createStart } from '@tanstack/react-start/server';
import { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from '@sentry/tanstackstart-react/server';

export default createStart({
requestMiddleware: [sentryGlobalRequestMiddleware, myRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, myFunctionMiddleware],
});
```

### Important Changes

- fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 ([#18631](https://github.com/getsentry/sentry-javascript/pull/18631))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
import * as Sentry from '@sentry/tanstackstart-react';
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/api/error')({
server: {
handlers: {
GET: async () => {
try {
throw new Error('Sentry API Route Test Error');
} catch (error) {
Sentry.captureException(error);
throw error;
}
throw new Error('Sentry API Route Test Error');
},
},
},
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import { createFileRoute } from '@tanstack/react-router';
import { flush } from '@sentry/tanstackstart-react';

export const Route = createFileRoute('/api/flush')({
server: {
handlers: {
GET: async () => {
await flush();
return new Response('ok');
},
},
},
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/ssr-error')({
loader: () => {
throw new Error('Sentry SSR Test Error');
},
component: () => <div>SSR Error Page</div>,
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { sentryGlobalFunctionMiddleware, sentryGlobalRequestMiddleware } from '@sentry/tanstackstart-react';
import { createStart } from '@tanstack/react-start';
// NOTE: These are NOT wrapped - auto-instrumentation via the Vite plugin will wrap them
import { globalRequestMiddleware, globalFunctionMiddleware } from './middleware';
import { globalFunctionMiddleware, globalRequestMiddleware } from './middleware';

export const startInstance = createStart(() => {
return {
requestMiddleware: [globalRequestMiddleware],
functionMiddleware: [globalFunctionMiddleware],
requestMiddleware: [sentryGlobalRequestMiddleware, globalRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, globalFunctionMiddleware],
};
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';

test('Sends client-side error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
Expand DownExpand Up@@ -51,17 +51,18 @@ test('Sends server-side function error to Sentry with auto-instrumentation', asy
type: 'Error',
value: 'Sentry Server Function Test Error',
mechanism: {
type: 'auto.middleware.tanstackstart.server_function',
handled: false,
},
},
],
},
});

expect(errorEvent.transaction).toBe('/');
expect(errorEvent.transaction).toEqual(expect.stringContaining('GET /_serverFn/'));
});

test('Sends API route error to Sentry if manually instrumented', async ({ page }) => {
test('Sends API route error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Sentry API Route Test Error';
});
Expand All@@ -81,7 +82,8 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }
type: 'Error',
value: 'Sentry API Route Test Error',
mechanism: {
handled: true,
type: 'auto.middleware.tanstackstart.request',
handled: false,
},
},
],
Expand All@@ -90,3 +92,28 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }

expect(errorEvent.transaction).toBe('GET /api/error');
});

// the sentry global middleware does not capture errors from SSR loader errors since they are serialized before they reach the middleware layer
// this test verifies that the error is in fact not sent to Sentry
test('Does not send SSR loader error to Sentry', async ({ baseURL, page }) => {
Comment thread
nicohrubec marked this conversation as resolved.
let errorEventOccurred = false;

waitForError('tanstackstart-react', event => {
if (!event.type && event.exception?.values?.[0]?.value === 'Sentry SSR Test Error') {
errorEventOccurred = true;
}
return event?.transaction === 'GET /ssr-error';
});

const transactionEventPromise = waitForTransaction('tanstackstart-react', transactionEvent => {
return transactionEvent?.transaction === 'GET /ssr-error';
});

await page.goto('/ssr-error');

await transactionEventPromise;

await (await fetch(`${baseURL}/api/flush`)).text();

expect(errorEventOccurred).toBe(false);
});
12 changes: 12 additions & 0 deletions packages/tanstackstart-react/src/client/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,3 +14,15 @@ export { init } from './sdk';
export function wrapMiddlewaresWithSentry<T extends TanStackMiddlewareBase>(middlewares: Record<string, T>): T[] {
return Object.values(middlewares);
}

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };
5 changes: 4 additions & 1 deletion packages/tanstackstart-react/src/common/types.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
export type TanStackMiddlewareBase = {
options?: { server?: (...args: unknown[]) => unknown };
// eslint-disable-next-line @typescript-eslint/no-explicit-any
'~types': any;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
options: { server?: (...args: any[]) => any };

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript kept complaining in my sample app that the types of the new sentry middlewares clash with what is expected from tanstack (it was still running fine thought), had to change it to this to fix that

Comment thread
nicohrubec marked this conversation as resolved.
};

export type MiddlewareWrapperOptions = {
Expand Down
3 changes: 3 additions & 0 deletions packages/tanstackstart-react/src/index.types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,3 +37,6 @@ export declare const statsigIntegration: typeof clientSdk.statsigIntegration;
export declare const unleashIntegration: typeof clientSdk.unleashIntegration;

export declare const wrapMiddlewaresWithSentry: typeof serverSdk.wrapMiddlewaresWithSentry;

export declare const sentryGlobalRequestMiddleware: typeof serverSdk.sentryGlobalRequestMiddleware;
export declare const sentryGlobalFunctionMiddleware: typeof serverSdk.sentryGlobalFunctionMiddleware;
46 changes: 46 additions & 0 deletions packages/tanstackstart-react/src/server/globalMiddleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
import { addNonEnumerableProperty, captureException } from '@sentry/core';
import type { TanStackMiddlewareBase } from '../common/types';
import { SENTRY_INTERNAL } from './middleware';

function createSentryMiddlewareHandler(mechanismType: string) {
return async function sentryMiddlewareHandler({ next }: { next: () => Promise<unknown> }): Promise<unknown> {
try {
return await next();
} catch (e) {
captureException(e, {
mechanism: { type: mechanismType, handled: false },
});
throw e;
}
};
}
Comment thread
cursor[bot] marked this conversation as resolved.

/**
* Global request middleware that captures errors from API route requests.
* Should be added as the first entry in the `requestMiddleware` array of `createStart()`.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.request') as (...args: any[]) => any,
},
};

/**
* Global function middleware that captures errors from server function invocations.
* Should be added as the first entry in the `functionMiddleware` array of `createStart()`.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.server_function') as (...args: any[]) => any,
},
};

// Mark as internal so the Vite auto-instrumentation plugin skips these middleware
addNonEnumerableProperty(sentryGlobalRequestMiddleware, SENTRY_INTERNAL, true);
addNonEnumerableProperty(sentryGlobalFunctionMiddleware, SENTRY_INTERNAL, true);
1 change: 1 addition & 0 deletions packages/tanstackstart-react/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ export * from '@sentry/node';
export { init } from './sdk';
export { wrapFetchWithSentry } from './wrapFetchWithSentry';
export { wrapMiddlewaresWithSentry } from './middleware';
export { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from './globalMiddleware';

/**
* A passthrough error boundary for the server that doesn't depend on any react. Error boundaries don't catch SSR errors
Expand Down
8 changes: 6 additions & 2 deletions packages/tanstackstart-react/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type { MiddlewareWrapperOptions, TanStackMiddlewareBase } from '../common
import { getMiddlewareSpanOptions } from './utils';

const SENTRY_WRAPPED = '__SENTRY_WRAPPED__';
export const SENTRY_INTERNAL = '__SENTRY_INTERNAL__';

/**
* Creates a proxy for the next function that ends the current span and restores the parent span.
Expand DownExpand Up@@ -39,8 +40,11 @@ function wrapMiddlewareWithSentry<T extends TanStackMiddlewareBase>(
middleware: T,
options: MiddlewareWrapperOptions,
): T {
if ((middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED]) {
// already instrumented
if (
(middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED] ||
(middleware as TanStackMiddlewareBase & { [SENTRY_INTERNAL]?: boolean })[SENTRY_INTERNAL]
) {
// already instrumented or internal Sentry middleware
return middleware;
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
import { afterEach, describe, expect, it, vi } from 'vitest';

const captureExceptionSpy = vi.fn();

vi.mock('@sentry/core', async importOriginal => {
const original = await importOriginal();
return {
...original,
captureException: (...args: unknown[]) => captureExceptionSpy(...args),
};
});

// Import after mocks are set up
const { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } =
await import('../../src/server/globalMiddleware');

describe('sentryGlobalRequestMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalRequestMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.request', handled: false },
});
});

it('does not capture error when next() succeeds', async () => {
const next = vi.fn().mockResolvedValue('success');

const serverFn = sentryGlobalRequestMiddleware.options.server!;
const result = await serverFn({ next });

expect(result).toBe('success');
expect(captureExceptionSpy).not.toHaveBeenCalled();
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalRequestMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});

describe('sentryGlobalFunctionMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalFunctionMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.server_function', handled: false },
});
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalFunctionMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,20 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

- **feat(tanstackstart-react): Add global sentry exception middlewares ([#19330](https://github.com/getsentry/sentry-javascript/pull/19330))**

The `sentryGlobalRequestMiddleware` and `sentryGlobalFunctionMiddleware` global middlewares capture unhandled exceptions thrown in TanStack Start API routes and server functions. Add them as the first entries in the `requestMiddleware` and `functionMiddleware` arrays of `createStart()`:

```ts
import { createStart } from '@tanstack/react-start/server';
import { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from '@sentry/tanstackstart-react/server';

export default createStart({
requestMiddleware: [sentryGlobalRequestMiddleware, myRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, myFunctionMiddleware],
});
```

### Important Changes

- fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 ([#18631](https://github.com/getsentry/sentry-javascript/pull/18631))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
import * as Sentry from '@sentry/tanstackstart-react';
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/api/error')({
server: {
handlers: {
GET: async () => {
try {
throw new Error('Sentry API Route Test Error');
} catch (error) {
Sentry.captureException(error);
throw error;
}
throw new Error('Sentry API Route Test Error');
},
},
},
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import { createFileRoute } from '@tanstack/react-router';
import { flush } from '@sentry/tanstackstart-react';

export const Route = createFileRoute('/api/flush')({
server: {
handlers: {
GET: async () => {
await flush();
return new Response('ok');
},
},
},
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/ssr-error')({
loader: () => {
throw new Error('Sentry SSR Test Error');
},
component: () => <div>SSR Error Page</div>,
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { sentryGlobalFunctionMiddleware, sentryGlobalRequestMiddleware } from '@sentry/tanstackstart-react';
import { createStart } from '@tanstack/react-start';
// NOTE: These are NOT wrapped - auto-instrumentation via the Vite plugin will wrap them
import { globalRequestMiddleware, globalFunctionMiddleware } from './middleware';
import { globalFunctionMiddleware, globalRequestMiddleware } from './middleware';

export const startInstance = createStart(() => {
return {
requestMiddleware: [globalRequestMiddleware],
functionMiddleware: [globalFunctionMiddleware],
requestMiddleware: [sentryGlobalRequestMiddleware, globalRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, globalFunctionMiddleware],
};
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';

test('Sends client-side error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
Expand DownExpand Up@@ -51,17 +51,18 @@ test('Sends server-side function error to Sentry with auto-instrumentation', asy
type: 'Error',
value: 'Sentry Server Function Test Error',
mechanism: {
type: 'auto.middleware.tanstackstart.server_function',
handled: false,
},
},
],
},
});

expect(errorEvent.transaction).toBe('/');
expect(errorEvent.transaction).toEqual(expect.stringContaining('GET /_serverFn/'));
});

test('Sends API route error to Sentry if manually instrumented', async ({ page }) => {
test('Sends API route error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Sentry API Route Test Error';
});
Expand All@@ -81,7 +82,8 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }
type: 'Error',
value: 'Sentry API Route Test Error',
mechanism: {
handled: true,
type: 'auto.middleware.tanstackstart.request',
handled: false,
},
},
],
Expand All@@ -90,3 +92,28 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }

expect(errorEvent.transaction).toBe('GET /api/error');
});

// the sentry global middleware does not capture errors from SSR loader errors since they are serialized before they reach the middleware layer
// this test verifies that the error is in fact not sent to Sentry
test('Does not send SSR loader error to Sentry', async ({ baseURL, page }) => {
Comment thread
nicohrubec marked this conversation as resolved.
let errorEventOccurred = false;

waitForError('tanstackstart-react', event => {
if (!event.type && event.exception?.values?.[0]?.value === 'Sentry SSR Test Error') {
errorEventOccurred = true;
}
return event?.transaction === 'GET /ssr-error';
});

const transactionEventPromise = waitForTransaction('tanstackstart-react', transactionEvent => {
return transactionEvent?.transaction === 'GET /ssr-error';
});

await page.goto('/ssr-error');

await transactionEventPromise;

await (await fetch(`${baseURL}/api/flush`)).text();

expect(errorEventOccurred).toBe(false);
});
12 changes: 12 additions & 0 deletions packages/tanstackstart-react/src/client/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,3 +14,15 @@ export { init } from './sdk';
export function wrapMiddlewaresWithSentry<T extends TanStackMiddlewareBase>(middlewares: Record<string, T>): T[] {
return Object.values(middlewares);
}

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };
5 changes: 4 additions & 1 deletion packages/tanstackstart-react/src/common/types.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
export type TanStackMiddlewareBase = {
options?: { server?: (...args: unknown[]) => unknown };
// eslint-disable-next-line @typescript-eslint/no-explicit-any
'~types': any;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
options: { server?: (...args: any[]) => any };

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript kept complaining in my sample app that the types of the new sentry middlewares clash with what is expected from tanstack (it was still running fine thought), had to change it to this to fix that

Comment thread
nicohrubec marked this conversation as resolved.
};

export type MiddlewareWrapperOptions = {
Expand Down
3 changes: 3 additions & 0 deletions packages/tanstackstart-react/src/index.types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,3 +37,6 @@ export declare const statsigIntegration: typeof clientSdk.statsigIntegration;
export declare const unleashIntegration: typeof clientSdk.unleashIntegration;

export declare const wrapMiddlewaresWithSentry: typeof serverSdk.wrapMiddlewaresWithSentry;

export declare const sentryGlobalRequestMiddleware: typeof serverSdk.sentryGlobalRequestMiddleware;
export declare const sentryGlobalFunctionMiddleware: typeof serverSdk.sentryGlobalFunctionMiddleware;
46 changes: 46 additions & 0 deletions packages/tanstackstart-react/src/server/globalMiddleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
import { addNonEnumerableProperty, captureException } from '@sentry/core';
import type { TanStackMiddlewareBase } from '../common/types';
import { SENTRY_INTERNAL } from './middleware';

function createSentryMiddlewareHandler(mechanismType: string) {
return async function sentryMiddlewareHandler({ next }: { next: () => Promise<unknown> }): Promise<unknown> {
try {
return await next();
} catch (e) {
captureException(e, {
mechanism: { type: mechanismType, handled: false },
});
throw e;
}
};
}
Comment thread
cursor[bot] marked this conversation as resolved.

/**
* Global request middleware that captures errors from API route requests.
* Should be added as the first entry in the `requestMiddleware` array of `createStart()`.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.request') as (...args: any[]) => any,
},
};

/**
* Global function middleware that captures errors from server function invocations.
* Should be added as the first entry in the `functionMiddleware` array of `createStart()`.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.server_function') as (...args: any[]) => any,
},
};

// Mark as internal so the Vite auto-instrumentation plugin skips these middleware
addNonEnumerableProperty(sentryGlobalRequestMiddleware, SENTRY_INTERNAL, true);
addNonEnumerableProperty(sentryGlobalFunctionMiddleware, SENTRY_INTERNAL, true);
1 change: 1 addition & 0 deletions packages/tanstackstart-react/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ export * from '@sentry/node';
export { init } from './sdk';
export { wrapFetchWithSentry } from './wrapFetchWithSentry';
export { wrapMiddlewaresWithSentry } from './middleware';
export { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from './globalMiddleware';

/**
* A passthrough error boundary for the server that doesn't depend on any react. Error boundaries don't catch SSR errors
Expand Down
8 changes: 6 additions & 2 deletions packages/tanstackstart-react/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type { MiddlewareWrapperOptions, TanStackMiddlewareBase } from '../common
import { getMiddlewareSpanOptions } from './utils';

const SENTRY_WRAPPED = '__SENTRY_WRAPPED__';
export const SENTRY_INTERNAL = '__SENTRY_INTERNAL__';

/**
* Creates a proxy for the next function that ends the current span and restores the parent span.
Expand DownExpand Up@@ -39,8 +40,11 @@ function wrapMiddlewareWithSentry<T extends TanStackMiddlewareBase>(
middleware: T,
options: MiddlewareWrapperOptions,
): T {
if ((middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED]) {
// already instrumented
if (
(middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED] ||
(middleware as TanStackMiddlewareBase & { [SENTRY_INTERNAL]?: boolean })[SENTRY_INTERNAL]
) {
// already instrumented or internal Sentry middleware
return middleware;
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
import { afterEach, describe, expect, it, vi } from 'vitest';

const captureExceptionSpy = vi.fn();

vi.mock('@sentry/core', async importOriginal => {
const original = await importOriginal();
return {
...original,
captureException: (...args: unknown[]) => captureExceptionSpy(...args),
};
});

// Import after mocks are set up
const { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } =
await import('../../src/server/globalMiddleware');

describe('sentryGlobalRequestMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalRequestMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.request', handled: false },
});
});

it('does not capture error when next() succeeds', async () => {
const next = vi.fn().mockResolvedValue('success');

const serverFn = sentryGlobalRequestMiddleware.options.server!;
const result = await serverFn({ next });

expect(result).toBe('success');
expect(captureExceptionSpy).not.toHaveBeenCalled();
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalRequestMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});

describe('sentryGlobalFunctionMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalFunctionMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.server_function', handled: false },
});
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalFunctionMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,20 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

- **feat(tanstackstart-react): Add global sentry exception middlewares ([#19330](https://github.com/getsentry/sentry-javascript/pull/19330))**

The `sentryGlobalRequestMiddleware` and `sentryGlobalFunctionMiddleware` global middlewares capture unhandled exceptions thrown in TanStack Start API routes and server functions. Add them as the first entries in the `requestMiddleware` and `functionMiddleware` arrays of `createStart()`:

```ts
import { createStart } from '@tanstack/react-start/server';
import { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from '@sentry/tanstackstart-react/server';

export default createStart({
requestMiddleware: [sentryGlobalRequestMiddleware, myRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, myFunctionMiddleware],
});
```

### Important Changes

- fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 ([#18631](https://github.com/getsentry/sentry-javascript/pull/18631))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
import * as Sentry from '@sentry/tanstackstart-react';
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/api/error')({
server: {
handlers: {
GET: async () => {
try {
throw new Error('Sentry API Route Test Error');
} catch (error) {
Sentry.captureException(error);
throw error;
}
throw new Error('Sentry API Route Test Error');
},
},
},
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import { createFileRoute } from '@tanstack/react-router';
import { flush } from '@sentry/tanstackstart-react';

export const Route = createFileRoute('/api/flush')({
server: {
handlers: {
GET: async () => {
await flush();
return new Response('ok');
},
},
},
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/ssr-error')({
loader: () => {
throw new Error('Sentry SSR Test Error');
},
component: () => <div>SSR Error Page</div>,
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { sentryGlobalFunctionMiddleware, sentryGlobalRequestMiddleware } from '@sentry/tanstackstart-react';
import { createStart } from '@tanstack/react-start';
// NOTE: These are NOT wrapped - auto-instrumentation via the Vite plugin will wrap them
import { globalRequestMiddleware, globalFunctionMiddleware } from './middleware';
import { globalFunctionMiddleware, globalRequestMiddleware } from './middleware';

export const startInstance = createStart(() => {
return {
requestMiddleware: [globalRequestMiddleware],
functionMiddleware: [globalFunctionMiddleware],
requestMiddleware: [sentryGlobalRequestMiddleware, globalRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, globalFunctionMiddleware],
};
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';

test('Sends client-side error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
Expand DownExpand Up@@ -51,17 +51,18 @@ test('Sends server-side function error to Sentry with auto-instrumentation', asy
type: 'Error',
value: 'Sentry Server Function Test Error',
mechanism: {
type: 'auto.middleware.tanstackstart.server_function',
handled: false,
},
},
],
},
});

expect(errorEvent.transaction).toBe('/');
expect(errorEvent.transaction).toEqual(expect.stringContaining('GET /_serverFn/'));
});

test('Sends API route error to Sentry if manually instrumented', async ({ page }) => {
test('Sends API route error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Sentry API Route Test Error';
});
Expand All@@ -81,7 +82,8 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }
type: 'Error',
value: 'Sentry API Route Test Error',
mechanism: {
handled: true,
type: 'auto.middleware.tanstackstart.request',
handled: false,
},
},
],
Expand All@@ -90,3 +92,28 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }

expect(errorEvent.transaction).toBe('GET /api/error');
});

// the sentry global middleware does not capture errors from SSR loader errors since they are serialized before they reach the middleware layer
// this test verifies that the error is in fact not sent to Sentry
test('Does not send SSR loader error to Sentry', async ({ baseURL, page }) => {
Comment thread
nicohrubec marked this conversation as resolved.
let errorEventOccurred = false;

waitForError('tanstackstart-react', event => {
if (!event.type && event.exception?.values?.[0]?.value === 'Sentry SSR Test Error') {
errorEventOccurred = true;
}
return event?.transaction === 'GET /ssr-error';
});

const transactionEventPromise = waitForTransaction('tanstackstart-react', transactionEvent => {
return transactionEvent?.transaction === 'GET /ssr-error';
});

await page.goto('/ssr-error');

await transactionEventPromise;

await (await fetch(`${baseURL}/api/flush`)).text();

expect(errorEventOccurred).toBe(false);
});
12 changes: 12 additions & 0 deletions packages/tanstackstart-react/src/client/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,3 +14,15 @@ export { init } from './sdk';
export function wrapMiddlewaresWithSentry<T extends TanStackMiddlewareBase>(middlewares: Record<string, T>): T[] {
return Object.values(middlewares);
}

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };
5 changes: 4 additions & 1 deletion packages/tanstackstart-react/src/common/types.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
export type TanStackMiddlewareBase = {
options?: { server?: (...args: unknown[]) => unknown };
// eslint-disable-next-line @typescript-eslint/no-explicit-any
'~types': any;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
options: { server?: (...args: any[]) => any };

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript kept complaining in my sample app that the types of the new sentry middlewares clash with what is expected from tanstack (it was still running fine thought), had to change it to this to fix that

Comment thread
nicohrubec marked this conversation as resolved.
};

export type MiddlewareWrapperOptions = {
Expand Down
3 changes: 3 additions & 0 deletions packages/tanstackstart-react/src/index.types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,3 +37,6 @@ export declare const statsigIntegration: typeof clientSdk.statsigIntegration;
export declare const unleashIntegration: typeof clientSdk.unleashIntegration;

export declare const wrapMiddlewaresWithSentry: typeof serverSdk.wrapMiddlewaresWithSentry;

export declare const sentryGlobalRequestMiddleware: typeof serverSdk.sentryGlobalRequestMiddleware;
export declare const sentryGlobalFunctionMiddleware: typeof serverSdk.sentryGlobalFunctionMiddleware;
46 changes: 46 additions & 0 deletions packages/tanstackstart-react/src/server/globalMiddleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
import { addNonEnumerableProperty, captureException } from '@sentry/core';
import type { TanStackMiddlewareBase } from '../common/types';
import { SENTRY_INTERNAL } from './middleware';

function createSentryMiddlewareHandler(mechanismType: string) {
return async function sentryMiddlewareHandler({ next }: { next: () => Promise<unknown> }): Promise<unknown> {
try {
return await next();
} catch (e) {
captureException(e, {
mechanism: { type: mechanismType, handled: false },
});
throw e;
}
};
}
Comment thread
cursor[bot] marked this conversation as resolved.

/**
* Global request middleware that captures errors from API route requests.
* Should be added as the first entry in the `requestMiddleware` array of `createStart()`.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.request') as (...args: any[]) => any,
},
};

/**
* Global function middleware that captures errors from server function invocations.
* Should be added as the first entry in the `functionMiddleware` array of `createStart()`.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.server_function') as (...args: any[]) => any,
},
};

// Mark as internal so the Vite auto-instrumentation plugin skips these middleware
addNonEnumerableProperty(sentryGlobalRequestMiddleware, SENTRY_INTERNAL, true);
addNonEnumerableProperty(sentryGlobalFunctionMiddleware, SENTRY_INTERNAL, true);
1 change: 1 addition & 0 deletions packages/tanstackstart-react/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ export * from '@sentry/node';
export { init } from './sdk';
export { wrapFetchWithSentry } from './wrapFetchWithSentry';
export { wrapMiddlewaresWithSentry } from './middleware';
export { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from './globalMiddleware';

/**
* A passthrough error boundary for the server that doesn't depend on any react. Error boundaries don't catch SSR errors
Expand Down
8 changes: 6 additions & 2 deletions packages/tanstackstart-react/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type { MiddlewareWrapperOptions, TanStackMiddlewareBase } from '../common
import { getMiddlewareSpanOptions } from './utils';

const SENTRY_WRAPPED = '__SENTRY_WRAPPED__';
export const SENTRY_INTERNAL = '__SENTRY_INTERNAL__';

/**
* Creates a proxy for the next function that ends the current span and restores the parent span.
Expand DownExpand Up@@ -39,8 +40,11 @@ function wrapMiddlewareWithSentry<T extends TanStackMiddlewareBase>(
middleware: T,
options: MiddlewareWrapperOptions,
): T {
if ((middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED]) {
// already instrumented
if (
(middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED] ||
(middleware as TanStackMiddlewareBase & { [SENTRY_INTERNAL]?: boolean })[SENTRY_INTERNAL]
) {
// already instrumented or internal Sentry middleware
return middleware;
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
import { afterEach, describe, expect, it, vi } from 'vitest';

const captureExceptionSpy = vi.fn();

vi.mock('@sentry/core', async importOriginal => {
const original = await importOriginal();
return {
...original,
captureException: (...args: unknown[]) => captureExceptionSpy(...args),
};
});

// Import after mocks are set up
const { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } =
await import('../../src/server/globalMiddleware');

describe('sentryGlobalRequestMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalRequestMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.request', handled: false },
});
});

it('does not capture error when next() succeeds', async () => {
const next = vi.fn().mockResolvedValue('success');

const serverFn = sentryGlobalRequestMiddleware.options.server!;
const result = await serverFn({ next });

expect(result).toBe('success');
expect(captureExceptionSpy).not.toHaveBeenCalled();
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalRequestMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});

describe('sentryGlobalFunctionMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalFunctionMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.server_function', handled: false },
});
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalFunctionMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,20 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

- **feat(tanstackstart-react): Add global sentry exception middlewares ([#19330](https://github.com/getsentry/sentry-javascript/pull/19330))**

The `sentryGlobalRequestMiddleware` and `sentryGlobalFunctionMiddleware` global middlewares capture unhandled exceptions thrown in TanStack Start API routes and server functions. Add them as the first entries in the `requestMiddleware` and `functionMiddleware` arrays of `createStart()`:

```ts
import { createStart } from '@tanstack/react-start/server';
import { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from '@sentry/tanstackstart-react/server';

export default createStart({
requestMiddleware: [sentryGlobalRequestMiddleware, myRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, myFunctionMiddleware],
});
```

### Important Changes

- fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 ([#18631](https://github.com/getsentry/sentry-javascript/pull/18631))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
import * as Sentry from '@sentry/tanstackstart-react';
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/api/error')({
server: {
handlers: {
GET: async () => {
try {
throw new Error('Sentry API Route Test Error');
} catch (error) {
Sentry.captureException(error);
throw error;
}
throw new Error('Sentry API Route Test Error');
},
},
},
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import { createFileRoute } from '@tanstack/react-router';
import { flush } from '@sentry/tanstackstart-react';

export const Route = createFileRoute('/api/flush')({
server: {
handlers: {
GET: async () => {
await flush();
return new Response('ok');
},
},
},
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/ssr-error')({
loader: () => {
throw new Error('Sentry SSR Test Error');
},
component: () => <div>SSR Error Page</div>,
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { sentryGlobalFunctionMiddleware, sentryGlobalRequestMiddleware } from '@sentry/tanstackstart-react';
import { createStart } from '@tanstack/react-start';
// NOTE: These are NOT wrapped - auto-instrumentation via the Vite plugin will wrap them
import { globalRequestMiddleware, globalFunctionMiddleware } from './middleware';
import { globalFunctionMiddleware, globalRequestMiddleware } from './middleware';

export const startInstance = createStart(() => {
return {
requestMiddleware: [globalRequestMiddleware],
functionMiddleware: [globalFunctionMiddleware],
requestMiddleware: [sentryGlobalRequestMiddleware, globalRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, globalFunctionMiddleware],
};
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';

test('Sends client-side error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
Expand DownExpand Up@@ -51,17 +51,18 @@ test('Sends server-side function error to Sentry with auto-instrumentation', asy
type: 'Error',
value: 'Sentry Server Function Test Error',
mechanism: {
type: 'auto.middleware.tanstackstart.server_function',
handled: false,
},
},
],
},
});

expect(errorEvent.transaction).toBe('/');
expect(errorEvent.transaction).toEqual(expect.stringContaining('GET /_serverFn/'));
});

test('Sends API route error to Sentry if manually instrumented', async ({ page }) => {
test('Sends API route error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Sentry API Route Test Error';
});
Expand All@@ -81,7 +82,8 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }
type: 'Error',
value: 'Sentry API Route Test Error',
mechanism: {
handled: true,
type: 'auto.middleware.tanstackstart.request',
handled: false,
},
},
],
Expand All@@ -90,3 +92,28 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }

expect(errorEvent.transaction).toBe('GET /api/error');
});

// the sentry global middleware does not capture errors from SSR loader errors since they are serialized before they reach the middleware layer
// this test verifies that the error is in fact not sent to Sentry
test('Does not send SSR loader error to Sentry', async ({ baseURL, page }) => {
Comment thread
nicohrubec marked this conversation as resolved.
let errorEventOccurred = false;

waitForError('tanstackstart-react', event => {
if (!event.type && event.exception?.values?.[0]?.value === 'Sentry SSR Test Error') {
errorEventOccurred = true;
}
return event?.transaction === 'GET /ssr-error';
});

const transactionEventPromise = waitForTransaction('tanstackstart-react', transactionEvent => {
return transactionEvent?.transaction === 'GET /ssr-error';
});

await page.goto('/ssr-error');

await transactionEventPromise;

await (await fetch(`${baseURL}/api/flush`)).text();

expect(errorEventOccurred).toBe(false);
});
12 changes: 12 additions & 0 deletions packages/tanstackstart-react/src/client/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,3 +14,15 @@ export { init } from './sdk';
export function wrapMiddlewaresWithSentry<T extends TanStackMiddlewareBase>(middlewares: Record<string, T>): T[] {
return Object.values(middlewares);
}

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };
5 changes: 4 additions & 1 deletion packages/tanstackstart-react/src/common/types.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
export type TanStackMiddlewareBase = {
options?: { server?: (...args: unknown[]) => unknown };
// eslint-disable-next-line @typescript-eslint/no-explicit-any
'~types': any;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
options: { server?: (...args: any[]) => any };

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript kept complaining in my sample app that the types of the new sentry middlewares clash with what is expected from tanstack (it was still running fine thought), had to change it to this to fix that

Comment thread
nicohrubec marked this conversation as resolved.
};

export type MiddlewareWrapperOptions = {
Expand Down
3 changes: 3 additions & 0 deletions packages/tanstackstart-react/src/index.types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,3 +37,6 @@ export declare const statsigIntegration: typeof clientSdk.statsigIntegration;
export declare const unleashIntegration: typeof clientSdk.unleashIntegration;

export declare const wrapMiddlewaresWithSentry: typeof serverSdk.wrapMiddlewaresWithSentry;

export declare const sentryGlobalRequestMiddleware: typeof serverSdk.sentryGlobalRequestMiddleware;
export declare const sentryGlobalFunctionMiddleware: typeof serverSdk.sentryGlobalFunctionMiddleware;
46 changes: 46 additions & 0 deletions packages/tanstackstart-react/src/server/globalMiddleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
import { addNonEnumerableProperty, captureException } from '@sentry/core';
import type { TanStackMiddlewareBase } from '../common/types';
import { SENTRY_INTERNAL } from './middleware';

function createSentryMiddlewareHandler(mechanismType: string) {
return async function sentryMiddlewareHandler({ next }: { next: () => Promise<unknown> }): Promise<unknown> {
try {
return await next();
} catch (e) {
captureException(e, {
mechanism: { type: mechanismType, handled: false },
});
throw e;
}
};
}
Comment thread
cursor[bot] marked this conversation as resolved.

/**
* Global request middleware that captures errors from API route requests.
* Should be added as the first entry in the `requestMiddleware` array of `createStart()`.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.request') as (...args: any[]) => any,
},
};

/**
* Global function middleware that captures errors from server function invocations.
* Should be added as the first entry in the `functionMiddleware` array of `createStart()`.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.server_function') as (...args: any[]) => any,
},
};

// Mark as internal so the Vite auto-instrumentation plugin skips these middleware
addNonEnumerableProperty(sentryGlobalRequestMiddleware, SENTRY_INTERNAL, true);
addNonEnumerableProperty(sentryGlobalFunctionMiddleware, SENTRY_INTERNAL, true);
1 change: 1 addition & 0 deletions packages/tanstackstart-react/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ export * from '@sentry/node';
export { init } from './sdk';
export { wrapFetchWithSentry } from './wrapFetchWithSentry';
export { wrapMiddlewaresWithSentry } from './middleware';
export { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from './globalMiddleware';

/**
* A passthrough error boundary for the server that doesn't depend on any react. Error boundaries don't catch SSR errors
Expand Down
8 changes: 6 additions & 2 deletions packages/tanstackstart-react/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type { MiddlewareWrapperOptions, TanStackMiddlewareBase } from '../common
import { getMiddlewareSpanOptions } from './utils';

const SENTRY_WRAPPED = '__SENTRY_WRAPPED__';
export const SENTRY_INTERNAL = '__SENTRY_INTERNAL__';

/**
* Creates a proxy for the next function that ends the current span and restores the parent span.
Expand DownExpand Up@@ -39,8 +40,11 @@ function wrapMiddlewareWithSentry<T extends TanStackMiddlewareBase>(
middleware: T,
options: MiddlewareWrapperOptions,
): T {
if ((middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED]) {
// already instrumented
if (
(middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED] ||
(middleware as TanStackMiddlewareBase & { [SENTRY_INTERNAL]?: boolean })[SENTRY_INTERNAL]
) {
// already instrumented or internal Sentry middleware
return middleware;
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
import { afterEach, describe, expect, it, vi } from 'vitest';

const captureExceptionSpy = vi.fn();

vi.mock('@sentry/core', async importOriginal => {
const original = await importOriginal();
return {
...original,
captureException: (...args: unknown[]) => captureExceptionSpy(...args),
};
});

// Import after mocks are set up
const { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } =
await import('../../src/server/globalMiddleware');

describe('sentryGlobalRequestMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalRequestMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.request', handled: false },
});
});

it('does not capture error when next() succeeds', async () => {
const next = vi.fn().mockResolvedValue('success');

const serverFn = sentryGlobalRequestMiddleware.options.server!;
const result = await serverFn({ next });

expect(result).toBe('success');
expect(captureExceptionSpy).not.toHaveBeenCalled();
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalRequestMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});

describe('sentryGlobalFunctionMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalFunctionMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.server_function', handled: false },
});
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalFunctionMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,20 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

- **feat(tanstackstart-react): Add global sentry exception middlewares ([#19330](https://github.com/getsentry/sentry-javascript/pull/19330))**

The `sentryGlobalRequestMiddleware` and `sentryGlobalFunctionMiddleware` global middlewares capture unhandled exceptions thrown in TanStack Start API routes and server functions. Add them as the first entries in the `requestMiddleware` and `functionMiddleware` arrays of `createStart()`:

```ts
import { createStart } from '@tanstack/react-start/server';
import { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from '@sentry/tanstackstart-react/server';

export default createStart({
requestMiddleware: [sentryGlobalRequestMiddleware, myRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, myFunctionMiddleware],
});
```

### Important Changes

- fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 ([#18631](https://github.com/getsentry/sentry-javascript/pull/18631))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
import * as Sentry from '@sentry/tanstackstart-react';
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/api/error')({
server: {
handlers: {
GET: async () => {
try {
throw new Error('Sentry API Route Test Error');
} catch (error) {
Sentry.captureException(error);
throw error;
}
throw new Error('Sentry API Route Test Error');
},
},
},
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import { createFileRoute } from '@tanstack/react-router';
import { flush } from '@sentry/tanstackstart-react';

export const Route = createFileRoute('/api/flush')({
server: {
handlers: {
GET: async () => {
await flush();
return new Response('ok');
},
},
},
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/ssr-error')({
loader: () => {
throw new Error('Sentry SSR Test Error');
},
component: () => <div>SSR Error Page</div>,
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { sentryGlobalFunctionMiddleware, sentryGlobalRequestMiddleware } from '@sentry/tanstackstart-react';
import { createStart } from '@tanstack/react-start';
// NOTE: These are NOT wrapped - auto-instrumentation via the Vite plugin will wrap them
import { globalRequestMiddleware, globalFunctionMiddleware } from './middleware';
import { globalFunctionMiddleware, globalRequestMiddleware } from './middleware';

export const startInstance = createStart(() => {
return {
requestMiddleware: [globalRequestMiddleware],
functionMiddleware: [globalFunctionMiddleware],
requestMiddleware: [sentryGlobalRequestMiddleware, globalRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, globalFunctionMiddleware],
};
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';

test('Sends client-side error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
Expand DownExpand Up@@ -51,17 +51,18 @@ test('Sends server-side function error to Sentry with auto-instrumentation', asy
type: 'Error',
value: 'Sentry Server Function Test Error',
mechanism: {
type: 'auto.middleware.tanstackstart.server_function',
handled: false,
},
},
],
},
});

expect(errorEvent.transaction).toBe('/');
expect(errorEvent.transaction).toEqual(expect.stringContaining('GET /_serverFn/'));
});

test('Sends API route error to Sentry if manually instrumented', async ({ page }) => {
test('Sends API route error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Sentry API Route Test Error';
});
Expand All@@ -81,7 +82,8 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }
type: 'Error',
value: 'Sentry API Route Test Error',
mechanism: {
handled: true,
type: 'auto.middleware.tanstackstart.request',
handled: false,
},
},
],
Expand All@@ -90,3 +92,28 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }

expect(errorEvent.transaction).toBe('GET /api/error');
});

// the sentry global middleware does not capture errors from SSR loader errors since they are serialized before they reach the middleware layer
// this test verifies that the error is in fact not sent to Sentry
test('Does not send SSR loader error to Sentry', async ({ baseURL, page }) => {
Comment thread
nicohrubec marked this conversation as resolved.
let errorEventOccurred = false;

waitForError('tanstackstart-react', event => {
if (!event.type && event.exception?.values?.[0]?.value === 'Sentry SSR Test Error') {
errorEventOccurred = true;
}
return event?.transaction === 'GET /ssr-error';
});

const transactionEventPromise = waitForTransaction('tanstackstart-react', transactionEvent => {
return transactionEvent?.transaction === 'GET /ssr-error';
});

await page.goto('/ssr-error');

await transactionEventPromise;

await (await fetch(`${baseURL}/api/flush`)).text();

expect(errorEventOccurred).toBe(false);
});
12 changes: 12 additions & 0 deletions packages/tanstackstart-react/src/client/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,3 +14,15 @@ export { init } from './sdk';
export function wrapMiddlewaresWithSentry<T extends TanStackMiddlewareBase>(middlewares: Record<string, T>): T[] {
return Object.values(middlewares);
}

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };
5 changes: 4 additions & 1 deletion packages/tanstackstart-react/src/common/types.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
export type TanStackMiddlewareBase = {
options?: { server?: (...args: unknown[]) => unknown };
// eslint-disable-next-line @typescript-eslint/no-explicit-any
'~types': any;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
options: { server?: (...args: any[]) => any };

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript kept complaining in my sample app that the types of the new sentry middlewares clash with what is expected from tanstack (it was still running fine thought), had to change it to this to fix that

Comment thread
nicohrubec marked this conversation as resolved.
};

export type MiddlewareWrapperOptions = {
Expand Down
3 changes: 3 additions & 0 deletions packages/tanstackstart-react/src/index.types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,3 +37,6 @@ export declare const statsigIntegration: typeof clientSdk.statsigIntegration;
export declare const unleashIntegration: typeof clientSdk.unleashIntegration;

export declare const wrapMiddlewaresWithSentry: typeof serverSdk.wrapMiddlewaresWithSentry;

export declare const sentryGlobalRequestMiddleware: typeof serverSdk.sentryGlobalRequestMiddleware;
export declare const sentryGlobalFunctionMiddleware: typeof serverSdk.sentryGlobalFunctionMiddleware;
46 changes: 46 additions & 0 deletions packages/tanstackstart-react/src/server/globalMiddleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
import { addNonEnumerableProperty, captureException } from '@sentry/core';
import type { TanStackMiddlewareBase } from '../common/types';
import { SENTRY_INTERNAL } from './middleware';

function createSentryMiddlewareHandler(mechanismType: string) {
return async function sentryMiddlewareHandler({ next }: { next: () => Promise<unknown> }): Promise<unknown> {
try {
return await next();
} catch (e) {
captureException(e, {
mechanism: { type: mechanismType, handled: false },
});
throw e;
}
};
}
Comment thread
cursor[bot] marked this conversation as resolved.

/**
* Global request middleware that captures errors from API route requests.
* Should be added as the first entry in the `requestMiddleware` array of `createStart()`.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.request') as (...args: any[]) => any,
},
};

/**
* Global function middleware that captures errors from server function invocations.
* Should be added as the first entry in the `functionMiddleware` array of `createStart()`.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.server_function') as (...args: any[]) => any,
},
};

// Mark as internal so the Vite auto-instrumentation plugin skips these middleware
addNonEnumerableProperty(sentryGlobalRequestMiddleware, SENTRY_INTERNAL, true);
addNonEnumerableProperty(sentryGlobalFunctionMiddleware, SENTRY_INTERNAL, true);
1 change: 1 addition & 0 deletions packages/tanstackstart-react/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ export * from '@sentry/node';
export { init } from './sdk';
export { wrapFetchWithSentry } from './wrapFetchWithSentry';
export { wrapMiddlewaresWithSentry } from './middleware';
export { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from './globalMiddleware';

/**
* A passthrough error boundary for the server that doesn't depend on any react. Error boundaries don't catch SSR errors
Expand Down
8 changes: 6 additions & 2 deletions packages/tanstackstart-react/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type { MiddlewareWrapperOptions, TanStackMiddlewareBase } from '../common
import { getMiddlewareSpanOptions } from './utils';

const SENTRY_WRAPPED = '__SENTRY_WRAPPED__';
export const SENTRY_INTERNAL = '__SENTRY_INTERNAL__';

/**
* Creates a proxy for the next function that ends the current span and restores the parent span.
Expand DownExpand Up@@ -39,8 +40,11 @@ function wrapMiddlewareWithSentry<T extends TanStackMiddlewareBase>(
middleware: T,
options: MiddlewareWrapperOptions,
): T {
if ((middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED]) {
// already instrumented
if (
(middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED] ||
(middleware as TanStackMiddlewareBase & { [SENTRY_INTERNAL]?: boolean })[SENTRY_INTERNAL]
) {
// already instrumented or internal Sentry middleware
return middleware;
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
import { afterEach, describe, expect, it, vi } from 'vitest';

const captureExceptionSpy = vi.fn();

vi.mock('@sentry/core', async importOriginal => {
const original = await importOriginal();
return {
...original,
captureException: (...args: unknown[]) => captureExceptionSpy(...args),
};
});

// Import after mocks are set up
const { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } =
await import('../../src/server/globalMiddleware');

describe('sentryGlobalRequestMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalRequestMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.request', handled: false },
});
});

it('does not capture error when next() succeeds', async () => {
const next = vi.fn().mockResolvedValue('success');

const serverFn = sentryGlobalRequestMiddleware.options.server!;
const result = await serverFn({ next });

expect(result).toBe('success');
expect(captureExceptionSpy).not.toHaveBeenCalled();
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalRequestMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});

describe('sentryGlobalFunctionMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalFunctionMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.server_function', handled: false },
});
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalFunctionMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,20 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

- **feat(tanstackstart-react): Add global sentry exception middlewares ([#19330](https://github.com/getsentry/sentry-javascript/pull/19330))**

The `sentryGlobalRequestMiddleware` and `sentryGlobalFunctionMiddleware` global middlewares capture unhandled exceptions thrown in TanStack Start API routes and server functions. Add them as the first entries in the `requestMiddleware` and `functionMiddleware` arrays of `createStart()`:

```ts
import { createStart } from '@tanstack/react-start/server';
import { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from '@sentry/tanstackstart-react/server';

export default createStart({
requestMiddleware: [sentryGlobalRequestMiddleware, myRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, myFunctionMiddleware],
});
```

### Important Changes

- fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 ([#18631](https://github.com/getsentry/sentry-javascript/pull/18631))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
import * as Sentry from '@sentry/tanstackstart-react';
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/api/error')({
server: {
handlers: {
GET: async () => {
try {
throw new Error('Sentry API Route Test Error');
} catch (error) {
Sentry.captureException(error);
throw error;
}
throw new Error('Sentry API Route Test Error');
},
},
},
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import { createFileRoute } from '@tanstack/react-router';
import { flush } from '@sentry/tanstackstart-react';

export const Route = createFileRoute('/api/flush')({
server: {
handlers: {
GET: async () => {
await flush();
return new Response('ok');
},
},
},
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
import { createFileRoute } from '@tanstack/react-router';

export const Route = createFileRoute('/ssr-error')({
loader: () => {
throw new Error('Sentry SSR Test Error');
},
component: () => <div>SSR Error Page</div>,
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import { sentryGlobalFunctionMiddleware, sentryGlobalRequestMiddleware } from '@sentry/tanstackstart-react';
import { createStart } from '@tanstack/react-start';
// NOTE: These are NOT wrapped - auto-instrumentation via the Vite plugin will wrap them
import { globalRequestMiddleware, globalFunctionMiddleware } from './middleware';
import { globalFunctionMiddleware, globalRequestMiddleware } from './middleware';

export const startInstance = createStart(() => {
return {
requestMiddleware: [globalRequestMiddleware],
functionMiddleware: [globalFunctionMiddleware],
requestMiddleware: [sentryGlobalRequestMiddleware, globalRequestMiddleware],
functionMiddleware: [sentryGlobalFunctionMiddleware, globalFunctionMiddleware],
};
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';

test('Sends client-side error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
Expand DownExpand Up@@ -51,17 +51,18 @@ test('Sends server-side function error to Sentry with auto-instrumentation', asy
type: 'Error',
value: 'Sentry Server Function Test Error',
mechanism: {
type: 'auto.middleware.tanstackstart.server_function',
handled: false,
},
},
],
},
});

expect(errorEvent.transaction).toBe('/');
expect(errorEvent.transaction).toEqual(expect.stringContaining('GET /_serverFn/'));
});

test('Sends API route error to Sentry if manually instrumented', async ({ page }) => {
test('Sends API route error to Sentry with auto-instrumentation', async ({ page }) => {
const errorEventPromise = waitForError('tanstackstart-react', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Sentry API Route Test Error';
});
Expand All@@ -81,7 +82,8 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }
type: 'Error',
value: 'Sentry API Route Test Error',
mechanism: {
handled: true,
type: 'auto.middleware.tanstackstart.request',
handled: false,
},
},
],
Expand All@@ -90,3 +92,28 @@ test('Sends API route error to Sentry if manually instrumented', async ({ page }

expect(errorEvent.transaction).toBe('GET /api/error');
});

// the sentry global middleware does not capture errors from SSR loader errors since they are serialized before they reach the middleware layer
// this test verifies that the error is in fact not sent to Sentry
test('Does not send SSR loader error to Sentry', async ({ baseURL, page }) => {
Comment thread
nicohrubec marked this conversation as resolved.
let errorEventOccurred = false;

waitForError('tanstackstart-react', event => {
if (!event.type && event.exception?.values?.[0]?.value === 'Sentry SSR Test Error') {
errorEventOccurred = true;
}
return event?.transaction === 'GET /ssr-error';
});

const transactionEventPromise = waitForTransaction('tanstackstart-react', transactionEvent => {
return transactionEvent?.transaction === 'GET /ssr-error';
});

await page.goto('/ssr-error');

await transactionEventPromise;

await (await fetch(`${baseURL}/api/flush`)).text();

expect(errorEventOccurred).toBe(false);
});
12 changes: 12 additions & 0 deletions packages/tanstackstart-react/src/client/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,3 +14,15 @@ export { init } from './sdk';
export function wrapMiddlewaresWithSentry<T extends TanStackMiddlewareBase>(middlewares: Record<string, T>): T[] {
return Object.values(middlewares);
}

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };

/**
* No-op stub for client-side builds.
* The actual implementation is server-only, but this stub is needed to prevent rendering errors.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = { '~types': undefined, options: {} };
5 changes: 4 additions & 1 deletion packages/tanstackstart-react/src/common/types.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
export type TanStackMiddlewareBase = {
options?: { server?: (...args: unknown[]) => unknown };
// eslint-disable-next-line @typescript-eslint/no-explicit-any
'~types': any;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
options: { server?: (...args: any[]) => any };

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript kept complaining in my sample app that the types of the new sentry middlewares clash with what is expected from tanstack (it was still running fine thought), had to change it to this to fix that

Comment thread
nicohrubec marked this conversation as resolved.
};

export type MiddlewareWrapperOptions = {
Expand Down
3 changes: 3 additions & 0 deletions packages/tanstackstart-react/src/index.types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,3 +37,6 @@ export declare const statsigIntegration: typeof clientSdk.statsigIntegration;
export declare const unleashIntegration: typeof clientSdk.unleashIntegration;

export declare const wrapMiddlewaresWithSentry: typeof serverSdk.wrapMiddlewaresWithSentry;

export declare const sentryGlobalRequestMiddleware: typeof serverSdk.sentryGlobalRequestMiddleware;
export declare const sentryGlobalFunctionMiddleware: typeof serverSdk.sentryGlobalFunctionMiddleware;
46 changes: 46 additions & 0 deletions packages/tanstackstart-react/src/server/globalMiddleware.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
import { addNonEnumerableProperty, captureException } from '@sentry/core';
import type { TanStackMiddlewareBase } from '../common/types';
import { SENTRY_INTERNAL } from './middleware';

function createSentryMiddlewareHandler(mechanismType: string) {
return async function sentryMiddlewareHandler({ next }: { next: () => Promise<unknown> }): Promise<unknown> {
try {
return await next();
} catch (e) {
captureException(e, {
mechanism: { type: mechanismType, handled: false },
});
throw e;
}
};
}
Comment thread
cursor[bot] marked this conversation as resolved.

/**
* Global request middleware that captures errors from API route requests.
* Should be added as the first entry in the `requestMiddleware` array of `createStart()`.
*/
export const sentryGlobalRequestMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.request') as (...args: any[]) => any,
},
};

/**
* Global function middleware that captures errors from server function invocations.
* Should be added as the first entry in the `functionMiddleware` array of `createStart()`.
*/
export const sentryGlobalFunctionMiddleware: TanStackMiddlewareBase = {
'~types': undefined,

options: {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
server: createSentryMiddlewareHandler('auto.middleware.tanstackstart.server_function') as (...args: any[]) => any,
},
};

// Mark as internal so the Vite auto-instrumentation plugin skips these middleware
addNonEnumerableProperty(sentryGlobalRequestMiddleware, SENTRY_INTERNAL, true);
addNonEnumerableProperty(sentryGlobalFunctionMiddleware, SENTRY_INTERNAL, true);
1 change: 1 addition & 0 deletions packages/tanstackstart-react/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ export * from '@sentry/node';
export { init } from './sdk';
export { wrapFetchWithSentry } from './wrapFetchWithSentry';
export { wrapMiddlewaresWithSentry } from './middleware';
export { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from './globalMiddleware';

/**
* A passthrough error boundary for the server that doesn't depend on any react. Error boundaries don't catch SSR errors
Expand Down
8 changes: 6 additions & 2 deletions packages/tanstackstart-react/src/server/middleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ import type { MiddlewareWrapperOptions, TanStackMiddlewareBase } from '../common
import { getMiddlewareSpanOptions } from './utils';

const SENTRY_WRAPPED = '__SENTRY_WRAPPED__';
export const SENTRY_INTERNAL = '__SENTRY_INTERNAL__';

/**
* Creates a proxy for the next function that ends the current span and restores the parent span.
Expand DownExpand Up@@ -39,8 +40,11 @@ function wrapMiddlewareWithSentry<T extends TanStackMiddlewareBase>(
middleware: T,
options: MiddlewareWrapperOptions,
): T {
if ((middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED]) {
// already instrumented
if (
(middleware as TanStackMiddlewareBase & { [SENTRY_WRAPPED]?: boolean })[SENTRY_WRAPPED] ||
(middleware as TanStackMiddlewareBase & { [SENTRY_INTERNAL]?: boolean })[SENTRY_INTERNAL]
) {
// already instrumented or internal Sentry middleware
return middleware;
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
import { afterEach, describe, expect, it, vi } from 'vitest';

const captureExceptionSpy = vi.fn();

vi.mock('@sentry/core', async importOriginal => {
const original = await importOriginal();
return {
...original,
captureException: (...args: unknown[]) => captureExceptionSpy(...args),
};
});

// Import after mocks are set up
const { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } =
await import('../../src/server/globalMiddleware');

describe('sentryGlobalRequestMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalRequestMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.request', handled: false },
});
});

it('does not capture error when next() succeeds', async () => {
const next = vi.fn().mockResolvedValue('success');

const serverFn = sentryGlobalRequestMiddleware.options.server!;
const result = await serverFn({ next });

expect(result).toBe('success');
expect(captureExceptionSpy).not.toHaveBeenCalled();
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalRequestMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});

describe('sentryGlobalFunctionMiddleware', () => {
afterEach(() => {
vi.clearAllMocks();
});

it('captures error with correct mechanism when next() throws', async () => {
const error = new Error('test error');
const next = vi.fn().mockRejectedValue(error);

const serverFn = sentryGlobalFunctionMiddleware.options.server!;

await expect(serverFn({ next })).rejects.toThrow('test error');

expect(captureExceptionSpy).toHaveBeenCalledWith(error, {
mechanism: { type: 'auto.middleware.tanstackstart.server_function', handled: false },
});
});

it('has __SENTRY_INTERNAL__ flag set', () => {
expect((sentryGlobalFunctionMiddleware as unknown as Record<string, unknown>)['__SENTRY_INTERNAL__']).toBe(true);
});
});
Loading