ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
onurtemizkan wants to merge 3 commits into from
Closed

ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
740fb77
ref(react): Remove lazy route machinery in favour of `lazyRouteManifest`
onurtemizkan Feb 23, 2026
8487544
Fix manifest fallback to set scope transaction name without activeRoo…
onurtemizkan Feb 23, 2026
0e3a747
Add manifest fallback for navigation spans
onurtemizkan Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,28 +13,15 @@ import {
import Index from './pages/Index';
import Deep from './pages/Deep';

function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number } {
function getRuntimeConfig(): { idleTimeout?: number } {
if (typeof window === 'undefined') {
return {};
}

try {
const url = new URL(window.location.href);
const timeoutParam = url.searchParams.get('timeout');
const idleTimeoutParam = url.searchParams.get('idleTimeout');

let lazyRouteTimeout: number | undefined = undefined;
if (timeoutParam) {
if (timeoutParam === 'Infinity') {
lazyRouteTimeout = Infinity;
} else {
const parsed = parseInt(timeoutParam, 10);
if (!isNaN(parsed)) {
lazyRouteTimeout = parsed;
}
}
}

let idleTimeout: number | undefined = undefined;
if (idleTimeoutParam) {
const parsed = parseInt(idleTimeoutParam, 10);
Expand All@@ -44,7 +31,6 @@ function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number }
}

return {
lazyRouteTimeout,
idleTimeout,
};
} catch (error) {
Expand DownExpand Up@@ -87,7 +73,6 @@ Sentry.init({
matchRoutes,
trackFetchStreamPerformance: true,
enableAsyncRouteHandlers: true,
lazyRouteTimeout: runtimeConfig.lazyRouteTimeout,
idleTimeout: runtimeConfig.idleTimeout,
lazyRouteManifest,
}),
Expand Down
54 changes: 2 additions & 52 deletions ...es/e2e-tests/test-applications/react-router-7-lazy-routes/tests/timeout-behaviour.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,6 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

test('lazyRouteTimeout: Routes load within timeout window', async ({ page }) => {
const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
return (
!!transactionEvent?.transaction &&
transactionEvent.contexts?.trace?.op === 'navigation' &&
transactionEvent.transaction.includes('deep')
);
});

// Route takes ~900ms, timeout allows 1050ms (50 + 1000)
// Routes will load in time → parameterized name
await page.goto('/?idleTimeout=50&timeout=1000');

const navigationLink = page.locator('id=navigation-to-deep');
await expect(navigationLink).toBeVisible();
await navigationLink.click();

const event = await transactionPromise;

// Should get full parameterized route
expect(event.transaction).toBe('/deep/level2/level3/:id');
expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('lazyRouteTimeout: Infinity timeout always waits for routes', async ({ page }) => {
const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
return (
!!transactionEvent?.transaction &&
transactionEvent.contexts?.trace?.op === 'navigation' &&
transactionEvent.transaction.includes('deep')
);
});

// Infinity timeout → waits as long as possible (capped at finalTimeout to prevent indefinite hangs)
await page.goto('/?idleTimeout=50&timeout=Infinity');

const navigationLink = page.locator('id=navigation-to-deep');
await expect(navigationLink).toBeVisible();
await navigationLink.click();

const event = await transactionPromise;

// Should wait for routes to load (up to finalTimeout) and get full route
expect(event.transaction).toBe('/deep/level2/level3/:id');
expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('idleTimeout: Captures all activity with increased timeout', async ({ page }) => {
const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
return (
Expand DownExpand Up@@ -87,9 +38,8 @@ test('idleTimeout: Finishes prematurely with low timeout', async ({ page }) => {
);
});

// Very low idleTimeout (50ms) and lazyRouteTimeout (100ms)
// Transaction finishes quickly, but still gets parameterized route name
await page.goto('/?idleTimeout=50&timeout=100');
// Very low idleTimeout (50ms) -- transaction finishes quickly but still gets parameterized route name
await page.goto('/?idleTimeout=50');

const navigationLink = page.locator('id=navigation-to-deep');
await expect(navigationLink).toBeVisible();
Expand Down
75 changes: 11 additions & 64 deletions ...ackages/e2e-tests/test-applications/react-router-7-lazy-routes/tests/transactions.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -427,8 +427,7 @@ test('Updates pageload transaction name correctly when span is cancelled early (
// Check if the span was indeed cancelled (should have idle_span_finish_reason attribute)
const idleSpanFinishReason = event.contexts?.trace?.data?.['sentry.idle_span_finish_reason'];
if (idleSpanFinishReason) {
// If the span was cancelled due to visibility change, verify it still got the right name
expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
}
});

Expand DownExpand Up@@ -498,7 +497,7 @@ test('Updates navigation transaction name correctly when span is cancelled early
}

if (idleSpanFinishReason) {
expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
}
});

Expand DownExpand Up@@ -1034,9 +1033,11 @@ test('Three-route rapid navigation preserves distinct transaction names', async
await slowFetchLink.click();
await page.waitForTimeout(150);

// Navigate to another-lazy before slow-fetch resolves
const anotherLazyLink = page.locator('id=delayed-lazy-to-another-lazy');
await anotherLazyLink.click();
// Navigate to another-lazy before slow-fetch resolves.
// Use programmatic navigation because the delayed-lazy page may have
// already unmounted (the /slow-fetch route has no element).
// eslint-disable-next-line no-restricted-globals
await page.evaluate(() => (window as any).__REACT_ROUTER__.navigate('/another-lazy/sub'));

await expect(page.locator('id=another-lazy-route')).toBeVisible({ timeout: 10000 });
await page.waitForTimeout(2000);
Expand DownExpand Up@@ -1241,8 +1242,8 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
);
});

// idleTimeout=300 ends span before 500ms lazy route loads, timeout=1000 waits for lazy routes
await page.goto('/slow-fetch/123?idleTimeout=300&timeout=1000');
// idleTimeout=300 ends span before 500ms lazy route loads
await page.goto('/slow-fetch/123?idleTimeout=300');

const event = await transactionPromise;

Expand All@@ -1255,60 +1256,6 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
expect(['idleTimeout', 'externalFinish']).toContain(idleSpanFinishReason);
});

// Regression: Wildcard route names should be upgraded to parameterized routes when lazy routes load
test('Wildcard route pageload gets upgraded to parameterized route name (regression)', async ({ page }) => {
const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
return (
!!transactionEvent?.transaction &&
transactionEvent.contexts?.trace?.op === 'pageload' &&
(transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
);
});

await page.goto('/wildcard-lazy/456?idleTimeout=300&timeout=1000');

const event = await transactionPromise;

expect(event.transaction).toBe('/wildcard-lazy/:id');
expect(event.type).toBe('transaction');
expect(event.contexts?.trace?.op).toBe('pageload');
expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

// Regression: Navigation to slow lazy route should get parameterized name even if span ends early.
// Network activity from dynamic imports extends the idle timeout until lazy routes load.
test('Slow lazy route navigation with early span end still gets parameterized route name (regression)', async ({
page,
}) => {
// Configure short idle timeout (300ms) but longer lazy route timeout (1000ms)
await page.goto('/?idleTimeout=300&timeout=1000');

// Wait for pageload to complete
await page.waitForTimeout(500);

const navigationPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
return (
!!transactionEvent?.transaction &&
transactionEvent.contexts?.trace?.op === 'navigation' &&
(transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
);
});

// Navigate to wildcard-lazy route (500ms delay in module via top-level await)
// The dynamic import creates network activity that extends the span lifetime
const wildcardLazyLink = page.locator('id=navigation-to-wildcard-lazy');
await expect(wildcardLazyLink).toBeVisible();
await wildcardLazyLink.click();

const event = await navigationPromise;

// The navigation transaction should have the parameterized route name
expect(event.transaction).toBe('/wildcard-lazy/:id');
expect(event.type).toBe('transaction');
expect(event.contexts?.trace?.op).toBe('navigation');
expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

test('Captured navigation context is used instead of stale window.location during rapid navigation', async ({
page,
}) => {
Expand DownExpand Up@@ -1437,7 +1384,7 @@ test('Second navigation span is not corrupted by first slow lazy handler complet
// lazyRouteManifest: provides parameterized name when lazy routes don't resolve in time
test('Route manifest provides correct name when navigation span ends before lazy route resolves', async ({ page }) => {
// Short idle timeout (50ms) ensures span ends before lazy route (500ms) resolves
await page.goto('/?idleTimeout=50&timeout=0');
await page.goto('/?idleTimeout=50');

// Wait for pageload to complete
await page.waitForTimeout(200);
Expand DownExpand Up@@ -1474,7 +1421,7 @@ test('Route manifest provides correct name when pageload span ends before lazy r
);
});

await page.goto('/wildcard-lazy/123?idleTimeout=50&timeout=0');
await page.goto('/wildcard-lazy/123?idleTimeout=50');

const event = await pageloadPromise;

Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
740fb77

ref(react): Remove lazy route machinery in favour of `lazyRouteManifest`


onurtemizkan Feb 23, 2026
8487544

Fix manifest fallback to set scope transaction name without activeRoo…


onurtemizkan Feb 23, 2026
0e3a747

Add manifest fallback for navigation spans


onurtemizkan Feb 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 1 addition & 16 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,28 +13,15 @@ import {
import Index from './pages/Index';
import Deep from './pages/Deep';

function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number } {
function getRuntimeConfig(): { idleTimeout?: number } {
 if (typeof window === 'undefined') {
 return {};
 }

 try {
 const url = new URL(window.location.href);
 const timeoutParam = url.searchParams.get('timeout');
 const idleTimeoutParam = url.searchParams.get('idleTimeout');

 let lazyRouteTimeout: number | undefined = undefined;
 if (timeoutParam) {
 if (timeoutParam === 'Infinity') {
 lazyRouteTimeout = Infinity;
 } else {
 const parsed = parseInt(timeoutParam, 10);
 if (!isNaN(parsed)) {
 lazyRouteTimeout = parsed;
 }
 }
 }

 let idleTimeout: number | undefined = undefined;
 if (idleTimeoutParam) {
 const parsed = parseInt(idleTimeoutParam, 10);
Expand All@@ -44,7 +31,6 @@ function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number }
 }

 return {
 lazyRouteTimeout,
 idleTimeout,
 };
 } catch (error) {
Expand DownExpand Up@@ -87,7 +73,6 @@ Sentry.init({
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 lazyRouteTimeout: runtimeConfig.lazyRouteTimeout,
 idleTimeout: runtimeConfig.idleTimeout,
 lazyRouteManifest,
 }),
Expand Down

54 changes: 2 additions & 52 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/tests/timeout-behaviour.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,6 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

test('lazyRouteTimeout: Routes load within timeout window', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Route takes ~900ms, timeout allows 1050ms (50 + 1000)
 // Routes will load in time → parameterized name
 await page.goto('/?idleTimeout=50&timeout=1000');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should get full parameterized route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('lazyRouteTimeout: Infinity timeout always waits for routes', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Infinity timeout → waits as long as possible (capped at finalTimeout to prevent indefinite hangs)
 await page.goto('/?idleTimeout=50&timeout=Infinity');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should wait for routes to load (up to finalTimeout) and get full route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('idleTimeout: Captures all activity with increased timeout', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
Expand DownExpand Up@@ -87,9 +38,8 @@ test('idleTimeout: Finishes prematurely with low timeout', async ({ page }) => {
 );
 });

 // Very low idleTimeout (50ms) and lazyRouteTimeout (100ms)
 // Transaction finishes quickly, but still gets parameterized route name
 await page.goto('/?idleTimeout=50&timeout=100');
 // Very low idleTimeout (50ms) -- transaction finishes quickly but still gets parameterized route name
 await page.goto('/?idleTimeout=50');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
Expand Down

75 changes: 11 additions & 64 deletions
...ackages/e2e-tests/test-applications/react-router-7-lazy-routes/tests/transactions.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,8 +427,7 @@ test('Updates pageload transaction name correctly when span is cancelled early (
 // Check if the span was indeed cancelled (should have idle_span_finish_reason attribute)
 const idleSpanFinishReason = event.contexts?.trace?.data?.['sentry.idle_span_finish_reason'];
 if (idleSpanFinishReason) {
 // If the span was cancelled due to visibility change, verify it still got the right name
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -498,7 +497,7 @@ test('Updates navigation transaction name correctly when span is cancelled early
 }

 if (idleSpanFinishReason) {
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -1034,9 +1033,11 @@ test('Three-route rapid navigation preserves distinct transaction names', async
 await slowFetchLink.click();
 await page.waitForTimeout(150);

 // Navigate to another-lazy before slow-fetch resolves
 const anotherLazyLink = page.locator('id=delayed-lazy-to-another-lazy');
 await anotherLazyLink.click();
 // Navigate to another-lazy before slow-fetch resolves.
 // Use programmatic navigation because the delayed-lazy page may have
 // already unmounted (the /slow-fetch route has no element).
 // eslint-disable-next-line no-restricted-globals
 await page.evaluate(() => (window as any).__REACT_ROUTER__.navigate('/another-lazy/sub'));

 await expect(page.locator('id=another-lazy-route')).toBeVisible({ timeout: 10000 });
 await page.waitForTimeout(2000);
Expand DownExpand Up@@ -1241,8 +1242,8 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 );
 });

 // idleTimeout=300 ends span before 500ms lazy route loads, timeout=1000 waits for lazy routes
 await page.goto('/slow-fetch/123?idleTimeout=300&timeout=1000');
 // idleTimeout=300 ends span before 500ms lazy route loads
 await page.goto('/slow-fetch/123?idleTimeout=300');

 const event = await transactionPromise;

Expand All@@ -1255,60 +1256,6 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 expect(['idleTimeout', 'externalFinish']).toContain(idleSpanFinishReason);
});

// Regression: Wildcard route names should be upgraded to parameterized routes when lazy routes load
test('Wildcard route pageload gets upgraded to parameterized route name (regression)', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'pageload' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 await page.goto('/wildcard-lazy/456?idleTimeout=300&timeout=1000');

 const event = await transactionPromise;

 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('pageload');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

// Regression: Navigation to slow lazy route should get parameterized name even if span ends early.
// Network activity from dynamic imports extends the idle timeout until lazy routes load.
test('Slow lazy route navigation with early span end still gets parameterized route name (regression)', async ({
 page,
}) => {
 // Configure short idle timeout (300ms) but longer lazy route timeout (1000ms)
 await page.goto('/?idleTimeout=300&timeout=1000');

 // Wait for pageload to complete
 await page.waitForTimeout(500);

 const navigationPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 // Navigate to wildcard-lazy route (500ms delay in module via top-level await)
 // The dynamic import creates network activity that extends the span lifetime
 const wildcardLazyLink = page.locator('id=navigation-to-wildcard-lazy');
 await expect(wildcardLazyLink).toBeVisible();
 await wildcardLazyLink.click();

 const event = await navigationPromise;

 // The navigation transaction should have the parameterized route name
 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('navigation');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

test('Captured navigation context is used instead of stale window.location during rapid navigation', async ({
 page,
}) => {
Expand DownExpand Up@@ -1437,7 +1384,7 @@ test('Second navigation span is not corrupted by first slow lazy handler complet
// lazyRouteManifest: provides parameterized name when lazy routes don't resolve in time
test('Route manifest provides correct name when navigation span ends before lazy route resolves', async ({ page }) => {
 // Short idle timeout (50ms) ensures span ends before lazy route (500ms) resolves
 await page.goto('/?idleTimeout=50&timeout=0');
 await page.goto('/?idleTimeout=50');

 // Wait for pageload to complete
 await page.waitForTimeout(200);
Expand DownExpand Up@@ -1474,7 +1421,7 @@ test('Route manifest provides correct name when pageload span ends before lazy r
 );
 });

 await page.goto('/wildcard-lazy/123?idleTimeout=50&timeout=0');
 await page.goto('/wildcard-lazy/123?idleTimeout=50');

 const event = await pageloadPromise;

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
740fb77

ref(react): Remove lazy route machinery in favour of `lazyRouteManifest`


onurtemizkan Feb 23, 2026
8487544

Fix manifest fallback to set scope transaction name without activeRoo…


onurtemizkan Feb 23, 2026
0e3a747

Add manifest fallback for navigation spans


onurtemizkan Feb 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 1 addition & 16 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,28 +13,15 @@ import {
import Index from './pages/Index';
import Deep from './pages/Deep';

function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number } {
function getRuntimeConfig(): { idleTimeout?: number } {
 if (typeof window === 'undefined') {
 return {};
 }

 try {
 const url = new URL(window.location.href);
 const timeoutParam = url.searchParams.get('timeout');
 const idleTimeoutParam = url.searchParams.get('idleTimeout');

 let lazyRouteTimeout: number | undefined = undefined;
 if (timeoutParam) {
 if (timeoutParam === 'Infinity') {
 lazyRouteTimeout = Infinity;
 } else {
 const parsed = parseInt(timeoutParam, 10);
 if (!isNaN(parsed)) {
 lazyRouteTimeout = parsed;
 }
 }
 }

 let idleTimeout: number | undefined = undefined;
 if (idleTimeoutParam) {
 const parsed = parseInt(idleTimeoutParam, 10);
Expand All@@ -44,7 +31,6 @@ function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number }
 }

 return {
 lazyRouteTimeout,
 idleTimeout,
 };
 } catch (error) {
Expand DownExpand Up@@ -87,7 +73,6 @@ Sentry.init({
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 lazyRouteTimeout: runtimeConfig.lazyRouteTimeout,
 idleTimeout: runtimeConfig.idleTimeout,
 lazyRouteManifest,
 }),
Expand Down

54 changes: 2 additions & 52 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/tests/timeout-behaviour.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,6 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

test('lazyRouteTimeout: Routes load within timeout window', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Route takes ~900ms, timeout allows 1050ms (50 + 1000)
 // Routes will load in time → parameterized name
 await page.goto('/?idleTimeout=50&timeout=1000');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should get full parameterized route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('lazyRouteTimeout: Infinity timeout always waits for routes', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Infinity timeout → waits as long as possible (capped at finalTimeout to prevent indefinite hangs)
 await page.goto('/?idleTimeout=50&timeout=Infinity');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should wait for routes to load (up to finalTimeout) and get full route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('idleTimeout: Captures all activity with increased timeout', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
Expand DownExpand Up@@ -87,9 +38,8 @@ test('idleTimeout: Finishes prematurely with low timeout', async ({ page }) => {
 );
 });

 // Very low idleTimeout (50ms) and lazyRouteTimeout (100ms)
 // Transaction finishes quickly, but still gets parameterized route name
 await page.goto('/?idleTimeout=50&timeout=100');
 // Very low idleTimeout (50ms) -- transaction finishes quickly but still gets parameterized route name
 await page.goto('/?idleTimeout=50');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
Expand Down

75 changes: 11 additions & 64 deletions
...ackages/e2e-tests/test-applications/react-router-7-lazy-routes/tests/transactions.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,8 +427,7 @@ test('Updates pageload transaction name correctly when span is cancelled early (
 // Check if the span was indeed cancelled (should have idle_span_finish_reason attribute)
 const idleSpanFinishReason = event.contexts?.trace?.data?.['sentry.idle_span_finish_reason'];
 if (idleSpanFinishReason) {
 // If the span was cancelled due to visibility change, verify it still got the right name
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -498,7 +497,7 @@ test('Updates navigation transaction name correctly when span is cancelled early
 }

 if (idleSpanFinishReason) {
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -1034,9 +1033,11 @@ test('Three-route rapid navigation preserves distinct transaction names', async
 await slowFetchLink.click();
 await page.waitForTimeout(150);

 // Navigate to another-lazy before slow-fetch resolves
 const anotherLazyLink = page.locator('id=delayed-lazy-to-another-lazy');
 await anotherLazyLink.click();
 // Navigate to another-lazy before slow-fetch resolves.
 // Use programmatic navigation because the delayed-lazy page may have
 // already unmounted (the /slow-fetch route has no element).
 // eslint-disable-next-line no-restricted-globals
 await page.evaluate(() => (window as any).__REACT_ROUTER__.navigate('/another-lazy/sub'));

 await expect(page.locator('id=another-lazy-route')).toBeVisible({ timeout: 10000 });
 await page.waitForTimeout(2000);
Expand DownExpand Up@@ -1241,8 +1242,8 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 );
 });

 // idleTimeout=300 ends span before 500ms lazy route loads, timeout=1000 waits for lazy routes
 await page.goto('/slow-fetch/123?idleTimeout=300&timeout=1000');
 // idleTimeout=300 ends span before 500ms lazy route loads
 await page.goto('/slow-fetch/123?idleTimeout=300');

 const event = await transactionPromise;

Expand All@@ -1255,60 +1256,6 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 expect(['idleTimeout', 'externalFinish']).toContain(idleSpanFinishReason);
});

// Regression: Wildcard route names should be upgraded to parameterized routes when lazy routes load
test('Wildcard route pageload gets upgraded to parameterized route name (regression)', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'pageload' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 await page.goto('/wildcard-lazy/456?idleTimeout=300&timeout=1000');

 const event = await transactionPromise;

 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('pageload');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

// Regression: Navigation to slow lazy route should get parameterized name even if span ends early.
// Network activity from dynamic imports extends the idle timeout until lazy routes load.
test('Slow lazy route navigation with early span end still gets parameterized route name (regression)', async ({
 page,
}) => {
 // Configure short idle timeout (300ms) but longer lazy route timeout (1000ms)
 await page.goto('/?idleTimeout=300&timeout=1000');

 // Wait for pageload to complete
 await page.waitForTimeout(500);

 const navigationPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 // Navigate to wildcard-lazy route (500ms delay in module via top-level await)
 // The dynamic import creates network activity that extends the span lifetime
 const wildcardLazyLink = page.locator('id=navigation-to-wildcard-lazy');
 await expect(wildcardLazyLink).toBeVisible();
 await wildcardLazyLink.click();

 const event = await navigationPromise;

 // The navigation transaction should have the parameterized route name
 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('navigation');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

test('Captured navigation context is used instead of stale window.location during rapid navigation', async ({
 page,
}) => {
Expand DownExpand Up@@ -1437,7 +1384,7 @@ test('Second navigation span is not corrupted by first slow lazy handler complet
// lazyRouteManifest: provides parameterized name when lazy routes don't resolve in time
test('Route manifest provides correct name when navigation span ends before lazy route resolves', async ({ page }) => {
 // Short idle timeout (50ms) ensures span ends before lazy route (500ms) resolves
 await page.goto('/?idleTimeout=50&timeout=0');
 await page.goto('/?idleTimeout=50');

 // Wait for pageload to complete
 await page.waitForTimeout(200);
Expand DownExpand Up@@ -1474,7 +1421,7 @@ test('Route manifest provides correct name when pageload span ends before lazy r
 );
 });

 await page.goto('/wildcard-lazy/123?idleTimeout=50&timeout=0');
 await page.goto('/wildcard-lazy/123?idleTimeout=50');

 const event = await pageloadPromise;

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
740fb77

ref(react): Remove lazy route machinery in favour of `lazyRouteManifest`


onurtemizkan Feb 23, 2026
8487544

Fix manifest fallback to set scope transaction name without activeRoo…


onurtemizkan Feb 23, 2026
0e3a747

Add manifest fallback for navigation spans


onurtemizkan Feb 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 1 addition & 16 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,28 +13,15 @@ import {
import Index from './pages/Index';
import Deep from './pages/Deep';

function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number } {
function getRuntimeConfig(): { idleTimeout?: number } {
 if (typeof window === 'undefined') {
 return {};
 }

 try {
 const url = new URL(window.location.href);
 const timeoutParam = url.searchParams.get('timeout');
 const idleTimeoutParam = url.searchParams.get('idleTimeout');

 let lazyRouteTimeout: number | undefined = undefined;
 if (timeoutParam) {
 if (timeoutParam === 'Infinity') {
 lazyRouteTimeout = Infinity;
 } else {
 const parsed = parseInt(timeoutParam, 10);
 if (!isNaN(parsed)) {
 lazyRouteTimeout = parsed;
 }
 }
 }

 let idleTimeout: number | undefined = undefined;
 if (idleTimeoutParam) {
 const parsed = parseInt(idleTimeoutParam, 10);
Expand All@@ -44,7 +31,6 @@ function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number }
 }

 return {
 lazyRouteTimeout,
 idleTimeout,
 };
 } catch (error) {
Expand DownExpand Up@@ -87,7 +73,6 @@ Sentry.init({
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 lazyRouteTimeout: runtimeConfig.lazyRouteTimeout,
 idleTimeout: runtimeConfig.idleTimeout,
 lazyRouteManifest,
 }),
Expand Down

54 changes: 2 additions & 52 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/tests/timeout-behaviour.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,6 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

test('lazyRouteTimeout: Routes load within timeout window', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Route takes ~900ms, timeout allows 1050ms (50 + 1000)
 // Routes will load in time → parameterized name
 await page.goto('/?idleTimeout=50&timeout=1000');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should get full parameterized route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('lazyRouteTimeout: Infinity timeout always waits for routes', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Infinity timeout → waits as long as possible (capped at finalTimeout to prevent indefinite hangs)
 await page.goto('/?idleTimeout=50&timeout=Infinity');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should wait for routes to load (up to finalTimeout) and get full route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('idleTimeout: Captures all activity with increased timeout', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
Expand DownExpand Up@@ -87,9 +38,8 @@ test('idleTimeout: Finishes prematurely with low timeout', async ({ page }) => {
 );
 });

 // Very low idleTimeout (50ms) and lazyRouteTimeout (100ms)
 // Transaction finishes quickly, but still gets parameterized route name
 await page.goto('/?idleTimeout=50&timeout=100');
 // Very low idleTimeout (50ms) -- transaction finishes quickly but still gets parameterized route name
 await page.goto('/?idleTimeout=50');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
Expand Down

75 changes: 11 additions & 64 deletions
...ackages/e2e-tests/test-applications/react-router-7-lazy-routes/tests/transactions.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,8 +427,7 @@ test('Updates pageload transaction name correctly when span is cancelled early (
 // Check if the span was indeed cancelled (should have idle_span_finish_reason attribute)
 const idleSpanFinishReason = event.contexts?.trace?.data?.['sentry.idle_span_finish_reason'];
 if (idleSpanFinishReason) {
 // If the span was cancelled due to visibility change, verify it still got the right name
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -498,7 +497,7 @@ test('Updates navigation transaction name correctly when span is cancelled early
 }

 if (idleSpanFinishReason) {
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -1034,9 +1033,11 @@ test('Three-route rapid navigation preserves distinct transaction names', async
 await slowFetchLink.click();
 await page.waitForTimeout(150);

 // Navigate to another-lazy before slow-fetch resolves
 const anotherLazyLink = page.locator('id=delayed-lazy-to-another-lazy');
 await anotherLazyLink.click();
 // Navigate to another-lazy before slow-fetch resolves.
 // Use programmatic navigation because the delayed-lazy page may have
 // already unmounted (the /slow-fetch route has no element).
 // eslint-disable-next-line no-restricted-globals
 await page.evaluate(() => (window as any).__REACT_ROUTER__.navigate('/another-lazy/sub'));

 await expect(page.locator('id=another-lazy-route')).toBeVisible({ timeout: 10000 });
 await page.waitForTimeout(2000);
Expand DownExpand Up@@ -1241,8 +1242,8 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 );
 });

 // idleTimeout=300 ends span before 500ms lazy route loads, timeout=1000 waits for lazy routes
 await page.goto('/slow-fetch/123?idleTimeout=300&timeout=1000');
 // idleTimeout=300 ends span before 500ms lazy route loads
 await page.goto('/slow-fetch/123?idleTimeout=300');

 const event = await transactionPromise;

Expand All@@ -1255,60 +1256,6 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 expect(['idleTimeout', 'externalFinish']).toContain(idleSpanFinishReason);
});

// Regression: Wildcard route names should be upgraded to parameterized routes when lazy routes load
test('Wildcard route pageload gets upgraded to parameterized route name (regression)', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'pageload' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 await page.goto('/wildcard-lazy/456?idleTimeout=300&timeout=1000');

 const event = await transactionPromise;

 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('pageload');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

// Regression: Navigation to slow lazy route should get parameterized name even if span ends early.
// Network activity from dynamic imports extends the idle timeout until lazy routes load.
test('Slow lazy route navigation with early span end still gets parameterized route name (regression)', async ({
 page,
}) => {
 // Configure short idle timeout (300ms) but longer lazy route timeout (1000ms)
 await page.goto('/?idleTimeout=300&timeout=1000');

 // Wait for pageload to complete
 await page.waitForTimeout(500);

 const navigationPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 // Navigate to wildcard-lazy route (500ms delay in module via top-level await)
 // The dynamic import creates network activity that extends the span lifetime
 const wildcardLazyLink = page.locator('id=navigation-to-wildcard-lazy');
 await expect(wildcardLazyLink).toBeVisible();
 await wildcardLazyLink.click();

 const event = await navigationPromise;

 // The navigation transaction should have the parameterized route name
 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('navigation');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

test('Captured navigation context is used instead of stale window.location during rapid navigation', async ({
 page,
}) => {
Expand DownExpand Up@@ -1437,7 +1384,7 @@ test('Second navigation span is not corrupted by first slow lazy handler complet
// lazyRouteManifest: provides parameterized name when lazy routes don't resolve in time
test('Route manifest provides correct name when navigation span ends before lazy route resolves', async ({ page }) => {
 // Short idle timeout (50ms) ensures span ends before lazy route (500ms) resolves
 await page.goto('/?idleTimeout=50&timeout=0');
 await page.goto('/?idleTimeout=50');

 // Wait for pageload to complete
 await page.waitForTimeout(200);
Expand DownExpand Up@@ -1474,7 +1421,7 @@ test('Route manifest provides correct name when pageload span ends before lazy r
 );
 });

 await page.goto('/wildcard-lazy/123?idleTimeout=50&timeout=0');
 await page.goto('/wildcard-lazy/123?idleTimeout=50');

 const event = await pageloadPromise;

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
740fb77

ref(react): Remove lazy route machinery in favour of `lazyRouteManifest`


onurtemizkan Feb 23, 2026
8487544

Fix manifest fallback to set scope transaction name without activeRoo…


onurtemizkan Feb 23, 2026
0e3a747

Add manifest fallback for navigation spans


onurtemizkan Feb 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 1 addition & 16 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,28 +13,15 @@ import {
import Index from './pages/Index';
import Deep from './pages/Deep';

function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number } {
function getRuntimeConfig(): { idleTimeout?: number } {
 if (typeof window === 'undefined') {
 return {};
 }

 try {
 const url = new URL(window.location.href);
 const timeoutParam = url.searchParams.get('timeout');
 const idleTimeoutParam = url.searchParams.get('idleTimeout');

 let lazyRouteTimeout: number | undefined = undefined;
 if (timeoutParam) {
 if (timeoutParam === 'Infinity') {
 lazyRouteTimeout = Infinity;
 } else {
 const parsed = parseInt(timeoutParam, 10);
 if (!isNaN(parsed)) {
 lazyRouteTimeout = parsed;
 }
 }
 }

 let idleTimeout: number | undefined = undefined;
 if (idleTimeoutParam) {
 const parsed = parseInt(idleTimeoutParam, 10);
Expand All@@ -44,7 +31,6 @@ function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number }
 }

 return {
 lazyRouteTimeout,
 idleTimeout,
 };
 } catch (error) {
Expand DownExpand Up@@ -87,7 +73,6 @@ Sentry.init({
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 lazyRouteTimeout: runtimeConfig.lazyRouteTimeout,
 idleTimeout: runtimeConfig.idleTimeout,
 lazyRouteManifest,
 }),
Expand Down

54 changes: 2 additions & 52 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/tests/timeout-behaviour.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,6 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

test('lazyRouteTimeout: Routes load within timeout window', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Route takes ~900ms, timeout allows 1050ms (50 + 1000)
 // Routes will load in time → parameterized name
 await page.goto('/?idleTimeout=50&timeout=1000');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should get full parameterized route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('lazyRouteTimeout: Infinity timeout always waits for routes', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Infinity timeout → waits as long as possible (capped at finalTimeout to prevent indefinite hangs)
 await page.goto('/?idleTimeout=50&timeout=Infinity');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should wait for routes to load (up to finalTimeout) and get full route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('idleTimeout: Captures all activity with increased timeout', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
Expand DownExpand Up@@ -87,9 +38,8 @@ test('idleTimeout: Finishes prematurely with low timeout', async ({ page }) => {
 );
 });

 // Very low idleTimeout (50ms) and lazyRouteTimeout (100ms)
 // Transaction finishes quickly, but still gets parameterized route name
 await page.goto('/?idleTimeout=50&timeout=100');
 // Very low idleTimeout (50ms) -- transaction finishes quickly but still gets parameterized route name
 await page.goto('/?idleTimeout=50');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
Expand Down

75 changes: 11 additions & 64 deletions
...ackages/e2e-tests/test-applications/react-router-7-lazy-routes/tests/transactions.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,8 +427,7 @@ test('Updates pageload transaction name correctly when span is cancelled early (
 // Check if the span was indeed cancelled (should have idle_span_finish_reason attribute)
 const idleSpanFinishReason = event.contexts?.trace?.data?.['sentry.idle_span_finish_reason'];
 if (idleSpanFinishReason) {
 // If the span was cancelled due to visibility change, verify it still got the right name
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -498,7 +497,7 @@ test('Updates navigation transaction name correctly when span is cancelled early
 }

 if (idleSpanFinishReason) {
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -1034,9 +1033,11 @@ test('Three-route rapid navigation preserves distinct transaction names', async
 await slowFetchLink.click();
 await page.waitForTimeout(150);

 // Navigate to another-lazy before slow-fetch resolves
 const anotherLazyLink = page.locator('id=delayed-lazy-to-another-lazy');
 await anotherLazyLink.click();
 // Navigate to another-lazy before slow-fetch resolves.
 // Use programmatic navigation because the delayed-lazy page may have
 // already unmounted (the /slow-fetch route has no element).
 // eslint-disable-next-line no-restricted-globals
 await page.evaluate(() => (window as any).__REACT_ROUTER__.navigate('/another-lazy/sub'));

 await expect(page.locator('id=another-lazy-route')).toBeVisible({ timeout: 10000 });
 await page.waitForTimeout(2000);
Expand DownExpand Up@@ -1241,8 +1242,8 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 );
 });

 // idleTimeout=300 ends span before 500ms lazy route loads, timeout=1000 waits for lazy routes
 await page.goto('/slow-fetch/123?idleTimeout=300&timeout=1000');
 // idleTimeout=300 ends span before 500ms lazy route loads
 await page.goto('/slow-fetch/123?idleTimeout=300');

 const event = await transactionPromise;

Expand All@@ -1255,60 +1256,6 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 expect(['idleTimeout', 'externalFinish']).toContain(idleSpanFinishReason);
});

// Regression: Wildcard route names should be upgraded to parameterized routes when lazy routes load
test('Wildcard route pageload gets upgraded to parameterized route name (regression)', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'pageload' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 await page.goto('/wildcard-lazy/456?idleTimeout=300&timeout=1000');

 const event = await transactionPromise;

 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('pageload');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

// Regression: Navigation to slow lazy route should get parameterized name even if span ends early.
// Network activity from dynamic imports extends the idle timeout until lazy routes load.
test('Slow lazy route navigation with early span end still gets parameterized route name (regression)', async ({
 page,
}) => {
 // Configure short idle timeout (300ms) but longer lazy route timeout (1000ms)
 await page.goto('/?idleTimeout=300&timeout=1000');

 // Wait for pageload to complete
 await page.waitForTimeout(500);

 const navigationPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 // Navigate to wildcard-lazy route (500ms delay in module via top-level await)
 // The dynamic import creates network activity that extends the span lifetime
 const wildcardLazyLink = page.locator('id=navigation-to-wildcard-lazy');
 await expect(wildcardLazyLink).toBeVisible();
 await wildcardLazyLink.click();

 const event = await navigationPromise;

 // The navigation transaction should have the parameterized route name
 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('navigation');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

test('Captured navigation context is used instead of stale window.location during rapid navigation', async ({
 page,
}) => {
Expand DownExpand Up@@ -1437,7 +1384,7 @@ test('Second navigation span is not corrupted by first slow lazy handler complet
// lazyRouteManifest: provides parameterized name when lazy routes don't resolve in time
test('Route manifest provides correct name when navigation span ends before lazy route resolves', async ({ page }) => {
 // Short idle timeout (50ms) ensures span ends before lazy route (500ms) resolves
 await page.goto('/?idleTimeout=50&timeout=0');
 await page.goto('/?idleTimeout=50');

 // Wait for pageload to complete
 await page.waitForTimeout(200);
Expand DownExpand Up@@ -1474,7 +1421,7 @@ test('Route manifest provides correct name when pageload span ends before lazy r
 );
 });

 await page.goto('/wildcard-lazy/123?idleTimeout=50&timeout=0');
 await page.goto('/wildcard-lazy/123?idleTimeout=50');

 const event = await pageloadPromise;

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
740fb77

ref(react): Remove lazy route machinery in favour of `lazyRouteManifest`


onurtemizkan Feb 23, 2026
8487544

Fix manifest fallback to set scope transaction name without activeRoo…


onurtemizkan Feb 23, 2026
0e3a747

Add manifest fallback for navigation spans


onurtemizkan Feb 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 1 addition & 16 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,28 +13,15 @@ import {
import Index from './pages/Index';
import Deep from './pages/Deep';

function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number } {
function getRuntimeConfig(): { idleTimeout?: number } {
 if (typeof window === 'undefined') {
 return {};
 }

 try {
 const url = new URL(window.location.href);
 const timeoutParam = url.searchParams.get('timeout');
 const idleTimeoutParam = url.searchParams.get('idleTimeout');

 let lazyRouteTimeout: number | undefined = undefined;
 if (timeoutParam) {
 if (timeoutParam === 'Infinity') {
 lazyRouteTimeout = Infinity;
 } else {
 const parsed = parseInt(timeoutParam, 10);
 if (!isNaN(parsed)) {
 lazyRouteTimeout = parsed;
 }
 }
 }

 let idleTimeout: number | undefined = undefined;
 if (idleTimeoutParam) {
 const parsed = parseInt(idleTimeoutParam, 10);
Expand All@@ -44,7 +31,6 @@ function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number }
 }

 return {
 lazyRouteTimeout,
 idleTimeout,
 };
 } catch (error) {
Expand DownExpand Up@@ -87,7 +73,6 @@ Sentry.init({
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 lazyRouteTimeout: runtimeConfig.lazyRouteTimeout,
 idleTimeout: runtimeConfig.idleTimeout,
 lazyRouteManifest,
 }),
Expand Down

54 changes: 2 additions & 52 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/tests/timeout-behaviour.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,6 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

test('lazyRouteTimeout: Routes load within timeout window', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Route takes ~900ms, timeout allows 1050ms (50 + 1000)
 // Routes will load in time → parameterized name
 await page.goto('/?idleTimeout=50&timeout=1000');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should get full parameterized route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('lazyRouteTimeout: Infinity timeout always waits for routes', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Infinity timeout → waits as long as possible (capped at finalTimeout to prevent indefinite hangs)
 await page.goto('/?idleTimeout=50&timeout=Infinity');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should wait for routes to load (up to finalTimeout) and get full route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('idleTimeout: Captures all activity with increased timeout', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
Expand DownExpand Up@@ -87,9 +38,8 @@ test('idleTimeout: Finishes prematurely with low timeout', async ({ page }) => {
 );
 });

 // Very low idleTimeout (50ms) and lazyRouteTimeout (100ms)
 // Transaction finishes quickly, but still gets parameterized route name
 await page.goto('/?idleTimeout=50&timeout=100');
 // Very low idleTimeout (50ms) -- transaction finishes quickly but still gets parameterized route name
 await page.goto('/?idleTimeout=50');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
Expand Down

75 changes: 11 additions & 64 deletions
...ackages/e2e-tests/test-applications/react-router-7-lazy-routes/tests/transactions.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,8 +427,7 @@ test('Updates pageload transaction name correctly when span is cancelled early (
 // Check if the span was indeed cancelled (should have idle_span_finish_reason attribute)
 const idleSpanFinishReason = event.contexts?.trace?.data?.['sentry.idle_span_finish_reason'];
 if (idleSpanFinishReason) {
 // If the span was cancelled due to visibility change, verify it still got the right name
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -498,7 +497,7 @@ test('Updates navigation transaction name correctly when span is cancelled early
 }

 if (idleSpanFinishReason) {
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -1034,9 +1033,11 @@ test('Three-route rapid navigation preserves distinct transaction names', async
 await slowFetchLink.click();
 await page.waitForTimeout(150);

 // Navigate to another-lazy before slow-fetch resolves
 const anotherLazyLink = page.locator('id=delayed-lazy-to-another-lazy');
 await anotherLazyLink.click();
 // Navigate to another-lazy before slow-fetch resolves.
 // Use programmatic navigation because the delayed-lazy page may have
 // already unmounted (the /slow-fetch route has no element).
 // eslint-disable-next-line no-restricted-globals
 await page.evaluate(() => (window as any).__REACT_ROUTER__.navigate('/another-lazy/sub'));

 await expect(page.locator('id=another-lazy-route')).toBeVisible({ timeout: 10000 });
 await page.waitForTimeout(2000);
Expand DownExpand Up@@ -1241,8 +1242,8 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 );
 });

 // idleTimeout=300 ends span before 500ms lazy route loads, timeout=1000 waits for lazy routes
 await page.goto('/slow-fetch/123?idleTimeout=300&timeout=1000');
 // idleTimeout=300 ends span before 500ms lazy route loads
 await page.goto('/slow-fetch/123?idleTimeout=300');

 const event = await transactionPromise;

Expand All@@ -1255,60 +1256,6 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 expect(['idleTimeout', 'externalFinish']).toContain(idleSpanFinishReason);
});

// Regression: Wildcard route names should be upgraded to parameterized routes when lazy routes load
test('Wildcard route pageload gets upgraded to parameterized route name (regression)', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'pageload' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 await page.goto('/wildcard-lazy/456?idleTimeout=300&timeout=1000');

 const event = await transactionPromise;

 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('pageload');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

// Regression: Navigation to slow lazy route should get parameterized name even if span ends early.
// Network activity from dynamic imports extends the idle timeout until lazy routes load.
test('Slow lazy route navigation with early span end still gets parameterized route name (regression)', async ({
 page,
}) => {
 // Configure short idle timeout (300ms) but longer lazy route timeout (1000ms)
 await page.goto('/?idleTimeout=300&timeout=1000');

 // Wait for pageload to complete
 await page.waitForTimeout(500);

 const navigationPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 // Navigate to wildcard-lazy route (500ms delay in module via top-level await)
 // The dynamic import creates network activity that extends the span lifetime
 const wildcardLazyLink = page.locator('id=navigation-to-wildcard-lazy');
 await expect(wildcardLazyLink).toBeVisible();
 await wildcardLazyLink.click();

 const event = await navigationPromise;

 // The navigation transaction should have the parameterized route name
 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('navigation');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

test('Captured navigation context is used instead of stale window.location during rapid navigation', async ({
 page,
}) => {
Expand DownExpand Up@@ -1437,7 +1384,7 @@ test('Second navigation span is not corrupted by first slow lazy handler complet
// lazyRouteManifest: provides parameterized name when lazy routes don't resolve in time
test('Route manifest provides correct name when navigation span ends before lazy route resolves', async ({ page }) => {
 // Short idle timeout (50ms) ensures span ends before lazy route (500ms) resolves
 await page.goto('/?idleTimeout=50&timeout=0');
 await page.goto('/?idleTimeout=50');

 // Wait for pageload to complete
 await page.waitForTimeout(200);
Expand DownExpand Up@@ -1474,7 +1421,7 @@ test('Route manifest provides correct name when pageload span ends before lazy r
 );
 });

 await page.goto('/wildcard-lazy/123?idleTimeout=50&timeout=0');
 await page.goto('/wildcard-lazy/123?idleTimeout=50');

 const event = await pageloadPromise;

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
740fb77

ref(react): Remove lazy route machinery in favour of `lazyRouteManifest`


onurtemizkan Feb 23, 2026
8487544

Fix manifest fallback to set scope transaction name without activeRoo…


onurtemizkan Feb 23, 2026
0e3a747

Add manifest fallback for navigation spans


onurtemizkan Feb 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 1 addition & 16 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,28 +13,15 @@ import {
import Index from './pages/Index';
import Deep from './pages/Deep';

function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number } {
function getRuntimeConfig(): { idleTimeout?: number } {
 if (typeof window === 'undefined') {
 return {};
 }

 try {
 const url = new URL(window.location.href);
 const timeoutParam = url.searchParams.get('timeout');
 const idleTimeoutParam = url.searchParams.get('idleTimeout');

 let lazyRouteTimeout: number | undefined = undefined;
 if (timeoutParam) {
 if (timeoutParam === 'Infinity') {
 lazyRouteTimeout = Infinity;
 } else {
 const parsed = parseInt(timeoutParam, 10);
 if (!isNaN(parsed)) {
 lazyRouteTimeout = parsed;
 }
 }
 }

 let idleTimeout: number | undefined = undefined;
 if (idleTimeoutParam) {
 const parsed = parseInt(idleTimeoutParam, 10);
Expand All@@ -44,7 +31,6 @@ function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number }
 }

 return {
 lazyRouteTimeout,
 idleTimeout,
 };
 } catch (error) {
Expand DownExpand Up@@ -87,7 +73,6 @@ Sentry.init({
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 lazyRouteTimeout: runtimeConfig.lazyRouteTimeout,
 idleTimeout: runtimeConfig.idleTimeout,
 lazyRouteManifest,
 }),
Expand Down

54 changes: 2 additions & 52 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/tests/timeout-behaviour.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,6 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

test('lazyRouteTimeout: Routes load within timeout window', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Route takes ~900ms, timeout allows 1050ms (50 + 1000)
 // Routes will load in time → parameterized name
 await page.goto('/?idleTimeout=50&timeout=1000');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should get full parameterized route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('lazyRouteTimeout: Infinity timeout always waits for routes', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Infinity timeout → waits as long as possible (capped at finalTimeout to prevent indefinite hangs)
 await page.goto('/?idleTimeout=50&timeout=Infinity');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should wait for routes to load (up to finalTimeout) and get full route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('idleTimeout: Captures all activity with increased timeout', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
Expand DownExpand Up@@ -87,9 +38,8 @@ test('idleTimeout: Finishes prematurely with low timeout', async ({ page }) => {
 );
 });

 // Very low idleTimeout (50ms) and lazyRouteTimeout (100ms)
 // Transaction finishes quickly, but still gets parameterized route name
 await page.goto('/?idleTimeout=50&timeout=100');
 // Very low idleTimeout (50ms) -- transaction finishes quickly but still gets parameterized route name
 await page.goto('/?idleTimeout=50');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
Expand Down

75 changes: 11 additions & 64 deletions
...ackages/e2e-tests/test-applications/react-router-7-lazy-routes/tests/transactions.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,8 +427,7 @@ test('Updates pageload transaction name correctly when span is cancelled early (
 // Check if the span was indeed cancelled (should have idle_span_finish_reason attribute)
 const idleSpanFinishReason = event.contexts?.trace?.data?.['sentry.idle_span_finish_reason'];
 if (idleSpanFinishReason) {
 // If the span was cancelled due to visibility change, verify it still got the right name
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -498,7 +497,7 @@ test('Updates navigation transaction name correctly when span is cancelled early
 }

 if (idleSpanFinishReason) {
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -1034,9 +1033,11 @@ test('Three-route rapid navigation preserves distinct transaction names', async
 await slowFetchLink.click();
 await page.waitForTimeout(150);

 // Navigate to another-lazy before slow-fetch resolves
 const anotherLazyLink = page.locator('id=delayed-lazy-to-another-lazy');
 await anotherLazyLink.click();
 // Navigate to another-lazy before slow-fetch resolves.
 // Use programmatic navigation because the delayed-lazy page may have
 // already unmounted (the /slow-fetch route has no element).
 // eslint-disable-next-line no-restricted-globals
 await page.evaluate(() => (window as any).__REACT_ROUTER__.navigate('/another-lazy/sub'));

 await expect(page.locator('id=another-lazy-route')).toBeVisible({ timeout: 10000 });
 await page.waitForTimeout(2000);
Expand DownExpand Up@@ -1241,8 +1242,8 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 );
 });

 // idleTimeout=300 ends span before 500ms lazy route loads, timeout=1000 waits for lazy routes
 await page.goto('/slow-fetch/123?idleTimeout=300&timeout=1000');
 // idleTimeout=300 ends span before 500ms lazy route loads
 await page.goto('/slow-fetch/123?idleTimeout=300');

 const event = await transactionPromise;

Expand All@@ -1255,60 +1256,6 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 expect(['idleTimeout', 'externalFinish']).toContain(idleSpanFinishReason);
});

// Regression: Wildcard route names should be upgraded to parameterized routes when lazy routes load
test('Wildcard route pageload gets upgraded to parameterized route name (regression)', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'pageload' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 await page.goto('/wildcard-lazy/456?idleTimeout=300&timeout=1000');

 const event = await transactionPromise;

 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('pageload');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

// Regression: Navigation to slow lazy route should get parameterized name even if span ends early.
// Network activity from dynamic imports extends the idle timeout until lazy routes load.
test('Slow lazy route navigation with early span end still gets parameterized route name (regression)', async ({
 page,
}) => {
 // Configure short idle timeout (300ms) but longer lazy route timeout (1000ms)
 await page.goto('/?idleTimeout=300&timeout=1000');

 // Wait for pageload to complete
 await page.waitForTimeout(500);

 const navigationPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 // Navigate to wildcard-lazy route (500ms delay in module via top-level await)
 // The dynamic import creates network activity that extends the span lifetime
 const wildcardLazyLink = page.locator('id=navigation-to-wildcard-lazy');
 await expect(wildcardLazyLink).toBeVisible();
 await wildcardLazyLink.click();

 const event = await navigationPromise;

 // The navigation transaction should have the parameterized route name
 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('navigation');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

test('Captured navigation context is used instead of stale window.location during rapid navigation', async ({
 page,
}) => {
Expand DownExpand Up@@ -1437,7 +1384,7 @@ test('Second navigation span is not corrupted by first slow lazy handler complet
// lazyRouteManifest: provides parameterized name when lazy routes don't resolve in time
test('Route manifest provides correct name when navigation span ends before lazy route resolves', async ({ page }) => {
 // Short idle timeout (50ms) ensures span ends before lazy route (500ms) resolves
 await page.goto('/?idleTimeout=50&timeout=0');
 await page.goto('/?idleTimeout=50');

 // Wait for pageload to complete
 await page.waitForTimeout(200);
Expand DownExpand Up@@ -1474,7 +1421,7 @@ test('Route manifest provides correct name when pageload span ends before lazy r
 );
 });

 await page.goto('/wildcard-lazy/123?idleTimeout=50&timeout=0');
 await page.goto('/wildcard-lazy/123?idleTimeout=50');

 const event = await pageloadPromise;

Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

onurtemizkan
wants to merge
3
commits into

from

 Closed


ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
740fb77

ref(react): Remove lazy route machinery in favour of `lazyRouteManifest`


onurtemizkan Feb 23, 2026
8487544

Fix manifest fallback to set scope transaction name without activeRoo…


onurtemizkan Feb 23, 2026
0e3a747

Add manifest fallback for navigation spans


onurtemizkan Feb 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 1 addition & 16 deletions
dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/src/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,28 +13,15 @@ import {
import Index from './pages/Index';
import Deep from './pages/Deep';

function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number } {
function getRuntimeConfig(): { idleTimeout?: number } {
 if (typeof window === 'undefined') {
 return {};
 }

 try {
 const url = new URL(window.location.href);
 const timeoutParam = url.searchParams.get('timeout');
 const idleTimeoutParam = url.searchParams.get('idleTimeout');

 let lazyRouteTimeout: number | undefined = undefined;
 if (timeoutParam) {
 if (timeoutParam === 'Infinity') {
 lazyRouteTimeout = Infinity;
 } else {
 const parsed = parseInt(timeoutParam, 10);
 if (!isNaN(parsed)) {
 lazyRouteTimeout = parsed;
 }
 }
 }

 let idleTimeout: number | undefined = undefined;
 if (idleTimeoutParam) {
 const parsed = parseInt(idleTimeoutParam, 10);
Expand All@@ -44,7 +31,6 @@ function getRuntimeConfig(): { lazyRouteTimeout?: number; idleTimeout?: number }
 }

 return {
 lazyRouteTimeout,
 idleTimeout,
 };
 } catch (error) {
Expand DownExpand Up@@ -87,7 +73,6 @@ Sentry.init({
 matchRoutes,
 trackFetchStreamPerformance: true,
 enableAsyncRouteHandlers: true,
 lazyRouteTimeout: runtimeConfig.lazyRouteTimeout,
 idleTimeout: runtimeConfig.idleTimeout,
 lazyRouteManifest,
 }),
Expand Down

54 changes: 2 additions & 52 deletions
...es/e2e-tests/test-applications/react-router-7-lazy-routes/tests/timeout-behaviour.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,55 +1,6 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

test('lazyRouteTimeout: Routes load within timeout window', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Route takes ~900ms, timeout allows 1050ms (50 + 1000)
 // Routes will load in time → parameterized name
 await page.goto('/?idleTimeout=50&timeout=1000');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should get full parameterized route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('lazyRouteTimeout: Infinity timeout always waits for routes', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 transactionEvent.transaction.includes('deep')
 );
 });

 // Infinity timeout → waits as long as possible (capped at finalTimeout to prevent indefinite hangs)
 await page.goto('/?idleTimeout=50&timeout=Infinity');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
 await navigationLink.click();

 const event = await transactionPromise;

 // Should wait for routes to load (up to finalTimeout) and get full route
 expect(event.transaction).toBe('/deep/level2/level3/:id');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
 expect(event.contexts?.trace?.data?.['sentry.idle_span_finish_reason']).toBe('idleTimeout');
});

test('idleTimeout: Captures all activity with increased timeout', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
Expand DownExpand Up@@ -87,9 +38,8 @@ test('idleTimeout: Finishes prematurely with low timeout', async ({ page }) => {
 );
 });

 // Very low idleTimeout (50ms) and lazyRouteTimeout (100ms)
 // Transaction finishes quickly, but still gets parameterized route name
 await page.goto('/?idleTimeout=50&timeout=100');
 // Very low idleTimeout (50ms) -- transaction finishes quickly but still gets parameterized route name
 await page.goto('/?idleTimeout=50');

 const navigationLink = page.locator('id=navigation-to-deep');
 await expect(navigationLink).toBeVisible();
Expand Down

75 changes: 11 additions & 64 deletions
...ackages/e2e-tests/test-applications/react-router-7-lazy-routes/tests/transactions.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,8 +427,7 @@ test('Updates pageload transaction name correctly when span is cancelled early (
 // Check if the span was indeed cancelled (should have idle_span_finish_reason attribute)
 const idleSpanFinishReason = event.contexts?.trace?.data?.['sentry.idle_span_finish_reason'];
 if (idleSpanFinishReason) {
 // If the span was cancelled due to visibility change, verify it still got the right name
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -498,7 +497,7 @@ test('Updates navigation transaction name correctly when span is cancelled early
 }

 if (idleSpanFinishReason) {
 expect(['externalFinish', 'cancelled']).toContain(idleSpanFinishReason);
 expect(['externalFinish', 'cancelled', 'idleTimeout']).toContain(idleSpanFinishReason);
 }
});

Expand DownExpand Up@@ -1034,9 +1033,11 @@ test('Three-route rapid navigation preserves distinct transaction names', async
 await slowFetchLink.click();
 await page.waitForTimeout(150);

 // Navigate to another-lazy before slow-fetch resolves
 const anotherLazyLink = page.locator('id=delayed-lazy-to-another-lazy');
 await anotherLazyLink.click();
 // Navigate to another-lazy before slow-fetch resolves.
 // Use programmatic navigation because the delayed-lazy page may have
 // already unmounted (the /slow-fetch route has no element).
 // eslint-disable-next-line no-restricted-globals
 await page.evaluate(() => (window as any).__REACT_ROUTER__.navigate('/another-lazy/sub'));

 await expect(page.locator('id=another-lazy-route')).toBeVisible({ timeout: 10000 });
 await page.waitForTimeout(2000);
Expand DownExpand Up@@ -1241,8 +1242,8 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 );
 });

 // idleTimeout=300 ends span before 500ms lazy route loads, timeout=1000 waits for lazy routes
 await page.goto('/slow-fetch/123?idleTimeout=300&timeout=1000');
 // idleTimeout=300 ends span before 500ms lazy route loads
 await page.goto('/slow-fetch/123?idleTimeout=300');

 const event = await transactionPromise;

Expand All@@ -1255,60 +1256,6 @@ test('Slow lazy route pageload with early span end still gets parameterized rout
 expect(['idleTimeout', 'externalFinish']).toContain(idleSpanFinishReason);
});

// Regression: Wildcard route names should be upgraded to parameterized routes when lazy routes load
test('Wildcard route pageload gets upgraded to parameterized route name (regression)', async ({ page }) => {
 const transactionPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'pageload' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 await page.goto('/wildcard-lazy/456?idleTimeout=300&timeout=1000');

 const event = await transactionPromise;

 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('pageload');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

// Regression: Navigation to slow lazy route should get parameterized name even if span ends early.
// Network activity from dynamic imports extends the idle timeout until lazy routes load.
test('Slow lazy route navigation with early span end still gets parameterized route name (regression)', async ({
 page,
}) => {
 // Configure short idle timeout (300ms) but longer lazy route timeout (1000ms)
 await page.goto('/?idleTimeout=300&timeout=1000');

 // Wait for pageload to complete
 await page.waitForTimeout(500);

 const navigationPromise = waitForTransaction('react-router-7-lazy-routes', async transactionEvent => {
 return (
 !!transactionEvent?.transaction &&
 transactionEvent.contexts?.trace?.op === 'navigation' &&
 (transactionEvent.transaction?.startsWith('/wildcard-lazy') ?? false)
 );
 });

 // Navigate to wildcard-lazy route (500ms delay in module via top-level await)
 // The dynamic import creates network activity that extends the span lifetime
 const wildcardLazyLink = page.locator('id=navigation-to-wildcard-lazy');
 await expect(wildcardLazyLink).toBeVisible();
 await wildcardLazyLink.click();

 const event = await navigationPromise;

 // The navigation transaction should have the parameterized route name
 expect(event.transaction).toBe('/wildcard-lazy/:id');
 expect(event.type).toBe('transaction');
 expect(event.contexts?.trace?.op).toBe('navigation');
 expect(event.contexts?.trace?.data?.['sentry.source']).toBe('route');
});

test('Captured navigation context is used instead of stale window.location during rapid navigation', async ({
 page,
}) => {
Expand DownExpand Up@@ -1437,7 +1384,7 @@ test('Second navigation span is not corrupted by first slow lazy handler complet
// lazyRouteManifest: provides parameterized name when lazy routes don't resolve in time
test('Route manifest provides correct name when navigation span ends before lazy route resolves', async ({ page }) => {
 // Short idle timeout (50ms) ensures span ends before lazy route (500ms) resolves
 await page.goto('/?idleTimeout=50&timeout=0');
 await page.goto('/?idleTimeout=50');

 // Wait for pageload to complete
 await page.waitForTimeout(200);
Expand DownExpand Up@@ -1474,7 +1421,7 @@ test('Route manifest provides correct name when pageload span ends before lazy r
 );
 });

 await page.goto('/wildcard-lazy/123?idleTimeout=50&timeout=0');
 await page.goto('/wildcard-lazy/123?idleTimeout=50');

 const event = await pageloadPromise;

Expand Down
Loading
Loading