Skip to content

fix(consola): Normalize extra keys from consola - #19511

Merged
s1gr1d merged 8 commits into
developfrom
sig/consola-extra-keys
Feb 26, 2026
Merged

fix(consola): Normalize extra keys from consola#19511
s1gr1d merged 8 commits into
developfrom
sig/consola-extra-keys

Conversation

@s1gr1d

@s1gr1ds1gr1d commented Feb 25, 2026

Copy link
Copy Markdown
Member

The JS doc states that extra keys are added as consola. log attributes. However, this is not the case.

Extra keys can be added by, for example, calling the Consola reporter directly or by calling consola.[type]({ message: '', ... }).

Part of this PR (split up for better reviewing): #18602

Closes#19512 (added automatically)

Comment threadpackages/core/src/integrations/consola.ts Outdated
@github-actions

github-actionsBot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.62 kB--
@sentry/browser - with treeshaking flags24.12 kB--
@sentry/browser (incl. Tracing)42.42 kB--
@sentry/browser (incl. Tracing, Profiling)47.09 kB--
@sentry/browser (incl. Tracing, Replay)81.24 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.86 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.94 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.2 kB--
@sentry/browser (incl. Feedback)42.43 kB--
@sentry/browser (incl. sendFeedback)30.29 kB--
@sentry/browser (incl. FeedbackAsync)35.34 kB--
@sentry/browser (incl. Metrics)26.79 kB--
@sentry/browser (incl. Logs)26.93 kB--
@sentry/browser (incl. Metrics & Logs)27.61 kB--
@sentry/react27.37 kB--
@sentry/react (incl. Tracing)44.76 kB--
@sentry/vue30.07 kB--
@sentry/vue (incl. Tracing)44.27 kB--
@sentry/svelte25.64 kB--
CDN Bundle28.16 kB--
CDN Bundle (incl. Tracing)43.25 kB--
CDN Bundle (incl. Logs, Metrics)29 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.09 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.08 kB--
CDN Bundle (incl. Tracing, Replay)80.13 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.99 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.64 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.53 kB--
CDN Bundle - uncompressed82.34 kB--
CDN Bundle (incl. Tracing) - uncompressed128.06 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.18 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.89 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.84 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.94 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.76 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.85 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.66 kB--
@sentry/nextjs (client)47.17 kB--
@sentry/sveltekit (client)42.88 kB--
@sentry/node-core52.18 kB+0.02%+9 B 🔺
@sentry/node174.48 kB+0.01%+5 B 🔺
@sentry/node - without tracing97.33 kB+0.02%+10 B 🔺
@sentry/aws-serverless113.13 kB+0.01%+7 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,060-9,319-3%
GET With Sentry1,74919%1,636+7%
GET With Sentry (error only)6,16268%5,856+5%
POST Baseline1,209-1,156+5%
POST With Sentry60550%557+9%
POST With Sentry (error only)1,06488%1,029+3%
MYSQL Baseline3,319-3,178+4%
MYSQL With Sentry56517%381+48%
MYSQL With Sentry (error only)2,71282%2,569+6%

View base workflow run

@s1gr1d
s1gr1d requested a review from chargomeFebruary 25, 2026 09:17
@s1gr1d
s1gr1dforce-pushed the sig/consola-extra-keys branch from b4b3486 to bc63ae2CompareFebruary 25, 2026 09:20

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment threadpackages/core/src/integrations/consola.ts Outdated

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@s1gr1d
s1gr1dforce-pushed the sig/consola-extra-keys branch from a6fd7e6 to 676b162CompareFebruary 25, 2026 12:05
@s1gr1d
s1gr1d enabled auto-merge (squash) February 25, 2026 12:16
@s1gr1ds1gr1d changed the title fix(consola): Add extra keys as consola. prefixed attributesfix(consola): Add extra keys from consola as attributesFeb 25, 2026
@s1gr1ds1gr1d changed the title fix(consola): Add extra keys from consola as attributesfix(consola): Normalize extra keys from consolaFeb 25, 2026
@s1gr1d
s1gr1d disabled auto-merge February 25, 2026 12:51
@s1gr1d
s1gr1dforce-pushed the sig/consola-extra-keys branch from 676b162 to 286f009CompareFebruary 26, 2026 09:07
@s1gr1d
s1gr1d enabled auto-merge (squash) February 26, 2026 09:08
@s1gr1d
s1gr1d merged commit 311cf29 into developFeb 26, 2026
433 of 438 checks passed
@s1gr1d
s1gr1d deleted the sig/consola-extra-keys branch February 26, 2026 15:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(consola): Add extra keys as consola. prefixed attributes

2 participants

@s1gr1d@chargome