Skip to content

test(consola): Restructure tests (e.g. changing cases.forEach() to it.each) - #19517

Merged
s1gr1d merged 2 commits into
developfrom
sig/consola-improve-tests
Feb 26, 2026
Merged

test(consola): Restructure tests (e.g. changing cases.forEach() to it.each)#19517
s1gr1d merged 2 commits into
developfrom
sig/consola-improve-tests

Conversation

@s1gr1d

@s1gr1ds1gr1d commented Feb 25, 2026

Copy link
Copy Markdown
Member

Some small refactoring to make test cases better readable.

Part of this PR (to make things easier reviewable): #18602

Closes#19518 (added automatically)

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment threadpackages/core/test/lib/integrations/consola.test.ts
@github-actions

github-actionsBot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.62 kB--
@sentry/browser - with treeshaking flags24.12 kB--
@sentry/browser (incl. Tracing)42.42 kB--
@sentry/browser (incl. Tracing, Profiling)47.09 kB--
@sentry/browser (incl. Tracing, Replay)81.24 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.86 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.94 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.2 kB--
@sentry/browser (incl. Feedback)42.43 kB--
@sentry/browser (incl. sendFeedback)30.29 kB--
@sentry/browser (incl. FeedbackAsync)35.34 kB--
@sentry/browser (incl. Metrics)26.79 kB--
@sentry/browser (incl. Logs)26.93 kB--
@sentry/browser (incl. Metrics & Logs)27.61 kB--
@sentry/react27.37 kB--
@sentry/react (incl. Tracing)44.76 kB--
@sentry/vue30.07 kB--
@sentry/vue (incl. Tracing)44.27 kB--
@sentry/svelte25.64 kB--
CDN Bundle28.16 kB--
CDN Bundle (incl. Tracing)43.25 kB--
CDN Bundle (incl. Logs, Metrics)29 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.09 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.08 kB--
CDN Bundle (incl. Tracing, Replay)80.13 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.99 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.64 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.53 kB--
CDN Bundle - uncompressed82.34 kB--
CDN Bundle (incl. Tracing) - uncompressed128.06 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.18 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.89 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.84 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.94 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.76 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.85 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.66 kB--
@sentry/nextjs (client)47.17 kB--
@sentry/sveltekit (client)42.88 kB--
@sentry/node-core52.18 kB+0.02%+8 B 🔺
@sentry/node173.46 kB+0.01%+9 B 🔺
@sentry/node - without tracing97.33 kB+0.02%+10 B 🔺
@sentry/aws-serverless113.13 kB+0.01%+7 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,994-8,806+2%
GET With Sentry1,72319%1,675+3%
GET With Sentry (error only)6,18269%6,155+0%
POST Baseline1,208-1,195+1%
POST With Sentry58649%541+8%
POST With Sentry (error only)1,06688%1,056+1%
MYSQL Baseline3,289-3,205+3%
MYSQL With Sentry42713%371+15%
MYSQL With Sentry (error only)2,67981%2,654+1%

View base workflow run

@s1gr1d
s1gr1d enabled auto-merge (squash) February 26, 2026 08:24
@s1gr1d
s1gr1d merged commit 17b7532 into developFeb 26, 2026
227 of 249 checks passed
@s1gr1d
s1gr1d deleted the sig/consola-improve-tests branch February 26, 2026 08:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(consola): Restructure tests (e.g. changing cases.forEach() to it.each)

2 participants

@s1gr1d@chargome