Uh oh!
There was an error while loading. Please reload this page.
feat(core): Add weight-based flushing to span buffer - #19579
Merged
Conversation
| : MAX_SPANS_PER_ENVELOPE; | ||
| this._flushInterval = flushInterval && flushInterval > 0 ? flushInterval : 5_000; | ||
| this._maxTraceWeight = | ||
| maxTraceWeightInBytes && maxTraceWeightInBytes > 0 ? maxTraceWeightInBytes : MAX_TRACE_WEIGHT_IN_BYTES; |
There was a problem hiding this comment.
Missing integration or E2E test for new feature
Low Severity
This feat PR adds weight-based flushing and span size estimation but only includes unit tests. Per the project review rules, feat PRs need at least one integration or E2E test. Consider adding an integration test that validates the end-to-end flow of weight-triggered flushing in a realistic scenario.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
There was a problem hiding this comment.
Bugbot Autofix determined this is a false positive.
Comprehensive unit tests exist; integration tests require span streaming infrastructure that doesn't exist in any test suite yet.
This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
MemberAuthor
There was a problem hiding this comment.
Correct, integration tests will follow soon!
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| return 8; | ||
| } | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Duplicate estimatePrimitiveSizeInBytes function in codebase
Low Severity
The newly added estimatePrimitiveSizeInBytes function in attributes.ts is a functionally identical duplicate of the existing private estimatePrimitiveSizeInBytes in client.ts (lines 1709–1719). Both check for string, number, and boolean types and return the same values. Similarly, estimateTypedAttributesSizeInBytes partially overlaps with estimateAttributesSizeInBytes in client.ts. The shared primitive estimator could be extracted into a common utility to avoid maintaining two copies.
Additional Locations (1)
MemberAuthor
There was a problem hiding this comment.
Yes, this was deliberate for the moment. I want to unify this + adjust log/metric size estimation a bit more but this will happen against the develop branch for logs and metrics. estimatePrimitiveSizeInBytes should IMHO not be in client.ts but rather in attributes.ts.
s1gr1d
approved these changes
Mar 2, 2026
Comment on lines
+162
to
+169
| if (typeof value === 'string') { | ||
| return value.length * 2; | ||
| } else if (typeof value === 'boolean') { | ||
| return 4; | ||
| } else if (typeof value === 'number') { | ||
| return 8; | ||
| } | ||
| return 0; |
Member
There was a problem hiding this comment.
As this is for attributes, we probably only need to account for string, boolean and number. But just for the sake of completeness, I want to mention that there would still be symbol and bigint that would fall through and evaluate as 0 (in case this ever gets relevant).
MemberAuthor
There was a problem hiding this comment.
Good point! At the moment, we'd drop these attributes on spans since they're not supported. We might want to reconsider this eventually (see #18164), in which case we'd probably stringify them. So we'd report the stringified length * 2. I'm gonna leave this as-is for now though.
Uh oh!
There was an error while loading. Please reload this page.
Merged
Lms24 added a commit
that referenced
this pull request
Mar 4, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
Lms24 added a commit
that referenced
this pull request
Mar 6, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
Lms24 added a commit
that referenced
this pull request
Mar 9, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
Lms24 added a commit
that referenced
this pull request
Mar 10, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
Lms24 added a commit
that referenced
this pull request
Mar 13, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
Lms24 added a commit
that referenced
this pull request
Mar 18, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
logaretm pushed a commit
that referenced
this pull request
Mar 18, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
Lms24 added a commit
that referenced
this pull request
Mar 23, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
Lms24 added a commit
that referenced
this pull request
Mar 30, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
Lms24 added a commit
that referenced
this pull request
Apr 2, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
Lms24 added a commit
that referenced
this pull request
Apr 8, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
Lms24 added a commit
that referenced
this pull request
Apr 9, 2026
Adds weight-based flushing and span size estimation to the span buffer. Behaviour: - tracks weight independently per trace - weight estimation follows the same strategy we use for logs and metrics. I optimized the calculation, adding fixed sizes for as many fields as possible. Only span name, attributes and links are computed dynamically, with the same assumptions and considerations as in logs and metrics. - My tests show that the size estimation roughly compares to factor 0.8 to 1.2 to the real sizes, depending on data on spans (no, few, many, primitive, array attributes and links, etc.) - For now, the limit is set to 5MB which is half of the 10MB Relay accepts for span envelopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds weight-based flushing and span size estimation to the span buffer.
Behaviour: