test(angular): Fix failing canary test - #19639

Merged
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix
Mar 9, 2026
Merged

test(angular): Fix failing canary test#19639
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix

Conversation

@Lms24

@Lms24Lms24 commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Member

The actual fail mostly "resolved itself" because Angular now also released 22.0.0-next.0 versions for the Angular CLI packages, in addition to the core angular packages. However, Angular 22 will require At least Node 22.22.0.

So this PR makes a few modifications to fully fix Angular canary tests again:

  • set the node version to Node 22.22.0 for the canary test and the Angular 21 e2e test (which should be fine IMHO)
  • Use the angular-21 app instead of the angular-20 app for canary tests
  • Remove the optional canary test config in the angular-20 app

closes#19636

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.64 kB--
@sentry/browser - with treeshaking flags24.14 kB--
@sentry/browser (incl. Tracing)42.44 kB--
@sentry/browser (incl. Tracing, Profiling)47.1 kB--
@sentry/browser (incl. Tracing, Replay)81.26 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.88 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.95 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.21 kB--
@sentry/browser (incl. Feedback)42.44 kB--
@sentry/browser (incl. sendFeedback)30.31 kB--
@sentry/browser (incl. FeedbackAsync)35.36 kB--
@sentry/browser (incl. Metrics)26.8 kB--
@sentry/browser (incl. Logs)26.95 kB--
@sentry/browser (incl. Metrics & Logs)27.62 kB--
@sentry/react27.39 kB--
@sentry/react (incl. Tracing)44.78 kB--
@sentry/vue30.09 kB--
@sentry/vue (incl. Tracing)44.31 kB--
@sentry/svelte25.66 kB--
CDN Bundle28.18 kB--
CDN Bundle (incl. Tracing)43.27 kB--
CDN Bundle (incl. Logs, Metrics)29.02 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.11 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.1 kB--
CDN Bundle (incl. Tracing, Replay)80.15 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)81.01 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.66 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.54 kB--
CDN Bundle - uncompressed82.38 kB--
CDN Bundle (incl. Tracing) - uncompressed128.09 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.21 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.93 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.88 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.98 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.8 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.7 kB--
@sentry/nextjs (client)47.19 kB--
@sentry/sveltekit (client)42.9 kB--
@sentry/node-core52.27 kB+0.02%+7 B 🔺
@sentry/node174.77 kB+0.01%+4 B 🔺
@sentry/node - without tracing97.44 kB+0.02%+11 B 🔺
@sentry/aws-serverless113.24 kB+0.01%+8 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,737-9,310-6%
GET With Sentry1,55418%1,737-11%
GET With Sentry (error only)5,94268%6,283-5%
POST Baseline1,165-1,213-4%
POST With Sentry57449%592-3%
POST With Sentry (error only)1,03088%1,075-4%
MYSQL Baseline3,196-3,259-2%
MYSQL With Sentry38812%447-13%
MYSQL With Sentry (error only)2,55580%2,659-4%

View base workflow run

@Lms24Lms24 mentioned this pull request Mar 5, 2026
Closed
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from 3dcb028 to 098e920CompareMarch 9, 2026 12:57
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
@Lms24Lms24 self-assigned this Mar 9, 2026
@Lms24
Lms24 marked this pull request as ready for review March 9, 2026 13:37
@Lms24
Lms24 requested review from a team, andreiborza and chargome and removed request for a teamMarch 9, 2026 13:37
cursor[bot]
cursorBot reviewed Mar 9, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment threadpackages/angular/package.json Outdated
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from ece849b to cac1432CompareMarch 9, 2026 13:39
sentry[bot]
sentryBot reviewed Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment thread.github/workflows/canary.yml
with:
version: 9.15.9
- name: Set up Node
if: matrix.test-application != 'angular-20'

@Lms24Lms24Mar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out this was no longer necessary at all. Now we just set Node 22 in the angular-21 package.json.

@Lms24
Lms24 merged commit f83f288 into developMar 9, 2026
226 checks passed
@Lms24
Lms24 deleted the lms/test-e2e-angular-canary-fix branch March 9, 2026 14:43
andreiborza pushed a commit that referenced this pull request Mar 11, 2026
@Lms24
test(angular): Fix failing canary test (#19639)
06c20be
The actual fail mostly "resolved itself" because Angular now also
released `22.0.0-next.0` versions for the Angular CLI packages, in
addition to the core angular packages. However, Angular 22 will
[require](angular/angular-cli#32681)
At least Node 22.22.0.
So this PR makes a few modifications to fully fix Angular canary tests
again:
- set the node version to Node 22.22.0 for the canary test and the
Angular 21 e2e test (which should be fine IMHO)
- Use the `angular-21` app instead of the `angular-20` app for canary
tests
- Remove the optional canary test config in the `angular-20` app
closes#19636
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargomechargome was automatically assigned from getsentry/team-javascript-sdks
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees

@Lms24Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

angular-20 (next) Test Failed

2 participants

@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

test(angular): Fix failing canary test - #19639

Merged
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix
Mar 9, 2026
Merged

test(angular): Fix failing canary test#19639
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix

Conversation

@Lms24

@Lms24Lms24 commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Member

The actual fail mostly "resolved itself" because Angular now also released 22.0.0-next.0 versions for the Angular CLI packages, in addition to the core angular packages. However, Angular 22 will require At least Node 22.22.0.

So this PR makes a few modifications to fully fix Angular canary tests again:

  • set the node version to Node 22.22.0 for the canary test and the Angular 21 e2e test (which should be fine IMHO)
  • Use the angular-21 app instead of the angular-20 app for canary tests
  • Remove the optional canary test config in the angular-20 app

closes#19636

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.64 kB--
@sentry/browser - with treeshaking flags24.14 kB--
@sentry/browser (incl. Tracing)42.44 kB--
@sentry/browser (incl. Tracing, Profiling)47.1 kB--
@sentry/browser (incl. Tracing, Replay)81.26 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.88 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.95 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.21 kB--
@sentry/browser (incl. Feedback)42.44 kB--
@sentry/browser (incl. sendFeedback)30.31 kB--
@sentry/browser (incl. FeedbackAsync)35.36 kB--
@sentry/browser (incl. Metrics)26.8 kB--
@sentry/browser (incl. Logs)26.95 kB--
@sentry/browser (incl. Metrics & Logs)27.62 kB--
@sentry/react27.39 kB--
@sentry/react (incl. Tracing)44.78 kB--
@sentry/vue30.09 kB--
@sentry/vue (incl. Tracing)44.31 kB--
@sentry/svelte25.66 kB--
CDN Bundle28.18 kB--
CDN Bundle (incl. Tracing)43.27 kB--
CDN Bundle (incl. Logs, Metrics)29.02 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.11 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.1 kB--
CDN Bundle (incl. Tracing, Replay)80.15 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)81.01 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.66 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.54 kB--
CDN Bundle - uncompressed82.38 kB--
CDN Bundle (incl. Tracing) - uncompressed128.09 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.21 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.93 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.88 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.98 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.8 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.7 kB--
@sentry/nextjs (client)47.19 kB--
@sentry/sveltekit (client)42.9 kB--
@sentry/node-core52.27 kB+0.02%+7 B 🔺
@sentry/node174.77 kB+0.01%+4 B 🔺
@sentry/node - without tracing97.44 kB+0.02%+11 B 🔺
@sentry/aws-serverless113.24 kB+0.01%+8 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,737-9,310-6%
GET With Sentry1,55418%1,737-11%
GET With Sentry (error only)5,94268%6,283-5%
POST Baseline1,165-1,213-4%
POST With Sentry57449%592-3%
POST With Sentry (error only)1,03088%1,075-4%
MYSQL Baseline3,196-3,259-2%
MYSQL With Sentry38812%447-13%
MYSQL With Sentry (error only)2,55580%2,659-4%

View base workflow run

@Lms24Lms24 mentioned this pull request Mar 5, 2026
Closed
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from 3dcb028 to 098e920CompareMarch 9, 2026 12:57
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
@Lms24Lms24 self-assigned this Mar 9, 2026
@Lms24
Lms24 marked this pull request as ready for review March 9, 2026 13:37
@Lms24
Lms24 requested review from a team, andreiborza and chargome and removed request for a teamMarch 9, 2026 13:37
cursor[bot]
cursorBot reviewed Mar 9, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment threadpackages/angular/package.json Outdated
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from ece849b to cac1432CompareMarch 9, 2026 13:39
sentry[bot]
sentryBot reviewed Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment thread.github/workflows/canary.yml
with:
version: 9.15.9
- name: Set up Node
if: matrix.test-application != 'angular-20'

@Lms24Lms24Mar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out this was no longer necessary at all. Now we just set Node 22 in the angular-21 package.json.

@Lms24
Lms24 merged commit f83f288 into developMar 9, 2026
226 checks passed
@Lms24
Lms24 deleted the lms/test-e2e-angular-canary-fix branch March 9, 2026 14:43
andreiborza pushed a commit that referenced this pull request Mar 11, 2026
@Lms24
test(angular): Fix failing canary test (#19639)
06c20be
The actual fail mostly "resolved itself" because Angular now also
released `22.0.0-next.0` versions for the Angular CLI packages, in
addition to the core angular packages. However, Angular 22 will
[require](angular/angular-cli#32681)
At least Node 22.22.0.
So this PR makes a few modifications to fully fix Angular canary tests
again:
- set the node version to Node 22.22.0 for the canary test and the
Angular 21 e2e test (which should be fine IMHO)
- Use the `angular-21` app instead of the `angular-20` app for canary
tests
- Remove the optional canary test config in the `angular-20` app
closes#19636
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargomechargome was automatically assigned from getsentry/team-javascript-sdks
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees

@Lms24Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

angular-20 (next) Test Failed

2 participants

@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(angular): Fix failing canary test - #19639

Merged
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix
Mar 9, 2026
Merged

test(angular): Fix failing canary test#19639
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix

Conversation

@Lms24

@Lms24Lms24 commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Member

The actual fail mostly "resolved itself" because Angular now also released 22.0.0-next.0 versions for the Angular CLI packages, in addition to the core angular packages. However, Angular 22 will require At least Node 22.22.0.

So this PR makes a few modifications to fully fix Angular canary tests again:

  • set the node version to Node 22.22.0 for the canary test and the Angular 21 e2e test (which should be fine IMHO)
  • Use the angular-21 app instead of the angular-20 app for canary tests
  • Remove the optional canary test config in the angular-20 app

closes#19636

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.64 kB--
@sentry/browser - with treeshaking flags24.14 kB--
@sentry/browser (incl. Tracing)42.44 kB--
@sentry/browser (incl. Tracing, Profiling)47.1 kB--
@sentry/browser (incl. Tracing, Replay)81.26 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.88 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.95 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.21 kB--
@sentry/browser (incl. Feedback)42.44 kB--
@sentry/browser (incl. sendFeedback)30.31 kB--
@sentry/browser (incl. FeedbackAsync)35.36 kB--
@sentry/browser (incl. Metrics)26.8 kB--
@sentry/browser (incl. Logs)26.95 kB--
@sentry/browser (incl. Metrics & Logs)27.62 kB--
@sentry/react27.39 kB--
@sentry/react (incl. Tracing)44.78 kB--
@sentry/vue30.09 kB--
@sentry/vue (incl. Tracing)44.31 kB--
@sentry/svelte25.66 kB--
CDN Bundle28.18 kB--
CDN Bundle (incl. Tracing)43.27 kB--
CDN Bundle (incl. Logs, Metrics)29.02 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.11 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.1 kB--
CDN Bundle (incl. Tracing, Replay)80.15 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)81.01 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.66 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.54 kB--
CDN Bundle - uncompressed82.38 kB--
CDN Bundle (incl. Tracing) - uncompressed128.09 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.21 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.93 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.88 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.98 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.8 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.7 kB--
@sentry/nextjs (client)47.19 kB--
@sentry/sveltekit (client)42.9 kB--
@sentry/node-core52.27 kB+0.02%+7 B 🔺
@sentry/node174.77 kB+0.01%+4 B 🔺
@sentry/node - without tracing97.44 kB+0.02%+11 B 🔺
@sentry/aws-serverless113.24 kB+0.01%+8 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,737-9,310-6%
GET With Sentry1,55418%1,737-11%
GET With Sentry (error only)5,94268%6,283-5%
POST Baseline1,165-1,213-4%
POST With Sentry57449%592-3%
POST With Sentry (error only)1,03088%1,075-4%
MYSQL Baseline3,196-3,259-2%
MYSQL With Sentry38812%447-13%
MYSQL With Sentry (error only)2,55580%2,659-4%

View base workflow run

@Lms24Lms24 mentioned this pull request Mar 5, 2026
Closed
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from 3dcb028 to 098e920CompareMarch 9, 2026 12:57
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
@Lms24Lms24 self-assigned this Mar 9, 2026
@Lms24
Lms24 marked this pull request as ready for review March 9, 2026 13:37
@Lms24
Lms24 requested review from a team, andreiborza and chargome and removed request for a teamMarch 9, 2026 13:37
cursor[bot]
cursorBot reviewed Mar 9, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment threadpackages/angular/package.json Outdated
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from ece849b to cac1432CompareMarch 9, 2026 13:39
sentry[bot]
sentryBot reviewed Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment thread.github/workflows/canary.yml
with:
version: 9.15.9
- name: Set up Node
if: matrix.test-application != 'angular-20'

@Lms24Lms24Mar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out this was no longer necessary at all. Now we just set Node 22 in the angular-21 package.json.

@Lms24
Lms24 merged commit f83f288 into developMar 9, 2026
226 checks passed
@Lms24
Lms24 deleted the lms/test-e2e-angular-canary-fix branch March 9, 2026 14:43
andreiborza pushed a commit that referenced this pull request Mar 11, 2026
@Lms24
test(angular): Fix failing canary test (#19639)
06c20be
The actual fail mostly "resolved itself" because Angular now also
released `22.0.0-next.0` versions for the Angular CLI packages, in
addition to the core angular packages. However, Angular 22 will
[require](angular/angular-cli#32681)
At least Node 22.22.0.
So this PR makes a few modifications to fully fix Angular canary tests
again:
- set the node version to Node 22.22.0 for the canary test and the
Angular 21 e2e test (which should be fine IMHO)
- Use the `angular-21` app instead of the `angular-20` app for canary
tests
- Remove the optional canary test config in the `angular-20` app
closes#19636
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargomechargome was automatically assigned from getsentry/team-javascript-sdks
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees

@Lms24Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

angular-20 (next) Test Failed

2 participants

@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(angular): Fix failing canary test - #19639

Merged
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix
Mar 9, 2026
Merged

test(angular): Fix failing canary test#19639
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix

Conversation

@Lms24

@Lms24Lms24 commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Member

The actual fail mostly "resolved itself" because Angular now also released 22.0.0-next.0 versions for the Angular CLI packages, in addition to the core angular packages. However, Angular 22 will require At least Node 22.22.0.

So this PR makes a few modifications to fully fix Angular canary tests again:

  • set the node version to Node 22.22.0 for the canary test and the Angular 21 e2e test (which should be fine IMHO)
  • Use the angular-21 app instead of the angular-20 app for canary tests
  • Remove the optional canary test config in the angular-20 app

closes#19636

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.64 kB--
@sentry/browser - with treeshaking flags24.14 kB--
@sentry/browser (incl. Tracing)42.44 kB--
@sentry/browser (incl. Tracing, Profiling)47.1 kB--
@sentry/browser (incl. Tracing, Replay)81.26 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.88 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.95 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.21 kB--
@sentry/browser (incl. Feedback)42.44 kB--
@sentry/browser (incl. sendFeedback)30.31 kB--
@sentry/browser (incl. FeedbackAsync)35.36 kB--
@sentry/browser (incl. Metrics)26.8 kB--
@sentry/browser (incl. Logs)26.95 kB--
@sentry/browser (incl. Metrics & Logs)27.62 kB--
@sentry/react27.39 kB--
@sentry/react (incl. Tracing)44.78 kB--
@sentry/vue30.09 kB--
@sentry/vue (incl. Tracing)44.31 kB--
@sentry/svelte25.66 kB--
CDN Bundle28.18 kB--
CDN Bundle (incl. Tracing)43.27 kB--
CDN Bundle (incl. Logs, Metrics)29.02 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.11 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.1 kB--
CDN Bundle (incl. Tracing, Replay)80.15 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)81.01 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.66 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.54 kB--
CDN Bundle - uncompressed82.38 kB--
CDN Bundle (incl. Tracing) - uncompressed128.09 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.21 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.93 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.88 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.98 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.8 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.7 kB--
@sentry/nextjs (client)47.19 kB--
@sentry/sveltekit (client)42.9 kB--
@sentry/node-core52.27 kB+0.02%+7 B 🔺
@sentry/node174.77 kB+0.01%+4 B 🔺
@sentry/node - without tracing97.44 kB+0.02%+11 B 🔺
@sentry/aws-serverless113.24 kB+0.01%+8 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,737-9,310-6%
GET With Sentry1,55418%1,737-11%
GET With Sentry (error only)5,94268%6,283-5%
POST Baseline1,165-1,213-4%
POST With Sentry57449%592-3%
POST With Sentry (error only)1,03088%1,075-4%
MYSQL Baseline3,196-3,259-2%
MYSQL With Sentry38812%447-13%
MYSQL With Sentry (error only)2,55580%2,659-4%

View base workflow run

@Lms24Lms24 mentioned this pull request Mar 5, 2026
Closed
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from 3dcb028 to 098e920CompareMarch 9, 2026 12:57
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
@Lms24Lms24 self-assigned this Mar 9, 2026
@Lms24
Lms24 marked this pull request as ready for review March 9, 2026 13:37
@Lms24
Lms24 requested review from a team, andreiborza and chargome and removed request for a teamMarch 9, 2026 13:37
cursor[bot]
cursorBot reviewed Mar 9, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment threadpackages/angular/package.json Outdated
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from ece849b to cac1432CompareMarch 9, 2026 13:39
sentry[bot]
sentryBot reviewed Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment thread.github/workflows/canary.yml
with:
version: 9.15.9
- name: Set up Node
if: matrix.test-application != 'angular-20'

@Lms24Lms24Mar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out this was no longer necessary at all. Now we just set Node 22 in the angular-21 package.json.

@Lms24
Lms24 merged commit f83f288 into developMar 9, 2026
226 checks passed
@Lms24
Lms24 deleted the lms/test-e2e-angular-canary-fix branch March 9, 2026 14:43
andreiborza pushed a commit that referenced this pull request Mar 11, 2026
@Lms24
test(angular): Fix failing canary test (#19639)
06c20be
The actual fail mostly "resolved itself" because Angular now also
released `22.0.0-next.0` versions for the Angular CLI packages, in
addition to the core angular packages. However, Angular 22 will
[require](angular/angular-cli#32681)
At least Node 22.22.0.
So this PR makes a few modifications to fully fix Angular canary tests
again:
- set the node version to Node 22.22.0 for the canary test and the
Angular 21 e2e test (which should be fine IMHO)
- Use the `angular-21` app instead of the `angular-20` app for canary
tests
- Remove the optional canary test config in the `angular-20` app
closes#19636
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargomechargome was automatically assigned from getsentry/team-javascript-sdks
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees

@Lms24Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

angular-20 (next) Test Failed

2 participants

@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

test(angular): Fix failing canary test - #19639

Merged
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix
Mar 9, 2026
Merged

test(angular): Fix failing canary test#19639
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix

Conversation

@Lms24

@Lms24Lms24 commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Member

The actual fail mostly "resolved itself" because Angular now also released 22.0.0-next.0 versions for the Angular CLI packages, in addition to the core angular packages. However, Angular 22 will require At least Node 22.22.0.

So this PR makes a few modifications to fully fix Angular canary tests again:

  • set the node version to Node 22.22.0 for the canary test and the Angular 21 e2e test (which should be fine IMHO)
  • Use the angular-21 app instead of the angular-20 app for canary tests
  • Remove the optional canary test config in the angular-20 app

closes#19636

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.64 kB--
@sentry/browser - with treeshaking flags24.14 kB--
@sentry/browser (incl. Tracing)42.44 kB--
@sentry/browser (incl. Tracing, Profiling)47.1 kB--
@sentry/browser (incl. Tracing, Replay)81.26 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.88 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.95 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.21 kB--
@sentry/browser (incl. Feedback)42.44 kB--
@sentry/browser (incl. sendFeedback)30.31 kB--
@sentry/browser (incl. FeedbackAsync)35.36 kB--
@sentry/browser (incl. Metrics)26.8 kB--
@sentry/browser (incl. Logs)26.95 kB--
@sentry/browser (incl. Metrics & Logs)27.62 kB--
@sentry/react27.39 kB--
@sentry/react (incl. Tracing)44.78 kB--
@sentry/vue30.09 kB--
@sentry/vue (incl. Tracing)44.31 kB--
@sentry/svelte25.66 kB--
CDN Bundle28.18 kB--
CDN Bundle (incl. Tracing)43.27 kB--
CDN Bundle (incl. Logs, Metrics)29.02 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.11 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.1 kB--
CDN Bundle (incl. Tracing, Replay)80.15 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)81.01 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.66 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.54 kB--
CDN Bundle - uncompressed82.38 kB--
CDN Bundle (incl. Tracing) - uncompressed128.09 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.21 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.93 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.88 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.98 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.8 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.7 kB--
@sentry/nextjs (client)47.19 kB--
@sentry/sveltekit (client)42.9 kB--
@sentry/node-core52.27 kB+0.02%+7 B 🔺
@sentry/node174.77 kB+0.01%+4 B 🔺
@sentry/node - without tracing97.44 kB+0.02%+11 B 🔺
@sentry/aws-serverless113.24 kB+0.01%+8 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,737-9,310-6%
GET With Sentry1,55418%1,737-11%
GET With Sentry (error only)5,94268%6,283-5%
POST Baseline1,165-1,213-4%
POST With Sentry57449%592-3%
POST With Sentry (error only)1,03088%1,075-4%
MYSQL Baseline3,196-3,259-2%
MYSQL With Sentry38812%447-13%
MYSQL With Sentry (error only)2,55580%2,659-4%

View base workflow run

@Lms24Lms24 mentioned this pull request Mar 5, 2026
Closed
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from 3dcb028 to 098e920CompareMarch 9, 2026 12:57
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
@Lms24Lms24 self-assigned this Mar 9, 2026
@Lms24
Lms24 marked this pull request as ready for review March 9, 2026 13:37
@Lms24
Lms24 requested review from a team, andreiborza and chargome and removed request for a teamMarch 9, 2026 13:37
cursor[bot]
cursorBot reviewed Mar 9, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment threadpackages/angular/package.json Outdated
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from ece849b to cac1432CompareMarch 9, 2026 13:39
sentry[bot]
sentryBot reviewed Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment thread.github/workflows/canary.yml
with:
version: 9.15.9
- name: Set up Node
if: matrix.test-application != 'angular-20'

@Lms24Lms24Mar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out this was no longer necessary at all. Now we just set Node 22 in the angular-21 package.json.

@Lms24
Lms24 merged commit f83f288 into developMar 9, 2026
226 checks passed
@Lms24
Lms24 deleted the lms/test-e2e-angular-canary-fix branch March 9, 2026 14:43
andreiborza pushed a commit that referenced this pull request Mar 11, 2026
@Lms24
test(angular): Fix failing canary test (#19639)
06c20be
The actual fail mostly "resolved itself" because Angular now also
released `22.0.0-next.0` versions for the Angular CLI packages, in
addition to the core angular packages. However, Angular 22 will
[require](angular/angular-cli#32681)
At least Node 22.22.0.
So this PR makes a few modifications to fully fix Angular canary tests
again:
- set the node version to Node 22.22.0 for the canary test and the
Angular 21 e2e test (which should be fine IMHO)
- Use the `angular-21` app instead of the `angular-20` app for canary
tests
- Remove the optional canary test config in the `angular-20` app
closes#19636
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargomechargome was automatically assigned from getsentry/team-javascript-sdks
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees

@Lms24Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

angular-20 (next) Test Failed

2 participants

@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(angular): Fix failing canary test - #19639

Merged
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix
Mar 9, 2026
Merged

test(angular): Fix failing canary test#19639
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix

Conversation

@Lms24

@Lms24Lms24 commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Member

The actual fail mostly "resolved itself" because Angular now also released 22.0.0-next.0 versions for the Angular CLI packages, in addition to the core angular packages. However, Angular 22 will require At least Node 22.22.0.

So this PR makes a few modifications to fully fix Angular canary tests again:

  • set the node version to Node 22.22.0 for the canary test and the Angular 21 e2e test (which should be fine IMHO)
  • Use the angular-21 app instead of the angular-20 app for canary tests
  • Remove the optional canary test config in the angular-20 app

closes#19636

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.64 kB--
@sentry/browser - with treeshaking flags24.14 kB--
@sentry/browser (incl. Tracing)42.44 kB--
@sentry/browser (incl. Tracing, Profiling)47.1 kB--
@sentry/browser (incl. Tracing, Replay)81.26 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.88 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.95 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.21 kB--
@sentry/browser (incl. Feedback)42.44 kB--
@sentry/browser (incl. sendFeedback)30.31 kB--
@sentry/browser (incl. FeedbackAsync)35.36 kB--
@sentry/browser (incl. Metrics)26.8 kB--
@sentry/browser (incl. Logs)26.95 kB--
@sentry/browser (incl. Metrics & Logs)27.62 kB--
@sentry/react27.39 kB--
@sentry/react (incl. Tracing)44.78 kB--
@sentry/vue30.09 kB--
@sentry/vue (incl. Tracing)44.31 kB--
@sentry/svelte25.66 kB--
CDN Bundle28.18 kB--
CDN Bundle (incl. Tracing)43.27 kB--
CDN Bundle (incl. Logs, Metrics)29.02 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.11 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.1 kB--
CDN Bundle (incl. Tracing, Replay)80.15 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)81.01 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.66 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.54 kB--
CDN Bundle - uncompressed82.38 kB--
CDN Bundle (incl. Tracing) - uncompressed128.09 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.21 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.93 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.88 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.98 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.8 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.7 kB--
@sentry/nextjs (client)47.19 kB--
@sentry/sveltekit (client)42.9 kB--
@sentry/node-core52.27 kB+0.02%+7 B 🔺
@sentry/node174.77 kB+0.01%+4 B 🔺
@sentry/node - without tracing97.44 kB+0.02%+11 B 🔺
@sentry/aws-serverless113.24 kB+0.01%+8 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,737-9,310-6%
GET With Sentry1,55418%1,737-11%
GET With Sentry (error only)5,94268%6,283-5%
POST Baseline1,165-1,213-4%
POST With Sentry57449%592-3%
POST With Sentry (error only)1,03088%1,075-4%
MYSQL Baseline3,196-3,259-2%
MYSQL With Sentry38812%447-13%
MYSQL With Sentry (error only)2,55580%2,659-4%

View base workflow run

@Lms24Lms24 mentioned this pull request Mar 5, 2026
Closed
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from 3dcb028 to 098e920CompareMarch 9, 2026 12:57
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
@Lms24Lms24 self-assigned this Mar 9, 2026
@Lms24
Lms24 marked this pull request as ready for review March 9, 2026 13:37
@Lms24
Lms24 requested review from a team, andreiborza and chargome and removed request for a teamMarch 9, 2026 13:37
cursor[bot]
cursorBot reviewed Mar 9, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment threadpackages/angular/package.json Outdated
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from ece849b to cac1432CompareMarch 9, 2026 13:39
sentry[bot]
sentryBot reviewed Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment thread.github/workflows/canary.yml
with:
version: 9.15.9
- name: Set up Node
if: matrix.test-application != 'angular-20'

@Lms24Lms24Mar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out this was no longer necessary at all. Now we just set Node 22 in the angular-21 package.json.

@Lms24
Lms24 merged commit f83f288 into developMar 9, 2026
226 checks passed
@Lms24
Lms24 deleted the lms/test-e2e-angular-canary-fix branch March 9, 2026 14:43
andreiborza pushed a commit that referenced this pull request Mar 11, 2026
@Lms24
test(angular): Fix failing canary test (#19639)
06c20be
The actual fail mostly "resolved itself" because Angular now also
released `22.0.0-next.0` versions for the Angular CLI packages, in
addition to the core angular packages. However, Angular 22 will
[require](angular/angular-cli#32681)
At least Node 22.22.0.
So this PR makes a few modifications to fully fix Angular canary tests
again:
- set the node version to Node 22.22.0 for the canary test and the
Angular 21 e2e test (which should be fine IMHO)
- Use the `angular-21` app instead of the `angular-20` app for canary
tests
- Remove the optional canary test config in the `angular-20` app
closes#19636
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargomechargome was automatically assigned from getsentry/team-javascript-sdks
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees

@Lms24Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

angular-20 (next) Test Failed

2 participants

@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(angular): Fix failing canary test - #19639

Merged
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix
Mar 9, 2026
Merged

test(angular): Fix failing canary test#19639
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix

Conversation

@Lms24

@Lms24Lms24 commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Member

The actual fail mostly "resolved itself" because Angular now also released 22.0.0-next.0 versions for the Angular CLI packages, in addition to the core angular packages. However, Angular 22 will require At least Node 22.22.0.

So this PR makes a few modifications to fully fix Angular canary tests again:

  • set the node version to Node 22.22.0 for the canary test and the Angular 21 e2e test (which should be fine IMHO)
  • Use the angular-21 app instead of the angular-20 app for canary tests
  • Remove the optional canary test config in the angular-20 app

closes#19636

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.64 kB--
@sentry/browser - with treeshaking flags24.14 kB--
@sentry/browser (incl. Tracing)42.44 kB--
@sentry/browser (incl. Tracing, Profiling)47.1 kB--
@sentry/browser (incl. Tracing, Replay)81.26 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.88 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.95 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.21 kB--
@sentry/browser (incl. Feedback)42.44 kB--
@sentry/browser (incl. sendFeedback)30.31 kB--
@sentry/browser (incl. FeedbackAsync)35.36 kB--
@sentry/browser (incl. Metrics)26.8 kB--
@sentry/browser (incl. Logs)26.95 kB--
@sentry/browser (incl. Metrics & Logs)27.62 kB--
@sentry/react27.39 kB--
@sentry/react (incl. Tracing)44.78 kB--
@sentry/vue30.09 kB--
@sentry/vue (incl. Tracing)44.31 kB--
@sentry/svelte25.66 kB--
CDN Bundle28.18 kB--
CDN Bundle (incl. Tracing)43.27 kB--
CDN Bundle (incl. Logs, Metrics)29.02 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.11 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.1 kB--
CDN Bundle (incl. Tracing, Replay)80.15 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)81.01 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.66 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.54 kB--
CDN Bundle - uncompressed82.38 kB--
CDN Bundle (incl. Tracing) - uncompressed128.09 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.21 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.93 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.88 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.98 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.8 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.7 kB--
@sentry/nextjs (client)47.19 kB--
@sentry/sveltekit (client)42.9 kB--
@sentry/node-core52.27 kB+0.02%+7 B 🔺
@sentry/node174.77 kB+0.01%+4 B 🔺
@sentry/node - without tracing97.44 kB+0.02%+11 B 🔺
@sentry/aws-serverless113.24 kB+0.01%+8 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,737-9,310-6%
GET With Sentry1,55418%1,737-11%
GET With Sentry (error only)5,94268%6,283-5%
POST Baseline1,165-1,213-4%
POST With Sentry57449%592-3%
POST With Sentry (error only)1,03088%1,075-4%
MYSQL Baseline3,196-3,259-2%
MYSQL With Sentry38812%447-13%
MYSQL With Sentry (error only)2,55580%2,659-4%

View base workflow run

@Lms24Lms24 mentioned this pull request Mar 5, 2026
Closed
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from 3dcb028 to 098e920CompareMarch 9, 2026 12:57
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
@Lms24Lms24 self-assigned this Mar 9, 2026
@Lms24
Lms24 marked this pull request as ready for review March 9, 2026 13:37
@Lms24
Lms24 requested review from a team, andreiborza and chargome and removed request for a teamMarch 9, 2026 13:37
cursor[bot]
cursorBot reviewed Mar 9, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment threadpackages/angular/package.json Outdated
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from ece849b to cac1432CompareMarch 9, 2026 13:39
sentry[bot]
sentryBot reviewed Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment thread.github/workflows/canary.yml
with:
version: 9.15.9
- name: Set up Node
if: matrix.test-application != 'angular-20'

@Lms24Lms24Mar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out this was no longer necessary at all. Now we just set Node 22 in the angular-21 package.json.

@Lms24
Lms24 merged commit f83f288 into developMar 9, 2026
226 checks passed
@Lms24
Lms24 deleted the lms/test-e2e-angular-canary-fix branch March 9, 2026 14:43
andreiborza pushed a commit that referenced this pull request Mar 11, 2026
@Lms24
test(angular): Fix failing canary test (#19639)
06c20be
The actual fail mostly "resolved itself" because Angular now also
released `22.0.0-next.0` versions for the Angular CLI packages, in
addition to the core angular packages. However, Angular 22 will
[require](angular/angular-cli#32681)
At least Node 22.22.0.
So this PR makes a few modifications to fully fix Angular canary tests
again:
- set the node version to Node 22.22.0 for the canary test and the
Angular 21 e2e test (which should be fine IMHO)
- Use the `angular-21` app instead of the `angular-20` app for canary
tests
- Remove the optional canary test config in the `angular-20` app
closes#19636
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargomechargome was automatically assigned from getsentry/team-javascript-sdks
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees

@Lms24Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

angular-20 (next) Test Failed

2 participants

@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

test(angular): Fix failing canary test - #19639

Merged
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix
Mar 9, 2026
Merged

test(angular): Fix failing canary test#19639
Lms24 merged 8 commits into
developfrom
lms/test-e2e-angular-canary-fix

Conversation

@Lms24

@Lms24Lms24 commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Member

The actual fail mostly "resolved itself" because Angular now also released 22.0.0-next.0 versions for the Angular CLI packages, in addition to the core angular packages. However, Angular 22 will require At least Node 22.22.0.

So this PR makes a few modifications to fully fix Angular canary tests again:

  • set the node version to Node 22.22.0 for the canary test and the Angular 21 e2e test (which should be fine IMHO)
  • Use the angular-21 app instead of the angular-20 app for canary tests
  • Remove the optional canary test config in the angular-20 app

closes#19636

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.64 kB--
@sentry/browser - with treeshaking flags24.14 kB--
@sentry/browser (incl. Tracing)42.44 kB--
@sentry/browser (incl. Tracing, Profiling)47.1 kB--
@sentry/browser (incl. Tracing, Replay)81.26 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.88 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.95 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.21 kB--
@sentry/browser (incl. Feedback)42.44 kB--
@sentry/browser (incl. sendFeedback)30.31 kB--
@sentry/browser (incl. FeedbackAsync)35.36 kB--
@sentry/browser (incl. Metrics)26.8 kB--
@sentry/browser (incl. Logs)26.95 kB--
@sentry/browser (incl. Metrics & Logs)27.62 kB--
@sentry/react27.39 kB--
@sentry/react (incl. Tracing)44.78 kB--
@sentry/vue30.09 kB--
@sentry/vue (incl. Tracing)44.31 kB--
@sentry/svelte25.66 kB--
CDN Bundle28.18 kB--
CDN Bundle (incl. Tracing)43.27 kB--
CDN Bundle (incl. Logs, Metrics)29.02 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.11 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.1 kB--
CDN Bundle (incl. Tracing, Replay)80.15 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)81.01 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.66 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.54 kB--
CDN Bundle - uncompressed82.38 kB--
CDN Bundle (incl. Tracing) - uncompressed128.09 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.21 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.93 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.88 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.98 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.8 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.7 kB--
@sentry/nextjs (client)47.19 kB--
@sentry/sveltekit (client)42.9 kB--
@sentry/node-core52.27 kB+0.02%+7 B 🔺
@sentry/node174.77 kB+0.01%+4 B 🔺
@sentry/node - without tracing97.44 kB+0.02%+11 B 🔺
@sentry/aws-serverless113.24 kB+0.01%+8 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Mar 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline8,737-9,310-6%
GET With Sentry1,55418%1,737-11%
GET With Sentry (error only)5,94268%6,283-5%
POST Baseline1,165-1,213-4%
POST With Sentry57449%592-3%
POST With Sentry (error only)1,03088%1,075-4%
MYSQL Baseline3,196-3,259-2%
MYSQL With Sentry38812%447-13%
MYSQL With Sentry (error only)2,55580%2,659-4%

View base workflow run

@Lms24Lms24 mentioned this pull request Mar 5, 2026
Closed
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from 3dcb028 to 098e920CompareMarch 9, 2026 12:57
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
@Lms24Lms24 self-assigned this Mar 9, 2026
@Lms24
Lms24 marked this pull request as ready for review March 9, 2026 13:37
@Lms24
Lms24 requested review from a team, andreiborza and chargome and removed request for a teamMarch 9, 2026 13:37
cursor[bot]
cursorBot reviewed Mar 9, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment threadpackages/angular/package.json Outdated
@Lms24
Lms24force-pushed the lms/test-e2e-angular-canary-fix branch from ece849b to cac1432CompareMarch 9, 2026 13:39
sentry[bot]
sentryBot reviewed Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment threadpackages/angular/package.json Outdated
Lms24
Lms24 commented Mar 9, 2026
View reviewed changes
Comment thread.github/workflows/canary.yml
with:
version: 9.15.9
- name: Set up Node
if: matrix.test-application != 'angular-20'

@Lms24Lms24Mar 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out this was no longer necessary at all. Now we just set Node 22 in the angular-21 package.json.

@Lms24
Lms24 merged commit f83f288 into developMar 9, 2026
226 checks passed
@Lms24
Lms24 deleted the lms/test-e2e-angular-canary-fix branch March 9, 2026 14:43
andreiborza pushed a commit that referenced this pull request Mar 11, 2026
@Lms24
test(angular): Fix failing canary test (#19639)
06c20be
The actual fail mostly "resolved itself" because Angular now also
released `22.0.0-next.0` versions for the Angular CLI packages, in
addition to the core angular packages. However, Angular 22 will
[require](angular/angular-cli#32681)
At least Node 22.22.0.
So this PR makes a few modifications to fully fix Angular canary tests
again:
- set the node version to Node 22.22.0 for the canary test and the
Angular 21 e2e test (which should be fine IMHO)
- Use the `angular-21` app instead of the `angular-20` app for canary
tests
- Remove the optional canary test config in the `angular-20` app
closes#19636
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@chargomechargomeAwaiting requested review from chargomechargome was automatically assigned from getsentry/team-javascript-sdks
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees

@Lms24Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

angular-20 (next) Test Failed

2 participants

@Lms24@s1gr1d