Uh oh!
There was an error while loading. Please reload this page.
ref(core): Simplify core utility functions for smaller bundle - #19854
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
A collection of small, safe simplifications across core utilities: - envelope.ts: Slim ITEM_TYPE_TO_DATA_CATEGORY_MAP by removing 7 self-mapping entries (e.g. session→session). Use a fallback to the type name itself. - object.ts: Replace getOwnProperties manual for-in+hasOwnProperty loop with Object.fromEntries(Object.entries(obj)). Use shorthand value in addNonEnumerableProperty. - baggage.ts: Use .startsWith() instead of .match(regex) for prefix check. - browser.ts: Inline allowedAttrs array literal directly in for-of loop. - eventFilters.ts: Convert verbose DEFAULT_IGNORE_ERRORS string literals to shorter regex patterns with equivalent matching behavior. All changes are behavior-preserving. Combined saves ~80 bytes gzipped. Co-Authored-By: Claude claude@anthropic.com
Lms24force-pushed
the
bundle-size/core-utils-cleanup
branch
from
March 18, 2026 20:34
3908220 to
11523b9CompareLms24
changed the base branch from
autoresearch/browser-bundle-size-2026-03-17
to
developMarch 18, 2026 20:34
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Deps
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Lms24
reviewed
Mar 18, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| */ | ||
| export function envelopeItemTypeToDataCategory(type: EnvelopeItemType): DataCategory { | ||
| return ITEM_TYPE_TO_DATA_CATEGORY_MAP[type]; | ||
| return DATA_CATEGORY_OVERRIDES[type] || (type as DataCategory); |
Member
There was a problem hiding this comment.
We need to retain type safety, otherwise we risk introducing incorrect data categories due to the type check. We can fix it with stricter types on the map and a small validation function. We probably still save some bytes compared to the original implementation.
See 11523b9#diff-588d4f33b2a2c626e7622549bdbbb6662455d9b30261667672be6f0af54074c4
| Object.defineProperty(obj, name, { | ||
| // enumerable: false, // the default, so we can save on bundle size by not explicitly setting it | ||
| value: value, | ||
| value, |
| return extractedProps; | ||
| } else { | ||
| return {}; | ||
| return Object.fromEntries(Object.entries(obj)); |
Lms24
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small, safe simplifications across core utilities. Combined saves ~80 bytes gzipped.
Changes
ITEM_TYPE_TO_DATA_CATEGORY_MAPby removing 7 self-mapping entries (e.g.session: "session"). Falls back to the type name itself.getOwnPropertiesmanualfor...in+hasOwnPropertyloop withObject.fromEntries(Object.entries(obj)). Use shorthandvalueinaddNonEnumerableProperty..startsWith()instead of.match(regex)for sentry prefix check.allowedAttrsarray literal directly in thefor...ofloop.DEFAULT_IGNORE_ERRORSstring literals to shorter regex patterns with equivalent matching behavior (vv().getRestrictions, simulateEvent, solana, _AutofillCallbackHandler).All changes are behavior-preserving.
Part of #19833.
Co-Authored-By: Claude claude@anthropic.com