Uh oh!
There was an error while loading. Please reload this page.
refactor(core): Inline Vue ViewModel checks in normalize and safeJoin - #19855
Closed
HazAT wants to merge 1 commit into
Closed
refactor(core): Inline Vue ViewModel checks in normalize and safeJoin#19855HazAT wants to merge 1 commit into
HazAT wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| if ( | ||
| typeof value === 'object' && | ||
| value !== null && | ||
| ('__isVue' in value || '_isVue' in value || '__v_isVNode' in value) |
There was a problem hiding this comment.
Property existence check differs from original truthiness check
Low Severity
The inlined check uses '__isVue' in value || '_isVue' in value || '__v_isVNode' in value which tests property existence, while the original isVueViewModel tested property truthiness (value.__isVue || value._isVue || value.__v_isVNode). The in operator returns true even if the property value is false, 0, null, or undefined. An object with e.g. { __isVue: false } would now be incorrectly identified as a Vue ViewModel when it previously would not have been. The PR claims identical behavior, but this is a subtle semantic difference.
Additional Locations (1)
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
The isVueViewModel() and getVueInternalName() functions from is.ts and stacktrace.ts were only called from two sites: normalize.ts (stringifyValue) and string.ts (safeJoin). Inlining the checks directly at these call sites allows tree-shaking to eliminate the standalone function definitions from bundles that pull in normalize/string but not is.ts for other reasons. Uses the `in` operator instead of `as any` casts to satisfy the linter's no-explicit-any / no-unsafe-member-access rules. The Vue check prevents infinite console warning loops when stringifying Vue 2/3 ViewModel instances or VNodes (see #8981). Saves ~15 bytes gzipped on the base browser bundle. Co-Authored-By: Claude claude@anthropic.com
Lms24force-pushed
the
bundle-size/inline-vue-checks
branch
from
March 19, 2026 11:39
1141c3c to
21a51b1CompareLms24
changed the base branch from
autoresearch/browser-bundle-size-2026-03-17
to
developMarch 19, 2026 11:39
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Deps
Other
Internal Changes 🔧Core
Other
🤖 This preview updates automatically when you update the PR. |
Lms24
reviewed
Mar 19, 2026
Member
There was a problem hiding this comment.
I'm going to close this. This might slightly improve bundle size but it drastically reduces readability. Plus this vue stuff is prone to sneak into core code, so I'd rather have one/two reusable functions we can just plug into the code path. If we reuse the function once more, it should amortize the bundle cost of declaring a function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inline
isVueViewModel()andgetVueInternalName()at their only two call sites. Saves ~15 bytes gzipped.Problem
isVueViewModel()andgetVueInternalName()are standalone exported functions inis.tsandstacktrace.ts, but they are only called from two places:normalize.ts(stringifyValue) andstring.ts(safeJoin). Keeping them as separate imports prevents tree-shaking from eliminating their definitions.Solution
Inline the check directly using the
inoperator (satisfiesno-explicit-any/no-unsafe-member-accesslint rules):The Vue check prevents infinite console warning loops when stringifying Vue 2/3 ViewModel instances or VNodes (see #8981). The behavior is identical.
Part of #19833.
Co-Authored-By: Claude claude@anthropic.com