Uh oh!
There was an error while loading. Please reload this page.
refactor(browser): Reduce browser package bundle size - #19856
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24force-pushed
the
bundle-size/browser-cleanup
branch
from
March 27, 2026 14:01
8691cef to
712481eCompareLms24
changed the base branch from
autoresearch/browser-bundle-size-2026-03-17
to
developMarch 27, 2026 14:01
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Nuxt
Other
Bug Fixes 🐛Ci
Other
Documentation 📚
Internal Changes 🔧Core
Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
Lms24
approved these changes
Mar 27, 2026
| 'XMLHttpRequestUpload', | ||
| ]; | ||
| // Using a comma-separated string and split for smaller bundle size vs an array literal | ||
| const DEFAULT_EVENT_TARGET = |
Member
There was a problem hiding this comment.
I think this is fine though with gzip compression only makes a minimal difference. We can roll with it here because types don't depend on this array. We can always revert it with minimal size impact if we need it for type safety.
| // Single source of truth: as const array provides both the runtime list and the type. | ||
| // Bundle file names are derived: strip 'Integration' suffix, lowercase. | ||
| // Exceptions (hyphenated bundle names) are listed in HYPHENATED_BUNDLES. | ||
| const LAZY_LOADABLE_NAMES = [ |
Member
There was a problem hiding this comment.
I made a few changes here: We need the list here for type safety but not the full object as before. This should still save a few bytes in comparison to the initial change.
| 'createLangChainCallbackHandler', | ||
| ] as const; | ||
| type LazyLoadableIntegrationName = (typeof LAZY_LOADABLE_NAMES)[number]; |
Lms24
enabled auto-merge (squash)
March 27, 2026 15:44
A collection of small, safe optimizations across the browser package: - helpers.ts: Rename internal `sentryWrapped` function to `sW` in the wrap() helper. Update the frame stripping regex in core/stacktrace.ts to match both names for backwards compatibility. Saves ~10B gzipped. - breadcrumbs.ts: Remove unused `breadcrumbData` variable from the fetch breadcrumb handler — it was constructed but never used in either branch. - browserapierrors.ts: Encode DEFAULT_EVENT_TARGET as comma-separated string.split() instead of array literal. Saves 51B raw. - globalhandlers.ts: Remove redundant intermediate variable aliases in _enhanceEventWithInitialFrame. - detectBrowserExtension.ts: Replace array.some(startsWith) with a single regex test for extension protocol detection. - eventbuilder.ts: Simplify getErrorPropertyFromObject to use Object.values().find() instead of manual for-in loop. - lazyLoadIntegration.ts: Derive CDN bundle filenames from integration names instead of storing duplicate key-value pairs. Uses a 3-entry exceptions map for hyphenated names (replay-canvas, feedback-modal, feedback-screenshot). Saves ~30B gzipped. All changes are behavior-preserving. No public API modifications. Co-Authored-By: Claude claude@anthropic.com
Lms24force-pushed
the
bundle-size/browser-cleanup
branch
from
March 30, 2026 10:31
ccf6cb6 to
aa4523cCompareUh oh!
There was an error while loading. Please reload this page.
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A collection of small, safe optimizations across the browser package. Combined saves ~60 bytes gzipped.
Changes
UPDATE (@Lms24): Removed some initial changes, leaving them here for posterity
helpers.ts+stacktrace.tsRename internalsentryWrapped→sWin wrap(). Update frame stripping regex to match both names.10B gzipbreadcrumbs.tsbreadcrumbDatavariable from fetch handlerbrowserapierrors.tsDEFAULT_EVENT_TARGETasstring.split(",")instead of array literalglobalhandlers.ts_enhanceEventWithInitialFramedetectBrowserExtension.tsarray.some(startsWith)with single regex testeventbuilder.tsgetErrorPropertyFromObjecttoObject.values().find()lazyLoadIntegration.tsintegration nameslist of integration names instead of storing duplicate key-value pairslazyLoadIntegration detail
The
LazyLoadableIntegrationsobject stored 21 key-value pairs where values were mostly derivable from keys (strip"Integration", lowercase). Replaced with:string.split(","))replay-canvas,feedback-modal,feedback-screenshot)All changes are behavior-preserving. No public API modifications.
Part of #19833.
Co-Authored-By: Claude claude@anthropic.com