Skip to content

fix(react-router): Disable debug ID injection in Vite plugin to prevent double injection#19890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaacs merged 1 commit into from
Mar 30, 2026
Merged

fix(react-router): Disable debug ID injection in Vite plugin to prevent double injection #19890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-router/src/vite/makeCustomSentryVitePlugins.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ export async function makeCustomSentryVitePlugins(options: SentryReactRouterBuil
},
// will be handled in buildEnd hook
sourcemaps: {
disable: 'disable-upload',
disable: true,

@cursorcursorBotMar 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spread overwrites disable: true when sourcemaps options provided

Medium Severity

The new disable: true at line 45 is correctly set to prevent double debug ID injection. However, ...unstable_sentryVitePluginOptions at line 48 spreads after the sourcemaps key, so if a user passes any unstable_sentryVitePluginOptions.sourcemaps property (e.g., { assets: ['dist/**'] }), the entire sourcemaps object—including disable: true—is replaced. This silently re-introduces the double injection bug the PR aims to fix. The existing test at line 69–86 confirms this: it expects disable to be absent after an override.

Fix in CursorFix in Web

...unstable_sentryVitePluginOptions?.sourcemaps,
},
...unstable_sentryVitePluginOptions,
Expand Down
4 changes: 2 additions & 2 deletions packages/react-router/test/vite/makeCustomSentryVitePlugins.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,13 +54,13 @@ describe('makeCustomSentryVitePlugins', () => {
expect(plugins?.[0]?.name).toBe('sentry-vite-plugin');
});

it('should disable sourcemap upload with "disable-upload" by default', async () => {
it('should disable sourcemap upload by default', async () => {
await makeCustomSentryVitePlugins({});

expect(sentryVitePlugin).toHaveBeenCalledWith(
expect.objectContaining({
sourcemaps: expect.objectContaining({
disable: 'disable-upload',
disable: true,
}),
}),
);
Expand Down
Loading