ref(core): Introduce instrumented method registry for AI integrations by nicohrubec · Pull Request #19981 · getsentry/sentry-javascript

nicohrubec · 2026-03-25T15:40:59Z

Replace the shared getOperationName() function with per-provider method registries that map API paths to their operation name and streaming behavior. This explicitly couples the instrumented methods and necessary metadata in one place instead of having convoluted substring matching in multiple places that can be quite hard to reason about.

Closes#19987 (added automatically)

github-actions · 2026-03-25T15:41:36Z

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

(node) Add nodeRuntimeMetricsIntegration by chargome in #19923
(nuxt) Support parametrized SSR routes in Nuxt 5 by s1gr1d in #19977

Bug Fixes 🐛

(e2e) Pin @opentelemetry/api to 1.9.0 in ts3.8 test app by logaretm in #19992
(opentelemetry) Convert seconds timestamps in span.end() to milliseconds by logaretm in #19958

Documentation 📚

(release) Update publishing-a-release.md by nicohrubec in #19982

Internal Changes 🔧

Core

Introduce instrumented method registry for AI integrations by nicohrubec in #19981

Consolidate getOperationName into one shared utility by nicohrubec in #19971

Other

(deno) Expand Deno E2E test coverage by chargome in #19957

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-03-25T15:50:28Z

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path	Size	% Change	Change
@sentry/browser	25.69 kB	+0.2%	+49 B 🔺
@sentry/browser - with treeshaking flags	24.17 kB	+0.14%	+33 B 🔺
@sentry/browser (incl. Tracing)	42.67 kB	+0.13%	+54 B 🔺
@sentry/browser (incl. Tracing, Profiling)	47.33 kB	+0.12%	+55 B 🔺
@sentry/browser (incl. Tracing, Replay)	81.48 kB	+0.08%	+57 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	71.06 kB	+0.1%	+69 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)	86.17 kB	+0.06%	+50 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)	98.41 kB	+0.04%	+36 B 🔺
@sentry/browser (incl. Feedback)	42.48 kB	+0.08%	+30 B 🔺
@sentry/browser (incl. sendFeedback)	30.35 kB	+0.15%	+44 B 🔺
@sentry/browser (incl. FeedbackAsync)	35.4 kB	+0.12%	+39 B 🔺
@sentry/browser (incl. Metrics)	26.96 kB	+0.14%	+37 B 🔺
@sentry/browser (incl. Logs)	27.1 kB	+0.12%	+32 B 🔺
@sentry/browser (incl. Metrics & Logs)	27.78 kB	+0.15%	+39 B 🔺
@sentry/react	27.45 kB	+0.22%	+58 B 🔺
@sentry/react (incl. Tracing)	45.01 kB	+0.14%	+60 B 🔺
@sentry/vue	30.13 kB	+0.16%	+46 B 🔺
@sentry/vue (incl. Tracing)	44.52 kB	+0.09%	+39 B 🔺
@sentry/svelte	25.7 kB	+0.16%	+40 B 🔺
CDN Bundle	28.35 kB	+0.27%	+75 B 🔺
CDN Bundle (incl. Tracing)	43.57 kB	+0.15%	+62 B 🔺
CDN Bundle (incl. Logs, Metrics)	29.22 kB	+0.27%	+77 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)	44.43 kB	+0.17%	+75 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)	68.3 kB	+0.13%	+86 B 🔺
CDN Bundle (incl. Tracing, Replay)	80.41 kB	+0.1%	+73 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	81.31 kB	+0.1%	+76 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	85.97 kB	+0.12%	+103 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	86.85 kB	+0.1%	+85 B 🔺
CDN Bundle - uncompressed	82.7 kB	+0.1%	+77 B 🔺
CDN Bundle (incl. Tracing) - uncompressed	128.62 kB	+0.05%	+64 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed	85.57 kB	+0.1%	+77 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	131.49 kB	+0.05%	+64 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	209.22 kB	+0.05%	+102 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed	245.5 kB	+0.04%	+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	248.35 kB	+0.04%	+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	258.41 kB	+0.04%	+89 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	261.26 kB	+0.04%	+89 B 🔺
@sentry/nextjs (client)	47.4 kB	+0.08%	+37 B 🔺
@sentry/sveltekit (client)	43.12 kB	+0.12%	+51 B 🔺
@sentry/node-core	56.46 kB	+0.2%	+112 B 🔺
@sentry/node	173.49 kB	+0.19%	+328 B 🔺
@sentry/node - without tracing	96.47 kB	+0.13%	+123 B 🔺
@sentry/aws-serverless	113.48 kB	+0.13%	+143 B 🔺

View base workflow run

github-actions · 2026-03-25T15:52:07Z

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario	Requests/s	% of Baseline	Prev. Requests/s	Change %
GET Baseline	9,384	-	9,058	+4%
GET With Sentry	1,769	19%	1,677	+5%
GET With Sentry (error only)	6,196	66%	6,200	-0%
POST Baseline	1,199	-	1,190	+1%
POST With Sentry	594	50%	566	+5%
POST With Sentry (error only)	1,061	88%	1,057	+0%
MYSQL Baseline	3,276	-	3,307	-1%
MYSQL With Sentry	446	14%	470	-5%
MYSQL With Sentry (error only)	2,654	81%	2,684	-1%

View base workflow run

chargome

LGTM, pls do a double-check if the types that got deleted were exported, bc then this would be breaking technically. Would mention this in the changelog if that's the case

chargome · 2026-03-26T14:03:26Z

+ 'models.generateContentStream': { operation: 'generate_content', streaming: true },
+ 'chats.create': { operation: 'chat' },
+ // chat.* paths are built by createDeepProxy when it proxies the chat instance with CHAT_PATH as base
+ 'chat.sendMessage': { operation: 'chat' },


l: we could actually use CHAT_PATH here instead of hardcoding

I'll likely get rid of CHAT_PATH in a follow up, can think about introducing a more broad operations objects to handle all of these ops constants

nicohrubec · 2026-03-26T14:55:39Z

@chargome right they are exported (for reasons idk because they are not used anywhere it seems). I put them back in with a deprecation notice

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

logaretm

Pretty good refactor

nicohrubec added 6 commits March 25, 2026 13:11

.
6b1f244

consolidate
1f47c32

text completions are no longer a thing
8ebae83

update comment
a3b3d3e

.
1a368b1

.
c18efbe

nicohrubec added 8 commits March 26, 2026 10:31

.
6806fba

Merge branch 'develop' into nh/consolidate-operation-api-path
e3e1e59

fix
d02e819

.
6fa9aa7

remove unneeded types
8d318f9

.
06998ac

remove unneeded tests
90fd6db

lint
114e21e

nicohrubec changed the title ~~ref(core): Couple api and operation name in ai integrations~~ref(core): Introduce instrumented method registry for AI integrationsMar 26, 2026

nicohrubec marked this pull request as ready for review March 26, 2026 10:42

github-actionsBot mentioned this pull request Mar 26, 2026
ref(core): Introduce instrumented method registry for AI integrations #19987
Closed

nicohrubec requested review from JPeer264, chargome and logaretm March 26, 2026 10:43

cursorBot reviewed Mar 26, 2026
View reviewed changes

Comment threadpackages/core/src/index.ts Outdated

nicohrubec mentioned this pull request Mar 26, 2026
ref(core): Do not emit spans for chats.create in google-genai #19990
Merged

chargome approved these changes Mar 26, 2026
View reviewed changes

do not remove types
0e894f2

cursorBot reviewed Mar 26, 2026
View reviewed changes

Comment threadpackages/core/src/tracing/google-genai/constants.ts

Merge branch 'develop' into nh/consolidate-operation-api-path
2a5dc33

cursorBot reviewed Mar 26, 2026
View reviewed changes

Comment threadpackages/core/src/tracing/openai/types.ts

nicohrubec added 2 commits March 26, 2026 18:16

types
93b06e4

types
443a294

logaretm approved these changes Mar 26, 2026
View reviewed changes

nicohrubec merged commit e3bdbed into developMar 26, 2026
464 of 469 checks passed

nicohrubec deleted the nh/consolidate-operation-api-path branch March 26, 2026 18:06

sentry-release-botBot mentioned this pull request Mar 31, 2026
publish: getsentry/sentry-javascript@10.47.0 getsentry/publish#7651
Closed
46 tasks

Uh oh!

Uh oh!

Conversation

nicohrubec commented Mar 25, 2026• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Mar 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

New Features ✨

Bug Fixes 🐛

Documentation 📚

Internal Changes 🔧

Core

Other

Uh oh!

github-actionsBot commented Mar 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

github-actionsBot commented Mar 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

node-overhead report 🧳

Uh oh!

Uh oh!

chargome left a comment

Choose a reason for hiding this comment

Uh oh!

chargomeMar 26, 2026

Choose a reason for hiding this comment

Uh oh!

nicohrubecMar 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nicohrubec commented Mar 26, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

logaretm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nicohrubec commented Mar 25, 2026•
edited by github-actions Bot
Loading

github-actionsBot commented Mar 25, 2026•
edited
Loading

github-actionsBot commented Mar 25, 2026•
edited
Loading

github-actionsBot commented Mar 25, 2026•
edited
Loading