Uh oh!
There was an error while loading. Please reload this page.
fix(e2e): Pin @opentelemetry/api to 1.9.0 in ts3.8 test app - #19992
Conversation
@opentelemetry/api@1.9.1 (released Mar 25) introduced inline type
modifiers (`export { Foo, type Bar }`) in its type definitions, which
requires TypeScript 4.5+. This breaks the generic-ts3.8 E2E test that
type-checks with `skipLibCheck: false` using TypeScript 3.8.
Pin to 1.9.0 via pnpm overrides to restore compatibility.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
There was a problem hiding this comment.
Pull request overview
This PR prevents downstream TypeScript build failures by pinning @opentelemetry/api to 1.9.0 (instead of ^1.9.0) so consumers don’t accidentally resolve to 1.9.1, whose .d.ts output requires TypeScript 4.5+.
Changes:
- Replaced
@opentelemetry/apidependency ranges (^1.9.0) with an exact version (1.9.0) across affected SDK packages. - Updated both
dependenciesand (where applicable)peerDependencies/devDependenciesto ensure the pin applies for both runtime installs and local development.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/aws-serverless/package.json | Pins @opentelemetry/api to 1.9.0 to avoid consumers resolving to 1.9.1. |
| packages/cloudflare/package.json | Pins @opentelemetry/api to 1.9.0 to avoid TypeScript incompatibility issues. |
| packages/deno/package.json | Pins @opentelemetry/api to 1.9.0 for stable consumer installs. |
| packages/hono/package.json | Pins @opentelemetry/api to 1.9.0 to prevent transitive upgrade to 1.9.1. |
| packages/nestjs/package.json | Pins @opentelemetry/api to 1.9.0 for compatibility with older TS toolchains. |
| packages/nextjs/package.json | Pins @opentelemetry/api to 1.9.0 to avoid incompatible .d.ts syntax in 1.9.1. |
| packages/node/package.json | Pins @opentelemetry/api to 1.9.0 for deterministic dependency resolution. |
| packages/node-core/package.json | Pins @opentelemetry/api to 1.9.0 in both peer + dev deps to prevent consumers using 1.9.1. |
| packages/opentelemetry/package.json | Pins @opentelemetry/api to 1.9.0 in peer + dev deps to enforce compatibility. |
| packages/react-router/package.json | Pins @opentelemetry/api to 1.9.0 to block transitive 1.9.1. |
| packages/remix/package.json | Pins @opentelemetry/api to 1.9.0 to prevent TS <4.5 typecheck failures. |
| packages/tanstackstart-react/package.json | Pins @opentelemetry/api to 1.9.0 to keep consumer installs TS-compatible. |
| packages/vercel-edge/package.json | Pins @opentelemetry/api to 1.9.0 to avoid resolving to 1.9.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| }, | ||
| "peerDependencies": { | ||
| "@opentelemetry/api": "^1.9.0", | ||
| "@opentelemetry/api": "1.9.0", |
There was a problem hiding this comment.
Exact-pinned peerDependencies will break user installs
High Severity
Pinning @opentelemetry/api to exactly 1.9.0 in peerDependencies (in @sentry/opentelemetry and @sentry/node-core) will cause ERESOLVE hard errors on npm 7+ for users who have any other version of @opentelemetry/api installed. Since the broader OTel ecosystem uses ^1.x peer dep ranges, users with other OTel packages will almost certainly resolve to 1.9.1, conflicting with this exact pin. Peer dependencies don't control what gets installed — only dependencies does — so the pin here doesn't prevent the problematic version but does break installs. The ^1.9.0 range should be kept for peerDependencies.
Additional Locations (1)
| }, | ||
| "peerDependencies": { | ||
| "@opentelemetry/api": "^1.9.0", | ||
| "@opentelemetry/api": "1.9.0", |
There was a problem hiding this comment.
Bug: The peerDependency on @opentelemetry/api is pinned to an exact version ("1.9.0"), which will cause npm install to fail for users with any other version installed.
Severity: HIGH
Suggested Fix
The peerDependencies for @opentelemetry/api should be changed from the exact version "1.9.0" to a more flexible range, such as ">=1.9.0" or "^1.9.0". This allows users to have other compatible 1.x versions of @opentelemetry/api installed in their project without causing installation conflicts, while the version shipped by the SDK is controlled via the dependencies field.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/opentelemetry/package.json#L45
Potential issue: Pinning `@opentelemetry/api` to an exact version `"1.9.0"` in
`peerDependencies` in `packages/opentelemetry/package.json` will cause installation
failures for users. With npm 7+, if a user's project depends on any version of
`@opentelemetry/api` other than exactly `1.9.0` (e.g., `1.9.1`), `npm install` will fail
with an `ERESOLVE` error. This blocks the installation process entirely, preventing
users from installing or updating their dependencies. This is especially problematic for
users of `@sentry/opentelemetry` who are likely to have `@opentelemetry/api` as a direct
dependency in their project.
Did we get this right? 👍 / 👎 to inform future reviews.
a6ebae6 to
c57b0abCompareUh oh!
There was an error while loading. Please reload this page.
Summary
@opentelemetry/api@1.9.1was released on Mar 25 and introducedexport { Foo, type Bar }syntax (inline type modifiers) in its.d.tsfiles, which requires TypeScript 4.5+generic-ts3.8E2E test runs withskipLibCheck: falseand TypeScript 3.8, so it tries to parse OTel's types and fails@opentelemetry/apito1.9.0in the ts3.8 test app viapnpm.overrides@opentelemetry/sdk-trace-basecause the tracer to become a no-op.d.tsfiles are unaffected — only OTel's own types use the incompatible syntaxTest plan
yarn test:run generic-ts3.8passes with the pinE2E generic-ts3.8 Testshould go green🤖 Generated with Claude Code
Closes#19998 (added automatically)