Uh oh!
There was an error while loading. Please reload this page.
fix(nuxt): Use virtual module for Nuxt pages data (SSR route parametrization) - #20020
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Core
Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| filename: 'sentry--nuxt-pages-data.mjs', | ||
| getContents: () => `export default ${JSON.stringify(pagesData, null, 2)};`, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Fix PR missing regression test for virtual module
Low Severity
This is a fix PR that introduces a new virtual module strategy for Nuxt v4+ and a new legacy plugin file, but doesn't include any unit, integration, or E2E test to validate the regression (SSR route parametrization issue #20010). Adding a test that verifies the virtual module approach works for Nuxt v4+ and the template fallback for Nuxt v3 would help prevent regressions.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Member
There was a problem hiding this comment.
We have Nuxt 4 tests already covering that
Contributor
size-limit report 📦
|
logaretm
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a virtual module with Vite when using Nuxt 4+ instead of creating a template.
useServerTemplate()cannot be used here as it's not Nitro-only but the SSR-space (server) within Nuxt.Closes#20010