Uh oh!
There was an error while loading. Please reload this page.
feat(deno): Add denoRuntimeMetricsIntegration - #20023
Merged
Merged
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
chargome
marked this pull request as ready for review
March 30, 2026 12:32
Uh oh!
There was an error while loading. Please reload this page.
chargome added a commit
to getsentry/sentry-docs
that referenced
this pull request
Mar 30, 2026
Document the new denoRuntimeMetricsIntegration for collecting Deno runtime health metrics (memory, uptime). Ref: getsentry/sentry-javascript#20023 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6 tasks
Uh oh!
There was an error while loading. Please reload this page.
…erval Global setInterval in Deno returns a number at runtime, not NodeJS.Timeout. _INTERNAL_safeUnref is a no-op for numbers (it checks typeof timer === 'object'). Use Deno.unrefTimer directly instead, with a type cast to work around @types/node polluting the global setInterval signature in the monorepo. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chargome added a commit
to getsentry/sentry-docs
that referenced
this pull request
Mar 31, 2026
Document the new denoRuntimeMetricsIntegration for collecting Deno runtime health metrics (memory, uptime). Ref: getsentry/sentry-javascript#20023 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chargome
requested review from
a team, Lms24, andreiborza, nicohrubec and stephanie-anderson
and removed request for
a team and stephanie-andersonMarch 31, 2026 13:14
denoRuntimeMetricsIntegrationUh oh!
There was an error while loading. Please reload this page.
Sub-second collection intervals provide no practical observability value and would cause unnecessary CPU overhead from tight Deno.memoryUsage() calls. Clamp to 1000ms and warn so misconfigured integrations are visible. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nicohrubec
approved these changes
Mar 31, 2026
…clamp NaN < 1000 evaluates to false (skipping the warning) and Math.max(NaN, 1000) returns NaN, causing setInterval(fn, NaN) to fire at near-zero interval. Use Number.isFinite to catch NaN and Infinity before applying Math.max. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Oxlint flags bare console.* references as errors. Use globalThis.console to bypass the rule while still intercepting the integration's warnings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
46 tasks
chargome added a commit
to getsentry/sentry-docs
that referenced
this pull request
Apr 20, 2026
## DESCRIBE YOUR PR Document the new `denoRuntimeMetricsIntegration` added in getsentry/sentry-javascript#20023. Documents getsentry/sentry-javascript#20023 - Add integration documentation page with default/opt-in metrics table and configuration options - Add integration to the Deno platform integration table ## IS YOUR CHANGE URGENT? - [ ] Urgent deadline (GA date, etc.) - [ ] Other deadline - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sentrivana pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
May 18, 2026
## DESCRIBE YOUR PR Document the new `denoRuntimeMetricsIntegration` added in getsentry/sentry-javascript#20023. Documents getsentry/sentry-javascript#20023 - Add integration documentation page with default/opt-in metrics table and configuration options - Add integration to the Deno platform integration table ## IS YOUR CHANGE URGENT? - [ ] Urgent deadline (GA date, etc.) - [ ] Other deadline - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
denoRuntimeMetricsIntegrationto@sentry/denothat collects runtime health metrics on a configurable interval (default: 30s).Default metrics (
deno.runtime.*prefix):mem.rss— Resident Set Sizemem.heap_used— V8 heap in usemem.heap_total— total V8 heapprocess.uptime— process uptimeOpt-in:
memExternalenablesmem.externalvs.
nodeRuntimeMetricsIntegration: No CPU or event loop metrics — Deno does not exposeprocess.cpuUsage(),performance.eventLoopUtilization(), ormonitorEventLoopDelay.Note: Deno's loadavg() reflects system-wide load across all processes rather than the Deno process itself, which is why we did not include it.
closes https://linear.app/getsentry/issue/JS-1957/runtime-metrics-deno-support