Uh oh!
There was an error while loading. Please reload this page.
ref(core): Unify .do* span ops to gen_ai.generate_content - #20074
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Core
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
nicohrubec
marked this pull request as ready for review
April 1, 2026 13:44
chargome
approved these changes
Apr 1, 2026
chargome
left a comment
Member
There was a problem hiding this comment.
Might be worth calling out in the changelog in case someone depends on these span names.
| return GEN_AI_GENERATE_OBJECT_DO_GENERATE_OPERATION_ATTRIBUTE; | ||
| case 'ai.streamObject.doStream': | ||
| return GEN_AI_STREAM_OBJECT_DO_STREAM_OPERATION_ATTRIBUTE; | ||
| return 'gen_ai.generate_content'; |
Member
There was a problem hiding this comment.
l: the other attributes are stored in a constant, maybe do the same here?
MemberAuthor
There was a problem hiding this comment.
Sure, I likely wanna get rid of the constants used here but I'll put one in for now to keep it consistent
andreiborza
approved these changes
Apr 2, 2026
Uh oh!
There was an error while loading. Please reload this page.
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vercel AI integration had 4 distinct span op values for inner
.do*spans (gen_ai.generate_text,gen_ai.stream_text,gen_ai.generate_object,gen_ai.stream_object), even though all of them sharegenerate_contentas operation name. Every other AI integration derives the span op asgen_ai.${operationName}, so these should all begen_ai.generate_content.