Skip to content

fix(deno): Avoid inferring invalid span op from Deno tracer - #20128

Merged
Lms24 merged 2 commits into
developfrom
lms/fix-deno-invalid-span-op
Apr 10, 2026
Merged

fix(deno): Avoid inferring invalid span op from Deno tracer#20128
Lms24 merged 2 commits into
developfrom
lms/fix-deno-invalid-span-op

Conversation

@Lms24

@Lms24Lms24 commented Apr 8, 2026

Copy link
Copy Markdown
Member

Looks like an invalid span op snuck into the Deno SDK when we pick up spans from Deno's tracer. We have a _mapSpanKindToOp helper in there which as a default value returned otel.span. This value does not align with our definition of span ops. Instead, if we can't infer a span op, we should just not set one in the first place.

(side-note: Long-term, we might need something more sophisticated here like inferSpanData in the Node SDK. But for now, I'd rather remove the invalid op and move on. Only came across this while working on #20127)

@github-actions

github-actionsBot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Core

  • Add enableTruncation option to OpenAI integration by andreiborza in #20167
  • Export a reusable function to add tracing headers by JPeer264 in #20076

Other

  • (deps) Bump defu from 6.1.4 to 6.1.6 by dependabot in #20104

Bug Fixes 🐛

  • (deno) Avoid inferring invalid span op from Deno tracer by Lms24 in #20128

Internal Changes 🔧

  • (bugbot) Add rules to flag test-flake-provoking patterns by Lms24 in #20192
  • (size-limit) Bump failing size limit scenario by Lms24 in #20186

🤖 This preview updates automatically when you update the PR.

@Lms24Lms24 self-assigned this Apr 8, 2026
@Lms24
Lms24 requested review from chargome and sergicalApril 8, 2026 17:30
@github-actions

github-actionsBot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser25.72 kB+0.31%+77 B 🔺
@sentry/browser - with treeshaking flags24.21 kB+0.34%+82 B 🔺
@sentry/browser (incl. Tracing)42.73 kB+1.36%+573 B 🔺
@sentry/browser (incl. Tracing, Profiling)47.35 kB+1.25%+583 B 🔺
@sentry/browser (incl. Tracing, Replay)81.54 kB+0.75%+600 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags71.11 kB+0.78%+549 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)86.25 kB+0.7%+594 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)98.45 kB+0.56%+541 B 🔺
@sentry/browser (incl. Feedback)42.51 kB+0.21%+87 B 🔺
@sentry/browser (incl. sendFeedback)30.39 kB+0.27%+80 B 🔺
@sentry/browser (incl. FeedbackAsync)35.38 kB+0.24%+82 B 🔺
@sentry/browser (incl. Metrics)27.04 kB+0.31%+83 B 🔺
@sentry/browser (incl. Logs)27.18 kB+0.3%+81 B 🔺
@sentry/browser (incl. Metrics & Logs)27.86 kB+0.29%+80 B 🔺
@sentry/react27.48 kB+0.26%+71 B 🔺
@sentry/react (incl. Tracing)45.05 kB+1.28%+566 B 🔺
@sentry/vue30.56 kB+1.61%+483 B 🔺
@sentry/vue (incl. Tracing)44.59 kB+1.23%+538 B 🔺
@sentry/svelte25.74 kB+0.31%+77 B 🔺
CDN Bundle28.41 kB+0.3%+83 B 🔺
CDN Bundle (incl. Tracing)43.75 kB+1.46%+628 B 🔺
CDN Bundle (incl. Logs, Metrics)29.78 kB+0.31%+92 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)44.83 kB+1.5%+660 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)68.59 kB+0.16%+103 B 🔺
CDN Bundle (incl. Tracing, Replay)80.64 kB+0.78%+621 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)81.66 kB+0.75%+604 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)86.17 kB+0.72%+615 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)87.2 kB+0.71%+610 B 🔺
CDN Bundle - uncompressed82.99 kB+0.34%+279 B 🔺
CDN Bundle (incl. Tracing) - uncompressed129.77 kB+1.5%+1.92 kB 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed87.14 kB+0.33%+279 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed133.19 kB+1.46%+1.92 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed210.12 kB+0.14%+279 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed246.65 kB+0.79%+1.92 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed250.05 kB+0.78%+1.92 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed259.56 kB+0.75%+1.92 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed262.95 kB+0.74%+1.92 kB 🔺
@sentry/nextjs (client)47.47 kB+1.24%+579 B 🔺
@sentry/sveltekit (client)43.2 kB+1.36%+577 B 🔺
@sentry/node-core57.86 kB+3.78%+2.1 kB 🔺
@sentry/node174.83 kB+1.42%+2.43 kB 🔺
@sentry/node - without tracing97.97 kB+2.02%+1.94 kB 🔺
@sentry/aws-serverless115.22 kB+2.11%+2.38 kB 🔺

View base workflow run

@Lms24
Lms24 marked this pull request as ready for review April 9, 2026 09:06
Comment threaddev-packages/e2e-tests/test-applications/deno/tests/ai.test.ts Outdated
@Lms24
Lms24 enabled auto-merge (squash) April 10, 2026 10:17

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c3468bf. Configure here.

Comment threadpackages/deno/src/opentelemetry/tracer.ts
@github-actions

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,464-9,230+3%
GET With Sentry1,81119%1,837-1%
GET With Sentry (error only)6,10665%6,130-0%
POST Baseline1,199-1,209-1%
POST With Sentry60050%611-2%
POST With Sentry (error only)1,05488%1,050+0%
MYSQL Baseline3,221-3,295-2%
MYSQL With Sentry47915%440+9%
MYSQL With Sentry (error only)2,61381%2,678-2%

View base workflow run

@Lms24
Lms24 merged commit 01a04ab into developApr 10, 2026
474 of 476 checks passed
@Lms24
Lms24 deleted the lms/fix-deno-invalid-span-op branch April 10, 2026 10:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@chargome