Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(core): Add enableTruncation option to LangGraph integration#20183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a5c479e
feat(core): Add `enableTruncation` option to LangGraph integration
andreiborza 632fe0e
Bump size limit
andreiborza d8673e3
Revert "Bump size limit"
nicohrubec 2a810c4
multi-message scenario test
nicohrubec 5fa2f5c
exact match
nicohrubec aafdc26
Merge branch 'develop' into ab/langgraph-enable-truncation-option
nicohrubec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
17 changes: 17 additions & 0 deletions
17 dev-packages/node-integration-tests/suites/tracing/langgraph/instrument-no-truncation.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import * as Sentry from '@sentry/node'; | ||
| import { loggingTransport } from '@sentry-internal/node-integration-tests'; | ||
| Sentry.init({ | ||
| dsn: 'https://public@dsn.ingest.sentry.io/1337', | ||
| release: '1.0', | ||
| tracesSampleRate: 1.0, | ||
| sendDefaultPii: true, | ||
| transport: loggingTransport, | ||
| integrations: [ | ||
| Sentry.langGraphIntegration({ | ||
| recordInputs: true, | ||
| recordOutputs: true, | ||
| enableTruncation: false, | ||
| }), | ||
| ], | ||
| }); | ||
46 changes: 46 additions & 0 deletions
46 dev-packages/node-integration-tests/suites/tracing/langgraph/scenario-no-truncation.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import { END, MessagesAnnotation, START, StateGraph } from '@langchain/langgraph'; | ||
| import * as Sentry from '@sentry/node'; | ||
| async function run() { | ||
| await Sentry.startSpan({ op: 'function', name: 'langgraph-test' }, async () => { | ||
| const mockLlm = () => { | ||
| return { | ||
| messages: [ | ||
| { | ||
| role: 'assistant', | ||
| content: 'Mock LLM response', | ||
| response_metadata: { | ||
| model_name: 'mock-model', | ||
| finish_reason: 'stop', | ||
| tokenUsage: { | ||
| promptTokens: 20, | ||
| completionTokens: 10, | ||
| totalTokens: 30, | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| }; | ||
| }; | ||
| const graph = new StateGraph(MessagesAnnotation) | ||
| .addNode('agent', mockLlm) | ||
| .addEdge(START, 'agent') | ||
| .addEdge('agent', END) | ||
| .compile({ name: 'weather_assistant' }); | ||
| // Multiple messages with long content (would normally be truncated and popped to last message only) | ||
| const longContent = 'A'.repeat(50_000); | ||
| await graph.invoke({ | ||
| messages: [ | ||
| { role: 'user', content: longContent }, | ||
| { role: 'assistant', content: 'Some reply' }, | ||
| { role: 'user', content: 'Follow-up question' }, | ||
| ], | ||
| }); | ||
| }); | ||
| await Sentry.flush(2000); | ||
| } | ||
| run(); |
34 changes: 34 additions & 0 deletions
34 dev-packages/node-integration-tests/suites/tracing/langgraph/test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -4,6 +4,7 @@ import { | ||
| GEN_AI_AGENT_NAME_ATTRIBUTE, | ||
| GEN_AI_CONVERSATION_ID_ATTRIBUTE, | ||
| GEN_AI_INPUT_MESSAGES_ATTRIBUTE, | ||
| GEN_AI_INPUT_MESSAGES_ORIGINAL_LENGTH_ATTRIBUTE, | ||
| GEN_AI_OPERATION_NAME_ATTRIBUTE, | ||
| GEN_AI_PIPELINE_NAME_ATTRIBUTE, | ||
| GEN_AI_REQUEST_AVAILABLE_TOOLS_ATTRIBUTE, | ||
| @@ -364,4 +365,37 @@ describe('LangGraph integration', () => { | ||
| await createRunner().ignore('event').expect({ transaction: EXPECTED_TRANSACTION_RESUME }).start().completed(); | ||
| }); | ||
| }); | ||
| const longContent = 'A'.repeat(50_000); | ||
| const EXPECTED_TRANSACTION_NO_TRUNCATION = { | ||
| transaction: 'langgraph-test', | ||
| spans: expect.arrayContaining([ | ||
| expect.objectContaining({ | ||
| data: expect.objectContaining({ | ||
| [GEN_AI_INPUT_MESSAGES_ATTRIBUTE]: JSON.stringify([ | ||
| { role: 'user', content: longContent }, | ||
| { role: 'assistant', content: 'Some reply' }, | ||
| { role: 'user', content: 'Follow-up question' }, | ||
| ]), | ||
| [GEN_AI_INPUT_MESSAGES_ORIGINAL_LENGTH_ATTRIBUTE]: 3, | ||
| }), | ||
nicohrubec marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| }), | ||
| ]), | ||
| }; | ||
| createEsmAndCjsTests( | ||
| __dirname, | ||
| 'scenario-no-truncation.mjs', | ||
| 'instrument-no-truncation.mjs', | ||
| (createRunner, test) => { | ||
| test('does not truncate input messages when enableTruncation is false', async () => { | ||
| await createRunner() | ||
| .ignore('event') | ||
| .expect({ transaction: EXPECTED_TRANSACTION_NO_TRUNCATION }) | ||
| .start() | ||
| .completed(); | ||
| }); | ||
| }, | ||
| ); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.