Uh oh!
There was an error while loading. Please reload this page.
feat(node): Implement registerModuleWrapper as alternative IITM/RITM wrapping method - #20188
Closed
mydea wants to merge 2 commits into
Closed
feat(node): Implement registerModuleWrapper as alternative IITM/RITM wrapping method#20188mydea wants to merge 2 commits into
registerModuleWrapper as alternative IITM/RITM wrapping method#20188mydea wants to merge 2 commits into
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
mydeaforce-pushed
the
fn/custom-iitm-wrapping
branch
from
April 10, 2026 08:38
6c2f752 to
9192a07Compareisaacs
reviewed
Apr 10, 2026
Uh oh!
There was an error while loading. Please reload this page.
isaacs
reviewed
Apr 10, 2026
| /* eslint-disable no-param-reassign */ | ||
| import * as path from 'node:path'; | ||
| import { Hook } from 'require-in-the-middle'; |
Member
There was a problem hiding this comment.
Presumably we'll also need a version of this for iitm, and also need to pull the relevant guts out for use in Bun, right?
Member
There was a problem hiding this comment.
Oh, wait, nevermind, this is node-core, not core, so no bun stuff. But we do need IITM.
MemberAuthor
There was a problem hiding this comment.
nothing needed for iitm I beleive, I think this takes care of this under the hood - at least, in otel, they only have this functionality for RITM 🤔
3 tasks
mydeaforce-pushed
the
fn/custom-iitm-wrapping
branch
from
May 5, 2026 13:46
956e1d1 to
066e637Comparemydea
commented
May 21, 2026
MemberAuthor
Closed in favor of #20900 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #20171
This PR implements a new method in node-core:
This works similarly to otel wrapping, registering the patch with IITM and RITM using the same semantics, more or less. It is a bit simplified for our requirements but should generally behave the same.
registerModuleWrapperis designed to be idempotent and to be callable multiple times. It will only actually patch once, calling it subsequently will update the options though - any options required in the patch should be resolved at runtime (!) via the passed-ingetOptions. (Why, you may ask yourself? Because we rely on this for preloading OTEL instrumentation, where we run the patch in--import preload.tsor similar but do not have the options yet, which are defined later ininit(), but should update the instrumentation config accordingly).I have tentatively implemented this for the existing express instrumentation. This is def. a breaking change so nothing we can ship now but it should show how this can/should eventually look.
Note that this should not be merged as it is a breaking change and only for showcase & discussion how this can/should work.