Skip to content

fix(e2e): Add op check to waitForTransaction in React Router e2e tests#20193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 3 commits into from
Apr 10, 2026
Merged

fix(e2e): Add op check to waitForTransaction in React Router e2e tests #20193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c40d1e
Initial plan
Copilot Apr 10, 2026
e82db66
fix(e2e): Add op check to waitForTransaction in React Router e2e tests
Copilot Apr 10, 2026
53e3ef0
fix(e2e): Run yarn format to fix formatting issues
Copilot Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...-applications/react-router-7-framework-custom/tests/performance/navigation.client.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,9 @@ import { APP_NAME } from '../constants';
test.describe('client - navigation performance', () => {
test('should create navigation transaction', async ({ page }) => {
const navigationPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/ssr';
return (
transactionEvent.transaction === '/performance/ssr' && transactionEvent.contexts?.trace?.op === 'navigation'
);
});

await page.goto(`/performance`); // pageload
Expand DownExpand Up@@ -56,7 +58,10 @@ test.describe('client - navigation performance', () => {

test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
return (
transactionEvent.transaction === '/performance/with/:param' &&
transactionEvent.contexts?.trace?.op === 'navigation'
);
});

await page.goto(`/performance`); // pageload
Expand Down
11 changes: 8 additions & 3 deletions ...st-applications/react-router-7-framework-custom/tests/performance/pageload.client.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ import { APP_NAME } from '../constants';
test.describe('client - pageload performance', () => {
test('should send pageload transaction', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance';
return transactionEvent.transaction === '/performance' && transactionEvent.contexts?.trace?.op === 'pageload';
});

await page.goto(`/performance`);
Expand DownExpand Up@@ -55,7 +55,10 @@ test.describe('client - pageload performance', () => {

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
return (
transactionEvent.transaction === '/performance/with/:param' &&
transactionEvent.contexts?.trace?.op === 'pageload'
);
});

await page.goto(`/performance/with/sentry`);
Expand DownExpand Up@@ -105,7 +108,9 @@ test.describe('client - pageload performance', () => {

test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/static';
return (
transactionEvent.transaction === '/performance/static' && transactionEvent.contexts?.trace?.op === 'pageload'
);
});

await page.goto(`/performance/static`);
Expand Down
9 changes: 7 additions & 2 deletions ...lications/react-router-7-framework-node-20-18/tests/performance/navigation.client.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,9 @@ import { APP_NAME } from '../constants';
test.describe('client - navigation performance', () => {
test('should create navigation transaction', async ({ page }) => {
const navigationPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/ssr';
return (
transactionEvent.transaction === '/performance/ssr' && transactionEvent.contexts?.trace?.op === 'navigation'
);
});

await page.goto(`/performance`); // pageload
Expand DownExpand Up@@ -56,7 +58,10 @@ test.describe('client - navigation performance', () => {

test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
return (
transactionEvent.transaction === '/performance/with/:param' &&
transactionEvent.contexts?.trace?.op === 'navigation'
);
});

await page.goto(`/performance`); // pageload
Expand Down
11 changes: 8 additions & 3 deletions ...pplications/react-router-7-framework-node-20-18/tests/performance/pageload.client.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ import { APP_NAME } from '../constants';
test.describe('client - pageload performance', () => {
test('should send pageload transaction', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance';
return transactionEvent.transaction === '/performance' && transactionEvent.contexts?.trace?.op === 'pageload';
});

await page.goto(`/performance`);
Expand DownExpand Up@@ -55,7 +55,10 @@ test.describe('client - pageload performance', () => {

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
return (
transactionEvent.transaction === '/performance/with/:param' &&
transactionEvent.contexts?.trace?.op === 'pageload'
);
});

await page.goto(`/performance/with/sentry`);
Expand DownExpand Up@@ -105,7 +108,9 @@ test.describe('client - pageload performance', () => {

test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/static';
return (
transactionEvent.transaction === '/performance/static' && transactionEvent.contexts?.trace?.op === 'pageload'
);
});

await page.goto(`/performance/static`);
Expand Down
5 changes: 4 additions & 1 deletion ...tions/react-router-7-framework-spa-node-20-18/tests/performance/navigation.client.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,10 @@ import { APP_NAME } from '../constants';
test.describe('client - navigation performance', () => {
test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
return (
transactionEvent.transaction === '/performance/with/:param' &&
transactionEvent.contexts?.trace?.op === 'navigation'
);
});

await page.goto(`/performance`); // pageload
Expand Down
7 changes: 5 additions & 2 deletions ...cations/react-router-7-framework-spa-node-20-18/tests/performance/pageload.client.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ import { APP_NAME } from '../constants';
test.describe('client - pageload performance', () => {
test('should send pageload transaction', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance';
return transactionEvent.transaction === '/performance' && transactionEvent.contexts?.trace?.op === 'pageload';
});

await page.goto(`/performance`);
Expand DownExpand Up@@ -55,7 +55,10 @@ test.describe('client - pageload performance', () => {

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
return (
transactionEvent.transaction === '/performance/with/:param' &&
transactionEvent.contexts?.trace?.op === 'pageload'
);
});

await page.goto(`/performance/with/sentry`);
Expand Down
5 changes: 4 additions & 1 deletion ...est-applications/react-router-7-framework-spa/tests/performance/navigation.client.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,10 @@ import { APP_NAME } from '../constants';
test.describe('client - navigation performance', () => {
test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
return (
transactionEvent.transaction === '/performance/with/:param' &&
transactionEvent.contexts?.trace?.op === 'navigation'
);
});

await page.goto(`/performance`); // pageload
Expand Down
7 changes: 5 additions & 2 deletions .../test-applications/react-router-7-framework-spa/tests/performance/pageload.client.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ import { APP_NAME } from '../constants';
test.describe('client - pageload performance', () => {
test('should send pageload transaction', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance';
return transactionEvent.transaction === '/performance' && transactionEvent.contexts?.trace?.op === 'pageload';
});

await page.goto(`/performance`);
Expand DownExpand Up@@ -55,7 +55,10 @@ test.describe('client - pageload performance', () => {

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
return (
transactionEvent.transaction === '/performance/with/:param' &&
transactionEvent.contexts?.trace?.op === 'pageload'
);
});

await page.goto(`/performance/with/sentry`);
Expand Down
14 changes: 11 additions & 3 deletions ...ts/test-applications/react-router-7-framework/tests/performance/navigation.client.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,9 @@ import { APP_NAME } from '../constants';
test.describe('client - navigation performance', () => {
test('should create navigation transaction', async ({ page }) => {
const navigationPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/ssr';
return (
transactionEvent.transaction === '/performance/ssr' && transactionEvent.contexts?.trace?.op === 'navigation'
);
});

await page.goto(`/performance`); // pageload
Expand DownExpand Up@@ -56,7 +58,10 @@ test.describe('client - navigation performance', () => {

test('should create navigation transaction when navigating with object `to` prop', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
return (
transactionEvent.transaction === '/performance/with/:param' &&
transactionEvent.contexts?.trace?.op === 'navigation'
);
});

await page.goto(`/performance`); // pageload
Expand DownExpand Up@@ -106,7 +111,10 @@ test.describe('client - navigation performance', () => {

test('should update navigation transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
return (
transactionEvent.transaction === '/performance/with/:param' &&
transactionEvent.contexts?.trace?.op === 'navigation'
);
});

await page.goto(`/performance`); // pageload
Expand Down
11 changes: 8 additions & 3 deletions ...ests/test-applications/react-router-7-framework/tests/performance/pageload.client.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ import { APP_NAME } from '../constants';
test.describe('client - pageload performance', () => {
test('should send pageload transaction', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance';
return transactionEvent.transaction === '/performance' && transactionEvent.contexts?.trace?.op === 'pageload';
});

await page.goto(`/performance`);
Expand DownExpand Up@@ -55,7 +55,10 @@ test.describe('client - pageload performance', () => {

test('should update pageload transaction for dynamic routes', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/with/:param';
return (
transactionEvent.transaction === '/performance/with/:param' &&
transactionEvent.contexts?.trace?.op === 'pageload'
);
});

await page.goto(`/performance/with/sentry`);
Expand DownExpand Up@@ -105,7 +108,9 @@ test.describe('client - pageload performance', () => {

test('should send pageload transaction for prerendered pages', async ({ page }) => {
const txPromise = waitForTransaction(APP_NAME, async transactionEvent => {
return transactionEvent.transaction === '/performance/static';
return (
transactionEvent.transaction === '/performance/static' && transactionEvent.contexts?.trace?.op === 'pageload'
);
});

await page.goto(`/performance/static`);
Expand Down
Loading