Uh oh!
There was an error while loading. Please reload this page.
test(openai): Use multi-message scenario in no-truncation test - #20194
Merged
Conversation
Ensures message popping doesn't occur when enableTruncation is false by testing with 3 messages instead of 1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Deps
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
nicohrubec
marked this pull request as ready for review
April 10, 2026 10:27
Contributor
size-limit report 📦
|
andreiborza
approved these changes
Apr 15, 2026
andreiborza
left a comment
Member
There was a problem hiding this comment.
Ah nice, thanks for catching this!
Uh oh!
There was an error while loading. Please reload this page.
mydea pushed a commit
that referenced
this pull request
Apr 15, 2026
let's expand the no-truncation scenario here to use multiple input messages to ensure no message popping is applied to align this with other scenarios Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let's expand the no-truncation scenario here to use multiple input messages to ensure no message popping is applied to align this with other scenarios