Uh oh!
There was an error while loading. Please reload this page.
test(browser): Fix flaky sessions route-lifecycle test + upgrade axios - #20197
Merged
Conversation
…ing timeout-based approach with sequential waitForSession The test was flaky because getMultipleSentryEnvelopeRequests starts a 4000ms timeout before page.goto, so the timeout could expire before all 4 session envelopes arrived. Replaced with the robust sequential waitForSession pattern (used in start-session, initial-scope, user tests) that deterministically waits for each session individually. Co-Authored-By: Claude <noreply@anthropic.com> Agent-Logs-Url: https://github.com/getsentry/sentry-javascript/sessions/443b2c75-cf14-4a37-8212-6a532959da82 Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
Fixes CVE: Axios NO_PROXY Hostname Normalization Bypass Leads to SSRF. Co-Authored-By: Claude <noreply@anthropic.com> Agent-Logs-Url: https://github.com/getsentry/sentry-javascript/sessions/443b2c75-cf14-4a37-8212-6a532959da82 Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix flaky Playwright ESM sessions after navigationfix(browser-tests): fix flaky sessions route-lifecycle test + upgrade axiosApr 10, 2026
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Deps
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Deps
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
marked this pull request as ready for review
April 10, 2026 13:12
Lms24
approved these changes
Apr 14, 2026
Lms24
left a comment
Member
There was a problem hiding this comment.
lgtm, technically we should split the axios stuff out but I don't care tbh
nicohrubec
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sessions/route-lifecyclePlaywright test flakes becausegetMultipleSentryEnvelopeRequestsstarts a 4000ms timeout beforepage.goto(). By the time page load + selector wait + 3 sequential clicks complete, the timeout can expire with only 3 of 4 expectedinitsessions captured.This PR replaces the timeout-based collection approach with sequential
waitForSessioncalls — the same deterministic pattern already used instart-session,initial-scope, andusersession tests: